GNU bug report logs - #66711
treesit-default-defun-skipper moves to bol if there is any whitespace

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 66711 in the body.
You can then email your comments to 66711 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dominik Honnef <dominik <at> honnef.co>
To: bug-gnu-emacs <at> gnu.org
Subject: treesit-default-defun-skipper moves to bol if there is any whitespace
Date: Mon, 23 Oct 2023 19:41:24 +0200

treesit-default-defun-skipper has the following bit of code:

    ;; Moving backward, but there are some whitespace (and only
    ;; whitespace) between point and BOL: go back to BOL.
    ((looking-back (rx (+ (or " " "\t")))
                   (line-beginning-position))
     (beginning-of-line))))

However, as written, the regexp matches if there is any whitespace
before point, not if there is only whitespace.

Message #8 received at 66711 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dominik Honnef <dominik <at> honnef.co>, Yuan Fu <casouri <at> gmail.com>
Cc: 66711 <at> debbugs.gnu.org
Subject: Re: bug#66711: treesit-default-defun-skipper moves to bol if there is
 any whitespace
Date: Sun, 29 Oct 2023 13:53:27 +0200

> From: Dominik Honnef <dominik <at> honnef.co>
> Date: Mon, 23 Oct 2023 19:41:24 +0200
> 
> treesit-default-defun-skipper has the following bit of code:
> 
>     ;; Moving backward, but there are some whitespace (and only
>     ;; whitespace) between point and BOL: go back to BOL.
>     ((looking-back (rx (+ (or " " "\t")))
>                    (line-beginning-position))
>      (beginning-of-line))))
> 
> However, as written, the regexp matches if there is any whitespace
> before point, not if there is only whitespace.

Yuan, any comments?

Message #11 received at 66711 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: casouri <at> gmail.com
Cc: 66711 <at> debbugs.gnu.org, dominik <at> honnef.co
Subject: Re: bug#66711: treesit-default-defun-skipper moves to bol if there is
 any whitespace
Date: Sat, 18 Nov 2023 10:36:47 +0200

Ping!  Yuan, any comments?

> Cc: 66711 <at> debbugs.gnu.org
> Date: Sun, 29 Oct 2023 13:53:27 +0200
> From: Eli Zaretskii <eliz <at> gnu.org>
> 
> > From: Dominik Honnef <dominik <at> honnef.co>
> > Date: Mon, 23 Oct 2023 19:41:24 +0200
> > 
> > treesit-default-defun-skipper has the following bit of code:
> > 
> >     ;; Moving backward, but there are some whitespace (and only
> >     ;; whitespace) between point and BOL: go back to BOL.
> >     ((looking-back (rx (+ (or " " "\t")))
> >                    (line-beginning-position))
> >      (beginning-of-line))))
> > 
> > However, as written, the regexp matches if there is any whitespace
> > before point, not if there is only whitespace.
> 
> Yuan, any comments?
> 
> 
> 
> 

Message #16 received at 66711-done <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 66711-done <at> debbugs.gnu.org, dominik <at> honnef.co
Subject: Re: bug#66711: treesit-default-defun-skipper moves to bol if there is
 any whitespace
Date: Sun, 10 Dec 2023 17:45:18 -0800

On 11/18/23 12:36 AM, Eli Zaretskii wrote:
> Ping!  Yuan, any comments?
>
>> Cc: 66711 <at> debbugs.gnu.org
>> Date: Sun, 29 Oct 2023 13:53:27 +0200
>> From: Eli Zaretskii <eliz <at> gnu.org>
>>
>>> From: Dominik Honnef <dominik <at> honnef.co>
>>> Date: Mon, 23 Oct 2023 19:41:24 +0200
>>>
>>> treesit-default-defun-skipper has the following bit of code:
>>>
>>>      ;; Moving backward, but there are some whitespace (and only
>>>      ;; whitespace) between point and BOL: go back to BOL.
>>>      ((looking-back (rx (+ (or " " "\t")))
>>>                     (line-beginning-position))
>>>       (beginning-of-line))))
>>>
>>> However, as written, the regexp matches if there is any whitespace
>>> before point, not if there is only whitespace.
>> Yuan, any comments?

Thanks, Dominik and Eli. I applied a patch that should fix the regexp.

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.