GNU bug report logs - #66747
[PATCH] gnu: font-google-noto: Update to 23.10.1.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 66747 in the body.
You can then email your comments to 66747 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Bruno Victal <mirai <at> makinata.eu>
To: guix-patches <at> gnu.org
Cc: Bruno Victal <mirai <at> makinata.eu>
Subject: [PATCH] gnu: font-google-noto: Update to 23.10.1.
Date: Wed, 25 Oct 2023 14:25:37 +0100

[1] indicates that [2] is the new _distribution_ upstream for Noto fonts.

[1]: <https://github.com/notofonts/noto-fonts>
[2]: <https://github.com/notofonts/notofonts.github.io>

* gnu/packages/fonts.scm (font-google-noto): Switch upstream url and
method. Update to 23.10.1, released at 2023-10-01T00:25:14Z.

Change-Id: I242710336ec81489f9800b68416f45c57d28b2bd
---
 gnu/packages/fonts.scm | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index 4254408e0f..eca84db7fe 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -1015,15 +1015,16 @@ (define-public font-gnu-unifont
 (define-public font-google-noto
   (package
     (name "font-google-noto")
-    (version "20171025")
+    (version "23.10.1")
     (source
      (origin
-       (method url-fetch/zipbomb)
-       (uri (string-append "https://noto-website-2.storage.googleapis.com/"
-                           "pkgs/Noto-hinted.zip"))
-       (file-name (string-append name "-" version ".zip"))
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/notofonts/notofonts.github.io")
+             (commit (string-append "noto-monthly-release-" version))))
+       (file-name (git-file-name name version))
        (sha256
-        (base32 "1bp42whyin7xcgmrbnfvz3rvd98xmxaz3ywqybbjmqzwaa9llyw3"))))
+        (base32 "1fab73hmr9gpmz6fmmxrb6m4g7lwhfzjx51g433pd1vp1srs8jgx"))))
     (build-system font-build-system)
     (home-page "https://www.google.com/get/noto/")
     (synopsis "Fonts to cover all languages")

base-commit: aabfddbe8bc16fa82067e88e7d79c8c1bc802414
-- 
2.41.0

Message #8 received at 66747 <at> debbugs.gnu.org (full text, mbox):

From: Hilton Chain <hako <at> ultrarare.space>
To: 66747 <at> debbugs.gnu.org
Cc: Bruno Victal <mirai <at> makinata.eu>
Subject: [PATCH v2] gnu: font-google-noto: Update to 23.11.1.
Date: Sat,  4 Nov 2023 19:01:13 +0800

From: Bruno Victal <mirai <at> makinata.eu>

[1] indicates that [2] is the new _distribution_ upstream for Noto fonts.

[1]: <https://github.com/notofonts/noto-fonts>
[2]: <https://github.com/notofonts/notofonts.github.io>

* gnu/packages/fonts.scm (font-google-noto): Update to 23.11.1.
[source]<method>: Switch to git-fetch.

Change-Id: I242710336ec81489f9800b68416f45c57d28b2bd
---

Updated the patch since new version is out. :)

 gnu/packages/fonts.scm | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index 4254408e0f..22a42d227f 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -1015,15 +1015,16 @@ (define-public font-gnu-unifont
 (define-public font-google-noto
   (package
     (name "font-google-noto")
-    (version "20171025")
+    (version "23.11.1")
     (source
      (origin
-       (method url-fetch/zipbomb)
-       (uri (string-append "https://noto-website-2.storage.googleapis.com/"
-                           "pkgs/Noto-hinted.zip"))
-       (file-name (string-append name "-" version ".zip"))
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/notofonts/notofonts.github.io")
+             (commit (string-append "noto-monthly-release-" version))))
+       (file-name (git-file-name name version))
        (sha256
-        (base32 "1bp42whyin7xcgmrbnfvz3rvd98xmxaz3ywqybbjmqzwaa9llyw3"))))
+        (base32 "0vvxhky35l4i0ha60yw0gj26f3v33hpf2zax17yyj16mww4cn4d8"))))
     (build-system font-build-system)
     (home-page "https://www.google.com/get/noto/")
     (synopsis "Fonts to cover all languages")

base-commit: f54f36b363a86bb033275e3a0594974d3d91bd53
-- 
2.41.0

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Hilton Chain <hako <at> ultrarare.space>
Cc: 66747-done <at> debbugs.gnu.org, guix-patches <at> gnu.org,
 Bruno Victal <mirai <at> makinata.eu>, Zhu Zihao <all_but_last <at> 163.com>,
 宋文武 <iyzsong <at> envs.net>
Subject: Re: [bug#66747] [PATCH v2] gnu: font-google-noto: Update to 23.11.1.
Date: Sun, 05 Nov 2023 18:28:23 +0000

[Message part 1 (text/plain, inline)]

Hilton Chain via Guix-patches via <guix-patches <at> gnu.org> writes:

> From: Bruno Victal <mirai <at> makinata.eu>
>
> [1] indicates that [2] is the new _distribution_ upstream for Noto fonts.
>
> [1]: <https://github.com/notofonts/noto-fonts>
> [2]: <https://github.com/notofonts/notofonts.github.io>
>
> * gnu/packages/fonts.scm (font-google-noto): Update to 23.11.1.
> [source]<method>: Switch to git-fetch.
>
> Change-Id: I242710336ec81489f9800b68416f45c57d28b2bd
> ---
>
> Updated the patch since new version is out. :)
>
>  gnu/packages/fonts.scm | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)

Thanks both, I've pushed this to master as
913d52952b0a893910657f88390f0d94a948edbc.

Chris

[signature.asc (application/pgp-signature, inline)]

Message #19 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Hugo Buddelmeijer <hugo <at> buddelmeijer.nl>
To: guix-patches <at> gnu.org
Cc: mirai <at> makinata.eu, mail <at> cbaines.net
Subject: [bug#66747] [PATCH v2] gnu: font-google-noto: Update to 23.11.1.
Date: Wed, 29 Nov 2023 15:01:39 +0100

[Message part 1 (text/plain, inline)]

Chris writes:

> Hilton Chain via Guix-patches via <guix-patches <at> gnu.org> writes:
>> From: Bruno Victal <mirai <at> makinata.eu>
>>
>> [1] indicates that [2] is the new _distribution_ upstream for Noto fonts.
>>
>> [1]: <https://github.com/notofonts/noto-fonts>
>> [2]: <https://github.com/notofonts/notofonts.github.io>
>>
>> * gnu/packages/fonts.scm (font-google-noto): Update to 23.11.1.
>> [source]<method>: Switch to git-fetch.
>>
>> Change-Id: I242710336ec81489f9800b68416f45c57d28b2bd
>> ---
>>
>> Updated the patch since new version is out. :)
>>
>>  gnu/packages/fonts.scm | 13 +++++++------
>>  1 file changed, 7 insertions(+), 6 deletions(-)
>
> Thanks both, I've pushed this to master as
> 913d52952b0a893910657f88390f0d94a948edbc.

This change seems to have broken the fonts in sway (wayland compositor).

This is my Sway status bar:

$ cat .config/sway/status.sh
DATE=$(date +'%Y-%m-%d %H:%M:%S')
BATTERY=$(cat /sys/class/power_supply/BAT0/capacity)
echo "🔋${BATTERY} 📅 ${DATE}"

Attached are screenshots of how it looks: goodtofu3.png with the old
font-google-noto, and badtofu3.png with the new font-google-noto.

Also looks wrong in foot, xterm, termite, uxterm, emacs, icecat, gimp;
only tested on sway.

I've not yet investigated the issue further. The next step for me
would be to install the old font-google-noto through an inferior
channel to to indeed verify that this change is indeed the culprit.

Hugo

[badtofu3.png (image/png, attachment)]

[goodtofu3.png (image/png, attachment)]

Message #22 received at 66747 <at> debbugs.gnu.org (full text, mbox):

From: Bruno Victal <mirai <at> makinata.eu>
To: Hugo Buddelmeijer <hugo <at> buddelmeijer.nl>
Cc: mail <at> cbaines.net, 66747 <at> debbugs.gnu.org
Subject: Re: [bug#66747] [PATCH v2] gnu: font-google-noto: Update to 23.11.1.
Date: Wed, 29 Nov 2023 18:35:48 +0000

[Message part 1 (text/plain, inline)]

Hi Hugo,

On 2023-11-29 14:01, Hugo Buddelmeijer wrote:
> This change seems to have broken the fonts in sway (wayland compositor).
> 
> This is my Sway status bar:
> 
> $ cat .config/sway/status.sh
> DATE=$(date +'%Y-%m-%d %H:%M:%S')
> BATTERY=$(cat /sys/class/power_supply/BAT0/capacity)
> echo "🔋${BATTERY} 📅 ${DATE}"

I didn't check with the old (and ancient, which had
U+2026 … HORIZONTAL ELLIPSIS broken) font-google-noto package though
I can confirm that I'm seeing TOFU when I lookup these characters
with 'gucharmap' command for 'Noto Sans Mono'.

Could you report this to upstream via [1] as indicated in the
README.md [2]?

[1]: <https://notofonts.github.io/reporter.html>
[2]: <https://github.com/notofonts/notofonts.github.io>

-- 
Furthermore, I consider that nonfree software must be eradicated.

Cheers,
Bruno.

[OpenPGP_signature.asc (application/pgp-signature, attachment)]

Message #25 received at 66747 <at> debbugs.gnu.org (full text, mbox):

From: Hugo Buddelmeijer <hugo <at> buddelmeijer.nl>
To: Bruno Victal <mirai <at> makinata.eu>
Cc: mail <at> cbaines.net, 66747 <at> debbugs.gnu.org
Subject: Re: [bug#66747] [PATCH v2] gnu: font-google-noto: Update to 23.11.1.
Date: Wed, 29 Nov 2023 23:19:18 +0100

It seems that the emoji are now in the font-google-noto-emoji package.
Installing that package worked for me: now the emoji are in color in
foot (wayland terminal), while earlier they only were in color in the
status bar.

So maybe everything works as intended. I was surprised to see tofu
because I expected that there would be 1 ultimate noto font, but maybe
that was naive.

On Wed, 29 Nov 2023 at 19:35, Bruno Victal <mirai <at> makinata.eu> wrote:
>
> Hi Hugo,
>
> On 2023-11-29 14:01, Hugo Buddelmeijer wrote:
> > This change seems to have broken the fonts in sway (wayland compositor).
> >
> > This is my Sway status bar:
> >
> > $ cat .config/sway/status.sh
> > DATE=$(date +'%Y-%m-%d %H:%M:%S')
> > BATTERY=$(cat /sys/class/power_supply/BAT0/capacity)
> > echo "🔋${BATTERY} 📅 ${DATE}"
>
> I didn't check with the old (and ancient, which had
> U+2026 … HORIZONTAL ELLIPSIS broken) font-google-noto package though
> I can confirm that I'm seeing TOFU when I lookup these characters
> with 'gucharmap' command for 'Noto Sans Mono'.
>
> Could you report this to upstream via [1] as indicated in the
> README.md [2]?
>
> [1]: <https://notofonts.github.io/reporter.html>
> [2]: <https://github.com/notofonts/notofonts.github.io>
>
> --
> Furthermore, I consider that nonfree software must be eradicated.
>
> Cheers,
> Bruno.
>

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.