GNU bug report logs - #66832
[PATCH] build-system: clojure: Use the standard error regarding cross builds.

Previous Next

Package: guix-patches;

Reported by: Christopher Baines <mail <at> cbaines.net>

Date: Mon, 30 Oct 2023 08:45:01 UTC

Severity: normal

Tags: patch

Done: Christopher Baines <mail <at> cbaines.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 66832 in the body.
You can then email your comments to 66832 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#66832; Package guix-patches. (Mon, 30 Oct 2023 08:45:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Christopher Baines <mail <at> cbaines.net>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Mon, 30 Oct 2023 08:45:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] build-system: clojure: Use the standard error regarding cross
 builds.
Date: Mon, 30 Oct 2023 08:43:34 +0000

Rather than raising an error in the build system.

* guix/build-system/clojure.scm (lower): Return #f for cross builds, rather
than calling error.

Change-Id: Id97c8f5140f55fe2c52ccb0db36fd993922c6a7e
---
 guix/build-system/clojure.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/guix/build-system/clojure.scm b/guix/build-system/clojure.scm
index fb897356bc..037fcaf21d 100644
--- a/guix/build-system/clojure.scm
+++ b/guix/build-system/clojure.scm
@@ -83,8 +83,8 @@ (define* (lower name
                             #:clojure #:jdk #:zip)))
 
     (if target
-        (error "No cross-compilation for clojure-build-system yet: LOWER"
-               target) ; FIXME
+        #f                              ; FIXME: No cross-compilation for
+                                        ; clojure-build-system yet
         (bag (name name)
              (system system)
              (host-inputs `(,@(if source

base-commit: 642769707c05dc1dd5674d60cd3b55d77b35c9d9
-- 
2.41.0
Information forwarded to guix-patches <at> gnu.org:
bug#66832; Package guix-patches. (Wed, 15 Nov 2023 17:21:02 GMT) Full text and rfc822 format available.

Message #8 received at 66832 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 66832 <at> debbugs.gnu.org
Subject: Re: [bug#66832] [PATCH] build-system: clojure: Use the standard
 error regarding cross builds.
Date: Wed, 15 Nov 2023 18:19:51 +0100

Christopher Baines <mail <at> cbaines.net> skribis:

> Rather than raising an error in the build system.
>
> * guix/build-system/clojure.scm (lower): Return #f for cross builds, rather
> than calling error.
>
> Change-Id: Id97c8f5140f55fe2c52ccb0db36fd993922c6a7e

LGTM!
Reply sent to Christopher Baines <mail <at> cbaines.net>:
You have taken responsibility. (Mon, 20 Nov 2023 15:12:01 GMT) Full text and rfc822 format available.
Notification sent to Christopher Baines <mail <at> cbaines.net>:
bug acknowledged by developer. (Mon, 20 Nov 2023 15:12:02 GMT) Full text and rfc822 format available.

Message #13 received at 66832-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 66832-done <at> debbugs.gnu.org
Subject: Re: [bug#66832] [PATCH] build-system: clojure: Use the standard
 error regarding cross builds.
Date: Mon, 20 Nov 2023 15:10:14 +0000

[Message part 1 (text/plain, inline)]
Ludovic Courtès <ludo <at> gnu.org> writes:

> Christopher Baines <mail <at> cbaines.net> skribis:
>
>> Rather than raising an error in the build system.
>>
>> * guix/build-system/clojure.scm (lower): Return #f for cross builds, rather
>> than calling error.
>>
>> Change-Id: Id97c8f5140f55fe2c52ccb0db36fd993922c6a7e
>
> LGTM!

Great, I've pushed this to master as
98ae8076435c74f90ad8ad30557963d2caa273c2.

Chris

[signature.asc (application/pgp-signature, inline)]
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 19 Dec 2023 12:24:05 GMT) Full text and rfc822 format available.
This bug report was last modified 1 year and 142 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.