GNU bug report logs - #66832
[PATCH] build-system: clojure: Use the standard error regarding cross builds.

Message received at 66832 <at> debbugs.gnu.org:

Received: (at 66832) by debbugs.gnu.org; 15 Nov 2023 17:20:05 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Nov 15 12:20:04 2023
Received: from localhost ([127.0.0.1]:53510 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r3JYa-0006b4-Jv
	for submit <at> debbugs.gnu.org; Wed, 15 Nov 2023 12:20:04 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:45762)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1r3JYY-0006Zq-NR
 for 66832 <at> debbugs.gnu.org; Wed, 15 Nov 2023 12:20:03 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1r3JYR-0002qf-N7; Wed, 15 Nov 2023 12:19:56 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To:
 From; bh=diC/fhJoFsv7tmYBz4q2jyZuY2vt8N7sifGXKbPC9GQ=; b=oA3r+cohxk+3WZi/HHlu
 G+Ze3NFGy2My8Ziyr4jtEZDVS0KN2vl1SCtfHZoSx1itmUBPq0J7mJwPjKVhLhQRHAomJ3Q0BzljO
 FwcV2yXGhcp4NS6a8B1KvOdP+L0tqWHbLuGFOBMsoF3bTiYh10mIHt62cXoWXg+QTeIwpYIuQGa4t
 Aqpt0FeMJIi33kS4HSxFHIFWBkF+4/ArlCkfVTFmErX/Ezx4yhgyzM4d4S79OmnZxR+LWAgmZuA3K
 1jblC7LzLW7xTSut+w5HTl25zrSf/w+tqO4jWbk+bVwYHek0b2ypY8k1+UyiyOh2z5dYQtoWFMz2G
 COUz5CqCqMAJ9Q==;
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
To: Christopher Baines <mail@HIDDEN>
Subject: Re: [bug#66832] [PATCH] build-system: clojure: Use the standard
 error regarding cross builds.
In-Reply-To: <3217ef7510266e353bae0e9f44c7d4a73517c4c9.1698655414.git.mail@HIDDEN>
 (Christopher Baines's message of "Mon, 30 Oct 2023 08:43:34 +0000")
References: <3217ef7510266e353bae0e9f44c7d4a73517c4c9.1698655414.git.mail@HIDDEN>
Date: Wed, 15 Nov 2023 18:19:51 +0100
Message-ID: <87il637x3c.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 66832
Cc: 66832 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Christopher Baines <mail@HIDDEN> skribis:

> Rather than raising an error in the build system.
>
> * guix/build-system/clojure.scm (lower): Return #f for cross builds, rather
> than calling error.
>
> Change-Id: Id97c8f5140f55fe2c52ccb0db36fd993922c6a7e

LGTM!

Message received at submit <at> debbugs.gnu.org:

Received: (at submit) by debbugs.gnu.org; 30 Oct 2023 08:44:28 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Oct 30 04:44:28 2023
Received: from localhost ([127.0.0.1]:44212 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qxNsq-0005kK-1K
	for submit <at> debbugs.gnu.org; Mon, 30 Oct 2023 04:44:28 -0400
Received: from lists.gnu.org ([2001:470:142::17]:43860)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mail@HIDDEN>) id 1qxNsn-0005k7-9Q
 for submit <at> debbugs.gnu.org; Mon, 30 Oct 2023 04:44:27 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <mail@HIDDEN>) id 1qxNs9-0006gC-EA
 for guix-patches@HIDDEN; Mon, 30 Oct 2023 04:43:45 -0400
Received: from mira.cbaines.net ([2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27])
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <mail@HIDDEN>) id 1qxNs4-0005WU-R6
 for guix-patches@HIDDEN; Mon, 30 Oct 2023 04:43:42 -0400
Received: from localhost (unknown [217.110.181.146])
 by mira.cbaines.net (Postfix) with ESMTPSA id D132E27BBE2
 for <guix-patches@HIDDEN>; Mon, 30 Oct 2023 08:43:35 +0000 (GMT)
Received: from localhost (localhost [local])
 by localhost (OpenSMTPD) with ESMTPA id c54b318d
 for <guix-patches@HIDDEN>; Mon, 30 Oct 2023 08:43:35 +0000 (UTC)
From: Christopher Baines <mail@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] build-system: clojure: Use the standard error regarding cross
 builds.
Date: Mon, 30 Oct 2023 08:43:34 +0000
Message-ID: <3217ef7510266e353bae0e9f44c7d4a73517c4c9.1698655414.git.mail@HIDDEN>
X-Mailer: git-send-email 2.41.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27;
 envelope-from=mail@HIDDEN; helo=mira.cbaines.net
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.9 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)

Rather than raising an error in the build system.

* guix/build-system/clojure.scm (lower): Return #f for cross builds, rather
than calling error.

Change-Id: Id97c8f5140f55fe2c52ccb0db36fd993922c6a7e
---
 guix/build-system/clojure.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/guix/build-system/clojure.scm b/guix/build-system/clojure.scm
index fb897356bc..037fcaf21d 100644
--- a/guix/build-system/clojure.scm
+++ b/guix/build-system/clojure.scm
@@ -83,8 +83,8 @@ (define* (lower name
                             #:clojure #:jdk #:zip)))
 
     (if target
-        (error "No cross-compilation for clojure-build-system yet: LOWER"
-               target) ; FIXME
+        #f                              ; FIXME: No cross-compilation for
+                                        ; clojure-build-system yet
         (bag (name name)
              (system system)
              (host-inputs `(,@(if source

base-commit: 642769707c05dc1dd5674d60cd3b55d77b35c9d9
-- 
2.41.0