Received: (at 66846) by debbugs.gnu.org; 31 Oct 2023 15:29:00 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Oct 31 11:28:59 2023 Received: from localhost ([127.0.0.1]:48997 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qxqfr-0007lC-K5 for submit <at> debbugs.gnu.org; Tue, 31 Oct 2023 11:28:59 -0400 Received: from smtp-27.smtpout.orange.fr ([80.12.242.27]:52429 helo=smtp.smtpout.orange.fr) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <da_vid@HIDDEN>) id 1qxqfp-0007l1-Kg for 66846 <at> debbugs.gnu.org; Tue, 31 Oct 2023 11:28:58 -0400 Received: from [192.168.1.15] ([2.7.71.181]) by smtp.orange.fr with ESMTPA id xqfFqZInSaLS1xqfGqUHRh; Tue, 31 Oct 2023 16:28:22 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1698766102; bh=dxi0vCFJp487BnGx9rXsf0bmKQ/1xgyCEcShYF1KwxM=; h=Date:Subject:From:To:References:In-Reply-To; b=Y/swVYI0BbLC2omZDqi+d/WoPBTtPIlFDRHlJNg9+3Z0hwcojUeA6b2CXeJUISOat 0InDBEHqHHlpzW7YdBe+j8ia6FrpZvK5dt9z4jZ/YKf7Sfg27Un90lFV7aI3/OvjKd QlHOqt6gtF0Rh5s5hM3UgJLrj752/YofPuf8bL0t2Ql1avJg1B7FPMbMyFiPa74Xi5 CnRO6QgkrGIsrpW0jyTI1F7U7QXjrg8dARjE7E8ywDnI0cbvzmEl/7qFtvngzPrpV3 3YPwa+CwXzmchAtAOM19wkhJiNG26tFG4LW74BK7aTBEDFU3tRQ4OWX772x19dyWdX ELh5iGFepNing== X-ME-Helo: [192.168.1.15] X-ME-Auth: ZGFfdmlkQHdhbmFkb28uZnI= X-ME-Date: Tue, 31 Oct 2023 16:28:22 +0100 X-ME-IP: 2.7.71.181 Message-ID: <89c6f6a5-d35e-4363-a04a-995dab69a361@HIDDEN> Date: Tue, 31 Oct 2023 16:28:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: 30.0.50; unexpected behavior of icon with non-existing image file? Content-Language: fr, en-US From: David Ponce <da_vid@HIDDEN> To: 66846 <at> debbugs.gnu.org References: <6a6a88f4-dc7c-44a4-9f09-5b3f184df971@HIDDEN> In-Reply-To: <6a6a88f4-dc7c-44a4-9f09-5b3f184df971@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66846 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) In fact, I wonder if a better implementation of the `icons--create' method could be to delegate image creation to `find-image'? Something like this: (cl-defmethod icons--create ((_type (eql 'image)) icon keywords) (when-let ((image (find-image `(( :file ,icon ,@(append (if-let ((val (plist-get keywords :height))) (list :height (if (eq val 'line) (window-default-line-height) val))) (if-let ((val (plist-get keywords :width))) (list :width (if (eq val 'font) (default-font-width) val))) '(:scale 1) (if-let ((val (plist-get keywords :rotation))) (list :rotation val)) (if-let ((val (plist-get keywords :margin))) (list :margin val)) (list :ascent (or (plist-get keywords :ascent) 'center)))))))) (propertize " " 'display image)))
bug-gnu-emacs@HIDDEN
:bug#66846
; Package emacs
.
Full text available.Received: (at submit) by debbugs.gnu.org; 31 Oct 2023 12:30:36 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Oct 31 08:30:36 2023 Received: from localhost ([127.0.0.1]:47688 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qxntE-0002YB-51 for submit <at> debbugs.gnu.org; Tue, 31 Oct 2023 08:30:36 -0400 Received: from lists.gnu.org ([2001:470:142::17]:56160) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <da_vid@HIDDEN>) id 1qxntB-0002Xt-0T for submit <at> debbugs.gnu.org; Tue, 31 Oct 2023 08:30:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <da_vid@HIDDEN>) id 1qxnsV-0007wo-KW for bug-gnu-emacs@HIDDEN; Tue, 31 Oct 2023 08:29:51 -0400 Received: from smtp-27.smtpout.orange.fr ([80.12.242.27] helo=smtp.smtpout.orange.fr) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <da_vid@HIDDEN>) id 1qxnsT-0007AL-4Q for bug-gnu-emacs@HIDDEN; Tue, 31 Oct 2023 08:29:51 -0400 Received: from [192.168.1.15] ([2.7.71.181]) by smtp.orange.fr with ESMTPA id xnsNqdsNh4FJ9xnsNquQMf; Tue, 31 Oct 2023 13:29:44 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1698755384; bh=1jTLg2IBQ8NGR1q1zOIJBPMtEkePyLfLWlbO8Hf2h+E=; h=Date:To:From:Subject; b=lQfXUka0sidS89rAg9/a6es/+V5KCL0gl4SQ5c5WIFtYlpcAqlAK5p9QQYqdLBFvk iP9aErpd6jXvpr33ooVHbhX+DRjWES6Qb6CBmUuNmPscuvInjfzwVhVBll/7VOzwvr MbMhwfc6I3vjKoc91omqZmcw7zueHcRmNIZ3C7JXMuLbtLT2fwQeG9KYghu1MS87ZM pyGac62guWnUHBZ0eT1nRH3JHi/klPzwiSxS9vUNpAA9pOeaH0WOMXTGL5lwgRS7Ls MHp/fm80OLtXF8fUW2ZgPmz9Lc222/Egi54TC6x3USG6+tXmVAiimtPi+hwU6cNfmh Gi1a8J4ePGBgQ== X-ME-Helo: [192.168.1.15] X-ME-Auth: ZGFfdmlkQHdhbmFkb28uZnI= X-ME-Date: Tue, 31 Oct 2023 13:29:44 +0100 X-ME-IP: 2.7.71.181 Message-ID: <6a6a88f4-dc7c-44a4-9f09-5b3f184df971@HIDDEN> Date: Tue, 31 Oct 2023 13:29:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: fr, en-US To: bug-gnu-emacs@HIDDEN From: David Ponce <da_vid@HIDDEN> Subject: 30.0.50; unexpected behavior of icon with non-existing image file? Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=80.12.242.27; envelope-from=da_vid@HIDDEN; helo=smtp.smtpout.orange.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.3 (/) Hello, I found a possible unexpected behavior with image in icon spec. Here are 2 small recipes that illustrate this. In both cases the image doesn't exist and maybe `icon-string' should return the text value of the icon, instead of failing like illustrated below (emacs -Q): ;; TEST 1 with relative file name. ;; Raise a wrong-type-argument error instead of inserting the text ;; "test". (define-icon test nil '((image "does-not-exist.svg") (text "test")) "Test icon." :version "30") (insert (icon-string 'test)) Debugger entered--Lisp error: (wrong-type-argument stringp nil) string-match("\\.png\\'" nil nil t) image-supported-file-p(nil) ... ;; TEST 2 with absolute file name. ;; Insert an invalid image instead of the text "test". (define-icon test1 nil '((image "/does-not-exist.svg") (text "test")) "Test1 icon." :version "30") ((button custom-icon) (test1 custom-icon)) (insert (icon-string 'test1)) nil Please find a possible fix in the below patch to icons.el: diff --git a/lisp/emacs-lisp/icons.el b/lisp/emacs-lisp/icons.el index 9a6d26243c7..dec8eaa9fac 100644 --- a/lisp/emacs-lisp/icons.el +++ b/lisp/emacs-lisp/icons.el @@ -188,10 +188,11 @@ icons--merge-spec (cl-defmethod icons--create ((_type (eql 'image)) icon keywords) (let ((file (if (file-name-absolute-p icon) - icon + (and (file-readable-p icon) icon) (and (fboundp 'image-search-load-path) (image-search-load-path icon))))) - (and (display-images-p) + (and file + (display-images-p) (fboundp 'image-supported-file-p) (image-supported-file-p file) (propertize In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.17.8) Repository revision: ecc8870981ef1a802f9504b1d0f261d19ab372b1 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12014000 System Description: Fedora Linux 38 (KDE Plasma) Configured using: 'configure PKG_CONFIG_PATH=/usr/local/lib/pkgconfig:/usr/lib/pkgconfig' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings: value of $LC_TIME: fr_FR.utf8 value of $LANG: fr_FR.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t minibuffer-regexp-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo gtk x-toolkit xinput2 x multi-tty move-toolbar make-network-process emacs) Memory information: ((conses 16 37932 10514) (symbols 48 5212 0) (strings 32 13264 1275) (string-bytes 1 378221) (vectors 16 10360) (vector-slots 8 157502 10085) (floats 8 38 21) (intervals 56 220 0) (buffers 992 10))
David Ponce <da_vid@HIDDEN>
:bug-gnu-emacs@HIDDEN
.
Full text available.bug-gnu-emacs@HIDDEN
:bug#66846
; Package emacs
.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.