GNU bug report logs - #66924
[PATCH] gnu: emacs-evil-anzu: Update to 0.03-0.d1e98ee.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 66924 in the body.
You can then email your comments to 66924 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Rostislav Svoboda <rostislav.svoboda <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Rostislav Svoboda <Rostislav.Svoboda <at> gmail.com>
Subject: [PATCH] gnu: emacs-evil-anzu: Update to 0.03-0.d1e98ee.
Date: Fri,  3 Nov 2023 23:18:46 +0100

The github url redirects from syohex/emacs-evil-anzu to emacsorphanage/evil-anzu.

* gnu/packages/emacs-xyz.scm (emacs-evil-anzu): Update to 0.03-0.d1e98ee.

Change-Id: Iff78e22c6a3c0c90e1dc4c24700bfc9e499dd132
---
 gnu/packages/emacs-xyz.scm | 40 ++++++++++++++++++++------------------
 1 file changed, 21 insertions(+), 19 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 07a9d4cbe7..a8a5bbed43 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -22283,26 +22283,28 @@ (define-public emacs-psc-ide
       (license license:gpl3+))))
 
 (define-public emacs-evil-anzu
-  (package
-    (name "emacs-evil-anzu")
-    (version "0.03")
-    (source
-     (origin
-       (method git-fetch)
-       (uri (git-reference
-             (url "https://github.com/syohex/emacs-evil-anzu")
-             (commit version)))
-       (file-name (git-file-name name version))
-       (sha256
-        (base32 "0lw7fg4gqwj30r0l6k2ni36sxqkf65zf0d0z3rxnpwbxlf8dlkrr"))))
-    (build-system emacs-build-system)
-    (propagated-inputs
-     (list emacs-evil emacs-anzu))
-    (home-page "https://github.com/syohex/emacs-evil-anzu")
-    (synopsis "Anzu for evil-mode")
-    (description "@code{anzu} provides a minor mode that displays the current
+  (let ((commit "d1e98ee6976437164627542909a25c6946497899")
+        (revision "0"))
+    (package
+      (name "emacs-evil-anzu")
+      (version (git-version "0.03" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/emacsorphanage/evil-anzu")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "1i8f360lq5a32knkzbwdw10ql9cxsmgfd4iiwnr7vcwacm34zq88"))))
+      (build-system emacs-build-system)
+      (propagated-inputs (list emacs-evil emacs-anzu))
+      (home-page "https://github.com/emacsorphanage/evil-anzu")
+      (synopsis "Anzu for evil-mode")
+      (description
+       "@code{anzu} provides a minor mode that displays the current
 match and total match information in the mode-line in various search modes.")
-    (license license:gpl3+)))
+      (license license:gpl3+))))
 
 (define-public emacs-pg
   (package

base-commit: eb93ab2d1401c08e7b6002e951633f6b8759b86d
-- 
2.41.0

Message #8 received at 66924 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Rostislav Svoboda <rostislav.svoboda <at> gmail.com>, 66924 <at> debbugs.gnu.org
Cc: Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: [bug#66924] [PATCH] gnu: emacs-evil-anzu: Update to
 0.03-0.d1e98ee.
Date: Fri, 03 Nov 2023 23:52:29 +0100

Am Freitag, dem 03.11.2023 um 23:18 +0100 schrieb Rostislav Svoboda:
> The github url redirects from syohex/emacs-evil-anzu to
> emacsorphanage/evil-anzu.
> 
> * gnu/packages/emacs-xyz.scm (emacs-evil-anzu): Update to 0.03-
> 0.d1e98ee.
The home-page update should be reflected in the ChangeLog rather than
explained in prose.  You might also want to add a comment to the file
as to why we're checking out a commit.

Cheers

Message #11 received at 66924 <at> debbugs.gnu.org (full text, mbox):

From: Rostislav Svoboda <rostislav.svoboda <at> gmail.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>, 66924 <at> debbugs.gnu.org,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: [bug#66924] [PATCH] gnu: emacs-evil-anzu: Update to
 0.03-0.d1e98ee.
Date: Sat, 4 Nov 2023 01:14:59 +0100

> The home-page update should be reflected in the ChangeLog rather than explained in prose.

???
What do you exactly mean by "reflected"? I'm not trying to explain or
reflect anything. I wrote this little note there so that people know
that I didn't change the repo URL by mistake.

I looked at the changes between 0.03 and d1e98ee - seem legit to me,
no backdoors or anything of that sort. The 0.03 is almost 9 years old,
the d1e98ee has been on melpa since March 2023 and it looks like the
changes are really needed, 'cause some other thing (doom emacs), is
throwing me an error when the 0.03 is used.

> You might also want to add a comment to the file as to why we're checking out a commit.

???
There's nothing else to check out. And that wouldn't be a meaningful comment.

Cheers

Message #14 received at 66924 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Rostislav Svoboda <rostislav.svoboda <at> gmail.com>
Cc: Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>, 66924 <at> debbugs.gnu.org,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: [bug#66924] [PATCH] gnu: emacs-evil-anzu: Update to
 0.03-0.d1e98ee.
Date: Sat, 04 Nov 2023 07:33:10 +0100

Am Samstag, dem 04.11.2023 um 01:14 +0100 schrieb Rostislav Svoboda:
> > The home-page update should be reflected in the ChangeLog rather
> > than explained in prose.
> 
> ???
> What do you exactly mean by "reflected"? I'm not trying to explain or
> reflect anything. I wrote this little note there so that people know
> that I didn't change the repo URL by mistake.
IOW you explained it :)

> I looked at the changes between 0.03 and d1e98ee - seem legit to me,
> no backdoors or anything of that sort. The 0.03 is almost 9 years
> old, the d1e98ee has been on melpa since March 2023 and it looks like
> the changes are really needed, 'cause some other thing (doom emacs),
> is throwing me an error when the 0.03 is used.
> 
> > You might also want to add a comment to the file as to why we're
> > checking out a commit.
> 
> ???
> There's nothing else to check out. And that wouldn't be a meaningful
> comment.
Look at other Emacs packages that have not had a long release.  They
carry a comment like ";; No release since DATE."

Cheers

Message #17 received at 66924 <at> debbugs.gnu.org (full text, mbox):

From: Clément Lassieur <clement <at> lassieur.org>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>, 66924 <at> debbugs.gnu.org,
 Rostislav Svoboda <rostislav.svoboda <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: [bug#66924] [PATCH] gnu: emacs-evil-anzu: Update to
 0.03-0.d1e98ee.
Date: Sat, 04 Nov 2023 11:47:33 +0100

On Sat, Nov 04 2023, Liliana Marie Prikler wrote:

> Am Samstag, dem 04.11.2023 um 01:14 +0100 schrieb Rostislav Svoboda:
>> > The home-page update should be reflected in the ChangeLog rather
>> > than explained in prose.
>> 
>> ???
>> What do you exactly mean by "reflected"? I'm not trying to explain or
>> reflect anything. I wrote this little note there so that people know
>> that I didn't change the repo URL by mistake.
> IOW you explained it :)
>
>> I looked at the changes between 0.03 and d1e98ee - seem legit to me,
>> no backdoors or anything of that sort. The 0.03 is almost 9 years
>> old, the d1e98ee has been on melpa since March 2023 and it looks like
>> the changes are really needed, 'cause some other thing (doom emacs),
>> is throwing me an error when the 0.03 is used.
>> 
>> > You might also want to add a comment to the file as to why we're
>> > checking out a commit.
>> 
>> ???
>> There's nothing else to check out. And that wouldn't be a meaningful
>> comment.
> Look at other Emacs packages that have not had a long release.  They
> carry a comment like ";; No release since DATE."

Please, this is bikeshedding :)

Even more packages don't have this comment and it's not the most useful
comment anyways.

--8<---------------cut here---------------start------------->8---
Spend time proportional to the stakes.  Ensure the discussion focuses on
important aspects of the changes; do not let it be derailed by
objectively unimportant issues (This situation is often referred to as
“bikeshedding”, where much time is spent discussing each one's
preference for the color of the shed at the expense progress made on the
project to keep bikes dry).
--8<---------------cut here---------------end--------------->8---

This patch looks good.

Message #20 received at 66924 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Clément Lassieur <clement <at> lassieur.org>
Cc: Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>, 66924 <at> debbugs.gnu.org,
 Rostislav Svoboda <rostislav.svoboda <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: [bug#66924] [PATCH] gnu: emacs-evil-anzu: Update to
 0.03-0.d1e98ee.
Date: Sat, 04 Nov 2023 12:48:52 +0100

Am Samstag, dem 04.11.2023 um 11:47 +0100 schrieb Clément Lassieur:
> On Sat, Nov 04 2023, Liliana Marie Prikler wrote:
> 
> > Am Samstag, dem 04.11.2023 um 01:14 +0100 schrieb Rostislav
> > Svoboda:
> > > There's nothing else to check out. And that wouldn't be a
> > > meaningful comment.
> > Look at other Emacs packages that have not had a long release. 
> > They carry a comment like ";; No release since DATE."
> 
> Please, this is bikeshedding :)
> 
> Even more packages don't have this comment and it's not the most
> useful comment anyways.
Given that the change from packaging a release to packaging a non-
release and vice versa requires re-indenting the whole thing, and that
non-releases don't really work well with `guix refresh', I think *a
comment* as to why a non-release is chosen and what else to watch out
for when updating the package is nice to have.

We can discuss the form of that comment, but that would be bikeshedding
:)

> --8<---------------cut here---------------start------------->8---
> Spend time proportional to the stakes. […]
> --8<---------------cut here---------------end--------------->8---
The stakes are low and the suggested changes small.  The time it would
take to amend the commit is proportional.  The time to go back and
forth seeking a justification as for why or why not to do so not so.

Cheers

Message #25 received at 66924-done <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Rostislav Svoboda <rostislav.svoboda <at> gmail.com>, 
 66924-done <at> debbugs.gnu.org
Cc: Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: [bug#66924] [PATCH] gnu: emacs-evil-anzu: Update to
 0.03-0.d1e98ee.
Date: Sat, 11 Nov 2023 07:14:56 +0100

Am Freitag, dem 03.11.2023 um 23:52 +0100 schrieb Liliana Marie
Prikler:
> Am Freitag, dem 03.11.2023 um 23:18 +0100 schrieb Rostislav Svoboda:
> > The github url redirects from syohex/emacs-evil-anzu to
> > emacsorphanage/evil-anzu.
> > 
> > * gnu/packages/emacs-xyz.scm (emacs-evil-anzu): Update to 0.03-
> > 0.d1e98ee.
> The home-page update should be reflected in the ChangeLog rather than
> explained in prose.  You might also want to add a comment to the file
> as to why we're checking out a commit.
> 
> Cheers
Pushed with exactly these changes.

Cheers

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.