GNU bug report logs - #66960
[PATCH] gnu: Add guile-algorithms

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 66960 in the body.
You can then email your comments to 66960 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Filip Lajszczak <filip <at> lajszczak.dev>
To: guix-patches <at> gnu.org
Cc: Filip Lajszczak <filip <at> lajszczak.dev>
Subject: [PATCH] gnu: Add guile-algorithms
Date: Sun,  5 Nov 2023 21:07:47 +0000

Guile port of racket-algorithms

* gnu/packages/guile-xyz.scm (guile-algorithms): New variable.
---
 gnu/packages/guile-xyz.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 8f4ada7800..c408cdb71b 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -1373,6 +1373,31 @@ (define-public guile-aa-tree
 convenient nested tree operations.")
     (license license:gpl3+)))
 
+(define-public guile-algorithms
+  (package
+    (name "guile-algorithms")
+    (version "0.1")
+      (source
+        (origin
+          (method git-fetch)
+          (uri (git-reference
+                 (url "https://git <at> git.sr.ht/~filiplajszczak/guile-algorithms")
+                 (commit (string-append "v" version))))
+          (file-name (git-file-name name version))
+          (sha256
+            (base32
+             "0sqnica53kpxc8lmsf9aqzf3wcfjnxq4sxg0j9ka4fjh0id931qc"))))
+    (build-system gnu-build-system)
+    (native-inputs (list autoconf automake pkg-config texinfo))
+    (inputs (list guile-3.0))
+    (synopsis "Guile port of racket-algorithms")
+    (description
+     "Guile port of @url{https://docs.racket-lang.org/algorithms/index.html,
+racket-algorithms}, a package containing many useful algorithms borrowed from many
+other programming languages).")
+    (home-page "https://guile-algorithms.lajszczak.dev/")
+    (license license:gpl3+)))
+
 (define-public guile-aws
   (let ((commit "f32bea12333e1054b97ab50e58a72636edabb5b7")
         (revision "1"))
-- 
2.42.0

Message #8 received at 66960 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Filip Lajszczak <filip <at> lajszczak.dev>
Cc: 66960 <at> debbugs.gnu.org
Subject: Re: [bug#66960] [PATCH] gnu: Add guile-algorithms
Date: Sat, 25 Nov 2023 19:17:32 +0100

Hello,

> +          (sha256
> +            (base32
> +             "0sqnica53kpxc8lmsf9aqzf3wcfjnxq4sxg0j9ka4fjh0id931qc"))))

It looks like the hash is now:
0r4fgq0p8lwma4cmdjb1xy2r40wkb7rg5b0cri2cab698fmb97al.

Does it mean that the release package was updated?

> +     "Guile port of @url{https://docs.racket-lang.org/algorithms/index.html,
> +racket-algorithms}, a package containing many useful algorithms borrowed from many
> +other programming languages).")

You can remove both "many".

Thanks,

Mathieu

Message #11 received at 66960 <at> debbugs.gnu.org (full text, mbox):

From: Filip Łajszczak <filip <at> lajszczak.dev>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 66960 <at> debbugs.gnu.org
Subject: Re: [bug#66960] [PATCH] gnu: Add guile-algorithms
Date: Sat, 25 Nov 2023 19:09:18 +0000

[Message part 1 (text/plain, inline)]

On 11/25/23 18:17, Mathieu Othacehe wrote:
> 
> Hello,
> 
>> +          (sha256
>> +            (base32
>> +             "0sqnica53kpxc8lmsf9aqzf3wcfjnxq4sxg0j9ka4fjh0id931qc"))))
> 
> It looks like the hash is now:
> 0r4fgq0p8lwma4cmdjb1xy2r40wkb7rg5b0cri2cab698fmb97al.
> 
> Does it mean that the release package was updated?

It should not have been as the tag was on the same commit, but it is now 
as I moved it to include small docs change. I do not totally understand.

> 
>> +     "Guile port of @url{https://docs.racket-lang.org/algorithms/index.html,
>> +racket-algorithms}, a package containing many useful algorithms borrowed from many
>> +other programming languages).")
> 
> You can remove both "many".
> 

Yep, make sense. It was just copied from the description of the original 
racket package, but it is better less bombastic.

> Thanks,
> 
> Mathieu

Thanks for your review. Amended patch to follow.

All the best,
Filip

[OpenPGP_0x5B9D16DC27046620.asc (application/pgp-keys, attachment)]

[OpenPGP_signature.asc (application/pgp-signature, attachment)]

Message #14 received at 66960 <at> debbugs.gnu.org (full text, mbox):

From: Filip Lajszczak <filip <at> lajszczak.dev>
To: 66960 <at> debbugs.gnu.org
Cc: Filip Lajszczak <filip <at> lajszczak.dev>
Subject: [PATCH v2] gnu: Add guile-algorithms
Date: Sat, 25 Nov 2023 19:12:22 +0000

Guile port of racket-algorithms

* gnu/packages/guile-xyz.scm (guile-algorithms): New variable.

Change-Id: I53e5b130f96ce10e52622fcdb35b9d0bbe28b108
---
 gnu/packages/guile-xyz.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 7326c1b65b..557589d2bb 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -1373,6 +1373,31 @@ (define-public guile-aa-tree
 convenient nested tree operations.")
     (license license:gpl3+)))
 
+(define-public guile-algorithms
+  (package
+    (name "guile-algorithms")
+    (version "0.1")
+      (source
+        (origin
+          (method git-fetch)
+          (uri (git-reference
+                 (url "https://git <at> git.sr.ht/~filiplajszczak/guile-algorithms")
+                 (commit (string-append "v" version))))
+          (file-name (git-file-name name version))
+          (sha256
+            (base32
+             "1a4ffnnhw92gqphjji5ajy3xfaqzww7xv3h8p82gkawx0rqvj5ni"))))
+    (build-system gnu-build-system)
+    (native-inputs (list autoconf automake pkg-config texinfo))
+    (inputs (list guile-3.0))
+    (synopsis "Guile port of racket-algorithms")
+    (description
+     "Guile port of @url{https://docs.racket-lang.org/algorithms/index.html,
+racket-algorithms}, a package containing useful algorithms borrowed from other
+programming languages).")
+    (home-page "https://guile-algorithms.lajszczak.dev/")
+    (license license:gpl3+)))
+
 (define-public guile-aws
   (let ((commit "f32bea12333e1054b97ab50e58a72636edabb5b7")
         (revision "1"))
-- 
2.43.0

Message #19 received at 66960-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Filip Lajszczak <filip <at> lajszczak.dev>
Cc: 66960-done <at> debbugs.gnu.org
Subject: Re: [bug#66960] [PATCH v2] gnu: Add guile-algorithms
Date: Sun, 26 Nov 2023 14:36:45 +0100

> * gnu/packages/guile-xyz.scm (guile-algorithms): New variable.

Applied, thanks for the v2,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.