GNU bug report logs -
#66964
Request for merging "mesa-updates" branch
Previous Next
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 66964 in the body.
You can then email your comments to 66964 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
guix-patches <at> gnu.org
:
bug#66964
; Package
guix-patches
.
(Mon, 06 Nov 2023 04:47:01 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
John Kehayias <john.kehayias <at> protonmail.com>
:
New bug report received and forwarded. Copy sent to
guix-patches <at> gnu.org
.
(Mon, 06 Nov 2023 04:47:01 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
Hello,
This is to start the process for merging the "mesa-updates" branch. A set of commits was just pushed there and the CI already has a build job for this branch. It is only 12 commits currently, but will be a lot of builds due mostly to the ungrafting of libx11 (and certain package updates beyond mesa itself, like pixman, libdrm, etc.). So, mostly waiting for things to build and hoping no major breakages. The ungrafts and version updates shouldn't be huge changes but you never know.
Please feel free to report any issues here and I'll update as well as things go.
Thanks!
John
Information forwarded
to
guix-patches <at> gnu.org
:
bug#66964
; Package
guix-patches
.
(Thu, 09 Nov 2023 13:47:01 GMT)
Full text and
rfc822 format available.
Message #8 received at 66964 <at> debbugs.gnu.org (full text, mbox):
Hi John,
I noticed one of my commit #65153 is on the mesa-update branch, it
would be helpful if you could take a look at #65155, an update
trying to export XDG_DATA_DIRS for mesa. Since no one replied
there, I'm not sure if this change is appropriate and if it fits
in this update.
--
dan
Information forwarded
to
guix-patches <at> gnu.org
:
bug#66964
; Package
guix-patches
.
(Sun, 12 Nov 2023 20:03:02 GMT)
Full text and
rfc822 format available.
Message #11 received at 66964 <at> debbugs.gnu.org (full text, mbox):
Hi,
I've just submitted a pair of patches for the mesa-updates branch: <https://issues.guix.gnu.org/67136> updating xorgproto and xorg-server-xwayland. The xorgproto is a high-impact update (guix refresh reports rebuilding 8710 packages would ensure 22871 dependent packages are rebuilt), but required to update to the latest xwayland as xwayland requires a newer version of presentproto than in the current guix xorgproto package. The updating and ungrafting of mesa and a number of X.org related libraries seemed like a good time (and place) to update xorgproto as well.
Cheers,
Kaelyn
Information forwarded
to
guix-patches <at> gnu.org
:
bug#66964
; Package
guix-patches
.
(Tue, 14 Nov 2023 20:07:01 GMT)
Full text and
rfc822 format available.
Message #14 received at 66964 <at> debbugs.gnu.org (full text, mbox):
Hi dan,
On Thu, Nov 09, 2023 at 09:43 PM, dan wrote:
> Hi John,
>
> I noticed one of my commit #65153 is on the mesa-update branch, it
> would be helpful if you could take a look at #65155, an update trying
> to export XDG_DATA_DIRS for mesa. Since no one replied there, I'm not
> sure if this change is appropriate and if it fits in this update.
Apologies I did not see this message as I think you only sent it to the
bug number (which does not get sent to anyone else as far as I know). I
had meant to respond to #65155 but I think I forgot. I did have a note
on the thread on guix-devel about this briefly:
> I don't think this is a correct change as written (search-path should
> be in vulkan-loader if I'm understanding what is supposed to happen
> here). Anyway, will follow up on that issue and left it out for now.
I'll follow up on that bug number directly to discuss.
Sorry for the miscommunication!
John
Information forwarded
to
guix-patches <at> gnu.org
:
bug#66964
; Package
guix-patches
.
(Tue, 14 Nov 2023 20:13:01 GMT)
Full text and
rfc822 format available.
Message #17 received at 66964 <at> debbugs.gnu.org (full text, mbox):
Hi Kaelyn,
On Sun, Nov 12, 2023 at 08:01 PM, Kaelyn wrote:
> Hi,
>
> I've just submitted a pair of patches for the mesa-updates branch:
> <https://issues.guix.gnu.org/67136> updating xorgproto and
> xorg-server-xwayland. The xorgproto is a high-impact update (guix
> refresh reports rebuilding 8710 packages would ensure 22871 dependent
> packages are rebuilt), but required to update to the latest xwayland
> as xwayland requires a newer version of presentproto than in the
> current guix xorgproto package. The updating and ungrafting of mesa
> and a number of X.org related libraries seemed like a good time (and
> place) to update xorgproto as well.
>
> Cheers,
> Kaelyn
Thanks for the patches. I think mesa-updates in this current iteration
is set on builds (ended up being a lot more due to the ungrafting but
seems done on our main architectures for several days now). I had to
make some other changes to fix some larger breakages but at this point I
think it will just be taking us back in the build queue too much.
So I think it would make more sense on the next big rebuild, either
core-updates (talk about doing that with more ungrafts right now) or
I'll do mesa-updates again when the next release of mesa hits. Or maybe
it makes sense to just do another branch for xwayland?
Open to ideas! I'll send a separate message soon on the status of
mesa-updates and see what people think, but my thought was to merge this
to master in the next day or so if there are no objections.
Thanks!
John
Information forwarded
to
guix-patches <at> gnu.org
:
bug#66964
; Package
guix-patches
.
(Tue, 14 Nov 2023 20:38:02 GMT)
Full text and
rfc822 format available.
Message #20 received at 66964 <at> debbugs.gnu.org (full text, mbox):
Hi John,
On Tuesday, November 14th, 2023 at 12:11 PM, John Kehayias <john.kehayias <at> protonmail.com> wrote:
>
> Hi Kaelyn,
>
> On Sun, Nov 12, 2023 at 08:01 PM, Kaelyn wrote:
>
> > Hi,
> >
> > I've just submitted a pair of patches for the mesa-updates branch:
> > https://issues.guix.gnu.org/67136 updating xorgproto and
> > xorg-server-xwayland. The xorgproto is a high-impact update (guix
> > refresh reports rebuilding 8710 packages would ensure 22871 dependent
> > packages are rebuilt), but required to update to the latest xwayland
> > as xwayland requires a newer version of presentproto than in the
> > current guix xorgproto package. The updating and ungrafting of mesa
> > and a number of X.org related libraries seemed like a good time (and
> > place) to update xorgproto as well.
> >
> > Cheers,
> > Kaelyn
>
>
> Thanks for the patches. I think mesa-updates in this current iteration
> is set on builds (ended up being a lot more due to the ungrafting but
> seems done on our main architectures for several days now). I had to
> make some other changes to fix some larger breakages but at this point I
> think it will just be taking us back in the build queue too much.
>
> So I think it would make more sense on the next big rebuild, either
> core-updates (talk about doing that with more ungrafts right now) or
> I'll do mesa-updates again when the next release of mesa hits. Or maybe
> it makes sense to just do another branch for xwayland?
>
> Open to ideas! I'll send a separate message soon on the status of
> mesa-updates and see what people think, but my thought was to merge this
> to master in the next day or so if there are no objections.
>
> Thanks!
> John
No worries! I realize I was a little late to the party for the mesa-updates branch (had some ongoing technical issues), so if core-updates is still early enough in the process I think it would be good to push the changes to that branch. The current xwayland is pretty old, and the updated version has quite a few CVEs fixed in comparison (just https://www.phoronix.com/news/X.Org-Halloween-Bugs-2023 and https://www.phoronix.com/news/X.Org-Server-Holiday-2022 list 8 CVEs fixed between xwayland 21.1.3 and 23.2.2).
Cheers,
Kaelyn
Information forwarded
to
guix-patches <at> gnu.org
:
bug#66964
; Package
guix-patches
.
(Wed, 15 Nov 2023 05:42:02 GMT)
Full text and
rfc822 format available.
Message #23 received at 66964 <at> debbugs.gnu.org (full text, mbox):
Hi everyone,
Update below:
On Sun, Nov 05, 2023 at 11:47 PM, John Kehayias wrote:
[snippy snip snip]
>>
>> Happy to! Substitutes will eventually become available, but there's
>> quite a few builds to be done. This takes care of some ungrafts and
>> updates with I hope minimal disruption. I'll be keeping an eye out and
>> using locally as well. Please test and report, thanks everyone!
>>
>> John
>
> An issue was created to track merging the mesa-updates branch here:
> <https://issues.guix.gnu.org/66964>. Please use that bug number as
> needed (and cc me or use wide-reply in emacs debbugs).
At this point I feel we are just about ready to go, unless there are
objections?
Substitute coverage, according to
<https://qa.guix.gnu.org/branch/mesa-updates> is good on x86_64 and
i686 (about 95% and 83%, respectively) while, as usual, other
architectures are behind. The next best is aarch64 at 54% on bordeaux,
and then falling to 24% for armhf, with others we build in the teens.
I think this is to be expected? In any event builds continue very
slowly and in the past I think this is about where we merge.
I should note: please check for any breakages. I didn't expect too
much, but did get more than I thought. It seems the ungrafting version
changes caused some things to fail. Also, the libx11 ungraft mean
python and rust were rebuilt, with the many packages that entails.
I fixed big ones I saw, like QT (unrelated: it was libxkbcommon
upgrade), but other leaf packages I saw had tests failing for reasons
I didn't see. For instance, php fails tests. The current ones are due
to the curl update, but updating php and removing an obsolete patch
had a different test fail. It would be great if someone more familiar
will take a look. With few dependents I figure this can just be done
on master after the merge.
So, shall I merge this to master in the next couple of days? I've been
merging master into mesa-updates smoothly so far. Please do check and
feel free to object if this needs more time.
Thanks everyone,
John
PS: I forgot to email the various patches/issues that are done on
mesa-updates, as listed in a previous message. I will do that too.
Information forwarded
to
guix-patches <at> gnu.org
:
bug#66964
; Package
guix-patches
.
(Wed, 15 Nov 2023 15:44:02 GMT)
Full text and
rfc822 format available.
Message #26 received at 66964 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
On Tue, Nov 14, 2023 at 08:11:08PM +0000, John Kehayias wrote:
> Hi Kaelyn,
>
> On Sun, Nov 12, 2023 at 08:01 PM, Kaelyn wrote:
>
> > Hi,
> >
> > I've just submitted a pair of patches for the mesa-updates branch:
> > <https://issues.guix.gnu.org/67136> updating xorgproto and
> > xorg-server-xwayland. The xorgproto is a high-impact update (guix
> > refresh reports rebuilding 8710 packages would ensure 22871 dependent
> > packages are rebuilt), but required to update to the latest xwayland
> > as xwayland requires a newer version of presentproto than in the
> > current guix xorgproto package. The updating and ungrafting of mesa
> > and a number of X.org related libraries seemed like a good time (and
> > place) to update xorgproto as well.
> >
> > Cheers,
> > Kaelyn
>
> Thanks for the patches. I think mesa-updates in this current iteration
> is set on builds (ended up being a lot more due to the ungrafting but
> seems done on our main architectures for several days now). I had to
> make some other changes to fix some larger breakages but at this point I
> think it will just be taking us back in the build queue too much.
>
> So I think it would make more sense on the next big rebuild, either
> core-updates (talk about doing that with more ungrafts right now) or
> I'll do mesa-updates again when the next release of mesa hits. Or maybe
> it makes sense to just do another branch for xwayland?
>
> Open to ideas! I'll send a separate message soon on the status of
> mesa-updates and see what people think, but my thought was to merge this
> to master in the next day or so if there are no objections.
If the mesa branch is ready to merge so soon then I think we should just
get that merged and then I'll rebase the rust-team branch on top of new
master. The rust-team branch is also ready to merge, but we're way
behind on aarch64 substitutes. Either way the substitute servers will
be rebuilding all of rust so I think it'd be better to merge in
mesa-updates and then do rust.
--
Efraim Flashner <efraim <at> flashner.co.il> רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org
:
bug#66964
; Package
guix-patches
.
(Sat, 18 Nov 2023 11:26:02 GMT)
Full text and
rfc822 format available.
Message #29 received at 66964 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
John Kehayias <john.kehayias <at> protonmail.com> writes:
> Hi everyone,
>
> Update below:
>
> On Sun, Nov 05, 2023 at 11:47 PM, John Kehayias wrote:
> [snippy snip snip]
>>>
>>> Happy to! Substitutes will eventually become available, but there's
>>> quite a few builds to be done. This takes care of some ungrafts and
>>> updates with I hope minimal disruption. I'll be keeping an eye out and
>>> using locally as well. Please test and report, thanks everyone!
>>>
>>> John
>>
>> An issue was created to track merging the mesa-updates branch here:
>> <https://issues.guix.gnu.org/66964>. Please use that bug number as
>> needed (and cc me or use wide-reply in emacs debbugs).
>
> At this point I feel we are just about ready to go, unless there are
> objections?
>
> Substitute coverage, according to
> <https://qa.guix.gnu.org/branch/mesa-updates> is good on x86_64 and
> i686 (about 95% and 83%, respectively) while, as usual, other
> architectures are behind. The next best is aarch64 at 54% on bordeaux,
> and then falling to 24% for armhf, with others we build in the teens.
> I think this is to be expected? In any event builds continue very
> slowly and in the past I think this is about where we merge.
I think some changes have been pushed since this email, since the
aarch64 substitute availability has dropped from 54% to 25%.
> So, shall I merge this to master in the next couple of days? I've been
> merging master into mesa-updates smoothly so far. Please do check and
> feel free to object if this needs more time.
I guess this has been held up by the changes on the 15th, but still, I
think we need to wait for substitute availability to improve more prior
to merging, unless there's a specific and significant reason why we
don't want to wait.
Targets are arbitrary, but guix weather defines ☀ as 80%+, so I think
that's what we should aim for at least for x86_64-linux, i686-linux,
aarch64-linux and armhf-linux. This isn't just about substitute
availability though as this is key for discovering what things fail to
build.
Obviously delays in merging aren't ideal, but we should tackle the
problems around this, maybe by deciding that testing and providing
substitutes for ARM isn't a priority and thus isn't something we should
wait for, or look at getting more ARM hardware to speed up the process
(we also have a lack of x86_64 hardware on the bordeaux build farm).
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org
:
bug#66964
; Package
guix-patches
.
(Mon, 20 Nov 2023 05:42:01 GMT)
Full text and
rfc822 format available.
Message #32 received at 66964 <at> debbugs.gnu.org (full text, mbox):
Hi,
On Sat, Nov 18, 2023 at 11:07 AM, Christopher Baines wrote:
>
> John Kehayias <john.kehayias <at> protonmail.com> writes:
>
>> Hi everyone,
>>
>> Update below:
>>
>> On Sun, Nov 05, 2023 at 11:47 PM, John Kehayias wrote:
>> [snippy snip snip]
>>
>> At this point I feel we are just about ready to go, unless there are
>> objections?
>>
>> Substitute coverage, according to
>> <https://qa.guix.gnu.org/branch/mesa-updates> is good on x86_64 and
>> i686 (about 95% and 83%, respectively) while, as usual, other
>> architectures are behind. The next best is aarch64 at 54% on bordeaux,
>> and then falling to 24% for armhf, with others we build in the teens.
>> I think this is to be expected? In any event builds continue very
>> slowly and in the past I think this is about where we merge.
>
> I think some changes have been pushed since this email, since the
> aarch64 substitute availability has dropped from 54% to 25%.
>
Yes, Efraim chimed in to help on some other architectures and some big
rebuilds were/are happening for those. I see them slowly ticking up
but it will still need some time.
>> So, shall I merge this to master in the next couple of days? I've been
>> merging master into mesa-updates smoothly so far. Please do check and
>> feel free to object if this needs more time.
>
> I guess this has been held up by the changes on the 15th, but still, I
> think we need to wait for substitute availability to improve more prior
> to merging, unless there's a specific and significant reason why we
> don't want to wait.
>
Yes, agreed. I'm not as clear on how well we do typically on non-x86
but getting a sense of it now, which is why I wanted to ask.
> Targets are arbitrary, but guix weather defines ☀ as 80%+, so I think
> that's what we should aim for at least for x86_64-linux, i686-linux,
> aarch64-linux and armhf-linux. This isn't just about substitute
> availability though as this is key for discovering what things fail to
> build.
>
I think this is something we could better clarify and quantify as many
of us probably only pay attention to x86_64, where for others we can
be strapped for both hardware and people. So I didn't want to wait for
some substitutes that would never come but also don't want to
inconvenience people on other architectures, especially if builds
there take much much longer in the first place.
Perhaps we can look at some historical data on what we've hit in
substitute coverage and try to at least keep up with that if not set
some goals for better coverage? While we might also expect further
difficulties as some get left behind by upstream (as we've had to work
around rust on i686 so far, I believe).
All that is to say, yes, let's make sure we have good substitute
coverage and are clear on what architectures we want to make sure
users get substitutes for.
> Obviously delays in merging aren't ideal, but we should tackle the
> problems around this, maybe by deciding that testing and providing
> substitutes for ARM isn't a priority and thus isn't something we should
> wait for, or look at getting more ARM hardware to speed up the process
> (we also have a lack of x86_64 hardware on the bordeaux build farm).
>
Agreed. We should have some clear Guix-wide standards and goals. I'm
sure we can get some hardware from Guix-ers and/or funding too,
especially if people know exactly what it will go towards improving.
Thanks for chiming in here and all your work on this front!
In the meantime, I'll go back to refreshing the CI and QA pages every
so often to make sure we keep getting closer...
Reply sent
to
John Kehayias <john.kehayias <at> protonmail.com>
:
You have taken responsibility.
(Tue, 28 Nov 2023 05:31:02 GMT)
Full text and
rfc822 format available.
Notification sent
to
John Kehayias <john.kehayias <at> protonmail.com>
:
bug acknowledged by developer.
(Tue, 28 Nov 2023 05:31:02 GMT)
Full text and
rfc822 format available.
Message #37 received at 66964-done <at> debbugs.gnu.org (full text, mbox):
Guix-ers,
On Wed, Nov 15, 2023 at 08:28 AM, Efraim Flashner wrote:
> On Tue, Nov 14, 2023 at 08:11:08PM +0000, John Kehayias wrote:
>> Hi Kaelyn,
>>
>> On Sun, Nov 12, 2023 at 08:01 PM, Kaelyn wrote:
>>
>> > Hi,
>> >
>> > I've just submitted a pair of patches for the mesa-updates branch:
>> > <https://issues.guix.gnu.org/67136> updating xorgproto and
>> > xorg-server-xwayland. The xorgproto is a high-impact update (guix
>> > refresh reports rebuilding 8710 packages would ensure 22871 dependent
>> > packages are rebuilt), but required to update to the latest xwayland
>> > as xwayland requires a newer version of presentproto than in the
>> > current guix xorgproto package. The updating and ungrafting of mesa
>> > and a number of X.org related libraries seemed like a good time (and
>> > place) to update xorgproto as well.
>> >
>> > Cheers,
>> > Kaelyn
>>
>> Thanks for the patches. I think mesa-updates in this current iteration
>> is set on builds (ended up being a lot more due to the ungrafting but
>> seems done on our main architectures for several days now). I had to
>> make some other changes to fix some larger breakages but at this point I
>> think it will just be taking us back in the build queue too much.
>>
>> So I think it would make more sense on the next big rebuild, either
>> core-updates (talk about doing that with more ungrafts right now) or
>> I'll do mesa-updates again when the next release of mesa hits. Or maybe
>> it makes sense to just do another branch for xwayland?
>>
>> Open to ideas! I'll send a separate message soon on the status of
>> mesa-updates and see what people think, but my thought was to merge this
>> to master in the next day or so if there are no objections.
>
> If the mesa branch is ready to merge so soon then I think we should just
> get that merged and then I'll rebase the rust-team branch on top of new
> master. The rust-team branch is also ready to merge, but we're way
> behind on aarch64 substitutes. Either way the substitute servers will
> be rebuilding all of rust so I think it'd be better to merge in
> mesa-updates and then do rust.
Merged as 79765b40fd9b4921b531284c589ace8a2c89a6ea woop!
We got good coverage on x86_64, i686, powerpc64le, aarch64 (all
-linux) especially from Bordeaux. Unfortunately armhf got stuck even
with prodding and waiting, but hopefully it will recover. There may be
some slight catching up across the board with recent issues on Berlin,
but prior to things getting wonky it was looking good (of course all
that happened right when I wanted to merge the other day).
Thanks to Efraim for some fixes and especially getting non-x86 in
better shape.
Feel free anyone to ping me on patches/bugs due to this merge. And
please enjoy updated mesa, fixes to gtk4 applications, some less
grafts, and more.
John
PS: I'll return to mesa-updates soon with next major mesa update and
pending related patches, or in core-updates if that is getting close.
Information forwarded
to
guix-patches <at> gnu.org
:
bug#66964
; Package
guix-patches
.
(Sat, 09 Dec 2023 19:30:02 GMT)
Full text and
rfc822 format available.
Message #40 received at 66964 <at> debbugs.gnu.org (full text, mbox):
Hi,
On Tuesday, November 14th, 2023 at 12:36 PM, Kaelyn <kaelyn.alexi <at> protonmail.com> wrote:
>
> Hi John,
>
> On Tuesday, November 14th, 2023 at 12:11 PM, John Kehayias john.kehayias <at> protonmail.com wrote:
>
> > Hi Kaelyn,
> >
> > On Sun, Nov 12, 2023 at 08:01 PM, Kaelyn wrote:
> >
> > > Hi,
> > >
> > > I've just submitted a pair of patches for the mesa-updates branch:
> > > https://issues.guix.gnu.org/67136 updating xorgproto and
> > > xorg-server-xwayland. The xorgproto is a high-impact update (guix
> > > refresh reports rebuilding 8710 packages would ensure 22871 dependent
> > > packages are rebuilt), but required to update to the latest xwayland
> > > as xwayland requires a newer version of presentproto than in the
> > > current guix xorgproto package. The updating and ungrafting of mesa
> > > and a number of X.org related libraries seemed like a good time (and
> > > place) to update xorgproto as well.
> > >
> > > Cheers,
> > > Kaelyn
> >
> > Thanks for the patches. I think mesa-updates in this current iteration
> > is set on builds (ended up being a lot more due to the ungrafting but
> > seems done on our main architectures for several days now). I had to
> > make some other changes to fix some larger breakages but at this point I
> > think it will just be taking us back in the build queue too much.
> >
> > So I think it would make more sense on the next big rebuild, either
> > core-updates (talk about doing that with more ungrafts right now) or
> > I'll do mesa-updates again when the next release of mesa hits. Or maybe
> > it makes sense to just do another branch for xwayland?
> >
> > Open to ideas! I'll send a separate message soon on the status of
> > mesa-updates and see what people think, but my thought was to merge this
> > to master in the next day or so if there are no objections.
> >
> > Thanks!
> > John
>
>
> No worries! I realize I was a little late to the party for the mesa-updates branch (had some ongoing technical issues), so if core-updates is still early enough in the process I think it would be good to push the changes to that branch. The current xwayland is pretty old, and the updated version has quite a few CVEs fixed in comparison (just https://www.phoronix.com/news/X.Org-Halloween-Bugs-2023 and https://www.phoronix.com/news/X.Org-Server-Holiday-2022 list 8 CVEs fixed between xwayland 21.1.3 and 23.2.2).
I forgot to sent an email when I did this, but a few weeks ago I updated the xorgproto/xwayland update ticket (#66964) to refer to core-updates instead of mesa-updates and sent in a v2 of the patches rebased against core-updates.
Cheers,
Kaelyn
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Sun, 07 Jan 2024 12:24:08 GMT)
Full text and
rfc822 format available.
This bug report was last modified 1 year and 143 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.