X-Loop: help-debbugs@HIDDEN
Subject: bug#66983: 29.1; sql-sqlite prompt-cont-regexp incompatible since sqlite 3.41.0
Resent-From: Gustav Broberg <gustav.broberg@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 07 Nov 2023 11:44:02 +0000
Resent-Message-ID: <handler.66983.B.169935742927622 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: report 66983
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords:
To: 66983 <at> debbugs.gnu.org
X-Debbugs-Original-To: bug-gnu-emacs@HIDDEN
Received: via spool by submit <at> debbugs.gnu.org id=B.169935742927622
(code B ref -1); Tue, 07 Nov 2023 11:44:02 +0000
Received: (at submit) by debbugs.gnu.org; 7 Nov 2023 11:43:49 +0000
Received: from localhost ([127.0.0.1]:41382 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1r0KUb-0007B9-2w
for submit <at> debbugs.gnu.org; Tue, 07 Nov 2023 06:43:49 -0500
Received: from lists.gnu.org ([2001:470:142::17]:58040)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <gustav.broberg@HIDDEN>) id 1r0JDA-0004t8-Oi
for submit <at> debbugs.gnu.org; Tue, 07 Nov 2023 05:21:33 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <gustav.broberg@HIDDEN>)
id 1r0JCS-000406-Ox
for bug-gnu-emacs@HIDDEN; Tue, 07 Nov 2023 05:20:49 -0500
Received: from mail-yb1-xb2a.google.com ([2607:f8b0:4864:20::b2a])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <gustav.broberg@HIDDEN>)
id 1r0JCQ-0004rw-V2
for bug-gnu-emacs@HIDDEN; Tue, 07 Nov 2023 05:20:48 -0500
Received: by mail-yb1-xb2a.google.com with SMTP id
3f1490d57ef6-da2b9211dc0so5326706276.3
for <bug-gnu-emacs@HIDDEN>; Tue, 07 Nov 2023 02:20:45 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1699352445; x=1699957245; darn=gnu.org;
h=to:subject:message-id:date:from:mime-version:from:to:cc:subject
:date:message-id:reply-to;
bh=tx71ccI/E9rK3oopN9MHF9kaVHPEXWfKZv3NpenUL+g=;
b=BH3GuETb5g/Bo7vvi809McQ9sXyldx3xtq0VlG/rcmyuD0MbV0DJo7nHWjLJ5y4qVF
saHY1UNDjm8zr7HkgOhCHFVNG1KcG65TRJiaohA1XHELyXa1HCFnhMGKih9Qk3+xiNLF
02HKB2GsPWnoeB9CiCnEstu1bEncf3mUk16n2RMiAu/fAOreA/ftcy2BGj13IAGkKaW4
+whdtCEnuN7LncwjJboMv7u2mOIQ6+3EWn3E8w+zRDYDH1qx3DxLqdOg6MyM7HaKeWRI
37quHf5Cpy5pkbW3uhuY8otODveWAeNC5yJDbrDbxzojGtACNoC7myTnvJ6F82lwl6iv
xbpg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1699352445; x=1699957245;
h=to:subject:message-id:date:from:mime-version:x-gm-message-state
:from:to:cc:subject:date:message-id:reply-to;
bh=tx71ccI/E9rK3oopN9MHF9kaVHPEXWfKZv3NpenUL+g=;
b=l8cT5ei9K0wEdHEfNlyuqxHzQ3wN6wtE0y4Ji573qPJI32Cg9ddVZqueYCX299wXjz
QZeP23F8hvbmdEz9O2G6xs4Mj8JSf1C2zkd523B7aEGImIHrk5bk9JHRdyz5p6AQ/g0Q
kZTWqRWh8HmBpnkPENZiKbCMrcli3hAqOc1QuO19o2KBadm0ennG0BfotJcDSp01VH2D
IwHDWxp4iu7VezVWO59plIkclnkPRbJ8QqjgtqHoE36VoujEHldwWH8QVnxqQ61U+krL
t59orcN531Cf3LGPgvW5bBDX5C5kE+LZiNOCessFM3vwfFUa4wSBvDb2zF1PlcQfXT5q
YHFQ==
X-Gm-Message-State: AOJu0YxxFh+JWGdjy9MAsK6HBfoOP2AoJgKmldfKtvdfsrXXYxF6mlew
Wu+N4KIUTDt80/ETZjlg5HN6wtZYMb6EuXnq3F+5wPbwC897pg==
X-Google-Smtp-Source: AGHT+IGPqyz25VAuaGJKzfqgv3sXL+6tEIE28sz8M5ZuR+EFy86pm7bUgTfJuiExlc9xUrjFS7xMkYHCseQidNbqnRI=
X-Received: by 2002:a5b:5ca:0:b0:da0:5ba2:6275 with SMTP id
w10-20020a5b05ca000000b00da05ba26275mr28629605ybp.34.1699352444740; Tue, 07
Nov 2023 02:20:44 -0800 (PST)
MIME-Version: 1.0
From: Gustav Broberg <gustav.broberg@HIDDEN>
Date: Tue, 7 Nov 2023 11:20:18 +0100
Message-ID: <CAE4h+g1hsf6iysQnezt2H2fUAGKSYU1VO9pE+tSzoZZkS6ft_g@HIDDEN>
Content-Type: multipart/alternative; boundary="000000000000d12a8206098d5234"
Received-SPF: pass client-ip=2607:f8b0:4864:20::b2a;
envelope-from=gustav.broberg@HIDDEN; helo=mail-yb1-xb2a.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Mailman-Approved-At: Tue, 07 Nov 2023 06:43:35 -0500
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
--000000000000d12a8206098d5234
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
The continuation prompt regexp for sql.el's sqlite product is hard coded as
" ...> ":
http://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/progmodes/sql.el?id=3D=
a1abb6a85e6605c256595b8d7b885018e5421c28#n497
But since SQLite version 3.41.0 this prompt is no longer static but dynamic
and contains information about current context (unclosed string,
parentheses, etc.):
https://www.sqlite.org/releaselog/3_41_0.html
For example, sending a multi-line query with an unclosed string like:
SELECT 1
AS "two lines
";
will give an output like:
SQLite version 3.44.0 2023-11-01 11:23:50
Enter ".help" for usage hints.
sqlite>
" ...> =E2=94=8C=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=
=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=90
=E2=94=82 two lines =E2=94=82
=E2=94=9C=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=
=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=A4
=E2=94=82 1 =E2=94=82
=E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=
=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=98
Run Time: real 0.000 user 0.000118 sys 0.000076
because the continuation prompt is '" ...> '.
Setting a custom sqlite continuation prompt regexp to match the dynamic
prompt
fixes this:
(sql-set-product-feature 'sqlite :prompt-cont-regexp "^...\\.\\.\\.> ")
I suggest updating the regexp in sql.el to this (or some more specific)
regexp.
Thanks!
--=20
Gustav
--000000000000d12a8206098d5234
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr">The continuation prompt regexp for sql.el's sqlite pro=
duct is hard coded as " =C2=A0 ...> ":<br><a href=3D"http://gi=
t.savannah.gnu.org/cgit/emacs.git/tree/lisp/progmodes/sql.el?id=3Da1abb6a85=
e6605c256595b8d7b885018e5421c28#n497">http://git.savannah.gnu.org/cgit/emac=
s.git/tree/lisp/progmodes/sql.el?id=3Da1abb6a85e6605c256595b8d7b885018e5421=
c28#n497</a><br><br>But since SQLite version 3.41.0 this prompt is no longe=
r static but dynamic<br>and contains information about current context (unc=
losed string, parentheses, etc.):<br><a href=3D"https://www.sqlite.org/rele=
aselog/3_41_0.html">https://www.sqlite.org/releaselog/3_41_0.html</a><br><b=
r>For example, sending a multi-line query with an unclosed string like:<br>=
<br>=C2=A0 SELECT 1<br>=C2=A0 AS "two lines<br>=C2=A0 ";<br><br>w=
ill give an output like:<br><br>=C2=A0 SQLite version 3.44.0 2023-11-01 11:=
23:50<br>=C2=A0 Enter ".help" for usage hints.<br>=C2=A0 sqlite&g=
t; <br>=C2=A0 " =C2=A0...> =E2=94=8C=E2=94=80=E2=94=80=E2=94=80=E2=
=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=
=90<br>=C2=A0 =E2=94=82 two lines =E2=94=82<br>=C2=A0 =E2=94=9C=E2=94=80=E2=
=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=
=80=E2=94=80=E2=94=A4<br>=C2=A0 =E2=94=82 1 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =E2=
=94=82<br>=C2=A0 =E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=
=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=98<br>=C2=A0 Run =
Time: real 0.000 user 0.000118 sys 0.000076<br><br>because the continuation=
prompt is '" =C2=A0...> '.<br><br>Setting a custom sqlite =
continuation prompt regexp to match the dynamic prompt<br>fixes this:<br><b=
r>=C2=A0 (sql-set-product-feature 'sqlite :prompt-cont-regexp "^..=
.\\.\\.\\.> ")<br><br>I suggest updating the regexp in sql.el to th=
is (or some more specific)<br>regexp.<br><br>Thanks!<br>-- <br>Gustav<br></=
div>
--000000000000d12a8206098d5234--
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Gustav Broberg <gustav.broberg@HIDDEN> Subject: bug#66983: Acknowledgement (29.1; sql-sqlite prompt-cont-regexp incompatible since sqlite 3.41.0) Message-ID: <handler.66983.B.169935742927622.ack <at> debbugs.gnu.org> References: <CAE4h+g1hsf6iysQnezt2H2fUAGKSYU1VO9pE+tSzoZZkS6ft_g@HIDDEN> X-Gnu-PR-Message: ack 66983 X-Gnu-PR-Package: emacs Reply-To: 66983 <at> debbugs.gnu.org Date: Tue, 07 Nov 2023 11:44:02 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): bug-gnu-emacs@HIDDEN If you wish to submit further information on this problem, please send it to 66983 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 66983: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D66983 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
X-Loop: help-debbugs@HIDDEN
Subject: bug#66983: [PATCH] sql.el: Let sqlite's prompt-cont-regexp accept new dynamic prompt
References: <CAE4h+g1hsf6iysQnezt2H2fUAGKSYU1VO9pE+tSzoZZkS6ft_g@HIDDEN>
In-Reply-To: <CAE4h+g1hsf6iysQnezt2H2fUAGKSYU1VO9pE+tSzoZZkS6ft_g@HIDDEN>
Resent-From: Gustav Broberg <gustav.broberg@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 10 Nov 2023 10:21:02 +0000
Resent-Message-ID: <handler.66983.B66983.169961163416792 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 66983
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords:
To: 66983 <at> debbugs.gnu.org
Received: via spool by 66983-submit <at> debbugs.gnu.org id=B66983.169961163416792
(code B ref 66983); Fri, 10 Nov 2023 10:21:02 +0000
Received: (at 66983) by debbugs.gnu.org; 10 Nov 2023 10:20:34 +0000
Received: from localhost ([127.0.0.1]:49594 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1r1Oco-0004Mh-WD
for submit <at> debbugs.gnu.org; Fri, 10 Nov 2023 05:20:34 -0500
Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]:54399)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <gustav.broberg@HIDDEN>) id 1r1O1p-0003Cp-3G
for 66983 <at> debbugs.gnu.org; Fri, 10 Nov 2023 04:42:19 -0500
Received: by mail-pj1-x1030.google.com with SMTP id
98e67ed59e1d1-28003daaaa6so1609561a91.0
for <66983 <at> debbugs.gnu.org>; Fri, 10 Nov 2023 01:41:37 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1699609290; x=1700214090; darn=debbugs.gnu.org;
h=to:subject:message-id:date:from:mime-version:from:to:cc:subject
:date:message-id:reply-to;
bh=fh3pbiCX2KxlRJ/6AKgJUDCSsVoy7upfpPTzzyHYS9o=;
b=Qp2GxdcfYvcSC+e5tDzujF8YAess+GJNfr994pRETTd042omkXu2cThlr2p/3sPgFQ
a8asdryAF/aL2yi/rwjtEsNX4QMyW2bt8EpkSUynBHcrIFvdiHAOFVx+yhZOOYfzgyl9
FkjL3JY1/QWZPdv6r3mkxCMtAd63ygCwHuG/4ChIPdKrNfYppK+btZv80D+mOV5qZJdc
DDUdBmJKb1unZyfz9godUq97OHFgXLd0m3aInvutfZAiLvV1HO9zDCrB6bWGQ1R6F2iX
da+bAK26r1HAwMwcgk50VzYKoxams3ghI3XLMvQrbmxYz69z5AIm9wB0sSQQ4ITDZgle
iLsA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1699609290; x=1700214090;
h=to:subject:message-id:date:from:mime-version:x-gm-message-state
:from:to:cc:subject:date:message-id:reply-to;
bh=fh3pbiCX2KxlRJ/6AKgJUDCSsVoy7upfpPTzzyHYS9o=;
b=NYxHPvZqLc+uk4+yn3OdK1DxGK7H1jk5eo3OwKFqD8vveZbuP4L6Z811mEyNo+czTh
K5rHhI21PefoxP5U46IC7+sgCtqLi0Fom6zrRH9QW4vRlb+yOLaQ/zV3/fpLmrUNuzXk
zoURZhcFZ/aAchqvSOrSG85V5rCBf4mpIKON50fH5jzF8cnV5EinECDTotlzzJlKJ4wX
QeTEcxGqH3srck2C0mZELot9Xd6Gbjc7oCLtFIdvi0639WiuFn6U0IOOQomLYEGpP8NV
2zH68NAyBR4IDgCm+R0bImUYCVfMHVdUVuIA9PWYqyn46JwunsizjtynLDPmu8OMHvvI
pzKw==
X-Gm-Message-State: AOJu0YzX4M2mmqinwv5UOckOJIKjhEfgl+ICABNWztH+r3wCZNWU0hzu
ukVFLf4tdR0w4Fnj+tHZaFSfmXsAAFdbe5/mwDXdvwaFtAjP/Q==
X-Google-Smtp-Source: AGHT+IFoOqM/oZpX4xg6WV/WVNkSGk9R9VEolgSZXE+04v7aiOiOcDhFKit0DHYKBWxUAgbuAf/DKzIXAi/FH8ji7QA=
X-Received: by 2002:a17:90b:4c12:b0:280:3f33:64d8 with SMTP id
na18-20020a17090b4c1200b002803f3364d8mr4693904pjb.21.1699609290187; Fri, 10
Nov 2023 01:41:30 -0800 (PST)
MIME-Version: 1.0
From: Gustav Broberg <gustav.broberg@HIDDEN>
Date: Fri, 10 Nov 2023 10:41:03 +0100
Message-ID: <CAE4h+g0xnUb00yGM82RsOij8N0T=m9ZDYHYtH3x8mrRFuEGhSg@HIDDEN>
Content-Type: multipart/mixed; boundary="000000000000ffbd570609c91f7f"
X-Spam-Score: 0.0 (/)
X-Mailman-Approved-At: Fri, 10 Nov 2023 05:20:29 -0500
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--000000000000ffbd570609c91f7f
Content-Type: multipart/alternative; boundary="000000000000ffbd550609c91f7d"
--000000000000ffbd550609c91f7d
Content-Type: text/plain; charset="UTF-8"
Patch for changing sql.el sqlite's prompt-cont-regexp to be compatible with
SQLite 3.41.0.
--000000000000ffbd550609c91f7d
Content-Type: text/html; charset="UTF-8"
<div dir="ltr">Patch for changing sql.el sqlite's prompt-cont-regexp to be compatible with SQLite 3.41.0.</div>
--000000000000ffbd550609c91f7d--
--000000000000ffbd570609c91f7f
Content-Type: application/octet-stream;
name="0001-sql.el-Let-sqlite-s-prompt-cont-regexp-accept-new-dy.patch"
Content-Disposition: attachment;
filename="0001-sql.el-Let-sqlite-s-prompt-cont-regexp-accept-new-dy.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_losfawmr0>
X-Attachment-Id: f_losfawmr0
RnJvbSBlMjQyZDYyMWVhNjVjNTE2M2VlNmRjOWVkNTAyNWE0MDMwODMxOWUxIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXYgQnJvYmVyZyA8Z3VzdGF2LmJyb2JlcmdAZ21haWwu
Y29tPgpEYXRlOiBGcmksIDEwIE5vdiAyMDIzIDEwOjE2OjI5ICswMTAwClN1YmplY3Q6IFtQQVRD
SF0gc3FsLmVsOiBMZXQgc3FsaXRlJ3MgcHJvbXB0LWNvbnQtcmVnZXhwIGFjY2VwdCBuZXcgZHlu
YW1pYwogcHJvbXB0CgpTaW5jZSBTUUxpdGUgdmVyc2lvbiAzLjQxLjAgdGhlIGNvbnRpbnVhdGlv
biBwcm9tcHQgaXMgZHluYW1pYyBhbmQKc2hvd3Mgb3BlbiBwYXJlbnRoZXNlcywgcXVvdGVzLCBj
b21tZW50cywgZXRjLiBVcGRhdGUgc3FsLmVsIHNxbGl0ZQpwcm9tcHQtY29udC1yZWdleHAgdG8g
bWF0Y2ggbm90IG9ubHkgdGhlIHN0YXRpYyBwcm9tcHQgKCIgICAuLi4+ICIpCmJ1dCB0aGUgbmV3
IGR5bmFtaWMgb25lcy4gVGhlIHBvc3NpYmxlIGNvbnRpbnVhdGlvbiBwcm9tcHRzIGFyZToKCiAg
ICAgLi4uPgogIGAgIC4uLj4KICAnICAuLi4+CiAgIiAgLi4uPgogIC8qIC4uLj4KICAoeE4uLi4+
ICh3aGVyZSBOIGlzIDEgdG8gOSkKICAoLi4uLi4+CiAgKXghLi4uPgotLS0KIGxpc3AvcHJvZ21v
ZGVzL3NxbC5lbCB8IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxl
dGlvbigtKQoKZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL3NxbC5lbCBiL2xpc3AvcHJvZ21v
ZGVzL3NxbC5lbAppbmRleCAwMDRhZTUwZWY1MC4uYTk5ZTk0YWNmNzkgMTAwNjQ0Ci0tLSBhL2xp
c3AvcHJvZ21vZGVzL3NxbC5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9zcWwuZWwKQEAgLTUwNyw3
ICs1MDcsNyBAQCBmaWxlLiAgU2luY2UgdGhhdCBpcyBhIHBsYWludGV4dCBmaWxlLCB0aGlzIGNv
dWxkIGJlIGRhbmdlcm91cy4iCiAgICAgIDpjb21wbGV0aW9uLW9iamVjdCBzcWwtc3FsaXRlLWNv
bXBsZXRpb24tb2JqZWN0CiAgICAgIDpwcm9tcHQtcmVnZXhwICJec3FsaXRlPiAiCiAgICAgIDpw
cm9tcHQtbGVuZ3RoIDgKLSAgICAgOnByb21wdC1jb250LXJlZ2V4cCAiXiAgIFxcLlxcLlxcLj4g
IikKKyAgICAgOnByb21wdC1jb250LXJlZ2V4cCAiXltgJ1wiLygpIF1beCouIF1bMS05IS4gXVxc
LlxcLlxcLj4gIikKIAogICAgIChzeWJhc2UKICAgICAgOm5hbWUgIlN5YmFzZSIKLS0gCjIuNDIu
MQoK
--000000000000ffbd570609c91f7f--
X-Loop: help-debbugs@HIDDEN
Subject: bug#66983: [PATCH] sql.el: Let sqlite's prompt-cont-regexp accept new dynamic prompt
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 10 Nov 2023 12:08:02 +0000
Resent-Message-ID: <handler.66983.B66983.169961804428972 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 66983
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords:
To: Gustav Broberg <gustav.broberg@HIDDEN>, Michael R. Mauger <michael@HIDDEN>
Cc: 66983 <at> debbugs.gnu.org
Received: via spool by 66983-submit <at> debbugs.gnu.org id=B66983.169961804428972
(code B ref 66983); Fri, 10 Nov 2023 12:08:02 +0000
Received: (at 66983) by debbugs.gnu.org; 10 Nov 2023 12:07:24 +0000
Received: from localhost ([127.0.0.1]:49647 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1r1QIF-0007XD-R3
for submit <at> debbugs.gnu.org; Fri, 10 Nov 2023 07:07:24 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:44150)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1r1QIC-0007Wy-CK
for 66983 <at> debbugs.gnu.org; Fri, 10 Nov 2023 07:07:22 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1r1QHT-00077X-1z; Fri, 10 Nov 2023 07:06:35 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=fQ8pj0MdCnWw1wlE23fN7tRyeW5cT5EJGLLyAUEcYKg=; b=d/h0MPYPAPwg
q4eGIvkTpbuDVpENvIKlYn0SrUvpDO+CtlBNG5R5WkGl+bZoLoUdTFW8p01SUtVsuJQNC4zOIT8Gf
FXe0rRC4Wo18rec2oIcY2MbxC2Z4f+q6umgNcZHNBgLvkD1HwQXGrz/GHbdguJ/UPSuO/xGYe3yX/
gPFKMXrYpLGfmrX6SqnaMZDjfQ49p9stDMJ23LyT7Y6FbGrAcd+DXxCPC1F+9lDRJhRgm0VyWY1dS
n36s3E1TWuyhEuSE1C/dhD/8kU/bBDs2efOV0Rp+S9MG8MFzzn4AAWVaEQaf651HHn7F081Sqx79+
dOTnwFBmF8SRYWM1rugO8Q==;
Date: Fri, 10 Nov 2023 14:06:20 +0200
Message-Id: <83o7g1yfr7.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <CAE4h+g0xnUb00yGM82RsOij8N0T=m9ZDYHYtH3x8mrRFuEGhSg@HIDDEN>
(message from Gustav Broberg on Fri, 10 Nov 2023 10:41:03 +0100)
References: <CAE4h+g1hsf6iysQnezt2H2fUAGKSYU1VO9pE+tSzoZZkS6ft_g@HIDDEN>
<CAE4h+g0xnUb00yGM82RsOij8N0T=m9ZDYHYtH3x8mrRFuEGhSg@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> From: Gustav Broberg <gustav.broberg@HIDDEN>
> Date: Fri, 10 Nov 2023 10:41:03 +0100
>
> Patch for changing sql.el sqlite's prompt-cont-regexp to be compatible with SQLite 3.41.0.
Thanks.
Michael, any comments or suggestions?
X-Loop: help-debbugs@HIDDEN
Subject: bug#66983: [PATCH] sql.el: Let sqlite's prompt-cont-regexp accept new dynamic prompt
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 25 Nov 2023 09:27:02 +0000
Resent-Message-ID: <handler.66983.B66983.17009044033896 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 66983
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords:
To: michael@HIDDEN
Cc: 66983 <at> debbugs.gnu.org, gustav.broberg@HIDDEN
Received: via spool by 66983-submit <at> debbugs.gnu.org id=B66983.17009044033896
(code B ref 66983); Sat, 25 Nov 2023 09:27:02 +0000
Received: (at 66983) by debbugs.gnu.org; 25 Nov 2023 09:26:43 +0000
Received: from localhost ([127.0.0.1]:37808 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1r6ovy-00010m-Ll
for submit <at> debbugs.gnu.org; Sat, 25 Nov 2023 04:26:42 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:40964)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1r6ovw-00010T-9x
for 66983 <at> debbugs.gnu.org; Sat, 25 Nov 2023 04:26:40 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1r6ovl-0007PS-I9; Sat, 25 Nov 2023 04:26:29 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=UVyJFF7nJNPd7ClGfMV8uExRQVH1dQDi3CKE5dtZBCU=; b=owbXPotgSgMl
L3EFwiwmVAwn4qDww3t79GqF56JHBISPja7Rw5EVvLqQI/DAn9Sy4jJ0O/rcSsXwor9KNtYv47sgl
4tZOKYXKHs+qRM30oAPlGLki80sy4edRFdSCZy/3yBIUw2W7Xz4RawWekUgKy2loVbFJNpmxWXSVx
KYicZyeWhVixSZVZmB8r4wCoqvkCmMxojhG2wzH6biNXPbOig8grkDmsYSBytBOnMbWWmADeq9CdJ
HRAXXAVKE7GbNchWVtf1kvVy6PimHwFkLJwY9AgPd46qxi8UydV2znOQOeZtJYg5R9ZIkUH+cO6DK
fdThujAt7ZKpkVSfFiutgA==;
Date: Sat, 25 Nov 2023 11:26:27 +0200
Message-Id: <838r6mdvzw.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <83o7g1yfr7.fsf@HIDDEN> (message from Eli Zaretskii on Fri, 10
Nov 2023 14:06:20 +0200)
References: <CAE4h+g1hsf6iysQnezt2H2fUAGKSYU1VO9pE+tSzoZZkS6ft_g@HIDDEN>
<CAE4h+g0xnUb00yGM82RsOij8N0T=m9ZDYHYtH3x8mrRFuEGhSg@HIDDEN>
<83o7g1yfr7.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Ping! Michael, can you please look into this?
> Cc: 66983 <at> debbugs.gnu.org
> Date: Fri, 10 Nov 2023 14:06:20 +0200
> From: Eli Zaretskii <eliz@HIDDEN>
>
> > From: Gustav Broberg <gustav.broberg@HIDDEN>
> > Date: Fri, 10 Nov 2023 10:41:03 +0100
> >
> > Patch for changing sql.el sqlite's prompt-cont-regexp to be compatible with SQLite 3.41.0.
>
> Thanks.
>
> Michael, any comments or suggestions?
>
>
>
>
X-Loop: help-debbugs@HIDDEN
Subject: bug#66983: [PATCH] sql.el: Let sqlite's prompt-cont-regexp accept new dynamic prompt
Resent-From: Stefan Kangas <stefankangas@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 15 Dec 2023 01:29:01 +0000
Resent-Message-ID: <handler.66983.B66983.170260372619589 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 66983
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords:
To: Eli Zaretskii <eliz@HIDDEN>, michael@HIDDEN
Cc: 66983 <at> debbugs.gnu.org, gustav.broberg@HIDDEN
Received: via spool by 66983-submit <at> debbugs.gnu.org id=B66983.170260372619589
(code B ref 66983); Fri, 15 Dec 2023 01:29:01 +0000
Received: (at 66983) by debbugs.gnu.org; 15 Dec 2023 01:28:46 +0000
Received: from localhost ([127.0.0.1]:51338 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rDx0Q-00055s-Ex
for submit <at> debbugs.gnu.org; Thu, 14 Dec 2023 20:28:46 -0500
Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]:57713)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <stefankangas@HIDDEN>) id 1rDx0P-00055e-6C
for 66983 <at> debbugs.gnu.org; Thu, 14 Dec 2023 20:28:45 -0500
Received: by mail-ed1-x52a.google.com with SMTP id
4fb4d7f45d1cf-54bf9a54fe3so148669a12.3
for <66983 <at> debbugs.gnu.org>; Thu, 14 Dec 2023 17:28:45 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1702603719; x=1703208519; darn=debbugs.gnu.org;
h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
:from:from:to:cc:subject:date:message-id:reply-to;
bh=lwO8nJfPjIX/oZSSkzoWGWLIOh5OT5ydtOkH6AjLbE0=;
b=j9RUi0lRK0HDzBP4DCKbCTcZGsfr3Hzd1uaBZ+8SbygnDtI9UJUKvjXNZi4SC5Oaec
ewFWiM1cKm0gyg4YLR3Kz+AXhZz+rLQbsapWZ5NSwYoJGXG1Er/nQHiCN+PXFcEOxCjk
V/KsFt6Qap2K47/MF1lK4GJjDlyZhY86Ag6AarXIr1njRQCOrwhVTKuHbB4LzJ6t+z6p
gz6XTswhgLE8E77oxfiv7F89myJFPdhT+DMz3TM7g86S1FLQVQGiLyRY+wxUR2ZGfcdt
X3lF7OTZGZX5Zn6FlDWudxICENw0WoJoUtOLVQd0aL3XKDJ5Tax4ukjvAKcyGGwZCELk
Wozg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1702603720; x=1703208520;
h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
:from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=lwO8nJfPjIX/oZSSkzoWGWLIOh5OT5ydtOkH6AjLbE0=;
b=swgnWsc2ZuK6okYCJiG+cVOiFk+w0gTZyLlj3TFKqpZ19pqu6dBmOjfKiLX/ezZp3j
r9k5mTijYKq/6z9exK5O/f0xLPaQd04LavwCm9iGwuVQ6YayepGXrrzvC50iOfx9gFxU
ef5rtfQq5m+wP5h6Nj+b+1q6dm+Wjo8qlMy1G23NkmAiPPMfOGH1nV8/jjc+TSqveOmI
eGsRseaoj2D3WjvHqrjx9GrHX88VtPfi9ozTUBs+KRsVBl+N69nFbeR92hec//BZY8iJ
ZOk2X9fcqVJi8vtQfcuBspo5Z9dLomuJaSKJY0XK46nX0c4ChA6fWoRR4OxXJKtHW8g+
/O9A==
X-Gm-Message-State: AOJu0Yx9W4gdwblta8RAzb9pYCRmiBH2zzQMYbPcX0OQzhiUfLicT1ea
wrXPYYdAqx7YDEaQRn6Rnq5oHjg7A7d4IXKaEA4=
X-Google-Smtp-Source: AGHT+IFwtkRP8clx3EqWT6O9cOi3vmx0FikFJs48KmBMuhnN+oEDhHBzZwdG6FBeLiM3tLrQlP1hl9q6td2JTkbRsyg=
X-Received: by 2002:a50:c8cb:0:b0:552:2b83:42e3 with SMTP id
k11-20020a50c8cb000000b005522b8342e3mr1455586edh.41.1702603719486; Thu, 14
Dec 2023 17:28:39 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
HTTPREST; Thu, 14 Dec 2023 17:28:39 -0800
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <838r6mdvzw.fsf@HIDDEN>
References: <CAE4h+g1hsf6iysQnezt2H2fUAGKSYU1VO9pE+tSzoZZkS6ft_g@HIDDEN>
<CAE4h+g0xnUb00yGM82RsOij8N0T=m9ZDYHYtH3x8mrRFuEGhSg@HIDDEN>
<83o7g1yfr7.fsf@HIDDEN> <838r6mdvzw.fsf@HIDDEN>
MIME-Version: 1.0
Date: Thu, 14 Dec 2023 17:28:39 -0800
Message-ID: <CADwFkmmFOm5N6C6jSqiE9+s23yef1RLndA7ZHQqYqjWFY_E+eQ@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Eli Zaretskii <eliz@HIDDEN> writes:
> Ping! Michael, can you please look into this?
>
>> Cc: 66983 <at> debbugs.gnu.org
>> Date: Fri, 10 Nov 2023 14:06:20 +0200
>> From: Eli Zaretskii <eliz@HIDDEN>
>>
>> > From: Gustav Broberg <gustav.broberg@HIDDEN>
>> > Date: Fri, 10 Nov 2023 10:41:03 +0100
>> >
>> > Patch for changing sql.el sqlite's prompt-cont-regexp to be compatible with SQLite 3.41.0.
>>
>> Thanks.
>>
>> Michael, any comments or suggestions?
It would be nice to get this fixed already in Emacs 29.2, given that
SQLite is so common.
FWIW, if Michael doesn't have time to look into this, the patch seems to
make sense. It just allows a few more prompts that weren't allowed
before.
At the same time, if these are indeed the only allowed prompts:
...>
` ...>
' ...>
" ...>
/* ...>
(xN...> (where N is 1 to 9)
(.....>
)x!...>
we could probably make something a bit more strict. Where do we find
the documentation for that though? Gustav, where is that from?
X-Loop: help-debbugs@HIDDEN
Subject: bug#66983: [PATCH] sql.el: Let sqlite's prompt-cont-regexp accept new dynamic prompt
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 15 Dec 2023 08:40:02 +0000
Resent-Message-ID: <handler.66983.B66983.170262956524663 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 66983
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords:
To: Stefan Kangas <stefankangas@HIDDEN>
Cc: michael@HIDDEN, gustav.broberg@HIDDEN, 66983 <at> debbugs.gnu.org
Received: via spool by 66983-submit <at> debbugs.gnu.org id=B66983.170262956524663
(code B ref 66983); Fri, 15 Dec 2023 08:40:02 +0000
Received: (at 66983) by debbugs.gnu.org; 15 Dec 2023 08:39:25 +0000
Received: from localhost ([127.0.0.1]:51581 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rE3jB-0006Pj-8S
for submit <at> debbugs.gnu.org; Fri, 15 Dec 2023 03:39:25 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:36386)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1rE3jA-0006PX-A2
for 66983 <at> debbugs.gnu.org; Fri, 15 Dec 2023 03:39:24 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1rE3j4-00013j-MX; Fri, 15 Dec 2023 03:39:18 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=bpzQfxyozRvTL/Ve0HRnScemDNVuVPQsDXpxGVm4Qxs=; b=IMjAJE+Nn8ad
QDtNEgS5RkDVoexlZna9zoWeII1pW65923VWocFl9XfiSf9dv+O1c1zSE7kBk1Ewa+0VHCA+HSlww
AAjRTZ8Uqrw9vxkh//F345nTPpFTA9cUaFL1UijbMb6l7k7JmzRDnR0cxTiQcdnZN7NCf064xGzQz
A0NzHuglBtUZH1xgCTcRL7oFYh79i9G0hDst+2SkNVCznXnvYwgPAhaEDc8dF7/2oDOvppYNAHsPc
RBX3kNOgFoXnen72xNwJ57jfbvERvwSljazZwvg2PgqBuSEV3arBZMuy34WjD7M9y/ailWljzz5kd
9z7PcJ+OoV5RgTwEECpHjA==;
Date: Fri, 15 Dec 2023 10:39:19 +0200
Message-Id: <838r5vq2q0.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <CADwFkmmFOm5N6C6jSqiE9+s23yef1RLndA7ZHQqYqjWFY_E+eQ@HIDDEN>
(message from Stefan Kangas on Thu, 14 Dec 2023 17:28:39 -0800)
References: <CAE4h+g1hsf6iysQnezt2H2fUAGKSYU1VO9pE+tSzoZZkS6ft_g@HIDDEN>
<CAE4h+g0xnUb00yGM82RsOij8N0T=m9ZDYHYtH3x8mrRFuEGhSg@HIDDEN>
<83o7g1yfr7.fsf@HIDDEN> <838r6mdvzw.fsf@HIDDEN>
<CADwFkmmFOm5N6C6jSqiE9+s23yef1RLndA7ZHQqYqjWFY_E+eQ@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> From: Stefan Kangas <stefankangas@HIDDEN>
> Date: Thu, 14 Dec 2023 17:28:39 -0800
> Cc: 66983 <at> debbugs.gnu.org, gustav.broberg@HIDDEN
>
> Eli Zaretskii <eliz@HIDDEN> writes:
>
> > Ping! Michael, can you please look into this?
> >
> >> Cc: 66983 <at> debbugs.gnu.org
> >> Date: Fri, 10 Nov 2023 14:06:20 +0200
> >> From: Eli Zaretskii <eliz@HIDDEN>
> >>
> >> > From: Gustav Broberg <gustav.broberg@HIDDEN>
> >> > Date: Fri, 10 Nov 2023 10:41:03 +0100
> >> >
> >> > Patch for changing sql.el sqlite's prompt-cont-regexp to be compatible with SQLite 3.41.0.
> >>
> >> Thanks.
> >>
> >> Michael, any comments or suggestions?
>
> It would be nice to get this fixed already in Emacs 29.2, given that
> SQLite is so common.
Agreed. I hope Michael will chime in soon enough.
X-Loop: help-debbugs@HIDDEN
Subject: bug#66983: [PATCH] sql.el: Let sqlite's prompt-cont-regexp accept new dynamic prompt
Resent-From: Gustav Broberg <gustav.broberg@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 15 Dec 2023 13:32:03 +0000
Resent-Message-ID: <handler.66983.B66983.170264706324268 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 66983
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords:
To: Stefan Kangas <stefankangas@HIDDEN>
Cc: michael@HIDDEN, Eli Zaretskii <eliz@HIDDEN>, 66983 <at> debbugs.gnu.org
Received: via spool by 66983-submit <at> debbugs.gnu.org id=B66983.170264706324268
(code B ref 66983); Fri, 15 Dec 2023 13:32:03 +0000
Received: (at 66983) by debbugs.gnu.org; 15 Dec 2023 13:31:03 +0000
Received: from localhost ([127.0.0.1]:51754 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rE8HO-0006IQ-O0
for submit <at> debbugs.gnu.org; Fri, 15 Dec 2023 08:31:03 -0500
Received: from mail-oa1-x2f.google.com ([2001:4860:4864:20::2f]:47465)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <gustav.broberg@HIDDEN>) id 1rE55Q-00078o-CX
for 66983 <at> debbugs.gnu.org; Fri, 15 Dec 2023 05:06:29 -0500
Received: by mail-oa1-x2f.google.com with SMTP id
586e51a60fabf-2035a859803so338319fac.3
for <66983 <at> debbugs.gnu.org>; Fri, 15 Dec 2023 02:06:28 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1702634782; x=1703239582; darn=debbugs.gnu.org;
h=cc:to:subject:message-id:date:from:in-reply-to:references
:mime-version:from:to:cc:subject:date:message-id:reply-to;
bh=Pifv3iJUb4gUdzwLpMQQswHKb9+40/U/GXxgsMuKZrg=;
b=IoK89fiCQVjv+NPA8iLs7obxxDT05qjBUQOVU8HJ8s8QfqNqYjYsX2gSOcRt7h6SZ/
Gm87gvbMXF+nEYz3INUCrhplVcDLoCu8cZtDRJssSqLQqeeV7j1YHZnf+Sn339yN9pUc
TZGnGrnXBSRelwQuUn/Ldba6iWVAs4pmRxD1/1RnGh0m5nWgxXHrHDGa4hYdOY/zDhpA
oB8V2k/MfoNTAnk7EJ/VbhDgs1mGrfAIwKZcBpQKsyQjTT6mmp/gD/DpP3F5ozNwtjik
VfoOXZy9uLLYyx/xzF957/BoJmJRueAkHA6fTTqr/zYxB3tHxt9D28uhtTYBOReO+JRO
Krwg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1702634782; x=1703239582;
h=cc:to:subject:message-id:date:from:in-reply-to:references
:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=Pifv3iJUb4gUdzwLpMQQswHKb9+40/U/GXxgsMuKZrg=;
b=fU8EGs3RJPPWzplttrrkcsumpTfblD2IvfZeRzCrb0kyht5Tatp8Zm3xJgPzE5oXr+
9E7vlyN0uVax6Xc0lKGkHa/Hoy3zJ0bQh6Ka28d/hLy80h5ijytvaWVyZLAUZXH/Xr4J
DbOMUC7bib2TiZgQaMTjGF0nR4rnYCRWoNZr+mcSyep9CRTkSivFK5cDfxPLESjVz7F+
XtE6JpF+Yl6aV06p9PXdrhCvKrmvj5Z7lcdZS3FqT8YD+aGEL5FYLNkJTAKVHX1mcQbk
2UcujzQMP5hhXQ6EzX5Iy1eOtcOGLoX42vS4nQmaSyqDIUXbJHMugMi3EojIB0pEULrf
2hRg==
X-Gm-Message-State: AOJu0Yz8dsXipBtsGbTKDRqrp7ECKrVP84JEtkaoMsSweYXKq5ikUi8u
UT0OD+P0MpNb/dPLAFircA6vq+hu6kEiITaecuY=
X-Google-Smtp-Source: AGHT+IFx8IKb56JIsk+p7TCKAyNzH8PH3/qa1lprXBvcltipawk4RBARLZ6gtsV6t592ASC0YPyvkIa7trjdo5A3QOk=
X-Received: by 2002:a05:6870:80b:b0:1fb:75a:77aa with SMTP id
fw11-20020a056870080b00b001fb075a77aamr11411355oab.91.1702634782416; Fri, 15
Dec 2023 02:06:22 -0800 (PST)
MIME-Version: 1.0
References: <CAE4h+g1hsf6iysQnezt2H2fUAGKSYU1VO9pE+tSzoZZkS6ft_g@HIDDEN>
<CAE4h+g0xnUb00yGM82RsOij8N0T=m9ZDYHYtH3x8mrRFuEGhSg@HIDDEN>
<83o7g1yfr7.fsf@HIDDEN> <838r6mdvzw.fsf@HIDDEN>
<CADwFkmmFOm5N6C6jSqiE9+s23yef1RLndA7ZHQqYqjWFY_E+eQ@HIDDEN>
In-Reply-To: <CADwFkmmFOm5N6C6jSqiE9+s23yef1RLndA7ZHQqYqjWFY_E+eQ@HIDDEN>
From: Gustav Broberg <gustav.broberg@HIDDEN>
Date: Fri, 15 Dec 2023 11:05:54 +0100
Message-ID: <CAE4h+g3zMxYEy73p7REoqhTqeLEUUH_Mk+j78nNt_6=hWUyteA@HIDDEN>
Content-Type: multipart/alternative; boundary="00000000000063662c060c898d6c"
X-Spam-Score: -0.0 (/)
X-Mailman-Approved-At: Fri, 15 Dec 2023 08:31:02 -0500
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--00000000000063662c060c898d6c
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
On Fri, Dec 15, 2023 at 2:28=E2=80=AFAM Stefan Kangas <stefankangas@HIDDEN=
om>
wrote:
> Eli Zaretskii <eliz@HIDDEN> writes:
>
> > Ping! Michael, can you please look into this?
> >
> >> Cc: 66983 <at> debbugs.gnu.org
> >> Date: Fri, 10 Nov 2023 14:06:20 +0200
> >> From: Eli Zaretskii <eliz@HIDDEN>
> >>
> >> > From: Gustav Broberg <gustav.broberg@HIDDEN>
> >> > Date: Fri, 10 Nov 2023 10:41:03 +0100
> >> >
> >> > Patch for changing sql.el sqlite's prompt-cont-regexp to be
> compatible with SQLite 3.41.0.
> >>
> >> Thanks.
> >>
> >> Michael, any comments or suggestions?
>
> It would be nice to get this fixed already in Emacs 29.2, given that
> SQLite is so common.
>
> FWIW, if Michael doesn't have time to look into this, the patch seems to
> make sense. It just allows a few more prompts that weren't allowed
> before.
>
> At the same time, if these are indeed the only allowed prompts:
>
> ...>
> ` ...>
> ' ...>
> " ...>
> /* ...>
> (xN...> (where N is 1 to 9)
> (.....>
> )x!...>
>
> we could probably make something a bit more strict. Where do we find
> the documentation for that though? Gustav, where is that from?
>
Thanks,
Not sure if it was clear, but the regexp in my actual patch is more strict
than in my first email: ^[`'\"/() ][x*. ][1-9!. ]\\.\\.\\.>
Unfortunately I've found no documentation listing the continuation prompts
=E2=80=93 I derived this list by inspecting the sqlite source code. For exa=
mple:
https://github.com/sqlite/sqlite/blob/e98238561911f85e54af3e6f26e47c2de8d1c=
da1/src/shell.c.in#L583-L611
-- Gustav
--00000000000063662c060c898d6c
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr"><div dir=3D"ltr">On Fri, Dec 15, 2023 at 2:28=E2=80=AFAM S=
tefan Kangas <<a href=3D"mailto:stefankangas@HIDDEN">stefankangas@gma=
il.com</a>> wrote:</div><div class=3D"gmail_quote"><blockquote class=3D"=
gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(20=
4,204,204);padding-left:1ex">Eli Zaretskii <<a href=3D"mailto:eliz@HIDDEN=
rg" target=3D"_blank">eliz@HIDDEN</a>> writes:<br>
<br>
> Ping!=C2=A0 Michael, can you please look into this?<br>
><br>
>> Cc: <a href=3D"mailto:66983 <at> debbugs.gnu.org" target=3D"_blank">669=
83 <at> debbugs.gnu.org</a><br>
>> Date: Fri, 10 Nov 2023 14:06:20 +0200<br>
>> From: Eli Zaretskii <<a href=3D"mailto:eliz@HIDDEN" target=3D"=
_blank">eliz@HIDDEN</a>><br>
>><br>
>> > From: Gustav Broberg <<a href=3D"mailto:gustav.broberg@gma=
il.com" target=3D"_blank">gustav.broberg@HIDDEN</a>><br>
>> > Date: Fri, 10 Nov 2023 10:41:03 +0100<br>
>> ><br>
>> > Patch for changing sql.el sqlite's prompt-cont-regexp to =
be compatible with SQLite 3.41.0.<br>
>><br>
>> Thanks.<br>
>><br>
>> Michael, any comments or suggestions?<br>
<br>
It would be nice to get this fixed already in Emacs 29.2, given that<br>
SQLite is so common.<br>
<br>
FWIW, if Michael doesn't have time to look into this, the patch seems t=
o<br>
make sense.=C2=A0 It just allows a few more prompts that weren't allowe=
d<br>
before.<br>
<br>
At the same time, if these are indeed the only allowed prompts:<br>
<br>
=C2=A0 =C2=A0 =C2=A0 ...><br>
=C2=A0 =C2=A0`=C2=A0 ...><br>
=C2=A0 =C2=A0'=C2=A0 ...><br>
=C2=A0 =C2=A0"=C2=A0 ...><br>
=C2=A0 =C2=A0/* ...><br>
=C2=A0 =C2=A0(xN...> (where N is 1 to 9)<br>
=C2=A0 =C2=A0(.....><br>
=C2=A0 =C2=A0)x!...><br>
<br>
we could probably make something a bit more strict.=C2=A0 Where do we find<=
br>
the documentation for that though?=C2=A0 Gustav, where is that from?<br></b=
lockquote><div><br></div><div>Thanks,<br><br>Not sure if it was clear, but =
the regexp in my actual patch is more strict than in my first email: ^[`=
9;\"/() ][x*. ][1-9!. ]\\.\\.\\.><br><br>Unfortunately I've fou=
nd no documentation listing the continuation prompts =E2=80=93 I derived th=
is list by inspecting the sqlite source code. For example:<br><a href=3D"ht=
tps://github.com/sqlite/sqlite/blob/e98238561911f85e54af3e6f26e47c2de8d1cda=
1/src/shell.c.in#L583-L611">https://github.com/sqlite/sqlite/blob/e98238561=
911f85e54af3e6f26e47c2de8d1cda1/src/shell.c.in#L583-L611</a><br><br>-- Gust=
av<br>=C2=A0</div></div></div>
--00000000000063662c060c898d6c--
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.