GNU bug report logs - #67018
[PATCH] Add autoload cookie to vc-git-grep

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 67018 in the body.
You can then email your comments to 67018 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alyssa Ross <hi <at> alyssa.is>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add autoload cookie to vc-git-grep
Date: Thu,  9 Nov 2023 15:46:30 +0100

---
 lisp/vc/vc-git.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el
index 707fc7cfc07..fe48d5fbd3d 100644
--- a/lisp/vc/vc-git.el
+++ b/lisp/vc/vc-git.el
@@ -1930,6 +1930,7 @@ vc-git-prepare-patch
 (defvar compilation-environment)
 
 ;; Derived from `lgrep'.
+;;;###autoload
 (defun vc-git-grep (regexp &optional files dir)
   "Run git grep, searching for REGEXP in FILES in directory DIR.
 The search is limited to file names matching shell pattern FILES.

base-commit: 5d171d26c00aefaef1496dede69337946a1edb14
-- 
2.42.0

Message #8 received at 67018 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Alyssa Ross <hi <at> alyssa.is>
Cc: 67018 <at> debbugs.gnu.org
Subject: Re: bug#67018: [PATCH] Add autoload cookie to vc-git-grep
Date: Thu, 09 Nov 2023 16:59:04 +0200

> From: Alyssa Ross <hi <at> alyssa.is>
> Date: Thu,  9 Nov 2023 15:46:30 +0100
> 
> ---
>  lisp/vc/vc-git.el | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el
> index 707fc7cfc07..fe48d5fbd3d 100644
> --- a/lisp/vc/vc-git.el
> +++ b/lisp/vc/vc-git.el
> @@ -1930,6 +1930,7 @@ vc-git-prepare-patch
>  (defvar compilation-environment)
>  
>  ;; Derived from `lgrep'.
> +;;;###autoload
>  (defun vc-git-grep (regexp &optional files dir)
>    "Run git grep, searching for REGEXP in FILES in directory DIR.
>  The search is limited to file names matching shell pattern FILES.

Thanks, but please explain the motivation.  Which package needs to
autoload this function and why?

Message #11 received at 67018 <at> debbugs.gnu.org (full text, mbox):

From: Alyssa Ross <hi <at> alyssa.is>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 67018 <at> debbugs.gnu.org
Subject: Re: bug#67018: [PATCH] Add autoload cookie to vc-git-grep
Date: Thu, 09 Nov 2023 16:05:32 +0100

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Alyssa Ross <hi <at> alyssa.is>
>> Date: Thu,  9 Nov 2023 15:46:30 +0100
>> 
>> ---
>>  lisp/vc/vc-git.el | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el
>> index 707fc7cfc07..fe48d5fbd3d 100644
>> --- a/lisp/vc/vc-git.el
>> +++ b/lisp/vc/vc-git.el
>> @@ -1930,6 +1930,7 @@ vc-git-prepare-patch
>>  (defvar compilation-environment)
>>  
>>  ;; Derived from `lgrep'.
>> +;;;###autoload
>>  (defun vc-git-grep (regexp &optional files dir)
>>    "Run git grep, searching for REGEXP in FILES in directory DIR.
>>  The search is limited to file names matching shell pattern FILES.
>
> Thanks, but please explain the motivation.  Which package needs to
> autoload this function and why?

Often running M-x vc-git-grep is the first thing I do after starting
Emacs.  I think it would be good if it was autoloaded, so I didn't have
to M-x load-library vc-git first, or try to set up autoloading just for
myself in my Emacs configuration.

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 67018 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Alyssa Ross <hi <at> alyssa.is>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 67018 <at> debbugs.gnu.org
Subject: Re: bug#67018: [PATCH] Add autoload cookie to vc-git-grep
Date: Thu, 09 Nov 2023 17:13:53 +0200

> From: Alyssa Ross <hi <at> alyssa.is>
> Cc: 67018 <at> debbugs.gnu.org
> Date: Thu, 09 Nov 2023 16:05:32 +0100
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> +;;;###autoload
> >>  (defun vc-git-grep (regexp &optional files dir)
> >>    "Run git grep, searching for REGEXP in FILES in directory DIR.
> >>  The search is limited to file names matching shell pattern FILES.
> >
> > Thanks, but please explain the motivation.  Which package needs to
> > autoload this function and why?
> 
> Often running M-x vc-git-grep is the first thing I do after starting
> Emacs.  I think it would be good if it was autoloaded, so I didn't have
> to M-x load-library vc-git first, or try to set up autoloading just for
> myself in my Emacs configuration.

By the same token we should autoload every command in every Lisp
package we have?  Because there are a lot of commands that are not
autoloaded, and you need to load their package to have them available.
I wonder what Dmitry and Stefan (both of them) think about this.

Message #17 received at 67018 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Eli Zaretskii <eliz <at> gnu.org>, Alyssa Ross <hi <at> alyssa.is>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 67018 <at> debbugs.gnu.org
Subject: Re: bug#67018: [PATCH] Add autoload cookie to vc-git-grep
Date: Thu, 9 Nov 2023 21:34:12 +0200

On 09/11/2023 17:13, Eli Zaretskii wrote:
>> From: Alyssa Ross<hi <at> alyssa.is>
>> Cc:67018 <at> debbugs.gnu.org
>> Date: Thu, 09 Nov 2023 16:05:32 +0100
>>
>> Eli Zaretskii<eliz <at> gnu.org>  writes:
>>
>>>> +;;;###autoload
>>>>   (defun vc-git-grep (regexp &optional files dir)
>>>>     "Run git grep, searching for REGEXP in FILES in directory DIR.
>>>>   The search is limited to file names matching shell pattern FILES.
>>> Thanks, but please explain the motivation.  Which package needs to
>>> autoload this function and why?
>> Often running M-x vc-git-grep is the first thing I do after starting
>> Emacs.  I think it would be good if it was autoloaded, so I didn't have
>> to M-x load-library vc-git first, or try to set up autoloading just for
>> myself in my Emacs configuration.
> By the same token we should autoload every command in every Lisp
> package we have?  Because there are a lot of commands that are not
> autoloaded, and you need to load their package to have them available.
> I wonder what Dmitry and Stefan (both of them) think about this.

A lot of commands don't make sense outside of major or minor mode, so we 
only have to autoload the modes in those cases.

If 'vc-git-grep' is an independent entry point, it should make sense to 
autoload it. I suppose vc-git is not loaded at the beginning of the 
session because no [Git-controlled] file has been visited yet.

I think I'd also like to advertise 'project-find-regexp' (bound to 'C-x 
p g'). Just in case Alyssa was not aware of it.

Message #20 received at 67018 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Dmitry Gutov <dmitry <at> gutov.dev>, Eli Zaretskii <eliz <at> gnu.org>,
 Alyssa Ross <hi <at> alyssa.is>, Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 67018 <at> debbugs.gnu.org
Subject: Re: bug#67018: [PATCH] Add autoload cookie to vc-git-grep
Date: Sun, 24 Dec 2023 06:47:44 -0800

Dmitry Gutov <dmitry <at> gutov.dev> writes:

> If 'vc-git-grep' is an independent entry point, it should make sense to
> autoload it. I suppose vc-git is not loaded at the beginning of the
> session because no [Git-controlled] file has been visited yet.
>
> I think I'd also like to advertise 'project-find-regexp' (bound to 'C-x
> p g'). Just in case Alyssa was not aware of it.

Makes sense to me.  So should we install this change?

Message #23 received at 67018 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Stefan Kangas <stefankangas <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>,
 Alyssa Ross <hi <at> alyssa.is>, Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 67018 <at> debbugs.gnu.org
Subject: Re: bug#67018: [PATCH] Add autoload cookie to vc-git-grep
Date: Sun, 24 Dec 2023 18:37:32 +0200

On 24/12/2023 16:47, Stefan Kangas wrote:
> Dmitry Gutov<dmitry <at> gutov.dev>  writes:
> 
>> If 'vc-git-grep' is an independent entry point, it should make sense to
>> autoload it. I suppose vc-git is not loaded at the beginning of the
>> session because no [Git-controlled] file has been visited yet.
>>
>> I think I'd also like to advertise 'project-find-regexp' (bound to 'C-x
>> p g'). Just in case Alyssa was not aware of it.
> Makes sense to me.  So should we install this change?

My opinion is yes, in case that wasn't clear from the previous message.

Message #30 received at 67018-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Dmitry Gutov <dmitry <at> gutov.dev>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 67018-done <at> debbugs.gnu.org,
 Alyssa Ross <hi <at> alyssa.is>, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#67018: [PATCH] Add autoload cookie to vc-git-grep
Date: Thu, 11 Jan 2024 13:17:59 -0800

Dmitry Gutov <dmitry <at> gutov.dev> writes:

> On 24/12/2023 16:47, Stefan Kangas wrote:
>> Dmitry Gutov<dmitry <at> gutov.dev>  writes:
>>
>>> If 'vc-git-grep' is an independent entry point, it should make sense to
>>> autoload it. I suppose vc-git is not loaded at the beginning of the
>>> session because no [Git-controlled] file has been visited yet.
>>>
>>> I think I'd also like to advertise 'project-find-regexp' (bound to 'C-x
>>> p g'). Just in case Alyssa was not aware of it.
>> Makes sense to me.  So should we install this change?
>
> My opinion is yes, in case that wasn't clear from the previous message.

Now done (commit e4e89e2cb66).  Thanks for the patch, Alyssa.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.