Received: (at 67026-done) by debbugs.gnu.org; 2 Dec 2023 18:10:19 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Dec 02 13:10:19 2023 Received: from localhost ([127.0.0.1]:58597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1r9URX-0001Aq-Dy for submit <at> debbugs.gnu.org; Sat, 02 Dec 2023 13:10:19 -0500 Received: from 46.233.146.77.rev.sfr.net ([77.146.233.46]:36450 helo=lepiller.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <julien@HIDDEN>) id 1r9URV-0001AP-3H for 67026-done <at> debbugs.gnu.org; Sat, 02 Dec 2023 13:10:18 -0500 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 50f6768c; Sat, 2 Dec 2023 18:10:00 +0000 (UTC) Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id c2d0e551 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Sat, 2 Dec 2023 18:10:00 +0000 (UTC) Date: Sat, 2 Dec 2023 19:10:00 +0100 From: Julien Lepiller <julien@HIDDEN> To: Ludovic =?UTF-8?B?Q291cnTDqHM=?= <ludo@HIDDEN> Subject: Re: [bug#67026] [PATCH] gnu: josm: Reduce closure size. Message-ID: <20231202191000.6b47a4bd@HIDDEN> In-Reply-To: <871qc4j468.fsf@HIDDEN> References: <20231109195755.67182db2@HIDDEN> <871qc4j468.fsf@HIDDEN> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 67026-done Cc: 67026-done <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.6 (/) Le Sat, 02 Dec 2023 11:21:19 +0100, Ludovic Court=C3=A8s <ludo@HIDDEN> a =C3=A9crit : > Hi Julien, >=20 > Julien Lepiller <julien@HIDDEN> skribis: >=20 > > This small patchset reduces josm's (the Java OSM editor) closure > > size from 1.781MB to 544MB (1.2GB reduction!). =20 >=20 > Wo0t, well done! >=20 > > This is mostly due to no longer referencing two JDKs. =20 >=20 > Heh. >=20 > LGTM! >=20 > Ludo=E2=80=99. Thanks, pushed to master as 406e46a15965bcb9e68e7c0bf09f14b9c72c6498 - 06ebc45e15f2a1bd4526a5a716eed657c902a0c1
Julien Lepiller <julien@HIDDEN>:Julien Lepiller <julien@HIDDEN>:Received: (at 67026) by debbugs.gnu.org; 2 Dec 2023 10:21:39 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Dec 02 05:21:39 2023 Received: from localhost ([127.0.0.1]:56681 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1r9N7z-0008Qb-Ba for submit <at> debbugs.gnu.org; Sat, 02 Dec 2023 05:21:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52434) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1r9N7w-0008QN-O1 for 67026 <at> debbugs.gnu.org; Sat, 02 Dec 2023 05:21:37 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1r9N7i-0000g9-6K; Sat, 02 Dec 2023 05:21:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=z4Fx6d3wMRaKPSeJF7KYnrZ8iabdhfDEcR+cInpmS9Q=; b=aRG8jgE5yaRwNby9zUps 948liW5WxDpelE/J5AfuiRoOCXS0cCQKcOY+0+TYT3ss6PAtaDwrn11gsB8fBd2pgcW146M45YgDt MHtUWSq1m3yrUKrV99nlviFjKYCmr2mhhjp9rsdZWpBLPVVlouH4BsTcnS1qopQ4iyLS9dQPIAJAa Abt48gAhTpk98AKWr35k5U3MUVI+qkzF5GgRIbIRGwt9TTkcUyTEfjCwJ9rq+3VVKMwXUPwZOKpfB YP48NpVTd+dL7FZR1VNT8/Ld2inTrpB3TJX1Q7qB5p4E9eEe2SmxOWu29AEXLwDEUfo9qEm77VTed 1ZpjsywXrIpzmw==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN> To: Julien Lepiller <julien@HIDDEN> Subject: Re: [bug#67026] [PATCH] gnu: josm: Reduce closure size. In-Reply-To: <20231109195755.67182db2@HIDDEN> (Julien Lepiller's message of "Thu, 9 Nov 2023 19:57:55 +0100") References: <20231109195755.67182db2@HIDDEN> Date: Sat, 02 Dec 2023 11:21:19 +0100 Message-ID: <871qc4j468.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67026 Cc: 67026 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Hi Julien, Julien Lepiller <julien@HIDDEN> skribis: > This small patchset reduces josm's (the Java OSM editor) closure size > from 1.781MB to 544MB (1.2GB reduction!). Wo0t, well done! > This is mostly due to no longer referencing two JDKs. Heh. LGTM! Ludo=E2=80=99.
guix-patches@HIDDEN:bug#67026; Package guix-patches.
Full text available.
Received: (at 67026) by debbugs.gnu.org; 9 Nov 2023 19:14:08 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 09 14:14:08 2023
Received: from localhost ([127.0.0.1]:48758 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1r1ATg-0005ne-IP
for submit <at> debbugs.gnu.org; Thu, 09 Nov 2023 14:14:08 -0500
Received: from lepiller.eu ([2a00:5884:8208::1]:42472 helo=hermes.lepiller.eu)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <julien@HIDDEN>) id 1r1ATY-0005mb-Oi
for 67026 <at> debbugs.gnu.org; Thu, 09 Nov 2023 14:14:04 -0500
Received: from hermes.lepiller.eu (localhost [127.0.0.1])
by hermes.lepiller.eu (OpenSMTPD) with ESMTP id 2361c6ab
for <67026 <at> debbugs.gnu.org>; Thu, 9 Nov 2023 19:13:17 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=from:to
:subject:date:message-id:in-reply-to:references:mime-version
:content-transfer-encoding; s=dkim; bh=kxZwUG/cxqj2gm3aLWQnZDfJr
bDxKNmzAAwuwMhNtEA=; b=WapV8Knce1jMztdVR4U8S6TBRBx9y6T036DNRnCTC
hN5y5IpxrLU3aaZR5Ki/I/oquli2espo2THyhoCOngU6O0eDNEOOCqu6GIytEa3y
ikiG9qAkchIjVBfQqz4d4rQK5EwbgMZB4nVs2Updt0jzo58L+JbM4Sza8vfKPPRJ
K34xTgOqAhmxu+9BwUbe0KYcYN/f4dV9huUu9ySJUhA7mInuWABtFBxxDYVGe6ej
3ou2CDxy2buP5mnfOKcqpRc/94wAm1SZHdR7Hh6rTkDYLvvQInFK8BvgDTmrok3A
ogfY5u9wFXcJjzMHAFqwNGRx904dxcWNj4PTprmCySSLA==
Received: by hermes.lepiller.eu (OpenSMTPD) with ESMTPSA id b7e57fdc
(TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for <67026 <at> debbugs.gnu.org>;
Thu, 9 Nov 2023 19:13:16 +0000 (UTC)
From: Julien Lepiller <julien@HIDDEN>
To: 67026 <at> debbugs.gnu.org
Subject: [PATCH 2/3] gnu: java-openjfx-graphics: Make java-swt optional.
Date: Thu, 9 Nov 2023 20:13:08 +0100
Message-ID: <20231109191309.6876-2-julien@HIDDEN>
X-Mailer: git-send-email 2.41.0
In-Reply-To: <20231109191309.6876-1-julien@HIDDEN>
References: <20231109191309.6876-1-julien@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 67026
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
It is used for an optional part of openjfx and not used by current
packages in Guix. Swt has a reference to a library in the JDK and has a
huge closure size because of that. This reduces closure by 1GB for this
package and dependents (including josm).
* gnu/packages/java.scm (java-openjfx-graphics)[native-inputs]: Move java-swt...
[inputs]: ...to here.
Change-Id: I7d8cb14569d5a9f451944695225a2dff143bf190
---
gnu/packages/java.scm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index eded386a03..d73550c042 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -2311,7 +2311,9 @@ (define-public java-openjfx-graphics
(string-append target new-name))))
(find-files "netbeans" "\\.so$"))))))))
(propagated-inputs
- (list java-openjfx-base java-swt))
+ (list java-openjfx-base))
+ (inputs
+ (list java-swt))
;; XXX: for unknown reasons
;; modules/graphics/src/main/native-prism-sw/JNativeSurface.c is missing
;; in this revision.
--
2.41.0
guix-patches@HIDDEN:bug#67026; Package guix-patches.
Full text available.
Received: (at 67026) by debbugs.gnu.org; 9 Nov 2023 19:14:05 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 09 14:14:05 2023
Received: from localhost ([127.0.0.1]:48756 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1r1ATd-0005nU-AQ
for submit <at> debbugs.gnu.org; Thu, 09 Nov 2023 14:14:05 -0500
Received: from lepiller.eu ([89.234.186.109]:47832 helo=hermes.lepiller.eu)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <julien@HIDDEN>) id 1r1ATa-0005mY-3P
for 67026 <at> debbugs.gnu.org; Thu, 09 Nov 2023 14:14:02 -0500
Received: from hermes.lepiller.eu (localhost [127.0.0.1])
by hermes.lepiller.eu (OpenSMTPD) with ESMTP id 2e28ed03
for <67026 <at> debbugs.gnu.org>; Thu, 9 Nov 2023 19:13:17 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=from:to
:subject:date:message-id:in-reply-to:references:mime-version
:content-transfer-encoding; s=dkim; bh=+EAmRYDG3vpJGXMJ0Z3vOClCO
wWVl6g8LjE/zlir+TY=; b=Hcws3uyhAPkb4ye5c1bBNDdeK6L9eu1If9YNoX7lL
X4IBlyoz/sNU7XBaQWTI98tDgAiwoEGWcok6rpEJTUYt7rrTIhaMcrorirdSsUTv
ApGDrnGbLkBu7vq2JbhTTD3OZiSjt/LpM0+EJkqO1fF1F9JegTRfo5MCCz0rc2xZ
VbEKBtlFN2M9re5K+mlqBEHiNczVh7lZrdCU2LC1jGN+i7itVNiGrPtCKB2OVVl1
DyIQFnqw7tub7k6vmhNA7EBjOrS77FlyOueWLmWvQWqLTMY+WPPVyTyBJyJTDFt0
yNG6r6xANmSiTSaFRg7ai/4WVMbpPxtsDFGFQznWK0wRg==
Received: by hermes.lepiller.eu (OpenSMTPD) with ESMTPSA id 713882dc
(TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for <67026 <at> debbugs.gnu.org>;
Thu, 9 Nov 2023 19:13:16 +0000 (UTC)
From: Julien Lepiller <julien@HIDDEN>
To: 67026 <at> debbugs.gnu.org
Subject: [PATCH 3/3] gnu: josm: Reduce closure size.
Date: Thu, 9 Nov 2023 20:13:09 +0100
Message-ID: <20231109191309.6876-3-julien@HIDDEN>
X-Mailer: git-send-email 2.41.0
In-Reply-To: <20231109191309.6876-1-julien@HIDDEN>
References: <20231109191309.6876-1-julien@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 67026
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
This saves 240MB of closure size.
* gnu/packages/geo.scm (josm)[inputs]: Add openjdk11.
[arguments]: Filter native inputs out of CLASSPATH. Use `java' from
openjdk11 instead of the JDK.
Change-Id: Ifa03b5cd033c5866d22e7557119284be0ea25a0e
---
gnu/packages/geo.scm | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/gnu/packages/geo.scm b/gnu/packages/geo.scm
index dbc8440141..746b22a082 100644
--- a/gnu/packages/geo.scm
+++ b/gnu/packages/geo.scm
@@ -1970,7 +1970,8 @@ (define-public josm
java-openjfx-media
java-parsson ; runtime dependency
java-signpost-core
- java-svg-salamander))
+ java-svg-salamander
+ openjdk11))
(arguments
`(#:tests? #f
#:jar-name "josm.jar"
@@ -2070,9 +2071,16 @@ (define-public josm
(lambda _
(display
(string-append "#!/bin/sh\n"
- (assoc-ref inputs "jdk") "/bin/java"
+ (assoc-ref inputs "openjdk") "/bin/java"
" -cp " out "/share/java/josm.jar:"
- (getenv "CLASSPATH")
+ ;; CLASSPATH, but remove native inputs
+ (string-join
+ (filter
+ (lambda (jar)
+ (and (not (string-contains jar "-jdk/"))
+ (not (string-contains jar "-javacc-"))))
+ (string-split (getenv "CLASSPATH") #\:))
+ ":")
" org.openstreetmap.josm.gui.MainApplication"))))
(chmod (string-append bin "/josm") #o755))
#t)))))
--
2.41.0
guix-patches@HIDDEN:bug#67026; Package guix-patches.
Full text available.
Received: (at 67026) by debbugs.gnu.org; 9 Nov 2023 19:14:03 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 09 14:14:03 2023
Received: from localhost ([127.0.0.1]:48754 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1r1ATa-0005nA-Qh
for submit <at> debbugs.gnu.org; Thu, 09 Nov 2023 14:14:03 -0500
Received: from lepiller.eu ([89.234.186.109]:47832 helo=hermes.lepiller.eu)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <julien@HIDDEN>) id 1r1ATX-0005mY-7d
for 67026 <at> debbugs.gnu.org; Thu, 09 Nov 2023 14:14:01 -0500
Received: from hermes.lepiller.eu (localhost [127.0.0.1])
by hermes.lepiller.eu (OpenSMTPD) with ESMTP id 9b4227b0
for <67026 <at> debbugs.gnu.org>; Thu, 9 Nov 2023 19:13:16 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=from:to
:subject:date:message-id:mime-version:content-type
:content-transfer-encoding; s=dkim; bh=F7xk2bXyiuWelmltKc9D7m1xw
cqdIWPf2xBifRWyklI=; b=j9V8SzvAQDzIFoyUGIWXzLEMjL/0nVirbghdcravZ
cKf+T/dCGEFk7MAZSl1SzkKx4L0HR0xYrgJPjWW7vVYDtMLFxrUlnF0GZ5iWIi5o
S6TvEOThf1hzWezglHuM6wYZ7+CVMbh2fXAvinxNDLlF22LKGxXB7WXAriDc3rG9
ZNet1c2/sWcgHl5vGW0XfOEo9/V+xp5kiNk7vEfDHegQXTilN0RQAHfC/Q/K3X3V
cdLcndU2IcVdof4hQxFPu6O/ik1zi7E9Y3pBADMLQZ38UJf6iiHQ7LCXzhFO/6Ee
AsbBf+ka17gXOAbdQ9io/SKHY1W3+m6j7q1mj4HPD3ooA==
Received: by hermes.lepiller.eu (OpenSMTPD) with ESMTPSA id 74ea1af7
(TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for <67026 <at> debbugs.gnu.org>;
Thu, 9 Nov 2023 19:13:16 +0000 (UTC)
From: Julien Lepiller <julien@HIDDEN>
To: 67026 <at> debbugs.gnu.org
Subject: [PATCH 1/3] gnu: javacc: Do not reference a jdk.
Date: Thu, 9 Nov 2023 20:13:07 +0100
Message-ID: <20231109191309.6876-1-julien@HIDDEN>
X-Mailer: git-send-email 2.41.0
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 67026
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
The jdk provides java and javac, while a jre only provides the necessary
java, reducing the closure size by 350MB.
* gnu/packages/java.scm (javacc): Remove #t at end of phases.
[inputs]: Add icedtea-8 as the jre.
[arguments]: Use it instead of the jdk.
Change-Id: Icb218c40915550b7ff1db96a48a3c48fa6ef52b4
---
gnu/packages/java.scm | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index 7c8c4e0a36..eded386a03 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -2465,8 +2465,7 @@ (define-public javacc
(modules '((guix build utils)))
;; Delete bundled jars.
(snippet '(begin (for-each delete-file-recursively
- '("bootstrap" "lib"))
- #t))))
+ '("bootstrap" "lib"))))))
(arguments
`(#:make-flags ; bootstrap from javacc-4
,#~(list (string-append "-Dbootstrap-jar="
@@ -2487,17 +2486,16 @@ (define-public javacc
(lambda _
(display
(string-append "#!/bin/sh\n"
- (assoc-ref inputs "jdk") "/bin/java"
+ (assoc-ref inputs "icedtea") "/bin/java"
" -cp " dir "/javacc.jar" " `basename $0`" " $*"))))
(chmod javacc #o755)
;; symlink to different names to affect the first argument and
;; change the behavior of the jar file.
(symlink javacc (string-append bin "/jjdoc"))
- (symlink javacc (string-append bin "/jjtree"))
- #t))))))
-
+ (symlink javacc (string-append bin "/jjtree"))))))))
(native-inputs
- (list javacc-4))))
+ (list javacc-4))
+ (inputs (list icedtea-8))))
(define-public java-ecj
(package
--
2.41.0
guix-patches@HIDDEN:bug#67026; Package guix-patches.
Full text available.Received: (at submit) by debbugs.gnu.org; 9 Nov 2023 18:58:59 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 09 13:58:59 2023 Received: from localhost ([127.0.0.1]:48746 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1r1AEx-0005PE-JX for submit <at> debbugs.gnu.org; Thu, 09 Nov 2023 13:58:59 -0500 Received: from lists.gnu.org ([2001:470:142::17]:38832) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <julien@HIDDEN>) id 1r1AEs-0005Ox-DV for submit <at> debbugs.gnu.org; Thu, 09 Nov 2023 13:58:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <julien@HIDDEN>) id 1r1AE9-0002DH-BX for guix-patches@HIDDEN; Thu, 09 Nov 2023 13:58:05 -0500 Received: from lepiller.eu ([89.234.186.109] helo=hermes.lepiller.eu) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <julien@HIDDEN>) id 1r1AE7-0006wJ-9W for guix-patches@HIDDEN; Thu, 09 Nov 2023 13:58:05 -0500 Received: from hermes.lepiller.eu (localhost [127.0.0.1]) by hermes.lepiller.eu (OpenSMTPD) with ESMTP id 785fe9cc for <guix-patches@HIDDEN>; Thu, 9 Nov 2023 18:57:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:subject:message-id:mime-version:content-type :content-transfer-encoding; s=dkim; bh=tN+Ur7ldCdNywewL9DYR0UJ3a CscJMI3NQN8ukZWYHo=; b=Qt1+MswLq80Sb0sbDS8E+Q+GojpOiwf5GXivV6Lj8 4u0C/9QzxCSClgBWcguaTneeEw1wlRpzSzKbaUH9VlVp9DjOk9L77sqiYRmcZPwD X4n7VwfUpq54OfUOccfZZLVOGMcDux/WvkF8S1Ip6frKMEQ2dL8aIyIilwkji3fH XYZDho88zBF2P4V6EzrHnunIg5O+yGaUxjsfqxZH/cWDnAHuAh0a1Cfr1166Pddy TKx0u++sechjTH6blyvP8KX9usYcciAvw4Iv2J3OAbfqFPjgM1yn2nJupV05uhOH c5y9/+n1M3wduQKXO5JSlO2iXDah+GXRIPro3aE6no7GA== Received: by hermes.lepiller.eu (OpenSMTPD) with ESMTPSA id 0197305f (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for <guix-patches@HIDDEN>; Thu, 9 Nov 2023 18:57:56 +0000 (UTC) Date: Thu, 9 Nov 2023 19:57:55 +0100 From: Julien Lepiller <julien@HIDDEN> To: guix-patches@HIDDEN Subject: [PATCH] gnu: josm: Reduce closure size. Message-ID: <20231109195755.67182db2@HIDDEN> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=89.234.186.109; envelope-from=julien@HIDDEN; helo=hermes.lepiller.eu X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) Hi Guix! This small patchset reduces josm's (the Java OSM editor) closure size from 1.781MB to 544MB (1.2GB reduction!). This is mostly due to no longer referencing two JDKs.
Julien Lepiller <julien@HIDDEN>:guix-patches@HIDDEN.
Full text available.guix-patches@HIDDEN:bug#67026; Package guix-patches.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.