GNU bug report logs - #67028
29.1; WDired should restore the previous `mode-name' when returning to Dired mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 67028 in the body.
You can then email your comments to 67028 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: 29.1; WDired should restore the previous `mode-name' when returning
 to Dired mode
Date: Thu, 9 Nov 2023 20:00:25 +0000

Dunno how simple and sure this would be to do, but I think that when you
quit WDired the mode-line should show the same `mode-name' it showed
before you entered WDired.  E.g., if the `mode-name' was "Dired by name"
then it should be restored to that.

Instead, when you quit WDired the `mode-name' is always set to just
"Dired".  You lose the info that the sorting is by name or by date.

Seems like `wdired-change-to-dired-mode' could just save the `mode-name'
before it changes mode.  And then `wdired-change-to-dired-mode' to
restore that saved `mode-name' value.

In GNU Emacs 29.1 (build 2, x86_64-w64-mingw32) of 2023-08-02 built on
 AVALON
Windowing system distributor 'Microsoft Corp.', version 10.0.19045
System Description: Microsoft Windows 10 Pro (v10.0.2009.19045.3570)

Configured using:
 'configure --with-modules --without-dbus --with-native-compilation=aot
 --without-compress-install --with-tree-sitter CFLAGS=-O2'

Configured features:
ACL GIF GMP GNUTLS HARFBUZZ JPEG JSON LCMS2 LIBXML2 MODULES NATIVE_COMP
NOTIFY W32NOTIFY PDUMPER PNG RSVG SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XPM ZLIB

(NATIVE_COMP present but libgccjit not available)

Message #8 received at 67028 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 67028 <at> debbugs.gnu.org
Subject: Re: bug#67028: 29.1;
 WDired should restore the previous `mode-name' when returning to
 Dired mode
Date: Fri, 10 Nov 2023 10:09:35 +0200

> From: Drew Adams <drew.adams <at> oracle.com>
> Date: Thu, 9 Nov 2023 20:00:25 +0000
> 
> Dunno how simple and sure this would be to do, but I think that when you
> quit WDired the mode-line should show the same `mode-name' it showed
> before you entered WDired.  E.g., if the `mode-name' was "Dired by name"
> then it should be restored to that.
> 
> Instead, when you quit WDired the `mode-name' is always set to just
> "Dired".  You lose the info that the sorting is by name or by date.

Thanks.  Does the patch below give good results?

diff --git a/lisp/wdired.el b/lisp/wdired.el
index 7b9c75d..079d93d 100644
--- a/lisp/wdired.el
+++ b/lisp/wdired.el
@@ -453,7 +453,7 @@ wdired-change-to-dired-mode
   (force-mode-line-update)
   (setq buffer-read-only t)
   (setq major-mode 'dired-mode)
-  (setq mode-name "Dired")
+  (dired-sort-set-mode-line)
   (dired-advertise)
   (dired-hide-details-update-invisibility-spec)
   (remove-hook 'kill-buffer-hook #'wdired-check-kill-buffer t)

Message #11 received at 67028 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: "67028 <at> debbugs.gnu.org" <67028 <at> debbugs.gnu.org>
Subject: RE: [External] : Re: bug#67028: 29.1; WDired should restore the
 previous `mode-name' when returning to Dired mode
Date: Fri, 10 Nov 2023 17:21:29 +0000

> Thanks.  Does the patch below give good results?

LGTM - thx.

Message #16 received at 67028-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 67028-done <at> debbugs.gnu.org
Subject: Re: [External] : Re: bug#67028: 29.1; WDired should restore the
 previous `mode-name' when returning to Dired mode
Date: Fri, 10 Nov 2023 21:55:46 +0200

> From: Drew Adams <drew.adams <at> oracle.com>
> CC: "67028 <at> debbugs.gnu.org" <67028 <at> debbugs.gnu.org>
> Date: Fri, 10 Nov 2023 17:21:29 +0000
> 
> > Thanks.  Does the patch below give good results?
> 
> LGTM - thx.

Thanks, installed on master, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.