Received: (at 67031) by debbugs.gnu.org; 21 Nov 2023 11:45:10 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 21 06:45:10 2023 Received: from localhost ([127.0.0.1]:55295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1r5PBX-0005h1-Fs for submit <at> debbugs.gnu.org; Tue, 21 Nov 2023 06:45:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45888) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1r5PBV-0005gm-Ix for 67031 <at> debbugs.gnu.org; Tue, 21 Nov 2023 06:44:54 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1r5PBN-0001x9-Br; Tue, 21 Nov 2023 06:44:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=yvkDc6/izpU4g0kpG3VzFizrAscnHTm2v9hhrRXykjY=; b=RVXnKepmF6HO AyRbifSUHbbFVYog8T+6Ia+kVYT8NqdzX2bfOswao0ZLTNpbnMXR3Xki85Qg2k36rOvUDQpcvWFKD z+DJ+XF5E1TLmlrfzpCIFnIVWB4/+9/nbUs75Jd6FDZT4aRbxeR3JFt7T9GQS6ekRaPrfuNIu7bLq XZth185GUPeu8mu18Hl+Uk3v7a9uHnSfBoG/OFcJ6psImnoK4Swq3uDVuwqW7NWTLDR/PnDUGtvb3 JdFxxggENO5U7mCT8+EgkrlV5iJ268B9A0yGacxtusZZwUvJD0Ye1bNEJ2vb8USoSuwvQzJfhbhQ2 LnPXkWxssA/Q99wquLckQw==; Date: Tue, 21 Nov 2023 13:44:32 +0200 Message-Id: <83cyw3ib4v.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Noah Peart <noah.v.peart@HIDDEN> In-Reply-To: <CAPVBTSfsFVeu1Po4Gfsx1idpaZLXW6uj+pwcsNpQv+VAftcs7w@HIDDEN> (message from Noah Peart on Mon, 20 Nov 2023 20:41:49 -0800) Subject: Re: bug#67031: [PATCH] Fix typescript-ts-mode indentation in unbracketed statements References: <CAPVBTSf7dQWTYwXZELABDaSXCR0EEvKKnBzksAfyo3wr5K2_Tg@HIDDEN> <83pm0bqgm7.fsf@HIDDEN> <98ce09c9-00a1-f5ad-79ad-ed4b8328ac31@HIDDEN> <83pm07ml54.fsf@HIDDEN> <CAPVBTSf5n0X+TGbZ=Y1i_ExP=MzcTx-zhOC2UY_2Fr4Q3D0FxA@HIDDEN> <475bca51-dd02-46c5-0114-9588b43b756b@HIDDEN> <83sf52l1gs.fsf@HIDDEN> <bf36134b-c6ce-d78a-4b12-a3465cbfcfac@HIDDEN> <CAPVBTScosYtK8ouvXXWT0VqVWfwH7qNJmTck5gwtVpvQmQdejg@HIDDEN> <CAPVBTScnQFEvhiSc5Thp3ApRQzUgKyupHBMKEbgUoFAEitoFmA@HIDDEN> <CAPVBTSfdRrjtayk8q0kRHob_a3rBFaX6yjzSbi16nw3kp75vyw@HIDDEN> <d952331d-6019-b2ed-a1d8-db4ba751275c@HIDDEN> <83il5viy4y.fsf@HIDDEN> <CAPVBTSfsFVeu1Po4Gfsx1idpaZLXW6uj+pwcsNpQv+VAftcs7w@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67031 Cc: dmitry@HIDDEN, casouri@HIDDEN, 67031 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) > From: Noah Peart <noah.v.peart@HIDDEN> > Date: Mon, 20 Nov 2023 20:41:49 -0800 > Cc: Dmitry Gutov <dmitry@HIDDEN>, casouri@HIDDEN, 67031 <at> debbugs.gnu.org > > I believe my copyright assignment is on file - Eli, I think you checked for me > last month. Yes, sorry, my bad. I was coffee-challenged and therefore confused. So we can install this right away.
bug-gnu-emacs@HIDDEN:bug#67031; Package emacs.
Full text available.Received: (at 67031) by debbugs.gnu.org; 21 Nov 2023 04:42:21 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Nov 20 23:42:20 2023 Received: from localhost ([127.0.0.1]:54957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1r5IaZ-0002Km-Ut for submit <at> debbugs.gnu.org; Mon, 20 Nov 2023 23:42:20 -0500 Received: from mail-oa1-x2a.google.com ([2001:4860:4864:20::2a]:57553) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <noah.v.peart@HIDDEN>) id 1r5IaP-0002KD-6M for 67031 <at> debbugs.gnu.org; Mon, 20 Nov 2023 23:42:16 -0500 Received: by mail-oa1-x2a.google.com with SMTP id 586e51a60fabf-1f5bd86ceb3so2144361fac.2 for <67031 <at> debbugs.gnu.org>; Mon, 20 Nov 2023 20:42:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700541721; x=1701146521; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=KNRQQCGWnE2wUX04m0bqy7zXk8g06ATEmtU5r0d6F3g=; b=nZYsCu+mZuICcGvwyXkpzM/d0DGSm9wmVrv7edYAvSmj/3EJxu8jn0XDgkxCdkuKD/ 39fvNT4e8qN2OlKcyf306MkCBYYVquF3KQdQYEyyNl5XhFy/Qy+iTGqom7mNhYtRyoa3 UY13qFauPdVeqrQXFG4ORszxfEmQwVwPzKA1dZ2C1YdOrNBLgqfT2M7ZCJYuT3Sd6Wr4 h1HNu2JZspdpU15lIi2TzfXaCYjadvMGYXmMazDRk1bnegkWbYEuQKeI2BZNrhYv8YOh f6ZTlZ+cnqUi7CzIddTGRwDBQU10QoWbJGn1lhSf6aIoWqCy56p3KaKjm4Rp4HdJE9OE 1CCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700541721; x=1701146521; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KNRQQCGWnE2wUX04m0bqy7zXk8g06ATEmtU5r0d6F3g=; b=Pk4roq02zwOlVRE4eZSvD6s7Dsd2Mop6aHdr+0tPhymNN2wnmn8OU3NHs0d2mrceco MPQJPM4BllSkSrkkfdJoQdnerqbu91vMUS2FbVCnhgdxJty8SgkKx2VvnO1pSOY7O+Xl jLGyPSquIoVmy5uE6I7PxZ7jjWYLePnTCmhNCNBiBPEEPC9afeZKqJN8GH3O5qOxiyBD Fq/5zcDtkS7VajLkIo1qqDFqDtMpvrN360msdbrSJmN1d/YtBixkzVtGv21nBPjqc0lx uy7SidnFbYsGnwJrGOe7IqiFP1jqyf/Gm6rqOj3puaJpWZQvR51TcIwzUMHsLWQmjHui jZfg== X-Gm-Message-State: AOJu0YxLvcLPa38+jrgiE94FVgBe76DwV/4+dmmQNcjBSajYL7TA5FHx /Sv3h3ce2nezD86Eg/TBkfHDtx2ITcMWFQoOQmA= X-Google-Smtp-Source: AGHT+IEe9EqCSX7Omz4Lrv9AMy3RPcTJe1hru5kYuRbTZ5ToTlV+zBC/rOJ9Z1AvyuXSNIuvU1skQGwMY+ES5vxf/wA= X-Received: by 2002:a05:6871:9187:b0:1f9:6832:e241 with SMTP id ak7-20020a056871918700b001f96832e241mr1094047oac.36.1700541720905; Mon, 20 Nov 2023 20:42:00 -0800 (PST) MIME-Version: 1.0 References: <CAPVBTSf7dQWTYwXZELABDaSXCR0EEvKKnBzksAfyo3wr5K2_Tg@HIDDEN> <83pm0bqgm7.fsf@HIDDEN> <98ce09c9-00a1-f5ad-79ad-ed4b8328ac31@HIDDEN> <83pm07ml54.fsf@HIDDEN> <CAPVBTSf5n0X+TGbZ=Y1i_ExP=MzcTx-zhOC2UY_2Fr4Q3D0FxA@HIDDEN> <475bca51-dd02-46c5-0114-9588b43b756b@HIDDEN> <83sf52l1gs.fsf@HIDDEN> <bf36134b-c6ce-d78a-4b12-a3465cbfcfac@HIDDEN> <CAPVBTScosYtK8ouvXXWT0VqVWfwH7qNJmTck5gwtVpvQmQdejg@HIDDEN> <CAPVBTScnQFEvhiSc5Thp3ApRQzUgKyupHBMKEbgUoFAEitoFmA@HIDDEN> <CAPVBTSfdRrjtayk8q0kRHob_a3rBFaX6yjzSbi16nw3kp75vyw@HIDDEN> <d952331d-6019-b2ed-a1d8-db4ba751275c@HIDDEN> <83il5viy4y.fsf@HIDDEN> In-Reply-To: <83il5viy4y.fsf@HIDDEN> From: Noah Peart <noah.v.peart@HIDDEN> Date: Mon, 20 Nov 2023 20:41:49 -0800 Message-ID: <CAPVBTSfsFVeu1Po4Gfsx1idpaZLXW6uj+pwcsNpQv+VAftcs7w@HIDDEN> Subject: Re: bug#67031: [PATCH] Fix typescript-ts-mode indentation in unbracketed statements To: Eli Zaretskii <eliz@HIDDEN> Content-Type: multipart/alternative; boundary="000000000000334dc1060aa239ad" X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 67031 Cc: Dmitry Gutov <dmitry@HIDDEN>, casouri@HIDDEN, 67031 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --000000000000334dc1060aa239ad Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I believe my copyright assignment is on file - Eli, I think you checked for me last month. On Mon, Nov 20, 2023 at 7:27=E2=80=AFPM Eli Zaretskii <eliz@HIDDEN> wrote: > > Date: Tue, 21 Nov 2023 00:28:23 +0200 > > Cc: Eli Zaretskii <eliz@HIDDEN>, casouri@HIDDEN, > 67031 <at> debbugs.gnu.org > > From: Dmitry Gutov <dmitry@HIDDEN> > > > > On 20/11/2023 20:13, Noah Peart wrote: > > > Sorry, ignore the previous patch. A couple additional rules were > needed > > > to handle > > > "while" and "else". > > > > Looking good. > > > > Eli, should this go to emacs-29? > > Yes. But we should wait for Noah's legal paperwork to be completed, > before we install. > --000000000000334dc1060aa239ad Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">I believe my copyright assignment is on file - Eli, I thin= k you checked for me=C2=A0<div>last month.</div></div><br><div class=3D"gma= il_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Mon, Nov 20, 2023 at 7:2= 7=E2=80=AFPM Eli Zaretskii <<a href=3D"mailto:eliz@HIDDEN">eliz@HIDDEN= </a>> wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:= 0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">= > Date: Tue, 21 Nov 2023 00:28:23 +0200<br> > Cc: Eli Zaretskii <<a href=3D"mailto:eliz@HIDDEN" target=3D"_blank= ">eliz@HIDDEN</a>>, <a href=3D"mailto:casouri@HIDDEN" target=3D"_bla= nk">casouri@HIDDEN</a>, <a href=3D"mailto:67031 <at> debbugs.gnu.org" target= =3D"_blank">67031 <at> debbugs.gnu.org</a><br> > From: Dmitry Gutov <<a href=3D"mailto:dmitry@HIDDEN" target=3D"_= blank">dmitry@HIDDEN</a>><br> > <br> > On 20/11/2023 20:13, Noah Peart wrote:<br> > > Sorry, ignore the previous patch.=C2=A0 A couple additional rules= were needed <br> > > to handle<br> > > "while" and "else".<br> > <br> > Looking good.<br> > <br> > Eli, should this go to emacs-29?<br> <br> Yes.=C2=A0 But we should wait for Noah's legal paperwork to be complete= d,<br> before we install.<br> </blockquote></div> --000000000000334dc1060aa239ad--
bug-gnu-emacs@HIDDEN:bug#67031; Package emacs.
Full text available.Received: (at 67031) by debbugs.gnu.org; 21 Nov 2023 03:28:06 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Nov 20 22:28:06 2023 Received: from localhost ([127.0.0.1]:54891 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1r5HQj-0000LA-Q1 for submit <at> debbugs.gnu.org; Mon, 20 Nov 2023 22:28:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51110) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1r5HQh-0000Kg-K9 for 67031 <at> debbugs.gnu.org; Mon, 20 Nov 2023 22:28:04 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1r5HQZ-00023Q-Sq; Mon, 20 Nov 2023 22:27:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=HrplCZhngvmin6pDsHJhGPp4t1s7azuIErh2LRTb6Vo=; b=Y0XZygjH85YsrLr3j5tm vznWMXJAB4r3yDY355lCfMUb+8JKC2AQ/4KTUTkfdIDsPM6B0JhwI6EkeafacZns9RQWGDjBSMZIy 5d6uYQFq/YRl57wdVkukWJAhXrlsJMUHv3maD1m/mk9bYjV7j3yQrPEOGwukbWUYBUcbWoG1u2Sg6 S/GgAChF5r3MZWHXtMeGpIuyWR0LyIhvoZL7kWTauo5mI2frBNW3n9cNfa77PhXhbqL1kk2M3WGAe /ZpN1FRfEdq+s1hd4N4vgrYMXFHuqVoFpMg41CawV+W247RNTuJfpmbY/Rd4cL67LG4UmTXBfA0wY w4i8cG0XPjfhsA==; Date: Tue, 21 Nov 2023 05:27:41 +0200 Message-Id: <83il5viy4y.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Dmitry Gutov <dmitry@HIDDEN> In-Reply-To: <d952331d-6019-b2ed-a1d8-db4ba751275c@HIDDEN> (message from Dmitry Gutov on Tue, 21 Nov 2023 00:28:23 +0200) Subject: Re: bug#67031: [PATCH] Fix typescript-ts-mode indentation in unbracketed statements References: <CAPVBTSf7dQWTYwXZELABDaSXCR0EEvKKnBzksAfyo3wr5K2_Tg@HIDDEN> <83pm0bqgm7.fsf@HIDDEN> <98ce09c9-00a1-f5ad-79ad-ed4b8328ac31@HIDDEN> <83pm07ml54.fsf@HIDDEN> <CAPVBTSf5n0X+TGbZ=Y1i_ExP=MzcTx-zhOC2UY_2Fr4Q3D0FxA@HIDDEN> <475bca51-dd02-46c5-0114-9588b43b756b@HIDDEN> <83sf52l1gs.fsf@HIDDEN> <bf36134b-c6ce-d78a-4b12-a3465cbfcfac@HIDDEN> <CAPVBTScosYtK8ouvXXWT0VqVWfwH7qNJmTck5gwtVpvQmQdejg@HIDDEN> <CAPVBTScnQFEvhiSc5Thp3ApRQzUgKyupHBMKEbgUoFAEitoFmA@HIDDEN> <CAPVBTSfdRrjtayk8q0kRHob_a3rBFaX6yjzSbi16nw3kp75vyw@HIDDEN> <d952331d-6019-b2ed-a1d8-db4ba751275c@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67031 Cc: noah.v.peart@HIDDEN, casouri@HIDDEN, 67031 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Tue, 21 Nov 2023 00:28:23 +0200 > Cc: Eli Zaretskii <eliz@HIDDEN>, casouri@HIDDEN, 67031 <at> debbugs.gnu.org > From: Dmitry Gutov <dmitry@HIDDEN> > > On 20/11/2023 20:13, Noah Peart wrote: > > Sorry, ignore the previous patch. A couple additional rules were needed > > to handle > > "while" and "else". > > Looking good. > > Eli, should this go to emacs-29? Yes. But we should wait for Noah's legal paperwork to be completed, before we install.
bug-gnu-emacs@HIDDEN:bug#67031; Package emacs.
Full text available.Received: (at 67031) by debbugs.gnu.org; 20 Nov 2023 22:28:39 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Nov 20 17:28:39 2023 Received: from localhost ([127.0.0.1]:54793 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1r5Ckx-0001AX-7z for submit <at> debbugs.gnu.org; Mon, 20 Nov 2023 17:28:39 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:60225) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <dmitry@HIDDEN>) id 1r5Cku-0001AK-8b for 67031 <at> debbugs.gnu.org; Mon, 20 Nov 2023 17:28:38 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id CD4225C12EB; Mon, 20 Nov 2023 17:28:28 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 20 Nov 2023 17:28:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1700519308; x=1700605708; bh=NdbodLMKdO2rcxhAWZ6Eh8MxtS6dEnk4IS0 GaBsuprg=; b=C5TaBG/JcMDdJJb97nNlIfw46npNXN7O4wJ2InScupbgC4J1ZOC OWm7xq9lNmE+EKeaxM15LDS/BojI2fjGGgKtdMF0usuiNscot75sZsAY+tWcEGWs G+2dGBiJKz/ZoZKNlRqhKu1g8T7sUKhv5lsPXMbm9+uiSS7RjNzTec7rdDQqiiwY shkhJXbqRU8m8djP+0IFCnqbPsgHEWGOj3jLw4bGHdTs6T0lP7Aa87LxgjDLx63+ rnJdgRz/1AlOSyCSvd4Ag9Mssp8zV+4FNbyDHUe5uOyBqBOrFcqPM5nBwHsle9I8 WbwL532L3mmVBl8PLAhxqhTUBbYcWglGKNA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1700519308; x=1700605708; bh=NdbodLMKdO2rcxhAWZ6Eh8MxtS6dEnk4IS0 GaBsuprg=; b=wfddtbFZzfpMwJPvo1Y//FOkuNfu7GQpsj/eNcnxOkX0O2H0vtc vWhJPsIdB6JGDcLUfFCNbEqE6k1OCuAQr514A9y884xx6ejCgXNoRnXPc8/lFlUi TkPjsGKxegZiw9APTYDoHRpOk8n401dM+VlryyQO3zTbd3m705A7kTaEuhHD+4Ld An9nDdOyNUDpHdnULbEV9XIWejXrOXv1MOSOuYwqSBwBcvj2AydwxCOyeyWjKS9+ Zj09laJGwQv3Cq9yg349f/J4GEjzjsXW670bfpDPTdLPfb/LGTU8mLOdwXUwTqHJ G4loGRvgRwXYHJJVpSj4QWi8F0DQ3ggcb/w== X-ME-Sender: <xms:jN1bZdCbQNuWgh7t-gE_xjht0vLnZgHge3lZE4nQE9DW-tUUJtgHvg> <xme:jN1bZbhTNbKOtEd-Bwc6twMGewN6Hbgt57s53BgcP1Vm5IG33VBD6UgiV_6KolyPr 8oZygHubw8_GEFfM6g> X-ME-Received: <xmr:jN1bZYlN7H6DVRszTa1JRWn6HoB6-4Si1EibadBII_WcgpHwneUWP8Hcf-L1LAUMuMExpg> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudegjedgudefhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfevfhfhjggtgfesthekredttdefjeenucfhrhhomhepffhm ihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrg htthgvrhhnpefhffehleejffegffeugefhkeektdffgfehjedvgeejtedtudehueffgffg feejheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe gumhhithhrhiesghhuthhovhdruggvvh X-ME-Proxy: <xmx:jN1bZXyFdeVpkkvkJjgQCuXZJRE7g7B7bcWFrvgHRzz3v9P6oZ_fTw> <xmx:jN1bZSQCixuR5nxyiYKeytnakrzdavj3uE0nDW00E9Wn4aVGwwE3KQ> <xmx:jN1bZabdMlD9T6myfiwvCSqTjK-80PQYFwmxZT2vXmJPyDdvq4m8gQ> <xmx:jN1bZdevPkvFnv_6mV3HMDl_4KNGYePYXLwxd_7VT9I-OogJ-xw_IA> Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 20 Nov 2023 17:28:26 -0500 (EST) Message-ID: <d952331d-6019-b2ed-a1d8-db4ba751275c@HIDDEN> Date: Tue, 21 Nov 2023 00:28:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#67031: [PATCH] Fix typescript-ts-mode indentation in unbracketed statements Content-Language: en-US To: Noah Peart <noah.v.peart@HIDDEN> References: <CAPVBTSf7dQWTYwXZELABDaSXCR0EEvKKnBzksAfyo3wr5K2_Tg@HIDDEN> <83pm0bqgm7.fsf@HIDDEN> <98ce09c9-00a1-f5ad-79ad-ed4b8328ac31@HIDDEN> <83pm07ml54.fsf@HIDDEN> <CAPVBTSf5n0X+TGbZ=Y1i_ExP=MzcTx-zhOC2UY_2Fr4Q3D0FxA@HIDDEN> <475bca51-dd02-46c5-0114-9588b43b756b@HIDDEN> <83sf52l1gs.fsf@HIDDEN> <bf36134b-c6ce-d78a-4b12-a3465cbfcfac@HIDDEN> <CAPVBTScosYtK8ouvXXWT0VqVWfwH7qNJmTck5gwtVpvQmQdejg@HIDDEN> <CAPVBTScnQFEvhiSc5Thp3ApRQzUgKyupHBMKEbgUoFAEitoFmA@HIDDEN> <CAPVBTSfdRrjtayk8q0kRHob_a3rBFaX6yjzSbi16nw3kp75vyw@HIDDEN> From: Dmitry Gutov <dmitry@HIDDEN> In-Reply-To: <CAPVBTSfdRrjtayk8q0kRHob_a3rBFaX6yjzSbi16nw3kp75vyw@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 67031 Cc: Eli Zaretskii <eliz@HIDDEN>, 67031 <at> debbugs.gnu.org, casouri@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.9 (---) On 20/11/2023 20:13, Noah Peart wrote: > Sorry, ignore the previous patch. A couple additional rules were needed > to handle > "while" and "else". Looking good. Eli, should this go to emacs-29?
bug-gnu-emacs@HIDDEN:bug#67031; Package emacs.
Full text available.Received: (at 67031) by debbugs.gnu.org; 20 Nov 2023 18:13:45 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Nov 20 13:13:45 2023 Received: from localhost ([127.0.0.1]:54506 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1r58mH-0001mN-5H for submit <at> debbugs.gnu.org; Mon, 20 Nov 2023 13:13:45 -0500 Received: from mail-oa1-x2c.google.com ([2001:4860:4864:20::2c]:45112) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <noah.v.peart@HIDDEN>) id 1r58mE-0001lz-Bt for 67031 <at> debbugs.gnu.org; Mon, 20 Nov 2023 13:13:43 -0500 Received: by mail-oa1-x2c.google.com with SMTP id 586e51a60fabf-1f5d7db4dcbso1272476fac.2 for <67031 <at> debbugs.gnu.org>; Mon, 20 Nov 2023 10:13:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700504014; x=1701108814; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=7sm+ntqKRY6+4pgxiMpZ/vWOQgoXoOlmSdNHhBmTFj8=; b=Mc1Sd4agC1H6bejlnu9O0d5GAcCNoi0llsFaK+tnr38JjFApXJW4gKI/Yr6TitGywV 7pFI4Tvn0k7T5suxn/Zpvm9qM0v65EQtjgpEXujMv5DrGCh8WDfuiI6NS9RTBWdJLBj7 Ux2J/bvtETppRzLE1nTqfm53RnL80D4GQP9b4PeCNQUOcWuUoEehrD/dO+8eS9kigVfh YXkA6mbWefRlp2OE3xJvkXl2E+8A4KgjEhcAgUB3rhR3T8ohs0WNQ9gxYQb5W5WBjg5Q imU+uBgWDMe30vhKhpxfger86PBmNGILzRxyn4TW7uYHdOttszcnB1TsRQF5hILbt7rw nvfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700504014; x=1701108814; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7sm+ntqKRY6+4pgxiMpZ/vWOQgoXoOlmSdNHhBmTFj8=; b=mJ4qJ+JYmCb5YpxE168zbKCSziuQnvG2uNlxCJ6MReWSYPOPz3yCszzK44Kik6VYnQ 86MYbq/a87lHkPuw6thGlRzAQvKhAMEb4f8PfNbNDVm5BAU/jzQfe0XNYP1cc3fZjzuY 4JYRCEt8jGtgZo7+q8/ZiuxrVexVDvvtL5RHPwtb2jHJ2ulILp5FtbHsmrXw1MYrohXv fo7dRil4wK1ybDyRfBMUsE/amjJo1q5tDMYSDy5f3th34IztJ5HeT3PKj9dU7VRrCA/Z RoSgM73vhxd9U4H3b/NINj1BNsuRCbqB/NqxptN37Is6jIPlvr5D8Oyc2+rq8WELkzXS yVwQ== X-Gm-Message-State: AOJu0YxIynUDGzoL6aiFmf539ba9kcIxF4n12yGfNWjsoyBa92rHoOOm +r7Ue5lMlnMue9BQVZLzD3V3QisP+kFe1O8HXZ1aLGgHgFRNFw8mMWg= X-Google-Smtp-Source: AGHT+IGuOZpALDsJ/QEgTDzQ1N/nDTPW2x7HDsQFvIOqMmTrCTc4cLfBX+LkNmlzRb8ZqYi3LtG6pr8wgn1j4iUxIIg= X-Received: by 2002:a05:6870:2b0b:b0:1f0:36ab:2886 with SMTP id ld11-20020a0568702b0b00b001f036ab2886mr10937533oab.41.1700504014270; Mon, 20 Nov 2023 10:13:34 -0800 (PST) MIME-Version: 1.0 References: <CAPVBTSf7dQWTYwXZELABDaSXCR0EEvKKnBzksAfyo3wr5K2_Tg@HIDDEN> <83pm0bqgm7.fsf@HIDDEN> <98ce09c9-00a1-f5ad-79ad-ed4b8328ac31@HIDDEN> <83pm07ml54.fsf@HIDDEN> <CAPVBTSf5n0X+TGbZ=Y1i_ExP=MzcTx-zhOC2UY_2Fr4Q3D0FxA@HIDDEN> <475bca51-dd02-46c5-0114-9588b43b756b@HIDDEN> <83sf52l1gs.fsf@HIDDEN> <bf36134b-c6ce-d78a-4b12-a3465cbfcfac@HIDDEN> <CAPVBTScosYtK8ouvXXWT0VqVWfwH7qNJmTck5gwtVpvQmQdejg@HIDDEN> <CAPVBTScnQFEvhiSc5Thp3ApRQzUgKyupHBMKEbgUoFAEitoFmA@HIDDEN> In-Reply-To: <CAPVBTScnQFEvhiSc5Thp3ApRQzUgKyupHBMKEbgUoFAEitoFmA@HIDDEN> From: Noah Peart <noah.v.peart@HIDDEN> Date: Mon, 20 Nov 2023 10:13:23 -0800 Message-ID: <CAPVBTSfdRrjtayk8q0kRHob_a3rBFaX6yjzSbi16nw3kp75vyw@HIDDEN> Subject: Re: bug#67031: [PATCH] Fix typescript-ts-mode indentation in unbracketed statements To: Dmitry Gutov <dmitry@HIDDEN> Content-Type: multipart/mixed; boundary="000000000000b5d1d1060a99715d" X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 67031 Cc: Eli Zaretskii <eliz@HIDDEN>, 67031 <at> debbugs.gnu.org, casouri@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --000000000000b5d1d1060a99715d Content-Type: multipart/alternative; boundary="000000000000b5d1cf060a99715b" --000000000000b5d1cf060a99715b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sorry, ignore the previous patch. A couple additional rules were needed to handle "while" and "else". On Mon, Nov 20, 2023 at 10:07=E2=80=AFAM Noah Peart <noah.v.peart@HIDDEN= > wrote: > Here is an updated patch with the added "else_clause" and indentation tes= t > for > statements without braces. > > On Mon, Nov 20, 2023 at 4:55=E2=80=AFAM Noah Peart <noah.v.peart@HIDDEN= m> wrote: > >> Yea, I'm using the same. But, would it be useful to have a way to set >> that when >> running tests without needing to temporarily add set >> `treesit-extra-load-path` in >> the test file? >> >> On Sun, Nov 19, 2023 at 5:38=E2=80=AFAM Dmitry Gutov <dmitry@HIDDEN> = wrote: >> >>> On 19/11/2023 08:08, Eli Zaretskii wrote: >>> >> Date: Sun, 19 Nov 2023 03:24:49 +0200 >>> >> Cc:casouri@HIDDEN,67031 <at> debbugs.gnu.org >>> >> From: Dmitry Gutov<dmitry@HIDDEN> >>> >> >>> >> On 19/11/2023 02:12, Noah Peart wrote: >>> >>> Yea, I can do that. >>> >>> >>> >>> Is there a recipe for running the tests with a tree-sitter library >>> path? >>> >> You mean with the default tree-sitter librayr path overridden? I'm >>> not sure. >>> > Why would an ERT test need that? We are supposed to test Emacs with >>> > the otherwise installed system features. As tree-sitter grammars are >>> > not part of Emacs, there should be no need to tell Emacs to use a >>> > grammar library other than the one installed on the system. Right? >>> >>> We have a way to override that with the variable >>> treesit-extra-load-path, so it follows that some users will take >>> advantage of it to add extra directories. >>> >>> I'm using ~/.emacs.d/tree-sitter/ myself. >>> >> --000000000000b5d1cf060a99715b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">Sorry, ignore the previous patch.=C2=A0 A couple additiona= l rules were needed to handle=C2=A0<div>"while" and "else&qu= ot;.</div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gm= ail_attr">On Mon, Nov 20, 2023 at 10:07=E2=80=AFAM Noah Peart <<a href= =3D"mailto:noah.v.peart@HIDDEN">noah.v.peart@HIDDEN</a>> wrote:<br= ></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;= border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr">H= ere is an updated patch with the added "else_clause" and indentat= ion test for=C2=A0<div>statements without braces.</div></div><br><div class= =3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Mon, Nov 20, 2023= at 4:55=E2=80=AFAM Noah Peart <<a href=3D"mailto:noah.v.peart@HIDDEN= " target=3D"_blank">noah.v.peart@HIDDEN</a>> wrote:<br></div><blockqu= ote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px= solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr">Yea, I'm usi= ng the same.=C2=A0 But, would it be useful to have a way to set that when= =C2=A0<div>running tests without needing to temporarily add set `treesit-ex= tra-load-path` in=C2=A0</div><div>the test file?</div></div><br><div class= =3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Sun, Nov 19, 2023= at 5:38=E2=80=AFAM Dmitry Gutov <<a href=3D"mailto:dmitry@HIDDEN" ta= rget=3D"_blank">dmitry@HIDDEN</a>> wrote:<br></div><blockquote class= =3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg= b(204,204,204);padding-left:1ex">On 19/11/2023 08:08, Eli Zaretskii wrote:<= br> >> Date: Sun, 19 Nov 2023 03:24:49 +0200<br> >> <a href=3D"mailto:Cc%3Acasouri@HIDDEN" target=3D"_blank">Cc:cas= ouri@HIDDEN</a>,<a href=3D"mailto:67031 <at> debbugs.gnu.org" target=3D"_blan= k">67031 <at> debbugs.gnu.org</a><br> >> From: Dmitry Gutov<<a href=3D"mailto:dmitry@HIDDEN" target= =3D"_blank">dmitry@HIDDEN</a>><br> >><br> >> On 19/11/2023 02:12, Noah Peart wrote:<br> >>> Yea, I can=C2=A0do that.<br> >>><br> >>> Is there a recipe for running the tests with a tree-sitter lib= rary path?<br> >> You mean with the default tree-sitter librayr path overridden? I&#= 39;m not sure.<br> > Why would an ERT test need that?=C2=A0 We are supposed to test Emacs w= ith<br> > the otherwise installed system features.=C2=A0 As tree-sitter grammars= are<br> > not part of Emacs, there should be no need to tell Emacs to use a<br> > grammar library other than the one installed on the system.=C2=A0 Righ= t?<br> <br> We have a way to override that with the variable <br> treesit-extra-load-path, so it follows that some users will take <br> advantage of it to add extra directories.<br> <br> I'm using ~/.emacs.d/tree-sitter/ myself.<br> </blockquote></div> </blockquote></div> </blockquote></div> --000000000000b5d1cf060a99715b-- --000000000000b5d1d1060a99715d Content-Type: text/x-patch; charset="US-ASCII"; name="typescript-ts-mode-indentation.patch" Content-Disposition: attachment; filename="typescript-ts-mode-indentation.patch" Content-Transfer-Encoding: base64 Content-ID: <f_lp785zp60> X-Attachment-Id: f_lp785zp60 RnJvbSAyNjI4ZTkyZjZjNTVmYjY5ZDlmNTA0Y2FlZTFlMWIxMDVlMzBlMDFhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBudmVybm8gPG5vYWgudi5wZWFydEBnbWFpbC5jb20+CkRhdGU6 IE1vbiwgMjAgTm92IDIwMjMgMTA6MDQ6NTEgLTA4MDAKU3ViamVjdDogW1BBVENIXSBGaXggdHlw ZXNjcmlwdC10cy1tb2RlIGluZGVudGF0aW9uIGluIHN0YXRlbWVudHMgd2l0aG91dAogYnJhY2Vz CgotLS0KIGxpc3AvcHJvZ21vZGVzL3R5cGVzY3JpcHQtdHMtbW9kZS5lbCAgICAgICAgICB8ICA1 ICsrKysrCiAuLi4vdHlwZXNjcmlwdC10cy1tb2RlLXJlc291cmNlcy9pbmRlbnQuZXJ0cyAgfCAy MiArKysrKysrKysrKysrKysrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDI3IGluc2VydGlvbnMoKykK CmRpZmYgLS1naXQgYS9saXNwL3Byb2dtb2Rlcy90eXBlc2NyaXB0LXRzLW1vZGUuZWwgYi9saXNw L3Byb2dtb2Rlcy90eXBlc2NyaXB0LXRzLW1vZGUuZWwKaW5kZXggYjk3NjE0NWRiZjMuLmI2ZDU0 OTVhZGJiIDEwMDY0NAotLS0gYS9saXNwL3Byb2dtb2Rlcy90eXBlc2NyaXB0LXRzLW1vZGUuZWwK KysrIGIvbGlzcC9wcm9nbW9kZXMvdHlwZXNjcmlwdC10cy1tb2RlLmVsCkBAIC0xMjQsNiArMTI0 LDExIEBAIHR5cGVzY3JpcHQtdHMtbW9kZS0taW5kZW50LXJ1bGVzCiAgICAgICgocGFyZW50LWlz ICJhcnJvd19mdW5jdGlvbiIpIHBhcmVudC1ib2wgdHlwZXNjcmlwdC10cy1tb2RlLWluZGVudC1v ZmZzZXQpCiAgICAgICgocGFyZW50LWlzICJwYXJlbnRoZXNpemVkX2V4cHJlc3Npb24iKSBwYXJl bnQtYm9sIHR5cGVzY3JpcHQtdHMtbW9kZS1pbmRlbnQtb2Zmc2V0KQogICAgICAoKHBhcmVudC1p cyAiYmluYXJ5X2V4cHJlc3Npb24iKSBwYXJlbnQtYm9sIHR5cGVzY3JpcHQtdHMtbW9kZS1pbmRl bnQtb2Zmc2V0KQorICAgICAoKG1hdGNoICJ3aGlsZSIgImRvX3N0YXRlbWVudCIpIHBhcmVudC1i b2wgMCkKKyAgICAgKChtYXRjaCAiZWxzZSIgImlmX3N0YXRlbWVudCIpIHBhcmVudC1ib2wgMCkK KyAgICAgKChwYXJlbnQtaXMgLChyeCAob3IgKHNlcSAob3IgImlmIiAiZm9yIiAiZm9yX2luIiAi d2hpbGUiICJkbyIpICJfc3RhdGVtZW50IikKKyAgICAgICAgICAgICAgICAgICAgICAgICAgImVs c2VfY2xhdXNlIikpKQorICAgICAgcGFyZW50LWJvbCB0eXBlc2NyaXB0LXRzLW1vZGUtaW5kZW50 LW9mZnNldCkKIAogICAgICAsQCh3aGVuIChlcSBsYW5ndWFnZSAndHN4KQogCSAoYXBwZW5kICh0 c3gtdHMtbW9kZS0taW5kZW50LWNvbXBhdGliaWxpdHktYjg5MzQyNikKZGlmZiAtLWdpdCBhL3Rl c3QvbGlzcC9wcm9nbW9kZXMvdHlwZXNjcmlwdC10cy1tb2RlLXJlc291cmNlcy9pbmRlbnQuZXJ0 cyBiL3Rlc3QvbGlzcC9wcm9nbW9kZXMvdHlwZXNjcmlwdC10cy1tb2RlLXJlc291cmNlcy9pbmRl bnQuZXJ0cwppbmRleCAxNDZlZTc2NTc0ZS4uMjBmNDIzMjU5YjQgMTAwNjQ0Ci0tLSBhL3Rlc3Qv bGlzcC9wcm9nbW9kZXMvdHlwZXNjcmlwdC10cy1tb2RlLXJlc291cmNlcy9pbmRlbnQuZXJ0cwor KysgYi90ZXN0L2xpc3AvcHJvZ21vZGVzL3R5cGVzY3JpcHQtdHMtbW9kZS1yZXNvdXJjZXMvaW5k ZW50LmVydHMKQEAgLTIzLDYgKzIzLDI4IEBAIGNvbnN0IGZvbyA9ICgpID0+IHsKIH0KID0tPS09 CiAKK05hbWU6IFN0YXRlbWVudCBpbmRlbnRhdGlvbiB3aXRob3V0IGJyYWNlcworCis9LT0KK2Nv bnN0IGZvbyA9ICgpID0+IHsKKyAgaWYgKHRydWUpCisgICAgY29uc29sZS5sb2coImlmX3N0YXRl bWVudCIpOworICBlbHNlIGlmIChmYWxzZSkKKyAgICBjb25zb2xlLmxvZygiaWZfc3RhdGVtZW50 Iik7CisgIGVsc2UKKyAgICBjb25zb2xlLmxvZygiZWxzZV9jbGF1c2UiKTsKKyAgZm9yIChsZXQg aSA9IDA7IGkgPCAxOyBpKyspCisgICAgY29uc29sZS5sb2coImZvcl9zdGF0ZW1lbnQiKTsKKyAg Zm9yIChsZXQgaSBvZiBbdHJ1ZV0pCisgICAgY29uc29sZS5sb2coImZvcl9pbl9zdGF0ZW1lbnQi KTsKKyAgd2hpbGUgKGZhbHNlKQorICAgIGNvbnNvbGUubG9nKCJ3aGlsZV9zdGF0ZW1lbnQiKTsK KyAgZG8KKyAgICBjb25zb2xlLmxvZygiZG9fc3RhdGVtZW50Iik7CisgIHdoaWxlIChmYWxzZSkK K307Cis9LT0tPQorCiBDb2RlOgogICAobGFtYmRhICgpCiAgICAgKHNldHEgaW5kZW50LXRhYnMt bW9kZSBuaWwpCi0tIAoyLjM0LjEKCg== --000000000000b5d1d1060a99715d--
bug-gnu-emacs@HIDDEN:bug#67031; Package emacs.
Full text available.Received: (at 67031) by debbugs.gnu.org; 20 Nov 2023 18:08:05 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Nov 20 13:08:05 2023 Received: from localhost ([127.0.0.1]:54498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1r58gm-0001di-H3 for submit <at> debbugs.gnu.org; Mon, 20 Nov 2023 13:08:05 -0500 Received: from mail-oa1-x2f.google.com ([2001:4860:4864:20::2f]:49388) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <noah.v.peart@HIDDEN>) id 1r58gk-0001dC-HP for 67031 <at> debbugs.gnu.org; Mon, 20 Nov 2023 13:08:03 -0500 Received: by mail-oa1-x2f.google.com with SMTP id 586e51a60fabf-1ef36a04931so2896761fac.2 for <67031 <at> debbugs.gnu.org>; Mon, 20 Nov 2023 10:08:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700503674; x=1701108474; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=cQVJhha6aRBmjrmbCO9Fvd6FMyEUO2HO4z54qp6V82w=; b=GQsS38kiJrAswAnCVEZEAGJ0bxNYM7g7khW4S3YI8fQnEDoxYaflrRkyyCeFEUtnvM YNNr+I1AJjneuevV8Niucc8z02xm4VdOVWRAqZMXWLLczxOZa+XVGDUGt4WLXHvP3AYl EmIG/uLIINIGUW0XwptNzULUmG/RyXpA3XSy4hk2fbo+vYzxy/WIEN0kzHrcGbs6FqNi X572+7CregOaPNQ0VAJ1u+KMIXXaZ+tYGSYj9jppZVQngOPTSfFJhRrbUjMXKi9sRoGA yU5ZrbxhKwJilrSRocetkGWOk/P4rfSXuYenm7vkl0xVCNLhe2k59hppcWN5+wRMDvj5 wsTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700503674; x=1701108474; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cQVJhha6aRBmjrmbCO9Fvd6FMyEUO2HO4z54qp6V82w=; b=T4aclZJoqJiZxwHkzBw26gddUBbwyMA827Yfe4MLE2/lfn1aK9w7/lH69tYUzo2mBZ ccIkbolpWK9u4wk4r1/7CVA4suApWfAIJFKl2bvN/fxYgPpkDFnC8w9bOWo9NQRs9pZG HUrvQyCsGr6j+PJuEBBdAvK/IWg86vCOUrB8kdkZRFm+maVlKnAH1nYwD7PhIzQsuz7/ ZIxkGXBXO6O4U6LpkwHN5f8GoKLLQmzuKTlH2Z4GPLUI7bgE0xeXgO4sFDVZ6yCz1zJ5 G7r0HaZ159+qg/9dPMGugSFvEH3Fbu2yd/geCHydk03UNuUERTA09aTAk3O/229i9XE9 QQ2A== X-Gm-Message-State: AOJu0YzKDILTpJHE3U0Fza6h73tEHWd6SUb0Qv/uKFPYCmJSk1jqln7w stI+RzbLnGFjwXdhQee9WEKGKA111duqhj/FyYg= X-Google-Smtp-Source: AGHT+IG28hMVsRulDK9rbEnJSHvt9oVJbinajRrnsovqZRgDgaYaXUKm3v6AfMeixizTuBrIJlHFFsMcwBS78JnFYUs= X-Received: by 2002:a05:6870:288a:b0:1f4:a122:6b02 with SMTP id gy10-20020a056870288a00b001f4a1226b02mr10126750oab.45.1700503674318; Mon, 20 Nov 2023 10:07:54 -0800 (PST) MIME-Version: 1.0 References: <CAPVBTSf7dQWTYwXZELABDaSXCR0EEvKKnBzksAfyo3wr5K2_Tg@HIDDEN> <83pm0bqgm7.fsf@HIDDEN> <98ce09c9-00a1-f5ad-79ad-ed4b8328ac31@HIDDEN> <83pm07ml54.fsf@HIDDEN> <CAPVBTSf5n0X+TGbZ=Y1i_ExP=MzcTx-zhOC2UY_2Fr4Q3D0FxA@HIDDEN> <475bca51-dd02-46c5-0114-9588b43b756b@HIDDEN> <83sf52l1gs.fsf@HIDDEN> <bf36134b-c6ce-d78a-4b12-a3465cbfcfac@HIDDEN> <CAPVBTScosYtK8ouvXXWT0VqVWfwH7qNJmTck5gwtVpvQmQdejg@HIDDEN> In-Reply-To: <CAPVBTScosYtK8ouvXXWT0VqVWfwH7qNJmTck5gwtVpvQmQdejg@HIDDEN> From: Noah Peart <noah.v.peart@HIDDEN> Date: Mon, 20 Nov 2023 10:07:43 -0800 Message-ID: <CAPVBTScnQFEvhiSc5Thp3ApRQzUgKyupHBMKEbgUoFAEitoFmA@HIDDEN> Subject: Re: bug#67031: [PATCH] Fix typescript-ts-mode indentation in unbracketed statements To: Dmitry Gutov <dmitry@HIDDEN> Content-Type: multipart/mixed; boundary="0000000000007289dd060a995da8" X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 67031 Cc: Eli Zaretskii <eliz@HIDDEN>, 67031 <at> debbugs.gnu.org, casouri@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --0000000000007289dd060a995da8 Content-Type: multipart/alternative; boundary="0000000000007289dc060a995da6" --0000000000007289dc060a995da6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Here is an updated patch with the added "else_clause" and indentation test for statements without braces. On Mon, Nov 20, 2023 at 4:55=E2=80=AFAM Noah Peart <noah.v.peart@HIDDEN>= wrote: > Yea, I'm using the same. But, would it be useful to have a way to set > that when > running tests without needing to temporarily add set > `treesit-extra-load-path` in > the test file? > > On Sun, Nov 19, 2023 at 5:38=E2=80=AFAM Dmitry Gutov <dmitry@HIDDEN> w= rote: > >> On 19/11/2023 08:08, Eli Zaretskii wrote: >> >> Date: Sun, 19 Nov 2023 03:24:49 +0200 >> >> Cc:casouri@HIDDEN,67031 <at> debbugs.gnu.org >> >> From: Dmitry Gutov<dmitry@HIDDEN> >> >> >> >> On 19/11/2023 02:12, Noah Peart wrote: >> >>> Yea, I can do that. >> >>> >> >>> Is there a recipe for running the tests with a tree-sitter library >> path? >> >> You mean with the default tree-sitter librayr path overridden? I'm no= t >> sure. >> > Why would an ERT test need that? We are supposed to test Emacs with >> > the otherwise installed system features. As tree-sitter grammars are >> > not part of Emacs, there should be no need to tell Emacs to use a >> > grammar library other than the one installed on the system. Right? >> >> We have a way to override that with the variable >> treesit-extra-load-path, so it follows that some users will take >> advantage of it to add extra directories. >> >> I'm using ~/.emacs.d/tree-sitter/ myself. >> > --0000000000007289dc060a995da6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">Here is an updated patch with the added "else_clause&= quot; and indentation test for=C2=A0<div>statements without braces.</div></= div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On= Mon, Nov 20, 2023 at 4:55=E2=80=AFAM Noah Peart <<a href=3D"mailto:noah= .v.peart@HIDDEN">noah.v.peart@HIDDEN</a>> wrote:<br></div><blockqu= ote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px= solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr">Yea, I'm usi= ng the same.=C2=A0 But, would it be useful to have a way to set that when= =C2=A0<div>running tests without needing to temporarily add set `treesit-ex= tra-load-path` in=C2=A0</div><div>the test file?</div></div><br><div class= =3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Sun, Nov 19, 2023= at 5:38=E2=80=AFAM Dmitry Gutov <<a href=3D"mailto:dmitry@HIDDEN" ta= rget=3D"_blank">dmitry@HIDDEN</a>> wrote:<br></div><blockquote class= =3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg= b(204,204,204);padding-left:1ex">On 19/11/2023 08:08, Eli Zaretskii wrote:<= br> >> Date: Sun, 19 Nov 2023 03:24:49 +0200<br> >> <a href=3D"mailto:Cc%3Acasouri@HIDDEN" target=3D"_blank">Cc:cas= ouri@HIDDEN</a>,<a href=3D"mailto:67031 <at> debbugs.gnu.org" target=3D"_blan= k">67031 <at> debbugs.gnu.org</a><br> >> From: Dmitry Gutov<<a href=3D"mailto:dmitry@HIDDEN" target= =3D"_blank">dmitry@HIDDEN</a>><br> >><br> >> On 19/11/2023 02:12, Noah Peart wrote:<br> >>> Yea, I can=C2=A0do that.<br> >>><br> >>> Is there a recipe for running the tests with a tree-sitter lib= rary path?<br> >> You mean with the default tree-sitter librayr path overridden? I&#= 39;m not sure.<br> > Why would an ERT test need that?=C2=A0 We are supposed to test Emacs w= ith<br> > the otherwise installed system features.=C2=A0 As tree-sitter grammars= are<br> > not part of Emacs, there should be no need to tell Emacs to use a<br> > grammar library other than the one installed on the system.=C2=A0 Righ= t?<br> <br> We have a way to override that with the variable <br> treesit-extra-load-path, so it follows that some users will take <br> advantage of it to add extra directories.<br> <br> I'm using ~/.emacs.d/tree-sitter/ myself.<br> </blockquote></div> </blockquote></div> --0000000000007289dc060a995da6-- --0000000000007289dd060a995da8 Content-Type: text/x-patch; charset="US-ASCII"; name="typescript-ts-mode-indentation.patch" Content-Disposition: attachment; filename="typescript-ts-mode-indentation.patch" Content-Transfer-Encoding: base64 Content-ID: <f_lp77ycau0> X-Attachment-Id: f_lp77ycau0 RnJvbSBlMzhmODIzMjM4ZjQ1NmEwODI1YjhhNGUzZjg2ZGE2ZWZhYWMwNTc5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBudmVybm8gPG5vYWgudi5wZWFydEBnbWFpbC5jb20+CkRhdGU6 IE1vbiwgMjAgTm92IDIwMjMgMTA6MDQ6NTEgLTA4MDAKU3ViamVjdDogW1BBVENIXSBGaXggdHlw ZXNjcmlwdC10cy1tb2RlIGluZGVudGF0aW9uIGluIHN0YXRlbWVudHMgd2l0aG91dAogYnJhY2Vz CgotLS0KIGxpc3AvcHJvZ21vZGVzL3R5cGVzY3JpcHQtdHMtbW9kZS5lbCAgICAgICAgICB8ICAz ICsrKwogLi4uL3R5cGVzY3JpcHQtdHMtbW9kZS1yZXNvdXJjZXMvaW5kZW50LmVydHMgIHwgMjIg KysrKysrKysrKysrKysrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAyNSBpbnNlcnRpb25zKCspCgpk aWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMvdHlwZXNjcmlwdC10cy1tb2RlLmVsIGIvbGlzcC9w cm9nbW9kZXMvdHlwZXNjcmlwdC10cy1tb2RlLmVsCmluZGV4IGI5NzYxNDVkYmYzLi44MjZjZDVm MzliMCAxMDA2NDQKLS0tIGEvbGlzcC9wcm9nbW9kZXMvdHlwZXNjcmlwdC10cy1tb2RlLmVsCisr KyBiL2xpc3AvcHJvZ21vZGVzL3R5cGVzY3JpcHQtdHMtbW9kZS5lbApAQCAtMTI0LDYgKzEyNCw5 IEBAIHR5cGVzY3JpcHQtdHMtbW9kZS0taW5kZW50LXJ1bGVzCiAgICAgICgocGFyZW50LWlzICJh cnJvd19mdW5jdGlvbiIpIHBhcmVudC1ib2wgdHlwZXNjcmlwdC10cy1tb2RlLWluZGVudC1vZmZz ZXQpCiAgICAgICgocGFyZW50LWlzICJwYXJlbnRoZXNpemVkX2V4cHJlc3Npb24iKSBwYXJlbnQt Ym9sIHR5cGVzY3JpcHQtdHMtbW9kZS1pbmRlbnQtb2Zmc2V0KQogICAgICAoKHBhcmVudC1pcyAi YmluYXJ5X2V4cHJlc3Npb24iKSBwYXJlbnQtYm9sIHR5cGVzY3JpcHQtdHMtbW9kZS1pbmRlbnQt b2Zmc2V0KQorICAgICAoKHBhcmVudC1pcyAsKHJ4IChvciAoc2VxIChvciAiaWYiICJmb3IiICJm b3JfaW4iICJ3aGlsZSIgImRvIikgIl9zdGF0ZW1lbnQiKQorICAgICAgICAgICAgICAgICAgICAg ICAgICAiZWxzZV9jbGF1c2UiKSkpCisgICAgICBwYXJlbnQtYm9sIHR5cGVzY3JpcHQtdHMtbW9k ZS1pbmRlbnQtb2Zmc2V0KQogCiAgICAgICxAKHdoZW4gKGVxIGxhbmd1YWdlICd0c3gpCiAJIChh cHBlbmQgKHRzeC10cy1tb2RlLS1pbmRlbnQtY29tcGF0aWJpbGl0eS1iODkzNDI2KQpkaWZmIC0t Z2l0IGEvdGVzdC9saXNwL3Byb2dtb2Rlcy90eXBlc2NyaXB0LXRzLW1vZGUtcmVzb3VyY2VzL2lu ZGVudC5lcnRzIGIvdGVzdC9saXNwL3Byb2dtb2Rlcy90eXBlc2NyaXB0LXRzLW1vZGUtcmVzb3Vy Y2VzL2luZGVudC5lcnRzCmluZGV4IDE0NmVlNzY1NzRlLi4yMGY0MjMyNTliNCAxMDA2NDQKLS0t IGEvdGVzdC9saXNwL3Byb2dtb2Rlcy90eXBlc2NyaXB0LXRzLW1vZGUtcmVzb3VyY2VzL2luZGVu dC5lcnRzCisrKyBiL3Rlc3QvbGlzcC9wcm9nbW9kZXMvdHlwZXNjcmlwdC10cy1tb2RlLXJlc291 cmNlcy9pbmRlbnQuZXJ0cwpAQCAtMjMsNiArMjMsMjggQEAgY29uc3QgZm9vID0gKCkgPT4gewog fQogPS09LT0KIAorTmFtZTogU3RhdGVtZW50IGluZGVudGF0aW9uIHdpdGhvdXQgYnJhY2VzCisK Kz0tPQorY29uc3QgZm9vID0gKCkgPT4geworICBpZiAodHJ1ZSkKKyAgICBjb25zb2xlLmxvZygi aWZfc3RhdGVtZW50Iik7CisgIGVsc2UgaWYgKGZhbHNlKQorICAgIGNvbnNvbGUubG9nKCJpZl9z dGF0ZW1lbnQiKTsKKyAgZWxzZQorICAgIGNvbnNvbGUubG9nKCJlbHNlX2NsYXVzZSIpOworICBm b3IgKGxldCBpID0gMDsgaSA8IDE7IGkrKykKKyAgICBjb25zb2xlLmxvZygiZm9yX3N0YXRlbWVu dCIpOworICBmb3IgKGxldCBpIG9mIFt0cnVlXSkKKyAgICBjb25zb2xlLmxvZygiZm9yX2luX3N0 YXRlbWVudCIpOworICB3aGlsZSAoZmFsc2UpCisgICAgY29uc29sZS5sb2coIndoaWxlX3N0YXRl bWVudCIpOworICBkbworICAgIGNvbnNvbGUubG9nKCJkb19zdGF0ZW1lbnQiKTsKKyAgd2hpbGUg KGZhbHNlKQorfTsKKz0tPS09CisKIENvZGU6CiAgIChsYW1iZGEgKCkKICAgICAoc2V0cSBpbmRl bnQtdGFicy1tb2RlIG5pbCkKLS0gCjIuMzQuMQoK --0000000000007289dd060a995da8--
bug-gnu-emacs@HIDDEN:bug#67031; Package emacs.
Full text available.Received: (at 67031) by debbugs.gnu.org; 20 Nov 2023 12:55:51 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Nov 20 07:55:51 2023 Received: from localhost ([127.0.0.1]:52760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1r53od-0000Wu-AT for submit <at> debbugs.gnu.org; Mon, 20 Nov 2023 07:55:51 -0500 Received: from mail-ot1-x32b.google.com ([2607:f8b0:4864:20::32b]:50548) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <noah.v.peart@HIDDEN>) id 1r53oX-0000Wd-Ak for 67031 <at> debbugs.gnu.org; Mon, 20 Nov 2023 07:55:49 -0500 Received: by mail-ot1-x32b.google.com with SMTP id 46e09a7af769-6d2fedd836fso2703679a34.1 for <67031 <at> debbugs.gnu.org>; Mon, 20 Nov 2023 04:55:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700484937; x=1701089737; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=AsxBjWyV0gEDBIEEDGxhWnHqItEBDau/t7cM+JbRwO8=; b=JBu9vE0Sf72X8w+iVOByTT8J83g1M2Q1AHNjBJzHui/qaRfyUKjVIaP6hPHKxkKAWY mH/q3VlY7NLYRUS0dTRGoUgSojNGozaH5dCthVaK4hCBhlvwaFnDFeIzt+pF8KRS9sFs eTmkv3BCgowy4wPVS/2NGa5j/0rcJfgE3fi1ehjXKPEWzWFWRMdd1s+joQ8U9W1px7f/ cCuCOw6RIr+ro5YvUS4VOxoIY9PSBrJjtIw1p8g7SndSWyU8ippz4DxB4l+D+AMloVkj vkzsdqxhG212cudum9B8tcBz77Mi3vgvrMo+4TvvClwm3tsLGU2gCPAkHZaOUaeTwvHM Vwnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700484937; x=1701089737; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AsxBjWyV0gEDBIEEDGxhWnHqItEBDau/t7cM+JbRwO8=; b=J4vxnFUXVNMIWvkBsilX9Xgh8+yJ4qUObDANic5B+nCiz5x+nvW6SFwCIK/JvpA91O V2AnyJsU4Z4xlaDjcc2WbUIAgor94QsXEOOZ8GEJJFEUKA1SBc44cAnPU2//xsgHkOfs lMofVt1N34arjUWwA1WXD19PbGI/tXH06T/r9fC2pgsuD/jcBtodDM66vewzvyhsZAky CjcJQ944O+tL5uVV5ufAFWTDe+0K6wSKarKfBGtUR5cBQObpf2Mo+ye2hfvEp45/HqVl Mz8BvOejy/J4EeRcYQ+30xMY12F+8XG59RXuPDSv05YjcZcTrVE+FxeiGZtdYFShNf0j kkGw== X-Gm-Message-State: AOJu0YzbM242nopPV5IA6osTN33rOgmGOIlUomGgk4siIpYzvy9rUBvx olAroh7KPY7QbtuzJxKNN05U29nuWDyKzYgF6fs= X-Google-Smtp-Source: AGHT+IH36OrUcRYC7lnseMhyjWtAuT3cjvTPVkqsT9sjFip+SYR0lHYcsyAhdNfYtxN1rZXZA6HZ4cdsLvOje1erlBA= X-Received: by 2002:a05:6870:c1d2:b0:1ef:62fc:d51c with SMTP id i18-20020a056870c1d200b001ef62fcd51cmr9092963oad.51.1700484937424; Mon, 20 Nov 2023 04:55:37 -0800 (PST) MIME-Version: 1.0 References: <CAPVBTSf7dQWTYwXZELABDaSXCR0EEvKKnBzksAfyo3wr5K2_Tg@HIDDEN> <83pm0bqgm7.fsf@HIDDEN> <98ce09c9-00a1-f5ad-79ad-ed4b8328ac31@HIDDEN> <83pm07ml54.fsf@HIDDEN> <CAPVBTSf5n0X+TGbZ=Y1i_ExP=MzcTx-zhOC2UY_2Fr4Q3D0FxA@HIDDEN> <475bca51-dd02-46c5-0114-9588b43b756b@HIDDEN> <83sf52l1gs.fsf@HIDDEN> <bf36134b-c6ce-d78a-4b12-a3465cbfcfac@HIDDEN> In-Reply-To: <bf36134b-c6ce-d78a-4b12-a3465cbfcfac@HIDDEN> From: Noah Peart <noah.v.peart@HIDDEN> Date: Mon, 20 Nov 2023 04:55:26 -0800 Message-ID: <CAPVBTScosYtK8ouvXXWT0VqVWfwH7qNJmTck5gwtVpvQmQdejg@HIDDEN> Subject: Re: bug#67031: [PATCH] Fix typescript-ts-mode indentation in unbracketed statements To: Dmitry Gutov <dmitry@HIDDEN> Content-Type: multipart/alternative; boundary="000000000000a423ff060a95005f" X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 67031 Cc: Eli Zaretskii <eliz@HIDDEN>, 67031 <at> debbugs.gnu.org, casouri@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --000000000000a423ff060a95005f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Yea, I'm using the same. But, would it be useful to have a way to set that when running tests without needing to temporarily add set `treesit-extra-load-path` in the test file? On Sun, Nov 19, 2023 at 5:38=E2=80=AFAM Dmitry Gutov <dmitry@HIDDEN> wro= te: > On 19/11/2023 08:08, Eli Zaretskii wrote: > >> Date: Sun, 19 Nov 2023 03:24:49 +0200 > >> Cc:casouri@HIDDEN,67031 <at> debbugs.gnu.org > >> From: Dmitry Gutov<dmitry@HIDDEN> > >> > >> On 19/11/2023 02:12, Noah Peart wrote: > >>> Yea, I can do that. > >>> > >>> Is there a recipe for running the tests with a tree-sitter library > path? > >> You mean with the default tree-sitter librayr path overridden? I'm not > sure. > > Why would an ERT test need that? We are supposed to test Emacs with > > the otherwise installed system features. As tree-sitter grammars are > > not part of Emacs, there should be no need to tell Emacs to use a > > grammar library other than the one installed on the system. Right? > > We have a way to override that with the variable > treesit-extra-load-path, so it follows that some users will take > advantage of it to add extra directories. > > I'm using ~/.emacs.d/tree-sitter/ myself. > --000000000000a423ff060a95005f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">Yea, I'm using the same.=C2=A0 But, would it be useful= to have a way to set that when=C2=A0<div>running tests without needing to = temporarily add set `treesit-extra-load-path` in=C2=A0</div><div>the test f= ile?</div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gm= ail_attr">On Sun, Nov 19, 2023 at 5:38=E2=80=AFAM Dmitry Gutov <<a href= =3D"mailto:dmitry@HIDDEN">dmitry@HIDDEN</a>> wrote:<br></div><bloc= kquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:= 1px solid rgb(204,204,204);padding-left:1ex">On 19/11/2023 08:08, Eli Zaret= skii wrote:<br> >> Date: Sun, 19 Nov 2023 03:24:49 +0200<br> >> <a href=3D"mailto:Cc%3Acasouri@HIDDEN" target=3D"_blank">Cc:cas= ouri@HIDDEN</a>,<a href=3D"mailto:67031 <at> debbugs.gnu.org" target=3D"_blan= k">67031 <at> debbugs.gnu.org</a><br> >> From: Dmitry Gutov<<a href=3D"mailto:dmitry@HIDDEN" target= =3D"_blank">dmitry@HIDDEN</a>><br> >><br> >> On 19/11/2023 02:12, Noah Peart wrote:<br> >>> Yea, I can=C2=A0do that.<br> >>><br> >>> Is there a recipe for running the tests with a tree-sitter lib= rary path?<br> >> You mean with the default tree-sitter librayr path overridden? I&#= 39;m not sure.<br> > Why would an ERT test need that?=C2=A0 We are supposed to test Emacs w= ith<br> > the otherwise installed system features.=C2=A0 As tree-sitter grammars= are<br> > not part of Emacs, there should be no need to tell Emacs to use a<br> > grammar library other than the one installed on the system.=C2=A0 Righ= t?<br> <br> We have a way to override that with the variable <br> treesit-extra-load-path, so it follows that some users will take <br> advantage of it to add extra directories.<br> <br> I'm using ~/.emacs.d/tree-sitter/ myself.<br> </blockquote></div> --000000000000a423ff060a95005f--
bug-gnu-emacs@HIDDEN:bug#67031; Package emacs.
Full text available.Received: (at 67031) by debbugs.gnu.org; 19 Nov 2023 13:39:01 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 19 08:39:01 2023 Received: from localhost ([127.0.0.1]:50217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1r4i0r-0006cE-CM for submit <at> debbugs.gnu.org; Sun, 19 Nov 2023 08:39:01 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:36701) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <dmitry@HIDDEN>) id 1r4i0m-0006bw-Rt for 67031 <at> debbugs.gnu.org; Sun, 19 Nov 2023 08:39:00 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 411DD5C01B9; Sun, 19 Nov 2023 08:38:50 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sun, 19 Nov 2023 08:38:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1700401130; x=1700487530; bh=UVui04T90/Ksxu83o3KWDCYqLIb2NNIjMvp q0THa12E=; b=HoZMGA9CEk++NUeZioElylhCnkvZB9rGg2eLQD9A+Cq21+WBMYK emO3hDJ8Gg43+Zp0xtFocXJq0oj27zpFXGy7SaD4ZyV/5GBH4ioy6rnEuZg5sKuv Bjd0vWgPJjtTEPURzxLEgr4jPifM5KkyF6WyMa2l+C4BcWsLazVUyuXMIMwmm8Cs PDetdBQJrrILdaNAnf8sZOtk/B4h0PM4VBjP/+e6ABgFfCO/VGtMboJSEy6B3NLq f2UuLyAE3YZbRUnmumckXzC9qiZRi3IO4VBsUv3bHKkb4Ggxw8Dk4oYe/cW0sscE MJr733bcjZXPFiauv2YlgyzerNklNq5yzZg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1700401130; x=1700487530; bh=UVui04T90/Ksxu83o3KWDCYqLIb2NNIjMvp q0THa12E=; b=qeYc/PxuZkeq80a8Hftq9F7G4SCnn2gwECPFBTni6YoeAP4V7s4 m7ZivaRMRbpPPlA9Kllh3SYbB+4QRNFTbI/FjDARjrduoJq+mg6dDcmwj2Yk0vfx JCSALy61NsB31FON6R1Bc3BRroY4jIbDvJ1aHnqFOWj/bYC9+wTQzmYiKDqKQJUE Bi4FGjRNYN7nW65oyZnWr4JBvXyvFMdT+136qfTpVefNlXzaSMI4s1FSQBxdTRES W7lynDL4ECAbFeOgmqMXhLL4OV/BM2ylnpfmOsbPI3ygLhV3NQDKrLyxjsQHhck2 LPpPbNoe9GQUZHxB0fIpdERnEwF5iB3mYbQ== X-ME-Sender: <xms:6Q9aZQyO2ZeFRivH-RwTzwVgUWzUj8Jj_U7IkZi-ozbROAX8eASx3Q> <xme:6Q9aZURfRsDXxqVj8IyMPSaZ-xc5ced9TSAcDPlAmzvUfJRLd79NXr-BwavA28S-E zaV8Ij_1T-O4Oycjjw> X-ME-Received: <xmr:6Q9aZSUAntmxFjg91WPy4KS0N51On7JRtZ0ZAtsYwGq6HsPF0Ev1heAsccWDdSgvnrEr4Q> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeggedgheeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhephfffheeljeffgeffueeghfekkedtfffgheejvdegjeettdduheeufffggfef jeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: <xmx:6Q9aZei5ZhlDtYFfibJ_zQ00lPE_KkupumGRH9rLwkDXB4tPeonlpw> <xmx:6Q9aZSBc5-kaoflzR07Wr8WQc1x-J_oI1B0EdKfKwqw3o4KXXZsv3g> <xmx:6Q9aZfKVraLoVdIehN1FHHrc-l8XwhlbMoQTCipapYxC59VavB-iyw> <xmx:6g9aZVPNdcYhHNEkUUF9XHi_3r0fZDkneIJUZtF8ReoQ31opwJnr8A> Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 19 Nov 2023 08:38:47 -0500 (EST) Message-ID: <bf36134b-c6ce-d78a-4b12-a3465cbfcfac@HIDDEN> Date: Sun, 19 Nov 2023 15:38:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#67031: [PATCH] Fix typescript-ts-mode indentation in unbracketed statements Content-Language: en-US To: Eli Zaretskii <eliz@HIDDEN> References: <CAPVBTSf7dQWTYwXZELABDaSXCR0EEvKKnBzksAfyo3wr5K2_Tg@HIDDEN> <83pm0bqgm7.fsf@HIDDEN> <98ce09c9-00a1-f5ad-79ad-ed4b8328ac31@HIDDEN> <83pm07ml54.fsf@HIDDEN> <CAPVBTSf5n0X+TGbZ=Y1i_ExP=MzcTx-zhOC2UY_2Fr4Q3D0FxA@HIDDEN> <475bca51-dd02-46c5-0114-9588b43b756b@HIDDEN> <83sf52l1gs.fsf@HIDDEN> From: Dmitry Gutov <dmitry@HIDDEN> In-Reply-To: <83sf52l1gs.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 67031 Cc: noah.v.peart@HIDDEN, casouri@HIDDEN, 67031 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.9 (---) On 19/11/2023 08:08, Eli Zaretskii wrote: >> Date: Sun, 19 Nov 2023 03:24:49 +0200 >> Cc:casouri@HIDDEN,67031 <at> debbugs.gnu.org >> From: Dmitry Gutov<dmitry@HIDDEN> >> >> On 19/11/2023 02:12, Noah Peart wrote: >>> Yea, I can do that. >>> >>> Is there a recipe for running the tests with a tree-sitter library path? >> You mean with the default tree-sitter librayr path overridden? I'm not sure. > Why would an ERT test need that? We are supposed to test Emacs with > the otherwise installed system features. As tree-sitter grammars are > not part of Emacs, there should be no need to tell Emacs to use a > grammar library other than the one installed on the system. Right? We have a way to override that with the variable treesit-extra-load-path, so it follows that some users will take advantage of it to add extra directories. I'm using ~/.emacs.d/tree-sitter/ myself.
bug-gnu-emacs@HIDDEN:bug#67031; Package emacs.
Full text available.Received: (at 67031) by debbugs.gnu.org; 19 Nov 2023 07:19:47 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 19 02:19:47 2023 Received: from localhost ([127.0.0.1]:49853 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1r4c5r-0001eg-FE for submit <at> debbugs.gnu.org; Sun, 19 Nov 2023 02:19:47 -0500 Received: from mail-oo1-xc2f.google.com ([2607:f8b0:4864:20::c2f]:46228) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <noah.v.peart@HIDDEN>) id 1r4c5m-0001eQ-NO for 67031 <at> debbugs.gnu.org; Sun, 19 Nov 2023 02:19:45 -0500 Received: by mail-oo1-xc2f.google.com with SMTP id 006d021491bc7-5869914484fso1977332eaf.0 for <67031 <at> debbugs.gnu.org>; Sat, 18 Nov 2023 23:19:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700378375; x=1700983175; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=TezrqehPVguF39lNu+Gzqt7um+iLUFKcahfIGsN+7uc=; b=jbw6y5ezqDdIa3pXpW6OgFpqegKDJuenwBGuJ1XI1Cv+x8bC87ONRDUQ/WGickCEGs wBHJ0z0X0VfiuRhJerrS769hI2WYXTYzvl921x6FtaKA6xSfC2wzOH/n7USgQEVWdwfd kbQOHigOGy0SYJJxWJ2+Q19P7FiJX03qFPeDV4jB+6lLOk2P0nB7lWgnacCMrXwMRBnU DuTZVdM2ANgMU575fhZe3hiRi9FrBN78PydHDc3VcCQejzD7PHUZbUtGE2hAZe+n/cC2 pqHYgldQhZGKmZVqHeU+T6zSDelslbmcSiy9WuHklrOrjUkCdca43LFsbP46jrRNswQt aU9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700378375; x=1700983175; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TezrqehPVguF39lNu+Gzqt7um+iLUFKcahfIGsN+7uc=; b=q4OcI89dQ7Z2ptU08bsvQjKD6tfv2PYk7aAMvu2ZeTgOSULmza1uxuyVjrCSLMFy1B YIUj4HMQ+aibjCptslgHpwWBV/Dqgh6xb1R6uK6yaK7qCS59+NZDYDV6JLiaeal9siBN K7HtdJueLqiMPu0yMFV9/gVXwzPcj/kwP+P5OzCD6nSnPdYdP96EdmWijqVykaV4W1de bKiau/wwDUIIVd0xEpfp7IBzRJuY2QTqK3k167sy6dj69RYrfb5BSOuwrxylitpWDZvz /9/CAY5PzhAFgw5y+g3XqQk2GVvM8ngzG1gqjKAvIuwAJqHiNpjyB5OtmLn5qOP5tjz6 YdUw== X-Gm-Message-State: AOJu0Yz2hMhX9xUcDDjHNaXnbJaXcazh8dkhE2xED1BFQ2HSRTcaqgR3 KRsPK8CECBpWwXdZhZFqU5WKSKuv6iU8g/tRUjw= X-Google-Smtp-Source: AGHT+IEWSkfUYOsDa0a1WnDc40DeQc4RSDqUJVQOvL4cyRWEMYfvAOHq7r4TsNPRv8dPg7MZ0wbu6a4Te7vi7wesibk= X-Received: by 2002:a05:6870:7e13:b0:1ea:4338:209d with SMTP id wx19-20020a0568707e1300b001ea4338209dmr6045505oab.31.1700378375532; Sat, 18 Nov 2023 23:19:35 -0800 (PST) MIME-Version: 1.0 References: <CAPVBTSf7dQWTYwXZELABDaSXCR0EEvKKnBzksAfyo3wr5K2_Tg@HIDDEN> <83pm0bqgm7.fsf@HIDDEN> <98ce09c9-00a1-f5ad-79ad-ed4b8328ac31@HIDDEN> <83pm07ml54.fsf@HIDDEN> <CAPVBTSf5n0X+TGbZ=Y1i_ExP=MzcTx-zhOC2UY_2Fr4Q3D0FxA@HIDDEN> <475bca51-dd02-46c5-0114-9588b43b756b@HIDDEN> <83sf52l1gs.fsf@HIDDEN> In-Reply-To: <83sf52l1gs.fsf@HIDDEN> From: Noah Peart <noah.v.peart@HIDDEN> Date: Sat, 18 Nov 2023 23:19:24 -0800 Message-ID: <CAPVBTSe9OeBqc-74Dq418-hVLK=hWKTphWQxLU7n1YhSCO1U+g@HIDDEN> Subject: Re: bug#67031: [PATCH] Fix typescript-ts-mode indentation in unbracketed statements To: Eli Zaretskii <eliz@HIDDEN> Content-Type: multipart/alternative; boundary="0000000000000eb66f060a7c31b7" X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 67031 Cc: Dmitry Gutov <dmitry@HIDDEN>, casouri@HIDDEN, 67031 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --0000000000000eb66f060a7c31b7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I don't think the test runs when it doesn't find a typescript parser. Ill double check tomorrow, but temporarily adding a treesit-extra load path should be ok. Thanks On Sat, Nov 18, 2023 at 10:08=E2=80=AFPM Eli Zaretskii <eliz@HIDDEN> wrote= : > > Date: Sun, 19 Nov 2023 03:24:49 +0200 > > Cc: casouri@HIDDEN, 67031 <at> debbugs.gnu.org > > From: Dmitry Gutov <dmitry@HIDDEN> > > > > On 19/11/2023 02:12, Noah Peart wrote: > > > Yea, I can do that. > > > > > > Is there a recipe for running the tests with a tree-sitter library > path? > > > > You mean with the default tree-sitter librayr path overridden? I'm not > sure. > > Why would an ERT test need that? We are supposed to test Emacs with > the otherwise installed system features. As tree-sitter grammars are > not part of Emacs, there should be no need to tell Emacs to use a > grammar library other than the one installed on the system. Right? > --0000000000000eb66f060a7c31b7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">I don't think the test runs when it doesn't find a= typescript parser.=C2=A0 Ill double check<div>tomorrow, but temporarily ad= ding a treesit-extra load path should be ok.</div><div><br></div><div>Thank= s</div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail= _attr">On Sat, Nov 18, 2023 at 10:08=E2=80=AFPM Eli Zaretskii <<a href= =3D"mailto:eliz@HIDDEN">eliz@HIDDEN</a>> wrote:<br></div><blockquote c= lass=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px soli= d rgb(204,204,204);padding-left:1ex">> Date: Sun, 19 Nov 2023 03:24:49 += 0200<br> > Cc: <a href=3D"mailto:casouri@HIDDEN" target=3D"_blank">casouri@gma= il.com</a>, <a href=3D"mailto:67031 <at> debbugs.gnu.org" target=3D"_blank">6703= 1 <at> debbugs.gnu.org</a><br> > From: Dmitry Gutov <<a href=3D"mailto:dmitry@HIDDEN" target=3D"_= blank">dmitry@HIDDEN</a>><br> > <br> > On 19/11/2023 02:12, Noah Peart wrote:<br> > > Yea, I can=C2=A0do that.<br> > > <br> > > Is there a recipe for running the tests with a tree-sitter librar= y path?<br> > <br> > You mean with the default tree-sitter librayr path overridden? I'm= not sure.<br> <br> Why would an ERT test need that?=C2=A0 We are supposed to test Emacs with<b= r> the otherwise installed system features.=C2=A0 As tree-sitter grammars are<= br> not part of Emacs, there should be no need to tell Emacs to use a<br> grammar library other than the one installed on the system.=C2=A0 Right?<br= > </blockquote></div> --0000000000000eb66f060a7c31b7--
bug-gnu-emacs@HIDDEN:bug#67031; Package emacs.
Full text available.Received: (at 67031) by debbugs.gnu.org; 19 Nov 2023 06:08:54 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 19 01:08:54 2023 Received: from localhost ([127.0.0.1]:49788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1r4azF-0002E4-V8 for submit <at> debbugs.gnu.org; Sun, 19 Nov 2023 01:08:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40578) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1r4azA-0002Dm-Nc for 67031 <at> debbugs.gnu.org; Sun, 19 Nov 2023 01:08:52 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1r4az3-0001Pf-T1; Sun, 19 Nov 2023 01:08:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=vmisl8+vzaKQQaEBLh2xDBzljGdvwq44IocXcNoJuPk=; b=Hou/Km/ahkCLWiMhNhnX CkO5v90dAI72Nic4aaNt44g0+7D1jHh2zEe6TmccHmDknAemJ6KeuHCnW6m6UFkvvLZ7vXVKptYoP 7MkSmiz0B/fDx5HbKcRCP0oizjcl1M867H+8xlapzs7GOlhc0Q73HffXh3ZWtQX3zBxE37FfKliFc y8SR48KUW86+mZ5JGN13ksAi5p1HksZ5fLNfOorxslVi+b7cCVVYvrs74OIsC5gDWphTD0+Gbk/jV eKo1Exz74reMRgLTYYQc1Jx/Z2SaZYiDg9P202eN++zBRFXq/etyXU6IduzuZcgAelV7MCT7XeA9/ gStcCF5WKuWtDQ==; Date: Sun, 19 Nov 2023 08:08:19 +0200 Message-Id: <83sf52l1gs.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Dmitry Gutov <dmitry@HIDDEN> In-Reply-To: <475bca51-dd02-46c5-0114-9588b43b756b@HIDDEN> (message from Dmitry Gutov on Sun, 19 Nov 2023 03:24:49 +0200) Subject: Re: bug#67031: [PATCH] Fix typescript-ts-mode indentation in unbracketed statements References: <CAPVBTSf7dQWTYwXZELABDaSXCR0EEvKKnBzksAfyo3wr5K2_Tg@HIDDEN> <83pm0bqgm7.fsf@HIDDEN> <98ce09c9-00a1-f5ad-79ad-ed4b8328ac31@HIDDEN> <83pm07ml54.fsf@HIDDEN> <CAPVBTSf5n0X+TGbZ=Y1i_ExP=MzcTx-zhOC2UY_2Fr4Q3D0FxA@HIDDEN> <475bca51-dd02-46c5-0114-9588b43b756b@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67031 Cc: noah.v.peart@HIDDEN, casouri@HIDDEN, 67031 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Sun, 19 Nov 2023 03:24:49 +0200 > Cc: casouri@HIDDEN, 67031 <at> debbugs.gnu.org > From: Dmitry Gutov <dmitry@HIDDEN> > > On 19/11/2023 02:12, Noah Peart wrote: > > Yea, I can do that. > > > > Is there a recipe for running the tests with a tree-sitter library path? > > You mean with the default tree-sitter librayr path overridden? I'm not sure. Why would an ERT test need that? We are supposed to test Emacs with the otherwise installed system features. As tree-sitter grammars are not part of Emacs, there should be no need to tell Emacs to use a grammar library other than the one installed on the system. Right?
bug-gnu-emacs@HIDDEN:bug#67031; Package emacs.
Full text available.
Received: (at 67031) by debbugs.gnu.org; 19 Nov 2023 04:27:00 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 18 23:26:59 2023
Received: from localhost ([127.0.0.1]:49738 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1r4ZOd-0007hf-HO
for submit <at> debbugs.gnu.org; Sat, 18 Nov 2023 23:26:59 -0500
Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]:55734)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <casouri@HIDDEN>) id 1r4ZOZ-0007hN-G2
for 67031 <at> debbugs.gnu.org; Sat, 18 Nov 2023 23:26:58 -0500
Received: by mail-pl1-x629.google.com with SMTP id
d9443c01a7336-1cc1ee2d8dfso29557285ad.3
for <67031 <at> debbugs.gnu.org>; Sat, 18 Nov 2023 20:26:54 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1700368008; x=1700972808; darn=debbugs.gnu.org;
h=to:references:message-id:content-transfer-encoding:cc:date
:in-reply-to:from:subject:mime-version:from:to:cc:subject:date
:message-id:reply-to;
bh=Qw4AYTt+j7ziIQB093vY5xrnjink/pvGzds2A015dR0=;
b=NGQo38hKbM+hcm63OpacLxyJPE+y9vZ37tG56c+cKtpH6exEdhyiuUcG7El03G9Iai
ObTmq+elhW2V8JdDxhOUAQtUX4/4iPjkGEhosRLZOjPjVoph2fWg9oBopjR4rbY68rDx
KOiusYCdMOTLnxytBXzoS7akeJrNx6bqlCuf+FjiEkbMoWUv3mzz7GDsWOiSvM+NP1Z8
8CxOmEoqdnw4Vgakn8kVARIOSu5PODPiNwDupU9D4a8sAYLGJUhnDHUGCaS7aU8PxUNO
WMXVY5i8Ps4Fp4i19pqTOBUphBiwWtsZgN6W7R4gJYdKutCP0ajqZTJK45NAULLLTXjH
/QIA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1700368008; x=1700972808;
h=to:references:message-id:content-transfer-encoding:cc:date
:in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=Qw4AYTt+j7ziIQB093vY5xrnjink/pvGzds2A015dR0=;
b=p2ftBdLh2SewFPngN4Oph37V66o4X+5DnVOWpDPdVJ5JPRhwxCmlTRpwxNn/IkIFMO
eROr7YFBIBPZoeMomsSDVujUGANhp8eRJ44twbzvu+a612q1UVzH5DRDCYd1WLGe8V7h
6SwnMRNYBIKkcJbmUWmAacVeLNTrb5SqAnq033WMohCzYecz6C1vD6PGBIKQMOCUtxVr
2BKGbKR9OSgALTlW+xLZU+ZBe22/PwMDq2EsTPKMtj8fPIPAVDuTA5Z/IejuSLA2ZaT7
YJ7ehCAxfbF7QQv8BDC19/08CCOHWb7IBkxhGJJKYljM+uPXEwO1GrSbGK5MFqWxuLkE
cI9w==
X-Gm-Message-State: AOJu0YyjNuq+7+mKFEIhQTeoPMJYbWZe8XqGEYSgQ7BaE6cPD0cuZfHR
4pt0fWj4EpYCNaDj+yIbn3U=
X-Google-Smtp-Source: AGHT+IGVTDVjHouRL8Stkn+5ATkVqW10kd6hUj4zZ6tasQ61lOuCcMYA8ALn4eCcSKyhenABA861Jg==
X-Received: by 2002:a17:902:e749:b0:1cc:5db8:7eb1 with SMTP id
p9-20020a170902e74900b001cc5db87eb1mr5662985plf.51.1700368008175;
Sat, 18 Nov 2023 20:26:48 -0800 (PST)
Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com.
[172.117.161.177]) by smtp.gmail.com with ESMTPSA id
p10-20020a170902e74a00b001c9c879ee4asm3720483plf.17.2023.11.18.20.26.47
(version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
Sat, 18 Nov 2023 20:26:47 -0800 (PST)
Content-Type: text/plain;
charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\))
Subject: Re: bug#67031: [PATCH] Fix typescript-ts-mode indentation in
unbracketed statements
From: Yuan Fu <casouri@HIDDEN>
In-Reply-To: <83pm07ml54.fsf@HIDDEN>
Date: Sat, 18 Nov 2023 20:26:36 -0800
Content-Transfer-Encoding: quoted-printable
Message-Id: <8BD033D0-C7B0-46F5-9D9D-66880B26AB95@HIDDEN>
References: <CAPVBTSf7dQWTYwXZELABDaSXCR0EEvKKnBzksAfyo3wr5K2_Tg@HIDDEN>
<83pm0bqgm7.fsf@HIDDEN> <98ce09c9-00a1-f5ad-79ad-ed4b8328ac31@HIDDEN>
<83pm07ml54.fsf@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
X-Mailer: Apple Mail (2.3731.700.6)
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 67031
Cc: noah.v.peart@HIDDEN, 67031 <at> debbugs.gnu.org,
Dmitry Gutov <dmitry@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
> On Nov 18, 2023, at 2:05 AM, Eli Zaretskii <eliz@HIDDEN> wrote:
>=20
>> Date: Thu, 16 Nov 2023 03:18:44 +0200
>> Cc: 67031 <at> debbugs.gnu.org
>> From: Dmitry Gutov <dmitry@HIDDEN>
>>=20
>> On 15/11/2023 15:40, Eli Zaretskii wrote:
>>>> From: nvp<noah.v.peart@HIDDEN>
>>>> Date: Thu, 9 Nov 2023 17:29:21 -0800
>>>>=20
>>>> Tags: patch
>>>>=20
>>>> * lisp/progmodes/typescript-ts-mode.el
>>>> (typescript-ts-mode--indent-rules): fix indentation after =
statements
>>>> without brackets
>>>>=20
>>>> Bug: There are no indentation rules for statement bodies following
>>>> if/for/for_in/do/while statements without brackets.
>>>>=20
>>>> Recipe to reproduce:
>>>> In a `typescript-ts-mode` buffer with the following code,
>>>>=20
>>>> if (true)
>>>> console.log('No indent here')
>>>>=20
>>>> Try to indent the second line.
>>> Dmitry, Yuan: any comments?
>>=20
>> I think it would be cool if the patch added a corresponding new case =
or=20
>> two in test/lisp/progmodes/typescript-ts-mode-resources/indent.erts
>=20
> Noah, would you please add such tests?
>=20
> Yuan, any comments or suggestions?
LGTM, I=E2=80=99ll also add else_clause too, like
((parent-is ,(rx (or (seq (or "if" "for" "for_in" "while" "do") =
"_statement")
"else_clause")))
parent-bol typescript-ts-mode-indent-offset)
Yuan
bug-gnu-emacs@HIDDEN:bug#67031; Package emacs.
Full text available.Received: (at 67031) by debbugs.gnu.org; 19 Nov 2023 01:25:05 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 18 20:25:05 2023 Received: from localhost ([127.0.0.1]:49675 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1r4WYb-0002fj-0b for submit <at> debbugs.gnu.org; Sat, 18 Nov 2023 20:25:05 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:40705) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <dmitry@HIDDEN>) id 1r4WYX-0002f3-QL for 67031 <at> debbugs.gnu.org; Sat, 18 Nov 2023 20:25:03 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 8DC5B32007CF; Sat, 18 Nov 2023 20:24:54 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sat, 18 Nov 2023 20:24:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1700357094; x=1700443494; bh=SteDPAlewvEq57L+eh0XGKK+j79E67lEqRl IPevKLNs=; b=XHdMO6H4+0osZT8bnnqksHaa2k8sirNTNRBqxYpIh82dtn9i8my +GmWJ6E7+0GvrBnC1DPY7NxcYjivCs0XP8CbQNaw2HAsiuduPLuRHBihlFCba0TW EFYsr3EPh/r3lvhFt93A9yd7YzrFlb+dZOeHML/IKBgvi5OQjMQqvThImOVHSatg nZDTRjhimmnKI7B5PquTIEQPgv6lPoDdgUQH957sSiuP4bRruoTuOZO8IZ1uL7Zy /twpasgYHLQhRmmqbvKzAZY4AKD7vWxeF0SZDuiJuzZ4obFqJEpu9THo6J/IvRO1 YMwjxOhWx00sa5Z2LrlRpNXSX8Jxszyx4IA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1700357094; x=1700443494; bh=SteDPAlewvEq57L+eh0XGKK+j79E67lEqRl IPevKLNs=; b=egDba45jKdz0eCXi+EMyNGpfFNEyUpVsik6xqYhV2NDKSI1Farr fZXcRF7fSEOe3t0XXabRh/6W0Kik515hulYhb9VyHMw4swvzXPFBp6F1tLBzy61i GkKJq6brQQSbs7E4Kp1un6m/xwCgil4AToADq+TFl37tAmXBxnvoNJ2IAUGIk6+i W47gIrgbPC/PsQdfyxy8w6t+megc2auBnVudcyS2iHoOIUE7UH0mhbfqqs9acM02 PkPR/OO/mPN0I8WVIufn5Z3AkFK/8lJ/sWgMXNRWcMvCX1oXwTOl9uVUml2kBgdF oudki9jynsPdF+vtP67ZoLuybXeDKLHMGKg== X-ME-Sender: <xms:5WNZZQPHUAmAcbSFUZpvTqaLvuA5vj3KTwvW3N1TUl-0pPJb1sDeZQ> <xme:5WNZZW-K6-J3bhvkhZ4UpX6xTbucWwo8NutATyQrd3wdNcRf-1Ab6BE95g6Kk3uXQ 4Ce_wO97nFAuqcYE-M> X-ME-Received: <xmr:5WNZZXQDXhRCz9CRi4eXjLSdSZo8VxoTmpVf-bbNDBnvwRo5MyoO8cOBFLOhqjxH9BdKzQ> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudegfedgfeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhephfffheeljeffgeffueeghfekkedtfffgheejvdegjeettdduheeufffggfef jeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: <xmx:5WNZZYsc9S6RQuBNmsVK-vjIvDTLZmyYf0QWZn_ZAwNBhhAFO10VIw> <xmx:5WNZZYfNaUwsV7569rMrs1y58KA_OzsCpk4PLiIggAefBEZqlGcqUQ> <xmx:5WNZZc1oDqOPZyvYpreucH8BNFgH-bPFabaMQy7MP8VKRNOKU4bQXg> <xmx:5mNZZZpkmNpIhSfN9C-evO1DmZUPK2umrkkUd9goZ2pliAksyF0U0g> Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 18 Nov 2023 20:24:52 -0500 (EST) Message-ID: <475bca51-dd02-46c5-0114-9588b43b756b@HIDDEN> Date: Sun, 19 Nov 2023 03:24:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#67031: [PATCH] Fix typescript-ts-mode indentation in unbracketed statements Content-Language: en-US To: Noah Peart <noah.v.peart@HIDDEN>, Eli Zaretskii <eliz@HIDDEN> References: <CAPVBTSf7dQWTYwXZELABDaSXCR0EEvKKnBzksAfyo3wr5K2_Tg@HIDDEN> <83pm0bqgm7.fsf@HIDDEN> <98ce09c9-00a1-f5ad-79ad-ed4b8328ac31@HIDDEN> <83pm07ml54.fsf@HIDDEN> <CAPVBTSf5n0X+TGbZ=Y1i_ExP=MzcTx-zhOC2UY_2Fr4Q3D0FxA@HIDDEN> From: Dmitry Gutov <dmitry@HIDDEN> In-Reply-To: <CAPVBTSf5n0X+TGbZ=Y1i_ExP=MzcTx-zhOC2UY_2Fr4Q3D0FxA@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 67031 Cc: casouri@HIDDEN, 67031 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.9 (---) On 19/11/2023 02:12, Noah Peart wrote: > Yea, I can do that. > > Is there a recipe for running the tests with a tree-sitter library path? You mean with the default tree-sitter librayr path overridden? I'm not sure. But note that you can run an ert test in your interactive session, or alter treesit-extra-load-path temporarily at the beginning of the ert test file, at least while you debug it locally.
bug-gnu-emacs@HIDDEN:bug#67031; Package emacs.
Full text available.
Received: (at 67031) by debbugs.gnu.org; 19 Nov 2023 00:13:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 18 19:13:06 2023
Received: from localhost ([127.0.0.1]:49669 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1r4VQv-0000no-IJ
for submit <at> debbugs.gnu.org; Sat, 18 Nov 2023 19:13:06 -0500
Received: from mail-oi1-x233.google.com ([2607:f8b0:4864:20::233]:42336)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <noah.v.peart@HIDDEN>) id 1r4VQt-0000nL-Vj
for 67031 <at> debbugs.gnu.org; Sat, 18 Nov 2023 19:13:04 -0500
Received: by mail-oi1-x233.google.com with SMTP id
5614622812f47-3b3f938331fso1634229b6e.1
for <67031 <at> debbugs.gnu.org>; Sat, 18 Nov 2023 16:13:02 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1700352777; x=1700957577; darn=debbugs.gnu.org;
h=cc:to:subject:message-id:date:from:in-reply-to:references
:mime-version:from:to:cc:subject:date:message-id:reply-to;
bh=8DM0OnAXnJvtgmIYrJBufiMymKoAVv3KeHwkbnYv0wU=;
b=ea33KjAr+G64B0vxX6jR3hwSBATHb3vH/o1psz07HA97FjiFYGprtV88GlSuPCdrFn
SrEVry1wgqEZbboZHSDAWxCq2Jlb9Op/vxtsoWECR3l8cFuVMPxBL3YrA3G+r3ZFNdjk
6yonZvAs3rWu7B7NmH7X71agPii0/SEwsJbqdwhrvCV1Je+TGfGYWcAQOxtjfllNn4g0
pDZdKuAuxsqvEsYobIIpYyT9xQiPxgGf9VwR6vDR60tosJKZCqi2DAfZiT43s7D0mcIN
dY9mJmZwdsbV1qaYcvy7tweb/9mZ4CSUtd2WMU5lTAq93IA0F8DUsuz0cMZci7dd9VgM
FYBw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1700352777; x=1700957577;
h=cc:to:subject:message-id:date:from:in-reply-to:references
:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=8DM0OnAXnJvtgmIYrJBufiMymKoAVv3KeHwkbnYv0wU=;
b=JidsWA3q0RacqCJcV+IR7/DMS0NLIxc50/vKQnDdRzoExasxvRhIT8FlElFIgIGhQQ
OCRfSNtZh8iqVF/4+lRGD2vU58LJKLOiHl1E1KssqDG5oa2fskRKFYnERtYVr8J03JA2
T3nd+lhGJL85QEQVgW76UywD1ch1x2ags6sl71DUMbzBxq1IFftdnwmEF6cOeumIArLd
lYaCFJ2SxWHPZjtaysRFObGLZp+tg9PaTgSZ1TqPYJflGB7P68SKa302xtGTN3jXUcab
v9WuirL0YMDvR8U7St1egWiVFLfAOtMBfVmzwy7Fu8GHlYR7bzSOagRuh3vA/Hnns28X
lx3w==
X-Gm-Message-State: AOJu0YxVJ5uom0X1g6Kwh/Xro7/e/CBkaXLRIqi+5d+kDnjJMXzbEJwI
md7cbXJLDH92lmnfAV/H6vq/sBYC32yQTTexdNg=
X-Google-Smtp-Source: AGHT+IFzVfT3Myte3KB5WFqOYyMeMoP+KaPN1PgIgqPCDegCYMryfiGgP/R6NqH3ujc5WQM9ipr+PoS3N2kgt0a9VH4=
X-Received: by 2002:a05:6808:178b:b0:3a7:e779:7fc1 with SMTP id
bg11-20020a056808178b00b003a7e7797fc1mr5143620oib.7.1700352777096; Sat, 18
Nov 2023 16:12:57 -0800 (PST)
MIME-Version: 1.0
References: <CAPVBTSf7dQWTYwXZELABDaSXCR0EEvKKnBzksAfyo3wr5K2_Tg@HIDDEN>
<83pm0bqgm7.fsf@HIDDEN> <98ce09c9-00a1-f5ad-79ad-ed4b8328ac31@HIDDEN>
<83pm07ml54.fsf@HIDDEN>
In-Reply-To: <83pm07ml54.fsf@HIDDEN>
From: Noah Peart <noah.v.peart@HIDDEN>
Date: Sat, 18 Nov 2023 16:12:46 -0800
Message-ID: <CAPVBTSf5n0X+TGbZ=Y1i_ExP=MzcTx-zhOC2UY_2Fr4Q3D0FxA@HIDDEN>
Subject: Re: bug#67031: [PATCH] Fix typescript-ts-mode indentation in
unbracketed statements
To: Eli Zaretskii <eliz@HIDDEN>
Content-Type: multipart/alternative; boundary="000000000000459389060a763b71"
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 67031
Cc: Dmitry Gutov <dmitry@HIDDEN>, casouri@HIDDEN, 67031 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--000000000000459389060a763b71
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Yea, I can do that.
Is there a recipe for running the tests with a tree-sitter library path?
On Sat, Nov 18, 2023 at 2:05=E2=80=AFAM Eli Zaretskii <eliz@HIDDEN> wrote:
> > Date: Thu, 16 Nov 2023 03:18:44 +0200
> > Cc: 67031 <at> debbugs.gnu.org
> > From: Dmitry Gutov <dmitry@HIDDEN>
> >
> > On 15/11/2023 15:40, Eli Zaretskii wrote:
> > >> From: nvp<noah.v.peart@HIDDEN>
> > >> Date: Thu, 9 Nov 2023 17:29:21 -0800
> > >>
> > >> Tags: patch
> > >>
> > >> * lisp/progmodes/typescript-ts-mode.el
> > >> (typescript-ts-mode--indent-rules): fix indentation after statements
> > >> without brackets
> > >>
> > >> Bug: There are no indentation rules for statement bodies following
> > >> if/for/for_in/do/while statements without brackets.
> > >>
> > >> Recipe to reproduce:
> > >> In a `typescript-ts-mode` buffer with the following code,
> > >>
> > >> if (true)
> > >> console.log('No indent here')
> > >>
> > >> Try to indent the second line.
> > > Dmitry, Yuan: any comments?
> >
> > I think it would be cool if the patch added a corresponding new case or
> > two in test/lisp/progmodes/typescript-ts-mode-resources/indent.erts
>
> Noah, would you please add such tests?
>
> Yuan, any comments or suggestions?
>
--000000000000459389060a763b71
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr">Yea, I can=C2=A0do that.<div><br></div><div>Is there a rec=
ipe for running the tests with a tree-sitter library path?</div></div><br><=
div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Sat, Nov=
18, 2023 at 2:05=E2=80=AFAM Eli Zaretskii <<a href=3D"mailto:eliz@HIDDEN=
rg">eliz@HIDDEN</a>> wrote:<br></div><blockquote class=3D"gmail_quote" =
style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);pa=
dding-left:1ex">> Date: Thu, 16 Nov 2023 03:18:44 +0200<br>
> Cc: <a href=3D"mailto:67031 <at> debbugs.gnu.org" target=3D"_blank">67031@d=
ebbugs.gnu.org</a><br>
> From: Dmitry Gutov <<a href=3D"mailto:dmitry@HIDDEN" target=3D"_=
blank">dmitry@HIDDEN</a>><br>
> <br>
> On 15/11/2023 15:40, Eli Zaretskii wrote:<br>
> >> From: nvp<<a href=3D"mailto:noah.v.peart@HIDDEN" target=
=3D"_blank">noah.v.peart@HIDDEN</a>><br>
> >> Date: Thu, 9 Nov 2023 17:29:21 -0800<br>
> >><br>
> >> Tags: patch<br>
> >><br>
> >> * lisp/progmodes/typescript-ts-mode.el<br>
> >> (typescript-ts-mode--indent-rules): fix indentation after sta=
tements<br>
> >> without brackets<br>
> >><br>
> >> Bug: There are no indentation rules for statement bodies foll=
owing<br>
> >> if/for/for_in/do/while statements without brackets.<br>
> >><br>
> >> Recipe to reproduce:<br>
> >> In a `typescript-ts-mode` buffer with the following code,<br>
> >><br>
> >>=C2=A0 =C2=A0 =C2=A0 if (true)<br>
> >>=C2=A0 =C2=A0 =C2=A0 console.log('No indent here')<br>
> >><br>
> >> Try to indent the second line.<br>
> > Dmitry, Yuan: any comments?<br>
> <br>
> I think it would be cool if the patch added a corresponding new case o=
r <br>
> two in test/lisp/progmodes/typescript-ts-mode-resources/indent.erts<br=
>
<br>
Noah, would you please add such tests?<br>
<br>
Yuan, any comments or suggestions?<br>
</blockquote></div>
--000000000000459389060a763b71--
bug-gnu-emacs@HIDDEN:bug#67031; Package emacs.
Full text available.
Received: (at 67031) by debbugs.gnu.org; 18 Nov 2023 10:05:56 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 18 05:05:56 2023
Received: from localhost ([127.0.0.1]:47843 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1r4ID6-0000GH-1X
for submit <at> debbugs.gnu.org; Sat, 18 Nov 2023 05:05:56 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:43180)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1r4ID4-0000G4-Io
for 67031 <at> debbugs.gnu.org; Sat, 18 Nov 2023 05:05:55 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1r4ICy-0004NY-Gq; Sat, 18 Nov 2023 05:05:48 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=dEfsr3UZKGa1Iyy9taMBHRrJTH/vwngDnS+cF+Y7qKs=; b=DOCHAgUbpXxh
CHZ9hY4KfJxodqaF4MljMsZj6tzm5TkXqB0iI6Vy6o9A742VaWWOee6G5zj8SXzyw+pfxXUUKpljL
dyvJtQlYw1SUScut6B6qOOLEFnPUxgdmEP2sB5uVme+R6s9rxv+IkZSfXQKX2PQkZ3HXL/GgVWYr5
xb1bgcIDTn4uXXfZoMcXJpxtB2uFFTcCA6qNaGSdkNSiuziNxAbHc5yxs75sEZeyVLSzAhT/fVlvl
MdjafLzjO2AY2Gzku57VDIlYF7aSVVD7rDg+GzNV+Y2zrktk63FE7vj4hZ+9/GyFs/6GAkyu/7byZ
346ml9n2Rvnb2XX+WlTmeQ==;
Date: Sat, 18 Nov 2023 12:05:43 +0200
Message-Id: <83pm07ml54.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: casouri@HIDDEN, noah.v.peart@HIDDEN, Dmitry Gutov <dmitry@HIDDEN>
In-Reply-To: <98ce09c9-00a1-f5ad-79ad-ed4b8328ac31@HIDDEN> (message from
Dmitry Gutov on Thu, 16 Nov 2023 03:18:44 +0200)
Subject: Re: bug#67031: [PATCH] Fix typescript-ts-mode indentation in
unbracketed statements
References: <CAPVBTSf7dQWTYwXZELABDaSXCR0EEvKKnBzksAfyo3wr5K2_Tg@HIDDEN>
<83pm0bqgm7.fsf@HIDDEN> <98ce09c9-00a1-f5ad-79ad-ed4b8328ac31@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 67031
Cc: 67031 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> Date: Thu, 16 Nov 2023 03:18:44 +0200
> Cc: 67031 <at> debbugs.gnu.org
> From: Dmitry Gutov <dmitry@HIDDEN>
>
> On 15/11/2023 15:40, Eli Zaretskii wrote:
> >> From: nvp<noah.v.peart@HIDDEN>
> >> Date: Thu, 9 Nov 2023 17:29:21 -0800
> >>
> >> Tags: patch
> >>
> >> * lisp/progmodes/typescript-ts-mode.el
> >> (typescript-ts-mode--indent-rules): fix indentation after statements
> >> without brackets
> >>
> >> Bug: There are no indentation rules for statement bodies following
> >> if/for/for_in/do/while statements without brackets.
> >>
> >> Recipe to reproduce:
> >> In a `typescript-ts-mode` buffer with the following code,
> >>
> >> if (true)
> >> console.log('No indent here')
> >>
> >> Try to indent the second line.
> > Dmitry, Yuan: any comments?
>
> I think it would be cool if the patch added a corresponding new case or
> two in test/lisp/progmodes/typescript-ts-mode-resources/indent.erts
Noah, would you please add such tests?
Yuan, any comments or suggestions?
bug-gnu-emacs@HIDDEN:bug#67031; Package emacs.
Full text available.
Received: (at 67031) by debbugs.gnu.org; 16 Nov 2023 01:18:59 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Nov 15 20:18:58 2023
Received: from localhost ([127.0.0.1]:54228 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1r3R22-0008Os-Jg
for submit <at> debbugs.gnu.org; Wed, 15 Nov 2023 20:18:58 -0500
Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:47311)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <dmitry@HIDDEN>) id 1r3R1x-0008OZ-TB
for 67031 <at> debbugs.gnu.org; Wed, 15 Nov 2023 20:18:56 -0500
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.west.internal (Postfix) with ESMTP id 63A333200AFD;
Wed, 15 Nov 2023 20:18:48 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
by compute1.internal (MEProxy); Wed, 15 Nov 2023 20:18:48 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc
:cc:content-transfer-encoding:content-type:content-type:date
:date:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:sender:subject:subject:to:to; s=fm2; t=
1700097527; x=1700183927; bh=Zuw2Gk9coRCWvASNWZK0PrWkatDa9nnRl4z
BytHeKNk=; b=QEtO5YbiRGBHE/ed0XALEK1ViN/CN5U5I+P78aSq0f4Tu3V1Kh7
OIeKqdY1hC8FxcVoUQoaqMJq3pYgIw/rbBWU7plKmRJI+bdhUviy0k0va1cHeeDL
xccLoTy3qtOCyu9TThCbftN9RcflFoQ2RldmjJi8e+edRkFCZ2IWJfUnzx43I9le
td2s9M4z8gDQAhAejGbVmSuWPh5b2wC28BbifFL226KG3c0AIZLzC6ht4rkJH6j3
8IfykOXUChzAjXL7FK0Qj98US4nO1JQxUXNBrQlaJs0mR1g+CmwsJLuPfujDFBWJ
4yryZtRzRZEJVuTgAO+99/g8CaQ6dlMRJYQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-transfer-encoding
:content-type:content-type:date:date:feedback-id:feedback-id
:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:sender:subject:subject:to:to:x-me-proxy
:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=
1700097527; x=1700183927; bh=Zuw2Gk9coRCWvASNWZK0PrWkatDa9nnRl4z
BytHeKNk=; b=k6XxuQ/vK+Y+7XiigVvcWq2vy00bsHuTh/iVYDIxCAHT5fjm6/a
3ANxFOu27kHc7Rg/TVdHJDy7acp1TjDu2Uh8xz05esbGAEZdNwHACosVoKnwO72q
Yw5fjgboYuNhTJ/vIwZf10R/Ep/cNjGgvGVarBxLUPpMILcMa8KcSGYfV8B/uCrJ
04/PqkIXg1m3Dr7KAqlE5dqiK/R4dzsKgyHjnEefcw6jkjcSZiA/m403JBsHrcFt
rJZumgvIlQ4YvxMKmW6yeD1jsNWqHDgkimYDLxfvN/03NsA3KzfJh+UTBdTdS0My
zQx2U0v2QuTGKvKirvozYOgry7y4Pt3+N+g==
X-ME-Sender: <xms:921VZdTuGk_-rrvgbfiqnxcBdxrbjKrUDPIsEh3FELAQTylgPPys9A>
<xme:921VZWxEcCwUkgDeFHi8m5oZDDIIPmLEmlrDmgwiPWljXsopvpzvmgQ2XsA9jpkXN
3nErdvOqHa-fttTCvY>
X-ME-Received: <xmr:921VZS2CNnzw4iPy0XJjnqkwwRsSEGyGS44DAIMJw81wDcZOXXHIDszSg9vbwiLM_hJYDw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudefjedgfeefucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi
thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth
htvghrnhepiefgteevheevveffheeltdeukeeiieekueefgedugfefgefhudelgfefveel
vdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug
hmihhtrhihsehguhhtohhvrdguvghv
X-ME-Proxy: <xmx:921VZVBHiSjhhtA6poJ1GfF15MHCVPQY3Y3faqMLMPk59M3A8CsEXQ>
<xmx:921VZWgBifKUDkSsPhcYxadFKb2fi0zpWIGjP0mZQoxjouLFAgkeuw>
<xmx:921VZZqlX1if2Oo2c6M3bVL3MBkUche9srvQ6rQ9YZl6QeBrmUSDtA>
<xmx:921VZZvTW-T16kTQiq4X2gB6jfxfzc1OfueE1MDM1O3HvTO-8ztQnQ>
Feedback-ID: i0e71465a:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed,
15 Nov 2023 20:18:46 -0500 (EST)
Message-ID: <98ce09c9-00a1-f5ad-79ad-ed4b8328ac31@HIDDEN>
Date: Thu, 16 Nov 2023 03:18:44 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
Thunderbird/102.13.0
Subject: Re: bug#67031: [PATCH] Fix typescript-ts-mode indentation in
unbracketed statements
Content-Language: en-US
To: Eli Zaretskii <eliz@HIDDEN>, nvp <noah.v.peart@HIDDEN>,
Yuan Fu <casouri@HIDDEN>
References: <CAPVBTSf7dQWTYwXZELABDaSXCR0EEvKKnBzksAfyo3wr5K2_Tg@HIDDEN>
<83pm0bqgm7.fsf@HIDDEN>
From: Dmitry Gutov <dmitry@HIDDEN>
In-Reply-To: <83pm0bqgm7.fsf@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: -4.4 (----)
X-Debbugs-Envelope-To: 67031
Cc: 67031 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -5.4 (-----)
On 15/11/2023 15:40, Eli Zaretskii wrote:
>> From: nvp<noah.v.peart@HIDDEN>
>> Date: Thu, 9 Nov 2023 17:29:21 -0800
>>
>> Tags: patch
>>
>> * lisp/progmodes/typescript-ts-mode.el
>> (typescript-ts-mode--indent-rules): fix indentation after statements
>> without brackets
>>
>> Bug: There are no indentation rules for statement bodies following
>> if/for/for_in/do/while statements without brackets.
>>
>> Recipe to reproduce:
>> In a `typescript-ts-mode` buffer with the following code,
>>
>> if (true)
>> console.log('No indent here')
>>
>> Try to indent the second line.
> Dmitry, Yuan: any comments?
I think it would be cool if the patch added a corresponding new case or
two in test/lisp/progmodes/typescript-ts-mode-resources/indent.erts
bug-gnu-emacs@HIDDEN:bug#67031; Package emacs.
Full text available.
Received: (at 67031) by debbugs.gnu.org; 15 Nov 2023 16:07:43 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Nov 15 11:07:43 2023
Received: from localhost ([127.0.0.1]:53009 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1r3IQY-0001TI-MZ
for submit <at> debbugs.gnu.org; Wed, 15 Nov 2023 11:07:42 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:58120)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1r3IQR-0001QS-Nl
for 67031 <at> debbugs.gnu.org; Wed, 15 Nov 2023 11:07:36 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1r3G8Y-0004KV-EM; Wed, 15 Nov 2023 08:40:58 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=NOSWPeg4j3J3I79ZQ7EVFdlK8oHXFPTDT7tg1kEcWLE=; b=mERgmShuAsPH
9SHRnSa9ntXfUlm/XyCy8fIK4mZKFk/B2qhn8OzsyoUVu4UukErXzSZUDSD1W94IdtHFB/6DuRmr5
jWF1G531VLA2ZYXWXEW0vVQ42oT+vhyKzoUKZct9vVBQxBPJTo0OSW9tcpi33+6ipNMVitl/5zXOC
GEBkeQA6WoybgIbUw/5PayX4Vrxc0pxDKGqk0f5uxCUlzPurED+9FEjG/a3IiG6+8ZiF+YgxQn8Zf
vrK6faiJe3E1OEGZ+QMS15k3TaNG5kYoiEsQw/T/cyCqvrFglbjOKyjxTfF6bMS3QmktfcCDthtZH
W3Rj0cmogrCo2RTYUHYE8w==;
Date: Wed, 15 Nov 2023 15:40:48 +0200
Message-Id: <83pm0bqgm7.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: nvp <noah.v.peart@HIDDEN>, Dmitry Gutov <dmitry@HIDDEN>,
Yuan Fu <casouri@HIDDEN>
In-Reply-To: <CAPVBTSf7dQWTYwXZELABDaSXCR0EEvKKnBzksAfyo3wr5K2_Tg@HIDDEN>
(message from nvp on Thu, 9 Nov 2023 17:29:21 -0800)
Subject: Re: bug#67031: [PATCH] Fix typescript-ts-mode indentation in
unbracketed statements
References: <CAPVBTSf7dQWTYwXZELABDaSXCR0EEvKKnBzksAfyo3wr5K2_Tg@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 67031
Cc: 67031 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> From: nvp <noah.v.peart@HIDDEN>
> Date: Thu, 9 Nov 2023 17:29:21 -0800
>
> Tags: patch
>
> * lisp/progmodes/typescript-ts-mode.el
> (typescript-ts-mode--indent-rules): fix indentation after statements
> without brackets
>
> Bug: There are no indentation rules for statement bodies following
> if/for/for_in/do/while statements without brackets.
>
> Recipe to reproduce:
> In a `typescript-ts-mode` buffer with the following code,
>
> if (true)
> console.log('No indent here')
>
> Try to indent the second line.
Dmitry, Yuan: any comments?
bug-gnu-emacs@HIDDEN:bug#67031; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 10 Nov 2023 01:30:26 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 09 20:30:26 2023
Received: from localhost ([127.0.0.1]:49211 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1r1GLp-0004E9-JP
for submit <at> debbugs.gnu.org; Thu, 09 Nov 2023 20:30:26 -0500
Received: from lists.gnu.org ([2001:470:142::17]:37178)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <noah.v.peart@HIDDEN>) id 1r1GLm-0004Du-RE
for submit <at> debbugs.gnu.org; Thu, 09 Nov 2023 20:30:24 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <noah.v.peart@HIDDEN>)
id 1r1GL3-0002uI-RE
for bug-gnu-emacs@HIDDEN; Thu, 09 Nov 2023 20:29:37 -0500
Received: from mail-oa1-x34.google.com ([2001:4860:4864:20::34])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <noah.v.peart@HIDDEN>)
id 1r1GL2-0006CK-3U
for bug-gnu-emacs@HIDDEN; Thu, 09 Nov 2023 20:29:37 -0500
Received: by mail-oa1-x34.google.com with SMTP id
586e51a60fabf-1efabc436e4so829467fac.1
for <bug-gnu-emacs@HIDDEN>; Thu, 09 Nov 2023 17:29:34 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1699579773; x=1700184573; darn=gnu.org;
h=to:subject:message-id:date:from:mime-version:from:to:cc:subject
:date:message-id:reply-to;
bh=gMv/yryOWkVTBySKkmPBzhN/Lpmxh/g9fD/T43yvB+g=;
b=eVn+2M1vh/3yf8pBQF6PjnKMXrCiIffdYVJ2d5f8PqcllO5eviXMUBqWnQtgvSFLzG
d8SdgdD7hen2aeeNse+ala/JqXkbVmJYhhhLsvdJkem+G5NI2+/fslg7QxshwoNNwKYh
Oe9kINFcjGKO4wd3uZPpg/xuEECzS0Fk4jKjQIv6VIsPf+KSQ5RHTIUrHIYhy0UBSv9X
sRC17G9EMwtTkRJmo/DrePOKsmneAZ0TJSfcyvqMoNgYgdgK4GCVUbNiRs+wl3wLy2l7
kHcVs9m8Ixuy5tDEuQ3Ao5oqwRVk1MjvG8iBgnwTLbMq9qoUuaNVSpJGBnuTn5muPMS2
GKqw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1699579773; x=1700184573;
h=to:subject:message-id:date:from:mime-version:x-gm-message-state
:from:to:cc:subject:date:message-id:reply-to;
bh=gMv/yryOWkVTBySKkmPBzhN/Lpmxh/g9fD/T43yvB+g=;
b=gj0XhSQeOZV6jQ3cf+3wASQsgDa3nDqdAI/ccyrcnE/9qMGvdcYrqCzg87yBOo8Gyj
wl4QbJcaYjHbx7QRp/VRCgG4qSuZVaMVJg3JeUlh/e/7g7jPsuxflNzpnIFa+pW4qFGT
k2to1amD5bqB+U/L3HETUkPAybnLDB8Pxdjxqbo/jCqMnYqIQUSYfPkFTZdwpMcZ7Qbz
MjjN9EzGLi8BMMruNEii7JGf5hWrjV/xKdxzlDQfhUAW5QDvockU1VuSEzfF7WnuFbBs
+seO9xiFkBORvRfi6SXdLIvs4XIvqTzy9X850lNQ+sBPCLyGpOF0kVUfBPvFpt7pLNIU
Zh5w==
X-Gm-Message-State: AOJu0Yzg2TziuvS2PnLAiwB8V80C0Au5n0rOyOSkQRwLm5psialidP+n
d0dMDbTbl6a7A1y9z1pPXO6SQ3PVUUk6B20Uy0gdmwtTZZY+DyMh
X-Google-Smtp-Source: AGHT+IEceLgH/TZD7rDm1YoUo5hzlKBB0UvuWZ+zH+KlIV0XUp8qnY7hSa2dmXHpysbiiflVgn7Ix9BhBuvmwdGVrQ4=
X-Received: by 2002:a05:6871:3146:b0:1e9:f9e5:d34e with SMTP id
lu6-20020a056871314600b001e9f9e5d34emr7328529oac.15.1699579772856; Thu, 09
Nov 2023 17:29:32 -0800 (PST)
MIME-Version: 1.0
From: nvp <noah.v.peart@HIDDEN>
Date: Thu, 9 Nov 2023 17:29:21 -0800
Message-ID: <CAPVBTSf7dQWTYwXZELABDaSXCR0EEvKKnBzksAfyo3wr5K2_Tg@HIDDEN>
Subject: [PATCH] Fix typescript-ts-mode indentation in unbracketed statements
To: bug-gnu-emacs@HIDDEN
Content-Type: multipart/mixed; boundary="000000000000a1027a0609c24091"
Received-SPF: pass client-ip=2001:4860:4864:20::34;
envelope-from=noah.v.peart@HIDDEN; helo=mail-oa1-x34.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
--000000000000a1027a0609c24091
Content-Type: multipart/alternative; boundary="000000000000a102790609c2408f"
--000000000000a102790609c2408f
Content-Type: text/plain; charset="UTF-8"
Tags: patch
* lisp/progmodes/typescript-ts-mode.el
(typescript-ts-mode--indent-rules): fix indentation after statements
without brackets
Bug: There are no indentation rules for statement bodies following
if/for/for_in/do/while statements without brackets.
Recipe to reproduce:
In a `typescript-ts-mode` buffer with the following code,
if (true)
console.log('No indent here')
Try to indent the second line.
In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.33, cairo version 1.16.0) of 2023-11-05 built on noah-X580VD
Repository revision: b819b8d6e90337b4cb36b35c2c6d0112c90a8e24
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Ubuntu 22.04.3 LTS
Configured using:
'configure --prefix=/usr/local --with-modules --with-tree-sitter
--with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls
--with-json --with-mailutils --with-jpeg --with-png --with-rsvg
--with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12
CXX=gcc-12'
--000000000000a102790609c2408f
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr">Tags: patch<br><br><br>* lisp/progmodes/typescript-ts-mode=
.el<br>(typescript-ts-mode--indent-rules): fix indentation after statements=
<br>without brackets<br><br>Bug: There are no indentation rules for stateme=
nt bodies following<br>if/for/for_in/do/while statements without brackets.<=
br><br>Recipe to reproduce:<br>In a `typescript-ts-mode` buffer with the fo=
llowing code, <br><br>=C2=A0 =C2=A0 if (true)<br>=C2=A0 =C2=A0 console.log(=
'No indent here')<br><br>Try to indent the second line.<br><br>In G=
NU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version<br>3.24.33, ca=
iro version 1.16.0) of 2023-11-05 built on noah-X580VD<br>Repository revisi=
on: b819b8d6e90337b4cb36b35c2c6d0112c90a8e24<br>Repository branch: master<b=
r>Windowing system distributor 'The X.Org Foundation', version 11.0=
.12101004<br>System Description: Ubuntu 22.04.3 LTS<br><br>Configured using=
:<br>=C2=A0'configure --prefix=3D/usr/local --with-modules --with-tree-=
sitter<br>--with-threads --with-x-toolkit=3Dgtk3 --with-xwidgets --with-gnu=
tls<br>--with-json --with-mailutils --with-jpeg --with-png --with-rsvg<br>-=
-with-tiff --with-xml2 --with-xpm --with-imagemagick CC=3Dgcc-12<br>CXX=3Dg=
cc-12'<br></div>
--000000000000a102790609c2408f--
--000000000000a1027a0609c24091
Content-Type: text/x-patch; charset="US-ASCII"; name="typescript-ts-mode-indentation.patch"
Content-Disposition: attachment;
filename="typescript-ts-mode-indentation.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_lorxvy6w0>
X-Attachment-Id: f_lorxvy6w0
RnJvbSAyMDE0NzkzYTdjYTM3MGYyNTk3OGEzZDBiZDZhYzZmZGIyZmIyY2E5IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBudmVybm8gPG5vYWgudi5wZWFydEBnbWFpbC5jb20+CkRhdGU6
IFRodSwgOSBOb3YgMjAyMyAxNzoxOTozNCAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdIEZpeCB0eXBl
c2NyaXB0LXRzLW1vZGUgaW5kZW50YXRpb24gaW4gdW5icmFja2V0ZWQgc3RhdGVtZW50cwoKLS0t
CiBsaXNwL3Byb2dtb2Rlcy90eXBlc2NyaXB0LXRzLW1vZGUuZWwgfCA0ICsrKysKIDEgZmlsZSBj
aGFuZ2VkLCA0IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9saXNwL3Byb2dtb2Rlcy90eXBl
c2NyaXB0LXRzLW1vZGUuZWwgYi9saXNwL3Byb2dtb2Rlcy90eXBlc2NyaXB0LXRzLW1vZGUuZWwK
aW5kZXggYjk3NjE0NWRiZjMuLmU2NzFhZDVkMmQ3IDEwMDY0NAotLS0gYS9saXNwL3Byb2dtb2Rl
cy90eXBlc2NyaXB0LXRzLW1vZGUuZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMvdHlwZXNjcmlwdC10
cy1tb2RlLmVsCkBAIC0xMjQsNiArMTI0LDEwIEBAIHR5cGVzY3JpcHQtdHMtbW9kZS0taW5kZW50
LXJ1bGVzCiAgICAgICgocGFyZW50LWlzICJhcnJvd19mdW5jdGlvbiIpIHBhcmVudC1ib2wgdHlw
ZXNjcmlwdC10cy1tb2RlLWluZGVudC1vZmZzZXQpCiAgICAgICgocGFyZW50LWlzICJwYXJlbnRo
ZXNpemVkX2V4cHJlc3Npb24iKSBwYXJlbnQtYm9sIHR5cGVzY3JpcHQtdHMtbW9kZS1pbmRlbnQt
b2Zmc2V0KQogICAgICAoKHBhcmVudC1pcyAiYmluYXJ5X2V4cHJlc3Npb24iKSBwYXJlbnQtYm9s
IHR5cGVzY3JpcHQtdHMtbW9kZS1pbmRlbnQtb2Zmc2V0KQorICAgICAoKG1hdGNoICJ3aGlsZSIg
ImRvX3N0YXRlbWVudCIpIHBhcmVudC1ib2wgMCkKKyAgICAgKChtYXRjaCAiZWxzZSIgImlmX3N0
YXRlbWVudCIpIHBhcmVudC1ib2wgMCkKKyAgICAgKChwYXJlbnQtaXMgLChyeCAoc2VxIChvciAi
aWYiICJmb3IiICJmb3JfaW4iICJ3aGlsZSIgImRvIikgIl9zdGF0ZW1lbnQiKSkpCisgICAgICBw
YXJlbnQtYm9sIHR5cGVzY3JpcHQtdHMtbW9kZS1pbmRlbnQtb2Zmc2V0KQogCiAgICAgICxAKHdo
ZW4gKGVxIGxhbmd1YWdlICd0c3gpCiAJIChhcHBlbmQgKHRzeC10cy1tb2RlLS1pbmRlbnQtY29t
cGF0aWJpbGl0eS1iODkzNDI2KQotLSAKMi4zNC4xCgo=
--000000000000a1027a0609c24091--
nvp <noah.v.peart@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#67031; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.