GNU bug report logs - #67062
30.0.50; [PATCH] Abbreviate the revision in 'vc-annotate' (for Git)

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Reported by: Jim Porter <jporterbugs@HIDDEN>; Keywords: patch; dated Sat, 11 Nov 2023 02:51:02 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 67062 <at> debbugs.gnu.org:


Received: (at 67062) by debbugs.gnu.org; 13 Nov 2023 07:09:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Nov 13 02:09:15 2023
Received: from localhost ([127.0.0.1]:57447 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r2R4N-0006M4-FG
	for submit <at> debbugs.gnu.org; Mon, 13 Nov 2023 02:09:15 -0500
Received: from relay6-d.mail.gandi.net ([2001:4b98:dc4:8::226]:56359)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>) id 1r2R4K-0006Lj-Ig
 for 67062 <at> debbugs.gnu.org; Mon, 13 Nov 2023 02:09:14 -0500
Received: by mail.gandi.net (Postfix) with ESMTPSA id 9EC0FC0005;
 Mon, 13 Nov 2023 07:08:23 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Jim Porter <jporterbugs@HIDDEN>
Subject: Re: bug#67062: 30.0.50; [PATCH] Abbreviate the revision in
 'vc-annotate' (for Git)
In-Reply-To: <2f7c9164-4a64-91c6-245e-61208de8560c@HIDDEN> (Jim Porter's
 message of "Sun, 12 Nov 2023 14:13:58 -0800")
Organization: LINKOV.NET
References: <66fc4912-6aa5-79da-bd6f-52f068cf1a77@HIDDEN>
 <83y1f4wxby.fsf@HIDDEN>
 <2eb31324-ae24-db4b-4f62-a0140bfb9f81@HIDDEN>
 <83sf5bv77j.fsf@HIDDEN>
 <ea6fbea1-d918-f534-4dd3-ee29b631cc6d@HIDDEN>
 <83bkbzusri.fsf@HIDDEN>
 <ad938cf5-201a-79f0-2b29-c4e0db230f9f@HIDDEN>
 <86msvi95aw.fsf@HIDDEN>
 <8742d731-62ba-0808-bdc6-cbad1cf98116@HIDDEN>
 <2f7c9164-4a64-91c6-245e-61208de8560c@HIDDEN>
Date: Mon, 13 Nov 2023 09:02:35 +0200
Message-ID: <868r72895g.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 67062
Cc: Dmitry Gutov <dmitry@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
 67062 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

> We just want to take that revision and turn it into a friendlier
> (read: shorter) form for the buffer name.

Then the best solution is to introduce a new variable
'vc-short-revision' that vc-annotate should either set as a
buffer-local value or let-bind around the vc backend API call.

Then the git backend could use it optionally depending
on the value of a new user option 'vc-git-short-revision'.

This is much better that adding a new API call.  We don't add
new API calls lightly since any change in API requires updating
the documentation at the top of vc.el and at the top of vc backend
implementation files.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67062; Package emacs. Full text available.

Message received at 67062 <at> debbugs.gnu.org:


Received: (at 67062) by debbugs.gnu.org; 12 Nov 2023 22:16:10 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 12 17:16:10 2023
Received: from localhost ([127.0.0.1]:57206 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r2IkU-00064k-FI
	for submit <at> debbugs.gnu.org; Sun, 12 Nov 2023 17:16:10 -0500
Received: from mail-oi1-x22f.google.com ([2607:f8b0:4864:20::22f]:51228)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jporterbugs@HIDDEN>) id 1r2IkS-00063V-5H
 for 67062 <at> debbugs.gnu.org; Sun, 12 Nov 2023 17:16:08 -0500
Received: by mail-oi1-x22f.google.com with SMTP id
 5614622812f47-3b6d80daae8so1122836b6e.2
 for <67062 <at> debbugs.gnu.org>; Sun, 12 Nov 2023 14:15:26 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1699827321; x=1700432121; darn=debbugs.gnu.org;
 h=content-transfer-encoding:in-reply-to:from:references:cc:to
 :content-language:subject:mime-version:date:message-id:from:to:cc
 :subject:date:message-id:reply-to;
 bh=/+KrL80b01ymyS/sYD6vnOxTaUkbqq5SmSnkCz6O+UU=;
 b=P0aJBGm6vMrofPTgjoW1oAkLA7bMxPF0xjZ+HwzXoQ4nf+z9PTtEGNNBob0JXFQPlG
 MBgrdoVfY29T+5FiHMVP3h4UC9Ck/LVdTiV4uZaESXiqvDZJ98kYNHkl3zfLaVFHHXR1
 Rov/h/NEkjuWWJukEanB0yTVQHblL3e/pfuMOOoDz+52cB8ZxBDXINztp4lyGtIy9gj0
 ehc1KPAKVrHGLhSKx4c+RSlT+n7wzO8nNQ7muSvV5wL5yzjwQBRm6dl3qFdzmgaLde5s
 sORG3iFMqaOpTIWNRPlbcZyIlwLa/7gOdIYt28DHjOIJp1iKvteY01Utj5aUzEVLYlAE
 XB/Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1699827321; x=1700432121;
 h=content-transfer-encoding:in-reply-to:from:references:cc:to
 :content-language:subject:mime-version:date:message-id
 :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=/+KrL80b01ymyS/sYD6vnOxTaUkbqq5SmSnkCz6O+UU=;
 b=Ncjl/pddlaNerz2/gTseQK0x/LfkhO0H/eEt0irwHQ31IeFLoNY2hBuasxQJfW95Td
 EjO7p4SNIBrD2cHFSzHnTnQ3t0evRH5hAvlOYcUaDhu4D9OXZsZHVRyA0o51aYEgZBpY
 bKMEDNf6EiGIx2JjpOb1wwUVWfIFFD58NJUeCM8mtUPlU+qvs5OAEPmGlu9lA9lOdLvS
 vLYm+pXskGjAQ0gqPJKkeQdoz0+lM3V6gHVmpJ9bV48i63EvLIZdNhKnUXui7ynhUJ3H
 qcvuiG3k3ejimYjBWvIC6sGM54bGKRhjhyv1G1Yo2W1FcQqSjzLVvbmGb9v1ouQuOjdM
 vgAw==
X-Gm-Message-State: AOJu0YwlZWMCqf4RcrRc+ohamaiXgZFBHHDaKuBhY2pz7isS+8/1x0l2
 /jxvLlDCWAARBFUIdz7nqR8=
X-Google-Smtp-Source: AGHT+IE9dQtNvuNziBT+vKxeuyOl+hStGLDUG+KdCw5BqpoqFMeleb9NXHQ6JzJRLeLQONkFS1eJHw==
X-Received: by 2002:a05:6808:3089:b0:3b5:75ec:44fd with SMTP id
 bl9-20020a056808308900b003b575ec44fdmr7956877oib.13.1699827321145; 
 Sun, 12 Nov 2023 14:15:21 -0800 (PST)
Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com.
 [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id
 q14-20020a63e20e000000b0056946623d7esm3050101pgh.55.2023.11.12.14.15.20
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 12 Nov 2023 14:15:20 -0800 (PST)
Message-ID: <75f8d9ca-8d15-c968-7fb2-3ef4c6731fae@HIDDEN>
Date: Sun, 12 Nov 2023 14:15:20 -0800
MIME-Version: 1.0
Subject: Re: bug#67062: 30.0.50; [PATCH] Abbreviate the revision in
 'vc-annotate' (for Git)
Content-Language: en-US
To: Dmitry Gutov <dmitry@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>
References: <66fc4912-6aa5-79da-bd6f-52f068cf1a77@HIDDEN>
 <83y1f4wxby.fsf@HIDDEN> <2eb31324-ae24-db4b-4f62-a0140bfb9f81@HIDDEN>
 <83sf5bv77j.fsf@HIDDEN> <399f2f1e-7c1f-e272-2a9d-4e36e8d8666b@HIDDEN>
 <894ab706-20ff-8773-be39-9d4a3c924872@HIDDEN>
From: Jim Porter <jporterbugs@HIDDEN>
In-Reply-To: <894ab706-20ff-8773-be39-9d4a3c924872@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 67062
Cc: 67062 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On 11/12/2023 12:35 PM, Dmitry Gutov wrote:
> On 12/11/2023 21:07, Jim Porter wrote:
>> In any case, we don't necessarily need to provide a default 
>> implementation for the 'short-revision' function. What about something 
>> like this? I'm not sure it's better, but it does let us avoid defining 
>> a no-op implementation for the "default backend".
> 
> Looks worse to me than having the default "identity" implementation.
> 
> Sorry.
> 
> Though it might go in anyway, since Eli likes it.

I'll do whichever gets the patch merged. While I personally find the 
no-op implementation for the default backend to be cleaner, doing it the 
other way doesn't bother me enough that I'll fight for it.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67062; Package emacs. Full text available.

Message received at 67062 <at> debbugs.gnu.org:


Received: (at 67062) by debbugs.gnu.org; 12 Nov 2023 22:14:50 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 12 17:14:50 2023
Received: from localhost ([127.0.0.1]:57202 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r2IjC-0003ST-26
	for submit <at> debbugs.gnu.org; Sun, 12 Nov 2023 17:14:50 -0500
Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]:47594)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jporterbugs@HIDDEN>) id 1r2Ij8-0003SF-Oa
 for 67062 <at> debbugs.gnu.org; Sun, 12 Nov 2023 17:14:48 -0500
Received: by mail-pj1-x102b.google.com with SMTP id
 98e67ed59e1d1-2809a824bbbso2830498a91.3
 for <67062 <at> debbugs.gnu.org>; Sun, 12 Nov 2023 14:14:05 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1699827240; x=1700432040; darn=debbugs.gnu.org;
 h=content-transfer-encoding:in-reply-to:from:references:cc:to
 :content-language:subject:mime-version:date:message-id:from:to:cc
 :subject:date:message-id:reply-to;
 bh=qcee174+0RibCUk//NPYG63Knux8Yl0Ut4F+pLPzZEY=;
 b=QXb0swh1XGsf5Hddwvvu8HOGPQL6rgQdNJLUNhL5d1FcNrXofJpoh5Py9z1juuAvr1
 1YFc+XLYIHrdrnGmNPCTLFZ62LQDO0+Wylsv8w8Ev9bfK2QjBg2FnJJSg+NRxlHWPTLK
 Kq5zU79BuU/FS1MK4xoyYzoiyYNAPtdXk8nf2NrZaZPQDYCGMuCGUUt0Geu1Yklglcab
 gDww5ytaoXmQ8VNgQ5orAuVMZ/7wTyIGQU+uZrw/VIo8e+k9NG+iZefZS77jOoXzQvBI
 2gGhiq3bsb8bZESJlBk65O+whUSvxoMQzW43dxUDWcOSKdOUC3IdtKo41XZVthItFKxi
 HDFg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1699827240; x=1700432040;
 h=content-transfer-encoding:in-reply-to:from:references:cc:to
 :content-language:subject:mime-version:date:message-id
 :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=qcee174+0RibCUk//NPYG63Knux8Yl0Ut4F+pLPzZEY=;
 b=RyHjKgqs+otkQDKQbIgHJJys1NU/x/lcJDISf7Fqf41CKJTYOSBx2EediaJC7fs/dG
 JTVE7423IfebIwZeqjSEUTLeOG+8zd98Wm1RHg2s9MAPP50cbwWkX5a6cmGVhVqiPgAi
 BXieZLQddNtmNBqXLb9u6K8VXmIkCmEa0lKK5porWI7ob+nbLdi5os3aIGWqgPf2O9Po
 VJjdrupf/YCG1T6FSqB1IuqaAZddqSzhZG4IjxMQ+DoHEMaXz24nlNcpGbeU+YOhZJqS
 tLLRW1IGQmCoae661X5m7Sw3TrodfgI23Dktl9WAGSTioU9b1H35uvMY1c7FcptYl98v
 YbWg==
X-Gm-Message-State: AOJu0YwE3rhXm4MGgX//hDNcN1O12C0zkUYRklBpi3TyF5vPpePifOrs
 OgpUPlxjFnQV4sU/e3il4s4=
X-Google-Smtp-Source: AGHT+IGDgxp3eYSkIlgKHSRGUYtbWBaZ+ATXPV0QNGxEr4j3ZlJ+jGwbc93bNnDVsOJc0GPMnLTncQ==
X-Received: by 2002:a17:90b:4a4a:b0:280:c98f:2092 with SMTP id
 lb10-20020a17090b4a4a00b00280c98f2092mr3355872pjb.33.1699827239695; 
 Sun, 12 Nov 2023 14:13:59 -0800 (PST)
Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com.
 [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id
 nm23-20020a17090b19d700b0028023d58874sm2722820pjb.1.2023.11.12.14.13.58
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 12 Nov 2023 14:13:59 -0800 (PST)
Message-ID: <2f7c9164-4a64-91c6-245e-61208de8560c@HIDDEN>
Date: Sun, 12 Nov 2023 14:13:58 -0800
MIME-Version: 1.0
Subject: Re: bug#67062: 30.0.50; [PATCH] Abbreviate the revision in
 'vc-annotate' (for Git)
Content-Language: en-US
To: Dmitry Gutov <dmitry@HIDDEN>, Juri Linkov <juri@HIDDEN>
References: <66fc4912-6aa5-79da-bd6f-52f068cf1a77@HIDDEN>
 <83y1f4wxby.fsf@HIDDEN> <2eb31324-ae24-db4b-4f62-a0140bfb9f81@HIDDEN>
 <83sf5bv77j.fsf@HIDDEN> <ea6fbea1-d918-f534-4dd3-ee29b631cc6d@HIDDEN>
 <83bkbzusri.fsf@HIDDEN> <ad938cf5-201a-79f0-2b29-c4e0db230f9f@HIDDEN>
 <86msvi95aw.fsf@HIDDEN>
 <8742d731-62ba-0808-bdc6-cbad1cf98116@HIDDEN>
From: Jim Porter <jporterbugs@HIDDEN>
In-Reply-To: <8742d731-62ba-0808-bdc6-cbad1cf98116@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 67062
Cc: Eli Zaretskii <eliz@HIDDEN>, 67062 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On 11/12/2023 12:37 PM, Dmitry Gutov wrote:
> On 12/11/2023 20:48, Juri Linkov wrote:
>> But maybe could add a new optional arg to vc-working-revision?
> 
> That's worse: we'll end up with a number-of-args migration, having to 
> use a condition-case form for a number of years. All for a new argument 
> that isn't used by the majority of the backends.

Also, it wouldn't work for what we want to do: REV in 'vc-annotate' 
isn't necessarily the current revision; it could be any revision. We 
just want to take that revision and turn it into a friendlier (read: 
shorter) form for the buffer name.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67062; Package emacs. Full text available.

Message received at 67062 <at> debbugs.gnu.org:


Received: (at 67062) by debbugs.gnu.org; 12 Nov 2023 20:38:35 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 12 15:38:35 2023
Received: from localhost ([127.0.0.1]:57096 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r2HE2-0000oC-O9
	for submit <at> debbugs.gnu.org; Sun, 12 Nov 2023 15:38:35 -0500
Received: from out4-smtp.messagingengine.com ([66.111.4.28]:32981)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dmitry@HIDDEN>) id 1r2HE0-0000nw-6q
 for 67062 <at> debbugs.gnu.org; Sun, 12 Nov 2023 15:38:32 -0500
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43])
 by mailout.nyi.internal (Postfix) with ESMTP id E8F925C036A;
 Sun, 12 Nov 2023 15:37:45 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute3.internal (MEProxy); Sun, 12 Nov 2023 15:37:45 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc
 :cc:content-transfer-encoding:content-type:content-type:date
 :date:from:from:in-reply-to:in-reply-to:message-id:mime-version
 :references:reply-to:sender:subject:subject:to:to; s=fm2; t=
 1699821465; x=1699907865; bh=oymgGVnpNPVq+8T4VK0KObB5bC/vWGIwXsu
 1TEXn5Yk=; b=l4BUC8969U43AaP0oKUYuWK4yyla1J18trz0D1wexfThJW0al6z
 SlxtTIRJ2lmxEnGQ0RqSlEGdO5Cc2DN+23/BHGuh5kMFVrBgKGFX9jCAAYH1Oysn
 QyRVmARWfHX7nmpjo6YMuSbRghyeFImqn3jMCZjjxun7Gu/7T3oWuOcbtdt/aIdI
 C4Yp+Yje7FkqTUp9TR8PDSGnP8nj51ICcpVAmWPx4IgYEaDbGS8G2RrvDTxomvEW
 I/vC9g67y2CAFdcZTRjouh/usXKEYRrA0GZ9ZUFrKRJ4dD4TsrL1VgbLIQwf4X/B
 aNWjqqOc3N7AuoDlLJSEod+6R5wpGWDNptA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-transfer-encoding
 :content-type:content-type:date:date:feedback-id:feedback-id
 :from:from:in-reply-to:in-reply-to:message-id:mime-version
 :references:reply-to:sender:subject:subject:to:to:x-me-proxy
 :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=
 1699821465; x=1699907865; bh=oymgGVnpNPVq+8T4VK0KObB5bC/vWGIwXsu
 1TEXn5Yk=; b=eSl2arbIlKtw1PNwr99xM6HrpzzwG/9TzKzvLvDDZ8y9VZ99nyS
 vOn+Hy2UHUQqtKI0PIl7zdb6C6BEnwW5rzc2+Uu4lYpXRqL9thbsbESxj5t9cBrB
 3vDqCoqjZf58bTpc659hOhRkoNU42ho0gZPTwVpkZrytadIzEWEuXf+g/Bs+P7O/
 +FTiNJUPGeRU5LQUFekUTOm/CNQg+mCY3it8mWNuI0xrBHdUUsSXJ4Cfz9BUt2XM
 pxYb1hIFtO0JVOqQN7mPhCBGRQRJ50Li6zIN9auG/Vferu69tYLoRm3sCPRV3TD0
 2gPGpd5Jv7+0W4Y3b0eQR1YGzPDmjjiizMg==
X-ME-Sender: <xms:mTdRZSzUDvRyOlvR3CdB50fgJFgRB8kf8H4pPaYsqLDz0N19Xkyp4w>
 <xme:mTdRZeT6dUWHI2LJIBtr9F9dWcN7tn0Xr5xtEV0Esln-moKoESZR8raDYTuCLclry
 C2gD3wOOEMk38JnFgA>
X-ME-Received: <xmr:mTdRZUUDNYxBXBU1qtDtWFBnphFinr3miAqD31-AvMCqEMN2fSlk9lfAN7yzHAc>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedruddvkedgudegvdcutefuodetggdotefrod
 ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
 necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
 enucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomhepffhm
 ihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrg
 htthgvrhhnpeeigfetveehveevffehledtueekieeikeeufeegudfgfeeghfdulefgfeev
 ledvveenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe
 gumhhithhrhiesghhuthhovhdruggvvh
X-ME-Proxy: <xmx:mTdRZYjOAXIatseocxoJYVqxZ9iVAZp5UnMIut4YKpedDHoEMQOz-w>
 <xmx:mTdRZUDk9rsU9atrHiWQ2M8hOIg9Id43WUc9F-eI_hrLg6FnoNM91Q>
 <xmx:mTdRZZJLF0VWvHztMl6PPrueo0o_KvLwafdvq643pBO4_AXTuP146A>
 <xmx:mTdRZXM5ogx_-7Q17nnZOXsHH7r04UepXJFKiqEP7QztAgqqu4aqtw>
Feedback-ID: i0e71465a:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun,
 12 Nov 2023 15:37:44 -0500 (EST)
Message-ID: <8742d731-62ba-0808-bdc6-cbad1cf98116@HIDDEN>
Date: Sun, 12 Nov 2023 22:37:42 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: bug#67062: 30.0.50; [PATCH] Abbreviate the revision in
 'vc-annotate' (for Git)
Content-Language: en-US
To: Juri Linkov <juri@HIDDEN>
References: <66fc4912-6aa5-79da-bd6f-52f068cf1a77@HIDDEN>
 <83y1f4wxby.fsf@HIDDEN> <2eb31324-ae24-db4b-4f62-a0140bfb9f81@HIDDEN>
 <83sf5bv77j.fsf@HIDDEN> <ea6fbea1-d918-f534-4dd3-ee29b631cc6d@HIDDEN>
 <83bkbzusri.fsf@HIDDEN> <ad938cf5-201a-79f0-2b29-c4e0db230f9f@HIDDEN>
 <86msvi95aw.fsf@HIDDEN>
From: Dmitry Gutov <dmitry@HIDDEN>
In-Reply-To: <86msvi95aw.fsf@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: -2.2 (--)
X-Debbugs-Envelope-To: 67062
Cc: jporterbugs@HIDDEN, Eli Zaretskii <eliz@HIDDEN>, 67062 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.2 (---)

On 12/11/2023 20:48, Juri Linkov wrote:
>>> no, vc-annotate will call a new function, which will have a special
>>> code for Git alone.
>> That's one extra indirection, but conceptually the same. We couldn't modify
>> vc-working-revision for this, so it'll have to be a new function.
> But maybe could add a new optional arg to vc-working-revision?

That's worse: we'll end up with a number-of-args migration, having to 
use a condition-case form for a number of years. All for a new argument 
that isn't used by the majority of the backends.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67062; Package emacs. Full text available.

Message received at 67062 <at> debbugs.gnu.org:


Received: (at 67062) by debbugs.gnu.org; 12 Nov 2023 20:36:09 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 12 15:36:09 2023
Received: from localhost ([127.0.0.1]:57091 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r2HBh-0000iK-9R
	for submit <at> debbugs.gnu.org; Sun, 12 Nov 2023 15:36:09 -0500
Received: from out4-smtp.messagingengine.com ([66.111.4.28]:50171)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dmitry@HIDDEN>) id 1r2HBe-0000hd-Ro
 for 67062 <at> debbugs.gnu.org; Sun, 12 Nov 2023 15:36:07 -0500
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
 by mailout.nyi.internal (Postfix) with ESMTP id 83EA45C036A;
 Sun, 12 Nov 2023 15:35:19 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute2.internal (MEProxy); Sun, 12 Nov 2023 15:35:19 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc
 :cc:content-transfer-encoding:content-type:content-type:date
 :date:from:from:in-reply-to:in-reply-to:message-id:mime-version
 :references:reply-to:sender:subject:subject:to:to; s=fm2; t=
 1699821319; x=1699907719; bh=2N+9JC6zjVl8Kri4jH5pUggUt8gxz7JjnUG
 71rdpAGM=; b=S6IxvW0HmE2GppcQYgr7nBQQxt/Kh76mYdJneYBe+uTFHxLUf2A
 cI1ifvgJPa97Wx5fotwK6sL9KlUqv+i3qmCICjc/c87V9xYWuwPkMvrH0NFCHFMk
 T/PfALNI5MGyV6gLt19E5p+uOMJRQ1tpw+BqC2mfSoDJHhGJsL4pOe8PFU2kKQV3
 J4VfFwVr5UftzOrjW77y4Mo/4aeKUhP1DWCdoNeoetHUOxXR6lrQ5QzXIzOramlj
 VqjehgkKwJTXvyHPCkIXb/3ehVL4O/nAQik0fSqpnp7xJHQsOh82LfpCZLG4p9pP
 W8B5p3Dxpuamg845J19PL5YuiRfQYEo0JDQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-transfer-encoding
 :content-type:content-type:date:date:feedback-id:feedback-id
 :from:from:in-reply-to:in-reply-to:message-id:mime-version
 :references:reply-to:sender:subject:subject:to:to:x-me-proxy
 :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=
 1699821319; x=1699907719; bh=2N+9JC6zjVl8Kri4jH5pUggUt8gxz7JjnUG
 71rdpAGM=; b=XIJWCNHkpJceUaDHQS+MbYaDHgE7IsLO4PfD+x1SDpkCTdNqZ4G
 izHfNt+UHrVIKEi4et0W+G47ar1njI49USsdNf7KZJ8VXhubRiFBG9e1V//JtGFX
 DLaLXshyzYD+DdxZkCA9d7SMDnpWcHBxUEcABzXg7KoslEw2QEu+tSvpZYuV3Er/
 U4lr/fxJAtkVCvfASp+9ocSECHq6GCrTiKPMvxTSwqR6wfvyDxJwAzlWmji1FzWk
 NzA/3HsHABYPUAKsTGEAXXlwgHioGIs6YobeKf/KXcoGtmaXoGu7aw7NOmff+3DI
 JaCqiqFsNITcsovwbYbvnkCcNT2YB4YHk0g==
X-ME-Sender: <xms:BzdRZe4PdNJgHFc0vF5jKsTSoJshcfC5G9G5IIPSEhf5k1EADlBAYw>
 <xme:BzdRZX64GD0rt8QXkQxnWD--588u8hFOMWfJyovqgrUkXf1DmIQ3In6gfBdXEHvet
 BCm_hyDCKfendeaMZg>
X-ME-Received: <xmr:BzdRZdcZ0IhrotROyVtF5KLj1QZxBJnZ3ktvYjA2T6O2ODfiyGVZJ5VqUN9LXuM>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedruddvkedgudegudcutefuodetggdotefrod
 ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
 necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
 enucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomhepffhm
 ihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrg
 htthgvrhhnpeeigfetveehveevffehledtueekieeikeeufeegudfgfeeghfdulefgfeev
 ledvveenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe
 gumhhithhrhiesghhuthhovhdruggvvh
X-ME-Proxy: <xmx:BzdRZbKW6cA7cEfEX3lK8SAzTZV4ykMIp3vEoOwQEQvy6VC7ykhHpg>
 <xmx:BzdRZSLaNIUt4MkqbEXvuyPusPeTr-1DXUCuxmf9ZbyYiCXO-gYPQQ>
 <xmx:BzdRZcwIukeNWqvwiQgww1S9sdgFIE8OlJI9l-HoOcE3_ON7Th--Sw>
 <xmx:BzdRZUgGxmNKysJXssXYLeUPGkueyOxZMKm4eqHIJMdMTDDu4LSgDQ>
Feedback-ID: i0e71465a:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun,
 12 Nov 2023 15:35:18 -0500 (EST)
Message-ID: <894ab706-20ff-8773-be39-9d4a3c924872@HIDDEN>
Date: Sun, 12 Nov 2023 22:35:15 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: bug#67062: 30.0.50; [PATCH] Abbreviate the revision in
 'vc-annotate' (for Git)
Content-Language: en-US
To: Jim Porter <jporterbugs@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>
References: <66fc4912-6aa5-79da-bd6f-52f068cf1a77@HIDDEN>
 <83y1f4wxby.fsf@HIDDEN> <2eb31324-ae24-db4b-4f62-a0140bfb9f81@HIDDEN>
 <83sf5bv77j.fsf@HIDDEN> <399f2f1e-7c1f-e272-2a9d-4e36e8d8666b@HIDDEN>
From: Dmitry Gutov <dmitry@HIDDEN>
In-Reply-To: <399f2f1e-7c1f-e272-2a9d-4e36e8d8666b@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: -2.2 (--)
X-Debbugs-Envelope-To: 67062
Cc: 67062 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.2 (---)

On 12/11/2023 21:07, Jim Porter wrote:
> In any case, we don't necessarily need to provide a default 
> implementation for the 'short-revision' function. What about something 
> like this? I'm not sure it's better, but it does let us avoid defining a 
> no-op implementation for the "default backend".

Looks worse to me than having the default "identity" implementation.

Sorry.

Though it might go in anyway, since Eli likes it.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67062; Package emacs. Full text available.

Message received at 67062 <at> debbugs.gnu.org:


Received: (at 67062) by debbugs.gnu.org; 12 Nov 2023 19:34:24 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 12 14:34:24 2023
Received: from localhost ([127.0.0.1]:57043 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r2GDw-0007NB-0H
	for submit <at> debbugs.gnu.org; Sun, 12 Nov 2023 14:34:24 -0500
Received: from mail-oi1-x22d.google.com ([2607:f8b0:4864:20::22d]:61771)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jporterbugs@HIDDEN>) id 1r2GDt-0007My-Va
 for 67062 <at> debbugs.gnu.org; Sun, 12 Nov 2023 14:34:22 -0500
Received: by mail-oi1-x22d.google.com with SMTP id
 5614622812f47-3b2ec5ee2e4so2441791b6e.3
 for <67062 <at> debbugs.gnu.org>; Sun, 12 Nov 2023 11:33:40 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1699817615; x=1700422415; darn=debbugs.gnu.org;
 h=in-reply-to:from:references:cc:to:content-language:subject
 :mime-version:date:message-id:from:to:cc:subject:date:message-id
 :reply-to; bh=Prp4E/P1infk5fStKRaGYzQKpVlilvqpfDCm+HiF9VY=;
 b=eH4633lycxZCloMxb7xTajOsRInrRv8/D4ffBpnwhya+tTxkeq4VSs24NbYoi2vQNH
 aSqusNXJ25LOVL6sWq0FwJNxzexsTa7aRBYjIuMg1oRl0+ypVsBlL18pmr+p1ZzxYJ7t
 A0/oXmoZw2d/O2qfz6ecqixt5q1Ibs2P4Vr/9GDzQITSP5qGbMtF9T6ANMwJ2phUiJAP
 ErQNFILrC/XqjGkbYML35cLX7HSerqOqdo08Le3NxICRfBQft9dbL1SV5KmL19BA52LH
 3ywHx7A+fCSwc2aawQ99/4pp2CcRhbnd9aAUNDBiqnYdlefZl1jLFePYZpoEJg7Sbi03
 BQeg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1699817615; x=1700422415;
 h=in-reply-to:from:references:cc:to:content-language:subject
 :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject
 :date:message-id:reply-to;
 bh=Prp4E/P1infk5fStKRaGYzQKpVlilvqpfDCm+HiF9VY=;
 b=jfxtWuFb1IevZZ0syE4Ra6j5RfITse9xrBEFDWFZ8171mI7Fg/QUJlLE75tYD06Ypp
 j/1c+upj+30xyxH2oxqF8eYhGnMoP6mEIRylfcgA8BSdZ6pv4bnX6uOfRo0qz/IFpNiW
 iZhaHyUEGPg2coWeMnae03gTp18Eb63Gx34k9ESp5Y0bOJ+ZROudQCQjRufWmWlGX67k
 5MlyEJHvo9jVH6Bm7XzqcjvoUMhEQtMUTjlfcZG1aLckp0wVClK3gHoQyOm+IueidRWL
 sVlQenffzT5B21lOJ52Ffpx2EulXitTYLVirUK+KxNRoIyU5oO8+h5wAsgsp9/ZpnbiY
 u47g==
X-Gm-Message-State: AOJu0Ywt9mllGPiOiDEYb0S/ePJ0vGTWn3xV7GT4t48mBaglFRJRZQDV
 oGlR8p+VOY7lHnEwiVzZ8kk=
X-Google-Smtp-Source: AGHT+IH/4n4afHYR5y15gnE8JKLCrq9JJx2TmwsrIWzZdXLGBNAuMIyePx9WVGrwwzJU1B6vu1Js/w==
X-Received: by 2002:a05:6870:b48e:b0:1e9:9180:6f60 with SMTP id
 y14-20020a056870b48e00b001e991806f60mr6645698oap.23.1699817614919; 
 Sun, 12 Nov 2023 11:33:34 -0800 (PST)
Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com.
 [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id
 29-20020a17090a005d00b0027d0af2e9c3sm5062070pjb.40.2023.11.12.11.33.33
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 12 Nov 2023 11:33:34 -0800 (PST)
Content-Type: multipart/mixed; boundary="------------m5emtLkPTcR2Mwdcp8nCjVjK"
Message-ID: <6335942d-b12b-1cdc-028f-d26722ea0d37@HIDDEN>
Date: Sun, 12 Nov 2023 11:33:33 -0800
MIME-Version: 1.0
Subject: Re: bug#67062: 30.0.50; [PATCH] Abbreviate the revision in
 'vc-annotate' (for Git)
Content-Language: en-US
To: Eli Zaretskii <eliz@HIDDEN>
References: <66fc4912-6aa5-79da-bd6f-52f068cf1a77@HIDDEN>
 <83y1f4wxby.fsf@HIDDEN> <2eb31324-ae24-db4b-4f62-a0140bfb9f81@HIDDEN>
 <83sf5bv77j.fsf@HIDDEN> <399f2f1e-7c1f-e272-2a9d-4e36e8d8666b@HIDDEN>
 <83zfziu6ra.fsf@HIDDEN>
From: Jim Porter <jporterbugs@HIDDEN>
In-Reply-To: <83zfziu6ra.fsf@HIDDEN>
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 67062
Cc: dmitry@HIDDEN, 67062 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

This is a multi-part message in MIME format.
--------------m5emtLkPTcR2Mwdcp8nCjVjK
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 11/12/2023 11:11 AM, Eli Zaretskii wrote:
>> Date: Sun, 12 Nov 2023 11:07:38 -0800
>> Cc: 67062 <at> debbugs.gnu.org
>> From: Jim Porter <jporterbugs@HIDDEN>
>>
>> In any case, we don't necessarily need to provide a default
>> implementation for the 'short-revision' function. What about something
>> like this? I'm not sure it's better, but it does let us avoid defining a
>> no-op implementation for the "default backend".
> 
> Fine by me, except that I think this should be optional behavior.

Ok, how about this? If you think I should add a bit about this to the 
manual, let me know. However, it seems like a fairly minor thing to me, 
and I don't want to distract the manual reader from the more-useful parts.

(I also welcome a suggestion on a shorter name than 
'vc-annotate-abbreviate-revision-in-buffer-name', but I wanted to be 
careful not to give the impression that this would apply to the revision 
IDs that you see in the VC-Annotate buffer's *contents*. I guess I could 
abbreviate some of the existing words though, like "revision" -> "rev".)
--------------m5emtLkPTcR2Mwdcp8nCjVjK
Content-Type: text/plain; charset=UTF-8;
 name="0001-Abbreviate-the-VC-revision-in-vc-annotate-s-buffer-n.patch"
Content-Disposition: attachment;
 filename*0="0001-Abbreviate-the-VC-revision-in-vc-annotate-s-buffer-n.pa";
 filename*1="tch"
Content-Transfer-Encoding: base64

RnJvbSA5NzI2ZTFhY2I3MGQ3ZDAyNjQ4NjY1Y2MyNTllMTc0NjcwY2E4MzlmIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j
b20+CkRhdGU6IEZyaSwgMTAgTm92IDIwMjMgMTg6NDI6MjkgLTA4MDAKU3ViamVjdDogW1BB
VENIXSBBYmJyZXZpYXRlIHRoZSBWQyByZXZpc2lvbiBpbiB2Yy1hbm5vdGF0ZSdzIGJ1ZmZl
ciBuYW1lCgoqIGxpc3AvdmMvdmMtYW5ub3RhdGUuZWwKKHZjLWFubm90YXRlLWFiYnJldmlh
dGUtcmV2aXNpb24taW4tYnVmZmVyLW5hbWUpOiBOZXcgb3B0aW9uLi4uCih2Yy1hbm5vdGF0
ZSk6IC4uLiB1c2UgaXQsIGFuZCB0cnkgdG8gY2FsbCAnc2hvcnQtcmV2aXNpb24nIHdoZW4K
cmVxdWVzdGVkLgoKKiBsaXNwL3ZjL3ZjLWdpdC5lbCAodmMtZ2l0LXNob3J0LXJldmlzaW9u
KTogTmV3IGZ1bmN0aW9uLgoodmMtZ2l0LS1yZXYtcGFyc2UpOiBOZXcgb3B0aW9uYWwgYXJn
dW1lbnQgU0hPUlQuCgoqIGV0Yy9ORVdTOiBBbm5vdW5jZSB0aGlzIGNoYW5nZSAoYnVnIzY3
MDYyKS4KLS0tCiBldGMvTkVXUyAgICAgICAgICAgICAgIHwgIDcgKysrKysrKwogbGlzcC92
Yy92Yy1hbm5vdGF0ZS5lbCB8IDEzICsrKysrKysrKysrKy0KIGxpc3AvdmMvdmMtZ2l0LmVs
ICAgICAgfCAxNCArKysrKysrKysrKy0tLQogMyBmaWxlcyBjaGFuZ2VkLCAzMCBpbnNlcnRp
b25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2V0Yy9ORVdTIGIvZXRjL05F
V1MKaW5kZXggNzY3ZTRjMjdiNDMuLmRmMTE3NTdlMThkIDEwMDY0NAotLS0gYS9ldGMvTkVX
UworKysgYi9ldGMvTkVXUwpAQCAtMzk2LDYgKzM5NiwxMyBAQCBzd2l0Y2hlcyBmb3Igc2hv
cnRsb2dzLCBzdWNoIGFzIHRoZSBvbmUgcHJvZHVjZWQgYnkgJ0MteCB2IEwnLgogKioqIE9i
c29sZXRlIGNvbW1hbmQgJ3ZjLXN3aXRjaC1iYWNrZW5kJyByZS1hZGRlZCBhcyAndmMtY2hh
bmdlLWJhY2tlbmQnLgogVGhlIGNvbW1hbmQgd2FzIHByZXZpb3VzbHkgb2Jzb2xldGVkIGFu
ZCB1bmJvdW5kIGluIEVtYWNzIDI4LgogCistLS0KKyoqKiAndmMtYW5ub3RhdGUnIGNhbiBu
b3cgYWJicmV2aWF0ZSB0aGUgcmV2aXNpb24gaW4gdGhlIGJ1ZmZlciBuYW1lLgorV2hlbiB0
aGUgb3B0aW9uICd2Yy1hbm5vdGF0ZS1hYmJyZXZpYXRlLXJldmlzaW9uLWluLWJ1ZmZlci1u
YW1lJyBpcworbm9uLW5pbCAodGhlIGRlZmF1bHQpLCAndmMtYW5ub3RhdGUnIHdpbGwgdXNl
IGFuIGFiYnJldmlhdGVkIHJldmlzaW9uCitpbiBpdHMgYnVmZmVyIG5hbWUgaWYgdGhlIFZD
IGJhY2tlbmQgaGFzIGEgJ3ZjLUJBQ0tFTkQtc2hvcnQtcmV2aXNpb24nCitmdW5jdGlvbi4K
KwogKiogRGlmZiBtb2RlCiAKICsrKwpkaWZmIC0tZ2l0IGEvbGlzcC92Yy92Yy1hbm5vdGF0
ZS5lbCBiL2xpc3AvdmMvdmMtYW5ub3RhdGUuZWwKaW5kZXggZGU2YzNhZGJiZGIuLmNhY2Yw
NWRiNmQ5IDEwMDY0NAotLS0gYS9saXNwL3ZjL3ZjLWFubm90YXRlLmVsCisrKyBiL2xpc3Av
dmMvdmMtYW5ub3RhdGUuZWwKQEAgLTE2Miw2ICsxNjIsMTEgQEAgdmMtYW5ub3RhdGUtbWVu
dS1lbGVtZW50cwogICA6dHlwZSAnKHJlcGVhdCBudW1iZXIpCiAgIDpncm91cCAndmMpCiAK
KyhkZWZjdXN0b20gdmMtYW5ub3RhdGUtYWJicmV2aWF0ZS1yZXZpc2lvbi1pbi1idWZmZXIt
bmFtZSB0CisgICJJZiBub24tbmlsLCBcXFt2Yy1hbm5vdGF0ZV0gd2lsbCB1c2Ugc2hvcnQg
cmV2aXNpb25zIGluIGl0cyBidWZmZXIgbmFtZS4iCisgIDp0eXBlICdib29sZWFuCisgIDpn
cm91cCAndmMpCisKIChkZWZ2YXIta2V5bWFwIHZjLWFubm90YXRlLW1vZGUtbWFwCiAgIDpk
b2MgIkxvY2FsIGtleW1hcCB1c2VkIGZvciBWQy1Bbm5vdGF0ZSBtb2RlLiIKICAgImEiICAg
Iyd2Yy1hbm5vdGF0ZS1yZXZpc2lvbi1wcmV2aW91cy10by1saW5lCkBAIC00MDksNyArNDE0
LDEzIEBAIHZjLWFubm90YXRlCiAJCQkJICBuaWwgbmlsICIyMCIpKSkpKSkpCiAgICh2Yy1l
bnN1cmUtdmMtYnVmZmVyKQogICAoc2V0cSB2Yy1hbm5vdGF0ZS1kaXNwbGF5LW1vZGUgZGlz
cGxheS1tb2RlKSA7Tm90IHN1cmUgd2h5LiAgLS1TdGVmCi0gIChsZXQqICgodGVtcC1idWZm
ZXItbmFtZSAoZm9ybWF0ICIqQW5ub3RhdGUgJXMgKHJldiAlcykqIiAoYnVmZmVyLW5hbWUp
IHJldikpCisgIChsZXQqICgoZGlzcGxheWVkLXJldgorICAgICAgICAgIChvciAoYW5kIHZj
LWFubm90YXRlLWFiYnJldmlhdGUtcmV2aXNpb24taW4tYnVmZmVyLW5hbWUKKyAgICAgICAg
ICAgICAgICAgICAoaWdub3JlLWVycm9ycyAodmMtY2FsbC1iYWNrZW5kICh2Yy1iYWNrZW5k
IGZpbGUpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAnc2hvcnQtcmV2aXNpb24gcmV2KSkpCisgICAgICAgICAgICAgIHJldikpCisgICAg
ICAgICAodGVtcC1idWZmZXItbmFtZSAoZm9ybWF0ICIqQW5ub3RhdGUgJXMgKHJldiAlcykq
IiAoYnVmZmVyLW5hbWUpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRp
c3BsYXllZC1yZXYpKQogICAgICAgICAgKHRlbXAtYnVmZmVyLXNob3ctZnVuY3Rpb24gJ3Zj
LWFubm90YXRlLWRpc3BsYXktc2VsZWN0KQogICAgICAgICAgOzsgSWYgQlVGIGlzIHNwZWNp
ZmllZCwgd2UgcHJlc3VtZSB0aGUgY2FsbGVyIG1haW50YWlucyBjdXJyZW50IGxpbmUsCiAg
ICAgICAgICA7OyBzbyB3ZSBkb24ndCBuZWVkIHRvIGRvIGl0IGhlcmUuICBUaGlzIGltcGxl
bWVudGF0aW9uIG1heSBnaXZlCmRpZmYgLS1naXQgYS9saXNwL3ZjL3ZjLWdpdC5lbCBiL2xp
c3AvdmMvdmMtZ2l0LmVsCmluZGV4IDcwN2ZjN2NmYzA3Li4wNTIxNjcwMWZhOSAxMDA2NDQK
LS0tIGEvbGlzcC92Yy92Yy1naXQuZWwKKysrIGIvbGlzcC92Yy92Yy1naXQuZWwKQEAgLTQw
Myw2ICs0MDMsMTEgQEAgdmMtZ2l0LXdvcmtpbmctcmV2aXNpb24KICAgKGxldCAocHJvY2Vz
cy1maWxlLXNpZGUtZWZmZWN0cykKICAgICAodmMtZ2l0LS1yZXYtcGFyc2UgIkhFQUQiKSkp
CiAKKyhkZWZ1biB2Yy1naXQtc2hvcnQtcmV2aXNpb24gKHJldikKKyAgIlJldHVybiBhbiBh
YmJyZXZpYXRlZCB2ZXJzaW9uIG9mIHRoZSByZXZpc2lvbiBSRVYuIgorICAobGV0IChwcm9j
ZXNzLWZpbGUtc2lkZS1lZmZlY3RzKQorICAgICh2Yy1naXQtLXJldi1wYXJzZSByZXYgJ3No
b3J0KSkpCisKIChkZWZ1biB2Yy1naXQtLXN5bWJvbGljLXJlZiAoZmlsZSkKICAgKG9yCiAg
ICAodmMtZmlsZS1nZXRwcm9wIGZpbGUgJ3ZjLWdpdC1zeW1ib2xpYy1yZWYpCkBAIC0xODMw
LDExICsxODM1LDE0IEBAIHZjLWdpdC1wcmV2aW91cy1yZXZpc2lvbgogICAgIDs7IGRvZXMg
bm90IChhbmQgY2Fubm90KSBxdW90ZS4KICAgICAodmMtZ2l0LS1yZXYtcGFyc2UgKGNvbmNh
dCByZXYgIn4xIikpKSkKIAotKGRlZnVuIHZjLWdpdC0tcmV2LXBhcnNlIChyZXYpCisoZGVm
dW4gdmMtZ2l0LS1yZXYtcGFyc2UgKHJldiAmb3B0aW9uYWwgc2hvcnQpCiAgICh3aXRoLXRl
bXAtYnVmZmVyCiAgICAgKGFuZAotICAgICAodmMtZ2l0LS1vdXQtb2sgInJldi1wYXJzZSIg
cmV2KQotICAgICAoYnVmZmVyLXN1YnN0cmluZy1uby1wcm9wZXJ0aWVzIChwb2ludC1taW4p
ICgrIChwb2ludC1taW4pIDQwKSkpKSkKKyAgICAgKGFwcGx5ICMndmMtZ2l0LS1vdXQtb2sg
InJldi1wYXJzZSIKKyAgICAgICAgICAgIChhcHBlbmQgKHdoZW4gc2hvcnQgJygiLS1zaG9y
dCIpKQorICAgICAgICAgICAgICAgICAgICAobGlzdCByZXYpKSkKKyAgICAgKGdvdG8tY2hh
ciAocG9pbnQtbWluKSkKKyAgICAgKGJ1ZmZlci1zdWJzdHJpbmctbm8tcHJvcGVydGllcyAo
cG9pbnQpIChwb3MtZW9sKSkpKSkKIAogKGRlZnVuIHZjLWdpdC1uZXh0LXJldmlzaW9uIChm
aWxlIHJldikKICAgIkdpdC1zcGVjaWZpYyB2ZXJzaW9uIG9mIGB2Yy1uZXh0LXJldmlzaW9u
Jy4iCi0tIAoyLjI1LjEKCg==

--------------m5emtLkPTcR2Mwdcp8nCjVjK--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67062; Package emacs. Full text available.

Message received at 67062 <at> debbugs.gnu.org:


Received: (at 67062) by debbugs.gnu.org; 12 Nov 2023 19:12:12 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 12 14:12:12 2023
Received: from localhost ([127.0.0.1]:57021 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r2FsR-0006pi-Tn
	for submit <at> debbugs.gnu.org; Sun, 12 Nov 2023 14:12:12 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:56164)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1r2FsP-0006pV-W8
 for 67062 <at> debbugs.gnu.org; Sun, 12 Nov 2023 14:12:10 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1r2Frf-0000Xp-G1; Sun, 12 Nov 2023 14:11:23 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=C9yJiumuQeFkYhRSSVTHF7l13jPVBVe4YnLS/LfTYB4=; b=o/gQxBsinBe9
 lXCmwaB5PjsgXu760+iFnmNg1ktlb0iojBBnRxhMECa+Vx2yNer4XLGIWWilnugU2EL61krbvmaRr
 6Qe75Inw4JGEoqtnqr34t0kEls/VyS5O6OlXn3uR9mH+9JOirHfhJH3Arsp5ONVNMNkIvfvXsanmM
 9T88wFkB1flBOww7E3fI4AXwG3+HTZV+fOclNWXgAa7tvftXg/k6+VO09aK9rGGWjmGv9YUpd5oTu
 IHZp85DYvAXN/3VpM50DZmFcA4AtcKdJTk0VFrzQBDfv0lo02PlVZApYUj+nTz3qArzAKK3FGCpdY
 hmHh/1K+afHTMsMpUNMSyQ==;
Date: Sun, 12 Nov 2023 21:11:05 +0200
Message-Id: <83zfziu6ra.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Jim Porter <jporterbugs@HIDDEN>
In-Reply-To: <399f2f1e-7c1f-e272-2a9d-4e36e8d8666b@HIDDEN> (message from
 Jim Porter on Sun, 12 Nov 2023 11:07:38 -0800)
Subject: Re: bug#67062: 30.0.50; [PATCH] Abbreviate the revision in
 'vc-annotate' (for Git)
References: <66fc4912-6aa5-79da-bd6f-52f068cf1a77@HIDDEN>
 <83y1f4wxby.fsf@HIDDEN> <2eb31324-ae24-db4b-4f62-a0140bfb9f81@HIDDEN>
 <83sf5bv77j.fsf@HIDDEN> <399f2f1e-7c1f-e272-2a9d-4e36e8d8666b@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 67062
Cc: dmitry@HIDDEN, 67062 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Sun, 12 Nov 2023 11:07:38 -0800
> Cc: 67062 <at> debbugs.gnu.org
> From: Jim Porter <jporterbugs@HIDDEN>
> 
> In any case, we don't necessarily need to provide a default 
> implementation for the 'short-revision' function. What about something 
> like this? I'm not sure it's better, but it does let us avoid defining a 
> no-op implementation for the "default backend".

Fine by me, except that I think this should be optional behavior.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67062; Package emacs. Full text available.

Message received at 67062 <at> debbugs.gnu.org:


Received: (at 67062) by debbugs.gnu.org; 12 Nov 2023 19:08:34 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 12 14:08:34 2023
Received: from localhost ([127.0.0.1]:57015 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r2Fow-0006jW-1K
	for submit <at> debbugs.gnu.org; Sun, 12 Nov 2023 14:08:34 -0500
Received: from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433]:61897)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jporterbugs@HIDDEN>) id 1r2Foq-0006jF-DB
 for 67062 <at> debbugs.gnu.org; Sun, 12 Nov 2023 14:08:32 -0500
Received: by mail-pf1-x433.google.com with SMTP id
 d2e1a72fcca58-6c34e87b571so2996670b3a.3
 for <67062 <at> debbugs.gnu.org>; Sun, 12 Nov 2023 11:07:47 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1699816061; x=1700420861; darn=debbugs.gnu.org;
 h=in-reply-to:from:content-language:references:cc:to:subject
 :mime-version:date:message-id:from:to:cc:subject:date:message-id
 :reply-to; bh=GsNMgu7GpuCTiy3+GTMqoJ+Zrry+StWm38MQUxhECUc=;
 b=O8aB5kYSKY/UDiTjqHMeLljGDFm856sBYywBTgx2GeyHNnSCUm1rzpwIBejGdYoIoN
 PLYSIm6pjbtUQzOSEH/0AqQwMtTPoySJV4Cz2jrvNMA50vwuvMNoW1XXwovW8FYLyh/l
 gEf31K/hfBib2hnh86F/oQfc/rzztFkvNNDYv6QNl9V9XD8GDgFmAJo9LMgQMNBKhFEW
 F13bV4cH3Rl6/Jt7+njPExT4TxDEF5Q9ZV/XrSL7SWVkr3PTlmJloUOdu5awe81hDZcY
 gBthckWeUp6rKNlHhqm2N+VA0cQvz+HfsOrnLUzJ0boJqpGsNi8ElvBLyVU71exaIWG0
 /+IQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1699816061; x=1700420861;
 h=in-reply-to:from:content-language:references:cc:to:subject
 :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject
 :date:message-id:reply-to;
 bh=GsNMgu7GpuCTiy3+GTMqoJ+Zrry+StWm38MQUxhECUc=;
 b=udf2LRRYOzJ9gmfsna3SW1WxZsFmHWCUxjpkvvWyUXMqKACG+lFDop+ItVM2BpZmSB
 Wx+SPIJo/GlSrsE1JL8J/mLc0yZlY2AZLyYB/FNZhlHwkz+Qymk10NDYDOkRVUqhOEaQ
 h3YWFPpRqbARs+MESQLkEJ9dkkUT+N6Yr8W07Fx3CRPjVXKO1Y51eo2GtpvARChn8TM5
 Bafue7RQqEA7Qh9KrMDEfJoDyEy1C6SeCTfS+JcOv1iiaPsMGniMbQLJerCjBZPvQUng
 zA9iw1vEmyFOg1doies+uvAc/lOQwCnAMRKF/gZEPPI0R3JyUW+jQdcfybLcET+S7/C1
 YIzQ==
X-Gm-Message-State: AOJu0YwhUls6UHssnawamcEU8OELrUp4T/+MqpBSJOCfXXH4f2j9ogkt
 YP8ItDlxp2vipnTA/2Cojo0=
X-Google-Smtp-Source: AGHT+IHzc0bUX1UXA6OBP49JeBsvYPjoE0+TqHEugluSSXmCEpdi3dj6RMO6LuJSf+EOEXnJEwFyTQ==
X-Received: by 2002:a17:902:dac8:b0:1cc:5691:5112 with SMTP id
 q8-20020a170902dac800b001cc56915112mr3681971plx.7.1699816061126; 
 Sun, 12 Nov 2023 11:07:41 -0800 (PST)
Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com.
 [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id
 ij26-20020a170902ab5a00b001c32fd9e412sm2939928plb.58.2023.11.12.11.07.40
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 12 Nov 2023 11:07:40 -0800 (PST)
Content-Type: multipart/mixed; boundary="------------77zRDhpPKRNiKYOcII2SmIhM"
Message-ID: <399f2f1e-7c1f-e272-2a9d-4e36e8d8666b@HIDDEN>
Date: Sun, 12 Nov 2023 11:07:38 -0800
MIME-Version: 1.0
Subject: Re: bug#67062: 30.0.50; [PATCH] Abbreviate the revision in
 'vc-annotate' (for Git)
To: Eli Zaretskii <eliz@HIDDEN>, Dmitry Gutov <dmitry@HIDDEN>
References: <66fc4912-6aa5-79da-bd6f-52f068cf1a77@HIDDEN>
 <83y1f4wxby.fsf@HIDDEN> <2eb31324-ae24-db4b-4f62-a0140bfb9f81@HIDDEN>
 <83sf5bv77j.fsf@HIDDEN>
Content-Language: en-US
From: Jim Porter <jporterbugs@HIDDEN>
In-Reply-To: <83sf5bv77j.fsf@HIDDEN>
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 67062
Cc: 67062 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

This is a multi-part message in MIME format.
--------------77zRDhpPKRNiKYOcII2SmIhM
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 11/11/2023 10:03 PM, Eli Zaretskii wrote:
>> Date: Sun, 12 Nov 2023 00:00:13 +0200
>> Cc: 67062 <at> debbugs.gnu.org
>> From: Dmitry Gutov <dmitry@HIDDEN>
>>
>> Our general approach is to prefer global options and dynamic dispatch on
>> backends, resorting to using per-backend options when it's much easier
>> to do.
> 
> Which I think is the case here.  What other VC backend has such long
> revision strings?  I couldn't think of any.

Game of Trees[1] is one, though you could argue that that's cheating 
because it uses the Git repository format. It does have a GNU ELPA 
package though, so the author would probably want to add a 
'vc-got-short-revision' function. (Or something similar depending on 
what this patch looks like if/when it merges.) Looking at some GoT 
repositories, they *do* still use the long SHA-1 hashes for revision 
identifiers.

In fact, there are at least a couple Git-compatible VCSes now. Facebook 
wrote one called "Sapling", though I haven't used it. Based on some 
screenshots at least, it looks like Sapling also uses SHA-1 hashes for 
revision IDs.

In any case, we don't necessarily need to provide a default 
implementation for the 'short-revision' function. What about something 
like this? I'm not sure it's better, but it does let us avoid defining a 
no-op implementation for the "default backend".

[1] https://gameoftrees.org/index.html

[2] https://github.com/facebook/sapling
--------------77zRDhpPKRNiKYOcII2SmIhM
Content-Type: text/plain; charset=UTF-8;
 name="0001-Abbreviate-the-VC-revision-in-vc-annotate-s-buffer-n.patch"
Content-Disposition: attachment;
 filename*0="0001-Abbreviate-the-VC-revision-in-vc-annotate-s-buffer-n.pa";
 filename*1="tch"
Content-Transfer-Encoding: base64

RnJvbSAwZDU1OTE1ZTE5ODRjYjAwMmIwZjdiOWE5ZTIyZDAzYzhiOTQzMWE3IE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j
b20+CkRhdGU6IEZyaSwgMTAgTm92IDIwMjMgMTg6NDI6MjkgLTA4MDAKU3ViamVjdDogW1BB
VENIXSBBYmJyZXZpYXRlIHRoZSBWQyByZXZpc2lvbiBpbiB2Yy1hbm5vdGF0ZSdzIGJ1ZmZl
ciBuYW1lCgoqIGxpc3AvdmMvdmMtYW5ub3RhdGUuZWwgKHZjLWFubm90YXRlKTogVHJ5IHRv
IGNhbGwgJ3Nob3J0LXJldmlzaW9uJy4KCiogbGlzcC92Yy92Yy1naXQuZWwgKHZjLWdpdC1z
aG9ydC1yZXZpc2lvbik6IE5ldyBmdW5jdGlvbi4KKHZjLWdpdC0tcmV2LXBhcnNlKTogTmV3
IG9wdGlvbmFsIGFyZ3VtZW50IFNIT1JULgoKKiBldGMvTkVXUzogQW5ub3VuY2UgdGhpcyBj
aGFuZ2UgKGJ1ZyM2NzA2MikuCi0tLQogZXRjL05FV1MgICAgICAgICAgICAgICB8ICA2ICsr
KysrKwogbGlzcC92Yy92Yy1hbm5vdGF0ZS5lbCB8ICA2ICsrKysrLQogbGlzcC92Yy92Yy1n
aXQuZWwgICAgICB8IDE0ICsrKysrKysrKysrLS0tCiAzIGZpbGVzIGNoYW5nZWQsIDIyIGlu
c2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZXRjL05FV1MgYi9l
dGMvTkVXUwppbmRleCA3NjdlNGMyN2I0My4uMDYzMjAwMTY0OGMgMTAwNjQ0Ci0tLSBhL2V0
Yy9ORVdTCisrKyBiL2V0Yy9ORVdTCkBAIC0zOTYsNiArMzk2LDEyIEBAIHN3aXRjaGVzIGZv
ciBzaG9ydGxvZ3MsIHN1Y2ggYXMgdGhlIG9uZSBwcm9kdWNlZCBieSAnQy14IHYgTCcuCiAq
KiogT2Jzb2xldGUgY29tbWFuZCAndmMtc3dpdGNoLWJhY2tlbmQnIHJlLWFkZGVkIGFzICd2
Yy1jaGFuZ2UtYmFja2VuZCcuCiBUaGUgY29tbWFuZCB3YXMgcHJldmlvdXNseSBvYnNvbGV0
ZWQgYW5kIHVuYm91bmQgaW4gRW1hY3MgMjguCiAKKy0tLQorKioqICd2Yy1hbm5vdGF0ZScg
Y2FuIG5vdyBhYmJyZXZpYXRlIHRoZSByZXZpc2lvbiBpbiB0aGUgYnVmZmVyIG5hbWUuCitW
QyBiYWNrZW5kcyB3aXRoIGEgJ3ZjLUJBQ0tFTkQtc2hvcnQtcmV2aXNpb24nIGZ1bmN0aW9u
cyBjYW4gY29udmVydCBhCityZXZpc2lvbiB0byBhIHNob3J0ZXIgZm9ybSwgYW5kICd2Yy1h
bm5vdGF0ZScgd2lsbCB1c2UgdGhpcyBmb3JtIGluCitpdHMgYnVmZmVyIG5hbWUuICBDdXJy
ZW50bHksIHRoZSBHaXQgYmFja2VuZCBzdXBwb3J0cyB0aGlzLgorCiAqKiBEaWZmIG1vZGUK
IAogKysrCmRpZmYgLS1naXQgYS9saXNwL3ZjL3ZjLWFubm90YXRlLmVsIGIvbGlzcC92Yy92
Yy1hbm5vdGF0ZS5lbAppbmRleCBkZTZjM2FkYmJkYi4uYmVlOGNmMjM4NzIgMTAwNjQ0Ci0t
LSBhL2xpc3AvdmMvdmMtYW5ub3RhdGUuZWwKKysrIGIvbGlzcC92Yy92Yy1hbm5vdGF0ZS5l
bApAQCAtNDA5LDcgKzQwOSwxMSBAQCB2Yy1hbm5vdGF0ZQogCQkJCSAgbmlsIG5pbCAiMjAi
KSkpKSkpKQogICAodmMtZW5zdXJlLXZjLWJ1ZmZlcikKICAgKHNldHEgdmMtYW5ub3RhdGUt
ZGlzcGxheS1tb2RlIGRpc3BsYXktbW9kZSkgO05vdCBzdXJlIHdoeS4gIC0tU3RlZgotICAo
bGV0KiAoKHRlbXAtYnVmZmVyLW5hbWUgKGZvcm1hdCAiKkFubm90YXRlICVzIChyZXYgJXMp
KiIgKGJ1ZmZlci1uYW1lKSByZXYpKQorICAobGV0KiAoKHNob3J0LXJldiAob3IgKGlnbm9y
ZS1lcnJvcnMgKHZjLWNhbGwtYmFja2VuZCAodmMtYmFja2VuZCBmaWxlKQorICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnc2hvcnQt
cmV2aXNpb24gcmV2KSkKKyAgICAgICAgICAgICAgICAgICAgICAgIHJldikpCisgICAgICAg
ICAodGVtcC1idWZmZXItbmFtZSAoZm9ybWF0ICIqQW5ub3RhdGUgJXMgKHJldiAlcykqIiAo
YnVmZmVyLW5hbWUpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNob3J0
LXJldikpCiAgICAgICAgICAodGVtcC1idWZmZXItc2hvdy1mdW5jdGlvbiAndmMtYW5ub3Rh
dGUtZGlzcGxheS1zZWxlY3QpCiAgICAgICAgICA7OyBJZiBCVUYgaXMgc3BlY2lmaWVkLCB3
ZSBwcmVzdW1lIHRoZSBjYWxsZXIgbWFpbnRhaW5zIGN1cnJlbnQgbGluZSwKICAgICAgICAg
IDs7IHNvIHdlIGRvbid0IG5lZWQgdG8gZG8gaXQgaGVyZS4gIFRoaXMgaW1wbGVtZW50YXRp
b24gbWF5IGdpdmUKZGlmZiAtLWdpdCBhL2xpc3AvdmMvdmMtZ2l0LmVsIGIvbGlzcC92Yy92
Yy1naXQuZWwKaW5kZXggNzA3ZmM3Y2ZjMDcuLjJmZjZmNTU2NGVkIDEwMDY0NAotLS0gYS9s
aXNwL3ZjL3ZjLWdpdC5lbAorKysgYi9saXNwL3ZjL3ZjLWdpdC5lbApAQCAtNDAzLDYgKzQw
MywxMSBAQCB2Yy1naXQtd29ya2luZy1yZXZpc2lvbgogICAobGV0IChwcm9jZXNzLWZpbGUt
c2lkZS1lZmZlY3RzKQogICAgICh2Yy1naXQtLXJldi1wYXJzZSAiSEVBRCIpKSkKIAorKGRl
ZnVuIHZjLWdpdC1zaG9ydC1yZXZpc2lvbiAocmV2KQorICAiR2l0LXNwZWNpZmljIHZlcnNp
b24gb2YgYHZjLXNob3J0LXJldmlzaW9uJy4iCisgIChsZXQgKHByb2Nlc3MtZmlsZS1zaWRl
LWVmZmVjdHMpCisgICAgKHZjLWdpdC0tcmV2LXBhcnNlIHJldiAnc2hvcnQpKSkKKwogKGRl
ZnVuIHZjLWdpdC0tc3ltYm9saWMtcmVmIChmaWxlKQogICAob3IKICAgICh2Yy1maWxlLWdl
dHByb3AgZmlsZSAndmMtZ2l0LXN5bWJvbGljLXJlZikKQEAgLTE4MzAsMTEgKzE4MzUsMTQg
QEAgdmMtZ2l0LXByZXZpb3VzLXJldmlzaW9uCiAgICAgOzsgZG9lcyBub3QgKGFuZCBjYW5u
b3QpIHF1b3RlLgogICAgICh2Yy1naXQtLXJldi1wYXJzZSAoY29uY2F0IHJldiAifjEiKSkp
KQogCi0oZGVmdW4gdmMtZ2l0LS1yZXYtcGFyc2UgKHJldikKKyhkZWZ1biB2Yy1naXQtLXJl
di1wYXJzZSAocmV2ICZvcHRpb25hbCBzaG9ydCkKICAgKHdpdGgtdGVtcC1idWZmZXIKICAg
ICAoYW5kCi0gICAgICh2Yy1naXQtLW91dC1vayAicmV2LXBhcnNlIiByZXYpCi0gICAgIChi
dWZmZXItc3Vic3RyaW5nLW5vLXByb3BlcnRpZXMgKHBvaW50LW1pbikgKCsgKHBvaW50LW1p
bikgNDApKSkpKQorICAgICAoYXBwbHkgIyd2Yy1naXQtLW91dC1vayAicmV2LXBhcnNlIgor
ICAgICAgICAgICAgKGFwcGVuZCAod2hlbiBzaG9ydCAnKCItLXNob3J0IikpCisgICAgICAg
ICAgICAgICAgICAgIChsaXN0IHJldikpKQorICAgICAoZ290by1jaGFyIChwb2ludC1taW4p
KQorICAgICAoYnVmZmVyLXN1YnN0cmluZy1uby1wcm9wZXJ0aWVzIChwb2ludCkgKHBvcy1l
b2wpKSkpKQogCiAoZGVmdW4gdmMtZ2l0LW5leHQtcmV2aXNpb24gKGZpbGUgcmV2KQogICAi
R2l0LXNwZWNpZmljIHZlcnNpb24gb2YgYHZjLW5leHQtcmV2aXNpb24nLiIKLS0gCjIuMjUu
MQoK

--------------77zRDhpPKRNiKYOcII2SmIhM--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67062; Package emacs. Full text available.

Message received at 67062 <at> debbugs.gnu.org:


Received: (at 67062) by debbugs.gnu.org; 12 Nov 2023 18:50:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 12 13:50:06 2023
Received: from localhost ([127.0.0.1]:57011 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r2FX4-0006JP-8x
	for submit <at> debbugs.gnu.org; Sun, 12 Nov 2023 13:50:06 -0500
Received: from relay2-d.mail.gandi.net ([217.70.183.194]:45789)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>) id 1r2FX2-0006Iq-4Z
 for 67062 <at> debbugs.gnu.org; Sun, 12 Nov 2023 13:50:05 -0500
Received: by mail.gandi.net (Postfix) with ESMTPSA id D7CFB40004;
 Sun, 12 Nov 2023 18:49:15 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Dmitry Gutov <dmitry@HIDDEN>
Subject: Re: bug#67062: 30.0.50; [PATCH] Abbreviate the revision in
 'vc-annotate' (for Git)
In-Reply-To: <ad938cf5-201a-79f0-2b29-c4e0db230f9f@HIDDEN> (Dmitry Gutov's
 message of "Sun, 12 Nov 2023 13:21:29 +0200")
Organization: LINKOV.NET
References: <66fc4912-6aa5-79da-bd6f-52f068cf1a77@HIDDEN>
 <83y1f4wxby.fsf@HIDDEN>
 <2eb31324-ae24-db4b-4f62-a0140bfb9f81@HIDDEN>
 <83sf5bv77j.fsf@HIDDEN>
 <ea6fbea1-d918-f534-4dd3-ee29b631cc6d@HIDDEN>
 <83bkbzusri.fsf@HIDDEN>
 <ad938cf5-201a-79f0-2b29-c4e0db230f9f@HIDDEN>
Date: Sun, 12 Nov 2023 20:48:07 +0200
Message-ID: <86msvi95aw.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 67062
Cc: jporterbugs@HIDDEN, Eli Zaretskii <eliz@HIDDEN>, 67062 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

>> no, vc-annotate will call a new function, which will have a special
>> code for Git alone.
>
> That's one extra indirection, but conceptually the same. We couldn't modify
> vc-working-revision for this, so it'll have to be a new function.

But maybe could add a new optional arg to vc-working-revision?




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67062; Package emacs. Full text available.

Message received at 67062 <at> debbugs.gnu.org:


Received: (at 67062) by debbugs.gnu.org; 12 Nov 2023 11:22:21 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 12 06:22:21 2023
Received: from localhost ([127.0.0.1]:55169 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r28Xl-0007pY-FR
	for submit <at> debbugs.gnu.org; Sun, 12 Nov 2023 06:22:21 -0500
Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:43109)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dmitry@HIDDEN>) id 1r28Xj-0007pL-Jx
 for 67062 <at> debbugs.gnu.org; Sun, 12 Nov 2023 06:22:20 -0500
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.west.internal (Postfix) with ESMTP id E0F7232004ED;
 Sun, 12 Nov 2023 06:21:32 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute4.internal (MEProxy); Sun, 12 Nov 2023 06:21:33 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc
 :cc:content-transfer-encoding:content-type:content-type:date
 :date:from:from:in-reply-to:in-reply-to:message-id:mime-version
 :references:reply-to:sender:subject:subject:to:to; s=fm2; t=
 1699788092; x=1699874492; bh=RKP3O76EeuzZlQ5vPHFqzJB0edJBh9hKAoI
 DikjyUgY=; b=HUW74A6UIdYa3Wv29grnI2r6tYKcLB4QO8KuvLq2n/8QDlSrKdu
 4HsRUXGe8I7vgP1pYr+tuEhUxw5ZU9pEVUtcmR6z+3LCOaK4r8HOVnfSplWUfUJI
 RJ++QbnrFSYYwhGv+cMXIXrdNSCtHAJGN1pDY1tBkpVWslCjMrsg/6q16wmiVPmZ
 DRd7mcyfh7Bkl3v6cGn4AxaXe0V/hmtAxvDSjhktUhr7qOAubOdbUg2uFu/5+19C
 nhstEEi9J5TEG8g5wI9XoxaVY+u7XN+/hn5ngX+yiP8SkKSOTbj8090oJcspVfds
 fF5nhWdi7qY54ojqzB9jolrD21xJsba626w==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-transfer-encoding
 :content-type:content-type:date:date:feedback-id:feedback-id
 :from:from:in-reply-to:in-reply-to:message-id:mime-version
 :references:reply-to:sender:subject:subject:to:to:x-me-proxy
 :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=
 1699788092; x=1699874492; bh=RKP3O76EeuzZlQ5vPHFqzJB0edJBh9hKAoI
 DikjyUgY=; b=E0kBTeuxPJKcQG7EZhMVNAmQv5PV8Tz3fpALLHCNRm9cKfNf15j
 m/78ql6/ZtS1m5gS7cGyDnL+HmmltHEQTlIC0FyJZQSjndnVmbf4PdmedsFsjIqi
 czGPOl+7hE/DEn6HshJlb9ZQXVmHolB4IOfI3E/tf1d6Mab8AL7Enuw0vq89B9TB
 5Ji3syzQ6BRvv9sUgSpBrTZ3kdQ1akX8eivoAgFPbEvEeNHA8wqRzI/og/hixOzt
 Jkw8aQnPP/17prptoksRRaE6G6+4KK27cyLZPmAu5Er20R5UI3NjtiYpgwkHtakQ
 eRi2KkSivWpxzwNA4qRZtdoRtUG5h9oWPDQ==
X-ME-Sender: <xms:PLVQZU35xiaq4sJHyNLj7FjhQur5904keMaPXO7KWmdnWkhUNK_3hw>
 <xme:PLVQZfFvpSeQz1s89vPRQBevLfurx7UXjpWVGrvEo-hBIqPzXGv3TJHV2Ds4hjs-T
 Yu4OSHcgJ-irfJc36g>
X-ME-Received: <xmr:PLVQZc6Hj6vZIzqBCbBNYCMm60Jxc4FOyPTMnlbmgKrJb93ootWRLLB5_dtHin0>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedruddvkedgvdekucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi
 thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth
 htvghrnhepiefgteevheevveffheeltdeukeeiieekueefgedugfefgefhudelgfefveel
 vdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug
 hmihhtrhihsehguhhtohhvrdguvghv
X-ME-Proxy: <xmx:PLVQZd1S6xpQPskIdLkpnkAcppFYQWfbhZWcXVox1H9VUjSnT0l8cQ>
 <xmx:PLVQZXGapCjy5cSQsSeWve72R1mp9VaJUDz7xrHlD14asiSSx9b0GA>
 <xmx:PLVQZW_k6Q928p6Mym_A1PWjYt9Oj6Nkt3EOcWXNYLg83uH1Y9hzMA>
 <xmx:PLVQZdP8FPn4f6cbv1XowG99HFNEGoyknIrHsfjcvhe3AeKxhKcf4g>
Feedback-ID: i0e71465a:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun,
 12 Nov 2023 06:21:31 -0500 (EST)
Message-ID: <ad938cf5-201a-79f0-2b29-c4e0db230f9f@HIDDEN>
Date: Sun, 12 Nov 2023 13:21:29 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: bug#67062: 30.0.50; [PATCH] Abbreviate the revision in
 'vc-annotate' (for Git)
Content-Language: en-US
To: Eli Zaretskii <eliz@HIDDEN>
References: <66fc4912-6aa5-79da-bd6f-52f068cf1a77@HIDDEN>
 <83y1f4wxby.fsf@HIDDEN> <2eb31324-ae24-db4b-4f62-a0140bfb9f81@HIDDEN>
 <83sf5bv77j.fsf@HIDDEN> <ea6fbea1-d918-f534-4dd3-ee29b631cc6d@HIDDEN>
 <83bkbzusri.fsf@HIDDEN>
From: Dmitry Gutov <dmitry@HIDDEN>
In-Reply-To: <83bkbzusri.fsf@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: -2.2 (--)
X-Debbugs-Envelope-To: 67062
Cc: jporterbugs@HIDDEN, 67062 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.2 (---)

On 12/11/2023 13:15, Eli Zaretskii wrote:
> no, vc-annotate will call a new function, which will have a special
> code for Git alone.

That's one extra indirection, but conceptually the same. We couldn't 
modify vc-working-revision for this, so it'll have to be a new function.

And the new function (name pending) will need to check (eq backend 'Git) 
and call vc-git-short-revision anyway.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67062; Package emacs. Full text available.

Message received at 67062 <at> debbugs.gnu.org:


Received: (at 67062) by debbugs.gnu.org; 12 Nov 2023 11:16:53 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 12 06:16:53 2023
Received: from localhost ([127.0.0.1]:55163 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r28SS-0007g7-Nn
	for submit <at> debbugs.gnu.org; Sun, 12 Nov 2023 06:16:52 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:36796)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1r28SP-0007fr-Ab
 for 67062 <at> debbugs.gnu.org; Sun, 12 Nov 2023 06:16:51 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1r28Re-0007V2-S4; Sun, 12 Nov 2023 06:16:02 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=P+efXPD/oYJmppPAA2cdow/oKKYKNLSlyJY/+9FpD88=; b=RMXRAQqXOUdU
 49IAZiRGsBnlBIMDFYqdaAXQXIvIz98Ij93DbUM3wG0YIhWXmZ93aXgp5Dzvq5QLXP3HsBVmOWVoM
 XOZ9sgZdLMmnNguNZ7G2AJPsxmrCpKlTCN1K7Wl7iHhFSyj9xFKtmxZVLDD7VF7UQA7sd7r9FECOK
 cwfu5T/Flq/lzSS7EZPpXfLYtDl83NkzRSURYVBI8KDRlgqRyRoJdgjGG5vK5qW7Fk2hOuWR7mSzm
 ITW5HNwP2omKZhzpPsQjYODYqcqeBmZ/BZk5rNcoOEn7jSmgoGhKZMyxbP9Yo2xuco3OD2W7qMjG0
 9nmPQDS0nyqqykl5hzDuAg==;
Date: Sun, 12 Nov 2023 13:15:45 +0200
Message-Id: <83bkbzusri.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Dmitry Gutov <dmitry@HIDDEN>
In-Reply-To: <ea6fbea1-d918-f534-4dd3-ee29b631cc6d@HIDDEN> (message from
 Dmitry Gutov on Sun, 12 Nov 2023 12:58:06 +0200)
Subject: Re: bug#67062: 30.0.50; [PATCH] Abbreviate the revision in
 'vc-annotate' (for Git)
References: <66fc4912-6aa5-79da-bd6f-52f068cf1a77@HIDDEN>
 <83y1f4wxby.fsf@HIDDEN> <2eb31324-ae24-db4b-4f62-a0140bfb9f81@HIDDEN>
 <83sf5bv77j.fsf@HIDDEN> <ea6fbea1-d918-f534-4dd3-ee29b631cc6d@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 67062
Cc: jporterbugs@HIDDEN, 67062 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Sun, 12 Nov 2023 12:58:06 +0200
> Cc: jporterbugs@HIDDEN, 67062 <at> debbugs.gnu.org
> From: Dmitry Gutov <dmitry@HIDDEN>
> 
> On 12/11/2023 08:03, Eli Zaretskii wrote:
> > I'm not sure I follow.  All we need is a new function to call instead
> > of vc-working-revision, that's all.  That new function will indicate
> > the intention to the backend.  Sounds easy enough.
> 
> vc-annotate will check (if (eq backend 'Git)) and call a different 
> function in such case? Rather dirty, but I guess that'll also work.

no, vc-annotate will call a new function, which will have a special
code for Git alone.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67062; Package emacs. Full text available.

Message received at 67062 <at> debbugs.gnu.org:


Received: (at 67062) by debbugs.gnu.org; 12 Nov 2023 10:58:59 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 12 05:58:59 2023
Received: from localhost ([127.0.0.1]:55153 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r28B8-0007C7-LB
	for submit <at> debbugs.gnu.org; Sun, 12 Nov 2023 05:58:58 -0500
Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:44651)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dmitry@HIDDEN>) id 1r28B7-0007Bt-7S
 for 67062 <at> debbugs.gnu.org; Sun, 12 Nov 2023 05:58:57 -0500
Received: from compute7.internal (compute7.nyi.internal [10.202.2.48])
 by mailout.west.internal (Postfix) with ESMTP id 4ADF7320077A;
 Sun, 12 Nov 2023 05:58:10 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute7.internal (MEProxy); Sun, 12 Nov 2023 05:58:10 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc
 :cc:content-transfer-encoding:content-type:content-type:date
 :date:from:from:in-reply-to:in-reply-to:message-id:mime-version
 :references:reply-to:sender:subject:subject:to:to; s=fm2; t=
 1699786689; x=1699873089; bh=JTjJr6hwXBt+YNrQFWmb/birK0JU0Repjy5
 qcNf+c+o=; b=JJMooHKLg2+w142RHrv9Rjvt1izBE4FM/M1IZ+udyMvy9Xki5oc
 GNd2NqUNHtEfHw+vMd0r7RDsoqtAEdt9HXqypnZTWbLKl5OZRBDcQZUibJtrEDa2
 qIy2QkMz+YNMOcqrOBUownbAJBt6FpHqvqA7NmV/5jePt2QMsEFmsl4PSpf2WF2I
 Qb1uVYCR3ctFExYp4MjB+uK2VmQfKM68dEc/SQWyt/Z6lB2uGnQGZDtvACtV1YKa
 n0r7qZHxWWcfsEQYS7KjE5VzY50DVa8dslw18a3Y6sytL8VZq/FVjCrIO6Psgg6M
 0wTyl12+SyJk0dyOAM8IKuIt2tieSMQXQIA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-transfer-encoding
 :content-type:content-type:date:date:feedback-id:feedback-id
 :from:from:in-reply-to:in-reply-to:message-id:mime-version
 :references:reply-to:sender:subject:subject:to:to:x-me-proxy
 :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=
 1699786689; x=1699873089; bh=JTjJr6hwXBt+YNrQFWmb/birK0JU0Repjy5
 qcNf+c+o=; b=qBsrljJn+1jB3k600gE6vBGnyLDA8J8v1IMedw37cvorSwEz/uS
 hNor7i/rqzz306ACpK+TFUAjZKStNO3Ee7KYl+XNlL1gD3dDedSWiGkjn/IDXV6K
 lOxGYQUTfczClv1afviMP/m3aLHx0WTDXIGKCGwRJKcDaoYTU17PSPZgAyFjhSId
 ZQVPVacfK3xSXhwUCjJWmHR8MetVOaDAoHLKxj3OPzUUW5FQ4xzIbDqtAoXF6g0z
 GrmceWeyh5N+egGrootdJikcOzHtlnVzhOxs2quNytP3YhleSOXJZgR3G9c46lCd
 YB4ITGeg3F7LAQJYSPk+ZTLzHsPEdjXiBtQ==
X-ME-Sender: <xms:wa9QZaWtkkFuIXM1foSCED9or_1JLVgOIfKs0HxYojIqNRJ2zPiTQQ>
 <xme:wa9QZWlJiCXdzTzKiKieuyY9r6Ww2YxMUGDRwE4rDBy5PsWB_X9ybiR6PDAJAk0C8
 jj1gTqRdM19rHnDuCw>
X-ME-Received: <xmr:wa9QZebvJx8SZEqxi0qSfG5FodLqsR0YQI8vxsP_Wwy_IQOqbJAYbMo7hYeHfTI>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedruddvkedgvdefucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi
 thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth
 htvghrnhepiefgteevheevveffheeltdeukeeiieekueefgedugfefgefhudelgfefveel
 vdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug
 hmihhtrhihsehguhhtohhvrdguvghv
X-ME-Proxy: <xmx:wa9QZRU1dQbaBev3NnmyisnGZTu-0gu76PiWLyggwn_4Y6lX1HOpDg>
 <xmx:wa9QZUk8OG-1Hn0NgvRjucsZ8Y2QBjHbGOOiesweHOOpmO66G9Cyvw>
 <xmx:wa9QZWfdTUOp5peAg70-ZY29_Xwk0WwYjkftrhgZ1UTOKkLQUH10Dw>
 <xmx:wa9QZQvuc3OkZqhzeJdwwl4An9i_j9egmpEwrXF86On7islSDwKPIg>
Feedback-ID: i0e71465a:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun,
 12 Nov 2023 05:58:08 -0500 (EST)
Message-ID: <ea6fbea1-d918-f534-4dd3-ee29b631cc6d@HIDDEN>
Date: Sun, 12 Nov 2023 12:58:06 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: bug#67062: 30.0.50; [PATCH] Abbreviate the revision in
 'vc-annotate' (for Git)
Content-Language: en-US
To: Eli Zaretskii <eliz@HIDDEN>
References: <66fc4912-6aa5-79da-bd6f-52f068cf1a77@HIDDEN>
 <83y1f4wxby.fsf@HIDDEN> <2eb31324-ae24-db4b-4f62-a0140bfb9f81@HIDDEN>
 <83sf5bv77j.fsf@HIDDEN>
From: Dmitry Gutov <dmitry@HIDDEN>
In-Reply-To: <83sf5bv77j.fsf@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: -2.2 (--)
X-Debbugs-Envelope-To: 67062
Cc: jporterbugs@HIDDEN, 67062 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.2 (---)

On 12/11/2023 08:03, Eli Zaretskii wrote:
> I'm not sure I follow.  All we need is a new function to call instead
> of vc-working-revision, that's all.  That new function will indicate
> the intention to the backend.  Sounds easy enough.

vc-annotate will check (if (eq backend 'Git)) and call a different 
function in such case? Rather dirty, but I guess that'll also work.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67062; Package emacs. Full text available.

Message received at 67062 <at> debbugs.gnu.org:


Received: (at 67062) by debbugs.gnu.org; 12 Nov 2023 06:04:53 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 12 01:04:53 2023
Received: from localhost ([127.0.0.1]:54959 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r23aX-0004ro-FD
	for submit <at> debbugs.gnu.org; Sun, 12 Nov 2023 01:04:53 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:35364)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1r23aU-0004rZ-DY
 for 67062 <at> debbugs.gnu.org; Sun, 12 Nov 2023 01:04:51 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1r23Zj-0006nz-U2; Sun, 12 Nov 2023 01:04:03 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=cUtvSi8eVKkbXnuilzzR66zZoeEQWa12e4toL0LbI60=; b=lpz+AnibRLm+
 3b7wF0rycHLGVPPvvPhdI/CQb4eaprO9J7coX1cNyGRhmi4JtLkzhNsCjGHsIBEuMV4FetiXMHvQC
 iCmkjykRDRt3AYZM/xQs3o1hh8RK0QjO39q3ogecZPHUMU3GoTD/eQn07H3/kYoP1ZIM2vf9Tmwm4
 N42BYEU/a1EWA1NfFLGjiyXmuM6TacJAmVs1sm4JrwMV38mIa8aMXJFQfXuZMMCpMxJPZhc/t4aNh
 zf8h1Em+SuXBSO7ncBjNNYpyDHNRtgcAD4b9uifY4fhCUUrICWuhR+NU7V7a/GwShMEnhHtfbt9W4
 LTIGXJG7Kd2prLphazPtdg==;
Date: Sun, 12 Nov 2023 08:03:44 +0200
Message-Id: <83sf5bv77j.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Dmitry Gutov <dmitry@HIDDEN>
In-Reply-To: <2eb31324-ae24-db4b-4f62-a0140bfb9f81@HIDDEN> (message from
 Dmitry Gutov on Sun, 12 Nov 2023 00:00:13 +0200)
Subject: Re: bug#67062: 30.0.50; [PATCH] Abbreviate the revision in
 'vc-annotate' (for Git)
References: <66fc4912-6aa5-79da-bd6f-52f068cf1a77@HIDDEN>
 <83y1f4wxby.fsf@HIDDEN> <2eb31324-ae24-db4b-4f62-a0140bfb9f81@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 67062
Cc: jporterbugs@HIDDEN, 67062 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Sun, 12 Nov 2023 00:00:13 +0200
> Cc: 67062 <at> debbugs.gnu.org
> From: Dmitry Gutov <dmitry@HIDDEN>
> 
> On 11/11/2023 09:41, Eli Zaretskii wrote:
> > If this is a Git-only issue, perhaps it would be better to have a
> > Git-only option, instead of defining a whole new VC method?
> 
> Our general approach is to prefer global options and dynamic dispatch on 
> backends, resorting to using per-backend options when it's much easier 
> to do.

Which I think is the case here.  What other VC backend has such long
revision strings?  I couldn't think of any.  And for Git, there could
be the choice of either shortening the SHA1 signature or using what
"git describe" returns.  Which is why I suggested an option specific
to vc-git.

> In this case it might actually be more difficult to go the second route 
> since the intention is to only use the short hash in this particular 
> place. vc-annotate is common code and it will need to indicate that 
> intention to the backend somehow.

I'm not sure I follow.  All we need is a new function to call instead
of vc-working-revision, that's all.  That new function will indicate
the intention to the backend.  Sounds easy enough.

IOW, if Git is a special case, there's IMO nothing wrong with having
code that is specific to Git.  Inventing a VC method that will do
nothing in every VCS but Git sounds un-economical and not very elegant
to me, FWIW.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67062; Package emacs. Full text available.

Message received at 67062 <at> debbugs.gnu.org:


Received: (at 67062) by debbugs.gnu.org; 12 Nov 2023 00:32:34 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 11 19:32:34 2023
Received: from localhost ([127.0.0.1]:54681 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r1yOv-0004aT-U8
	for submit <at> debbugs.gnu.org; Sat, 11 Nov 2023 19:32:34 -0500
Received: from mail-pg1-x52a.google.com ([2607:f8b0:4864:20::52a]:48275)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jporterbugs@HIDDEN>) id 1r1yOt-0004aE-Ov
 for 67062 <at> debbugs.gnu.org; Sat, 11 Nov 2023 19:32:32 -0500
Received: by mail-pg1-x52a.google.com with SMTP id
 41be03b00d2f7-5b980391d70so2487463a12.0
 for <67062 <at> debbugs.gnu.org>; Sat, 11 Nov 2023 16:31:51 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1699749105; x=1700353905; darn=debbugs.gnu.org;
 h=in-reply-to:from:references:cc:to:content-language:subject
 :mime-version:date:message-id:from:to:cc:subject:date:message-id
 :reply-to; bh=PSW5PvJyAqLNO9GUYlMaXdUfb88KSBpZUzmX2EdSO2Y=;
 b=Lu0+hE86hxYOZINkDpvmub75iXIINN2s8ZyQ0El3tKs8xF/RrnlZC/xuHINCLp4tya
 /SCOgPTZxwqv8q08gx4wd/44CKKR6jMZYH2A8v3kou4cJLpg6xbvmEgCPn+xfLcQkVy/
 nGufzKCx2mrb3Cpxe25U8sKOe/yFcL1c1VQTMLg0tvFPBPnJtsytSU/p+sv7Jk8+JWEd
 uIQRjZZrbYW4oEeb9hzZZxwZWsu+NHSdsc+n8uUAiX+CfsaFa6/RHKzTFJVPjpufNpoM
 geSs0ySQ4Qno/ESRYGLEgpKIn6cEHuIu0bKjqGzJV1et/LzIMhoGViRjs7Aa9tobgVIM
 k95Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1699749105; x=1700353905;
 h=in-reply-to:from:references:cc:to:content-language:subject
 :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject
 :date:message-id:reply-to;
 bh=PSW5PvJyAqLNO9GUYlMaXdUfb88KSBpZUzmX2EdSO2Y=;
 b=se/syjns8Q38DycrmtrLerd1TAYn5/wHOdR1RWFuJRDbmje3WdH6GOjOjypN5qWhJ3
 3HBOv4cL3PhAfUHdb+TyO+4QtWsDvkfQa8klPWF8cLR0Y57iUn7UEQMv0FqaKtc53ZMb
 4aB0OoJcBfF8xvrEC6DXr4WKfMtwGL0r1GCrRTZSVRkRkFijG5MdX+HEinYwwxE6DYMR
 7JwlM4u1HQy0lQVPP91yAp+MyhftLubtrIlIHmbkOb48HedeLkigwy4yttn38FEAUXoh
 IRR2E0Usb403Sxhx5SbNJ6uUx+lZ67I9FvJQgrqVvFAsKvjIaokh/3KcSE+I/xBw9jkq
 jlsg==
X-Gm-Message-State: AOJu0YxyJpoTWM+Asg2tvnpS3pfNxz0V1nXRAdHMNlYc67rhHGLCFXdU
 nWj1URFfTg7KBtZf9iPYtjo=
X-Google-Smtp-Source: AGHT+IG2h/6kgf9450HDqvEA7gbfESPURmtCSmDRHPSAv+HVhRjao/gqcvXuR3xwPoIJrooIK/nhDQ==
X-Received: by 2002:a05:6a21:7782:b0:154:3f13:1bb7 with SMTP id
 bd2-20020a056a21778200b001543f131bb7mr3894138pzc.49.1699749104839; 
 Sat, 11 Nov 2023 16:31:44 -0800 (PST)
Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com.
 [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id
 c64-20020a17090a494600b0027cf8869ee7sm4169052pjh.0.2023.11.11.16.31.43
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sat, 11 Nov 2023 16:31:44 -0800 (PST)
Content-Type: multipart/mixed; boundary="------------804uT0Llz0kr8Zurueu6Xc2O"
Message-ID: <2f7f9967-496c-163a-fa46-58b255a7e8a0@HIDDEN>
Date: Sat, 11 Nov 2023 16:31:43 -0800
MIME-Version: 1.0
Subject: Re: bug#67062: 30.0.50; [PATCH] Abbreviate the revision in
 'vc-annotate' (for Git)
Content-Language: en-US
To: Dmitry Gutov <dmitry@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>
References: <66fc4912-6aa5-79da-bd6f-52f068cf1a77@HIDDEN>
 <83y1f4wxby.fsf@HIDDEN> <2eb31324-ae24-db4b-4f62-a0140bfb9f81@HIDDEN>
From: Jim Porter <jporterbugs@HIDDEN>
In-Reply-To: <2eb31324-ae24-db4b-4f62-a0140bfb9f81@HIDDEN>
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 67062
Cc: 67062 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

This is a multi-part message in MIME format.
--------------804uT0Llz0kr8Zurueu6Xc2O
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 11/11/2023 2:00 PM, Dmitry Gutov wrote:
> On 11/11/2023 09:41, Eli Zaretskii wrote:
>> If this is a Git-only issue, perhaps it would be better to have a
>> Git-only option, instead of defining a whole new VC method?
> 
> Our general approach is to prefer global options and dynamic dispatch on 
> backends, resorting to using per-backend options when it's much easier 
> to do.
> 
> In this case it might actually be more difficult to go the second route 
> since the intention is to only use the short hash in this particular 
> place. vc-annotate is common code and it will need to indicate that 
> intention to the backend somehow.

Thanks for taking a look. It sounds like the strategy I went with is at 
least approximately right, so here's an updated patch with a NEWS entry.

I looked through the manuals and didn't see anywhere to add a mention of 
this though. There's a section about 'vc-annotate', but it's written for 
an Emacs user, rather than an Elisp programmer, and I think trying to 
explain "short revisions" in that section would just add unnecessary 
detail. If we still want to add some mention of this to a manual, I 
guess it would make the most sense in some section about how to use the 
VC package as an Elisp programmer. I didn't see much about that though...
--------------804uT0Llz0kr8Zurueu6Xc2O
Content-Type: text/plain; charset=UTF-8;
 name="0001-Abbreviate-the-VC-revision-in-vc-annotate-s-buffer-n.patch"
Content-Disposition: attachment;
 filename*0="0001-Abbreviate-the-VC-revision-in-vc-annotate-s-buffer-n.pa";
 filename*1="tch"
Content-Transfer-Encoding: base64

RnJvbSAzZGQ5NDM0MTYxYjM2ZjAxMzk3YzMyNjljYTgzOWJjYTNkYjBkNTllIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j
b20+CkRhdGU6IEZyaSwgMTAgTm92IDIwMjMgMTg6NDI6MjkgLTA4MDAKU3ViamVjdDogW1BB
VENIXSBBYmJyZXZpYXRlIHRoZSBWQyByZXZpc2lvbiBpbiB2Yy1hbm5vdGF0ZSdzIGJ1ZmZl
ciBuYW1lCgoqIGxpc3AvdmMvdmMtYW5ub3RhdGUuZWwgKHZjLWFubm90YXRlKTogQ2FsbCAn
c2hvcnQtcmV2aXNpb24nCgoqIGxpc3AvdmMvdmMtaG9va3MuZWwgKHZjLWRlZmF1bHQtc2hv
cnQtcmV2aXNpb24pOiBOZXcgZnVuY3Rpb24uCgoqIGxpc3AvdmMvdmMtZ2l0LmVsICh2Yy1n
aXQtc2hvcnQtcmV2aXNpb24pOiBOZXcgZnVuY3Rpb24uCih2Yy1naXQtLXJldi1wYXJzZSk6
IE5ldyBvcHRpb25hbCBhcmd1bWVudCBTSE9SVC4KCiogZXRjL05FV1M6IEFubm91bmNlIHRo
aXMgY2hhbmdlIChidWcjNjcwNjIpLgotLS0KIGV0Yy9ORVdTICAgICAgICAgICAgICAgfCAg
NiArKysrKysKIGxpc3AvdmMvdmMtYW5ub3RhdGUuZWwgfCAgNCArKystCiBsaXNwL3ZjL3Zj
LWdpdC5lbCAgICAgIHwgMTQgKysrKysrKysrKystLS0KIGxpc3AvdmMvdmMtaG9va3MuZWwg
ICAgfCAgNSArKysrKwogNCBmaWxlcyBjaGFuZ2VkLCAyNSBpbnNlcnRpb25zKCspLCA0IGRl
bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2V0Yy9ORVdTIGIvZXRjL05FV1MKaW5kZXggNzY3
ZTRjMjdiNDMuLjA2MzIwMDE2NDhjIDEwMDY0NAotLS0gYS9ldGMvTkVXUworKysgYi9ldGMv
TkVXUwpAQCAtMzk2LDYgKzM5NiwxMiBAQCBzd2l0Y2hlcyBmb3Igc2hvcnRsb2dzLCBzdWNo
IGFzIHRoZSBvbmUgcHJvZHVjZWQgYnkgJ0MteCB2IEwnLgogKioqIE9ic29sZXRlIGNvbW1h
bmQgJ3ZjLXN3aXRjaC1iYWNrZW5kJyByZS1hZGRlZCBhcyAndmMtY2hhbmdlLWJhY2tlbmQn
LgogVGhlIGNvbW1hbmQgd2FzIHByZXZpb3VzbHkgb2Jzb2xldGVkIGFuZCB1bmJvdW5kIGlu
IEVtYWNzIDI4LgogCistLS0KKyoqKiAndmMtYW5ub3RhdGUnIGNhbiBub3cgYWJicmV2aWF0
ZSB0aGUgcmV2aXNpb24gaW4gdGhlIGJ1ZmZlciBuYW1lLgorVkMgYmFja2VuZHMgd2l0aCBh
ICd2Yy1CQUNLRU5ELXNob3J0LXJldmlzaW9uJyBmdW5jdGlvbnMgY2FuIGNvbnZlcnQgYQor
cmV2aXNpb24gdG8gYSBzaG9ydGVyIGZvcm0sIGFuZCAndmMtYW5ub3RhdGUnIHdpbGwgdXNl
IHRoaXMgZm9ybSBpbgoraXRzIGJ1ZmZlciBuYW1lLiAgQ3VycmVudGx5LCB0aGUgR2l0IGJh
Y2tlbmQgc3VwcG9ydHMgdGhpcy4KKwogKiogRGlmZiBtb2RlCiAKICsrKwpkaWZmIC0tZ2l0
IGEvbGlzcC92Yy92Yy1hbm5vdGF0ZS5lbCBiL2xpc3AvdmMvdmMtYW5ub3RhdGUuZWwKaW5k
ZXggZGU2YzNhZGJiZGIuLjg1MTYxMzQ3Y2JmIDEwMDY0NAotLS0gYS9saXNwL3ZjL3ZjLWFu
bm90YXRlLmVsCisrKyBiL2xpc3AvdmMvdmMtYW5ub3RhdGUuZWwKQEAgLTQwOSw3ICs0MDks
OSBAQCB2Yy1hbm5vdGF0ZQogCQkJCSAgbmlsIG5pbCAiMjAiKSkpKSkpKQogICAodmMtZW5z
dXJlLXZjLWJ1ZmZlcikKICAgKHNldHEgdmMtYW5ub3RhdGUtZGlzcGxheS1tb2RlIGRpc3Bs
YXktbW9kZSkgO05vdCBzdXJlIHdoeS4gIC0tU3RlZgotICAobGV0KiAoKHRlbXAtYnVmZmVy
LW5hbWUgKGZvcm1hdCAiKkFubm90YXRlICVzIChyZXYgJXMpKiIgKGJ1ZmZlci1uYW1lKSBy
ZXYpKQorICAobGV0KiAoKHRlbXAtYnVmZmVyLW5hbWUgKGZvcm1hdCAiKkFubm90YXRlICVz
IChyZXYgJXMpKiIgKGJ1ZmZlci1uYW1lKQorICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAodmMtY2FsbC1iYWNrZW5kICh2Yy1iYWNrZW5kIGZpbGUpCisgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ3Nob3J0LXJldmlz
aW9uIHJldikpKQogICAgICAgICAgKHRlbXAtYnVmZmVyLXNob3ctZnVuY3Rpb24gJ3ZjLWFu
bm90YXRlLWRpc3BsYXktc2VsZWN0KQogICAgICAgICAgOzsgSWYgQlVGIGlzIHNwZWNpZmll
ZCwgd2UgcHJlc3VtZSB0aGUgY2FsbGVyIG1haW50YWlucyBjdXJyZW50IGxpbmUsCiAgICAg
ICAgICA7OyBzbyB3ZSBkb24ndCBuZWVkIHRvIGRvIGl0IGhlcmUuICBUaGlzIGltcGxlbWVu
dGF0aW9uIG1heSBnaXZlCmRpZmYgLS1naXQgYS9saXNwL3ZjL3ZjLWdpdC5lbCBiL2xpc3Av
dmMvdmMtZ2l0LmVsCmluZGV4IDcwN2ZjN2NmYzA3Li4yZmY2ZjU1NjRlZCAxMDA2NDQKLS0t
IGEvbGlzcC92Yy92Yy1naXQuZWwKKysrIGIvbGlzcC92Yy92Yy1naXQuZWwKQEAgLTQwMyw2
ICs0MDMsMTEgQEAgdmMtZ2l0LXdvcmtpbmctcmV2aXNpb24KICAgKGxldCAocHJvY2Vzcy1m
aWxlLXNpZGUtZWZmZWN0cykKICAgICAodmMtZ2l0LS1yZXYtcGFyc2UgIkhFQUQiKSkpCiAK
KyhkZWZ1biB2Yy1naXQtc2hvcnQtcmV2aXNpb24gKHJldikKKyAgIkdpdC1zcGVjaWZpYyB2
ZXJzaW9uIG9mIGB2Yy1zaG9ydC1yZXZpc2lvbicuIgorICAobGV0IChwcm9jZXNzLWZpbGUt
c2lkZS1lZmZlY3RzKQorICAgICh2Yy1naXQtLXJldi1wYXJzZSByZXYgJ3Nob3J0KSkpCisK
IChkZWZ1biB2Yy1naXQtLXN5bWJvbGljLXJlZiAoZmlsZSkKICAgKG9yCiAgICAodmMtZmls
ZS1nZXRwcm9wIGZpbGUgJ3ZjLWdpdC1zeW1ib2xpYy1yZWYpCkBAIC0xODMwLDExICsxODM1
LDE0IEBAIHZjLWdpdC1wcmV2aW91cy1yZXZpc2lvbgogICAgIDs7IGRvZXMgbm90IChhbmQg
Y2Fubm90KSBxdW90ZS4KICAgICAodmMtZ2l0LS1yZXYtcGFyc2UgKGNvbmNhdCByZXYgIn4x
IikpKSkKIAotKGRlZnVuIHZjLWdpdC0tcmV2LXBhcnNlIChyZXYpCisoZGVmdW4gdmMtZ2l0
LS1yZXYtcGFyc2UgKHJldiAmb3B0aW9uYWwgc2hvcnQpCiAgICh3aXRoLXRlbXAtYnVmZmVy
CiAgICAgKGFuZAotICAgICAodmMtZ2l0LS1vdXQtb2sgInJldi1wYXJzZSIgcmV2KQotICAg
ICAoYnVmZmVyLXN1YnN0cmluZy1uby1wcm9wZXJ0aWVzIChwb2ludC1taW4pICgrIChwb2lu
dC1taW4pIDQwKSkpKSkKKyAgICAgKGFwcGx5ICMndmMtZ2l0LS1vdXQtb2sgInJldi1wYXJz
ZSIKKyAgICAgICAgICAgIChhcHBlbmQgKHdoZW4gc2hvcnQgJygiLS1zaG9ydCIpKQorICAg
ICAgICAgICAgICAgICAgICAobGlzdCByZXYpKSkKKyAgICAgKGdvdG8tY2hhciAocG9pbnQt
bWluKSkKKyAgICAgKGJ1ZmZlci1zdWJzdHJpbmctbm8tcHJvcGVydGllcyAocG9pbnQpIChw
b3MtZW9sKSkpKSkKIAogKGRlZnVuIHZjLWdpdC1uZXh0LXJldmlzaW9uIChmaWxlIHJldikK
ICAgIkdpdC1zcGVjaWZpYyB2ZXJzaW9uIG9mIGB2Yy1uZXh0LXJldmlzaW9uJy4iCmRpZmYg
LS1naXQgYS9saXNwL3ZjL3ZjLWhvb2tzLmVsIGIvbGlzcC92Yy92Yy1ob29rcy5lbAppbmRl
eCBjMTZmYjYzYjJmZi4uMzhjODRhMGNlZWEgMTAwNjQ0Ci0tLSBhL2xpc3AvdmMvdmMtaG9v
a3MuZWwKKysrIGIvbGlzcC92Yy92Yy1ob29rcy5lbApAQCAtNTAyLDYgKzUwMiwxMSBAQCB2
Yy13b3JraW5nLXJldmlzaW9uCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAodmMtY2Fs
bC1iYWNrZW5kCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYmFja2VuZCAnd29ya2lu
Zy1yZXZpc2lvbiBmaWxlKSkpKSkpCiAKKyhkZWZ1biB2Yy1kZWZhdWx0LXNob3J0LXJldmlz
aW9uIChfYmFja2VuZCByZXYpCisgICJSZXR1cm4gYSBcInNob3J0ZW5lZFwiIHZlcnNpb24g
b2YgdGhlIHJldmlzaW9uIFJFVi4KK1RoaXMgZGVmYXVsdCBpbXBsZW1lbnRhdGlvbiBzaW1w
bHkgcmV0dXJucyBSRVYgdW5jaGFuZ2VkLiIKKyAgcmV2KQorCiAoZGVmdW4gdmMtZGVmYXVs
dC1yZWdpc3RlcmVkIChiYWNrZW5kIGZpbGUpCiAgICJDaGVjayBpZiBGSUxFIGlzIHJlZ2lz
dGVyZWQgaW4gQkFDS0VORCB1c2luZyB2Yy1CQUNLRU5ELW1hc3Rlci10ZW1wbGF0ZXMuIgog
ICAobGV0ICgoc3ltICh2Yy1tYWtlLWJhY2tlbmQtc3ltIGJhY2tlbmQgJ21hc3Rlci10ZW1w
bGF0ZXMpKSkKLS0gCjIuMjUuMQoK

--------------804uT0Llz0kr8Zurueu6Xc2O--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67062; Package emacs. Full text available.

Message received at 67062 <at> debbugs.gnu.org:


Received: (at 67062) by debbugs.gnu.org; 11 Nov 2023 22:01:03 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 11 17:01:03 2023
Received: from localhost ([127.0.0.1]:54509 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r1w2J-0000Y2-8u
	for submit <at> debbugs.gnu.org; Sat, 11 Nov 2023 17:01:03 -0500
Received: from out5-smtp.messagingengine.com ([66.111.4.29]:56623)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dmitry@HIDDEN>) id 1r1w2H-0000XR-Jh
 for 67062 <at> debbugs.gnu.org; Sat, 11 Nov 2023 17:01:01 -0500
Received: from compute7.internal (compute7.nyi.internal [10.202.2.48])
 by mailout.nyi.internal (Postfix) with ESMTP id B4A3F5C0151;
 Sat, 11 Nov 2023 17:00:15 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute7.internal (MEProxy); Sat, 11 Nov 2023 17:00:15 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc
 :cc:content-transfer-encoding:content-type:content-type:date
 :date:from:from:in-reply-to:in-reply-to:message-id:mime-version
 :references:reply-to:sender:subject:subject:to:to; s=fm2; t=
 1699740015; x=1699826415; bh=AIPbfajc+GWu5wRW9Ku2mD471gd5MztiX2u
 wzH7wy18=; b=lsyFcmyb6sF87EE8CqmWdUI/l5DbTQ0V7FtSpledx5SlDyva4ng
 1RezgXVo1MSgj4lQ4S6ezDUzzNCtuPZKRgNjQNoCDvco7qk4TF1y+RSh0e47YJ2b
 escOdOwL18OEaUalvvGalE4qr/FB1njBSnfE6rVfUtMhyOc5KW+lgTGyJriK271x
 /HPNZxI6GIfSZrxqd5rzTigvH3iGlWcCeiihqJruiTeZ9Hi+u+sUdsNNJgqqd+fE
 KlULVcKsvY3W9pzeyejqJx8g6N4k8YEnfCWhN+xVHfdkOHke1hatzMYBMUcpWjQC
 ZdN19tWSSRLkm39iojox25y8tVcXZAKH66Q==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-transfer-encoding
 :content-type:content-type:date:date:feedback-id:feedback-id
 :from:from:in-reply-to:in-reply-to:message-id:mime-version
 :references:reply-to:sender:subject:subject:to:to:x-me-proxy
 :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=
 1699740015; x=1699826415; bh=AIPbfajc+GWu5wRW9Ku2mD471gd5MztiX2u
 wzH7wy18=; b=sBIuOYX1aWv3b4zgyQ2x/SLLL6JLjP4f6aWVtDN37ngN45Nb2M+
 K44w45GDglG4KhEw2LYPwNmix5hgRWfEzLcQOqQ5IEOa67PmHRSsOGggo6WRmEqF
 asCFZLjEHfTgfBWeR0Xu3bJWQweK/Sb3cKvuBKlmYAFEPdadmc0NXvDE80yUQJg2
 M1W3txa+M7Kx2ewhIslnFY6097jFsQOBzw+1pAlsncgQy+o68b/vkpqvklaG+jkB
 6VHhhaHblUPwE4h8bEcHki+hSrt+pUu784T0+AOSfTkDNXS/hsKz5VOL8tscK3lv
 eprFpT6BDheC2a9yxO4fpwc7zq/fIEhmQxg==
X-ME-Sender: <xms:b_lPZRVoJm5zEdZQmMg_AGPf_34rT5g_cYIU7hVNBpNZqCRJcqtnJA>
 <xme:b_lPZRlLL9kVib67SgR-7Ur47t36e9wRFEAPYWvpp9iGWzW62MLNMDWzN9wzY7RBS
 5c28y0fcCjdxfWfCww>
X-ME-Received: <xmr:b_lPZdbHB9dPI_B4WxVr9MzrKuVmdozFz5RF97kZlX-2M3yGYU3JoyQUCygUeg8>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedruddvhedgudehhecutefuodetggdotefrod
 ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
 necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
 enucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomhepffhm
 ihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrg
 htthgvrhhnpeeigfetveehveevffehledtueekieeikeeufeegudfgfeeghfdulefgfeev
 ledvveenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe
 gumhhithhrhiesghhuthhovhdruggvvh
X-ME-Proxy: <xmx:b_lPZUXGBZ7oMT1EqRFAytTVQ_A4U4IAq87ZCvZ6IyYcTv4tojAFwg>
 <xmx:b_lPZbktd1LXxSJIEpOR5ukjO1Vz8F1GE0oMyInHc4Dy24vr7aOBKA>
 <xmx:b_lPZRdKRUVMa32F8PA_lKVeHqvAL-QlWXgYPzefn2p0pvIG68jSbQ>
 <xmx:b_lPZTt1M5OMEvPgkQEkoejiaCZ5u7uX7-ekymcCok8vu9QgxpftVQ>
Feedback-ID: i0e71465a:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat,
 11 Nov 2023 17:00:14 -0500 (EST)
Message-ID: <2eb31324-ae24-db4b-4f62-a0140bfb9f81@HIDDEN>
Date: Sun, 12 Nov 2023 00:00:13 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: bug#67062: 30.0.50; [PATCH] Abbreviate the revision in
 'vc-annotate' (for Git)
Content-Language: en-US
To: Eli Zaretskii <eliz@HIDDEN>, Jim Porter <jporterbugs@HIDDEN>
References: <66fc4912-6aa5-79da-bd6f-52f068cf1a77@HIDDEN>
 <83y1f4wxby.fsf@HIDDEN>
From: Dmitry Gutov <dmitry@HIDDEN>
In-Reply-To: <83y1f4wxby.fsf@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: -2.2 (--)
X-Debbugs-Envelope-To: 67062
Cc: 67062 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.2 (---)

On 11/11/2023 09:41, Eli Zaretskii wrote:
> If this is a Git-only issue, perhaps it would be better to have a
> Git-only option, instead of defining a whole new VC method?

Our general approach is to prefer global options and dynamic dispatch on 
backends, resorting to using per-backend options when it's much easier 
to do.

In this case it might actually be more difficult to go the second route 
since the intention is to only use the short hash in this particular 
place. vc-annotate is common code and it will need to indicate that 
intention to the backend somehow.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67062; Package emacs. Full text available.

Message received at 67062 <at> debbugs.gnu.org:


Received: (at 67062) by debbugs.gnu.org; 11 Nov 2023 21:32:19 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 11 16:32:19 2023
Received: from localhost ([127.0.0.1]:54487 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r1vaU-0008C3-Ot
	for submit <at> debbugs.gnu.org; Sat, 11 Nov 2023 16:32:19 -0500
Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]:49442)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jporterbugs@HIDDEN>) id 1r1vaS-0008Bp-Gs
 for 67062 <at> debbugs.gnu.org; Sat, 11 Nov 2023 16:32:16 -0500
Received: by mail-pl1-x633.google.com with SMTP id
 d9443c01a7336-1cc3bb32b5dso27928985ad.3
 for <67062 <at> debbugs.gnu.org>; Sat, 11 Nov 2023 13:31:35 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1699738290; x=1700343090; darn=debbugs.gnu.org;
 h=content-transfer-encoding:in-reply-to:from:references:cc:to
 :content-language:subject:mime-version:date:message-id:from:to:cc
 :subject:date:message-id:reply-to;
 bh=OgS03/tJ2ZX2N55jJMvXwDM3L0MSeg3pyn12HkHkTPc=;
 b=eQQKU7QSfdKsh0yKAwi5iqWiBhpO9mFI0wtCCCvcSeRwQHP1MkcVsAO+nH7dsvtTN2
 6iW8gvv4fV/XE+56AEkRMiePbE8CAG68UjhvaX/eWs8oLsqEJRIOVLBh0rsMIiQnhFKE
 VZlB8HqnGBFT0lbqhrSigkatzeO4cPEdlrJDmNfTrKmVvufZwWXH1gxB2Btz/DcSHpdh
 hsvDs5PVp3pemIfo5uym7HSz+/rYmUG6OPOE59rdKQwMZaP7YY16+7Gh+DUU68wIMC+m
 xKiUNayD7POjkOt//76vOLAKJXsmDe84MhIbvqLuIS8dhzHL2q5nW4nAjIWraUDxZjg/
 N3HQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1699738290; x=1700343090;
 h=content-transfer-encoding:in-reply-to:from:references:cc:to
 :content-language:subject:mime-version:date:message-id
 :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=OgS03/tJ2ZX2N55jJMvXwDM3L0MSeg3pyn12HkHkTPc=;
 b=T+5zLZ7gkvXWnOwNoYSFl2ZTHxjbsOJCSVNkeXPCVn/GRxEQ8t8rOwZERw9C4yNieQ
 bGHu1QK/9Dop/1lENftSCfK0f6vUxI6q7OEIhyoYrmC2bLG+PGxVE7TGL9Ww7x0SpJ+R
 hFMYwcdpKIk1bfDHutTyQgCAURiIwGH6L3XfSzDV5OrXZaxyw/nZJ2T4t850ARwYp1gr
 4AJZjTuwyfApWYAmEE8gEdBEV0Qg6WWzzEphLeGo7NIztN2ivD4IVEej7h2yAJhy01WV
 eCtkE4NpKw8VT2WrL2Hzy6d0MMFoVbm5Hbv12Sp+Qds51AKDKgAOxlBkIS02YK3+Kv7M
 Y4cw==
X-Gm-Message-State: AOJu0YxOOs4Ds7i/gSkw8GR5QB6CvbRc0k3WkP6VpETpoxtNcBOs+rp8
 Xe8q1cKylfMth76zun72yO9qXkPaXuM=
X-Google-Smtp-Source: AGHT+IEj1W/Cc2eU8QwRUKGoOWnLwcGzhAUa8V0Tev3zEa8mP79tCVuM6ApE6uTifYGtLbQynFhd8Q==
X-Received: by 2002:a17:902:d346:b0:1cc:29ef:df7d with SMTP id
 l6-20020a170902d34600b001cc29efdf7dmr3439580plk.65.1699738289732; 
 Sat, 11 Nov 2023 13:31:29 -0800 (PST)
Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com.
 [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id
 f4-20020a170902e98400b001b9c5e07bc3sm1684594plb.238.2023.11.11.13.31.29
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sat, 11 Nov 2023 13:31:29 -0800 (PST)
Message-ID: <2f659ad5-9bfb-daaf-e63d-580bde689427@HIDDEN>
Date: Sat, 11 Nov 2023 13:31:28 -0800
MIME-Version: 1.0
Subject: Re: bug#67062: 30.0.50; [PATCH] Abbreviate the revision in
 'vc-annotate' (for Git)
Content-Language: en-US
To: Eli Zaretskii <eliz@HIDDEN>
References: <66fc4912-6aa5-79da-bd6f-52f068cf1a77@HIDDEN>
 <83y1f4wxby.fsf@HIDDEN>
From: Jim Porter <jporterbugs@HIDDEN>
In-Reply-To: <83y1f4wxby.fsf@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 67062
Cc: 67062 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On 11/10/2023 11:41 PM, Eli Zaretskii wrote:
>> Date: Fri, 10 Nov 2023 18:49:59 -0800
>> From: Jim Porter <jporterbugs@HIDDEN>
>>
>> Attached is a patch to add a 'short-revision' function for VC backends,
>> and a Git implementation for it.
> 
> If this is a Git-only issue, perhaps it would be better to have a
> Git-only option, instead of defining a whole new VC method?

Perhaps, though I'm not sure the best way to do that. I'll also take a 
look at some other VC backends to see if they could benefit. I usually 
use Git these days, so I haven't tried vc-annotate using a different 
backend.

> In any case, please document whatever is eventually accepted, both in
> NEWS and in the manual.

Definitely. This was just a sketch of a patch to make sure the idea 
makes sense and to get feedback on whether I should do this in a totally 
different way (which would likely require totally different 
documentation too).




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67062; Package emacs. Full text available.

Message received at 67062 <at> debbugs.gnu.org:


Received: (at 67062) by debbugs.gnu.org; 11 Nov 2023 07:42:46 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 11 02:42:46 2023
Received: from localhost ([127.0.0.1]:51425 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r1idi-0008Eu-2R
	for submit <at> debbugs.gnu.org; Sat, 11 Nov 2023 02:42:46 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:39358)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1r1ide-0008Eg-PA
 for 67062 <at> debbugs.gnu.org; Sat, 11 Nov 2023 02:42:44 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1r1icu-0002XC-1H; Sat, 11 Nov 2023 02:41:57 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=mrP6leAcsSrghRsg4l4Bm4OouFWaKGFMrDxond8NelM=; b=gX0/JV9xhq9x
 UlYayftF3cImAw8I0cvDk1sEl8UNwXrwPLNwLdXaejgs8Lnjm+PdJcYaC6ZTFHg58DL7UHUL9rCo6
 1S9YJFDNWaIxGgJrxdUFfTlRaOtf88GbyY1xr6moO7j28ZvmT6SOxk0TTgsyDy9SPddSRB2JByR+Y
 CQ5bStLdm47vm8kiCVOu16bt5pdUoEgLa8/c5GNuSh3GEXfHDGPyAOqmwlHPCaFyjBFGFbZ3ram1b
 GwdyiCPMV9kuaAC6bnzr+Kbi14ywDHZCMgHfWNHYyRn/F5q5kOI0z+iP4cKQVdxcZqa4BIFcfHljp
 g4Jk6a7Q5sLCPPdIhqtdDQ==;
Date: Sat, 11 Nov 2023 09:41:53 +0200
Message-Id: <83y1f4wxby.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Jim Porter <jporterbugs@HIDDEN>
In-Reply-To: <66fc4912-6aa5-79da-bd6f-52f068cf1a77@HIDDEN> (message from
 Jim Porter on Fri, 10 Nov 2023 18:49:59 -0800)
Subject: Re: bug#67062: 30.0.50;
 [PATCH] Abbreviate the revision in 'vc-annotate' (for Git)
References: <66fc4912-6aa5-79da-bd6f-52f068cf1a77@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 67062
Cc: 67062 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Fri, 10 Nov 2023 18:49:59 -0800
> From: Jim Porter <jporterbugs@HIDDEN>
> 
> Attached is a patch to add a 'short-revision' function for VC backends, 
> and a Git implementation for it.

If this is a Git-only issue, perhaps it would be better to have a
Git-only option, instead of defining a whole new VC method?

In any case, please document whatever is eventually accepted, both in
NEWS and in the manual.  (Frankly, I don't understand why patches are
not submitted with documentation to match to begin with.)




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67062; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 11 Nov 2023 02:50:54 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 10 21:50:54 2023
Received: from localhost ([127.0.0.1]:51289 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r1e5F-0000NT-Ub
	for submit <at> debbugs.gnu.org; Fri, 10 Nov 2023 21:50:54 -0500
Received: from lists.gnu.org ([2001:470:142::17]:56528)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jporterbugs@HIDDEN>) id 1r1e5B-0000NC-JT
 for submit <at> debbugs.gnu.org; Fri, 10 Nov 2023 21:50:52 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <jporterbugs@HIDDEN>)
 id 1r1e4R-0002mP-Jx
 for bug-gnu-emacs@HIDDEN; Fri, 10 Nov 2023 21:50:03 -0500
Received: from mail-oa1-x2d.google.com ([2001:4860:4864:20::2d])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <jporterbugs@HIDDEN>)
 id 1r1e4P-0002eV-Oh
 for bug-gnu-emacs@HIDDEN; Fri, 10 Nov 2023 21:50:03 -0500
Received: by mail-oa1-x2d.google.com with SMTP id
 586e51a60fabf-1ef370c2e12so1486366fac.1
 for <bug-gnu-emacs@HIDDEN>; Fri, 10 Nov 2023 18:50:01 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1699671000; x=1700275800; darn=gnu.org;
 h=to:subject:from:content-language:mime-version:date:message-id:from
 :to:cc:subject:date:message-id:reply-to;
 bh=CgQo9LdV9iSr+lDPyaKVodRFOlODLlx+u4oAPLA9VLw=;
 b=izrCyFABj30U2CXMOWo2EAw6QlE2DQDfGTNdUES5cy9cLBuYUwmLBN/0CDDTJqTAW2
 iRj6abeDfiWOekCxhvHNuA//+zY64ggTSe+g7ZS+HJbkbjAfncV/Vdamn+HTWIXSyjNh
 D5r5lSR7kVBndfn6p+ODI78H2cFVhdXr9NTPKwRhv82Rcp41Tm1PPKnWKuRxKMR3/6af
 hipPg8/EZWnt6KRBbwIsY0RVVVZLLoHI4NRIlH95K+UmoIplqEGjfhtUKvWJ4YVseD0J
 p7kR6yXTBJZebZZi9Lt3mGw9DqdDrWhFRIlSPVUObCuLO9mhL2IX5mtho0PyrjRRh0CO
 cFNg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1699671000; x=1700275800;
 h=to:subject:from:content-language:mime-version:date:message-id
 :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=CgQo9LdV9iSr+lDPyaKVodRFOlODLlx+u4oAPLA9VLw=;
 b=FgHqcomRSkzTYgOnHvoYDUTzNpvWXdbBdJyDxrb9Zl7qP+OLUhDMMLLhHrfr2ciNlt
 nMpj8Ey6JjNnUOHuzlv5wzP6AOgLSft4RsOzzl4KzY7F1yB2ps8F1AsPD/aU0Kcc3jPG
 HTXi51B+2CKJsD0wHATyH9o3QkAH3f3lDZNi070CnhbR1O5CGksJ4rF4VyPd2hNzUtVO
 Q9PXv9So7WucI3gFZImEyDdteOMYhgPXJWit0YvDVQ+COQ0Boo8gF8lfpQaDLtA86PB8
 x0Cq0S9OIEqvE5oVpJ54mm2weDidosPFofBj3b7xSd00qZC095t/n0FrJJFug61bUSGb
 ywUw==
X-Gm-Message-State: AOJu0YxH9p0eaduSbdx0sKTOfaPp8UvPi/D/o4cirK4C+USMw5DDi0U5
 0UI6LPWPOAHwpPVhJ6NtgYRfQGJfYik=
X-Google-Smtp-Source: AGHT+IHJCXk9cnstNODVb6VsXGFPy6IeE4YD6svDnZG8wlprOdZTrayRT2varZNmfsyizRJA2rJE7Q==
X-Received: by 2002:a05:6870:d0c6:b0:1bb:509a:824f with SMTP id
 k6-20020a056870d0c600b001bb509a824fmr1313358oaa.55.1699670999925; 
 Fri, 10 Nov 2023 18:49:59 -0800 (PST)
Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com.
 [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id
 5-20020a17090a19c500b0026f39c90111sm489817pjj.20.2023.11.10.18.49.58
 for <bug-gnu-emacs@HIDDEN>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 10 Nov 2023 18:49:59 -0800 (PST)
Content-Type: multipart/mixed; boundary="------------r0mWTxxpCVyAoQHXsdzsz4pC"
Message-ID: <66fc4912-6aa5-79da-bd6f-52f068cf1a77@HIDDEN>
Date: Fri, 10 Nov 2023 18:49:59 -0800
MIME-Version: 1.0
X-Mozilla-News-Host: news://news.gmane.io:119
Content-Language: en-US
From: Jim Porter <jporterbugs@HIDDEN>
Subject: 30.0.50; [PATCH] Abbreviate the revision in 'vc-annotate' (for Git)
To: bug-gnu-emacs@HIDDEN
Received-SPF: pass client-ip=2001:4860:4864:20::2d;
 envelope-from=jporterbugs@HIDDEN; helo=mail-oa1-x2d.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

This is a multi-part message in MIME format.
--------------r0mWTxxpCVyAoQHXsdzsz4pC
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Currently, when running 'vc-annotate' for a Git repo, the buffer name is 
very long: it has the form "*Annotate FILE (rev REVISION)*", and for 
Git, REVISION is 40(?) characters long. Seeing the full Git SHA isn't 
(in my opinion) useful, especially not in a space-limited area like the 
mode line. At the default width of 80 columns, this pushes much of the 
mode line information off-screen.

Attached is a patch to add a 'short-revision' function for VC backends, 
and a Git implementation for it.

Does this make sense? Should there be an option to restore the previous 
behavior? (I'm not sure why anyone would *want* the old behavior, but 
I'm not opposed to adding an option.)
--------------r0mWTxxpCVyAoQHXsdzsz4pC
Content-Type: text/plain; charset=UTF-8;
 name="0001-Abbreviate-the-VC-revision-in-vc-annotate-s-buffer-n.patch"
Content-Disposition: attachment;
 filename*0="0001-Abbreviate-the-VC-revision-in-vc-annotate-s-buffer-n.pa";
 filename*1="tch"
Content-Transfer-Encoding: base64

RnJvbSA5MTAzYWE2NGI2NGQwYTc5ODM1YzA3MjA4NmQwNDA3MzRkZGYxYzJhIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j
b20+CkRhdGU6IEZyaSwgMTAgTm92IDIwMjMgMTg6NDI6MjkgLTA4MDAKU3ViamVjdDogW1BB
VENIXSBBYmJyZXZpYXRlIHRoZSBWQyByZXZpc2lvbiBpbiB2Yy1hbm5vdGF0ZSdzIGJ1ZmZl
ciBuYW1lCgoqIGxpc3AvdmMvdmMtYW5ub3RhdGUuZWwgKHZjLWFubm90YXRlKTogQ2FsbCAn
c2hvcnQtcmV2aXNpb24nCgoqIGxpc3AvdmMvdmMtaG9va3MuZWwgKHZjLWRlZmF1bHQtc2hv
cnQtcmV2aXNpb24pOiBOZXcgZnVuY3Rpb24uCgoqIGxpc3AvdmMvdmMtZ2l0LmVsICh2Yy1n
aXQtc2hvcnQtcmV2aXNpb24pOiBOZXcgZnVuY3Rpb24uCih2Yy1naXQtLXJldi1wYXJzZSk6
IE5ldyBvcHRpb25hbCBhcmd1bWVudCBTSE9SVC4KLS0tCiBsaXNwL3ZjL3ZjLWFubm90YXRl
LmVsIHwgIDQgKysrLQogbGlzcC92Yy92Yy1naXQuZWwgICAgICB8IDE0ICsrKysrKysrKysr
LS0tCiBsaXNwL3ZjL3ZjLWhvb2tzLmVsICAgIHwgIDUgKysrKysKIDMgZmlsZXMgY2hhbmdl
ZCwgMTkgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNw
L3ZjL3ZjLWFubm90YXRlLmVsIGIvbGlzcC92Yy92Yy1hbm5vdGF0ZS5lbAppbmRleCBkZTZj
M2FkYmJkYi4uODUxNjEzNDdjYmYgMTAwNjQ0Ci0tLSBhL2xpc3AvdmMvdmMtYW5ub3RhdGUu
ZWwKKysrIGIvbGlzcC92Yy92Yy1hbm5vdGF0ZS5lbApAQCAtNDA5LDcgKzQwOSw5IEBAIHZj
LWFubm90YXRlCiAJCQkJICBuaWwgbmlsICIyMCIpKSkpKSkpCiAgICh2Yy1lbnN1cmUtdmMt
YnVmZmVyKQogICAoc2V0cSB2Yy1hbm5vdGF0ZS1kaXNwbGF5LW1vZGUgZGlzcGxheS1tb2Rl
KSA7Tm90IHN1cmUgd2h5LiAgLS1TdGVmCi0gIChsZXQqICgodGVtcC1idWZmZXItbmFtZSAo
Zm9ybWF0ICIqQW5ub3RhdGUgJXMgKHJldiAlcykqIiAoYnVmZmVyLW5hbWUpIHJldikpCisg
IChsZXQqICgodGVtcC1idWZmZXItbmFtZSAoZm9ybWF0ICIqQW5ub3RhdGUgJXMgKHJldiAl
cykqIiAoYnVmZmVyLW5hbWUpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICh2Yy1jYWxsLWJhY2tlbmQgKHZjLWJhY2tlbmQgZmlsZSkKKyAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnc2hvcnQtcmV2aXNpb24gcmV2
KSkpCiAgICAgICAgICAodGVtcC1idWZmZXItc2hvdy1mdW5jdGlvbiAndmMtYW5ub3RhdGUt
ZGlzcGxheS1zZWxlY3QpCiAgICAgICAgICA7OyBJZiBCVUYgaXMgc3BlY2lmaWVkLCB3ZSBw
cmVzdW1lIHRoZSBjYWxsZXIgbWFpbnRhaW5zIGN1cnJlbnQgbGluZSwKICAgICAgICAgIDs7
IHNvIHdlIGRvbid0IG5lZWQgdG8gZG8gaXQgaGVyZS4gIFRoaXMgaW1wbGVtZW50YXRpb24g
bWF5IGdpdmUKZGlmZiAtLWdpdCBhL2xpc3AvdmMvdmMtZ2l0LmVsIGIvbGlzcC92Yy92Yy1n
aXQuZWwKaW5kZXggNzA3ZmM3Y2ZjMDcuLjJmZjZmNTU2NGVkIDEwMDY0NAotLS0gYS9saXNw
L3ZjL3ZjLWdpdC5lbAorKysgYi9saXNwL3ZjL3ZjLWdpdC5lbApAQCAtNDAzLDYgKzQwMywx
MSBAQCB2Yy1naXQtd29ya2luZy1yZXZpc2lvbgogICAobGV0IChwcm9jZXNzLWZpbGUtc2lk
ZS1lZmZlY3RzKQogICAgICh2Yy1naXQtLXJldi1wYXJzZSAiSEVBRCIpKSkKIAorKGRlZnVu
IHZjLWdpdC1zaG9ydC1yZXZpc2lvbiAocmV2KQorICAiR2l0LXNwZWNpZmljIHZlcnNpb24g
b2YgYHZjLXNob3J0LXJldmlzaW9uJy4iCisgIChsZXQgKHByb2Nlc3MtZmlsZS1zaWRlLWVm
ZmVjdHMpCisgICAgKHZjLWdpdC0tcmV2LXBhcnNlIHJldiAnc2hvcnQpKSkKKwogKGRlZnVu
IHZjLWdpdC0tc3ltYm9saWMtcmVmIChmaWxlKQogICAob3IKICAgICh2Yy1maWxlLWdldHBy
b3AgZmlsZSAndmMtZ2l0LXN5bWJvbGljLXJlZikKQEAgLTE4MzAsMTEgKzE4MzUsMTQgQEAg
dmMtZ2l0LXByZXZpb3VzLXJldmlzaW9uCiAgICAgOzsgZG9lcyBub3QgKGFuZCBjYW5ub3Qp
IHF1b3RlLgogICAgICh2Yy1naXQtLXJldi1wYXJzZSAoY29uY2F0IHJldiAifjEiKSkpKQog
Ci0oZGVmdW4gdmMtZ2l0LS1yZXYtcGFyc2UgKHJldikKKyhkZWZ1biB2Yy1naXQtLXJldi1w
YXJzZSAocmV2ICZvcHRpb25hbCBzaG9ydCkKICAgKHdpdGgtdGVtcC1idWZmZXIKICAgICAo
YW5kCi0gICAgICh2Yy1naXQtLW91dC1vayAicmV2LXBhcnNlIiByZXYpCi0gICAgIChidWZm
ZXItc3Vic3RyaW5nLW5vLXByb3BlcnRpZXMgKHBvaW50LW1pbikgKCsgKHBvaW50LW1pbikg
NDApKSkpKQorICAgICAoYXBwbHkgIyd2Yy1naXQtLW91dC1vayAicmV2LXBhcnNlIgorICAg
ICAgICAgICAgKGFwcGVuZCAod2hlbiBzaG9ydCAnKCItLXNob3J0IikpCisgICAgICAgICAg
ICAgICAgICAgIChsaXN0IHJldikpKQorICAgICAoZ290by1jaGFyIChwb2ludC1taW4pKQor
ICAgICAoYnVmZmVyLXN1YnN0cmluZy1uby1wcm9wZXJ0aWVzIChwb2ludCkgKHBvcy1lb2wp
KSkpKQogCiAoZGVmdW4gdmMtZ2l0LW5leHQtcmV2aXNpb24gKGZpbGUgcmV2KQogICAiR2l0
LXNwZWNpZmljIHZlcnNpb24gb2YgYHZjLW5leHQtcmV2aXNpb24nLiIKZGlmZiAtLWdpdCBh
L2xpc3AvdmMvdmMtaG9va3MuZWwgYi9saXNwL3ZjL3ZjLWhvb2tzLmVsCmluZGV4IGMxNmZi
NjNiMmZmLi4zOGM4NGEwY2VlYSAxMDA2NDQKLS0tIGEvbGlzcC92Yy92Yy1ob29rcy5lbAor
KysgYi9saXNwL3ZjL3ZjLWhvb2tzLmVsCkBAIC01MDIsNiArNTAyLDExIEBAIHZjLXdvcmtp
bmctcmV2aXNpb24KICAgICAgICAgICAgICAgICAgICAgICAgICAgICh2Yy1jYWxsLWJhY2tl
bmQKICAgICAgICAgICAgICAgICAgICAgICAgICAgICBiYWNrZW5kICd3b3JraW5nLXJldmlz
aW9uIGZpbGUpKSkpKSkKIAorKGRlZnVuIHZjLWRlZmF1bHQtc2hvcnQtcmV2aXNpb24gKF9i
YWNrZW5kIHJldikKKyAgIlJldHVybiBhIFwic2hvcnRlbmVkXCIgdmVyc2lvbiBvZiB0aGUg
cmV2aXNpb24gUkVWLgorVGhpcyBkZWZhdWx0IGltcGxlbWVudGF0aW9uIHNpbXBseSByZXR1
cm5zIFJFViB1bmNoYW5nZWQuIgorICByZXYpCisKIChkZWZ1biB2Yy1kZWZhdWx0LXJlZ2lz
dGVyZWQgKGJhY2tlbmQgZmlsZSkKICAgIkNoZWNrIGlmIEZJTEUgaXMgcmVnaXN0ZXJlZCBp
biBCQUNLRU5EIHVzaW5nIHZjLUJBQ0tFTkQtbWFzdGVyLXRlbXBsYXRlcy4iCiAgIChsZXQg
KChzeW0gKHZjLW1ha2UtYmFja2VuZC1zeW0gYmFja2VuZCAnbWFzdGVyLXRlbXBsYXRlcykp
KQotLSAKMi4yNS4xCgo=

--------------r0mWTxxpCVyAoQHXsdzsz4pC--




Acknowledgement sent to Jim Porter <jporterbugs@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#67062; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Mon, 13 Nov 2023 07:15:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.