GNU bug report logs - #67123
[PATCH] gnu: Add pass-coffin

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 67123 in the body.
You can then email your comments to 67123 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christian Miller <christian.miller <at> dadoes.de>
To: guix-patches <at> gnu.org
Cc: Christian Miller <christian.miller <at> dadoes.de>
Subject: [PATCH] gnu: Add pass-coffin
Date: Sat, 11 Nov 2023 19:41:22 +0100

* gnu/packages/password-utils.scm (pass-coffin): New variable.

Change-Id: I2fdf6c755b9b75780c5a3c0304e5b961a15640a4
---
 gnu/packages/password-utils.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/password-utils.scm b/gnu/packages/password-utils.scm
index 385bd64985..f9767b91af 100644
--- a/gnu/packages/password-utils.scm
+++ b/gnu/packages/password-utils.scm
@@ -39,6 +39,7 @@
 ;;; Copyright © 2022 ( <paren <at> disroot.org>
 ;;; Copyright © 2022 Nicolas Graves <ngraves <at> ngraves.fr>
 ;;; Copyright © 2022 Petr Hodina <phodina <at> protonmail.com>
+;;; Copyright © 2023 Christian Miller <christian.miller <at> dadoes.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1567,6 +1568,37 @@ (define-public pass-tomb
 pass-tomb to automatically close your store after a given time.")
     (license license:gpl3+)))
 
+(define-public pass-coffin
+  (package
+    (name "pass-coffin")
+    (version "1.2.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/ayushnix/pass-coffin")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1486ikwsdjsj74qf949vk47r8mfp2mbbdc3scs8786nnnkhzc89n"))))
+    (build-system gnu-build-system)
+    (arguments
+     (list
+      #:tests? #f ;No tests
+      #:make-flags #~(list (string-append "PREFIX="
+                                          #$output)
+                           (string-append "BASHCOMPDIR="
+                                          #$output "/etc/bash_completion.d"))
+      #:phases #~(modify-phases %standard-phases
+                   (delete 'configure))))
+    (inputs (list password-store tar))
+    (home-page "https://github.com/ayushnix/pass-coffin")
+    (synopsis "Pass extension to keep the tree of passwords encrypted")
+    (description
+     "Pass-coffin is a pass extension that hides the password store
+data inside a GPG encrypted file, which we'll call a coffin.")
+    (license license:gpl3)))
+
 (define-public xkcdpass
   (package
     (name "xkcdpass")

base-commit: af6105afc67a15a491a0a4fd18a28c9f801a0b94
-- 
2.41.0

Message #10 received at 67123 <at> debbugs.gnu.org (full text, mbox):

From: Steve George <steve <at> futurile.net>
To: 67123 <at> debbugs.gnu.org
Cc: Steve George <steve <at> futurile.net>, guix-patches <at> gnu.org
Subject: [PATCH v2 1/1] gnu: Add pass-coffin
Date: Sat, 24 Feb 2024 08:39:34 +0000

From: Christian Miller via Guix-patches via <guix-patches <at> gnu.org>

* gnu/packages/password-utils.scm (pass-coffin): New variable.

Reviewed-by: Steve George <steve <at> futurile.net>

Change-Id: I2fdf6c755b9b75780c5a3c0304e5b961a15640a4
---
 gnu/packages/password-utils.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/password-utils.scm b/gnu/packages/password-utils.scm
index b79fdfc6a0f..09be72cfa6b 100644
--- a/gnu/packages/password-utils.scm
+++ b/gnu/packages/password-utils.scm
@@ -39,6 +39,7 @@
 ;;; Copyright © 2022 ( <paren <at> disroot.org>
 ;;; Copyright © 2022 Nicolas Graves <ngraves <at> ngraves.fr>
 ;;; Copyright © 2022 Petr Hodina <phodina <at> protonmail.com>
+;;; Copyright © 2023 Christian Miller <christian.miller <at> dadoes.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1562,6 +1563,37 @@ (define-public pass-tomb
 pass-tomb to automatically close your store after a given time.")
     (license license:gpl3+)))
 
+(define-public pass-coffin
+  (package
+    (name "pass-coffin")
+    (version "1.2.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/ayushnix/pass-coffin")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1486ikwsdjsj74qf949vk47r8mfp2mbbdc3scs8786nnnkhzc89n"))))
+    (build-system gnu-build-system)
+    (arguments
+     (list
+      #:tests? #f ;No tests
+      #:make-flags #~(list (string-append "PREFIX="
+                                          #$output)
+                           (string-append "BASHCOMPDIR="
+                                          #$output "/etc/bash_completion.d"))
+      #:phases #~(modify-phases %standard-phases
+                   (delete 'configure))))
+    (inputs (list password-store tar))
+    (home-page "https://github.com/ayushnix/pass-coffin")
+    (synopsis "Pass extension to keep the tree of passwords encrypted")
+    (description
+     "Pass-coffin is a pass extension that hides the password store
+data inside a GPG encrypted file, which we'll call a coffin.")
+    (license license:gpl3)))
+
 (define-public xkcdpass
   (package
     (name "xkcdpass")
-- 
2.41.0

Message #13 received at 67123 <at> debbugs.gnu.org (full text, mbox):

From: Steve George <steve <at> futurile.net>
To: 67123 <at> debbugs.gnu.org
Cc: Steve George <steve <at> futurile.net>, guix-patches <at> gnu.org
Subject: [PATCH v2 0/1] gnu: Add pass-coffin
Date: Sat, 24 Feb 2024 08:39:33 +0000

Review by Steve George: 
  * submission: checked commit format, synopsis and commit
  * submission: license, patch applies cleanly
  * functionality: test installed, guix lint is clean
  * code: checked style
  * added: Reviewed-by commit trailer
  * re-roll to trigger QA build

  * Question for committer: this is an add-on to password-store and can't be
    used without it. Should password-store be a propagated-input?


Christian Miller via Guix-patches via (1):
  gnu: Add pass-coffin

 gnu/packages/password-utils.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)


base-commit: e7990b12170eec0c35541196f948be26a9e4a519
-- 
2.41.0

Message #22 received at 67123 <at> debbugs.gnu.org (full text, mbox):

From: Clément Lassieur <clement <at> lassieur.org>
To: Steve George <steve <at> futurile.net>
Cc: 67123 <at> debbugs.gnu.org
Subject: Re: [bug#67123] [PATCH v2 0/1] gnu: Add pass-coffin
Date: Sat, 24 Feb 2024 11:23:17 +0100

On Sat, Feb 24 2024, Steve George wrote:

> Review by Steve George: 
>   * submission: checked commit format, synopsis and commit
>   * submission: license, patch applies cleanly
>   * functionality: test installed, guix lint is clean
>   * code: checked style
>   * added: Reviewed-by commit trailer
>   * re-roll to trigger QA build
>
>   * Question for committer: this is an add-on to password-store and can't be
>     used without it. Should password-store be a propagated-input?

I don't think so.  See emacs for example.  That would make it harder to
use another version of password-store.

> Christian Miller via Guix-patches via (1):
>   gnu: Add pass-coffin
>
>  gnu/packages/password-utils.scm | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
>
>
> base-commit: e7990b12170eec0c35541196f948be26a9e4a519

Message #27 received at 67123-done <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: 67123-done <at> debbugs.gnu.org
Subject: Close
Date: Mon, 26 Feb 2024 16:51:31 +0100

Hello,

like Clément, I would say we should not propagate password-store.
It would also create a weird situation when people install password-store
with one revision of Guix, and add this extension from a different revision.
More generally, password-store in a profile and from the propagated input
could clash, and it would be surprising if installing an extension swaps
the main program under your feet.

Applied, thanks for the patch and the review!

Andreas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.