GNU bug report logs - #67133
[PATCH] Fix CBZ file detection in doc-view-mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 67133 in the body.
You can then email your comments to 67133 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Morgan Smith <Morgan.J.Smith <at> outlook.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix CBZ file detection in doc-view-mode
Date: Sun, 12 Nov 2023 12:40:35 -0500

[Message part 1 (text/plain, inline)]

Tags: patch

When opening a CBZ file I get the message "doc-view-set-doc-type:
Conflicting types: name says (cbz) but content says (epub odf)".

Looking at the end of `doc-view-set-doc-type` (lisp/doc-view.el:2141)
it's pretty obvious why and it has an easy fix.  In fact we already did
this fix once before for ODF files as you can see at bug#54947 which
resulted in commit b3ff4905388834994ff26d9d033d6bc62b094c1c



In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.37, cairo version 1.16.0)
System Description: Guix System

Configured using:
 'configure
CONFIG_SHELL=/gnu/store/v9p25q9l5nnaixkhpap5rnymmwbhf9rp-bash-minimal-5.1.16/bin/bash
SHELL=/gnu/store/v9p25q9l5nnaixkhpap5rnymmwbhf9rp-bash-minimal-5.1.16/bin/bash
--prefix=/gnu/store/zfggiiqcxwzb5v48fb6cjkznvcwa12v8-emacs-next-pgtk-git.2117490
--enable-fast-install --with-pgtk --with-cairo --with-modules
--with-native-compilation=aot --disable-build-details'

[0001-Fix-CBZ-file-detection-in-doc-view-mode.patch (text/patch, attachment)]

Message #8 received at 67133 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Morgan Smith <Morgan.J.Smith <at> outlook.com>, Tassilo Horn <tsdh <at> gnu.org>
Cc: 67133 <at> debbugs.gnu.org
Subject: Re: bug#67133: [PATCH] Fix CBZ file detection in doc-view-mode
Date: Wed, 15 Nov 2023 15:12:57 +0200

> From: Morgan Smith <Morgan.J.Smith <at> outlook.com>
> Date: Sun, 12 Nov 2023 12:40:35 -0500
> 
> When opening a CBZ file I get the message "doc-view-set-doc-type:
> Conflicting types: name says (cbz) but content says (epub odf)".
> 
> Looking at the end of `doc-view-set-doc-type` (lisp/doc-view.el:2141)
> it's pretty obvious why and it has an easy fix.  In fact we already did
> this fix once before for ODF files as you can see at bug#54947 which
> resulted in commit b3ff4905388834994ff26d9d033d6bc62b094c1c

Tassilo, any comments on this?

Thanks.

Message #13 received at 67133-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Tassilo Horn <tsdh <at> gnu.org>
Cc: Morgan.J.Smith <at> outlook.com, 67133-done <at> debbugs.gnu.org
Subject: Re: bug#67133: [PATCH] Fix CBZ file detection in doc-view-mode
Date: Wed, 15 Nov 2023 19:10:03 +0200

> From: Tassilo Horn <tsdh <at> gnu.org>
> Cc: Eli Zaretskii <eliz <at> gnu.org>
> Date: Wed, 15 Nov 2023 16:43:53 +0100
> 
> Morgan Smith <Morgan.J.Smith <at> outlook.com> writes:
> 
> Hi Morgan & Eli,
> 
> > Tags: patch
> >
> > When opening a CBZ file I get the message "doc-view-set-doc-type:
> > Conflicting types: name says (cbz) but content says (epub odf)".
> 
> I approve this patch.  Feel free to commit it where you see fit.

Thanks, installed on the emacs-29 branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.