GNU bug report logs - #67161
30.0.50; [PATCH] Add option `dired-filename-display-length'

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Reported by: Liu Hui <liuhui1610@HIDDEN>; Keywords: patch; Done: Eli Zaretskii <eliz@HIDDEN>; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 67161 <at> debbugs.gnu.org:


Received: (at 67161) by debbugs.gnu.org; 26 Nov 2023 06:00:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 26 01:00:06 2023
Received: from localhost ([127.0.0.1]:40638 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r78BZ-0004q8-Kw
	for submit <at> debbugs.gnu.org; Sun, 26 Nov 2023 01:00:06 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:60556)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1r78BX-0004fK-Dz
 for 67161 <at> debbugs.gnu.org; Sun, 26 Nov 2023 01:00:03 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1r78BJ-0006L6-HL; Sun, 26 Nov 2023 00:59:51 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=YsJm7ACef06kKdPgbc0gqlxy8MKxtyVQrt5tngRh/1s=; b=Glui6/YoExhXofP9+VJY
 9Pt4df2kHG7+ZiQsB83SW+/NWLsTdXANoO7JPQMhVLeoW8BM2Se/GhGTT4PBwTOj39HDQD6voRxUj
 sZZiyiWe0IPPE7wzuYzpFEwxekfj8wIYSNMNrVQJ+XbQWzymBD6vJQtFgL0G81xok7jNnfi3m9l81
 YbDga+c7IZlBNBqAVJdK9/cGjWnfHFBFVLCt8LTfBxwFvKV+o+HUZVd12/RvhrdKOecQLDa6652Sg
 vMUJ7ULU5DdMxBACM3x9JrgXt/I5Mme3w3tw6dBIWbrrAwTAbsi1kEkPyio2wxr2ijZRrzxaUQ7ef
 x+uTC2cyCuMEeQ==;
Date: Sun, 26 Nov 2023 07:59:29 +0200
Message-Id: <83edgdawce.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Liu Hui <liuhui1610@HIDDEN>, Stefan Monnier <monnier@HIDDEN>
In-Reply-To: <CAOQTW-PSmLviOP6mJfg-BxQ50D2Y0naMXWMb+t9hnK_k=sbd+g@HIDDEN>
 (message from Liu Hui on Sun, 26 Nov 2023 10:56:52 +0800)
Subject: Re: bug#67161: 30.0.50;
 [PATCH] Add option `dired-filename-display-length'
References: <CAOQTW-MSpBK4ACpLk8U2m6HJx8HXw21O0kyYZ-i85ETNjyOUcA@HIDDEN>
 <8334x8tqi9.fsf@HIDDEN>
 <CAOQTW-P4+vs+JH8BTL8fL-d1QJXOdYq3i+3O7tALTDs=qHpnzA@HIDDEN>
 <83a5rfrych.fsf@HIDDEN>
 <CAOQTW-M5VaV0Va+ixd2-6SoKb4tPebxviobOB8Qs3Oxb9js9GA@HIDDEN>
 <83sf55q4nc.fsf@HIDDEN>
 <CAOQTW-MhVkj5LBYeguWKE6FsVgovdD0wuEW5bHZdy=01maXW1w@HIDDEN>
 <83jzqfmiuj.fsf@HIDDEN>
 <CAOQTW-NN=nmvs5j6_AwMyrA8v9Zuo_vbn9KNKXPPsfn+J25gGA@HIDDEN>
 <CAOQTW-OguzdSKKKm=UR5A+Kr=Z0FHSJE45a22yvRJiEf2Z-yuA@HIDDEN>
 <83jzq6cdfx.fsf@HIDDEN> <86y1elzq58.fsf@HIDDEN>
 <83lealbnz5.fsf@HIDDEN>
 <CAOQTW-PSmLviOP6mJfg-BxQ50D2Y0naMXWMb+t9hnK_k=sbd+g@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 67161
Cc: 67161 <at> debbugs.gnu.org, juri@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Liu Hui <liuhui1610@HIDDEN>
> Date: Sun, 26 Nov 2023 10:56:52 +0800
> Cc: Juri Linkov <juri@HIDDEN>, 67161 <at> debbugs.gnu.org
> 
> Eli Zaretskii <eliz@HIDDEN> 于2023年11月26日周日 04:02写道:
> 
> > Does the below fix the problem, and is the Dired display after the
> > change correct when file names are truncated?
> >
> > diff --git a/lisp/dired.el b/lisp/dired.el
> > index 23a6fc0..096d6a8 100644
> > --- a/lisp/dired.el
> > +++ b/lisp/dired.el
> > @@ -2021,8 +2021,12 @@ dired--get-ellipsis-length
> >    (let* ((dt (or (window-display-table)
> >                   buffer-display-table
> >                   standard-display-table))
> > -         (glyphs (and dt (display-table-slot dt 'selective-display))))
> > -    (string-width (if glyphs (concat glyphs) "..."))))
> > +         (glyphs (and dt (display-table-slot dt 'selective-display)))
> > +         (vlen (length glyphs))
> > +         (char-glyphs (make-vector vlen nil)))
> > +    (dotimes (i vlen)
> > +      (aset char-glyphs i (glyph-char (aref glyphs i))))
> > +    (string-width (if glyphs (concat char-glyphs) "..."))))
> >
> >  (defun dired--get-filename-display-length ()
> >    "Return maximum display length of filename.
> 
> Thanks Eli! I wasn't aware of the face of glyph and I confirm the
> dired display is correct with your fix.

Thanks for testing.

However, I'm beginning to think that this is a subtle misfeature in
'concat': it should support vector of glyphs with faces, and should
preserve the face information (my patch simply discards faces, which
could perhaps affect string-width result).

So I think we should perhaps extend 'concat' to support vectors of
glyphs with faces.  Stefan, WDYT?




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67161; Package emacs. Full text available.

Message received at 67161 <at> debbugs.gnu.org:


Received: (at 67161) by debbugs.gnu.org; 26 Nov 2023 02:57:17 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 25 21:57:17 2023
Received: from localhost ([127.0.0.1]:40549 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r75Kf-0007a1-BH
	for submit <at> debbugs.gnu.org; Sat, 25 Nov 2023 21:57:17 -0500
Received: from mail-vk1-xa30.google.com ([2607:f8b0:4864:20::a30]:52716)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <liuhui1610@HIDDEN>) id 1r75Kd-0007Zn-0I
 for 67161 <at> debbugs.gnu.org; Sat, 25 Nov 2023 21:57:15 -0500
Received: by mail-vk1-xa30.google.com with SMTP id
 71dfb90a1353d-4ac023c8f82so1035840e0c.1
 for <67161 <at> debbugs.gnu.org>; Sat, 25 Nov 2023 18:57:09 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1700967424; x=1701572224; darn=debbugs.gnu.org;
 h=content-transfer-encoding:cc:to:subject:message-id:date:from
 :in-reply-to:references:mime-version:from:to:cc:subject:date
 :message-id:reply-to;
 bh=pH/SZpe18lvAxvFDMv+ScfPmjBBZ40gWd6JXFYFSpkU=;
 b=Zk1944631H4zD7rshrTGmiEOFgjhdV5SabyWxAn4H2KoJD/MsGYnh0XigAsFOdFeHx
 Hy5cVftcYznxK5BS1UZ37D+y4KfHHifDQA7EJUCoixNgqzflevZvj8eIvQgZ3U0RpQ48
 wGk+4xyXNnt4VPVg0euzHSU1AV3uetdCbx4iBDjHJIZuI9CjbfpvYYNLIxKdRkyEsAcx
 23ym/uziY/cWWB1MYoaQOpg3blIfzJbLEefygLm2ubI0wYEeMOsMyTOhax3cuZcUcxyc
 Hn0tJnTopTYNpk7SNWCL9cEHtUCLKuCPntZ94cr36YJxET5ymkj1a0r0wRtGJNdBvKdC
 4WmQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1700967424; x=1701572224;
 h=content-transfer-encoding:cc:to:subject:message-id:date:from
 :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=pH/SZpe18lvAxvFDMv+ScfPmjBBZ40gWd6JXFYFSpkU=;
 b=X6EFRPNekmEr5/79eL2xq0Kp1ecF/mlDKu8z+PG+8DTTUIjeO/DemzKtCN8HE6+8Xt
 eDSIB2ny2SDa2dakZnWZP6quzDQlPLfzZ799/d6fp9e4/58JNuzh8LugmyKsw/gBQp3g
 t+/gar9jllm6DMHzkN91bdbPd/iR4bdmkNm5l7l3lk5YCNiPjEp2esyL0kkPOAXN2TB7
 pVDVW73UJr0dPyateH8N5zhaINhBzFUr4tBYj1SGEE3KAXI/wPofxSju5vetFFu35rXw
 YCkhQNO/pmnmwNR2CrA6ALEqVBklZVc15eSSvwuwDVa/jKXnctSuvf15vA9erAtyIMmL
 TFHQ==
X-Gm-Message-State: AOJu0YyrUjRQJG065CNN/eZLpb0hyDSt70E68qlLUcK4DaYKpq22+LrJ
 CdEZ3y+q5w1fZJvl7HzKjcRUPn8eP4fqyewZ8HU=
X-Google-Smtp-Source: AGHT+IHFvlM/3K/SedmoqeT3RAJGWAkKXsOSBU264fcNN9LkJNZfubQeq5hGLl7Je0dbXapWrm8nkAL3Z3U1XBRjbx4=
X-Received: by 2002:a67:cf4a:0:b0:462:9b33:fce5 with SMTP id
 f10-20020a67cf4a000000b004629b33fce5mr7851283vsm.13.1700967423794; Sat, 25
 Nov 2023 18:57:03 -0800 (PST)
MIME-Version: 1.0
References: <CAOQTW-MSpBK4ACpLk8U2m6HJx8HXw21O0kyYZ-i85ETNjyOUcA@HIDDEN>
 <8334x8tqi9.fsf@HIDDEN>
 <CAOQTW-P4+vs+JH8BTL8fL-d1QJXOdYq3i+3O7tALTDs=qHpnzA@HIDDEN>
 <83a5rfrych.fsf@HIDDEN>
 <CAOQTW-M5VaV0Va+ixd2-6SoKb4tPebxviobOB8Qs3Oxb9js9GA@HIDDEN>
 <83sf55q4nc.fsf@HIDDEN>
 <CAOQTW-MhVkj5LBYeguWKE6FsVgovdD0wuEW5bHZdy=01maXW1w@HIDDEN>
 <83jzqfmiuj.fsf@HIDDEN>
 <CAOQTW-NN=nmvs5j6_AwMyrA8v9Zuo_vbn9KNKXPPsfn+J25gGA@HIDDEN>
 <CAOQTW-OguzdSKKKm=UR5A+Kr=Z0FHSJE45a22yvRJiEf2Z-yuA@HIDDEN>
 <83jzq6cdfx.fsf@HIDDEN> <86y1elzq58.fsf@HIDDEN>
 <83lealbnz5.fsf@HIDDEN>
In-Reply-To: <83lealbnz5.fsf@HIDDEN>
From: Liu Hui <liuhui1610@HIDDEN>
Date: Sun, 26 Nov 2023 10:56:52 +0800
Message-ID: <CAOQTW-PSmLviOP6mJfg-BxQ50D2Y0naMXWMb+t9hnK_k=sbd+g@HIDDEN>
Subject: Re: bug#67161: 30.0.50;
 [PATCH] Add option `dired-filename-display-length'
To: Eli Zaretskii <eliz@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.2 (/)
X-Debbugs-Envelope-To: 67161
Cc: 67161 <at> debbugs.gnu.org, Juri Linkov <juri@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.8 (/)

Eli Zaretskii <eliz@HIDDEN> =E4=BA=8E2023=E5=B9=B411=E6=9C=8826=E6=97=A5=
=E5=91=A8=E6=97=A5 04:02=E5=86=99=E9=81=93=EF=BC=9A

> Does the below fix the problem, and is the Dired display after the
> change correct when file names are truncated?
>
> diff --git a/lisp/dired.el b/lisp/dired.el
> index 23a6fc0..096d6a8 100644
> --- a/lisp/dired.el
> +++ b/lisp/dired.el
> @@ -2021,8 +2021,12 @@ dired--get-ellipsis-length
>    (let* ((dt (or (window-display-table)
>                   buffer-display-table
>                   standard-display-table))
> -         (glyphs (and dt (display-table-slot dt 'selective-display))))
> -    (string-width (if glyphs (concat glyphs) "..."))))
> +         (glyphs (and dt (display-table-slot dt 'selective-display)))
> +         (vlen (length glyphs))
> +         (char-glyphs (make-vector vlen nil)))
> +    (dotimes (i vlen)
> +      (aset char-glyphs i (glyph-char (aref glyphs i))))
> +    (string-width (if glyphs (concat char-glyphs) "..."))))
>
>  (defun dired--get-filename-display-length ()
>    "Return maximum display length of filename.

Thanks Eli! I wasn't aware of the face of glyph and I confirm the
dired display is correct with your fix.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67161; Package emacs. Full text available.

Message received at 67161 <at> debbugs.gnu.org:


Received: (at 67161) by debbugs.gnu.org; 25 Nov 2023 20:03:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 25 15:03:06 2023
Received: from localhost ([127.0.0.1]:40348 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r6yrq-00026k-BN
	for submit <at> debbugs.gnu.org; Sat, 25 Nov 2023 15:03:06 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:47886)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1r6yro-00026F-8g
 for 67161 <at> debbugs.gnu.org; Sat, 25 Nov 2023 15:03:04 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1r6yrd-0005pa-5z; Sat, 25 Nov 2023 15:02:53 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=6bXnUP0cvdDL8cGvjIQvLhKQxPwMDosPbjKezF+UZ5E=; b=rHb7yugsJExiQDsytbI8
 Eyr7sI7OSQh2isPiHtd8tEc06zVpl6mQtNUh9/uMPm9ch7zdNnJ47sv/Pr0oyxwQSihr5/ZRLbFaE
 JRVsPvcxYWeHrldmUly/9EKpOtNeOYqINqfr0Y2IP+SqkKjhO6VQYP9abs4O0MYCakxp7OM4hlduR
 EHG6nWR0RgJ2Q37KFKkVaPYrBDqcs0WeiLtaaYcl+91rnAwYudZDUm52Duba0K897PhfpHGJ+/KNv
 lm8mWLE2JceWpXa8rUEZyjg4ntDVyjBXVTXtcXBsAT9Uv51cnMPUsTmD1mU/TWfUNAc5MVkLsoDk4
 vhFD7DYgZqfUMQ==;
Date: Sat, 25 Nov 2023 22:02:38 +0200
Message-Id: <83lealbnz5.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Juri Linkov <juri@HIDDEN>
In-Reply-To: <86y1elzq58.fsf@HIDDEN> (message from Juri Linkov on
 Sat, 25 Nov 2023 19:51:55 +0200)
Subject: Re: bug#67161: 30.0.50; [PATCH] Add option
 `dired-filename-display-length'
References: <CAOQTW-MSpBK4ACpLk8U2m6HJx8HXw21O0kyYZ-i85ETNjyOUcA@HIDDEN>
 <8334x8tqi9.fsf@HIDDEN>
 <CAOQTW-P4+vs+JH8BTL8fL-d1QJXOdYq3i+3O7tALTDs=qHpnzA@HIDDEN>
 <83a5rfrych.fsf@HIDDEN>
 <CAOQTW-M5VaV0Va+ixd2-6SoKb4tPebxviobOB8Qs3Oxb9js9GA@HIDDEN>
 <83sf55q4nc.fsf@HIDDEN>
 <CAOQTW-MhVkj5LBYeguWKE6FsVgovdD0wuEW5bHZdy=01maXW1w@HIDDEN>
 <83jzqfmiuj.fsf@HIDDEN>
 <CAOQTW-NN=nmvs5j6_AwMyrA8v9Zuo_vbn9KNKXPPsfn+J25gGA@HIDDEN>
 <CAOQTW-OguzdSKKKm=UR5A+Kr=Z0FHSJE45a22yvRJiEf2Z-yuA@HIDDEN>
 <83jzq6cdfx.fsf@HIDDEN> <86y1elzq58.fsf@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 67161
Cc: liuhui1610@HIDDEN, 67161 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Juri Linkov <juri@HIDDEN>
> Cc: eliz@HIDDEN,  liuhui1610@HIDDEN
> Date: Sat, 25 Nov 2023 19:51:55 +0200
> 
> > Thanks, installed on the master branch, and closing the bug.
> 
> There is a problem with this specific configuration
> when ellipsis is a vector:
> 
>   (progn
>     (or standard-display-table (setq standard-display-table (make-display-table)))
>     (let* ((face (lsh (face-id 'escape-glyph) 22))
>            (dots (+ face ?…)))
>       (set-char-table-extra-slot standard-display-table 4 (vector dots))))
> 
> that fails with
> 
>   Debugger entered--Lisp error: (wrong-type-argument characterp 88088614)
>     concat([88088614])
>     (if glyphs (concat glyphs) "...")
>     (string-width (if glyphs (concat glyphs) "..."))
>     dired--get-ellipsis-length()
>     ...
> 

Does the below fix the problem, and is the Dired display after the
change correct when file names are truncated?

diff --git a/lisp/dired.el b/lisp/dired.el
index 23a6fc0..096d6a8 100644
--- a/lisp/dired.el
+++ b/lisp/dired.el
@@ -2021,8 +2021,12 @@ dired--get-ellipsis-length
   (let* ((dt (or (window-display-table)
                  buffer-display-table
                  standard-display-table))
-         (glyphs (and dt (display-table-slot dt 'selective-display))))
-    (string-width (if glyphs (concat glyphs) "..."))))
+         (glyphs (and dt (display-table-slot dt 'selective-display)))
+         (vlen (length glyphs))
+         (char-glyphs (make-vector vlen nil)))
+    (dotimes (i vlen)
+      (aset char-glyphs i (glyph-char (aref glyphs i))))
+    (string-width (if glyphs (concat char-glyphs) "..."))))
 
 (defun dired--get-filename-display-length ()
   "Return maximum display length of filename.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67161; Package emacs. Full text available.

Message received at 67161 <at> debbugs.gnu.org:


Received: (at 67161) by debbugs.gnu.org; 25 Nov 2023 18:21:40 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 25 13:21:40 2023
Received: from localhost ([127.0.0.1]:40187 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r6xHg-0002Op-BL
	for submit <at> debbugs.gnu.org; Sat, 25 Nov 2023 13:21:40 -0500
Received: from relay7-d.mail.gandi.net ([2001:4b98:dc4:8::227]:57573)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>) id 1r6xHc-0002OF-BA
 for 67161 <at> debbugs.gnu.org; Sat, 25 Nov 2023 13:21:36 -0500
Received: by mail.gandi.net (Postfix) with ESMTPSA id C094C20003;
 Sat, 25 Nov 2023 18:21:23 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: 67161 <at> debbugs.gnu.org
Subject: Re: bug#67161: 30.0.50; [PATCH] Add option
 `dired-filename-display-length'
In-Reply-To: <83jzq6cdfx.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 25 Nov
 2023 12:52:34 +0200")
Organization: LINKOV.NET
References: <CAOQTW-MSpBK4ACpLk8U2m6HJx8HXw21O0kyYZ-i85ETNjyOUcA@HIDDEN>
 <8334x8tqi9.fsf@HIDDEN>
 <CAOQTW-P4+vs+JH8BTL8fL-d1QJXOdYq3i+3O7tALTDs=qHpnzA@HIDDEN>
 <83a5rfrych.fsf@HIDDEN>
 <CAOQTW-M5VaV0Va+ixd2-6SoKb4tPebxviobOB8Qs3Oxb9js9GA@HIDDEN>
 <83sf55q4nc.fsf@HIDDEN>
 <CAOQTW-MhVkj5LBYeguWKE6FsVgovdD0wuEW5bHZdy=01maXW1w@HIDDEN>
 <83jzqfmiuj.fsf@HIDDEN>
 <CAOQTW-NN=nmvs5j6_AwMyrA8v9Zuo_vbn9KNKXPPsfn+J25gGA@HIDDEN>
 <CAOQTW-OguzdSKKKm=UR5A+Kr=Z0FHSJE45a22yvRJiEf2Z-yuA@HIDDEN>
 <83jzq6cdfx.fsf@HIDDEN>
Date: Sat, 25 Nov 2023 19:51:55 +0200
Message-ID: <86y1elzq58.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 67161
Cc: liuhui1610@HIDDEN, eliz@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

> Thanks, installed on the master branch, and closing the bug.

There is a problem with this specific configuration
when ellipsis is a vector:

  (progn
    (or standard-display-table (setq standard-display-table (make-display-table)))
    (let* ((face (lsh (face-id 'escape-glyph) 22))
           (dots (+ face ?…)))
      (set-char-table-extra-slot standard-display-table 4 (vector dots))))

that fails with

  Debugger entered--Lisp error: (wrong-type-argument characterp 88088614)
    concat([88088614])
    (if glyphs (concat glyphs) "...")
    (string-width (if glyphs (concat glyphs) "..."))
    dired--get-ellipsis-length()
    ...




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67161; Package emacs. Full text available.

Message received at 67161-done <at> debbugs.gnu.org:


Received: (at 67161-done) by debbugs.gnu.org; 25 Nov 2023 10:52:51 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 25 05:52:51 2023
Received: from localhost ([127.0.0.1]:37934 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r6qHK-0006HY-PE
	for submit <at> debbugs.gnu.org; Sat, 25 Nov 2023 05:52:51 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:53954)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1r6qHI-0006HL-FS
 for 67161-done <at> debbugs.gnu.org; Sat, 25 Nov 2023 05:52:49 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1r6qH7-0005NV-QR; Sat, 25 Nov 2023 05:52:37 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=+kE4C9N/9edprcZCiagjLL/cSykLPToWDLN1Zr3gUVo=; b=RuAbbmiB/Ii+
 hhCkmCa1mpCiyavwbIHJ7lOP6l+6OIH+xingz5RoGM4LCu2znV5kTN9rcBrgMvryYqs8CklDD55/1
 LutQYR8BnhfW3VdSPIhviH1Yq76jalOg5RQ/CLLd5vcwDBvKd2wRiitQ8M5OLv6JOI0i+hFd8chb7
 Zaf3BWon7fyKrhVI8TTjczL97oXn4/VAHcnfXSx/3umci1lKOweB/Hh/SNQUrwkMcGHT0senbuTAd
 dO7EcD5pMmgEAoWsDKsi012EU1PgtprfaTJqge2gb/Hw8CY0Hd9ZHk891vVNl/GNmeqMmq8Zi8GEn
 F3NdBnkiwbs5edEZFvrNnQ==;
Date: Sat, 25 Nov 2023 12:52:34 +0200
Message-Id: <83jzq6cdfx.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Liu Hui <liuhui1610@HIDDEN>
In-Reply-To: <CAOQTW-OguzdSKKKm=UR5A+Kr=Z0FHSJE45a22yvRJiEf2Z-yuA@HIDDEN>
 (message from Liu Hui on Wed, 22 Nov 2023 13:41:18 +0800)
Subject: Re: bug#67161: 30.0.50;
 [PATCH] Add option `dired-filename-display-length'
References: <CAOQTW-MSpBK4ACpLk8U2m6HJx8HXw21O0kyYZ-i85ETNjyOUcA@HIDDEN>
 <8334x8tqi9.fsf@HIDDEN>
 <CAOQTW-P4+vs+JH8BTL8fL-d1QJXOdYq3i+3O7tALTDs=qHpnzA@HIDDEN>
 <83a5rfrych.fsf@HIDDEN>
 <CAOQTW-M5VaV0Va+ixd2-6SoKb4tPebxviobOB8Qs3Oxb9js9GA@HIDDEN>
 <83sf55q4nc.fsf@HIDDEN>
 <CAOQTW-MhVkj5LBYeguWKE6FsVgovdD0wuEW5bHZdy=01maXW1w@HIDDEN>
 <83jzqfmiuj.fsf@HIDDEN>
 <CAOQTW-NN=nmvs5j6_AwMyrA8v9Zuo_vbn9KNKXPPsfn+J25gGA@HIDDEN>
 <CAOQTW-OguzdSKKKm=UR5A+Kr=Z0FHSJE45a22yvRJiEf2Z-yuA@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 67161-done
Cc: 67161-done <at> debbugs.gnu.org, stefankangas@HIDDEN,
 monnier@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Liu Hui <liuhui1610@HIDDEN>
> Date: Wed, 22 Nov 2023 13:41:18 +0800
> Cc: stefankangas@HIDDEN, monnier@HIDDEN, 67161 <at> debbugs.gnu.org
> 
> > Therefore, I would like to change
> >
> >   (put-text-property ell-beg (point) 'invisible 'dired-filename-hide)
> >
> > to
> >
> >   (let ((ov (make-overlay ell-beg (point))))
> >     (overlay-put ov 'invisible 'dired-filename-hide)
> >     (overlay-put ov 'isearch-open-invisible t)
> >     (overlay-put ov 'evaporate t))
> >
> > in the attached patch, then text in hidden part can be matched
> > regardless of search-invisible being open or t. It also has a bonus
> > that hidden text can be revealed during isearch.
> 
> Since there is no objection to using overlay, I have updated the patch
> accordingly with additional explanation. Thanks.

Thanks, installed on the master branch, and closing the bug.

Please in the future always mention the bug number as part of the
commit log message, when the bug number is known.




Notification sent to Liu Hui <liuhui1610@HIDDEN>:
bug acknowledged by developer. Full text available.
Reply sent to Eli Zaretskii <eliz@HIDDEN>:
You have taken responsibility. Full text available.

Message received at 67161 <at> debbugs.gnu.org:


Received: (at 67161) by debbugs.gnu.org; 22 Nov 2023 05:41:43 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Nov 22 00:41:43 2023
Received: from localhost ([127.0.0.1]:57886 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r5fza-0006nC-UA
	for submit <at> debbugs.gnu.org; Wed, 22 Nov 2023 00:41:43 -0500
Received: from mail-vs1-xe2c.google.com ([2607:f8b0:4864:20::e2c]:46121)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <liuhui1610@HIDDEN>) id 1r5fzY-0006mx-FY
 for 67161 <at> debbugs.gnu.org; Wed, 22 Nov 2023 00:41:41 -0500
Received: by mail-vs1-xe2c.google.com with SMTP id
 ada2fe7eead31-460f623392fso1865590137.0
 for <67161 <at> debbugs.gnu.org>; Tue, 21 Nov 2023 21:41:37 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1700631692; x=1701236492; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:from:to:cc:subject:date:message-id:reply-to;
 bh=drfoc7Om3UvZv1o521BtULzmmAkQYNSiGBPTxYGUgpo=;
 b=ZyVX3/BUEmDhEfxElJngIvdqPbHsFcUWFvgmKnruSrJdAqQEr2nZiv5Zzw+j1T+9dZ
 7BarAFHhWybccVfMYSfct6Z3I4H86KB/aHAxZUNjnUub0NVXHWuEhT0euu5sGoyiTTau
 I+bP2okHDwH587hvsiQbqw7VxTY5i8CibFhr7ceclZz1dX1rbJJRKZGTtw3tE1VYeCZZ
 JmYfEUPLZMY0LRNI2TLS5Rq0bSr0gSVt3Z6kXyU6an31PMCpc0S6K/7vHotfFivsLSYS
 h24Xposbfi93eVuoAP+m9+uK3r8ZR1vyVPwkaN8kW5NWq+6hnd25p52uwxltqWH846g1
 581w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1700631692; x=1701236492;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=drfoc7Om3UvZv1o521BtULzmmAkQYNSiGBPTxYGUgpo=;
 b=E4IKQcqZ3+sd7dg1oRwPK4JT5hVcClRvmAFFBWplRFGu+lgTQq57LBp3UxUyQf6vRi
 FDzbHPcvQRVvj/rq+sHR1sw35z/Idb8/lLU1XnzVyM6SNSHyfudcFRV5f7hkYmyFhrGW
 jvZ0xF3JrQ8ftnc5F3OdZF++9I6+J1wmu+rafEtrknKvKi4Jdi0J3XGJuu9Xjf6mvJNf
 DIGjMvF0Ea8+fieFwUAIRz2mE960lLmCmiUMmtCihjiOv3gr+R+VZrC8qUSy9Ffbrcut
 4GASOFLio3+8ZuKdiO7tVGw2D8j6/wKaIe+GlStIo4MznoxnpFkMmVh5i0Go6q2HZ/2d
 EghA==
X-Gm-Message-State: AOJu0YzFQgcvj8VYz062DTakjmai9p+B16QooHKRCwVnphmmgkiZoVvp
 2pIpppgjdzWxgGMfL9YRV60RmmFnvzKXLNaGJ7U=
X-Google-Smtp-Source: AGHT+IEWA8db4WrZ8F/LquA6Vds1woDO+8cxgSTwKavCu+dkBVt6dEP78Idt5/nUWWXXl/B7lBKh+qSpZgYN7zrgVSA=
X-Received: by 2002:a05:6102:1045:b0:45f:1106:518a with SMTP id
 h5-20020a056102104500b0045f1106518amr1614262vsq.32.1700631691853; Tue, 21 Nov
 2023 21:41:31 -0800 (PST)
MIME-Version: 1.0
References: <CAOQTW-MSpBK4ACpLk8U2m6HJx8HXw21O0kyYZ-i85ETNjyOUcA@HIDDEN>
 <8334x8tqi9.fsf@HIDDEN>
 <CAOQTW-P4+vs+JH8BTL8fL-d1QJXOdYq3i+3O7tALTDs=qHpnzA@HIDDEN>
 <83a5rfrych.fsf@HIDDEN>
 <CAOQTW-M5VaV0Va+ixd2-6SoKb4tPebxviobOB8Qs3Oxb9js9GA@HIDDEN>
 <83sf55q4nc.fsf@HIDDEN>
 <CAOQTW-MhVkj5LBYeguWKE6FsVgovdD0wuEW5bHZdy=01maXW1w@HIDDEN>
 <83jzqfmiuj.fsf@HIDDEN>
 <CAOQTW-NN=nmvs5j6_AwMyrA8v9Zuo_vbn9KNKXPPsfn+J25gGA@HIDDEN>
In-Reply-To: <CAOQTW-NN=nmvs5j6_AwMyrA8v9Zuo_vbn9KNKXPPsfn+J25gGA@HIDDEN>
From: Liu Hui <liuhui1610@HIDDEN>
Date: Wed, 22 Nov 2023 13:41:18 +0800
Message-ID: <CAOQTW-OguzdSKKKm=UR5A+Kr=Z0FHSJE45a22yvRJiEf2Z-yuA@HIDDEN>
Subject: Re: bug#67161: 30.0.50;
 [PATCH] Add option `dired-filename-display-length'
To: Eli Zaretskii <eliz@HIDDEN>
Content-Type: multipart/mixed; boundary="000000000000e32f9e060ab72b42"
X-Spam-Score: 0.2 (/)
X-Debbugs-Envelope-To: 67161
Cc: 67161 <at> debbugs.gnu.org, stefankangas@HIDDEN, monnier@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.8 (/)

--000000000000e32f9e060ab72b42
Content-Type: text/plain; charset="UTF-8"

> Therefore, I would like to change
>
>   (put-text-property ell-beg (point) 'invisible 'dired-filename-hide)
>
> to
>
>   (let ((ov (make-overlay ell-beg (point))))
>     (overlay-put ov 'invisible 'dired-filename-hide)
>     (overlay-put ov 'isearch-open-invisible t)
>     (overlay-put ov 'evaporate t))
>
> in the attached patch, then text in hidden part can be matched
> regardless of search-invisible being open or t. It also has a bonus
> that hidden text can be revealed during isearch.

Since there is no objection to using overlay, I have updated the patch
accordingly with additional explanation. Thanks.

--000000000000e32f9e060ab72b42
Content-Type: text/x-patch; charset="US-ASCII"; 
	name="0001-Add-option-dired-filename-display-length.patch"
Content-Disposition: attachment; 
	filename="0001-Add-option-dired-filename-display-length.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_lp9bw80q0>
X-Attachment-Id: f_lp9bw80q0

RnJvbSBmMmZjYmM0NzU2ZTNiZWIyNzBhODlmZTVkYjVkNjRlNDY3Y2I2ZDFkIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBMaXUgSHVpIDxsaXVodWkxNjEwQGdtYWlsLmNvbT4KRGF0ZTog
TW9uLCAyMCBOb3YgMjAyMyAxMjowOToxNSArMDgwMApTdWJqZWN0OiBbUEFUQ0hdIEFkZCBvcHRp
b24gYGRpcmVkLWZpbGVuYW1lLWRpc3BsYXktbGVuZ3RoJwoKKiBsaXNwL2RpcmVkLmVsIChkaXJl
ZC1maWxlbmFtZS1kaXNwbGF5LWxlbmd0aCk6IE5ldyBvcHRpb24uCihkaXJlZC1pbnNlcnQtc2V0
LXByb3BlcnRpZXMpOiBTZXQgaW52aXNpYmxlIHByb3BlcnR5IGZvciBsb25nCmZpbGVuYW1lcy4K
KGRpcmVkLS1nZXQtZWxsaXBzaXMtbGVuZ3RoKQooZGlyZWQtLWdldC1maWxlbmFtZS1kaXNwbGF5
LWxlbmd0aCkKKGRpcmVkLWZpbGVuYW1lLXVwZGF0ZS1pbnZpc2liaWxpdHktc3BlYyk6IE5ldyBm
dW5jdGlvbnMuCihkaXJlZC1tb2RlKTogQWRkIGZpbGVuYW1lIGludmlzaWJpbGl0eSBzcGVjLgoo
ZGlyZWQtbWFrZS1kaXJlY3RvcnktY2xpY2thYmxlKToKKGRpcmVkLWtpbGwtd2hlbi1vcGVuaW5n
LW5ldy1kaXJlZC1idWZmZXIpOgooZGlyZWQtaGlkZS1kZXRhaWxzLXByZXNlcnZlZC1jb2x1bW5z
KTogQWRkIG1pc3NpbmcgZ3JvdXAuCiogbGlzcC93ZGlyZWQuZWwgKHdkaXJlZC1jaGFuZ2UtdG8t
d2RpcmVkLW1vZGUpCih3ZGlyZWQtY2hhbmdlLXRvLWRpcmVkLW1vZGUpOiBVcGRhdGUgZmlsZW5h
bWUgaW52aXNpYmlsaXR5IHNwZWMuCiogZXRjL05FV1M6IEFubm91bmNlIHRoZSBjaGFuZ2UuCi0t
LQogZXRjL05FV1MgICAgICAgfCAgIDcgKysrCiBsaXNwL2RpcmVkLmVsICB8IDE1MSArKysrKysr
KysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tCiBsaXNwL3dkaXJlZC5l
bCB8ICAgNyArKysKIDMgZmlsZXMgY2hhbmdlZCwgMTIzIGluc2VydGlvbnMoKyksIDQyIGRlbGV0
aW9ucygtKQoKZGlmZiAtLWdpdCBhL2V0Yy9ORVdTIGIvZXRjL05FV1MKaW5kZXggZTE0ZDE1YTc0
ODcuLmI0YTMwMTRkZWJkIDEwMDY0NAotLS0gYS9ldGMvTkVXUworKysgYi9ldGMvTkVXUwpAQCAt
NDg3LDYgKzQ4NywxMyBAQCBlbXB0eSBsaW5lcy4gIEl0IGFsc28gY29udHJvbHMgaG93IHRvIG1v
dmUgcG9pbnQgd2hlbiBlbmNvdW50ZXJpbmcgYQogYm91bmRhcnkgKGUuZy4sIGlmIGV2ZXJ5IGxp
bmUgaXMgdmlzaWJsZSwgaW52b2tpbmcgJ2RpcmVkLW5leHQtbGluZScKIGF0IHRoZSBsYXN0IGxp
bmUgd2lsbCBtb3ZlIHRvIHRoZSBmaXJzdCBsaW5lKS4gIFRoZSBkZWZhdWx0IGlzIG5pbC4KIAor
KioqIE5ldyB1c2VyIG9wdGlvbiAnZGlyZWQtZmlsZW5hbWUtZGlzcGxheS1sZW5ndGgnLgorSXQg
aXMgYW4gaW50ZWdlciByZXByZXNlbnRpbmcgdGhlIG1heGltdW0gZGlzcGxheSBsZW5ndGggb2Yg
ZmlsZW5hbWVzLgorVGhlIG1pZGRsZSBwYXJ0IG9mIGZpbGVuYW1lIHdob3NlIGxlbmd0aCBleGNl
ZWRzIHRoZSByZXN0cmljdGlvbiBpcworaGlkZGVuIGFuZCBhbiBlbGxpcHNpcyBpcyBkaXNwbGF5
ZWQgaW5zdGVhZC4gIEEgdmFsdWUgb2YgJ3dpbmRvdycKK21lYW5zIHVzaW5nIHRoZSByaWdodCBl
ZGdlIG9mIHdpbmRvdyBhcyB0aGUgZGlzcGxheSByZXN0cmljdGlvbi4gIFRoZQorZGVmYXVsdCBp
cyBuaWwuCisKICoqIEVkaWZmCiAKIC0tLQpkaWZmIC0tZ2l0IGEvbGlzcC9kaXJlZC5lbCBiL2xp
c3AvZGlyZWQuZWwKaW5kZXggNTgzY2IyNDc1ZTIuLjg4MTI3MjFiYjNhIDEwMDY0NAotLS0gYS9s
aXNwL2RpcmVkLmVsCisrKyBiL2xpc3AvZGlyZWQuZWwKQEAgLTM1MCw2ICszNTAsNyBAQCBkaXJl
ZC1hZnRlci1yZWFkaW4taG9vawogKGRlZmN1c3RvbSBkaXJlZC1tYWtlLWRpcmVjdG9yeS1jbGlj
a2FibGUgdAogICAiV2hlbiBub24tbmlsLCBtYWtlIHRoZSBkaXJlY3RvcnkgYXQgdGhlIHN0YXJ0
IG9mIHRoZSBkaXJlZCBidWZmZXIgY2xpY2thYmxlLiIKICAgOnZlcnNpb24gIjI5LjEiCisgIDpn
cm91cCAnZGlyZWQKICAgOnR5cGUgJ2Jvb2xlYW4pCiAKIChkZWZjdXN0b20gZGlyZWQtaW5pdGlh
bC1wb3NpdGlvbi1ob29rIG5pbApAQCAtNDI5LDYgKzQzMCw3IEBAIGRpcmVkLW1hcmstcmVnaW9u
CiAoZGVmY3VzdG9tIGRpcmVkLWtpbGwtd2hlbi1vcGVuaW5nLW5ldy1kaXJlZC1idWZmZXIgbmls
CiAgICJJZiBub24tbmlsLCBraWxsIHRoZSBjdXJyZW50IGJ1ZmZlciB3aGVuIHNlbGVjdGluZyBh
IG5ldyBkaXJlY3RvcnkuIgogICA6dHlwZSAnYm9vbGVhbgorICA6Z3JvdXAgJ2RpcmVkCiAgIDp2
ZXJzaW9uICIyOC4xIikKIAogKGRlZmN1c3RvbSBkaXJlZC1ndWVzcy1zaGVsbC1jYXNlLWZvbGQt
c2VhcmNoIHQKQEAgLTUxNSw2ICs1MTcsMjIgQEAgZGlyZWQtbW92ZW1lbnQtc3R5bGUKIChkZWZj
dXN0b20gZGlyZWQtaGlkZS1kZXRhaWxzLXByZXNlcnZlZC1jb2x1bW5zIG5pbAogICAiTGlzdCBv
ZiBjb2x1bW5zIHdoaWNoIGFyZSBub3QgaGlkZGVuIGluIGBkaXJlZC1oaWRlLWRldGFpbHMtbW9k
ZScuIgogICA6dHlwZSAnKHJlcGVhdCBpbnRlZ2VyKQorICA6Z3JvdXAgJ2RpcmVkCisgIDp2ZXJz
aW9uICIzMC4xIikKKworKGRlZmN1c3RvbSBkaXJlZC1maWxlbmFtZS1kaXNwbGF5LWxlbmd0aCBu
aWwKKyAgIklmIG5vbi1uaWwsIHJlc3RyaWN0IHRoZSBkaXNwbGF5IGxlbmd0aCBvZiBmaWxlbmFt
ZXMuCitJZiB0aGUgdmFsdWUgaXMgdGhlIHN5bWJvbCBgd2luZG93JywgdGhlIHJpZ2h0IGVkZ2Ug
b2YgY3VycmVudAord2luZG93IGlzIHVzZWQgYXMgdGhlIHJlc3RyaWN0aW9uLiAgT3RoZXJ3aXNl
LCBpdCBzaG91bGQgYmUgYW4KK2ludGVnZXIgcmVwcmVzZW50aW5nIHRoZSBtYXhpbXVtIGZpbGVu
YW1lIGxlbmd0aC4KKworVGhlIG1pZGRsZSBwYXJ0IG9mIGZpbGVuYW1lIHdob3NlIGxlbmd0aCBl
eGNlZWRzIHRoZSByZXN0cmljdGlvbgoraXMgaGlkZGVuIGJ5IHVzaW5nIHRoZSBgaW52aXNpYmxl
JyBwcm9wZXJ0eSBhbmQgYW4gZWxsaXBzaXMgaXMKK2Rpc3BsYXllZCBpbnN0ZWFkLiIKKyAgOnR5
cGUgJyhjaG9pY2UgKGNvbnN0ICAgOnRhZyAiTm8gcmVzdHJpY3Rpb24iIG5pbCkKKyAgICAgICAg
ICAgICAgICAgKGNvbnN0ICAgOnRhZyAiV2luZG93IiB3aW5kb3cpCisgICAgICAgICAgICAgICAg
IChpbnRlZ2VyIDp0YWcgIkludGVnZXIiKSkKKyAgOmdyb3VwICdkaXJlZAogICA6dmVyc2lvbiAi
MzAuMSIpCiAKIAwKQEAgLTE5MDAsNTEgKzE5MTgsNzIgQEAgZGlyZWQtY2xpY2stdG8tc2VsZWN0
LW1vZGUKIChkZWZ2YXIgZGlyZWQtY2xpY2stdG8tc2VsZWN0LW1hcCkKIAogKGRlZnVuIGRpcmVk
LWluc2VydC1zZXQtcHJvcGVydGllcyAoYmVnIGVuZCkKLSAgIkFkZCB2YXJpb3VzIHRleHQgcHJv
cGVydGllcyB0byB0aGUgbGluZXMgaW4gdGhlIHJlZ2lvbiwgZnJvbSBCRUcgdG8gRU5ELiIKKyAg
IkFkZCB2YXJpb3VzIHRleHQgcHJvcGVydGllcyB0byB0aGUgbGluZXMgaW4gdGhlIHJlZ2lvbiwg
ZnJvbSBCRUcgdG8gRU5ELgorT3ZlcmxheXMgY291bGQgYmUgYWRkZWQgd2hlbiBzb21lIHVzZXIg
b3B0aW9ucyBhcmUgZW5hYmxlZCwgZS5nLiwKK2BkaXJlZC1maWxlbmFtZS1kaXNwbGF5LWxlbmd0
aCcuIgorICAocmVtb3ZlLW92ZXJsYXlzIGJlZyBlbmQgJ2ludmlzaWJsZSAnZGlyZWQtZmlsZW5h
bWUtaGlkZSkKICAgKHNhdmUtZXhjdXJzaW9uCiAgICAgKGdvdG8tY2hhciBiZWcpCi0gICAgKHdo
aWxlICg8IChwb2ludCkgZW5kKQotICAgICAgKGlnbm9yZS1lcnJvcnMKLQkoaWYgKG5vdCAoZGly
ZWQtbW92ZS10by1maWxlbmFtZSkpCi0JICAgICh1bmxlc3MgKG9yIChsb29raW5nLWF0LXAgIl4k
IikKLQkJCShsb29raW5nLWF0LXAgZGlyZWQtc3ViZGlyLXJlZ2V4cCkpCi0JICAgICAgKHB1dC10
ZXh0LXByb3BlcnR5IChsaW5lLWJlZ2lubmluZy1wb3NpdGlvbikKLQkJCQkgKDErIChsaW5lLWVu
ZC1wb3NpdGlvbikpCi0JCQkJICdpbnZpc2libGUgJ2RpcmVkLWhpZGUtZGV0YWlscy1pbmZvcm1h
dGlvbikpCi0JICAoc2F2ZS1leGN1cnNpb24KLSAgICAgICAgICAgIChsZXQgKChlbmQgKDEtIChw
b2ludCkpKQotICAgICAgICAgICAgICAgICAgKG9wb2ludCAoZ290by1jaGFyICgxKyAocG9zLWJv
bCkpKSkKLSAgICAgICAgICAgICAgICAgIChpIDApKQotICAgICAgICAgICAgICAocHV0LXRleHQt
cHJvcGVydHkgb3BvaW50IGVuZCAnaW52aXNpYmxlICdkaXJlZC1oaWRlLWRldGFpbHMtZGV0YWls
KQotICAgICAgICAgICAgICAod2hpbGUgKHJlLXNlYXJjaC1mb3J3YXJkICJbXiBdKyIgZW5kIHQp
Ci0gICAgICAgICAgICAgICAgKHdoZW4gKG1lbWJlciAoY2wtaW5jZiBpKSBkaXJlZC1oaWRlLWRl
dGFpbHMtcHJlc2VydmVkLWNvbHVtbnMpCi0gICAgICAgICAgICAgICAgICAocHV0LXRleHQtcHJv
cGVydHkgb3BvaW50IChwb2ludCkgJ2ludmlzaWJsZSBuaWwpKQotICAgICAgICAgICAgICAgIChz
ZXRxIG9wb2ludCAocG9pbnQpKSkpKQotICAgICAgICAgIChsZXQgKChiZWcgKHBvaW50KSkgKGVu
ZCAoc2F2ZS1leGN1cnNpb24KLQkgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChkaXJlZC1t
b3ZlLXRvLWVuZC1vZi1maWxlbmFtZSkKLQkgICAgICAgICAgICAgICAgICAgICAgICAgICAgICgx
LSAocG9pbnQpKSkpKQotICAgICAgICAgICAgKGlmIGRpcmVkLWNsaWNrLXRvLXNlbGVjdC1tb2Rl
Ci0gICAgICAgICAgICAgICAgKHB1dC10ZXh0LXByb3BlcnR5IGJlZyBlbmQgJ2tleW1hcAotICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkaXJlZC1jbGljay10by1zZWxlY3QtbWFw
KQotICAgICAgICAgICAgICAod2hlbiAoYW5kIGRpcmVkLW1vdXNlLWRyYWctZmlsZXMgKGZib3Vu
ZHAgJ3gtYmVnaW4tZHJhZykpCi0gICAgICAgICAgICAgICAgKHB1dC10ZXh0LXByb3BlcnR5IGJl
ZyBlbmQgJ2tleW1hcAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkaXJlZC1t
b3VzZS1kcmFnLWZpbGVzLW1hcCkpKQotCSAgICAoYWRkLXRleHQtcHJvcGVydGllcwotCSAgICAg
YmVnICgxKyBlbmQpCi0JICAgICBgKG1vdXNlLWZhY2UKLQkgICAgICAgaGlnaGxpZ2h0Ci0JICAg
ICAgIGRpcmVkLWZpbGVuYW1lIHQKLQkgICAgICAgaGVscC1lY2hvICwoaWYgZGlyZWQtY2xpY2st
dG8tc2VsZWN0LW1vZGUKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJtb3VzZS0yOiBt
YXJrIG9yIHVubWFyayB0aGlzIGZpbGUiCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgKGlm
IChhbmQgZGlyZWQtbW91c2UtZHJhZy1maWxlcwotICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIChmYm91bmRwICd4LWJlZ2luLWRyYWcpKQotICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAiZG93bi1tb3VzZS0xOiBkcmFnIHRoaXMgZmlsZSB0byBhbm90aGVyIHByb2dy
YW0KKyAgICAobGV0ICgoZWxsLWxlbiAoZGlyZWQtLWdldC1lbGxpcHNpcy1sZW5ndGgpKSBtYXhs
ZW4gZmlsZW5hbWUtY29sKQorICAgICAgKHdoaWxlICg8IChwb2ludCkgZW5kKQorICAgICAgICAo
aWdub3JlLWVycm9ycworCSAgKGlmIChub3QgKGRpcmVkLW1vdmUtdG8tZmlsZW5hbWUpKQorCSAg
ICAgICh1bmxlc3MgKG9yIChsb29raW5nLWF0LXAgIl4kIikKKwkJCSAgKGxvb2tpbmctYXQtcCBk
aXJlZC1zdWJkaXItcmVnZXhwKSkKKwkgICAgICAgIChwdXQtdGV4dC1wcm9wZXJ0eSAobGluZS1i
ZWdpbm5pbmctcG9zaXRpb24pCisJCQkJICAgKDErIChsaW5lLWVuZC1wb3NpdGlvbikpCisJCQkJ
ICAgJ2ludmlzaWJsZSAnZGlyZWQtaGlkZS1kZXRhaWxzLWluZm9ybWF0aW9uKSkKKwkgICAgKHNh
dmUtZXhjdXJzaW9uCisgICAgICAgICAgICAgIChsZXQgKChlbmQgKDEtIChwb2ludCkpKQorICAg
ICAgICAgICAgICAgICAgICAob3BvaW50IChnb3RvLWNoYXIgKDErIChwb3MtYm9sKSkpKQorICAg
ICAgICAgICAgICAgICAgICAoaSAwKSkKKyAgICAgICAgICAgICAgICAocHV0LXRleHQtcHJvcGVy
dHkgb3BvaW50IGVuZCAnaW52aXNpYmxlICdkaXJlZC1oaWRlLWRldGFpbHMtZGV0YWlsKQorICAg
ICAgICAgICAgICAgICh3aGlsZSAocmUtc2VhcmNoLWZvcndhcmQgIlteIF0rIiBlbmQgdCkKKyAg
ICAgICAgICAgICAgICAgICh3aGVuIChtZW1iZXIgKGNsLWluY2YgaSkgZGlyZWQtaGlkZS1kZXRh
aWxzLXByZXNlcnZlZC1jb2x1bW5zKQorICAgICAgICAgICAgICAgICAgICAocHV0LXRleHQtcHJv
cGVydHkgb3BvaW50IChwb2ludCkgJ2ludmlzaWJsZSBuaWwpKQorICAgICAgICAgICAgICAgICAg
KHNldHEgb3BvaW50IChwb2ludCkpKSkpCisgICAgICAgICAgICAobGV0ICgoYmVnIChwb2ludCkp
IChlbmQgKHNhdmUtZXhjdXJzaW9uCisJICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChk
aXJlZC1tb3ZlLXRvLWVuZC1vZi1maWxlbmFtZSkKKwkgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgKDEtIChwb2ludCkpKSkpCisgICAgICAgICAgICAgIChpZiBkaXJlZC1jbGljay10by1z
ZWxlY3QtbW9kZQorICAgICAgICAgICAgICAgICAgKHB1dC10ZXh0LXByb3BlcnR5IGJlZyBlbmQg
J2tleW1hcAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRpcmVkLWNsaWNr
LXRvLXNlbGVjdC1tYXApCisgICAgICAgICAgICAgICAgKHdoZW4gKGFuZCBkaXJlZC1tb3VzZS1k
cmFnLWZpbGVzIChmYm91bmRwICd4LWJlZ2luLWRyYWcpKQorICAgICAgICAgICAgICAgICAgKHB1
dC10ZXh0LXByb3BlcnR5IGJlZyBlbmQgJ2tleW1hcAorICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIGRpcmVkLW1vdXNlLWRyYWctZmlsZXMtbWFwKSkpCisgICAgICAgICAgICAg
ICh3aGVuIGRpcmVkLWZpbGVuYW1lLWRpc3BsYXktbGVuZ3RoCisgICAgICAgICAgICAgICAgKGxl
dCAoKGxlbiAoc3RyaW5nLXdpZHRoIChidWZmZXItc3Vic3RyaW5nIGJlZyAoMSsgZW5kKSkpKQor
ICAgICAgICAgICAgICAgICAgICAgIGVsbC1iZWcpCisgICAgICAgICAgICAgICAgICAob3IgbWF4
bGVuIChzZXRxIG1heGxlbiAoZGlyZWQtLWdldC1maWxlbmFtZS1kaXNwbGF5LWxlbmd0aCkpKQor
ICAgICAgICAgICAgICAgICAgKHdoZW4gKGFuZCAoaW50ZWdlcnAgbWF4bGVuKSAoPiBsZW4gbWF4
bGVuICgrIGVsbC1sZW4gMikpKQorICAgICAgICAgICAgICAgICAgICAob3IgZmlsZW5hbWUtY29s
IChzZXRxIGZpbGVuYW1lLWNvbCAoY3VycmVudC1jb2x1bW4pKSkKKyAgICAgICAgICAgICAgICAg
ICAgKG1vdmUtdG8tY29sdW1uICgrIGZpbGVuYW1lLWNvbCAoLyBtYXhsZW4gMikpKQorICAgICAg
ICAgICAgICAgICAgICAoc2V0cSBlbGwtYmVnIChwb2ludCkpCisgICAgICAgICAgICAgICAgICAg
IChtb3ZlLXRvLWNvbHVtbiAoKyBmaWxlbmFtZS1jb2wgKC8gbWF4bGVuIDIpCisgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoLSBsZW4gbWF4bGVuKSBlbGwtbGVuKSkKKyAg
ICAgICAgICAgICAgICAgICAgOzsgSGVyZSB3ZSB1c2Ugb3ZlcmxheXMgYmVjYXVzZSBpc2VhcmNo
IGJ5IGRlZmF1bHQKKyAgICAgICAgICAgICAgICAgICAgOzsgZG9lc24ndCBzdXBwb3J0IGZpbmRp
bmcgbWF0Y2hlcyBpbiBoaWRkZW4gdGV4dAorICAgICAgICAgICAgICAgICAgICA7OyBtYWRlIGlu
dmlzaWJsZSB2aWEgdGV4dCBwcm9wZXJ0aWVzLgorICAgICAgICAgICAgICAgICAgICAobGV0ICgo
b3YgKG1ha2Utb3ZlcmxheSBlbGwtYmVnIChwb2ludCkpKSkKKyAgICAgICAgICAgICAgICAgICAg
ICAob3ZlcmxheS1wdXQgb3YgJ2ludmlzaWJsZSAnZGlyZWQtZmlsZW5hbWUtaGlkZSkKKyAgICAg
ICAgICAgICAgICAgICAgICAob3ZlcmxheS1wdXQgb3YgJ2lzZWFyY2gtb3Blbi1pbnZpc2libGUg
dCkKKyAgICAgICAgICAgICAgICAgICAgICAob3ZlcmxheS1wdXQgb3YgJ2V2YXBvcmF0ZSB0KSkp
KSkKKwkgICAgICAoYWRkLXRleHQtcHJvcGVydGllcworCSAgICAgICBiZWcgKDErIGVuZCkKKwkg
ICAgICAgYChtb3VzZS1mYWNlCisJICAgICAgICAgaGlnaGxpZ2h0CisJICAgICAgICAgZGlyZWQt
ZmlsZW5hbWUgdAorCSAgICAgICAgIGhlbHAtZWNobyAsKGlmIGRpcmVkLWNsaWNrLXRvLXNlbGVj
dC1tb2RlCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJtb3VzZS0yOiBtYXJrIG9y
IHVubWFyayB0aGlzIGZpbGUiCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoaWYgKGFu
ZCBkaXJlZC1tb3VzZS1kcmFnLWZpbGVzCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAoZmJvdW5kcCAneC1iZWdpbi1kcmFnKSkKKyAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAiZG93bi1tb3VzZS0xOiBkcmFnIHRoaXMgZmlsZSB0byBhbm90aGVyIHByb2dy
YW0KIG1vdXNlLTI6IHZpc2l0IHRoaXMgZmlsZSBpbiBvdGhlciB3aW5kb3ciCi0gICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAibW91c2UtMjogdmlzaXQgdGhpcyBmaWxlIGluIG90aGVyIHdp
bmRvdyIpKSkpCi0JICAgICh3aGVuICg8ICgrIGVuZCA1KSAobGluZS1lbmQtcG9zaXRpb24pKQot
CSAgICAgIChwdXQtdGV4dC1wcm9wZXJ0eSAoKyBlbmQgNSkgKGxpbmUtZW5kLXBvc2l0aW9uKQot
CQkJICAgICAgICAgJ2ludmlzaWJsZSAnZGlyZWQtaGlkZS1kZXRhaWxzLWxpbmspKSkpKQotICAg
ICAgKGZvcndhcmQtbGluZSAxKSkpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAi
bW91c2UtMjogdmlzaXQgdGhpcyBmaWxlIGluIG90aGVyIHdpbmRvdyIpKSkpCisJICAgICAgKHdo
ZW4gKDwgKCsgZW5kIDUpIChsaW5lLWVuZC1wb3NpdGlvbikpCisJICAgICAgICAocHV0LXRleHQt
cHJvcGVydHkgKCsgZW5kIDUpIChsaW5lLWVuZC1wb3NpdGlvbikKKwkJCSAgICAgICAgICAgJ2lu
dmlzaWJsZSAnZGlyZWQtaGlkZS1kZXRhaWxzLWxpbmspKSkpKQorICAgICAgICAoZm9yd2FyZC1s
aW5lIDEpKSkpKQogCiAoZGVmdW4gZGlyZWQtLW1ha2UtZGlyZWN0b3J5LWNsaWNrYWJsZSAoKQog
ICAoc2F2ZS1leGN1cnNpb24KQEAgLTE5NzYsNiArMjAxNSwyNCBAQCBkaXJlZC0tbWFrZS1kaXJl
Y3RvcnktY2xpY2thYmxlCiAgICAgICAgICAgICAgICAgICAgICAgICAgICJSRVQiIGNsaWNrKSkp
KQogICAgICAgICAgIChzZXRxIHNlZ21lbnQtc3RhcnQgKHBvaW50KSkpKSkpKQogCisoZGVmdW4g
ZGlyZWQtLWdldC1lbGxpcHNpcy1sZW5ndGggKCkKKyAgIlJldHVybiBsZW5ndGggb2YgZWxsaXBz
aXMuIgorICAobGV0KiAoKGR0IChvciAod2luZG93LWRpc3BsYXktdGFibGUpCisgICAgICAgICAg
ICAgICAgIGJ1ZmZlci1kaXNwbGF5LXRhYmxlCisgICAgICAgICAgICAgICAgIHN0YW5kYXJkLWRp
c3BsYXktdGFibGUpKQorICAgICAgICAgKGdseXBocyAoYW5kIGR0IChkaXNwbGF5LXRhYmxlLXNs
b3QgZHQgJ3NlbGVjdGl2ZS1kaXNwbGF5KSkpKQorICAgIChzdHJpbmctd2lkdGggKGlmIGdseXBo
cyAoY29uY2F0IGdseXBocykgIi4uLiIpKSkpCisKKyhkZWZ1biBkaXJlZC0tZ2V0LWZpbGVuYW1l
LWRpc3BsYXktbGVuZ3RoICgpCisgICJSZXR1cm4gbWF4aW11bSBkaXNwbGF5IGxlbmd0aCBvZiBm
aWxlbmFtZS4KK1doZW4gYGRpcmVkLWZpbGVuYW1lLWRpc3BsYXktbGVuZ3RoJyBpcyBub3QgYW4g
aW50ZWdlciwgdGhlCitmdW5jdGlvbiBhY3R1YWxseSByZXR1cm5zIHRoZSBudW1iZXIgb2YgY29s
dW1ucyBhdmFpbGFibGUgZm9yCitkaXNwbGF5aW5nIHRoZSBmaWxlIG5hbWVzLCBhbmQgc2hvdWxk
IGJlIGNhbGxlZCB3aXRoIHBvaW50IGF0IHRoZQorZmlyc3QgY2hhcmFjdGVyIG9mIHRoZSBmaWxl
IG5hbWUuIgorICAoaWYgKGludGVnZXJwIGRpcmVkLWZpbGVuYW1lLWRpc3BsYXktbGVuZ3RoKQor
ICAgICAgZGlyZWQtZmlsZW5hbWUtZGlzcGxheS1sZW5ndGgKKyAgICAoLSAod2luZG93LW1heC1j
aGFycy1wZXItbGluZSkgMSAoY3VycmVudC1jb2x1bW4pKSkpCisKIAwKIDs7OyBSZXZlcnRpbmcg
YSBkaXJlZCBidWZmZXIKIApAQCAtMjYxNyw2ICsyNjc0LDcgQEAgZGlyZWQtbW9kZQogCW1vZGUt
bGluZS1idWZmZXItaWRlbnRpZmljYXRpb24KIAkocHJvcGVydGl6ZWQtYnVmZmVyLWlkZW50aWZp
Y2F0aW9uICIlMTdiIikpCiAgIChhZGQtdG8taW52aXNpYmlsaXR5LXNwZWMgJyhkaXJlZCAuIHQp
KQorICAoZGlyZWQtZmlsZW5hbWUtdXBkYXRlLWludmlzaWJpbGl0eS1zcGVjKQogICA7OyBJZ25v
cmUgZGlyZWQtaGlkZS1kZXRhaWxzLSogdmFsdWUgb2YgaW52aXNpYmxlIHRleHQgcHJvcGVydHkg
YnkgZGVmYXVsdC4KICAgKHdoZW4gKGVxIGJ1ZmZlci1pbnZpc2liaWxpdHktc3BlYyB0KQogICAg
IChzZXRxIGJ1ZmZlci1pbnZpc2liaWxpdHktc3BlYyAobGlzdCB0KSkpCkBAIC0zMTA2LDYgKzMx
NjQsMTUgQEAgZGlyZWQtaGlkZS1kZXRhaWxzLXVwZGF0ZS1pbnZpc2liaWxpdHktc3BlYwogDAog
Ozs7IEZ1bmN0aW9ucyB0byBoaWRlL3VuaGlkZSB0ZXh0CiAKKyhkZWZ1biBkaXJlZC1maWxlbmFt
ZS11cGRhdGUtaW52aXNpYmlsaXR5LXNwZWMgKCkKKyAgIlVwZGF0ZSBgYnVmZmVyLWludmlzaWJp
bGl0eS1zcGVjJyBmb3IgZmlsZW5hbWVzLgorU3BlY2lmaWNhbGx5LCB0aGUgZmlsZW5hbWUgaW52
aXNpYmlsaXR5IHNwZWMgaXMgYWRkZWQgaW4gRGlyZWQKK2J1ZmZlcnMgYW5kIHJlbW92ZWQgaW4g
V0RpcmVkIGJ1ZmZlcnMuIgorICAoZnVuY2FsbCAoaWYgKGRlcml2ZWQtbW9kZS1wICdkaXJlZC1t
b2RlKQorICAgICAgICAgICAgICAgJ2FkZC10by1pbnZpc2liaWxpdHktc3BlYworICAgICAgICAg
ICAgICdyZW1vdmUtZnJvbS1pbnZpc2liaWxpdHktc3BlYykKKyAgICAgICAgICAgJyhkaXJlZC1m
aWxlbmFtZS1oaWRlIC4gdCkpKQorCiAoZGVmdW4gZGlyZWQtLWZpbmQtaGlkZGVuLXBvcyAoc3Rh
cnQgZW5kKQogICAodGV4dC1wcm9wZXJ0eS1hbnkgc3RhcnQgZW5kICdpbnZpc2libGUgJ2RpcmVk
KSkKIApkaWZmIC0tZ2l0IGEvbGlzcC93ZGlyZWQuZWwgYi9saXNwL3dkaXJlZC5lbAppbmRleCAw
NzlkOTNkNjAxMS4uYjViMDFmMGQwODkgMTAwNjQ0Ci0tLSBhL2xpc3Avd2RpcmVkLmVsCisrKyBi
L2xpc3Avd2RpcmVkLmVsCkBAIC0yNjEsNiArMjYxLDEwIEBAIHdkaXJlZC1jaGFuZ2UtdG8td2Rp
cmVkLW1vZGUKICAgKGFkZC1mdW5jdGlvbiA6b3ZlcnJpZGUgKGxvY2FsICdyZXZlcnQtYnVmZmVy
LWZ1bmN0aW9uKSAjJ3dkaXJlZC1yZXZlcnQpCiAgIChzZXQtYnVmZmVyLW1vZGlmaWVkLXAgbmls
KQogICAoc2V0cSBidWZmZXItdW5kby1saXN0IG5pbCkKKyAgOzsgTm9uLW5pbCBgZGlyZWQtZmls
ZW5hbWUtZGlzcGxheS1sZW5ndGgnIG1heSBjYXVzZSBmaWxlbmFtZXMgdG8gYmUKKyAgOzsgaGlk
ZGVuIHBhcnRseSwgc28gd2UgcmVtb3ZlIGZpbGVuYW1lIGludmlzaWJpbGl0eSBzcGVjCisgIDs7
IHRlbXBvcmFyaWx5IHRvIGVuc3VyZSBmaWxlbmFtZXMgYXJlIHZpc2libGUgZm9yIGVkaXRpbmcu
CisgIChkaXJlZC1maWxlbmFtZS11cGRhdGUtaW52aXNpYmlsaXR5LXNwZWMpCiAgIChydW4tbW9k
ZS1ob29rcyAnd2RpcmVkLW1vZGUtaG9vaykKICAgKG1lc3NhZ2UgIiVzIiAoc3Vic3RpdHV0ZS1j
b21tYW5kLWtleXMKIAkJICJQcmVzcyBcXFt3ZGlyZWQtZmluaXNoLWVkaXRdIHdoZW4gZmluaXNo
ZWQgXApAQCAtNDU2LDYgKzQ2MCw5IEBAIHdkaXJlZC1jaGFuZ2UtdG8tZGlyZWQtbW9kZQogICAo
ZGlyZWQtc29ydC1zZXQtbW9kZS1saW5lKQogICAoZGlyZWQtYWR2ZXJ0aXNlKQogICAoZGlyZWQt
aGlkZS1kZXRhaWxzLXVwZGF0ZS1pbnZpc2liaWxpdHktc3BlYykKKyAgOzsgUmVzdG9yZSBmaWxl
bmFtZSBpbnZpc2liaWxpdHkgc3BlYyB0aGF0IGlzIHJlbW92ZWQgaW4KKyAgOzsgYHdkaXJlZC1j
aGFuZ2UtdG8td2RpcmVkLW1vZGUnLgorICAoZGlyZWQtZmlsZW5hbWUtdXBkYXRlLWludmlzaWJp
bGl0eS1zcGVjKQogICAocmVtb3ZlLWhvb2sgJ2tpbGwtYnVmZmVyLWhvb2sgIyd3ZGlyZWQtY2hl
Y2sta2lsbC1idWZmZXIgdCkKICAgKHJlbW92ZS1ob29rICdiZWZvcmUtY2hhbmdlLWZ1bmN0aW9u
cyAjJ3dkaXJlZC0tYmVmb3JlLWNoYW5nZS1mbiB0KQogICAocmVtb3ZlLWhvb2sgJ2FmdGVyLWNo
YW5nZS1mdW5jdGlvbnMgIyd3ZGlyZWQtLXJlc3RvcmUtcHJvcGVydGllcyB0KQotLSAKMi4yNS4x
Cgo=
--000000000000e32f9e060ab72b42--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67161; Package emacs. Full text available.

Message received at 67161 <at> debbugs.gnu.org:


Received: (at 67161) by debbugs.gnu.org; 21 Nov 2023 17:13:14 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 21 12:13:13 2023
Received: from localhost ([127.0.0.1]:57346 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r5UJF-0000YQ-KD
	for submit <at> debbugs.gnu.org; Tue, 21 Nov 2023 12:13:13 -0500
Received: from relay2-d.mail.gandi.net ([2001:4b98:dc4:8::222]:33061)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>) id 1r5UJC-0000Y8-VG
 for 67161 <at> debbugs.gnu.org; Tue, 21 Nov 2023 12:13:12 -0500
Received: by mail.gandi.net (Postfix) with ESMTPSA id 6BA6E4000C;
 Tue, 21 Nov 2023 17:13:00 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#67161: 30.0.50; [PATCH] Add option
 `dired-filename-display-length'
In-Reply-To: <83a5r7ian7.fsf@HIDDEN> (Eli Zaretskii's message of "Tue, 21 Nov
 2023 13:55:08 +0200")
Organization: LINKOV.NET
References: <CAOQTW-MSpBK4ACpLk8U2m6HJx8HXw21O0kyYZ-i85ETNjyOUcA@HIDDEN>
 <8334x8tqi9.fsf@HIDDEN>
 <CAOQTW-P4+vs+JH8BTL8fL-d1QJXOdYq3i+3O7tALTDs=qHpnzA@HIDDEN>
 <83a5rfrych.fsf@HIDDEN>
 <CAOQTW-M5VaV0Va+ixd2-6SoKb4tPebxviobOB8Qs3Oxb9js9GA@HIDDEN>
 <83sf55q4nc.fsf@HIDDEN>
 <CAOQTW-MhVkj5LBYeguWKE6FsVgovdD0wuEW5bHZdy=01maXW1w@HIDDEN>
 <83jzqfmiuj.fsf@HIDDEN>
 <CAOQTW-NN=nmvs5j6_AwMyrA8v9Zuo_vbn9KNKXPPsfn+J25gGA@HIDDEN>
 <835y1wk4ls.fsf@HIDDEN> <jwv34x0xnsv.fsf-monnier+emacs@HIDDEN>
 <86v89v1qrd.fsf@HIDDEN> <83a5r7ian7.fsf@HIDDEN>
Date: Tue, 21 Nov 2023 19:12:10 +0200
Message-ID: <861qcjnifw.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 67161
Cc: liuhui1610@HIDDEN, 67161 <at> debbugs.gnu.org, monnier@HIDDEN,
 stefankangas@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

>> > I think the idea is that matching invisible text is somewhat
>> > inconvenient, so it's better to temporarily reveal/open that text.
>> > But I think it points to an bug in Isearch: when `isearch-invisible` is
>> > `open` we should match text inside invisible text, regardless if we can
>> > reveal/open that invisible text or not.  IOW `open` should find the
>> > same matches as `t`, the only difference being that it additionally
>> > (tries to) reveal/open the text.
>>
>> This could be a new value like `open-or-match` with a trivial change:
>>
>> @@ -3899,6 +3899,9 @@ isearch-filter-visible
>>  of what `isearch-range-invisible' says."
>>    (and (not (text-property-not-all beg end 'inhibit-isearch nil))
>>         (or (eq search-invisible t)
>> +           (when (eq search-invisible 'open-or-match)
>> +             (isearch-range-invisible beg end)
>> +             t)
>>             (not (isearch-range-invisible beg end)))))
>>
>> But I doubt that it could be enabled by default because in many cases
>> it's too confusing for users to stop at a match that is not visible.
>
> Isn't it possible to unhide the invisible text by temporarily
> manipulating buffer-invisibility-spec?

Do you mean unhiding text properties?




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67161; Package emacs. Full text available.

Message received at 67161 <at> debbugs.gnu.org:


Received: (at 67161) by debbugs.gnu.org; 21 Nov 2023 11:56:12 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 21 06:56:12 2023
Received: from localhost ([127.0.0.1]:55316 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r5PMR-00065S-RA
	for submit <at> debbugs.gnu.org; Tue, 21 Nov 2023 06:56:12 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:48802)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1r5PMO-00065C-ML
 for 67161 <at> debbugs.gnu.org; Tue, 21 Nov 2023 06:56:10 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1r5PME-000566-IM; Tue, 21 Nov 2023 06:55:58 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=wibiq5bgEJFul+hewl6lHpyA/8VLUoz7/xevTl8Skhc=; b=li72656iIMpF
 BTTb8lxN9JIKkYz1klEsNrucDfmV7QnGzKVkSpbUU3x/p7g28Do+etURQEehEB3CS7lqxIKGB9aG1
 20+BwPe9SQUwvBM2GEoNiQDgb4l29YYtc+lWX3n8N/VrwiljonP/Imj61/afnvnENOzIaP+YZQ8yw
 D8PbHEPY2l9N1fu+yJo5t5XRM+wKrwtqT/RIYRhKy4y9fF5rMdma6bw8k2lsxim5T731Pf4B5oOJT
 XAKv/Xcq+j1YCNQSAMVTNpj7hgomkMGazoBuLiW/L6JRH/nc6EIWRB0QesLAuk+fNgHF/gLAGhqV3
 de9BxK23qbVYT1O1Ylajjg==;
Date: Tue, 21 Nov 2023 13:55:08 +0200
Message-Id: <83a5r7ian7.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Juri Linkov <juri@HIDDEN>
In-Reply-To: <86v89v1qrd.fsf@HIDDEN> (message from Juri Linkov on
 Tue, 21 Nov 2023 09:52:02 +0200)
Subject: Re: bug#67161: 30.0.50; [PATCH] Add option
 `dired-filename-display-length'
References: <CAOQTW-MSpBK4ACpLk8U2m6HJx8HXw21O0kyYZ-i85ETNjyOUcA@HIDDEN>
 <8334x8tqi9.fsf@HIDDEN>
 <CAOQTW-P4+vs+JH8BTL8fL-d1QJXOdYq3i+3O7tALTDs=qHpnzA@HIDDEN>
 <83a5rfrych.fsf@HIDDEN>
 <CAOQTW-M5VaV0Va+ixd2-6SoKb4tPebxviobOB8Qs3Oxb9js9GA@HIDDEN>
 <83sf55q4nc.fsf@HIDDEN>
 <CAOQTW-MhVkj5LBYeguWKE6FsVgovdD0wuEW5bHZdy=01maXW1w@HIDDEN>
 <83jzqfmiuj.fsf@HIDDEN>
 <CAOQTW-NN=nmvs5j6_AwMyrA8v9Zuo_vbn9KNKXPPsfn+J25gGA@HIDDEN>
 <835y1wk4ls.fsf@HIDDEN> <jwv34x0xnsv.fsf-monnier+emacs@HIDDEN> 
 <86v89v1qrd.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 67161
Cc: liuhui1610@HIDDEN, 67161 <at> debbugs.gnu.org, monnier@HIDDEN,
 stefankangas@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Juri Linkov <juri@HIDDEN>
> Cc: Eli Zaretskii <eliz@HIDDEN>,  Liu Hui <liuhui1610@HIDDEN>,
>   stefankangas@HIDDEN,  67161 <at> debbugs.gnu.org
> Date: Tue, 21 Nov 2023 09:52:02 +0200
> 
> > I think the idea is that matching invisible text is somewhat
> > inconvenient, so it's better to temporarily reveal/open that text.
> > But I think it points to an bug in Isearch: when `isearch-invisible` is
> > `open` we should match text inside invisible text, regardless if we can
> > reveal/open that invisible text or not.  IOW `open` should find the
> > same matches as `t`, the only difference being that it additionally
> > (tries to) reveal/open the text.
> 
> This could be a new value like `open-or-match` with a trivial change:
> 
> @@ -3899,6 +3899,9 @@ isearch-filter-visible
>  of what `isearch-range-invisible' says."
>    (and (not (text-property-not-all beg end 'inhibit-isearch nil))
>         (or (eq search-invisible t)
> +           (when (eq search-invisible 'open-or-match)
> +             (isearch-range-invisible beg end)
> +             t)
>             (not (isearch-range-invisible beg end)))))
> 
> But I doubt that it could be enabled by default because in many cases
> it's too confusing for users to stop at a match that is not visible.

Isn't it possible to unhide the invisible text by temporarily
manipulating buffer-invisibility-spec?




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67161; Package emacs. Full text available.

Message received at 67161 <at> debbugs.gnu.org:


Received: (at 67161) by debbugs.gnu.org; 21 Nov 2023 08:31:00 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 21 03:31:00 2023
Received: from localhost ([127.0.0.1]:55125 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r5M9r-0000Sh-Lb
	for submit <at> debbugs.gnu.org; Tue, 21 Nov 2023 03:30:59 -0500
Received: from relay4-d.mail.gandi.net ([2001:4b98:dc4:8::224]:59653)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>) id 1r5M9m-0000SN-QE
 for 67161 <at> debbugs.gnu.org; Tue, 21 Nov 2023 03:30:58 -0500
Received: by mail.gandi.net (Postfix) with ESMTPSA id 7E4BDE000D;
 Tue, 21 Nov 2023 08:30:43 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Stefan Monnier <monnier@HIDDEN>
Subject: Re: bug#67161: 30.0.50; [PATCH] Add option
 `dired-filename-display-length'
In-Reply-To: <jwv34x0xnsv.fsf-monnier+emacs@HIDDEN> (Stefan Monnier's message
 of "Mon, 20 Nov 2023 13:55:58 -0500")
Organization: LINKOV.NET
References: <CAOQTW-MSpBK4ACpLk8U2m6HJx8HXw21O0kyYZ-i85ETNjyOUcA@HIDDEN>
 <8334x8tqi9.fsf@HIDDEN>
 <CAOQTW-P4+vs+JH8BTL8fL-d1QJXOdYq3i+3O7tALTDs=qHpnzA@HIDDEN>
 <83a5rfrych.fsf@HIDDEN>
 <CAOQTW-M5VaV0Va+ixd2-6SoKb4tPebxviobOB8Qs3Oxb9js9GA@HIDDEN>
 <83sf55q4nc.fsf@HIDDEN>
 <CAOQTW-MhVkj5LBYeguWKE6FsVgovdD0wuEW5bHZdy=01maXW1w@HIDDEN>
 <83jzqfmiuj.fsf@HIDDEN>
 <CAOQTW-NN=nmvs5j6_AwMyrA8v9Zuo_vbn9KNKXPPsfn+J25gGA@HIDDEN>
 <835y1wk4ls.fsf@HIDDEN> <jwv34x0xnsv.fsf-monnier+emacs@HIDDEN>
Date: Tue, 21 Nov 2023 09:52:02 +0200
Message-ID: <86v89v1qrd.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 67161
Cc: Liu Hui <liuhui1610@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
 67161 <at> debbugs.gnu.org, stefankangas@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

>>> in the attached patch, then text in hidden part can be matched
>>> regardless of search-invisible being open or t. It also has a bonus
>>> that hidden text can be revealed during isearch.
>
> Yes, using an overlay sounds like a better choice here, thanks.
>
>> Juri, this seems to be a usability bug?  Why does Isearch only look
>> into invisible overlay properties, but not text properties?  IOW, why
>> doesn't "M-s i" set the value of isearch-invisible to t, not 'open'?
>
> I think the idea is that matching invisible text is somewhat
> inconvenient, so it's better to temporarily reveal/open that text.
> But I think it points to an bug in Isearch: when `isearch-invisible` is
> `open` we should match text inside invisible text, regardless if we can
> reveal/open that invisible text or not.  IOW `open` should find the
> same matches as `t`, the only difference being that it additionally
> (tries to) reveal/open the text.

This could be a new value like `open-or-match` with a trivial change:

@@ -3899,6 +3899,9 @@ isearch-filter-visible
 of what `isearch-range-invisible' says."
   (and (not (text-property-not-all beg end 'inhibit-isearch nil))
        (or (eq search-invisible t)
+           (when (eq search-invisible 'open-or-match)
+             (isearch-range-invisible beg end)
+             t)
            (not (isearch-range-invisible beg end)))))

But I doubt that it could be enabled by default because in many cases
it's too confusing for users to stop at a match that is not visible.

OTOH, there was a request about informing the user about hidden matches.
So now the Isearch prompt shows the number of invisible matches.
Having this information the user can reveal in some way and visually
inspect these matches.

>> In any case, the differences between properties and
>> overlays is unusual and IMO a misfeature.  Can this be fixed?
>
> Indeed, it would be good to implement some way to reveal/open invisible
> text made invisible via text-properties rather than overlays.
> That also applies to `reveal-mode`, of course.

Would be nice to have such useful feature.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67161; Package emacs. Full text available.

Message received at 67161 <at> debbugs.gnu.org:


Received: (at 67161) by debbugs.gnu.org; 20 Nov 2023 19:18:17 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Nov 20 14:18:16 2023
Received: from localhost ([127.0.0.1]:54606 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r59mi-00048Q-Fd
	for submit <at> debbugs.gnu.org; Mon, 20 Nov 2023 14:18:16 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:42978)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1r59mg-00048C-5Z
 for 67161 <at> debbugs.gnu.org; Mon, 20 Nov 2023 14:18:15 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1r59mX-0001pX-Nd; Mon, 20 Nov 2023 14:18:05 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=f0yJna8PjYSXkNy6uDZjTdSR0+LVkVtLjB2eheG7S/Q=; b=XSIkA6vTqfu/
 8TZZv0Hmd1Z6IPbJpaMbA6IDgDz9/qVlfWjREe1NuxL0AMPk6tflf/IuqrZW7+kvR+I358yxQqTqU
 pGwCzrSwAcq5Ksb1r2nnhk9RbyE/oTs0dK2QqmFje9e+NLm2mk/1YwNH2HFhoGokFlBqAsDcB3KZ2
 pJAiy5T4ghEeDuhzqxbv9p3dFQ5gqnOFP9WEcXlChOYHqvGhOIuYnMF1K+bpppdcct1uHeOPmrEQA
 Hv2FjArH+DgkWKjg/X4n1E5mSDSkFN/yEewwPg/W1h4N1iZOV19p7Z3OngIZc8QOrT6AT1nNn4q4Q
 F7iyulN8XQcZTMx/KZ9ONw==;
Date: Mon, 20 Nov 2023 21:17:35 +0200
Message-Id: <83leasi69c.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Stefan Monnier <monnier@HIDDEN>
In-Reply-To: <jwv34x0xnsv.fsf-monnier+emacs@HIDDEN> (message from Stefan
 Monnier on Mon, 20 Nov 2023 13:55:58 -0500)
Subject: Re: bug#67161: 30.0.50; [PATCH] Add option
 `dired-filename-display-length'
References: <CAOQTW-MSpBK4ACpLk8U2m6HJx8HXw21O0kyYZ-i85ETNjyOUcA@HIDDEN>
 <8334x8tqi9.fsf@HIDDEN>
 <CAOQTW-P4+vs+JH8BTL8fL-d1QJXOdYq3i+3O7tALTDs=qHpnzA@HIDDEN>
 <83a5rfrych.fsf@HIDDEN>
 <CAOQTW-M5VaV0Va+ixd2-6SoKb4tPebxviobOB8Qs3Oxb9js9GA@HIDDEN>
 <83sf55q4nc.fsf@HIDDEN>
 <CAOQTW-MhVkj5LBYeguWKE6FsVgovdD0wuEW5bHZdy=01maXW1w@HIDDEN>
 <83jzqfmiuj.fsf@HIDDEN>
 <CAOQTW-NN=nmvs5j6_AwMyrA8v9Zuo_vbn9KNKXPPsfn+J25gGA@HIDDEN>
 <835y1wk4ls.fsf@HIDDEN> <jwv34x0xnsv.fsf-monnier+emacs@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 67161
Cc: liuhui1610@HIDDEN, 67161 <at> debbugs.gnu.org, stefankangas@HIDDEN,
 juri@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Stefan Monnier <monnier@HIDDEN>
> Cc: Liu Hui <liuhui1610@HIDDEN>,  Juri Linkov <juri@HIDDEN>,
>   stefankangas@HIDDEN,  67161 <at> debbugs.gnu.org
> Date: Mon, 20 Nov 2023 13:55:58 -0500
> 
> > Juri, this seems to be a usability bug?  Why does Isearch only look
> > into invisible overlay properties, but not text properties?  IOW, why
> > doesn't "M-s i" set the value of isearch-invisible to t, not 'open'?
> 
> I think the idea is that matching invisible text is somewhat
> inconvenient, so it's better to temporarily reveal/open that text.
> But I think it points to an bug in Isearch: when `isearch-invisible` is
> `open` we should match text inside invisible text, regardless if we can
> reveal/open that invisible text or not.  IOW `open` should find the
> same matches as `t`, the only difference being that it additionally
> (tries to) reveal/open the text.

Agreed.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67161; Package emacs. Full text available.

Message received at 67161 <at> debbugs.gnu.org:


Received: (at 67161) by debbugs.gnu.org; 20 Nov 2023 18:58:45 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Nov 20 13:58:45 2023
Received: from localhost ([127.0.0.1]:54565 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r59To-0003OQ-OK
	for submit <at> debbugs.gnu.org; Mon, 20 Nov 2023 13:58:45 -0500
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:60974)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <monnier@HIDDEN>) id 1r59Tl-0003Nr-UB
 for 67161 <at> debbugs.gnu.org; Mon, 20 Nov 2023 13:58:42 -0500
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 5A8C3100068;
 Mon, 20 Nov 2023 13:58:34 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1700506713;
 bh=MrxR6apfXC/ncSfKiyO8oBYmmnWgff14wNNfaPPBwOA=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=RVCc3sM7mrzNUFzb4pbVZxFFww7AtgZBQXvY8WP5M0obSoIle8rXzTVYj2rjJobuJ
 04xgPTaHZKqwZkFRPHjEmj0r1D5V61X56whNV3G7xbZe3SzGuMujTtN48XoT+K32v8
 0nCI+5hVYJ+AImRNtbE3ztM3ZwyiGjML2TJmaKoFUdIEvEWnoZhkuibxylk62IhCCV
 bTjeJbY9GQYxkio7aK7+Om6s01tpZAsFRPWMEt78EJBggAAteCGcpVd6abs/NM0D0q
 p1iUNc9xl/OHxHvRPVefSN8GDhyIutvQGbto9ZNchbx/rpW+uFk11PDggpbylsPmXB
 u5AamQJzzbMhw==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id B0989100033;
 Mon, 20 Nov 2023 13:58:33 -0500 (EST)
Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9B20A1202E0;
 Mon, 20 Nov 2023 13:58:33 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#67161: 30.0.50; [PATCH] Add option
 `dired-filename-display-length'
In-Reply-To: <835y1wk4ls.fsf@HIDDEN> (Eli Zaretskii's message of "Mon, 20 Nov
 2023 14:10:23 +0200")
Message-ID: <jwv34x0xnsv.fsf-monnier+emacs@HIDDEN>
References: <CAOQTW-MSpBK4ACpLk8U2m6HJx8HXw21O0kyYZ-i85ETNjyOUcA@HIDDEN>
 <8334x8tqi9.fsf@HIDDEN>
 <CAOQTW-P4+vs+JH8BTL8fL-d1QJXOdYq3i+3O7tALTDs=qHpnzA@HIDDEN>
 <83a5rfrych.fsf@HIDDEN>
 <CAOQTW-M5VaV0Va+ixd2-6SoKb4tPebxviobOB8Qs3Oxb9js9GA@HIDDEN>
 <83sf55q4nc.fsf@HIDDEN>
 <CAOQTW-MhVkj5LBYeguWKE6FsVgovdD0wuEW5bHZdy=01maXW1w@HIDDEN>
 <83jzqfmiuj.fsf@HIDDEN>
 <CAOQTW-NN=nmvs5j6_AwMyrA8v9Zuo_vbn9KNKXPPsfn+J25gGA@HIDDEN>
 <835y1wk4ls.fsf@HIDDEN>
Date: Mon, 20 Nov 2023 13:55:58 -0500
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL 0.097 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
 DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
 domain T_SCC_BODY_TEXT_LINE    -0.01 -
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 67161
Cc: Liu Hui <liuhui1610@HIDDEN>, 67161 <at> debbugs.gnu.org,
 stefankangas@HIDDEN, Juri Linkov <juri@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

>> in the attached patch, then text in hidden part can be matched
>> regardless of search-invisible being open or t. It also has a bonus
>> that hidden text can be revealed during isearch.

Yes, using an overlay sounds like a better choice here, thanks.

> Juri, this seems to be a usability bug?  Why does Isearch only look
> into invisible overlay properties, but not text properties?  IOW, why
> doesn't "M-s i" set the value of isearch-invisible to t, not 'open'?

I think the idea is that matching invisible text is somewhat
inconvenient, so it's better to temporarily reveal/open that text.
But I think it points to an bug in Isearch: when `isearch-invisible` is
`open` we should match text inside invisible text, regardless if we can
reveal/open that invisible text or not.  IOW `open` should find the
same matches as `t`, the only difference being that it additionally
(tries to) reveal/open the text.

> In any case, the differences between properties and
> overlays is unusual and IMO a misfeature.  Can this be fixed?

Indeed, it would be good to implement some way to reveal/open invisible
text made invisible via text-properties rather than overlays.
That also applies to `reveal-mode`, of course.


        Stefan





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67161; Package emacs. Full text available.

Message received at 67161 <at> debbugs.gnu.org:


Received: (at 67161) by debbugs.gnu.org; 20 Nov 2023 18:42:56 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Nov 20 13:42:56 2023
Received: from localhost ([127.0.0.1]:54536 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r59EV-0002Zs-OH
	for submit <at> debbugs.gnu.org; Mon, 20 Nov 2023 13:42:56 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:37760)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1r59ES-0002Zd-QT
 for 67161 <at> debbugs.gnu.org; Mon, 20 Nov 2023 13:42:54 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1r59EK-00087f-OM; Mon, 20 Nov 2023 13:42:44 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=NPRnGAvVWYe4UuTUfrMwpOKqw6ONNXku4iueF4Ay+Jk=; b=gRa53/R0WcbC
 GbgwKHUFaVOvoLtbsip7rVeHnXvHNbEYdb6Wl+cwiu+ZZVgJrXPHFimYmdc4CIPT75OYu40qSnPrI
 BtqNhj/t5+qxzPU5f1A/j3crpyhCR3dwPFbrH/avqAU7VDGpreG2V/vx7+KYxq4F6/h+x1wHjnnvL
 EXzqJrYWTUL4zUKduJH3bXiOt3VWhl2vqEaqxGtWZO6b8nN7tmMdVW8qL8Ql5Bpp5uK2fVl8O/2+d
 Fl8zGj925jho0ZKPHYjnnfCbF+etciadIPPQZ+ViVLkRPfcZ23A1jzGTpvylEynR0HiY1C9ABbcR6
 y6vUNibSReCeqd5DgcuQhA==;
Date: Mon, 20 Nov 2023 20:42:30 +0200
Message-Id: <83o7foi7vt.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Juri Linkov <juri@HIDDEN>
In-Reply-To: <86o7foqpu8.fsf@HIDDEN> (message from Juri Linkov on
 Mon, 20 Nov 2023 19:54:27 +0200)
Subject: Re: bug#67161: 30.0.50; [PATCH] Add option
 `dired-filename-display-length'
References: <CAOQTW-MSpBK4ACpLk8U2m6HJx8HXw21O0kyYZ-i85ETNjyOUcA@HIDDEN>
 <8334x8tqi9.fsf@HIDDEN>
 <CAOQTW-P4+vs+JH8BTL8fL-d1QJXOdYq3i+3O7tALTDs=qHpnzA@HIDDEN>
 <83a5rfrych.fsf@HIDDEN>
 <CAOQTW-M5VaV0Va+ixd2-6SoKb4tPebxviobOB8Qs3Oxb9js9GA@HIDDEN>
 <83sf55q4nc.fsf@HIDDEN>
 <CAOQTW-MhVkj5LBYeguWKE6FsVgovdD0wuEW5bHZdy=01maXW1w@HIDDEN>
 <83jzqfmiuj.fsf@HIDDEN>
 <CAOQTW-NN=nmvs5j6_AwMyrA8v9Zuo_vbn9KNKXPPsfn+J25gGA@HIDDEN>
 <835y1wk4ls.fsf@HIDDEN> <86o7foqpu8.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 67161
Cc: liuhui1610@HIDDEN, 67161 <at> debbugs.gnu.org, stefankangas@HIDDEN,
 monnier@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Juri Linkov <juri@HIDDEN>
> Cc: Liu Hui <liuhui1610@HIDDEN>,  stefankangas@HIDDEN,
>   monnier@HIDDEN,  67161 <at> debbugs.gnu.org
> Date: Mon, 20 Nov 2023 19:54:27 +0200
> 
> >> Therefore, I would like to change
> >>
> >>   (put-text-property ell-beg (point) 'invisible 'dired-filename-hide)
> >>
> >> to
> >>
> >>   (let ((ov (make-overlay ell-beg (point))))
> >>     (overlay-put ov 'invisible 'dired-filename-hide)
> >>     (overlay-put ov 'isearch-open-invisible t)
> >>     (overlay-put ov 'evaporate t))
> >
> > Juri, this seems to be a usability bug?  Why does Isearch only look
> > into invisible overlay properties, but not text properties?  IOW, why
> > doesn't "M-s i" set the value of isearch-invisible to t, not 'open'?
> > Or maybe 'open' should also search inside text properties, not just
> > overlays?  In any case, the differences between properties and
> > overlays is unusual and IMO a misfeature.  Can this be fixed?
> 
> I recall Ihor implemented the revealing of invisible text properties
> for Org-mode when overlays were very slow.  But now overlays are
> optimized, so Liu is absolutely right that better to use overlays.

That might be so, but I was asking about Isearch being able to find
matches inside invisible text, not about the Dired feature.  Why
cannot a user tell Isearch to find text that is invisible due to text
properties?




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67161; Package emacs. Full text available.

Message received at 67161 <at> debbugs.gnu.org:


Received: (at 67161) by debbugs.gnu.org; 20 Nov 2023 17:57:31 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Nov 20 12:57:30 2023
Received: from localhost ([127.0.0.1]:54477 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r58WY-0001LL-M0
	for submit <at> debbugs.gnu.org; Mon, 20 Nov 2023 12:57:30 -0500
Received: from relay8-d.mail.gandi.net ([2001:4b98:dc4:8::228]:50731)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>) id 1r58WW-0001L4-UM
 for 67161 <at> debbugs.gnu.org; Mon, 20 Nov 2023 12:57:29 -0500
Received: by mail.gandi.net (Postfix) with ESMTPSA id 548A41BF20B;
 Mon, 20 Nov 2023 17:57:17 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#67161: 30.0.50; [PATCH] Add option
 `dired-filename-display-length'
In-Reply-To: <835y1wk4ls.fsf@HIDDEN> (Eli Zaretskii's message of "Mon, 20 Nov
 2023 14:10:23 +0200")
Organization: LINKOV.NET
References: <CAOQTW-MSpBK4ACpLk8U2m6HJx8HXw21O0kyYZ-i85ETNjyOUcA@HIDDEN>
 <8334x8tqi9.fsf@HIDDEN>
 <CAOQTW-P4+vs+JH8BTL8fL-d1QJXOdYq3i+3O7tALTDs=qHpnzA@HIDDEN>
 <83a5rfrych.fsf@HIDDEN>
 <CAOQTW-M5VaV0Va+ixd2-6SoKb4tPebxviobOB8Qs3Oxb9js9GA@HIDDEN>
 <83sf55q4nc.fsf@HIDDEN>
 <CAOQTW-MhVkj5LBYeguWKE6FsVgovdD0wuEW5bHZdy=01maXW1w@HIDDEN>
 <83jzqfmiuj.fsf@HIDDEN>
 <CAOQTW-NN=nmvs5j6_AwMyrA8v9Zuo_vbn9KNKXPPsfn+J25gGA@HIDDEN>
 <835y1wk4ls.fsf@HIDDEN>
Date: Mon, 20 Nov 2023 19:54:27 +0200
Message-ID: <86o7foqpu8.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 67161
Cc: Liu Hui <liuhui1610@HIDDEN>, 67161 <at> debbugs.gnu.org,
 stefankangas@HIDDEN, monnier@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

>> Therefore, I would like to change
>>
>>   (put-text-property ell-beg (point) 'invisible 'dired-filename-hide)
>>
>> to
>>
>>   (let ((ov (make-overlay ell-beg (point))))
>>     (overlay-put ov 'invisible 'dired-filename-hide)
>>     (overlay-put ov 'isearch-open-invisible t)
>>     (overlay-put ov 'evaporate t))
>
> Juri, this seems to be a usability bug?  Why does Isearch only look
> into invisible overlay properties, but not text properties?  IOW, why
> doesn't "M-s i" set the value of isearch-invisible to t, not 'open'?
> Or maybe 'open' should also search inside text properties, not just
> overlays?  In any case, the differences between properties and
> overlays is unusual and IMO a misfeature.  Can this be fixed?

I recall Ihor implemented the revealing of invisible text properties
for Org-mode when overlays were very slow.  But now overlays are
optimized, so Liu is absolutely right that better to use overlays.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67161; Package emacs. Full text available.

Message received at 67161 <at> debbugs.gnu.org:


Received: (at 67161) by debbugs.gnu.org; 20 Nov 2023 17:21:10 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Nov 20 12:21:10 2023
Received: from localhost ([127.0.0.1]:54365 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r57xO-0000E2-Az
	for submit <at> debbugs.gnu.org; Mon, 20 Nov 2023 12:21:10 -0500
Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:39366)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <drew.adams@HIDDEN>) id 1r57xJ-0000Da-7H
 for 67161 <at> debbugs.gnu.org; Mon, 20 Nov 2023 12:21:08 -0500
Received: from pps.filterd (m0246630.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id
 3AKHJ7Vl022037; Mon, 20 Nov 2023 17:21:02 GMT
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com;
 h=from : to : cc :
 subject : date : message-id : references : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2023-03-30;
 bh=GCwHMyhhoMTueCH58G26AtRJNuLNnnp+12JJyrG8E0c=;
 b=H1CeMAXpt+OXpb/vR6Qe1Ih8t3XR1DDSE5IV9xifL2JZ8DcpSjcPg1yQ7Qe2z14j3F/s
 +qzyeSEGvcEvw9sBUoB7O+WwjMoNghST0xSotR6pMDsr+W3/+ichAoC7XhMW45Fv3aWA
 5JSbrFWtzlXcm8o/zkQJNpebOdfRAIuOKh+wJO6pkA5bZfP+k2Sqm1sD39S8ycHW66c9
 o3yjtS4R+EvHVHZptrWw8yWQ0zqoyi3PnePJF4ZlxQ+o55qsfZ9EXa4KOl7LJ3y6rljk
 rYgZ7xuQHAIs8WX2+kWJXOkqXu+OvelIOYFdPK0HiJQLPjOrpjuLY5Pzl1ovhzSSaEH9 sg== 
Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com
 (iadpaimrmta01.appoci.oracle.com [130.35.100.223])
 by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3uekpek7ju-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Mon, 20 Nov 2023 17:21:01 +0000
Received: from pps.filterd
 (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1])
 by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19)
 with ESMTP id 3AKGS155037512; Mon, 20 Nov 2023 17:21:01 GMT
Received: from nam10-dm6-obe.outbound.protection.outlook.com
 (mail-dm6nam10lp2100.outbound.protection.outlook.com [104.47.58.100])
 by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id
 3uekq5pn91-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Mon, 20 Nov 2023 17:21:00 +0000
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZDOkISW0+/Dg2rAgYsaInEtn8qTowPZq23V9SxsxsOpjf3KRLXRP5G+2fLqmHl9M+pYdfKEsPuW7bOa8YbYaD7Kusjz017X69k6yThocAujQGpJy4RmVnpCTITQjdGzJKoapR271tGY33fdj7C2TCiO47L2N0nqiJCKC1aXRMcPfxeTAnmmS/HOgw6eaTAJIrgE1/+in7CLIcC/fyEI2dncX83JSuwqLd73qnTaCfXbQFDAoPJdB1HZvuooVWVIBCSi5CutnmDFBahmdgfjUWEL3dYfcb6qitOiA2000Z1czzW+ZBxs9lVX301JVgamuSs+ZLYtr2KSDiV6uDTo4SA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GCwHMyhhoMTueCH58G26AtRJNuLNnnp+12JJyrG8E0c=;
 b=NwFwY8XEO42Rkn9nVxQ74dNHwRkxPN52EIYZLNTnXDxVpNdAnKZ+RY6xpcgzHivTekqibcmbO09Z/bEkY0bUJIujUrS3QOgbAzwTmEoGGg9eb+VCxjMxssxYvX0TwDinnqWRS9yQT0zNFq8nHXzKaaevWi0coLnPIv3E+2SB/R1YBNTZevu9eQTMdo4t689jJJ3Q7cfLlscIM5Eh4+ptDZnDDPuD0n72iJibJyrgdzneckAl5Qm3Den30IBYQk/3GDoabTVybrvUO2wown2b1fo+fEC2JyHGHgo7W0/IqmqcB/hYJ+0QUWp6erCK0vLHuvRkAIpBsyzwByRaz4cpzg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=GCwHMyhhoMTueCH58G26AtRJNuLNnnp+12JJyrG8E0c=;
 b=BZrriJUCL1mZJjQcpBvnZYjIBoRduSgNdpLhKou9Mh2BZEzUX+xGIdikwyKEhgqDwC/HU8DzTN2cB52mrBcCBPkxxmyvZ2AbKubh2uFSitU9YTvip4cW9zkvJEOjfRmfvpX+AAxdzbRz0a4hDPfBdb7w2p1qbKEgwijJcShIO48=
Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19)
 by DS7PR10MB5327.namprd10.prod.outlook.com (2603:10b6:5:3b1::15) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.27; Mon, 20 Nov
 2023 17:20:59 +0000
Received: from SJ0PR10MB5488.namprd10.prod.outlook.com
 ([fe80::3b4c:a669:c229:47b4]) by SJ0PR10MB5488.namprd10.prod.outlook.com
 ([fe80::3b4c:a669:c229:47b4%7]) with mapi id 15.20.7002.027; Mon, 20 Nov 2023
 17:20:58 +0000
From: Drew Adams <drew.adams@HIDDEN>
To: Liu Hui <liuhui1610@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>
Subject: RE: [External] : bug#67161: 30.0.50; [PATCH] Add option
 `dired-filename-display-length'
Thread-Topic: [External] : bug#67161: 30.0.50; [PATCH] Add option
 `dired-filename-display-length'
Thread-Index: AQHaG2r697We1MltSUGxvjw221PiTrCDdGsA
Date: Mon, 20 Nov 2023 17:20:58 +0000
Message-ID: <SJ0PR10MB54887506E9ACB7BCED175802F3B4A@HIDDEN>
References: <CAOQTW-MSpBK4ACpLk8U2m6HJx8HXw21O0kyYZ-i85ETNjyOUcA@HIDDEN>
 <8334x8tqi9.fsf@HIDDEN>
 <CAOQTW-P4+vs+JH8BTL8fL-d1QJXOdYq3i+3O7tALTDs=qHpnzA@HIDDEN>
 <83a5rfrych.fsf@HIDDEN>
 <CAOQTW-M5VaV0Va+ixd2-6SoKb4tPebxviobOB8Qs3Oxb9js9GA@HIDDEN>
 <83sf55q4nc.fsf@HIDDEN>
 <CAOQTW-MhVkj5LBYeguWKE6FsVgovdD0wuEW5bHZdy=01maXW1w@HIDDEN>
 <83jzqfmiuj.fsf@HIDDEN>
 <CAOQTW-NN=nmvs5j6_AwMyrA8v9Zuo_vbn9KNKXPPsfn+J25gGA@HIDDEN>
In-Reply-To: <CAOQTW-NN=nmvs5j6_AwMyrA8v9Zuo_vbn9KNKXPPsfn+J25gGA@HIDDEN>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: SJ0PR10MB5488:EE_|DS7PR10MB5327:EE_
x-ms-office365-filtering-correlation-id: ca71154f-2b1b-4e3a-63cb-08dbe9ed1010
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: pDoGtSZHDWTVJ+UqB+5clVo6FVFcZIKFzs7nVLrlkCKISkBns4TbFKExLggkva5bq7+QP0DSbiZtnDAvL3nesQIcodByettnxl6O0/LcpUzugkvV5Oqz7oZ5FEl5BZULQZfu00ihAJb94qLl4Ycq5lW7AplFK1OYuJhYRaYv54V7LPLDvTbd9RU/JTqv/U/Dq4xnHbCXeYGfd359p/Ga/QfNniQU9E92piIiKIVtor4K5fIhC/hSjjjIDfgppUaZRldU1AbyZt5xZQxas+rwpEg+lVZEEBTX6SfCIwgN8IbMqb+1ZQF85p5dl1BItp/+TuVwNkKROeupTJDlxL3c3U97ZK37PXySZwsLS4obzCQWKTF+D7PmUncrTLf5Y4uLUPvUknon6x28Ba7VfhzeQYTEFMGUfYDHKcCUikebKeXdDMwQj0mOCGPFe6zSMh1C0k1T2Cv/df/dFe2ekqr31a7W7VdgEFJ3PH+SpTk7TSvdyQjxNVSqeDp3qIm9nGnN3+EoX2NnxD12gcHKdhz2akHIWCs0Za+liutlodAe4zbAp4d8oN85GNDJ5ULcnWUizQQYOfIcHnOnliRgMb1bzjxo1B/3obaj+BJBCf1YjvfOiTRX0OY/0bKSniF0wbfZWaDJFBPogi1h/UBXdlvmxQ==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(13230031)(346002)(366004)(376002)(39860400002)(136003)(396003)(230922051799003)(64100799003)(186009)(1800799012)(451199024)(8936002)(122000001)(110136005)(71200400001)(478600001)(7696005)(6506007)(64756008)(54906003)(66476007)(66446008)(66556008)(316002)(66946007)(9686003)(26005)(55016003)(8676002)(4326008)(38100700002)(76116006)(5660300002)(44832011)(4744005)(86362001)(2906002)(33656002)(41300700001)(52536014)(38070700009)(81973001);
 DIR:OUT; SFP:1101; 
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NFJYaThaTnJIMVU5WkEzT3pRc3dITnpvbGwvSHNob3pKRVNLa3VUMHNGNGxm?=
 =?utf-8?B?ZFFKQ0ZLSjVKOVlKZTR4ejdjblA3S0JrSmFWTHhzNnZ3TVZta2Zra20yTXdr?=
 =?utf-8?B?d1Y5OHdRMm5MajNUUzZUL01vRlZMelVJZWNXamc1Q2RFVzFWdTBWVCtlWE8r?=
 =?utf-8?B?N3ZocTFYRDk1YUU2MG83Q2w3V21MNnJjY0dPc25va1M2VEIxazdaUGUzWjl4?=
 =?utf-8?B?TTRDYXUwbWJicWhGaU1veWc4bW51RWhjeDBwNnUvUlZGSmk4QWFEZ0NxV2kx?=
 =?utf-8?B?NG1hSk11dVpXcm5MQStvZEpXSGRTNkhTTEVZanhWRWt3Mmt1UnpiYlc1N3Ft?=
 =?utf-8?B?S2tBSUlCM2duaXk3NkpCYTVOYVFQd1ZFN3RtQW13UitIVldZRFZRMkhKVjlo?=
 =?utf-8?B?bmwwMU9pcmtYK2NPYUhiUk5HVENhODZXYzBXdFdmck85dWVLbVhsazFQRElP?=
 =?utf-8?B?MjRmVllqSVhtaFZXVVlSVHgwK2laZ1JJcERsYWRsbW1tVFhxSFkvK1VnVFVT?=
 =?utf-8?B?d3htR0V3SktWVjIvald5WXl2WFlhSFR2dGg5TkpUcHRsUitQUktZUE9ySGxW?=
 =?utf-8?B?UFh0R0pLcG90VjVoTllzNC9pdm1YOW16cGZLU3FVUnp5dmJORFhoMlpLTE9h?=
 =?utf-8?B?SDQrUEtENFdlTldzRjlBT2M2amJkUXczZXZKSjUvSkk2UjlFbmtIMVhacXBO?=
 =?utf-8?B?c3RCd0QwWkE1NWV3Q2Zsa3NIL04xVmFlcVZ1cEFWRkxoQnNhdkhvRW54clc0?=
 =?utf-8?B?RzZ5OXJsbUpXaTI2U1BlTUhCMjkwWHRFSG93NGNiV3Qxd25DakZsKy9MalZV?=
 =?utf-8?B?WXEzSTZmZXl5MlVTR3Y0TW8wdGVWQ0hPS2FNZElSMlBvcWlPR1djdmdRN2pm?=
 =?utf-8?B?UTFpdUdxelRlbU1XWHpEc0RYRm9LWlNRclA0aFhtNitGRENFMkIvMmNWY0No?=
 =?utf-8?B?bUhCT1RXRVN1b255VUU3Qlc3UmJMMnRhdnlQaE5wTDhQbEJqSW9BOGVDVWsz?=
 =?utf-8?B?NjFFcHI0WWZNRkN1bVpXRjFEcDRkZGxMVlUwYzgzeC8zbHcyU1lGM3MyeHhD?=
 =?utf-8?B?U040TC84cFVnUkNsT1RiR0hPTzZjQjJQVUQwejFPbW1la1BJVHkxenZyaC83?=
 =?utf-8?B?WmVBd0o1NU0zWHk4bGQwbGVwajRMS0taYjlDTWs3S3prNXh0ZVJqbG1Famhy?=
 =?utf-8?B?eHIrNHZBbFp4MzhmOWh3Yk9BcDVvajBtalRMd29adDNHNldWNlBqdGhSYWl5?=
 =?utf-8?B?TFVvLzc3S3NSb1Z0SDNaMFNFYTRVSWRPWmloL1NBMytjc1E5bS9XT3lVK2Vw?=
 =?utf-8?B?UE5ialE3Y01qSVNFWTVaSi9hK1gvYUpGNGRva25VVjRWaTE3MGh3bUpYUTIx?=
 =?utf-8?B?dVFXdWZsV2psTHhSM0NiVCtwWTVKZzBmRmdGdlJGUDJtZHBJSVFwMFhHRkR1?=
 =?utf-8?B?ZGh5bGs0cGo0TWloVWxKam9pYlZ4Vy9HWXZwOHhIbE0zbVNNMXNjZjgwVzhy?=
 =?utf-8?B?UjZ2S25DY3VtNU1tMDNzYmI2Vm5IRWdjZ1NXUmR0QzQ4TDdoVVBKMzdKZXBy?=
 =?utf-8?B?QnJYVzBDUVF5RktIWnI1T2NlYnlrcVUxR1V3U2FjSCtsS2lqQnpCSzZNdGk1?=
 =?utf-8?B?dGxqMzhJNldGZE5XMlRaeU5ZT2U2aytBdThqczFFQ3JrcytrVmVIeXNHbW16?=
 =?utf-8?B?Q2lNL1BDWFZMejdXM0pRdTVKUE5JenBaeWF4N200amkwV0VsSytIb2JreE1u?=
 =?utf-8?B?bElMU2VDa05PUWVEcVN6WE9vdnhHcFlqRmtLZk9DWm40SnJ1N21mYXZsdmJN?=
 =?utf-8?B?KzIzSlZPM203Q3U0d2pKVVBDSGVTVUd2R24yUGFvdWNxSy9jeVFPNERsQVlk?=
 =?utf-8?B?ZEpISTFnTEhFUmRvbHpIU3VYenVMLzgvanhQTjB6eEFoeVpsM2oxcEI2bmVZ?=
 =?utf-8?B?a04xY1lHVjRIa1BrOU1QZi9HbHBPalNUN3RDUUJTVXNCNVowTSs4U3FXTUda?=
 =?utf-8?B?ckdURUd2cnEyZHhTeUQ1QThMblIvT3VQaTRHYkY3ekgzU3M1dzRBbUFIb21Q?=
 =?utf-8?B?cHNtZDNaL1VCRmpSNVZnTDdzNlVIN3NpYms2b3VZRWFCKzRlNjF2Tnp1QmFp?=
 =?utf-8?Q?9ofDmpYdThUz/jTJydyChCJ0r?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: C+Z2ugz+SiB/1j5YiP/HhLKIwfy9prs6TEsaPhJZoSTuEE0LqYDmgvGbb+dTvWd/PRWJKclSUiW9DeHBxwOd78F4ZfAV2N3Tz7sZ1R3F4LoIs/r6BI4cq/b5x1RtGupGmj57FL2I9CJajyZEluwgEp6rr6Av452lpyXWBAqppaU1SeNHx2kPuieSUhsbBNLX2yiQ2MR8jNj4bnAY49eGNLbpHdm2GbVF3B32nVwG2GMPiXQOX0v4shpoiOkDx8I6TC8NPsCjs7sFCoQIUcLWOrXga7uG/X8cok2DEuz3NZPgoNUjKdR/eHpZTsRZ7O6J8VN7amaKg3jJlIEN87YI1dCr5Bj69B9Ue1D2Xd8aXsbO2hP8UERKhi63SN8zmxjx+ngo+So28xLoSOv1ohxQglXf/T16ipLaANDhRcXV7bJUYsfyM08at3AqyCdJuLWe3kyxqdsrPt9o9E4Ogaohaac3zcZrcSlGZGvZEll0/U7s9eMntaE/tBaJ1mJyfyElRDgytrbxdMVErcli9TKBaE7mJQzMA3crhh8d0Duqaf6Y2xMVShOc30AhXqq88SWNdPSgjz69D3qybOkeFMLIordG9dQFi/zRne9l5OARIVZOTWwhWb1OpkmlWWm+Fa8Qm2i84JcVL62JTyeJRWOrYEqMERCJAW79JShaluMDv4CL6uq9Ez0Evsp6LPY6rEqDBtJD6PaMZBwRi8x57ggSs4q4Ohr8FYwA093DoIqPwaFd+jpXUG++sckIynMtvu3B4UOFjO75QtUdEvb+831etppmZIHIw+6TqOCNP6B+Gl0skIT4OHuzJjcBNbjr8gq/iGF/81TCSgSesbCEphrnfgKPx8JJaO1VFXKZFp6lE/4=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ca71154f-2b1b-4e3a-63cb-08dbe9ed1010
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Nov 2023 17:20:58.8746 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: IF54pR8mkiYn7YgYqRI5AoNwG37bb95NJBR5wC1Epqq+ke8kIaMUUih5nMHLDBOOOPhOX9YaxESLjkntC+qRjg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5327
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-11-20_17,2023-11-20_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0
 spamscore=0 phishscore=0
 mlxlogscore=966 adultscore=0 bulkscore=0 malwarescore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000
 definitions=main-2311200124
X-Proofpoint-GUID: lpcpSOwi3DS2hqDC89Fc2hkhYH0oyWAC
X-Proofpoint-ORIG-GUID: lpcpSOwi3DS2hqDC89Fc2hkhYH0oyWAC
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 67161
Cc: "67161 <at> debbugs.gnu.org" <67161 <at> debbugs.gnu.org>,
 "stefankangas@HIDDEN" <stefankangas@HIDDEN>,
 "monnier@HIDDEN" <monnier@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

PiAxLiBlbWFjcyAtUQ0KPiAyLiB0eXBlIE0tOiAoaW5zZXJ0ICJ2aXNpYmxlICIgKHByb3BlcnRp
emUgImhpZGRlbiIgJ2ludmlzaWJsZSB0KSkNCj4gMy4gQy1zIGhpZGRlbg0KDQpKdXN0IHNldCBv
ciBiaW5kIGBpc2VhcmNoLWZpbHRlci1wcmVkaWNhdGUnIHRvDQpgaXNlYXJjaC1yYW5nZS1pbnZp
c2libGUnLCB0byBzZWFyY2ggb25seSBpbnZpc2libGUgdGV4dC4NCg0KYEMtaCBmIGlzZWFyY2gt
cmFuZ2UtaW52aXNpYmxlJzoNCg0KICBpc2VhcmNoLXJhbmdlLWludmlzaWJsZSBpcyBhIGNvbXBp
bGVkIExpc3AgZnVuY3Rpb24gaW4g4oCYaXNlYXJjaC5lbOKAmS4NCg0KICAoaXNlYXJjaC1yYW5n
ZS1pbnZpc2libGUgQkVHIEVORCkNCg0KICBSZXR1cm4gdCBpZiBhbGwgdGhlIHRleHQgZnJvbSBC
RUcgdG8gRU5EIGlzIGludmlzaWJsZS4NCg==




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67161; Package emacs. Full text available.

Message received at 67161 <at> debbugs.gnu.org:


Received: (at 67161) by debbugs.gnu.org; 20 Nov 2023 12:10:51 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Nov 20 07:10:51 2023
Received: from localhost ([127.0.0.1]:52662 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r5375-00050N-1a
	for submit <at> debbugs.gnu.org; Mon, 20 Nov 2023 07:10:51 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:33824)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1r5372-000507-WB
 for 67161 <at> debbugs.gnu.org; Mon, 20 Nov 2023 07:10:49 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1r536t-0006B5-Q6; Mon, 20 Nov 2023 07:10:39 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=OE69Yw8OQyXJ6r0thVvxO4IoLu8EOL+NEJoOEZZBHHs=; b=dt0LcK14uh+I
 PwrQIvsmD1dreTSpRqHdb+SjRiyAyeXOCiiOkWAS9lnB3OEqu4B+RPuSoKCLOw5Yh+e7bI0NQogv1
 idlfrlJD3wUmezN082wxeIMK2AAh4Stkl+d/XWmpooh0dNl49CNorxlj9FG3KjBGWfKbmurx7rUXY
 /rkoKYnzRQQKDBtO/s4d89UvwKxHLfNRpShM/lvum96gZKWpMLcZrUVz7mvHaJr4yKtIQuFBAVN0A
 H3MzDvm4biuRHUy50N8MkF5Eott6UxVl81HQXnqjm6zh4EN7rCeSyR5J1yVjRp6hnFprU5sLbGfWn
 l4DucgglnLalrndve9yAtw==;
Date: Mon, 20 Nov 2023 14:10:23 +0200
Message-Id: <835y1wk4ls.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Liu Hui <liuhui1610@HIDDEN>, Juri Linkov <juri@HIDDEN>
In-Reply-To: <CAOQTW-NN=nmvs5j6_AwMyrA8v9Zuo_vbn9KNKXPPsfn+J25gGA@HIDDEN>
 (message from Liu Hui on Mon, 20 Nov 2023 12:34:13 +0800)
Subject: Re: bug#67161: 30.0.50;
 [PATCH] Add option `dired-filename-display-length'
References: <CAOQTW-MSpBK4ACpLk8U2m6HJx8HXw21O0kyYZ-i85ETNjyOUcA@HIDDEN>
 <8334x8tqi9.fsf@HIDDEN>
 <CAOQTW-P4+vs+JH8BTL8fL-d1QJXOdYq3i+3O7tALTDs=qHpnzA@HIDDEN>
 <83a5rfrych.fsf@HIDDEN>
 <CAOQTW-M5VaV0Va+ixd2-6SoKb4tPebxviobOB8Qs3Oxb9js9GA@HIDDEN>
 <83sf55q4nc.fsf@HIDDEN>
 <CAOQTW-MhVkj5LBYeguWKE6FsVgovdD0wuEW5bHZdy=01maXW1w@HIDDEN>
 <83jzqfmiuj.fsf@HIDDEN>
 <CAOQTW-NN=nmvs5j6_AwMyrA8v9Zuo_vbn9KNKXPPsfn+J25gGA@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 67161
Cc: 67161 <at> debbugs.gnu.org, stefankangas@HIDDEN, monnier@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Liu Hui <liuhui1610@HIDDEN>
> Date: Mon, 20 Nov 2023 12:34:13 +0800
> Cc: stefankangas@HIDDEN, monnier@HIDDEN, 67161 <at> debbugs.gnu.org
> 
> > > BTW, I just find isearch doesn't handle hidden filenames based on
> > > 'invisible' text property, which needs to be fixed. So maybe an
> > > overlay-based approach is better? though I don't know if there is any
> > > possible problem with using overlays for this feature. WDYT?
> >
> > Doesn't "M-s i" during isearch handle this?
> 
> No. I want to search text in hidden part rather than only in the
> visible part, which is necessary for users to find relevant files even
> if they are partly hidden.
> 
> Here is an example illustrating the problem:
> 1. emacs -Q
> 2. type M-: (insert "visible " (propertize "hidden" 'invisible t))
> 3. C-s hidden
> 
> isearch fails to match the invisible text by default, unless
> search-invisible is changed to t. However, the default value of
> search-invisible is open and it cannot be changed to t during isearch
> by M-s i.
> 
> Therefore, I would like to change
> 
>   (put-text-property ell-beg (point) 'invisible 'dired-filename-hide)
> 
> to
> 
>   (let ((ov (make-overlay ell-beg (point))))
>     (overlay-put ov 'invisible 'dired-filename-hide)
>     (overlay-put ov 'isearch-open-invisible t)
>     (overlay-put ov 'evaporate t))
> 
> in the attached patch, then text in hidden part can be matched
> regardless of search-invisible being open or t. It also has a bonus
> that hidden text can be revealed during isearch.

Juri, this seems to be a usability bug?  Why does Isearch only look
into invisible overlay properties, but not text properties?  IOW, why
doesn't "M-s i" set the value of isearch-invisible to t, not 'open'?
Or maybe 'open' should also search inside text properties, not just
overlays?  In any case, the differences between properties and
overlays is unusual and IMO a misfeature.  Can this be fixed?




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67161; Package emacs. Full text available.

Message received at 67161 <at> debbugs.gnu.org:


Received: (at 67161) by debbugs.gnu.org; 20 Nov 2023 04:34:37 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 19 23:34:37 2023
Received: from localhost ([127.0.0.1]:52340 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r4vzY-0001qZ-J9
	for submit <at> debbugs.gnu.org; Sun, 19 Nov 2023 23:34:37 -0500
Received: from mail-vs1-xe33.google.com ([2607:f8b0:4864:20::e33]:47612)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <liuhui1610@HIDDEN>) id 1r4vzU-0001qI-G0
 for 67161 <at> debbugs.gnu.org; Sun, 19 Nov 2023 23:34:35 -0500
Received: by mail-vs1-xe33.google.com with SMTP id
 ada2fe7eead31-45d88053c24so1134799137.3
 for <67161 <at> debbugs.gnu.org>; Sun, 19 Nov 2023 20:34:30 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1700454865; x=1701059665; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:from:to:cc:subject:date:message-id:reply-to;
 bh=SqoA8UtdpCYGCubPhrRgb55/BhgjJa/KNlqMpdJv13A=;
 b=eUrThaRwjTqkflY+pZD+c+WfO6mkC83gcjtX2kBACXu5u/00d6K+DAEID4Ta0Krmmn
 JFYZh4tMyXnjmqdVeTpUzJ1MkoQq9JB5qiN1MXVi3bojdVDkfbUeVvkz4frGFsL1X4xl
 CzfKSut3d5ihOKL7MAcBgoyHscUsCwG/QsdV7h4QoFpcprQAFlAtJEgFGwNkbpi307Kq
 M1zzjrMI/VaGxPntEp3LcESl8R91dXLiyhlxKlzzrLdQJwSxo267AMcp5fwFwDK9DDo6
 n2Yy/jrmwqrbGvG7IGygnryRa3hNQuoJLRfKfvI51rEJBkCHwLmd8IGzrX3shNroX2ke
 FpcA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1700454865; x=1701059665;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=SqoA8UtdpCYGCubPhrRgb55/BhgjJa/KNlqMpdJv13A=;
 b=IyW6dsfU3wG8pIXaeMXC18CFCKdGgvBJ92b8iHcSKtDrOwEG0NEjxn3yVUIuIEcLx9
 GxZjeIkGqe0Dwo3vbZVW1CXEIAJEt3ZwMv3XFt4njKA0TW9M6ewQRUKFTdM8C/cmqXD+
 TRrKafPmesC09LyQdY0ail+rnTXeVWcZWpWGSd82cpe5jsB49W0PsjTedWttlW+HOgmx
 cyepkKNm0lZnky3BxXirq93J7WNDyx9kX816mkzFO39XQtXO3IcdVfOxlSNmFSHs/H1T
 M92pw1Hp+4rT45scPDZ9hLVG3Jvc7hekPAVs8HKVN8NdJYneJScgZS+/MqPohk0RLML1
 L2pg==
X-Gm-Message-State: AOJu0YwiznddMj1soiPoVr7lpiVW4h/OU0lDWYjwSxkqBNwiFWeO+F/P
 wqL0+7ikn97XXheurLGPcdqfVLcGpq61u1nDKV4=
X-Google-Smtp-Source: AGHT+IEXvfk6ISH5U/YcHsYj3jS67t92FE4QUEoGhnq0WN29WFJxrgBod6QGytE6/NMXTsSMChR2WxIE5vcoizqR/T8=
X-Received: by 2002:a05:6102:20ca:b0:462:a86a:53d8 with SMTP id
 i10-20020a05610220ca00b00462a86a53d8mr595738vsr.19.1700454864877; Sun, 19 Nov
 2023 20:34:24 -0800 (PST)
MIME-Version: 1.0
References: <CAOQTW-MSpBK4ACpLk8U2m6HJx8HXw21O0kyYZ-i85ETNjyOUcA@HIDDEN>
 <8334x8tqi9.fsf@HIDDEN>
 <CAOQTW-P4+vs+JH8BTL8fL-d1QJXOdYq3i+3O7tALTDs=qHpnzA@HIDDEN>
 <83a5rfrych.fsf@HIDDEN>
 <CAOQTW-M5VaV0Va+ixd2-6SoKb4tPebxviobOB8Qs3Oxb9js9GA@HIDDEN>
 <83sf55q4nc.fsf@HIDDEN>
 <CAOQTW-MhVkj5LBYeguWKE6FsVgovdD0wuEW5bHZdy=01maXW1w@HIDDEN>
 <83jzqfmiuj.fsf@HIDDEN>
In-Reply-To: <83jzqfmiuj.fsf@HIDDEN>
From: Liu Hui <liuhui1610@HIDDEN>
Date: Mon, 20 Nov 2023 12:34:13 +0800
Message-ID: <CAOQTW-NN=nmvs5j6_AwMyrA8v9Zuo_vbn9KNKXPPsfn+J25gGA@HIDDEN>
Subject: Re: bug#67161: 30.0.50;
 [PATCH] Add option `dired-filename-display-length'
To: Eli Zaretskii <eliz@HIDDEN>
Content-Type: multipart/mixed; boundary="0000000000002dbca8060a8e005d"
X-Spam-Score: 0.2 (/)
X-Debbugs-Envelope-To: 67161
Cc: 67161 <at> debbugs.gnu.org, stefankangas@HIDDEN, monnier@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.8 (/)

--0000000000002dbca8060a8e005d
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Eli Zaretskii <eliz@HIDDEN> =E4=BA=8E2023=E5=B9=B411=E6=9C=8818=E6=97=A5=
=E5=91=A8=E5=85=AD 18:55=E5=86=99=E9=81=93=EF=BC=9A

> If there are two different modes of using this function, the doc
> string could describe them both.  Currently, it only describes the use
> case where dired-filename-display-length is an integer, in which case
> it is a simple accessor.  The other use case is more subtle, and the
> doc string is completely silent about that, in particular it doesn't
> mention that point should be at the first character of the file name
> in that case.

Thanks for the explanation. I have updated the doc string as suggested.

> > BTW, I just find isearch doesn't handle hidden filenames based on
> > 'invisible' text property, which needs to be fixed. So maybe an
> > overlay-based approach is better? though I don't know if there is any
> > possible problem with using overlays for this feature. WDYT?
>
> Doesn't "M-x i" during isearch handle this?

No. I want to search text in hidden part rather than only in the
visible part, which is necessary for users to find relevant files even
if they are partly hidden.

Here is an example illustrating the problem:
1. emacs -Q
2. type M-: (insert "visible " (propertize "hidden" 'invisible t))
3. C-s hidden

isearch fails to match the invisible text by default, unless
search-invisible is changed to t. However, the default value of
search-invisible is open and it cannot be changed to t during isearch
by M-s i.

Therefore, I would like to change

  (put-text-property ell-beg (point) 'invisible 'dired-filename-hide)

to

  (let ((ov (make-overlay ell-beg (point))))
    (overlay-put ov 'invisible 'dired-filename-hide)
    (overlay-put ov 'isearch-open-invisible t)
    (overlay-put ov 'evaporate t))

in the attached patch, then text in hidden part can be matched
regardless of search-invisible being open or t. It also has a bonus
that hidden text can be revealed during isearch.

> > --- a/lisp/wdired.el
> > +++ b/lisp/wdired.el
> > @@ -261,6 +261,9 @@ wdired-change-to-wdired-mode
> >    (add-function :override (local 'revert-buffer-function) #'wdired-rev=
ert)
> >    (set-buffer-modified-p nil)
> >    (setq buffer-undo-list nil)
> > +  ;; remove filename invisibility spec to ensure filenames are visible
> > +  ;; for editing
>
> Comments should be complete sentences: begin with a capital letter and
> end with a period.  Also, please mention here the new defcustom you
> add to Dired, so that the comment could better explain itself.
>
> Thanks.

Fixed.

--0000000000002dbca8060a8e005d
Content-Type: text/x-patch; charset="US-ASCII"; 
	name="0001-Add-option-dired-filename-display-length.patch"
Content-Disposition: attachment; 
	filename="0001-Add-option-dired-filename-display-length.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_lp6etbnz0>
X-Attachment-Id: f_lp6etbnz0

RnJvbSAxN2EwMmU4YWY0NTAyYzg0MDU0ZmQ3YmFjOWQ2OWYwMDRkMDlkNmE0IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBMaXUgSHVpIDxsaXVodWkxNjEwQGdtYWlsLmNvbT4KRGF0ZTog
TW9uLCAyMCBOb3YgMjAyMyAxMjowOToxNSArMDgwMApTdWJqZWN0OiBbUEFUQ0hdIEFkZCBvcHRp
b24gYGRpcmVkLWZpbGVuYW1lLWRpc3BsYXktbGVuZ3RoJwoKKiBsaXNwL2RpcmVkLmVsIChkaXJl
ZC1maWxlbmFtZS1kaXNwbGF5LWxlbmd0aCk6IE5ldyBvcHRpb24uCihkaXJlZC1pbnNlcnQtc2V0
LXByb3BlcnRpZXMpOiBTZXQgaW52aXNpYmlsaXR5IHNwZWMgZm9yIGxvbmcKZmlsZW5hbWVzLgoo
ZGlyZWQtLWdldC1lbGxpcHNpcy1sZW5ndGgpCihkaXJlZC0tZ2V0LWZpbGVuYW1lLWRpc3BsYXkt
bGVuZ3RoKQooZGlyZWQtZmlsZW5hbWUtdXBkYXRlLWludmlzaWJpbGl0eS1zcGVjKTogTmV3IGZ1
bmN0aW9ucy4KKGRpcmVkLW1vZGUpOiBBZGQgZmlsZW5hbWUgaW52aXNpYmlsaXR5IHNwZWMuCihk
aXJlZC1tYWtlLWRpcmVjdG9yeS1jbGlja2FibGUpOgooZGlyZWQta2lsbC13aGVuLW9wZW5pbmct
bmV3LWRpcmVkLWJ1ZmZlcik6CihkaXJlZC1oaWRlLWRldGFpbHMtcHJlc2VydmVkLWNvbHVtbnMp
OiBBZGQgbWlzc2luZyBncm91cC4KKiBsaXNwL3dkaXJlZC5lbCAod2RpcmVkLWNoYW5nZS10by13
ZGlyZWQtbW9kZSkKKHdkaXJlZC1jaGFuZ2UtdG8tZGlyZWQtbW9kZSk6IFVwZGF0ZSBmaWxlbmFt
ZSBpbnZpc2liaWxpdHkgc3BlYy4KKiBldGMvTkVXUzogQW5ub3VuY2UgdGhlIGNoYW5nZS4KLS0t
CiBldGMvTkVXUyAgICAgICB8ICAgNyArKysKIGxpc3AvZGlyZWQuZWwgIHwgMTQxICsrKysrKysr
KysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0KIGxpc3Avd2RpcmVkLmVs
IHwgICA3ICsrKwogMyBmaWxlcyBjaGFuZ2VkLCAxMTQgaW5zZXJ0aW9ucygrKSwgNDEgZGVsZXRp
b25zKC0pCgpkaWZmIC0tZ2l0IGEvZXRjL05FV1MgYi9ldGMvTkVXUwppbmRleCAyM2Y0YThiNTMx
MS4uYWQ5YmRhNTRiNWUgMTAwNjQ0Ci0tLSBhL2V0Yy9ORVdTCisrKyBiL2V0Yy9ORVdTCkBAIC00
NzIsNiArNDcyLDEzIEBAIGVtcHR5IGxpbmVzLiAgSXQgYWxzbyBjb250cm9scyBob3cgdG8gbW92
ZSBwb2ludCB3aGVuIGVuY291bnRlcmluZyBhCiBib3VuZGFyeSAoZS5nLiwgaWYgZXZlcnkgbGlu
ZSBpcyB2aXNpYmxlLCBpbnZva2luZyAnZGlyZWQtbmV4dC1saW5lJwogYXQgdGhlIGxhc3QgbGlu
ZSB3aWxsIG1vdmUgdG8gdGhlIGZpcnN0IGxpbmUpLiAgVGhlIGRlZmF1bHQgaXMgbmlsLgogCisq
KiogTmV3IHVzZXIgb3B0aW9uICdkaXJlZC1maWxlbmFtZS1kaXNwbGF5LWxlbmd0aCcuCitJdCBp
cyBhbiBpbnRlZ2VyIHJlcHJlc2VudGluZyB0aGUgbWF4aW11bSBkaXNwbGF5IGxlbmd0aCBvZiBm
aWxlbmFtZXMuCitUaGUgbWlkZGxlIHBhcnQgb2YgZmlsZW5hbWUgd2hvc2UgbGVuZ3RoIGV4Y2Vl
ZHMgdGhlIHJlc3RyaWN0aW9uIGlzCitoaWRkZW4gYW5kIGFuIGVsbGlwc2lzIGlzIGRpc3BsYXll
ZCBpbnN0ZWFkLiAgQSB2YWx1ZSBvZiAnd2luZG93JworbWVhbnMgdXNpbmcgdGhlIHJpZ2h0IGVk
Z2Ugb2Ygd2luZG93IGFzIHRoZSBkaXNwbGF5IHJlc3RyaWN0aW9uLiAgVGhlCitkZWZhdWx0IGlz
IG5pbC4KKwogKiogRWRpZmYKIAogLS0tCmRpZmYgLS1naXQgYS9saXNwL2RpcmVkLmVsIGIvbGlz
cC9kaXJlZC5lbAppbmRleCA4OTE5ZDJjMjIzZi4uZTE4OTNiMWU4ZjEgMTAwNjQ0Ci0tLSBhL2xp
c3AvZGlyZWQuZWwKKysrIGIvbGlzcC9kaXJlZC5lbApAQCAtMzUwLDYgKzM1MCw3IEBAIGRpcmVk
LWFmdGVyLXJlYWRpbi1ob29rCiAoZGVmY3VzdG9tIGRpcmVkLW1ha2UtZGlyZWN0b3J5LWNsaWNr
YWJsZSB0CiAgICJXaGVuIG5vbi1uaWwsIG1ha2UgdGhlIGRpcmVjdG9yeSBhdCB0aGUgc3RhcnQg
b2YgdGhlIGRpcmVkIGJ1ZmZlciBjbGlja2FibGUuIgogICA6dmVyc2lvbiAiMjkuMSIKKyAgOmdy
b3VwICdkaXJlZAogICA6dHlwZSAnYm9vbGVhbikKIAogKGRlZmN1c3RvbSBkaXJlZC1pbml0aWFs
LXBvc2l0aW9uLWhvb2sgbmlsCkBAIC00MjksNiArNDMwLDcgQEAgZGlyZWQtbWFyay1yZWdpb24K
IChkZWZjdXN0b20gZGlyZWQta2lsbC13aGVuLW9wZW5pbmctbmV3LWRpcmVkLWJ1ZmZlciBuaWwK
ICAgIklmIG5vbi1uaWwsIGtpbGwgdGhlIGN1cnJlbnQgYnVmZmVyIHdoZW4gc2VsZWN0aW5nIGEg
bmV3IGRpcmVjdG9yeS4iCiAgIDp0eXBlICdib29sZWFuCisgIDpncm91cCAnZGlyZWQKICAgOnZl
cnNpb24gIjI4LjEiKQogCiAoZGVmY3VzdG9tIGRpcmVkLWd1ZXNzLXNoZWxsLWNhc2UtZm9sZC1z
ZWFyY2ggdApAQCAtNTE1LDYgKzUxNywyMiBAQCBkaXJlZC1tb3ZlbWVudC1zdHlsZQogKGRlZmN1
c3RvbSBkaXJlZC1oaWRlLWRldGFpbHMtcHJlc2VydmVkLWNvbHVtbnMgbmlsCiAgICJMaXN0IG9m
IGNvbHVtbnMgd2hpY2ggYXJlIG5vdCBoaWRkZW4gaW4gYGRpcmVkLWhpZGUtZGV0YWlscy1tb2Rl
Jy4iCiAgIDp0eXBlICcocmVwZWF0IGludGVnZXIpCisgIDpncm91cCAnZGlyZWQKKyAgOnZlcnNp
b24gIjMwLjEiKQorCisoZGVmY3VzdG9tIGRpcmVkLWZpbGVuYW1lLWRpc3BsYXktbGVuZ3RoIG5p
bAorICAiSWYgbm9uLW5pbCwgcmVzdHJpY3QgdGhlIGRpc3BsYXkgbGVuZ3RoIG9mIGZpbGVuYW1l
cy4KK0lmIHRoZSB2YWx1ZSBpcyB0aGUgc3ltYm9sIGB3aW5kb3cnLCB0aGUgcmlnaHQgZWRnZSBv
ZiBjdXJyZW50Cit3aW5kb3cgaXMgdXNlZCBhcyB0aGUgcmVzdHJpY3Rpb24uICBPdGhlcndpc2Us
IGl0IHNob3VsZCBiZSBhbgoraW50ZWdlciByZXByZXNlbnRpbmcgdGhlIG1heGltdW0gZmlsZW5h
bWUgbGVuZ3RoLgorCitUaGUgbWlkZGxlIHBhcnQgb2YgZmlsZW5hbWUgd2hvc2UgbGVuZ3RoIGV4
Y2VlZHMgdGhlIHJlc3RyaWN0aW9uCitpcyBoaWRkZW4gYnkgdXNpbmcgdGhlIGBpbnZpc2libGUn
IHByb3BlcnR5IGFuZCBhbiBlbGxpcHNpcyBpcworZGlzcGxheWVkIGluc3RlYWQuIgorICA6dHlw
ZSAnKGNob2ljZSAoY29uc3QgICA6dGFnICJObyByZXN0cmljdGlvbiIgbmlsKQorICAgICAgICAg
ICAgICAgICAoY29uc3QgICA6dGFnICJXaW5kb3ciIHdpbmRvdykKKyAgICAgICAgICAgICAgICAg
KGludGVnZXIgOnRhZyAiSW50ZWdlciIpKQorICA6Z3JvdXAgJ2RpcmVkCiAgIDp2ZXJzaW9uICIz
MC4xIikKIAogDApAQCAtMTkwMyw0OCArMTkyMSw2MSBAQCBkaXJlZC1pbnNlcnQtc2V0LXByb3Bl
cnRpZXMKICAgIkFkZCB2YXJpb3VzIHRleHQgcHJvcGVydGllcyB0byB0aGUgbGluZXMgaW4gdGhl
IHJlZ2lvbiwgZnJvbSBCRUcgdG8gRU5ELiIKICAgKHNhdmUtZXhjdXJzaW9uCiAgICAgKGdvdG8t
Y2hhciBiZWcpCi0gICAgKHdoaWxlICg8IChwb2ludCkgZW5kKQotICAgICAgKGlnbm9yZS1lcnJv
cnMKLQkoaWYgKG5vdCAoZGlyZWQtbW92ZS10by1maWxlbmFtZSkpCi0JICAgICh1bmxlc3MgKG9y
IChsb29raW5nLWF0LXAgIl4kIikKLQkJCShsb29raW5nLWF0LXAgZGlyZWQtc3ViZGlyLXJlZ2V4
cCkpCi0JICAgICAgKHB1dC10ZXh0LXByb3BlcnR5IChsaW5lLWJlZ2lubmluZy1wb3NpdGlvbikK
LQkJCQkgKDErIChsaW5lLWVuZC1wb3NpdGlvbikpCi0JCQkJICdpbnZpc2libGUgJ2RpcmVkLWhp
ZGUtZGV0YWlscy1pbmZvcm1hdGlvbikpCi0JICAoc2F2ZS1leGN1cnNpb24KLSAgICAgICAgICAg
IChsZXQgKChlbmQgKDEtIChwb2ludCkpKQotICAgICAgICAgICAgICAgICAgKG9wb2ludCAoZ290
by1jaGFyICgxKyAocG9zLWJvbCkpKSkKLSAgICAgICAgICAgICAgICAgIChpIDApKQotICAgICAg
ICAgICAgICAocHV0LXRleHQtcHJvcGVydHkgb3BvaW50IGVuZCAnaW52aXNpYmxlICdkaXJlZC1o
aWRlLWRldGFpbHMtZGV0YWlsKQotICAgICAgICAgICAgICAod2hpbGUgKHJlLXNlYXJjaC1mb3J3
YXJkICJbXiBdKyIgZW5kIHQpCi0gICAgICAgICAgICAgICAgKHdoZW4gKG1lbWJlciAoY2wtaW5j
ZiBpKSBkaXJlZC1oaWRlLWRldGFpbHMtcHJlc2VydmVkLWNvbHVtbnMpCi0gICAgICAgICAgICAg
ICAgICAocHV0LXRleHQtcHJvcGVydHkgb3BvaW50IChwb2ludCkgJ2ludmlzaWJsZSBuaWwpKQot
ICAgICAgICAgICAgICAgIChzZXRxIG9wb2ludCAocG9pbnQpKSkpKQotICAgICAgICAgIChsZXQg
KChiZWcgKHBvaW50KSkgKGVuZCAoc2F2ZS1leGN1cnNpb24KLQkgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIChkaXJlZC1tb3ZlLXRvLWVuZC1vZi1maWxlbmFtZSkKLQkgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICgxLSAocG9pbnQpKSkpKQotICAgICAgICAgICAgKGlmIGRpcmVkLWNs
aWNrLXRvLXNlbGVjdC1tb2RlCi0gICAgICAgICAgICAgICAgKHB1dC10ZXh0LXByb3BlcnR5IGJl
ZyBlbmQgJ2tleW1hcAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkaXJlZC1j
bGljay10by1zZWxlY3QtbWFwKQotICAgICAgICAgICAgICAod2hlbiAoYW5kIGRpcmVkLW1vdXNl
LWRyYWctZmlsZXMgKGZib3VuZHAgJ3gtYmVnaW4tZHJhZykpCi0gICAgICAgICAgICAgICAgKHB1
dC10ZXh0LXByb3BlcnR5IGJlZyBlbmQgJ2tleW1hcAotICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICBkaXJlZC1tb3VzZS1kcmFnLWZpbGVzLW1hcCkpKQotCSAgICAoYWRkLXRleHQt
cHJvcGVydGllcwotCSAgICAgYmVnICgxKyBlbmQpCi0JICAgICBgKG1vdXNlLWZhY2UKLQkgICAg
ICAgaGlnaGxpZ2h0Ci0JICAgICAgIGRpcmVkLWZpbGVuYW1lIHQKLQkgICAgICAgaGVscC1lY2hv
ICwoaWYgZGlyZWQtY2xpY2stdG8tc2VsZWN0LW1vZGUKLSAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICJtb3VzZS0yOiBtYXJrIG9yIHVubWFyayB0aGlzIGZpbGUiCi0gICAgICAgICAgICAg
ICAgICAgICAgICAgICAgKGlmIChhbmQgZGlyZWQtbW91c2UtZHJhZy1maWxlcwotICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIChmYm91bmRwICd4LWJlZ2luLWRyYWcpKQotICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiZG93bi1tb3VzZS0xOiBkcmFnIHRoaXMgZmls
ZSB0byBhbm90aGVyIHByb2dyYW0KKyAgICAobGV0ICgoZWxsLWxlbiAoZGlyZWQtLWdldC1lbGxp
cHNpcy1sZW5ndGgpKSBtYXhsZW4gZmlsZW5hbWUtY29sKQorICAgICAgKHdoaWxlICg8IChwb2lu
dCkgZW5kKQorICAgICAgICAoaWdub3JlLWVycm9ycworCSAgKGlmIChub3QgKGRpcmVkLW1vdmUt
dG8tZmlsZW5hbWUpKQorCSAgICAgICh1bmxlc3MgKG9yIChsb29raW5nLWF0LXAgIl4kIikKKwkJ
CSAgKGxvb2tpbmctYXQtcCBkaXJlZC1zdWJkaXItcmVnZXhwKSkKKwkgICAgICAgIChwdXQtdGV4
dC1wcm9wZXJ0eSAobGluZS1iZWdpbm5pbmctcG9zaXRpb24pCisJCQkJICAgKDErIChsaW5lLWVu
ZC1wb3NpdGlvbikpCisJCQkJICAgJ2ludmlzaWJsZSAnZGlyZWQtaGlkZS1kZXRhaWxzLWluZm9y
bWF0aW9uKSkKKwkgICAgKHNhdmUtZXhjdXJzaW9uCisgICAgICAgICAgICAgIChsZXQgKChlbmQg
KDEtIChwb2ludCkpKQorICAgICAgICAgICAgICAgICAgICAob3BvaW50IChnb3RvLWNoYXIgKDEr
IChwb3MtYm9sKSkpKQorICAgICAgICAgICAgICAgICAgICAoaSAwKSkKKyAgICAgICAgICAgICAg
ICAocHV0LXRleHQtcHJvcGVydHkgb3BvaW50IGVuZCAnaW52aXNpYmxlICdkaXJlZC1oaWRlLWRl
dGFpbHMtZGV0YWlsKQorICAgICAgICAgICAgICAgICh3aGlsZSAocmUtc2VhcmNoLWZvcndhcmQg
IlteIF0rIiBlbmQgdCkKKyAgICAgICAgICAgICAgICAgICh3aGVuIChtZW1iZXIgKGNsLWluY2Yg
aSkgZGlyZWQtaGlkZS1kZXRhaWxzLXByZXNlcnZlZC1jb2x1bW5zKQorICAgICAgICAgICAgICAg
ICAgICAocHV0LXRleHQtcHJvcGVydHkgb3BvaW50IChwb2ludCkgJ2ludmlzaWJsZSBuaWwpKQor
ICAgICAgICAgICAgICAgICAgKHNldHEgb3BvaW50IChwb2ludCkpKSkpCisgICAgICAgICAgICAo
bGV0ICgoYmVnIChwb2ludCkpIChlbmQgKHNhdmUtZXhjdXJzaW9uCisJICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIChkaXJlZC1tb3ZlLXRvLWVuZC1vZi1maWxlbmFtZSkKKwkgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgKDEtIChwb2ludCkpKSkpCisgICAgICAgICAgICAgIChp
ZiBkaXJlZC1jbGljay10by1zZWxlY3QtbW9kZQorICAgICAgICAgICAgICAgICAgKHB1dC10ZXh0
LXByb3BlcnR5IGJlZyBlbmQgJ2tleW1hcAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIGRpcmVkLWNsaWNrLXRvLXNlbGVjdC1tYXApCisgICAgICAgICAgICAgICAgKHdoZW4g
KGFuZCBkaXJlZC1tb3VzZS1kcmFnLWZpbGVzIChmYm91bmRwICd4LWJlZ2luLWRyYWcpKQorICAg
ICAgICAgICAgICAgICAgKHB1dC10ZXh0LXByb3BlcnR5IGJlZyBlbmQgJ2tleW1hcAorICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRpcmVkLW1vdXNlLWRyYWctZmlsZXMtbWFw
KSkpCisgICAgICAgICAgICAgICh3aGVuIGRpcmVkLWZpbGVuYW1lLWRpc3BsYXktbGVuZ3RoCisg
ICAgICAgICAgICAgICAgKGxldCAoKGxlbiAoc3RyaW5nLXdpZHRoIChidWZmZXItc3Vic3RyaW5n
IGJlZyAoMSsgZW5kKSkpKQorICAgICAgICAgICAgICAgICAgICAgIGVsbC1iZWcpCisgICAgICAg
ICAgICAgICAgICAob3IgbWF4bGVuIChzZXRxIG1heGxlbiAoZGlyZWQtLWdldC1maWxlbmFtZS1k
aXNwbGF5LWxlbmd0aCkpKQorICAgICAgICAgICAgICAgICAgKHdoZW4gKGFuZCAoaW50ZWdlcnAg
bWF4bGVuKSAoPiBsZW4gbWF4bGVuICgrIGVsbC1sZW4gMikpKQorICAgICAgICAgICAgICAgICAg
ICAob3IgZmlsZW5hbWUtY29sIChzZXRxIGZpbGVuYW1lLWNvbCAoY3VycmVudC1jb2x1bW4pKSkK
KyAgICAgICAgICAgICAgICAgICAgKG1vdmUtdG8tY29sdW1uICgrIGZpbGVuYW1lLWNvbCAoLyBt
YXhsZW4gMikpKQorICAgICAgICAgICAgICAgICAgICAoc2V0cSBlbGwtYmVnIChwb2ludCkpCisg
ICAgICAgICAgICAgICAgICAgIChtb3ZlLXRvLWNvbHVtbiAoKyBmaWxlbmFtZS1jb2wgKC8gbWF4
bGVuIDIpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoLSBsZW4gbWF4
bGVuKSBlbGwtbGVuKSkKKyAgICAgICAgICAgICAgICAgICAgKHB1dC10ZXh0LXByb3BlcnR5Cisg
ICAgICAgICAgICAgICAgICAgICBlbGwtYmVnIChwb2ludCkgJ2ludmlzaWJsZSAnZGlyZWQtZmls
ZW5hbWUtaGlkZSkpKSkKKwkgICAgICAoYWRkLXRleHQtcHJvcGVydGllcworCSAgICAgICBiZWcg
KDErIGVuZCkKKwkgICAgICAgYChtb3VzZS1mYWNlCisJICAgICAgICAgaGlnaGxpZ2h0CisJICAg
ICAgICAgZGlyZWQtZmlsZW5hbWUgdAorCSAgICAgICAgIGhlbHAtZWNobyAsKGlmIGRpcmVkLWNs
aWNrLXRvLXNlbGVjdC1tb2RlCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJtb3Vz
ZS0yOiBtYXJrIG9yIHVubWFyayB0aGlzIGZpbGUiCisgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAoaWYgKGFuZCBkaXJlZC1tb3VzZS1kcmFnLWZpbGVzCisgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAoZmJvdW5kcCAneC1iZWdpbi1kcmFnKSkKKyAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAiZG93bi1tb3VzZS0xOiBkcmFnIHRoaXMgZmlsZSB0byBh
bm90aGVyIHByb2dyYW0KIG1vdXNlLTI6IHZpc2l0IHRoaXMgZmlsZSBpbiBvdGhlciB3aW5kb3ci
Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAibW91c2UtMjogdmlzaXQgdGhpcyBmaWxl
IGluIG90aGVyIHdpbmRvdyIpKSkpCi0JICAgICh3aGVuICg8ICgrIGVuZCA1KSAobGluZS1lbmQt
cG9zaXRpb24pKQotCSAgICAgIChwdXQtdGV4dC1wcm9wZXJ0eSAoKyBlbmQgNSkgKGxpbmUtZW5k
LXBvc2l0aW9uKQotCQkJICAgICAgICAgJ2ludmlzaWJsZSAnZGlyZWQtaGlkZS1kZXRhaWxzLWxp
bmspKSkpKQotICAgICAgKGZvcndhcmQtbGluZSAxKSkpKQorICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAibW91c2UtMjogdmlzaXQgdGhpcyBmaWxlIGluIG90aGVyIHdpbmRvdyIpKSkp
CisJICAgICAgKHdoZW4gKDwgKCsgZW5kIDUpIChsaW5lLWVuZC1wb3NpdGlvbikpCisJICAgICAg
ICAocHV0LXRleHQtcHJvcGVydHkgKCsgZW5kIDUpIChsaW5lLWVuZC1wb3NpdGlvbikKKwkJCSAg
ICAgICAgICAgJ2ludmlzaWJsZSAnZGlyZWQtaGlkZS1kZXRhaWxzLWxpbmspKSkpKQorICAgICAg
ICAoZm9yd2FyZC1saW5lIDEpKSkpKQogCiAoZGVmdW4gZGlyZWQtLW1ha2UtZGlyZWN0b3J5LWNs
aWNrYWJsZSAoKQogICAoc2F2ZS1leGN1cnNpb24KQEAgLTE5NzYsNiArMjAwNywyNCBAQCBkaXJl
ZC0tbWFrZS1kaXJlY3RvcnktY2xpY2thYmxlCiAgICAgICAgICAgICAgICAgICAgICAgICAgICJS
RVQiIGNsaWNrKSkpKQogICAgICAgICAgIChzZXRxIHNlZ21lbnQtc3RhcnQgKHBvaW50KSkpKSkp
KQogCisoZGVmdW4gZGlyZWQtLWdldC1lbGxpcHNpcy1sZW5ndGggKCkKKyAgIlJldHVybiBsZW5n
dGggb2YgZWxsaXBzaXMuIgorICAobGV0KiAoKGR0IChvciAod2luZG93LWRpc3BsYXktdGFibGUp
CisgICAgICAgICAgICAgICAgIGJ1ZmZlci1kaXNwbGF5LXRhYmxlCisgICAgICAgICAgICAgICAg
IHN0YW5kYXJkLWRpc3BsYXktdGFibGUpKQorICAgICAgICAgKGdseXBocyAoYW5kIGR0IChkaXNw
bGF5LXRhYmxlLXNsb3QgZHQgJ3NlbGVjdGl2ZS1kaXNwbGF5KSkpKQorICAgIChzdHJpbmctd2lk
dGggKGlmIGdseXBocyAoY29uY2F0IGdseXBocykgIi4uLiIpKSkpCisKKyhkZWZ1biBkaXJlZC0t
Z2V0LWZpbGVuYW1lLWRpc3BsYXktbGVuZ3RoICgpCisgICJSZXR1cm4gbWF4aW11bSBkaXNwbGF5
IGxlbmd0aCBvZiBmaWxlbmFtZS4KK1doZW4gYGRpcmVkLWZpbGVuYW1lLWRpc3BsYXktbGVuZ3Ro
JyBpcyBub3QgYW4gaW50ZWdlciwgdGhlCitmdW5jdGlvbiBhY3R1YWxseSByZXR1cm5zIHRoZSBu
dW1iZXIgb2YgY29sdW1ucyBhdmFpbGFibGUgZm9yCitkaXNwbGF5aW5nIHRoZSBmaWxlIG5hbWVz
LCBhbmQgc2hvdWxkIGJlIGNhbGxlZCB3aXRoIHBvaW50IGF0IHRoZQorZmlyc3QgY2hhcmFjdGVy
IG9mIHRoZSBmaWxlIG5hbWUuIgorICAoaWYgKGludGVnZXJwIGRpcmVkLWZpbGVuYW1lLWRpc3Bs
YXktbGVuZ3RoKQorICAgICAgZGlyZWQtZmlsZW5hbWUtZGlzcGxheS1sZW5ndGgKKyAgICAoLSAo
d2luZG93LW1heC1jaGFycy1wZXItbGluZSkgMSAoY3VycmVudC1jb2x1bW4pKSkpCisKIAwKIDs7
OyBSZXZlcnRpbmcgYSBkaXJlZCBidWZmZXIKIApAQCAtMjYxNyw2ICsyNjY2LDcgQEAgZGlyZWQt
bW9kZQogCW1vZGUtbGluZS1idWZmZXItaWRlbnRpZmljYXRpb24KIAkocHJvcGVydGl6ZWQtYnVm
ZmVyLWlkZW50aWZpY2F0aW9uICIlMTdiIikpCiAgIChhZGQtdG8taW52aXNpYmlsaXR5LXNwZWMg
JyhkaXJlZCAuIHQpKQorICAoZGlyZWQtZmlsZW5hbWUtdXBkYXRlLWludmlzaWJpbGl0eS1zcGVj
KQogICA7OyBJZ25vcmUgZGlyZWQtaGlkZS1kZXRhaWxzLSogdmFsdWUgb2YgaW52aXNpYmxlIHRl
eHQgcHJvcGVydHkgYnkgZGVmYXVsdC4KICAgKHdoZW4gKGVxIGJ1ZmZlci1pbnZpc2liaWxpdHkt
c3BlYyB0KQogICAgIChzZXRxIGJ1ZmZlci1pbnZpc2liaWxpdHktc3BlYyAobGlzdCB0KSkpCkBA
IC0zMTA2LDYgKzMxNTYsMTUgQEAgZGlyZWQtaGlkZS1kZXRhaWxzLXVwZGF0ZS1pbnZpc2liaWxp
dHktc3BlYwogDAogOzs7IEZ1bmN0aW9ucyB0byBoaWRlL3VuaGlkZSB0ZXh0CiAKKyhkZWZ1biBk
aXJlZC1maWxlbmFtZS11cGRhdGUtaW52aXNpYmlsaXR5LXNwZWMgKCkKKyAgIlVwZGF0ZSBgYnVm
ZmVyLWludmlzaWJpbGl0eS1zcGVjJyBmb3IgZmlsZW5hbWVzLgorU3BlY2lmaWNhbGx5LCB0aGUg
ZmlsZW5hbWUgaW52aXNpYmlsaXR5IHNwZWMgaXMgYWRkZWQgaW4gRGlyZWQKK2J1ZmZlcnMgYW5k
IHJlbW92ZWQgaW4gV0RpcmVkIGJ1ZmZlcnMuIgorICAoZnVuY2FsbCAoaWYgKGRlcml2ZWQtbW9k
ZS1wICdkaXJlZC1tb2RlKQorICAgICAgICAgICAgICAgJ2FkZC10by1pbnZpc2liaWxpdHktc3Bl
YworICAgICAgICAgICAgICdyZW1vdmUtZnJvbS1pbnZpc2liaWxpdHktc3BlYykKKyAgICAgICAg
ICAgJyhkaXJlZC1maWxlbmFtZS1oaWRlIC4gdCkpKQorCiAoZGVmdW4gZGlyZWQtLWZpbmQtaGlk
ZGVuLXBvcyAoc3RhcnQgZW5kKQogICAodGV4dC1wcm9wZXJ0eS1hbnkgc3RhcnQgZW5kICdpbnZp
c2libGUgJ2RpcmVkKSkKIApkaWZmIC0tZ2l0IGEvbGlzcC93ZGlyZWQuZWwgYi9saXNwL3dkaXJl
ZC5lbAppbmRleCAwNzlkOTNkNjAxMS4uYjViMDFmMGQwODkgMTAwNjQ0Ci0tLSBhL2xpc3Avd2Rp
cmVkLmVsCisrKyBiL2xpc3Avd2RpcmVkLmVsCkBAIC0yNjEsNiArMjYxLDEwIEBAIHdkaXJlZC1j
aGFuZ2UtdG8td2RpcmVkLW1vZGUKICAgKGFkZC1mdW5jdGlvbiA6b3ZlcnJpZGUgKGxvY2FsICdy
ZXZlcnQtYnVmZmVyLWZ1bmN0aW9uKSAjJ3dkaXJlZC1yZXZlcnQpCiAgIChzZXQtYnVmZmVyLW1v
ZGlmaWVkLXAgbmlsKQogICAoc2V0cSBidWZmZXItdW5kby1saXN0IG5pbCkKKyAgOzsgTm9uLW5p
bCBgZGlyZWQtZmlsZW5hbWUtZGlzcGxheS1sZW5ndGgnIG1heSBjYXVzZSBmaWxlbmFtZXMgdG8g
YmUKKyAgOzsgaGlkZGVuIHBhcnRseSwgc28gd2UgcmVtb3ZlIGZpbGVuYW1lIGludmlzaWJpbGl0
eSBzcGVjCisgIDs7IHRlbXBvcmFyaWx5IHRvIGVuc3VyZSBmaWxlbmFtZXMgYXJlIHZpc2libGUg
Zm9yIGVkaXRpbmcuCisgIChkaXJlZC1maWxlbmFtZS11cGRhdGUtaW52aXNpYmlsaXR5LXNwZWMp
CiAgIChydW4tbW9kZS1ob29rcyAnd2RpcmVkLW1vZGUtaG9vaykKICAgKG1lc3NhZ2UgIiVzIiAo
c3Vic3RpdHV0ZS1jb21tYW5kLWtleXMKIAkJICJQcmVzcyBcXFt3ZGlyZWQtZmluaXNoLWVkaXRd
IHdoZW4gZmluaXNoZWQgXApAQCAtNDU2LDYgKzQ2MCw5IEBAIHdkaXJlZC1jaGFuZ2UtdG8tZGly
ZWQtbW9kZQogICAoZGlyZWQtc29ydC1zZXQtbW9kZS1saW5lKQogICAoZGlyZWQtYWR2ZXJ0aXNl
KQogICAoZGlyZWQtaGlkZS1kZXRhaWxzLXVwZGF0ZS1pbnZpc2liaWxpdHktc3BlYykKKyAgOzsg
UmVzdG9yZSBmaWxlbmFtZSBpbnZpc2liaWxpdHkgc3BlYyB0aGF0IGlzIHJlbW92ZWQgaW4KKyAg
OzsgYHdkaXJlZC1jaGFuZ2UtdG8td2RpcmVkLW1vZGUnLgorICAoZGlyZWQtZmlsZW5hbWUtdXBk
YXRlLWludmlzaWJpbGl0eS1zcGVjKQogICAocmVtb3ZlLWhvb2sgJ2tpbGwtYnVmZmVyLWhvb2sg
Iyd3ZGlyZWQtY2hlY2sta2lsbC1idWZmZXIgdCkKICAgKHJlbW92ZS1ob29rICdiZWZvcmUtY2hh
bmdlLWZ1bmN0aW9ucyAjJ3dkaXJlZC0tYmVmb3JlLWNoYW5nZS1mbiB0KQogICAocmVtb3ZlLWhv
b2sgJ2FmdGVyLWNoYW5nZS1mdW5jdGlvbnMgIyd3ZGlyZWQtLXJlc3RvcmUtcHJvcGVydGllcyB0
KQotLSAKMi4yNS4xCgo=
--0000000000002dbca8060a8e005d--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67161; Package emacs. Full text available.

Message received at 67161 <at> debbugs.gnu.org:


Received: (at 67161) by debbugs.gnu.org; 18 Nov 2023 16:12:44 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 18 11:12:44 2023
Received: from localhost ([127.0.0.1]:49367 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r4Nw4-0004Z7-Ks
	for submit <at> debbugs.gnu.org; Sat, 18 Nov 2023 11:12:44 -0500
Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:64492)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <drew.adams@HIDDEN>) id 1r4Nvz-0004Yx-Hp
 for 67161 <at> debbugs.gnu.org; Sat, 18 Nov 2023 11:12:43 -0500
Received: from pps.filterd (m0333520.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id
 3AIEcu5I030211; Sat, 18 Nov 2023 16:12:37 GMT
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com;
 h=from : to : cc :
 subject : date : message-id : references : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2023-03-30;
 bh=VBtPnmC2ylJoEuOFPu3VtOIIWE7Yu9v4O0kvoeq2e8Y=;
 b=GaDTRsWSBsMfvv3ccaZKs1D7ImtgrvBUqVU2Hdt6oH+c1PF3BUv21VLJ/W6zsncz2hZh
 tys+3Huz5kAjPtJogvU6tqTi5nMn6Nrs0csbVu5Q7/zOi1bLOzXgcBSuYjXh5fEEzEka
 Hk8WEXcYD2hD8hQAcFodd9WweqcLjk7yn0HGO9r6NcuNzz3lItN72zPjK0sxgiPC2fz1
 wVJ9UexQItCwdopNW/mNucpCHTVWc6XBoYUC/MZEjetXz6o0Qb+vZB8ndXnUWzqKw1eM
 o5/1OdQJAk7SyVKI3czVNXLL15a/VAuuoQJLiQXqymhdZOIEF6dBwnov9GX20zm1Mipy Ug== 
Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com
 (iadpaimrmta03.appoci.oracle.com [130.35.103.27])
 by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3uenadgfp9-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Sat, 18 Nov 2023 16:12:37 +0000
Received: from pps.filterd
 (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1])
 by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19)
 with ESMTP id 3AIClGSW023524; Sat, 18 Nov 2023 16:12:36 GMT
Received: from nam10-mw2-obe.outbound.protection.outlook.com
 (mail-mw2nam10lp2100.outbound.protection.outlook.com [104.47.55.100])
 by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id
 3uekq3k4hk-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Sat, 18 Nov 2023 16:12:36 +0000
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZbFdFJx3C9T6LbSE2ssVQIoK7DJgYnHdzCJ/X35NAS9bJaXVFwNhqdWRNBdGpEOrdGbth3mr9bEgZ9sRuCyAPyaSdEoDOiJgfu1l2SfiaaTG4y6l2yQBxZQt3kbWOBDY5+G23ncBGakydQAWoH6RaFjGX+R3YBJBwsBcAI1gpHnEIDNw0WHR8KcT/15UStEhDulsERwoZZ6K7G+H9kOqm9WsW39dbzNZU0ddscbeQbH0RHPQBGsNPxcIBFjRxLp5YJXY/KluDUzk6YJ+pj3V/tasE9QX5BKSNowWiLqNYUygL3s+beupi7b8sGiF6g3rof00R89R95MxmVvHatTU1w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=VBtPnmC2ylJoEuOFPu3VtOIIWE7Yu9v4O0kvoeq2e8Y=;
 b=eUAoGALhHZjQfcpmkWUWhjPdWm2IBpUxl1aQQJIzfqYpYbS0s0jrM8ZTaZwyCQdhiI8vGn4tW/IXhSH1OE59sIaYQeCJXiUEdXnqmDXs41YD3zd6BvKgysyj/t5eGxH+UB+mXt0CymbSlvfzMTrDUVOKm+yjOhQKOi2W51fILVcGQRJnkSnEFC77DAjDD3EtqNuybjQl1kh8YnMUz6F+xk/ctRZQiIjZX0pSYzczN6t1yxlrZg8Kof1ObrM57b8fPnZuMT5JjeC3LyUfHIYNUA6kn0otL6dxGFQlGNFDVGbLldekez4xeqtXljwlg5Pr61wzjgXTmADYEmoDtyvOsQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=VBtPnmC2ylJoEuOFPu3VtOIIWE7Yu9v4O0kvoeq2e8Y=;
 b=d6wXP+T4Gcxzds0dcOKH4p/IBc/BtM7fGhynFlS33SjeXaBjyFPPmtKrHPMjzNw6oFae8YfwB1HB2IlQ2swxGqTmPR8g/eWDsRMh5M9XxoWayu6N/VOX8GG1nGyKXpgpoUNugktb22v/+LvebB1zOG8PvXzd2ip7aFvQGHUAMRA=
Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19)
 by MW4PR10MB6437.namprd10.prod.outlook.com (2603:10b6:303:218::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.26; Sat, 18 Nov
 2023 16:12:34 +0000
Received: from SJ0PR10MB5488.namprd10.prod.outlook.com
 ([fe80::3b4c:a669:c229:47b4]) by SJ0PR10MB5488.namprd10.prod.outlook.com
 ([fe80::3b4c:a669:c229:47b4%6]) with mapi id 15.20.6977.029; Sat, 18 Nov 2023
 16:12:34 +0000
From: Drew Adams <drew.adams@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>, Liu Hui <liuhui1610@HIDDEN>
Subject: RE: [External] : bug#67161: 30.0.50; [PATCH] Add option
 `dired-filename-display-length'
Thread-Topic: [External] : bug#67161: 30.0.50; [PATCH] Add option
 `dired-filename-display-length'
Thread-Index: AQHaGg3hFab2bIaftEaIUoxdt9m4KrCAP9hw
Date: Sat, 18 Nov 2023 16:12:34 +0000
Message-ID: <SJ0PR10MB54888E0D0CE16C4BD0346667F3B6A@HIDDEN>
References: <CAOQTW-MSpBK4ACpLk8U2m6HJx8HXw21O0kyYZ-i85ETNjyOUcA@HIDDEN>
 <8334x8tqi9.fsf@HIDDEN>
 <CAOQTW-P4+vs+JH8BTL8fL-d1QJXOdYq3i+3O7tALTDs=qHpnzA@HIDDEN>
 <83a5rfrych.fsf@HIDDEN>
 <CAOQTW-M5VaV0Va+ixd2-6SoKb4tPebxviobOB8Qs3Oxb9js9GA@HIDDEN>
 <83sf55q4nc.fsf@HIDDEN>
 <CAOQTW-MhVkj5LBYeguWKE6FsVgovdD0wuEW5bHZdy=01maXW1w@HIDDEN>
 <83jzqfmiuj.fsf@HIDDEN>
In-Reply-To: <83jzqfmiuj.fsf@HIDDEN>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: SJ0PR10MB5488:EE_|MW4PR10MB6437:EE_
x-ms-office365-filtering-correlation-id: 42fa243c-1ada-44b5-c195-08dbe8512cca
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: bFIUniWtZ/MfMg1d7cEwcBM3oEo6eA/jVD/U0D0PWFpxHXSZ1RvHAsf39RxYbUuwWcBwCQnZ7pQva1m00XaDpnvqgmEHE6jy5Dqv1mgczaB+fmgc7F9AkGpD68fE9N6Ko/XHuvI8+tIeB3ObESzJIKFiKVbe8kgXUeLJBfSNfMSGD6ih4SvYJyLsEwar406EJpojUPsICWi7laZTJG2hWLgDoRWU4QAYNHoVfCLbhMWdkrc3PnF95Aa9cBiy9vfqaFG79iynsYqkQTU50KhsrMVjh2cVjrWM/PvGRZyCsCC0i9mxxHFJuBx8FVhIvc1zpx60YklGInlCNdPQuSeab1iBoVRsVWTNpzaNgEwikJt4L/G0o6/kZGFhIfEkjDhQEOsONMPSgPH9avS7EiWKTS/mQMaGdbAfL4xYt+0TMwAO6mKbYQmSaucRSemKzGyepriwT4dSAbVe7+V3ciHRCCySAHJAVXVYvetyW2qzCGJAsMO/WGz8hQ5GU1ceMWoS7STJmZFK9PYcPDvBt0ruDRzX4BhjERMKtQ0Fl2ZSTZPP/UDdyx39W+foVslwqj54uLlY5nyPJNe1vSciK0i6ZFB2VQCh5lPxSCYYdiTyvMbks4ECX/VZkUKH2r5eEuUKzWnxxaFhlYqOiIlzKyDpPA==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(13230031)(346002)(366004)(376002)(39860400002)(396003)(136003)(230922051799003)(451199024)(64100799003)(186009)(1800799012)(33656002)(558084003)(86362001)(38100700002)(38070700009)(122000001)(76116006)(66946007)(110136005)(66556008)(66476007)(66446008)(64756008)(54906003)(316002)(8676002)(8936002)(4326008)(52536014)(41300700001)(55016003)(5660300002)(2906002)(44832011)(9686003)(6506007)(7696005)(71200400001)(26005)(478600001)(81973001);
 DIR:OUT; SFP:1101; 
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?JX0AykkOyq/VB6hbyeZ4Um7ngBXDMll74ti/a3pU3pNTmJa31qClJ6Fqha+o?=
 =?us-ascii?Q?PNvIWURNaM/E4ArxPM297Uy2tcCNqs7t3EA994hqFxkbQ4Bm+X3TyPAgaKDt?=
 =?us-ascii?Q?LBCIWqIx9mRt5WVMv56JagEUPamXJH0xPQihZafVDQj1XfTAjkMQjQ6sP6or?=
 =?us-ascii?Q?+j30jlm3yEJXAwzzwCFktazSTW5VfFQ31NU0K12VHeVwOoPI6LeLzI2S4ITd?=
 =?us-ascii?Q?RlZIeKI8iJ55hxZed9u5e7Jvr6AiFCN+8B+1QTVhIs52agMM1bQF0Zuyaz9Q?=
 =?us-ascii?Q?TVowd+IUTYfCy7JKuF0HVLT/fyNhbKOPuiZ6bwcBEXKtY2/CdruPMvfvwQQP?=
 =?us-ascii?Q?cgDsRTbuPAVzwWIg/DSdo0Z2oUtqVzhyrGsG5HfZ9FjMTOFpTFHrejsXcxBk?=
 =?us-ascii?Q?F21W9TUtWvjv626/wGlj5qKqhmzwagWZV+Kbf7AAuv/NUMwXgoL76hlZanym?=
 =?us-ascii?Q?GQDyy22IFVxR5KlbTFwFH/wg+ZpF76WJ7z3xm9pi0blr1cHMXEJVy/nYbB0W?=
 =?us-ascii?Q?c9EbfKZuczRpimdhQPm07c3Fkx42JZ0fngI3WC4rITM8w3L7EW8EP0JZCwzk?=
 =?us-ascii?Q?5TtKM/NLuroaqb8ATtuSRlUbD8RGeKH5noni/coBqqVUYPgIOuCRt2C3z4Xa?=
 =?us-ascii?Q?zNITD3+BjpMxOQ3mmUctpr+Y7eRHYWbO5apJfL1XnOE/CuSuDX/VklPX7/T6?=
 =?us-ascii?Q?DjjVbyzSqnxuRo5SOQn1hfDYQOJmHymmsgD4gqoj9SPRTHu/e9sYAsyYiX5v?=
 =?us-ascii?Q?d5OuNH43Im/qXwaDQfjqLMdjH6HY98XIT+IUjtgEWMuIjnVxVsSu/T5Z23hl?=
 =?us-ascii?Q?pUYAW8Jtmy1yFVX1zAXOtxXpDfbjZKq9QjaUIbFKDm9OfhIRciNX3PEqsVgB?=
 =?us-ascii?Q?aPtXrXf3t/gSI3imSj3BWLWG8oOSrC1E8+3O465I+huNhyKLmFynFb9xG/DE?=
 =?us-ascii?Q?qM5EBrizuhVQglVTRaCoNj+jY4QDeRVRFYTWqb6zgu6uA2cSYVPWV73z14s4?=
 =?us-ascii?Q?nXJ24ZR1YWIESKoZSZjEcgZwWAwD6bE3QyqFciPCv30ILZD0rov6bqOBak2L?=
 =?us-ascii?Q?wH9RCuQyIpolO92sld4qogrpRQYx7oYT9VsA69rHTlXDttw7XLBEKpLWDMB5?=
 =?us-ascii?Q?VFp1Ziidd5jwD2JuPgKa7XdjgzoDw/oBwHjdoXPtkcbko6oDyyiF2trKyzH3?=
 =?us-ascii?Q?AYeo5sVoIjiCDqxzi0wgCbtJ6G6FF1uY3dJcSMPSQVcuYj8lHMqp9wvjjF/R?=
 =?us-ascii?Q?rXWesC5HMmGLmUD7H9t11oV6XC42AljjmCua5J2BC3j8Nlz8XgJlS8Red6as?=
 =?us-ascii?Q?13DP2/VtLvvJosO78Bpsm7XRf9y/GcMk6uwWdpNrT17UNDYH19qDMr0hVPwV?=
 =?us-ascii?Q?Z5huSqHjAuCpdJwjM1ChHMxfIUaQU5cbdX3EgoxvrOBe2LTgqDfT5uLtYRS/?=
 =?us-ascii?Q?l6FXarYK8+VfgemkxQVwRLfFWbofPdxp9GtPG651gKZ33EFP4gaPnWEW96fB?=
 =?us-ascii?Q?3gwGJV1LMucf/2UO7VjhhtaI9t36hOzkPImzTTBDuCO5f/t3vnan2m8aPhM6?=
 =?us-ascii?Q?9qwCsfyrF36UWm395GGXevD+6r5fYRjlxfpaElCl?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 97GcLEqIEK2ZxJ7attTyUdiHq0kGqjnts3Uxmoq9GJNoppshuKELzlyw6MLQo0SrzKaWSY+GzOhBoJrWKqgjACGhZ6n25T1dJPwBsbfRdLocRKWrS0x9WAgAnfvNP2y5Y8pIi7UupgzRwP1JxQDlqgXr070EovUYiEq23f2P2T8U/lnomso8oHh7aXDX45aO0GoPPdHK3jgWLSj34eCmkFwJTR6DWqaKfNBBUzgPBsdwtiOHrYnVWDX/6uMwfEPp9sZIxDcqQZ8Iy1adEUCAytr7BzdrXixNAbrYLoOD2uywt2pqxwLGTKb9kYT8DclnzOqTTMxf74SxIlRlyjRu37D5VW75OwnPWEB1qW1fUyaH8XfI31+qJu+FtPz8s+1bpIr8MkzCR+Oj5B0oxL8k0ySSCjILtsCAR4/HXHVvYGO6ubGomt1j+z7tAde6q5KSpKwkIqFpw0ASrPnOz2aiD+ysDaRkVUss0n51A3YVHCB5DFv/hOt5ZixmEivyhn3496EmGiHkNqyTnE+xo27rbGTIw94gpvsKzBmzBBuHPHveDBEiZevFSCF3rgPq1fPCVUBbQsqaZXl9qhSygBp9YqShKgNaePTQ2+srZVWWX0UK8YwQvLcF91wFD0OmxinkdPknc0/EjMmwBeROau0+8uL8RR0qARsu+4qNM7jntqGFZmq6+4+U2qNkQALVuIf0Ho0yow+NV6ZYlZeGonZVSOtoSFOITW+UcNNQ70CJXOcG96agI1f0Sr2HbbMer7wOvNGvpI8Ix8IEv//cauKhn4bl5aRzvLr4OQojlYI1dOkXC9qbBoy+4VY51g0uCTTJ2tVNRrHdREcXA0V2lPGHQXEEtA4DviHqZAr8mr1USjs=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 42fa243c-1ada-44b5-c195-08dbe8512cca
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Nov 2023 16:12:34.4442 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 8oDn41FG1gr71YVQCpyyHCX+aucmUumffuKL/kP7zWqdlMYs905TNQaaWzbZT4y0owvuYzM3U9/2dCTnyTRXRw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB6437
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-11-18_13,2023-11-17_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0
 bulkscore=0 mlxscore=0
 mlxlogscore=854 phishscore=0 malwarescore=0 suspectscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000
 definitions=main-2311180122
X-Proofpoint-GUID: tWuGUhdIxleJiU5_0jwnHzLlTjKLMnhN
X-Proofpoint-ORIG-GUID: tWuGUhdIxleJiU5_0jwnHzLlTjKLMnhN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 67161
Cc: "67161 <at> debbugs.gnu.org" <67161 <at> debbugs.gnu.org>,
 "stefankangas@HIDDEN" <stefankangas@HIDDEN>,
 "monnier@HIDDEN" <monnier@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

> Doesn't "M-x i" during isearch handle this?

Typo, I think.  `M-s i'.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67161; Package emacs. Full text available.

Message received at 67161 <at> debbugs.gnu.org:


Received: (at 67161) by debbugs.gnu.org; 18 Nov 2023 10:55:40 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 18 05:55:39 2023
Received: from localhost ([127.0.0.1]:47894 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r4IzD-0001Wz-Gh
	for submit <at> debbugs.gnu.org; Sat, 18 Nov 2023 05:55:39 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:35850)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1r4IzA-0001Wl-Vu
 for 67161 <at> debbugs.gnu.org; Sat, 18 Nov 2023 05:55:38 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1r4Iz4-0006xE-NW; Sat, 18 Nov 2023 05:55:30 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=oeSynKYhNk7xU410eMzbGymUujxpd5fi7pB2E2v/ti0=; b=EMTG3xAX2fX0
 W4KD+EEdahMJiZjC/J0jiCkjsZYGgEl2BgIo3ZP3KvZGZJ7xW01BJ6wdhYNB+63em3SQ1hmyMU0CI
 HdHNwuOnDYeH2QDyAkUi6dNbxMgu/YpKGsTIU3w0Yt1iUrUtARj8FaesNCOwXs+z/ksJUpFqcHZ1S
 lfwH3XDnWA4o9qJQXHwXxM9PE5+M2w82KJGHHOgYUJl4138qSkypu3O/+mmnPflrdUJr3nxTueEFY
 ds4N+qpcn55mr6A/OUKRqA8LU9ULL200jNGlpvtWa29SsHxYjfQoY/yrCCYfc5tKZq5qUDJqEOAc2
 I2b3W3+k/Oi7J/+puKqH9A==;
Date: Sat, 18 Nov 2023 12:55:16 +0200
Message-Id: <83jzqfmiuj.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Liu Hui <liuhui1610@HIDDEN>
In-Reply-To: <CAOQTW-MhVkj5LBYeguWKE6FsVgovdD0wuEW5bHZdy=01maXW1w@HIDDEN>
 (message from Liu Hui on Sat, 18 Nov 2023 17:23:26 +0800)
Subject: Re: bug#67161: 30.0.50;
 [PATCH] Add option `dired-filename-display-length'
References: <CAOQTW-MSpBK4ACpLk8U2m6HJx8HXw21O0kyYZ-i85ETNjyOUcA@HIDDEN>
 <8334x8tqi9.fsf@HIDDEN>
 <CAOQTW-P4+vs+JH8BTL8fL-d1QJXOdYq3i+3O7tALTDs=qHpnzA@HIDDEN>
 <83a5rfrych.fsf@HIDDEN>
 <CAOQTW-M5VaV0Va+ixd2-6SoKb4tPebxviobOB8Qs3Oxb9js9GA@HIDDEN>
 <83sf55q4nc.fsf@HIDDEN>
 <CAOQTW-MhVkj5LBYeguWKE6FsVgovdD0wuEW5bHZdy=01maXW1w@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 67161
Cc: 67161 <at> debbugs.gnu.org, stefankangas@HIDDEN, monnier@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Liu Hui <liuhui1610@HIDDEN>
> Date: Sat, 18 Nov 2023 17:23:26 +0800
> Cc: stefankangas@HIDDEN, monnier@HIDDEN, 67161 <at> debbugs.gnu.org
> 
> > > +(defun dired--get-filename-display-length ()
> > > +  "Return maximum display length of filename."
> >
> > This doc string is inaccurate.  The function actually returns the
> > number of columns available for displaying the file names in a Dired
> > buffer, and it should be called with point at the first character of
> > the file name.
> 
> Why is it inaccurate? When `dired-filename-display-length' is window,
> the function does return the number of columns available, and it is
> used as the maximum display length. Moreover, it could be an integer,
> which also means the maximum display length.

If there are two different modes of using this function, the doc
string could describe them both.  Currently, it only describes the use
case where dired-filename-display-length is an integer, in which case
it is a simple accessor.  The other use case is more subtle, and the
doc string is completely silent about that, in particular it doesn't
mention that point should be at the first character of the file name
in that case.

> BTW, I just find isearch doesn't handle hidden filenames based on
> 'invisible' text property, which needs to be fixed. So maybe an
> overlay-based approach is better? though I don't know if there is any
> possible problem with using overlays for this feature. WDYT?

Doesn't "M-x i" during isearch handle this?

> --- a/lisp/wdired.el
> +++ b/lisp/wdired.el
> @@ -261,6 +261,9 @@ wdired-change-to-wdired-mode
>    (add-function :override (local 'revert-buffer-function) #'wdired-revert)
>    (set-buffer-modified-p nil)
>    (setq buffer-undo-list nil)
> +  ;; remove filename invisibility spec to ensure filenames are visible
> +  ;; for editing

Comments should be complete sentences: begin with a capital letter and
end with a period.  Also, please mention here the new defcustom you
add to Dired, so that the comment could better explain itself.

Thanks.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67161; Package emacs. Full text available.

Message received at 67161 <at> debbugs.gnu.org:


Received: (at 67161) by debbugs.gnu.org; 18 Nov 2023 09:23:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 18 04:23:48 2023
Received: from localhost ([127.0.0.1]:47801 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r4HYJ-0007aZ-Cf
	for submit <at> debbugs.gnu.org; Sat, 18 Nov 2023 04:23:48 -0500
Received: from mail-ua1-x933.google.com ([2607:f8b0:4864:20::933]:50429)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <liuhui1610@HIDDEN>) id 1r4HYG-0007aJ-7Q
 for 67161 <at> debbugs.gnu.org; Sat, 18 Nov 2023 04:23:45 -0500
Received: by mail-ua1-x933.google.com with SMTP id
 a1e0cc1a2514c-7c1c0a75ee4so448853241.0
 for <67161 <at> debbugs.gnu.org>; Sat, 18 Nov 2023 01:23:43 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1700299417; x=1700904217; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:from:to:cc:subject:date:message-id:reply-to;
 bh=QRPvSmeOPAm/HwzpGfp4LEnks2UxWRTdvGiBJ/GuROA=;
 b=npYHblATTZ9WIpm1PZGZL7yrFVa4oqW7L1Of4Qioo1K5NTKJpIQmHDeJBRd0MHnz0i
 pNj6V964A9tEG/fvI9TjMIsnl1Xl2PpQCY29WpTbSVA/H/IHSlsw7+d71K3uGUkkpju3
 Pn2PV9bAdGq9kcx/hoJzOGDhON2UH34XAtm4eg/vypepg7pWA5ZHr5bX3WgKkUG9dp7k
 K6maDOfixRn1HAd3T9nDKkDcyv6Pj/1ZGs1NHM0e/Q/C83qq/fRowhQRPMq8eCV5qEZz
 FLg/aiP6ogtBonJpqJqaehh/LVWXD4JSDcumoF5vhSX+2X0po5aqf3MO9gchGLlaEeqn
 YFXA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1700299417; x=1700904217;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=QRPvSmeOPAm/HwzpGfp4LEnks2UxWRTdvGiBJ/GuROA=;
 b=VVauXABJVB+GPI7jm+g9FvIvkuzWgX5nw/8ddFC1TPiZyMAVd7ePoQGd69LI4qGN/p
 6zZZQkRTLOzUNnf0Tzt6JRxxyJA6q1bfx6Vdcy9bpAbGpby/4zTfkdNG94vAhS+7sA2q
 H4jZS75aTFb+7Abv2GZan54NEhMgCth95IuXa93U18jjy5xQfjjOUYYsWeqhuSJn4Yde
 HkWuBPjACBBHl92z6SqCDdObNMWLb2a7D8RZU+PasvuZoXmY015xbaaLHsuR7qWU3E+1
 7QFcXdTFPLWVEVhHn1Rzvu3rn+LH3hXW2JD3g/0ehBguq2x3jVJb5wpnbxls7NI2IFYh
 LM9A==
X-Gm-Message-State: AOJu0YyD285gYM3UoMpArsdjRObVpShrZw4zQ1CthrlB+VwQPQzEUTWn
 IRihnhUVoRDQs42iym6d85RK0L7q5RSflveGHEc=
X-Google-Smtp-Source: AGHT+IHPq4AoTeyrd6d7Fak/ghXyvUO6ueBgjvmPeVPtq0JnLNsmr3r6NhfTmKEECFwsT+oPomoi3AKE7RijlgF6b2k=
X-Received: by 2002:a05:6102:3f52:b0:462:797b:2b62 with SMTP id
 l18-20020a0561023f5200b00462797b2b62mr2297109vsv.32.1700299417549; Sat, 18
 Nov 2023 01:23:37 -0800 (PST)
MIME-Version: 1.0
References: <CAOQTW-MSpBK4ACpLk8U2m6HJx8HXw21O0kyYZ-i85ETNjyOUcA@HIDDEN>
 <8334x8tqi9.fsf@HIDDEN>
 <CAOQTW-P4+vs+JH8BTL8fL-d1QJXOdYq3i+3O7tALTDs=qHpnzA@HIDDEN>
 <83a5rfrych.fsf@HIDDEN>
 <CAOQTW-M5VaV0Va+ixd2-6SoKb4tPebxviobOB8Qs3Oxb9js9GA@HIDDEN>
 <83sf55q4nc.fsf@HIDDEN>
In-Reply-To: <83sf55q4nc.fsf@HIDDEN>
From: Liu Hui <liuhui1610@HIDDEN>
Date: Sat, 18 Nov 2023 17:23:26 +0800
Message-ID: <CAOQTW-MhVkj5LBYeguWKE6FsVgovdD0wuEW5bHZdy=01maXW1w@HIDDEN>
Subject: Re: bug#67161: 30.0.50;
 [PATCH] Add option `dired-filename-display-length'
To: Eli Zaretskii <eliz@HIDDEN>
Content-Type: multipart/mixed; boundary="000000000000cc4070060a69ce7b"
X-Spam-Score: 0.2 (/)
X-Debbugs-Envelope-To: 67161
Cc: 67161 <at> debbugs.gnu.org, stefankangas@HIDDEN, monnier@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.8 (/)

--000000000000cc4070060a69ce7b
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Eli Zaretskii <eliz@HIDDEN> =E4=BA=8E2023=E5=B9=B411=E6=9C=8816=E6=97=A5=
=E5=91=A8=E5=9B=9B 20:11=E5=86=99=E9=81=93=EF=BC=9A
>
> > From: Liu Hui <liuhui1610@HIDDEN>
> > Date: Thu, 16 Nov 2023 18:07:04 +0800
> > Cc: Stefan Kangas <stefankangas@HIDDEN>, Stefan Monnier <monnier@iro=
.umontreal.ca>,
> >       67161 <at> debbugs.gnu.org
> >
> > From 991ea588df6799331a7feea9e83493ef0d724096 Mon Sep 17 00:00:00 2001
> > From: Liu Hui <liuhui1610@HIDDEN>
> > Date: Tue, 14 Nov 2023 16:14:12 +0800
> > Subject: [PATCH] Add option `dired-filename-display-length'
> >
> > * lisp/dired.el (dired-filename-display-length): New option.
> > (dired-insert-set-properties): Set invisibility spec for long
> > filenames.
> > (dired--get-ellipsis-length)
> > (dired--get-filename-display-length)
> > (dired-filename-update-invisibility-spec): New functions.
> > (dired-mode): Add filename invisibility spec.
> > (dired-make-directory-clickable):
> > (dired-kill-when-opening-new-dired-buffer):
> > (dired-hide-details-preserved-columns): Add missing group.
> > * lisp/wdired.el (wdired-change-to-wdired-mode)
> > (wdired-change-to-dired-mode): Update filename invisibility spec.
>
> These changes need a NEWS entry to describe the new option and its
> effect in short.

Added.

> > diff --git a/lisp/dired.el b/lisp/dired.el
> > index 8919d2c223f..aad77a3dfc0 100644
> > --- a/lisp/dired.el
> > +++ b/lisp/dired.el
> > @@ -350,6 +350,7 @@ dired-after-readin-hook
> >  (defcustom dired-make-directory-clickable t
> >    "When non-nil, make the directory at the start of the dired buffer c=
lickable."
> >    :version "29.1"
> > +  :group 'dired
> >    :type 'boolean)
> >
> >  (defcustom dired-initial-position-hook nil
> > @@ -429,6 +430,7 @@ dired-mark-region
> >  (defcustom dired-kill-when-opening-new-dired-buffer nil
> >    "If non-nil, kill the current buffer when selecting a new directory.=
"
> >    :type 'boolean
> > +  :group 'dired
> >    :version "28.1")
> >
> >  (defcustom dired-guess-shell-case-fold-search t
> > @@ -515,6 +517,18 @@ dired-movement-style
> >  (defcustom dired-hide-details-preserved-columns nil
> >    "List of columns which are not hidden in `dired-hide-details-mode'."
> >    :type '(repeat integer)
> > +  :group 'dired
> > +  :version "30.1")
>
> Why do we need an explicit :group tag here?  Options whose group is
> not 'dired' indeed need it, but those whose group is 'dired' get it
> implicitly, AFAIU.

I find these options are implicitly assigned to the dired-guess group
rather than dired group, since dired-guess is the last group.

> > +(defcustom dired-filename-display-length nil
> > +  "If non-nil, hide middle part of long filenames in Dired buffers.
> > +If the value is the symbol `window', then filenames are shortened
> > +to not exceed the right edge of current window.  Otherwise, it
> > +should be an integer representing the maximum filename length."
>
> This should tell more about the effect: that portions of longer file
> names are hidden by using the 'invisible' property and that the
> ellipsis is displayed in their stead.

Done.

> > +(defun dired--get-ellipsis-length ()
> > +  "Return length of ellipsis."
> > +  (let* ((dt (or (window-display-table)
> > +                 buffer-display-table
> > +                 standard-display-table))
> > +         (glyphs (and dt (display-table-slot dt 'selective-display))))
> > +    (if glyphs (length glyphs) (eval-when-compile (length "...")))))
>
> Why do you use 'length' here and not 'string-width' or similar?  You
> seem to assume that each character takes just one column on display?

Fixed.

> > +(defun dired--get-filename-display-length ()
> > +  "Return maximum display length of filename."
>
> This doc string is inaccurate.  The function actually returns the
> number of columns available for displaying the file names in a Dired
> buffer, and it should be called with point at the first character of
> the file name.

Why is it inaccurate? When `dired-filename-display-length' is window,
the function does return the number of columns available, and it is
used as the maximum display length. Moreover, it could be an integer,
which also means the maximum display length.

> > +(defun dired-filename-update-invisibility-spec ()
>
> This function should have a doc string.

Added.

> > diff --git a/lisp/wdired.el b/lisp/wdired.el
> > index 079d93d6011..5d50a574290 100644
> > --- a/lisp/wdired.el
> > +++ b/lisp/wdired.el
> > @@ -261,6 +261,7 @@ wdired-change-to-wdired-mode
> >    (add-function :override (local 'revert-buffer-function) #'wdired-rev=
ert)
> >    (set-buffer-modified-p nil)
> >    (setq buffer-undo-list nil)
> > +  (dired-filename-update-invisibility-spec)
> >    (run-mode-hooks 'wdired-mode-hook)
> >    (message "%s" (substitute-command-keys
> >                "Press \\[wdired-finish-edit] when finished \
> > @@ -456,6 +457,7 @@ wdired-change-to-dired-mode
> >    (dired-sort-set-mode-line)
> >    (dired-advertise)
> >    (dired-hide-details-update-invisibility-spec)
> > +  (dired-filename-update-invisibility-spec)
>
> Please add comments in these two places explaining why you call
> dired-filename-update-invisibility-spec here, so that the reader won't
> need to look at that function to understand the reason.

Added.

> Thanks.

BTW, I just find isearch doesn't handle hidden filenames based on
'invisible' text property, which needs to be fixed. So maybe an
overlay-based approach is better? though I don't know if there is any
possible problem with using overlays for this feature. WDYT?

--000000000000cc4070060a69ce7b
Content-Type: text/x-patch; charset="US-ASCII"; 
	name="0001-Add-option-dired-filename-display-length.patch"
Content-Disposition: attachment; 
	filename="0001-Add-option-dired-filename-display-length.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_lp3ucyvh0>
X-Attachment-Id: f_lp3ucyvh0

RnJvbSA5ZjQyZDc1NTY2ZTk4MGMzMjY3ODNlNGY1NWMxNjFhNjdjZGY1YWU2IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBMaXUgSHVpIDxsaXVodWkxNjEwQGdtYWlsLmNvbT4KRGF0ZTog
VHVlLCAxNCBOb3YgMjAyMyAxNjoxNDoxMiArMDgwMApTdWJqZWN0OiBbUEFUQ0hdIEFkZCBvcHRp
b24gYGRpcmVkLWZpbGVuYW1lLWRpc3BsYXktbGVuZ3RoJwoKKiBsaXNwL2RpcmVkLmVsIChkaXJl
ZC1maWxlbmFtZS1kaXNwbGF5LWxlbmd0aCk6IE5ldyBvcHRpb24uCihkaXJlZC1pbnNlcnQtc2V0
LXByb3BlcnRpZXMpOiBTZXQgaW52aXNpYmlsaXR5IHNwZWMgZm9yIGxvbmcKZmlsZW5hbWVzLgoo
ZGlyZWQtLWdldC1lbGxpcHNpcy1sZW5ndGgpCihkaXJlZC0tZ2V0LWZpbGVuYW1lLWRpc3BsYXkt
bGVuZ3RoKQooZGlyZWQtZmlsZW5hbWUtdXBkYXRlLWludmlzaWJpbGl0eS1zcGVjKTogTmV3IGZ1
bmN0aW9ucy4KKGRpcmVkLW1vZGUpOiBBZGQgZmlsZW5hbWUgaW52aXNpYmlsaXR5IHNwZWMuCihk
aXJlZC1tYWtlLWRpcmVjdG9yeS1jbGlja2FibGUpOgooZGlyZWQta2lsbC13aGVuLW9wZW5pbmct
bmV3LWRpcmVkLWJ1ZmZlcik6CihkaXJlZC1oaWRlLWRldGFpbHMtcHJlc2VydmVkLWNvbHVtbnMp
OiBBZGQgbWlzc2luZyBncm91cC4KKiBsaXNwL3dkaXJlZC5lbCAod2RpcmVkLWNoYW5nZS10by13
ZGlyZWQtbW9kZSkKKHdkaXJlZC1jaGFuZ2UtdG8tZGlyZWQtbW9kZSk6IFVwZGF0ZSBmaWxlbmFt
ZSBpbnZpc2liaWxpdHkgc3BlYy4KKiBldGMvTkVXUzogQW5ub3VuY2UgdGhlIGNoYW5nZS4KLS0t
CiBldGMvTkVXUyAgICAgICB8ICAgNyArKysKIGxpc3AvZGlyZWQuZWwgIHwgMTM4ICsrKysrKysr
KysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0KIGxpc3Avd2RpcmVkLmVs
IHwgICA2ICsrKwogMyBmaWxlcyBjaGFuZ2VkLCAxMTAgaW5zZXJ0aW9ucygrKSwgNDEgZGVsZXRp
b25zKC0pCgpkaWZmIC0tZ2l0IGEvZXRjL05FV1MgYi9ldGMvTkVXUwppbmRleCAyM2Y0YThiNTMx
MS4uZTlhODRjYjkxODMgMTAwNjQ0Ci0tLSBhL2V0Yy9ORVdTCisrKyBiL2V0Yy9ORVdTCkBAIC00
NzIsNiArNDcyLDEzIEBAIGVtcHR5IGxpbmVzLiAgSXQgYWxzbyBjb250cm9scyBob3cgdG8gbW92
ZSBwb2ludCB3aGVuIGVuY291bnRlcmluZyBhCiBib3VuZGFyeSAoZS5nLiwgaWYgZXZlcnkgbGlu
ZSBpcyB2aXNpYmxlLCBpbnZva2luZyAnZGlyZWQtbmV4dC1saW5lJwogYXQgdGhlIGxhc3QgbGlu
ZSB3aWxsIG1vdmUgdG8gdGhlIGZpcnN0IGxpbmUpLiAgVGhlIGRlZmF1bHQgaXMgbmlsLgogCisq
KiogTmV3IHVzZXIgb3B0aW9uICdkaXJlZC1maWxlbmFtZS1kaXNwbGF5LWxlbmd0aCcuCitJdCBp
cyBhbiBpbnRlZ2VyIHJlcHJlc2VudGluZyB0aGUgbWF4aW11bSBkaXNwbGF5IGxlbmd0aCBvZiBm
aWxlbmFtZXMuCitUaGUgbWlkZGxlIHBhcnQgb2YgZmlsZW5hbWUgd2hvc2UgbGVuZ3RoIGV4Y2Vl
ZHMgdGhlIHJlc3RyaWN0aW9uIGlzCitoaWRkZW4gYW5kIGEgZWxsaXBzaXMgaXMgZGlzcGxheWVk
IGluc3RlYWQuICBBIHZhbHVlIG9mICd3aW5kb3cnIG1lYW5zCit1c2luZyB0aGUgcmlnaHQgZWRn
ZSBvZiB3aW5kb3cgYXMgdGhlIGRpc3BsYXkgcmVzdHJpY3Rpb24uICBUaGUKK2RlZmF1bHQgaXMg
bmlsLgorCiAqKiBFZGlmZgogCiAtLS0KZGlmZiAtLWdpdCBhL2xpc3AvZGlyZWQuZWwgYi9saXNw
L2RpcmVkLmVsCmluZGV4IDg5MTlkMmMyMjNmLi43ZWVhYjg2ZDg1MSAxMDA2NDQKLS0tIGEvbGlz
cC9kaXJlZC5lbAorKysgYi9saXNwL2RpcmVkLmVsCkBAIC0zNTAsNiArMzUwLDcgQEAgZGlyZWQt
YWZ0ZXItcmVhZGluLWhvb2sKIChkZWZjdXN0b20gZGlyZWQtbWFrZS1kaXJlY3RvcnktY2xpY2th
YmxlIHQKICAgIldoZW4gbm9uLW5pbCwgbWFrZSB0aGUgZGlyZWN0b3J5IGF0IHRoZSBzdGFydCBv
ZiB0aGUgZGlyZWQgYnVmZmVyIGNsaWNrYWJsZS4iCiAgIDp2ZXJzaW9uICIyOS4xIgorICA6Z3Jv
dXAgJ2RpcmVkCiAgIDp0eXBlICdib29sZWFuKQogCiAoZGVmY3VzdG9tIGRpcmVkLWluaXRpYWwt
cG9zaXRpb24taG9vayBuaWwKQEAgLTQyOSw2ICs0MzAsNyBAQCBkaXJlZC1tYXJrLXJlZ2lvbgog
KGRlZmN1c3RvbSBkaXJlZC1raWxsLXdoZW4tb3BlbmluZy1uZXctZGlyZWQtYnVmZmVyIG5pbAog
ICAiSWYgbm9uLW5pbCwga2lsbCB0aGUgY3VycmVudCBidWZmZXIgd2hlbiBzZWxlY3RpbmcgYSBu
ZXcgZGlyZWN0b3J5LiIKICAgOnR5cGUgJ2Jvb2xlYW4KKyAgOmdyb3VwICdkaXJlZAogICA6dmVy
c2lvbiAiMjguMSIpCiAKIChkZWZjdXN0b20gZGlyZWQtZ3Vlc3Mtc2hlbGwtY2FzZS1mb2xkLXNl
YXJjaCB0CkBAIC01MTUsNiArNTE3LDIyIEBAIGRpcmVkLW1vdmVtZW50LXN0eWxlCiAoZGVmY3Vz
dG9tIGRpcmVkLWhpZGUtZGV0YWlscy1wcmVzZXJ2ZWQtY29sdW1ucyBuaWwKICAgIkxpc3Qgb2Yg
Y29sdW1ucyB3aGljaCBhcmUgbm90IGhpZGRlbiBpbiBgZGlyZWQtaGlkZS1kZXRhaWxzLW1vZGUn
LiIKICAgOnR5cGUgJyhyZXBlYXQgaW50ZWdlcikKKyAgOmdyb3VwICdkaXJlZAorICA6dmVyc2lv
biAiMzAuMSIpCisKKyhkZWZjdXN0b20gZGlyZWQtZmlsZW5hbWUtZGlzcGxheS1sZW5ndGggbmls
CisgICJJZiBub24tbmlsLCByZXN0cmljdCB0aGUgZGlzcGxheSBsZW5ndGggb2YgZmlsZW5hbWVz
LgorSWYgdGhlIHZhbHVlIGlzIHRoZSBzeW1ib2wgYHdpbmRvdycsIHRoZSByaWdodCBlZGdlIG9m
IGN1cnJlbnQKK3dpbmRvdyBpcyB1c2VkIGFzIHRoZSByZXN0cmljdGlvbi4gIE90aGVyd2lzZSwg
aXQgc2hvdWxkIGJlIGFuCitpbnRlZ2VyIHJlcHJlc2VudGluZyB0aGUgbWF4aW11bSBmaWxlbmFt
ZSBsZW5ndGguCisKK1RoZSBtaWRkbGUgcGFydCBvZiBmaWxlbmFtZSB3aG9zZSBsZW5ndGggZXhj
ZWVkcyB0aGUgcmVzdHJpY3Rpb24KK2lzIGhpZGRlbiBieSB1c2luZyB0aGUgYGludmlzaWJsZScg
cHJvcGVydHkgYW5kIGEgZWxsaXBzaXMgaXMKK2Rpc3BsYXllZCBpbnN0ZWFkLiIKKyAgOnR5cGUg
JyhjaG9pY2UgKGNvbnN0ICAgOnRhZyAiTm8gcmVzdHJpY3Rpb24iIG5pbCkKKyAgICAgICAgICAg
ICAgICAgKGNvbnN0ICAgOnRhZyAiV2luZG93IiB3aW5kb3cpCisgICAgICAgICAgICAgICAgIChp
bnRlZ2VyIDp0YWcgIkludGVnZXIiKSkKKyAgOmdyb3VwICdkaXJlZAogICA6dmVyc2lvbiAiMzAu
MSIpCiAKIAwKQEAgLTE5MDMsNDggKzE5MjEsNjEgQEAgZGlyZWQtaW5zZXJ0LXNldC1wcm9wZXJ0
aWVzCiAgICJBZGQgdmFyaW91cyB0ZXh0IHByb3BlcnRpZXMgdG8gdGhlIGxpbmVzIGluIHRoZSBy
ZWdpb24sIGZyb20gQkVHIHRvIEVORC4iCiAgIChzYXZlLWV4Y3Vyc2lvbgogICAgIChnb3RvLWNo
YXIgYmVnKQotICAgICh3aGlsZSAoPCAocG9pbnQpIGVuZCkKLSAgICAgIChpZ25vcmUtZXJyb3Jz
Ci0JKGlmIChub3QgKGRpcmVkLW1vdmUtdG8tZmlsZW5hbWUpKQotCSAgICAodW5sZXNzIChvciAo
bG9va2luZy1hdC1wICJeJCIpCi0JCQkobG9va2luZy1hdC1wIGRpcmVkLXN1YmRpci1yZWdleHAp
KQotCSAgICAgIChwdXQtdGV4dC1wcm9wZXJ0eSAobGluZS1iZWdpbm5pbmctcG9zaXRpb24pCi0J
CQkJICgxKyAobGluZS1lbmQtcG9zaXRpb24pKQotCQkJCSAnaW52aXNpYmxlICdkaXJlZC1oaWRl
LWRldGFpbHMtaW5mb3JtYXRpb24pKQotCSAgKHNhdmUtZXhjdXJzaW9uCi0gICAgICAgICAgICAo
bGV0ICgoZW5kICgxLSAocG9pbnQpKSkKLSAgICAgICAgICAgICAgICAgIChvcG9pbnQgKGdvdG8t
Y2hhciAoMSsgKHBvcy1ib2wpKSkpCi0gICAgICAgICAgICAgICAgICAoaSAwKSkKLSAgICAgICAg
ICAgICAgKHB1dC10ZXh0LXByb3BlcnR5IG9wb2ludCBlbmQgJ2ludmlzaWJsZSAnZGlyZWQtaGlk
ZS1kZXRhaWxzLWRldGFpbCkKLSAgICAgICAgICAgICAgKHdoaWxlIChyZS1zZWFyY2gtZm9yd2Fy
ZCAiW14gXSsiIGVuZCB0KQotICAgICAgICAgICAgICAgICh3aGVuIChtZW1iZXIgKGNsLWluY2Yg
aSkgZGlyZWQtaGlkZS1kZXRhaWxzLXByZXNlcnZlZC1jb2x1bW5zKQotICAgICAgICAgICAgICAg
ICAgKHB1dC10ZXh0LXByb3BlcnR5IG9wb2ludCAocG9pbnQpICdpbnZpc2libGUgbmlsKSkKLSAg
ICAgICAgICAgICAgICAoc2V0cSBvcG9pbnQgKHBvaW50KSkpKSkKLSAgICAgICAgICAobGV0ICgo
YmVnIChwb2ludCkpIChlbmQgKHNhdmUtZXhjdXJzaW9uCi0JICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAoZGlyZWQtbW92ZS10by1lbmQtb2YtZmlsZW5hbWUpCi0JICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAoMS0gKHBvaW50KSkpKSkKLSAgICAgICAgICAgIChpZiBkaXJlZC1jbGlj
ay10by1zZWxlY3QtbW9kZQotICAgICAgICAgICAgICAgIChwdXQtdGV4dC1wcm9wZXJ0eSBiZWcg
ZW5kICdrZXltYXAKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZGlyZWQtY2xp
Y2stdG8tc2VsZWN0LW1hcCkKLSAgICAgICAgICAgICAgKHdoZW4gKGFuZCBkaXJlZC1tb3VzZS1k
cmFnLWZpbGVzIChmYm91bmRwICd4LWJlZ2luLWRyYWcpKQotICAgICAgICAgICAgICAgIChwdXQt
dGV4dC1wcm9wZXJ0eSBiZWcgZW5kICdrZXltYXAKLSAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgZGlyZWQtbW91c2UtZHJhZy1maWxlcy1tYXApKSkKLQkgICAgKGFkZC10ZXh0LXBy
b3BlcnRpZXMKLQkgICAgIGJlZyAoMSsgZW5kKQotCSAgICAgYChtb3VzZS1mYWNlCi0JICAgICAg
IGhpZ2hsaWdodAotCSAgICAgICBkaXJlZC1maWxlbmFtZSB0Ci0JICAgICAgIGhlbHAtZWNobyAs
KGlmIGRpcmVkLWNsaWNrLXRvLXNlbGVjdC1tb2RlCi0gICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAibW91c2UtMjogbWFyayBvciB1bm1hcmsgdGhpcyBmaWxlIgotICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIChpZiAoYW5kIGRpcmVkLW1vdXNlLWRyYWctZmlsZXMKLSAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAoZmJvdW5kcCAneC1iZWdpbi1kcmFnKSkKLSAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgImRvd24tbW91c2UtMTogZHJhZyB0aGlzIGZpbGUg
dG8gYW5vdGhlciBwcm9ncmFtCisgICAgKGxldCAoKGVsbC1sZW4gKGRpcmVkLS1nZXQtZWxsaXBz
aXMtbGVuZ3RoKSkgbWF4bGVuIGZpbGVuYW1lLWNvbCkKKyAgICAgICh3aGlsZSAoPCAocG9pbnQp
IGVuZCkKKyAgICAgICAgKGlnbm9yZS1lcnJvcnMKKwkgIChpZiAobm90IChkaXJlZC1tb3ZlLXRv
LWZpbGVuYW1lKSkKKwkgICAgICAodW5sZXNzIChvciAobG9va2luZy1hdC1wICJeJCIpCisJCQkg
IChsb29raW5nLWF0LXAgZGlyZWQtc3ViZGlyLXJlZ2V4cCkpCisJICAgICAgICAocHV0LXRleHQt
cHJvcGVydHkgKGxpbmUtYmVnaW5uaW5nLXBvc2l0aW9uKQorCQkJCSAgICgxKyAobGluZS1lbmQt
cG9zaXRpb24pKQorCQkJCSAgICdpbnZpc2libGUgJ2RpcmVkLWhpZGUtZGV0YWlscy1pbmZvcm1h
dGlvbikpCisJICAgIChzYXZlLWV4Y3Vyc2lvbgorICAgICAgICAgICAgICAobGV0ICgoZW5kICgx
LSAocG9pbnQpKSkKKyAgICAgICAgICAgICAgICAgICAgKG9wb2ludCAoZ290by1jaGFyICgxKyAo
cG9zLWJvbCkpKSkKKyAgICAgICAgICAgICAgICAgICAgKGkgMCkpCisgICAgICAgICAgICAgICAg
KHB1dC10ZXh0LXByb3BlcnR5IG9wb2ludCBlbmQgJ2ludmlzaWJsZSAnZGlyZWQtaGlkZS1kZXRh
aWxzLWRldGFpbCkKKyAgICAgICAgICAgICAgICAod2hpbGUgKHJlLXNlYXJjaC1mb3J3YXJkICJb
XiBdKyIgZW5kIHQpCisgICAgICAgICAgICAgICAgICAod2hlbiAobWVtYmVyIChjbC1pbmNmIGkp
IGRpcmVkLWhpZGUtZGV0YWlscy1wcmVzZXJ2ZWQtY29sdW1ucykKKyAgICAgICAgICAgICAgICAg
ICAgKHB1dC10ZXh0LXByb3BlcnR5IG9wb2ludCAocG9pbnQpICdpbnZpc2libGUgbmlsKSkKKyAg
ICAgICAgICAgICAgICAgIChzZXRxIG9wb2ludCAocG9pbnQpKSkpKQorICAgICAgICAgICAgKGxl
dCAoKGJlZyAocG9pbnQpKSAoZW5kIChzYXZlLWV4Y3Vyc2lvbgorCSAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAoZGlyZWQtbW92ZS10by1lbmQtb2YtZmlsZW5hbWUpCisJICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICgxLSAocG9pbnQpKSkpKQorICAgICAgICAgICAgICAoaWYg
ZGlyZWQtY2xpY2stdG8tc2VsZWN0LW1vZGUKKyAgICAgICAgICAgICAgICAgIChwdXQtdGV4dC1w
cm9wZXJ0eSBiZWcgZW5kICdrZXltYXAKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICBkaXJlZC1jbGljay10by1zZWxlY3QtbWFwKQorICAgICAgICAgICAgICAgICh3aGVuIChh
bmQgZGlyZWQtbW91c2UtZHJhZy1maWxlcyAoZmJvdW5kcCAneC1iZWdpbi1kcmFnKSkKKyAgICAg
ICAgICAgICAgICAgIChwdXQtdGV4dC1wcm9wZXJ0eSBiZWcgZW5kICdrZXltYXAKKyAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkaXJlZC1tb3VzZS1kcmFnLWZpbGVzLW1hcCkp
KQorICAgICAgICAgICAgICAod2hlbiBkaXJlZC1maWxlbmFtZS1kaXNwbGF5LWxlbmd0aAorICAg
ICAgICAgICAgICAgIChsZXQgKChsZW4gKHN0cmluZy13aWR0aCAoYnVmZmVyLXN1YnN0cmluZyBi
ZWcgKDErIGVuZCkpKSkKKyAgICAgICAgICAgICAgICAgICAgICBlbGwtYmVnKQorICAgICAgICAg
ICAgICAgICAgKG9yIG1heGxlbiAoc2V0cSBtYXhsZW4gKGRpcmVkLS1nZXQtZmlsZW5hbWUtZGlz
cGxheS1sZW5ndGgpKSkKKyAgICAgICAgICAgICAgICAgICh3aGVuIChhbmQgKGludGVnZXJwIG1h
eGxlbikgKD4gbGVuIG1heGxlbiAoKyBlbGwtbGVuIDIpKSkKKyAgICAgICAgICAgICAgICAgICAg
KG9yIGZpbGVuYW1lLWNvbCAoc2V0cSBmaWxlbmFtZS1jb2wgKGN1cnJlbnQtY29sdW1uKSkpCisg
ICAgICAgICAgICAgICAgICAgIChtb3ZlLXRvLWNvbHVtbiAoKyBmaWxlbmFtZS1jb2wgKC8gbWF4
bGVuIDIpKSkKKyAgICAgICAgICAgICAgICAgICAgKHNldHEgZWxsLWJlZyAocG9pbnQpKQorICAg
ICAgICAgICAgICAgICAgICAobW92ZS10by1jb2x1bW4gKCsgZmlsZW5hbWUtY29sICgvIG1heGxl
biAyKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKC0gbGVuIG1heGxl
bikgZWxsLWxlbikpCisgICAgICAgICAgICAgICAgICAgIChwdXQtdGV4dC1wcm9wZXJ0eQorICAg
ICAgICAgICAgICAgICAgICAgZWxsLWJlZyAocG9pbnQpICdpbnZpc2libGUgJ2RpcmVkLWZpbGVu
YW1lLWhpZGUpKSkpCisJICAgICAgKGFkZC10ZXh0LXByb3BlcnRpZXMKKwkgICAgICAgYmVnICgx
KyBlbmQpCisJICAgICAgIGAobW91c2UtZmFjZQorCSAgICAgICAgIGhpZ2hsaWdodAorCSAgICAg
ICAgIGRpcmVkLWZpbGVuYW1lIHQKKwkgICAgICAgICBoZWxwLWVjaG8gLChpZiBkaXJlZC1jbGlj
ay10by1zZWxlY3QtbW9kZQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAibW91c2Ut
MjogbWFyayBvciB1bm1hcmsgdGhpcyBmaWxlIgorICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgKGlmIChhbmQgZGlyZWQtbW91c2UtZHJhZy1maWxlcworICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgKGZib3VuZHAgJ3gtYmVnaW4tZHJhZykpCisgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgImRvd24tbW91c2UtMTogZHJhZyB0aGlzIGZpbGUgdG8gYW5v
dGhlciBwcm9ncmFtCiBtb3VzZS0yOiB2aXNpdCB0aGlzIGZpbGUgaW4gb3RoZXIgd2luZG93Igot
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIm1vdXNlLTI6IHZpc2l0IHRoaXMgZmlsZSBp
biBvdGhlciB3aW5kb3ciKSkpKQotCSAgICAod2hlbiAoPCAoKyBlbmQgNSkgKGxpbmUtZW5kLXBv
c2l0aW9uKSkKLQkgICAgICAocHV0LXRleHQtcHJvcGVydHkgKCsgZW5kIDUpIChsaW5lLWVuZC1w
b3NpdGlvbikKLQkJCSAgICAgICAgICdpbnZpc2libGUgJ2RpcmVkLWhpZGUtZGV0YWlscy1saW5r
KSkpKSkKLSAgICAgIChmb3J3YXJkLWxpbmUgMSkpKSkKKyAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIm1vdXNlLTI6IHZpc2l0IHRoaXMgZmlsZSBpbiBvdGhlciB3aW5kb3ciKSkpKQor
CSAgICAgICh3aGVuICg8ICgrIGVuZCA1KSAobGluZS1lbmQtcG9zaXRpb24pKQorCSAgICAgICAg
KHB1dC10ZXh0LXByb3BlcnR5ICgrIGVuZCA1KSAobGluZS1lbmQtcG9zaXRpb24pCisJCQkgICAg
ICAgICAgICdpbnZpc2libGUgJ2RpcmVkLWhpZGUtZGV0YWlscy1saW5rKSkpKSkKKyAgICAgICAg
KGZvcndhcmQtbGluZSAxKSkpKSkKIAogKGRlZnVuIGRpcmVkLS1tYWtlLWRpcmVjdG9yeS1jbGlj
a2FibGUgKCkKICAgKHNhdmUtZXhjdXJzaW9uCkBAIC0xOTc2LDYgKzIwMDcsMjEgQEAgZGlyZWQt
LW1ha2UtZGlyZWN0b3J5LWNsaWNrYWJsZQogICAgICAgICAgICAgICAgICAgICAgICAgICAiUkVU
IiBjbGljaykpKSkKICAgICAgICAgICAoc2V0cSBzZWdtZW50LXN0YXJ0IChwb2ludCkpKSkpKSkK
IAorKGRlZnVuIGRpcmVkLS1nZXQtZWxsaXBzaXMtbGVuZ3RoICgpCisgICJSZXR1cm4gbGVuZ3Ro
IG9mIGVsbGlwc2lzLiIKKyAgKGxldCogKChkdCAob3IgKHdpbmRvdy1kaXNwbGF5LXRhYmxlKQor
ICAgICAgICAgICAgICAgICBidWZmZXItZGlzcGxheS10YWJsZQorICAgICAgICAgICAgICAgICBz
dGFuZGFyZC1kaXNwbGF5LXRhYmxlKSkKKyAgICAgICAgIChnbHlwaHMgKGFuZCBkdCAoZGlzcGxh
eS10YWJsZS1zbG90IGR0ICdzZWxlY3RpdmUtZGlzcGxheSkpKSkKKyAgICAoc3RyaW5nLXdpZHRo
IChpZiBnbHlwaHMgKGNvbmNhdCBnbHlwaHMpICIuLi4iKSkpKQorCisoZGVmdW4gZGlyZWQtLWdl
dC1maWxlbmFtZS1kaXNwbGF5LWxlbmd0aCAoKQorICAiUmV0dXJuIG1heGltdW0gZGlzcGxheSBs
ZW5ndGggb2YgZmlsZW5hbWUuCitJdCBpcyBjYWxsZWQgYXQgdGhlIGZpcnN0IGNoYXJhY3RlciBv
ZiB0aGUgZmlsZSBuYW1lLiIKKyAgKGlmIChpbnRlZ2VycCBkaXJlZC1maWxlbmFtZS1kaXNwbGF5
LWxlbmd0aCkKKyAgICAgIGRpcmVkLWZpbGVuYW1lLWRpc3BsYXktbGVuZ3RoCisgICAgKC0gKHdp
bmRvdy1tYXgtY2hhcnMtcGVyLWxpbmUpIDEgKGN1cnJlbnQtY29sdW1uKSkpKQorCiAMCiA7Ozsg
UmV2ZXJ0aW5nIGEgZGlyZWQgYnVmZmVyCiAKQEAgLTI2MTcsNiArMjY2Myw3IEBAIGRpcmVkLW1v
ZGUKIAltb2RlLWxpbmUtYnVmZmVyLWlkZW50aWZpY2F0aW9uCiAJKHByb3BlcnRpemVkLWJ1ZmZl
ci1pZGVudGlmaWNhdGlvbiAiJTE3YiIpKQogICAoYWRkLXRvLWludmlzaWJpbGl0eS1zcGVjICco
ZGlyZWQgLiB0KSkKKyAgKGRpcmVkLWZpbGVuYW1lLXVwZGF0ZS1pbnZpc2liaWxpdHktc3BlYykK
ICAgOzsgSWdub3JlIGRpcmVkLWhpZGUtZGV0YWlscy0qIHZhbHVlIG9mIGludmlzaWJsZSB0ZXh0
IHByb3BlcnR5IGJ5IGRlZmF1bHQuCiAgICh3aGVuIChlcSBidWZmZXItaW52aXNpYmlsaXR5LXNw
ZWMgdCkKICAgICAoc2V0cSBidWZmZXItaW52aXNpYmlsaXR5LXNwZWMgKGxpc3QgdCkpKQpAQCAt
MzEwNiw2ICszMTUzLDE1IEBAIGRpcmVkLWhpZGUtZGV0YWlscy11cGRhdGUtaW52aXNpYmlsaXR5
LXNwZWMKIAwKIDs7OyBGdW5jdGlvbnMgdG8gaGlkZS91bmhpZGUgdGV4dAogCisoZGVmdW4gZGly
ZWQtZmlsZW5hbWUtdXBkYXRlLWludmlzaWJpbGl0eS1zcGVjICgpCisgICJVcGRhdGUgYGJ1ZmZl
ci1pbnZpc2liaWxpdHktc3BlYycgZm9yIGZpbGVuYW1lcy4KK1NwZWNpZmljYWxseSwgdGhlIGZp
bGVuYW1lIGludmlzaWJpbGl0eSBzcGVjIGlzIGFkZGVkIGluIERpcmVkCitidWZmZXJzIGFuZCBy
ZW1vdmVkIGluIFdEaXJlZCBidWZmZXJzLiIKKyAgKGZ1bmNhbGwgKGlmIChkZXJpdmVkLW1vZGUt
cCAnZGlyZWQtbW9kZSkKKyAgICAgICAgICAgICAgICdhZGQtdG8taW52aXNpYmlsaXR5LXNwZWMK
KyAgICAgICAgICAgICAncmVtb3ZlLWZyb20taW52aXNpYmlsaXR5LXNwZWMpCisgICAgICAgICAg
ICcoZGlyZWQtZmlsZW5hbWUtaGlkZSAuIHQpKSkKKwogKGRlZnVuIGRpcmVkLS1maW5kLWhpZGRl
bi1wb3MgKHN0YXJ0IGVuZCkKICAgKHRleHQtcHJvcGVydHktYW55IHN0YXJ0IGVuZCAnaW52aXNp
YmxlICdkaXJlZCkpCiAKZGlmZiAtLWdpdCBhL2xpc3Avd2RpcmVkLmVsIGIvbGlzcC93ZGlyZWQu
ZWwKaW5kZXggMDc5ZDkzZDYwMTEuLmI5OTZiZTliYWE5IDEwMDY0NAotLS0gYS9saXNwL3dkaXJl
ZC5lbAorKysgYi9saXNwL3dkaXJlZC5lbApAQCAtMjYxLDYgKzI2MSw5IEBAIHdkaXJlZC1jaGFu
Z2UtdG8td2RpcmVkLW1vZGUKICAgKGFkZC1mdW5jdGlvbiA6b3ZlcnJpZGUgKGxvY2FsICdyZXZl
cnQtYnVmZmVyLWZ1bmN0aW9uKSAjJ3dkaXJlZC1yZXZlcnQpCiAgIChzZXQtYnVmZmVyLW1vZGlm
aWVkLXAgbmlsKQogICAoc2V0cSBidWZmZXItdW5kby1saXN0IG5pbCkKKyAgOzsgcmVtb3ZlIGZp
bGVuYW1lIGludmlzaWJpbGl0eSBzcGVjIHRvIGVuc3VyZSBmaWxlbmFtZXMgYXJlIHZpc2libGUK
KyAgOzsgZm9yIGVkaXRpbmcKKyAgKGRpcmVkLWZpbGVuYW1lLXVwZGF0ZS1pbnZpc2liaWxpdHkt
c3BlYykKICAgKHJ1bi1tb2RlLWhvb2tzICd3ZGlyZWQtbW9kZS1ob29rKQogICAobWVzc2FnZSAi
JXMiIChzdWJzdGl0dXRlLWNvbW1hbmQta2V5cwogCQkgIlByZXNzIFxcW3dkaXJlZC1maW5pc2gt
ZWRpdF0gd2hlbiBmaW5pc2hlZCBcCkBAIC00NTYsNiArNDU5LDkgQEAgd2RpcmVkLWNoYW5nZS10
by1kaXJlZC1tb2RlCiAgIChkaXJlZC1zb3J0LXNldC1tb2RlLWxpbmUpCiAgIChkaXJlZC1hZHZl
cnRpc2UpCiAgIChkaXJlZC1oaWRlLWRldGFpbHMtdXBkYXRlLWludmlzaWJpbGl0eS1zcGVjKQor
ICA7OyByZS1hZGQgZmlsZW5hbWUgaW52aXNpYmlsaXR5IHNwZWMgdGhhdCBpcyByZW1vdmVkIGlu
CisgIDs7IGB3ZGlyZWQtY2hhbmdlLXRvLXdkaXJlZC1tb2RlJworICAoZGlyZWQtZmlsZW5hbWUt
dXBkYXRlLWludmlzaWJpbGl0eS1zcGVjKQogICAocmVtb3ZlLWhvb2sgJ2tpbGwtYnVmZmVyLWhv
b2sgIyd3ZGlyZWQtY2hlY2sta2lsbC1idWZmZXIgdCkKICAgKHJlbW92ZS1ob29rICdiZWZvcmUt
Y2hhbmdlLWZ1bmN0aW9ucyAjJ3dkaXJlZC0tYmVmb3JlLWNoYW5nZS1mbiB0KQogICAocmVtb3Zl
LWhvb2sgJ2FmdGVyLWNoYW5nZS1mdW5jdGlvbnMgIyd3ZGlyZWQtLXJlc3RvcmUtcHJvcGVydGll
cyB0KQotLSAKMi4yNS4xCgo=
--000000000000cc4070060a69ce7b--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67161; Package emacs. Full text available.

Message received at 67161 <at> debbugs.gnu.org:


Received: (at 67161) by debbugs.gnu.org; 16 Nov 2023 12:11:53 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 16 07:11:53 2023
Received: from localhost ([127.0.0.1]:54650 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r3bDs-0006vl-Vk
	for submit <at> debbugs.gnu.org; Thu, 16 Nov 2023 07:11:53 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:49468)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1r3bDp-0006vW-0D
 for 67161 <at> debbugs.gnu.org; Thu, 16 Nov 2023 07:11:51 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1r3bDj-00014p-NT; Thu, 16 Nov 2023 07:11:43 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=h+ZXiTiJEzUYdX9mBWUH7Gvec9uNSttnUE6q8UVlvF0=; b=V+1g74We6Elk
 pLsEem3nxoCQCLdQeVtJBv0bIk97Kgpzax+Par4OCR6GiUsYXLyvSJD1+Tq9HmJzeoR0l8etIKhg+
 kLIGnF1Zuq+rDGBYGV0EUHWBnSLiMrtwvJ9uDlvfaetSdwrPIpo0/Fa+nwdm2sMhqrHEZv56vV5O7
 s3zXdZPuM/4U8slLUhmzg4R3dM+EaMXjI6ddDKqRXgG/xzANfdYua8icVkJLq4WMXI8C7iileULek
 IFPny383tClYm96xpcoh3QHPZSek7IRcw8/hNt0BI7Db2ZZTd1f8biEIeAH2R5zYct6BsZnY+eDfa
 6VpKYrfIY6B7cVJinNiDmg==;
Date: Thu, 16 Nov 2023 14:11:35 +0200
Message-Id: <83sf55q4nc.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Liu Hui <liuhui1610@HIDDEN>
In-Reply-To: <CAOQTW-M5VaV0Va+ixd2-6SoKb4tPebxviobOB8Qs3Oxb9js9GA@HIDDEN>
 (message from Liu Hui on Thu, 16 Nov 2023 18:07:04 +0800)
Subject: Re: bug#67161: 30.0.50;
 [PATCH] Add option `dired-filename-display-length'
References: <CAOQTW-MSpBK4ACpLk8U2m6HJx8HXw21O0kyYZ-i85ETNjyOUcA@HIDDEN>
 <8334x8tqi9.fsf@HIDDEN>
 <CAOQTW-P4+vs+JH8BTL8fL-d1QJXOdYq3i+3O7tALTDs=qHpnzA@HIDDEN>
 <83a5rfrych.fsf@HIDDEN>
 <CAOQTW-M5VaV0Va+ixd2-6SoKb4tPebxviobOB8Qs3Oxb9js9GA@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 67161
Cc: 67161 <at> debbugs.gnu.org, stefankangas@HIDDEN, monnier@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Liu Hui <liuhui1610@HIDDEN>
> Date: Thu, 16 Nov 2023 18:07:04 +0800
> Cc: Stefan Kangas <stefankangas@HIDDEN>, Stefan Monnier <monnier@HIDDEN>, 
> 	67161 <at> debbugs.gnu.org
> 
> From 991ea588df6799331a7feea9e83493ef0d724096 Mon Sep 17 00:00:00 2001
> From: Liu Hui <liuhui1610@HIDDEN>
> Date: Tue, 14 Nov 2023 16:14:12 +0800
> Subject: [PATCH] Add option `dired-filename-display-length'
> 
> * lisp/dired.el (dired-filename-display-length): New option.
> (dired-insert-set-properties): Set invisibility spec for long
> filenames.
> (dired--get-ellipsis-length)
> (dired--get-filename-display-length)
> (dired-filename-update-invisibility-spec): New functions.
> (dired-mode): Add filename invisibility spec.
> (dired-make-directory-clickable):
> (dired-kill-when-opening-new-dired-buffer):
> (dired-hide-details-preserved-columns): Add missing group.
> * lisp/wdired.el (wdired-change-to-wdired-mode)
> (wdired-change-to-dired-mode): Update filename invisibility spec.

These changes need a NEWS entry to describe the new option and its
effect in short.

> diff --git a/lisp/dired.el b/lisp/dired.el
> index 8919d2c223f..aad77a3dfc0 100644
> --- a/lisp/dired.el
> +++ b/lisp/dired.el
> @@ -350,6 +350,7 @@ dired-after-readin-hook
>  (defcustom dired-make-directory-clickable t
>    "When non-nil, make the directory at the start of the dired buffer clickable."
>    :version "29.1"
> +  :group 'dired
>    :type 'boolean)
>  
>  (defcustom dired-initial-position-hook nil
> @@ -429,6 +430,7 @@ dired-mark-region
>  (defcustom dired-kill-when-opening-new-dired-buffer nil
>    "If non-nil, kill the current buffer when selecting a new directory."
>    :type 'boolean
> +  :group 'dired
>    :version "28.1")
>  
>  (defcustom dired-guess-shell-case-fold-search t
> @@ -515,6 +517,18 @@ dired-movement-style
>  (defcustom dired-hide-details-preserved-columns nil
>    "List of columns which are not hidden in `dired-hide-details-mode'."
>    :type '(repeat integer)
> +  :group 'dired
> +  :version "30.1")

Why do we need an explicit :group tag here?  Options whose group is
not 'dired' indeed need it, but those whose group is 'dired' get it
implicitly, AFAIU.

> +(defcustom dired-filename-display-length nil
> +  "If non-nil, hide middle part of long filenames in Dired buffers.
> +If the value is the symbol `window', then filenames are shortened
> +to not exceed the right edge of current window.  Otherwise, it
> +should be an integer representing the maximum filename length."

This should tell more about the effect: that portions of longer file
names are hidden by using the 'invisible' property and that the
ellipsis is displayed in their stead.

> +(defun dired--get-ellipsis-length ()
> +  "Return length of ellipsis."
> +  (let* ((dt (or (window-display-table)
> +                 buffer-display-table
> +                 standard-display-table))
> +         (glyphs (and dt (display-table-slot dt 'selective-display))))
> +    (if glyphs (length glyphs) (eval-when-compile (length "...")))))

Why do you use 'length' here and not 'string-width' or similar?  You
seem to assume that each character takes just one column on display?

> +(defun dired--get-filename-display-length ()
> +  "Return maximum display length of filename."

This doc string is inaccurate.  The function actually returns the
number of columns available for displaying the file names in a Dired
buffer, and it should be called with point at the first character of
the file name.

> +(defun dired-filename-update-invisibility-spec ()

This function should have a doc string.

> diff --git a/lisp/wdired.el b/lisp/wdired.el
> index 079d93d6011..5d50a574290 100644
> --- a/lisp/wdired.el
> +++ b/lisp/wdired.el
> @@ -261,6 +261,7 @@ wdired-change-to-wdired-mode
>    (add-function :override (local 'revert-buffer-function) #'wdired-revert)
>    (set-buffer-modified-p nil)
>    (setq buffer-undo-list nil)
> +  (dired-filename-update-invisibility-spec)
>    (run-mode-hooks 'wdired-mode-hook)
>    (message "%s" (substitute-command-keys
>  		 "Press \\[wdired-finish-edit] when finished \
> @@ -456,6 +457,7 @@ wdired-change-to-dired-mode
>    (dired-sort-set-mode-line)
>    (dired-advertise)
>    (dired-hide-details-update-invisibility-spec)
> +  (dired-filename-update-invisibility-spec)

Please add comments in these two places explaining why you call
dired-filename-update-invisibility-spec here, so that the reader won't
need to look at that function to understand the reason.

Thanks.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67161; Package emacs. Full text available.

Message received at 67161 <at> debbugs.gnu.org:


Received: (at 67161) by debbugs.gnu.org; 16 Nov 2023 10:07:25 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 16 05:07:25 2023
Received: from localhost ([127.0.0.1]:54520 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r3ZHQ-0000jr-EN
	for submit <at> debbugs.gnu.org; Thu, 16 Nov 2023 05:07:25 -0500
Received: from mail-ua1-x932.google.com ([2607:f8b0:4864:20::932]:55334)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <liuhui1610@HIDDEN>) id 1r3ZHO-0000je-04
 for 67161 <at> debbugs.gnu.org; Thu, 16 Nov 2023 05:07:22 -0500
Received: by mail-ua1-x932.google.com with SMTP id
 a1e0cc1a2514c-7ba6a0bada9so247999241.2
 for <67161 <at> debbugs.gnu.org>; Thu, 16 Nov 2023 02:07:22 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1700129236; x=1700734036; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:from:to:cc:subject:date:message-id:reply-to;
 bh=yfJuzNxmCuG3EWnCzr7Fdzbif8Bg8aefUoRkGK4ZWUg=;
 b=bqyYaTepGczfLjjfFOGsE1S1YClZykgfNPVLnIb9Vk/7BRPSRcLuWUKwj37FuP/y7a
 KbZ7ltwj7J1JhzMaKoI56ZNWpCailchkOkteJy5JlC/QgHVDMSHGaw57/aFQJP1tBrUQ
 Z+/GDjyDACtIRutCUzf/YdaKOOw63PJWgHOSPbN7V6CACfgAhuL87q5JThQErgavHFmv
 5iBP/ecHTzgghou+LelfxJUn8nC1DZYyO05oJe+ocx9DCzEaepfGgit8uxi4AWwMAGuI
 YMZM4szKRdMr+CdU+VGzodumD1lk+wn5vCS85ad3kKhBzThlLbMQZWRVbmcQty5Xq9ZD
 hduA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1700129236; x=1700734036;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=yfJuzNxmCuG3EWnCzr7Fdzbif8Bg8aefUoRkGK4ZWUg=;
 b=An7Oj+Evzly72176Kcqixu/hKEMsNV3W/JNDsBim4VvVjhXP+lxOOOZfidClp2mb0w
 pvZoV2U9qBZFzH/+hPQ7JdhRYCXqMmeSGPL8wKMIAw/zAqSvTfE1S+vXdDe+K/Zx6GzF
 U+oAPphBAFyqzOSp740vziTodHg/gMCu8EkpJ9y3spfNlNfTjBFjD4N0b9w+R+IRgajr
 gM8POYtx9VYN5i1xB3kwsqgq1o5980a/MlrMOHlyooYcKg1YaTWk2uGMTdCm0YOPzJug
 cZhY8v5A1p+NN+2ike28C7798oUjQoU+hlsZAHvqz6t/x5jHYCfQdlkJt+e4ICh0aCUa
 sxFQ==
X-Gm-Message-State: AOJu0YwZWUqBHkm1QNk0DVd/R9fu9o0IM5M6kMz7hkrtr9/WpkYLUWzr
 O1bNOoFjdtLDNu8XWLVdxpB7ZZ2gVEcycZNtZgA=
X-Google-Smtp-Source: AGHT+IG1jm0gFt02wnBhi8BqO2vHrTPugbCq8gCpUauc/nIoWEIF+0XQ7QJxmvYIZ5aYsIVrzlMrgJCGHHrszQPrxuc=
X-Received: by 2002:a67:c08d:0:b0:45d:b9fa:48e9 with SMTP id
 x13-20020a67c08d000000b0045db9fa48e9mr14383354vsi.31.1700129236708; Thu, 16
 Nov 2023 02:07:16 -0800 (PST)
MIME-Version: 1.0
References: <CAOQTW-MSpBK4ACpLk8U2m6HJx8HXw21O0kyYZ-i85ETNjyOUcA@HIDDEN>
 <8334x8tqi9.fsf@HIDDEN>
 <CAOQTW-P4+vs+JH8BTL8fL-d1QJXOdYq3i+3O7tALTDs=qHpnzA@HIDDEN>
 <83a5rfrych.fsf@HIDDEN>
In-Reply-To: <83a5rfrych.fsf@HIDDEN>
From: Liu Hui <liuhui1610@HIDDEN>
Date: Thu, 16 Nov 2023 18:07:04 +0800
Message-ID: <CAOQTW-M5VaV0Va+ixd2-6SoKb4tPebxviobOB8Qs3Oxb9js9GA@HIDDEN>
Subject: Re: bug#67161: 30.0.50;
 [PATCH] Add option `dired-filename-display-length'
To: Eli Zaretskii <eliz@HIDDEN>
Content-Type: multipart/mixed; boundary="0000000000003a040d060a422fb5"
X-Spam-Score: 0.2 (/)
X-Debbugs-Envelope-To: 67161
Cc: 67161 <at> debbugs.gnu.org, Stefan Kangas <stefankangas@HIDDEN>,
 Stefan Monnier <monnier@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.8 (/)

--0000000000003a040d060a422fb5
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Eli Zaretskii <eliz@HIDDEN> =E4=BA=8E2023=E5=B9=B411=E6=9C=8815=E6=97=A5=
=E5=91=A8=E4=B8=89 20:32=E5=86=99=E9=81=93=EF=BC=9A

> I actually wonder why we need it as a defcustom.  If you use
> truncate-string-ellipsis, you will get both a customizable setting and
> the correct string for the terminal at hand.  Why do we need an extra
> option?

As Stefan promptly pointed out, the ellipsis defcustom is actually
useless because the display of ellipsis is determined by the display
table. So I have deleted it in the attached patch.

> So you consider using the 'invisible' property a good feature?  I
> actually don't like using it for such purposes, as it gets in the way.

I don't know the drawback of the 'invisible' property. This patch is
inspired by dired-hide-details-mode, which uses the property to hide
file information.

> Btw, using string-width might not be the best possibility here.  I
> would recommend string-pixel-width instead (with subsequent division
> by what default-char-width returns), as that will produce a better
> approximation, especially on GUI frames.

I agree using pixel width is more accurate, though the approximation
based on character width is good enough in most cases. In fact, in
addition to string-width, move-to-column also needs to be replaced by
a function that moves the point to the character at a specific pixel
position. It seems there isn't such a built-in function.

--0000000000003a040d060a422fb5
Content-Type: text/x-patch; charset="US-ASCII"; 
	name="0001-Add-option-dired-filename-display-length.patch"
Content-Disposition: attachment; 
	filename="0001-Add-option-dired-filename-display-length.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_lp10rqjg0>
X-Attachment-Id: f_lp10rqjg0

RnJvbSA5OTFlYTU4OGRmNjc5OTMzMWE3ZmVlYTllODM0OTNlZjBkNzI0MDk2IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBMaXUgSHVpIDxsaXVodWkxNjEwQGdtYWlsLmNvbT4KRGF0ZTog
VHVlLCAxNCBOb3YgMjAyMyAxNjoxNDoxMiArMDgwMApTdWJqZWN0OiBbUEFUQ0hdIEFkZCBvcHRp
b24gYGRpcmVkLWZpbGVuYW1lLWRpc3BsYXktbGVuZ3RoJwoKKiBsaXNwL2RpcmVkLmVsIChkaXJl
ZC1maWxlbmFtZS1kaXNwbGF5LWxlbmd0aCk6IE5ldyBvcHRpb24uCihkaXJlZC1pbnNlcnQtc2V0
LXByb3BlcnRpZXMpOiBTZXQgaW52aXNpYmlsaXR5IHNwZWMgZm9yIGxvbmcKZmlsZW5hbWVzLgoo
ZGlyZWQtLWdldC1lbGxpcHNpcy1sZW5ndGgpCihkaXJlZC0tZ2V0LWZpbGVuYW1lLWRpc3BsYXkt
bGVuZ3RoKQooZGlyZWQtZmlsZW5hbWUtdXBkYXRlLWludmlzaWJpbGl0eS1zcGVjKTogTmV3IGZ1
bmN0aW9ucy4KKGRpcmVkLW1vZGUpOiBBZGQgZmlsZW5hbWUgaW52aXNpYmlsaXR5IHNwZWMuCihk
aXJlZC1tYWtlLWRpcmVjdG9yeS1jbGlja2FibGUpOgooZGlyZWQta2lsbC13aGVuLW9wZW5pbmct
bmV3LWRpcmVkLWJ1ZmZlcik6CihkaXJlZC1oaWRlLWRldGFpbHMtcHJlc2VydmVkLWNvbHVtbnMp
OiBBZGQgbWlzc2luZyBncm91cC4KKiBsaXNwL3dkaXJlZC5lbCAod2RpcmVkLWNoYW5nZS10by13
ZGlyZWQtbW9kZSkKKHdkaXJlZC1jaGFuZ2UtdG8tZGlyZWQtbW9kZSk6IFVwZGF0ZSBmaWxlbmFt
ZSBpbnZpc2liaWxpdHkgc3BlYy4KLS0tCiBsaXNwL2RpcmVkLmVsICB8IDEzMCArKysrKysrKysr
KysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tCiBsaXNwL3dkaXJlZC5lbCB8
ICAgMiArCiAyIGZpbGVzIGNoYW5nZWQsIDkxIGluc2VydGlvbnMoKyksIDQxIGRlbGV0aW9ucygt
KQoKZGlmZiAtLWdpdCBhL2xpc3AvZGlyZWQuZWwgYi9saXNwL2RpcmVkLmVsCmluZGV4IDg5MTlk
MmMyMjNmLi5hYWQ3N2EzZGZjMCAxMDA2NDQKLS0tIGEvbGlzcC9kaXJlZC5lbAorKysgYi9saXNw
L2RpcmVkLmVsCkBAIC0zNTAsNiArMzUwLDcgQEAgZGlyZWQtYWZ0ZXItcmVhZGluLWhvb2sKIChk
ZWZjdXN0b20gZGlyZWQtbWFrZS1kaXJlY3RvcnktY2xpY2thYmxlIHQKICAgIldoZW4gbm9uLW5p
bCwgbWFrZSB0aGUgZGlyZWN0b3J5IGF0IHRoZSBzdGFydCBvZiB0aGUgZGlyZWQgYnVmZmVyIGNs
aWNrYWJsZS4iCiAgIDp2ZXJzaW9uICIyOS4xIgorICA6Z3JvdXAgJ2RpcmVkCiAgIDp0eXBlICdi
b29sZWFuKQogCiAoZGVmY3VzdG9tIGRpcmVkLWluaXRpYWwtcG9zaXRpb24taG9vayBuaWwKQEAg
LTQyOSw2ICs0MzAsNyBAQCBkaXJlZC1tYXJrLXJlZ2lvbgogKGRlZmN1c3RvbSBkaXJlZC1raWxs
LXdoZW4tb3BlbmluZy1uZXctZGlyZWQtYnVmZmVyIG5pbAogICAiSWYgbm9uLW5pbCwga2lsbCB0
aGUgY3VycmVudCBidWZmZXIgd2hlbiBzZWxlY3RpbmcgYSBuZXcgZGlyZWN0b3J5LiIKICAgOnR5
cGUgJ2Jvb2xlYW4KKyAgOmdyb3VwICdkaXJlZAogICA6dmVyc2lvbiAiMjguMSIpCiAKIChkZWZj
dXN0b20gZGlyZWQtZ3Vlc3Mtc2hlbGwtY2FzZS1mb2xkLXNlYXJjaCB0CkBAIC01MTUsNiArNTE3
LDE4IEBAIGRpcmVkLW1vdmVtZW50LXN0eWxlCiAoZGVmY3VzdG9tIGRpcmVkLWhpZGUtZGV0YWls
cy1wcmVzZXJ2ZWQtY29sdW1ucyBuaWwKICAgIkxpc3Qgb2YgY29sdW1ucyB3aGljaCBhcmUgbm90
IGhpZGRlbiBpbiBgZGlyZWQtaGlkZS1kZXRhaWxzLW1vZGUnLiIKICAgOnR5cGUgJyhyZXBlYXQg
aW50ZWdlcikKKyAgOmdyb3VwICdkaXJlZAorICA6dmVyc2lvbiAiMzAuMSIpCisKKyhkZWZjdXN0
b20gZGlyZWQtZmlsZW5hbWUtZGlzcGxheS1sZW5ndGggbmlsCisgICJJZiBub24tbmlsLCBoaWRl
IG1pZGRsZSBwYXJ0IG9mIGxvbmcgZmlsZW5hbWVzIGluIERpcmVkIGJ1ZmZlcnMuCitJZiB0aGUg
dmFsdWUgaXMgdGhlIHN5bWJvbCBgd2luZG93JywgdGhlbiBmaWxlbmFtZXMgYXJlIHNob3J0ZW5l
ZAordG8gbm90IGV4Y2VlZCB0aGUgcmlnaHQgZWRnZSBvZiBjdXJyZW50IHdpbmRvdy4gIE90aGVy
d2lzZSwgaXQKK3Nob3VsZCBiZSBhbiBpbnRlZ2VyIHJlcHJlc2VudGluZyB0aGUgbWF4aW11bSBm
aWxlbmFtZSBsZW5ndGguIgorICA6dHlwZSAnKGNob2ljZSAoY29uc3QgICA6dGFnICJGdWxsIiBu
aWwpCisgICAgICAgICAgICAgICAgIChjb25zdCAgIDp0YWcgIldpbmRvdyIgd2luZG93KQorICAg
ICAgICAgICAgICAgICAoaW50ZWdlciA6dGFnICJJbnRlZ2VyIikpCisgIDpncm91cCAnZGlyZWQK
ICAgOnZlcnNpb24gIjMwLjEiKQogCiAMCkBAIC0xOTAzLDQ4ICsxOTE3LDYxIEBAIGRpcmVkLWlu
c2VydC1zZXQtcHJvcGVydGllcwogICAiQWRkIHZhcmlvdXMgdGV4dCBwcm9wZXJ0aWVzIHRvIHRo
ZSBsaW5lcyBpbiB0aGUgcmVnaW9uLCBmcm9tIEJFRyB0byBFTkQuIgogICAoc2F2ZS1leGN1cnNp
b24KICAgICAoZ290by1jaGFyIGJlZykKLSAgICAod2hpbGUgKDwgKHBvaW50KSBlbmQpCi0gICAg
ICAoaWdub3JlLWVycm9ycwotCShpZiAobm90IChkaXJlZC1tb3ZlLXRvLWZpbGVuYW1lKSkKLQkg
ICAgKHVubGVzcyAob3IgKGxvb2tpbmctYXQtcCAiXiQiKQotCQkJKGxvb2tpbmctYXQtcCBkaXJl
ZC1zdWJkaXItcmVnZXhwKSkKLQkgICAgICAocHV0LXRleHQtcHJvcGVydHkgKGxpbmUtYmVnaW5u
aW5nLXBvc2l0aW9uKQotCQkJCSAoMSsgKGxpbmUtZW5kLXBvc2l0aW9uKSkKLQkJCQkgJ2ludmlz
aWJsZSAnZGlyZWQtaGlkZS1kZXRhaWxzLWluZm9ybWF0aW9uKSkKLQkgIChzYXZlLWV4Y3Vyc2lv
bgotICAgICAgICAgICAgKGxldCAoKGVuZCAoMS0gKHBvaW50KSkpCi0gICAgICAgICAgICAgICAg
ICAob3BvaW50IChnb3RvLWNoYXIgKDErIChwb3MtYm9sKSkpKQotICAgICAgICAgICAgICAgICAg
KGkgMCkpCi0gICAgICAgICAgICAgIChwdXQtdGV4dC1wcm9wZXJ0eSBvcG9pbnQgZW5kICdpbnZp
c2libGUgJ2RpcmVkLWhpZGUtZGV0YWlscy1kZXRhaWwpCi0gICAgICAgICAgICAgICh3aGlsZSAo
cmUtc2VhcmNoLWZvcndhcmQgIlteIF0rIiBlbmQgdCkKLSAgICAgICAgICAgICAgICAod2hlbiAo
bWVtYmVyIChjbC1pbmNmIGkpIGRpcmVkLWhpZGUtZGV0YWlscy1wcmVzZXJ2ZWQtY29sdW1ucykK
LSAgICAgICAgICAgICAgICAgIChwdXQtdGV4dC1wcm9wZXJ0eSBvcG9pbnQgKHBvaW50KSAnaW52
aXNpYmxlIG5pbCkpCi0gICAgICAgICAgICAgICAgKHNldHEgb3BvaW50IChwb2ludCkpKSkpCi0g
ICAgICAgICAgKGxldCAoKGJlZyAocG9pbnQpKSAoZW5kIChzYXZlLWV4Y3Vyc2lvbgotCSAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgKGRpcmVkLW1vdmUtdG8tZW5kLW9mLWZpbGVuYW1lKQot
CSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKDEtIChwb2ludCkpKSkpCi0gICAgICAgICAg
ICAoaWYgZGlyZWQtY2xpY2stdG8tc2VsZWN0LW1vZGUKLSAgICAgICAgICAgICAgICAocHV0LXRl
eHQtcHJvcGVydHkgYmVnIGVuZCAna2V5bWFwCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIGRpcmVkLWNsaWNrLXRvLXNlbGVjdC1tYXApCi0gICAgICAgICAgICAgICh3aGVuIChh
bmQgZGlyZWQtbW91c2UtZHJhZy1maWxlcyAoZmJvdW5kcCAneC1iZWdpbi1kcmFnKSkKLSAgICAg
ICAgICAgICAgICAocHV0LXRleHQtcHJvcGVydHkgYmVnIGVuZCAna2V5bWFwCi0gICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIGRpcmVkLW1vdXNlLWRyYWctZmlsZXMtbWFwKSkpCi0J
ICAgIChhZGQtdGV4dC1wcm9wZXJ0aWVzCi0JICAgICBiZWcgKDErIGVuZCkKLQkgICAgIGAobW91
c2UtZmFjZQotCSAgICAgICBoaWdobGlnaHQKLQkgICAgICAgZGlyZWQtZmlsZW5hbWUgdAotCSAg
ICAgICBoZWxwLWVjaG8gLChpZiBkaXJlZC1jbGljay10by1zZWxlY3QtbW9kZQotICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIm1vdXNlLTI6IG1hcmsgb3IgdW5tYXJrIHRoaXMgZmlsZSIK
LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAoaWYgKGFuZCBkaXJlZC1tb3VzZS1kcmFnLWZp
bGVzCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGZib3VuZHAgJ3gtYmVn
aW4tZHJhZykpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJkb3duLW1vdXNlLTE6
IGRyYWcgdGhpcyBmaWxlIHRvIGFub3RoZXIgcHJvZ3JhbQorICAgIChsZXQgKChlbGwtbGVuIChk
aXJlZC0tZ2V0LWVsbGlwc2lzLWxlbmd0aCkpIG1heGxlbiBmaWxlbmFtZS1jb2wpCisgICAgICAo
d2hpbGUgKDwgKHBvaW50KSBlbmQpCisgICAgICAgIChpZ25vcmUtZXJyb3JzCisJICAoaWYgKG5v
dCAoZGlyZWQtbW92ZS10by1maWxlbmFtZSkpCisJICAgICAgKHVubGVzcyAob3IgKGxvb2tpbmct
YXQtcCAiXiQiKQorCQkJICAobG9va2luZy1hdC1wIGRpcmVkLXN1YmRpci1yZWdleHApKQorCSAg
ICAgICAgKHB1dC10ZXh0LXByb3BlcnR5IChsaW5lLWJlZ2lubmluZy1wb3NpdGlvbikKKwkJCQkg
ICAoMSsgKGxpbmUtZW5kLXBvc2l0aW9uKSkKKwkJCQkgICAnaW52aXNpYmxlICdkaXJlZC1oaWRl
LWRldGFpbHMtaW5mb3JtYXRpb24pKQorCSAgICAoc2F2ZS1leGN1cnNpb24KKyAgICAgICAgICAg
ICAgKGxldCAoKGVuZCAoMS0gKHBvaW50KSkpCisgICAgICAgICAgICAgICAgICAgIChvcG9pbnQg
KGdvdG8tY2hhciAoMSsgKHBvcy1ib2wpKSkpCisgICAgICAgICAgICAgICAgICAgIChpIDApKQor
ICAgICAgICAgICAgICAgIChwdXQtdGV4dC1wcm9wZXJ0eSBvcG9pbnQgZW5kICdpbnZpc2libGUg
J2RpcmVkLWhpZGUtZGV0YWlscy1kZXRhaWwpCisgICAgICAgICAgICAgICAgKHdoaWxlIChyZS1z
ZWFyY2gtZm9yd2FyZCAiW14gXSsiIGVuZCB0KQorICAgICAgICAgICAgICAgICAgKHdoZW4gKG1l
bWJlciAoY2wtaW5jZiBpKSBkaXJlZC1oaWRlLWRldGFpbHMtcHJlc2VydmVkLWNvbHVtbnMpCisg
ICAgICAgICAgICAgICAgICAgIChwdXQtdGV4dC1wcm9wZXJ0eSBvcG9pbnQgKHBvaW50KSAnaW52
aXNpYmxlIG5pbCkpCisgICAgICAgICAgICAgICAgICAoc2V0cSBvcG9pbnQgKHBvaW50KSkpKSkK
KyAgICAgICAgICAgIChsZXQgKChiZWcgKHBvaW50KSkgKGVuZCAoc2F2ZS1leGN1cnNpb24KKwkg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGRpcmVkLW1vdmUtdG8tZW5kLW9mLWZpbGVu
YW1lKQorCSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoMS0gKHBvaW50KSkpKSkKKyAg
ICAgICAgICAgICAgKGlmIGRpcmVkLWNsaWNrLXRvLXNlbGVjdC1tb2RlCisgICAgICAgICAgICAg
ICAgICAocHV0LXRleHQtcHJvcGVydHkgYmVnIGVuZCAna2V5bWFwCisgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgZGlyZWQtY2xpY2stdG8tc2VsZWN0LW1hcCkKKyAgICAgICAg
ICAgICAgICAod2hlbiAoYW5kIGRpcmVkLW1vdXNlLWRyYWctZmlsZXMgKGZib3VuZHAgJ3gtYmVn
aW4tZHJhZykpCisgICAgICAgICAgICAgICAgICAocHV0LXRleHQtcHJvcGVydHkgYmVnIGVuZCAn
a2V5bWFwCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZGlyZWQtbW91c2Ut
ZHJhZy1maWxlcy1tYXApKSkKKyAgICAgICAgICAgICAgKHdoZW4gZGlyZWQtZmlsZW5hbWUtZGlz
cGxheS1sZW5ndGgKKyAgICAgICAgICAgICAgICAobGV0ICgobGVuIChzdHJpbmctd2lkdGggKGJ1
ZmZlci1zdWJzdHJpbmcgYmVnICgxKyBlbmQpKSkpCisgICAgICAgICAgICAgICAgICAgICAgZWxs
LWJlZykKKyAgICAgICAgICAgICAgICAgIChvciBtYXhsZW4gKHNldHEgbWF4bGVuIChkaXJlZC0t
Z2V0LWZpbGVuYW1lLWRpc3BsYXktbGVuZ3RoKSkpCisgICAgICAgICAgICAgICAgICAod2hlbiAo
YW5kIChpbnRlZ2VycCBtYXhsZW4pICg+IGxlbiBtYXhsZW4gKCsgZWxsLWxlbiAyKSkpCisgICAg
ICAgICAgICAgICAgICAgIChvciBmaWxlbmFtZS1jb2wgKHNldHEgZmlsZW5hbWUtY29sIChjdXJy
ZW50LWNvbHVtbikpKQorICAgICAgICAgICAgICAgICAgICAobW92ZS10by1jb2x1bW4gKCsgZmls
ZW5hbWUtY29sICgvIG1heGxlbiAyKSkpCisgICAgICAgICAgICAgICAgICAgIChzZXRxIGVsbC1i
ZWcgKHBvaW50KSkKKyAgICAgICAgICAgICAgICAgICAgKG1vdmUtdG8tY29sdW1uICgrIGZpbGVu
YW1lLWNvbCAoLyBtYXhsZW4gMikKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICgtIGxlbiBtYXhsZW4pIGVsbC1sZW4pKQorICAgICAgICAgICAgICAgICAgICAocHV0LXRl
eHQtcHJvcGVydHkKKyAgICAgICAgICAgICAgICAgICAgIGVsbC1iZWcgKHBvaW50KSAnaW52aXNp
YmxlICdkaXJlZC1maWxlbmFtZS1oaWRlKSkpKQorCSAgICAgIChhZGQtdGV4dC1wcm9wZXJ0aWVz
CisJICAgICAgIGJlZyAoMSsgZW5kKQorCSAgICAgICBgKG1vdXNlLWZhY2UKKwkgICAgICAgICBo
aWdobGlnaHQKKwkgICAgICAgICBkaXJlZC1maWxlbmFtZSB0CisJICAgICAgICAgaGVscC1lY2hv
ICwoaWYgZGlyZWQtY2xpY2stdG8tc2VsZWN0LW1vZGUKKyAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIm1vdXNlLTI6IG1hcmsgb3IgdW5tYXJrIHRoaXMgZmlsZSIKKyAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIChpZiAoYW5kIGRpcmVkLW1vdXNlLWRyYWctZmlsZXMKKyAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChmYm91bmRwICd4LWJlZ2luLWRyYWcp
KQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJkb3duLW1vdXNlLTE6IGRyYWcg
dGhpcyBmaWxlIHRvIGFub3RoZXIgcHJvZ3JhbQogbW91c2UtMjogdmlzaXQgdGhpcyBmaWxlIGlu
IG90aGVyIHdpbmRvdyIKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJtb3VzZS0yOiB2
aXNpdCB0aGlzIGZpbGUgaW4gb3RoZXIgd2luZG93IikpKSkKLQkgICAgKHdoZW4gKDwgKCsgZW5k
IDUpIChsaW5lLWVuZC1wb3NpdGlvbikpCi0JICAgICAgKHB1dC10ZXh0LXByb3BlcnR5ICgrIGVu
ZCA1KSAobGluZS1lbmQtcG9zaXRpb24pCi0JCQkgICAgICAgICAnaW52aXNpYmxlICdkaXJlZC1o
aWRlLWRldGFpbHMtbGluaykpKSkpCi0gICAgICAoZm9yd2FyZC1saW5lIDEpKSkpCisgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICJtb3VzZS0yOiB2aXNpdCB0aGlzIGZpbGUgaW4gb3Ro
ZXIgd2luZG93IikpKSkKKwkgICAgICAod2hlbiAoPCAoKyBlbmQgNSkgKGxpbmUtZW5kLXBvc2l0
aW9uKSkKKwkgICAgICAgIChwdXQtdGV4dC1wcm9wZXJ0eSAoKyBlbmQgNSkgKGxpbmUtZW5kLXBv
c2l0aW9uKQorCQkJICAgICAgICAgICAnaW52aXNpYmxlICdkaXJlZC1oaWRlLWRldGFpbHMtbGlu
aykpKSkpCisgICAgICAgIChmb3J3YXJkLWxpbmUgMSkpKSkpCiAKIChkZWZ1biBkaXJlZC0tbWFr
ZS1kaXJlY3RvcnktY2xpY2thYmxlICgpCiAgIChzYXZlLWV4Y3Vyc2lvbgpAQCAtMTk3Niw2ICsy
MDAzLDIwIEBAIGRpcmVkLS1tYWtlLWRpcmVjdG9yeS1jbGlja2FibGUKICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIlJFVCIgY2xpY2spKSkpCiAgICAgICAgICAgKHNldHEgc2VnbWVudC1zdGFy
dCAocG9pbnQpKSkpKSkpCiAKKyhkZWZ1biBkaXJlZC0tZ2V0LWVsbGlwc2lzLWxlbmd0aCAoKQor
ICAiUmV0dXJuIGxlbmd0aCBvZiBlbGxpcHNpcy4iCisgIChsZXQqICgoZHQgKG9yICh3aW5kb3ct
ZGlzcGxheS10YWJsZSkKKyAgICAgICAgICAgICAgICAgYnVmZmVyLWRpc3BsYXktdGFibGUKKyAg
ICAgICAgICAgICAgICAgc3RhbmRhcmQtZGlzcGxheS10YWJsZSkpCisgICAgICAgICAoZ2x5cGhz
IChhbmQgZHQgKGRpc3BsYXktdGFibGUtc2xvdCBkdCAnc2VsZWN0aXZlLWRpc3BsYXkpKSkpCisg
ICAgKGlmIGdseXBocyAobGVuZ3RoIGdseXBocykgKGV2YWwtd2hlbi1jb21waWxlIChsZW5ndGgg
Ii4uLiIpKSkpKQorCisoZGVmdW4gZGlyZWQtLWdldC1maWxlbmFtZS1kaXNwbGF5LWxlbmd0aCAo
KQorICAiUmV0dXJuIG1heGltdW0gZGlzcGxheSBsZW5ndGggb2YgZmlsZW5hbWUuIgorICAoaWYg
KGludGVnZXJwIGRpcmVkLWZpbGVuYW1lLWRpc3BsYXktbGVuZ3RoKQorICAgICAgZGlyZWQtZmls
ZW5hbWUtZGlzcGxheS1sZW5ndGgKKyAgICAoLSAod2luZG93LW1heC1jaGFycy1wZXItbGluZSkg
MSAoY3VycmVudC1jb2x1bW4pKSkpCisKIAwKIDs7OyBSZXZlcnRpbmcgYSBkaXJlZCBidWZmZXIK
IApAQCAtMjYxNyw2ICsyNjU4LDcgQEAgZGlyZWQtbW9kZQogCW1vZGUtbGluZS1idWZmZXItaWRl
bnRpZmljYXRpb24KIAkocHJvcGVydGl6ZWQtYnVmZmVyLWlkZW50aWZpY2F0aW9uICIlMTdiIikp
CiAgIChhZGQtdG8taW52aXNpYmlsaXR5LXNwZWMgJyhkaXJlZCAuIHQpKQorICAoZGlyZWQtZmls
ZW5hbWUtdXBkYXRlLWludmlzaWJpbGl0eS1zcGVjKQogICA7OyBJZ25vcmUgZGlyZWQtaGlkZS1k
ZXRhaWxzLSogdmFsdWUgb2YgaW52aXNpYmxlIHRleHQgcHJvcGVydHkgYnkgZGVmYXVsdC4KICAg
KHdoZW4gKGVxIGJ1ZmZlci1pbnZpc2liaWxpdHktc3BlYyB0KQogICAgIChzZXRxIGJ1ZmZlci1p
bnZpc2liaWxpdHktc3BlYyAobGlzdCB0KSkpCkBAIC0zMTA2LDYgKzMxNDgsMTIgQEAgZGlyZWQt
aGlkZS1kZXRhaWxzLXVwZGF0ZS1pbnZpc2liaWxpdHktc3BlYwogDAogOzs7IEZ1bmN0aW9ucyB0
byBoaWRlL3VuaGlkZSB0ZXh0CiAKKyhkZWZ1biBkaXJlZC1maWxlbmFtZS11cGRhdGUtaW52aXNp
YmlsaXR5LXNwZWMgKCkKKyAgKGZ1bmNhbGwgKGlmIChkZXJpdmVkLW1vZGUtcCAnZGlyZWQtbW9k
ZSkKKyAgICAgICAgICAgICAgICdhZGQtdG8taW52aXNpYmlsaXR5LXNwZWMKKyAgICAgICAgICAg
ICAncmVtb3ZlLWZyb20taW52aXNpYmlsaXR5LXNwZWMpCisgICAgICAgICAgICcoZGlyZWQtZmls
ZW5hbWUtaGlkZSAuIHQpKSkKKwogKGRlZnVuIGRpcmVkLS1maW5kLWhpZGRlbi1wb3MgKHN0YXJ0
IGVuZCkKICAgKHRleHQtcHJvcGVydHktYW55IHN0YXJ0IGVuZCAnaW52aXNpYmxlICdkaXJlZCkp
CiAKZGlmZiAtLWdpdCBhL2xpc3Avd2RpcmVkLmVsIGIvbGlzcC93ZGlyZWQuZWwKaW5kZXggMDc5
ZDkzZDYwMTEuLjVkNTBhNTc0MjkwIDEwMDY0NAotLS0gYS9saXNwL3dkaXJlZC5lbAorKysgYi9s
aXNwL3dkaXJlZC5lbApAQCAtMjYxLDYgKzI2MSw3IEBAIHdkaXJlZC1jaGFuZ2UtdG8td2RpcmVk
LW1vZGUKICAgKGFkZC1mdW5jdGlvbiA6b3ZlcnJpZGUgKGxvY2FsICdyZXZlcnQtYnVmZmVyLWZ1
bmN0aW9uKSAjJ3dkaXJlZC1yZXZlcnQpCiAgIChzZXQtYnVmZmVyLW1vZGlmaWVkLXAgbmlsKQog
ICAoc2V0cSBidWZmZXItdW5kby1saXN0IG5pbCkKKyAgKGRpcmVkLWZpbGVuYW1lLXVwZGF0ZS1p
bnZpc2liaWxpdHktc3BlYykKICAgKHJ1bi1tb2RlLWhvb2tzICd3ZGlyZWQtbW9kZS1ob29rKQog
ICAobWVzc2FnZSAiJXMiIChzdWJzdGl0dXRlLWNvbW1hbmQta2V5cwogCQkgIlByZXNzIFxcW3dk
aXJlZC1maW5pc2gtZWRpdF0gd2hlbiBmaW5pc2hlZCBcCkBAIC00NTYsNiArNDU3LDcgQEAgd2Rp
cmVkLWNoYW5nZS10by1kaXJlZC1tb2RlCiAgIChkaXJlZC1zb3J0LXNldC1tb2RlLWxpbmUpCiAg
IChkaXJlZC1hZHZlcnRpc2UpCiAgIChkaXJlZC1oaWRlLWRldGFpbHMtdXBkYXRlLWludmlzaWJp
bGl0eS1zcGVjKQorICAoZGlyZWQtZmlsZW5hbWUtdXBkYXRlLWludmlzaWJpbGl0eS1zcGVjKQog
ICAocmVtb3ZlLWhvb2sgJ2tpbGwtYnVmZmVyLWhvb2sgIyd3ZGlyZWQtY2hlY2sta2lsbC1idWZm
ZXIgdCkKICAgKHJlbW92ZS1ob29rICdiZWZvcmUtY2hhbmdlLWZ1bmN0aW9ucyAjJ3dkaXJlZC0t
YmVmb3JlLWNoYW5nZS1mbiB0KQogICAocmVtb3ZlLWhvb2sgJ2FmdGVyLWNoYW5nZS1mdW5jdGlv
bnMgIyd3ZGlyZWQtLXJlc3RvcmUtcHJvcGVydGllcyB0KQotLSAKMi4yNS4xCgo=
--0000000000003a040d060a422fb5--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67161; Package emacs. Full text available.

Message received at 67161 <at> debbugs.gnu.org:


Received: (at 67161) by debbugs.gnu.org; 16 Nov 2023 03:44:28 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Nov 15 22:44:28 2023
Received: from localhost ([127.0.0.1]:54264 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r3TIq-0003kX-GY
	for submit <at> debbugs.gnu.org; Wed, 15 Nov 2023 22:44:28 -0500
Received: from mail-vs1-xe36.google.com ([2607:f8b0:4864:20::e36]:53689)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <liuhui1610@HIDDEN>) id 1r3TIk-0003kD-S0
 for 67161 <at> debbugs.gnu.org; Wed, 15 Nov 2023 22:44:26 -0500
Received: by mail-vs1-xe36.google.com with SMTP id
 ada2fe7eead31-45d8c405696so131559137.3
 for <67161 <at> debbugs.gnu.org>; Wed, 15 Nov 2023 19:44:23 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1700106257; x=1700711057; darn=debbugs.gnu.org;
 h=content-transfer-encoding:cc:to:subject:message-id:date:from
 :in-reply-to:references:mime-version:from:to:cc:subject:date
 :message-id:reply-to;
 bh=Kpeiq1okTlWzi7eZ0pejZxet6PslHH6abzOcuLtoTRY=;
 b=XLj1YSYlkDRabSWrQw9rtMbf+NLyVb/KSgDm2tEPlXQjC6tPd/jNqX/Lh99M4EczjK
 o0M6PSYQYjCOAjgAt4I0ALBiHNLD0TrEaF+X4lwI0FLHzDOAjNOQEucr68yA50GK3ZzK
 5f83jy4S2pw6igzUiMweHEkxiALzUi8uiV7Q4WDIPRI4KMgzUkIozXfhFHipC35Q8X2x
 qQq93Rao4e46THarA+LeAIQlZGTz+1TiX122+H1B7D7yRgUoWyPlRGWCB58zzC/jP0cA
 xvYp8lArgijqTwRkj36WN3VGoEbzoiL9liMaRllhU549XYr/w482tnagyiLfTyyOSMKO
 UQUg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1700106257; x=1700711057;
 h=content-transfer-encoding:cc:to:subject:message-id:date:from
 :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=Kpeiq1okTlWzi7eZ0pejZxet6PslHH6abzOcuLtoTRY=;
 b=tUz9PThsS3mv3meB9CeNCo+PRUX+If+z5kMrytJBlVV28u0Yl+Uz77/bIz2Ym5ACi0
 tkkXzGQ7VcrNWdkwQYhmozoiWZY3hd5ztamRnFKjJc+0LmK/Ozhk22ybamG4fxnfqLCW
 Z5lldebljbBMdG4DUzMMEscsNAT08g2+38jt6hdiiawHF+4QPLbD/fFqXf4FyQGu4ie4
 gJFxmLueT4fxQGBr0Kp7z9ma13hVK1JFokJncQN7JZn76ULGBn0VgsVBvoYKNyywGXyT
 ++HzfRfSZW6ZJg8e18bZDY/1myepD1QNuGt9ZJd65kLXS23dQHzm17MPnw7kKsuIL89D
 88vA==
X-Gm-Message-State: AOJu0YyXmKZWM2N6fybBp7Z6Q7eZHxbTBk3adrARTHImAO/6AP5s9Adr
 ty3Jzt4HrX0sYSE33VQ449zT5s4nJDLZEJLuUaw=
X-Google-Smtp-Source: AGHT+IE8d02S3A0TXEWyWxBx9Vft0t5LAW4HS9oFsrbI7gZBLcNib6ZdyGTXpgOlps1zZ5S+hcngTsFom//EixlzpWU=
X-Received: by 2002:a05:6102:1625:b0:45f:654a:f3b with SMTP id
 cu37-20020a056102162500b0045f654a0f3bmr18568655vsb.19.1700106257583; Wed, 15
 Nov 2023 19:44:17 -0800 (PST)
MIME-Version: 1.0
References: <CAOQTW-MSpBK4ACpLk8U2m6HJx8HXw21O0kyYZ-i85ETNjyOUcA@HIDDEN>
 <jwv5y236n1p.fsf-monnier+emacs@HIDDEN>
In-Reply-To: <jwv5y236n1p.fsf-monnier+emacs@HIDDEN>
From: Liu Hui <liuhui1610@HIDDEN>
Date: Thu, 16 Nov 2023 11:44:06 +0800
Message-ID: <CAOQTW-M+DLefR38qnoNe+BnqX2qwzbq_Ac_6p81dem+eF=xBJA@HIDDEN>
Subject: Re: bug#67161: 30.0.50;
 [PATCH] Add option `dired-filename-display-length'
To: Stefan Monnier <monnier@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.2 (/)
X-Debbugs-Envelope-To: 67161
Cc: 67161 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.8 (/)

Stefan Monnier <monnier@HIDDEN> =E4=BA=8E2023=E5=B9=B411=E6=9C=88=
15=E6=97=A5=E5=91=A8=E4=B8=89 23:57=E5=86=99=E9=81=93=EF=BC=9A

> I think it's good that you use `invisible`, tho, specifically since it
> then uses whichever ellipsis the user has chosen via the display-table.
> The downside is that most users don't know how to change it and there's
> no convenient facility to access it.  You probably need something like
>
>     (defun length-of-standard-ellipsis ()
>       (let ((glyphs
>              (and standard-display-table
>                   (display-table-slot standard-display-table
>                                       'selective-display))))
>         (if glyphs (length glyphs) (eval-when-compile (length "...")))))

Thanks very much for pointing out the problem! Your suggestion is
valuable, and I will update the patch later.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67161; Package emacs. Full text available.

Message received at 67161 <at> debbugs.gnu.org:


Received: (at 67161) by debbugs.gnu.org; 15 Nov 2023 18:06:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Nov 15 13:06:48 2023
Received: from localhost ([127.0.0.1]:53746 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r3KHo-0004r9-6p
	for submit <at> debbugs.gnu.org; Wed, 15 Nov 2023 13:06:48 -0500
Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:31166)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <drew.adams@HIDDEN>) id 1r3KHl-0004qz-Am
 for 67161 <at> debbugs.gnu.org; Wed, 15 Nov 2023 13:06:46 -0500
Received: from pps.filterd (m0333520.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id
 3AFI3iDS008925; Wed, 15 Nov 2023 18:06:45 GMT
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com;
 h=from : to : cc :
 subject : date : message-id : references : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2023-03-30;
 bh=n2weKu90OKQHVqXz2R0ZAx/r8GDRUGZITZQk3JcvwBk=;
 b=ShO1owNGQNo3t/JDi2Ezcd0meHHlbILDIcv53N4jet+pPOErv5AY6Wb6eenjEJs66m2/
 dT2/6DYJ3yGjBCU7YwZN5Ftyn+Ef0tO+N1WGDIADjCmLBUi1ynn4bYWg1UA84dYT9LvC
 jkObpeTHflje37z5l65sIRgTdObt10D5ZIzb3Dz8R1sUThennT4g3jNucgrTj5205YWC
 0YTxTS3MAStAQl5FJoaIwA4wforaGMpxrFS1+Gd/FElkGvAi4ZsWh+zl9zlD0bUCGqtK
 EDiN5iDz0rvFXYEKtdpVmuif+Ele9QpdsqNVGNvmLmva9iUpDbIkvP16VRzb1ErOkOY9 gw== 
Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com
 (phxpaimrmta02.appoci.oracle.com [147.154.114.232])
 by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3ua2mdsdkf-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Wed, 15 Nov 2023 18:06:45 +0000
Received: from pps.filterd
 (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1])
 by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19)
 with ESMTP id 3AFHZkLL008956; Wed, 15 Nov 2023 18:06:44 GMT
Received: from nam11-co1-obe.outbound.protection.outlook.com
 (mail-co1nam11lp2168.outbound.protection.outlook.com [104.47.56.168])
 by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id
 3uaxpy9ceh-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Wed, 15 Nov 2023 18:06:44 +0000
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=exJm5aNxutogwZFV53dDVCCvclnvPwS2yJ/yfPRAi4Nea4XlBOJFxpqBYvAtp9dALUwbVCGFg85nHYmqMhSvjO/x3DU2mXKQjd3YT8xKtpCzX57aEAZGm78Ct0zD2WsiNxSosGS/X0MXdiY+Eoj8Eek3DORLHl8FlNMg1EA+hVx7AVt3oHewwxhJMb86iJc2/goKLSRaNS6qXjK/iqmNmQBhKFgg03kFPiKObqoec22cNSwCMgbkUyZWYkLVcZkKkNLRj418R7eop5H+BXqBZ77/7+1jk9hOtWcKWo28/yISf8coVcC/XySpI5znmX/NtdOLWWoFDW6fXvIdO1qSBQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=n2weKu90OKQHVqXz2R0ZAx/r8GDRUGZITZQk3JcvwBk=;
 b=dl8I9N97hzUD0wP0GVgna5ZCl0G1Ro+JASBUIQ2R2+yimY1YWP/NOJnrmDmwupX8LYM2uG4kV7lQl9Dh6qBg+OrFRwFb1pkNlpnjECWjwfmtlQ/nPvThvh+n6E8YCD/2sy8GcUk1fu/uhdimjRtoTNNZaYJTgDNuchxs12aQVvcMWuY1KDoAFPOHCpjkU5EHVicoF9roQaLLErFNJgaa+R0EVSmEPwA2gLNEpz9CMFbRE7D7XA/Qxways+XU0+T/0y2+3fRbWjZCp7jKu8Np9MPz1iF2oSpUcs9H+0WrqA3QAPDz007Wg5LwrcnrR1UNsDaoFZ/TL4FAoh7GLTUzKQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=n2weKu90OKQHVqXz2R0ZAx/r8GDRUGZITZQk3JcvwBk=;
 b=WtbhRbHm80w814Soe3LaMBL8Cbz09LNMTe2HlMs9jCze0nJSXwf9oD5nOBstQbifke+n7EAjo8ZtF6scsKLOvqQLy+HSJen5TdHTyuVcyJwcx06OfP+wL3idoQCEaQUxLknmH2zALd7LGvf7ybCL6wb68UJ+p6guY50jPj8je0s=
Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19)
 by PH0PR10MB4792.namprd10.prod.outlook.com (2603:10b6:510:3d::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.17; Wed, 15 Nov
 2023 18:06:42 +0000
Received: from SJ0PR10MB5488.namprd10.prod.outlook.com
 ([fe80::3b4c:a669:c229:47b4]) by SJ0PR10MB5488.namprd10.prod.outlook.com
 ([fe80::3b4c:a669:c229:47b4%6]) with mapi id 15.20.6977.029; Wed, 15 Nov 2023
 18:06:42 +0000
From: Drew Adams <drew.adams@HIDDEN>
To: Liu Hui <liuhui1610@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>
Subject: RE: [External] : bug#67161: 30.0.50; [PATCH] Add option
 `dired-filename-display-length'
Thread-Topic: [External] : bug#67161: 30.0.50; [PATCH] Add option
 `dired-filename-display-length'
Thread-Index: AQHaF9jQk39gd0xBPkujM7S98kfcTrB7qCSQ
Date: Wed, 15 Nov 2023 18:06:42 +0000
Message-ID: <SJ0PR10MB5488DE08DD9A9C4DC4A0EDCDF3B1A@HIDDEN>
References: <CAOQTW-MSpBK4ACpLk8U2m6HJx8HXw21O0kyYZ-i85ETNjyOUcA@HIDDEN>
 <8334x8tqi9.fsf@HIDDEN>
 <CAOQTW-P4+vs+JH8BTL8fL-d1QJXOdYq3i+3O7tALTDs=qHpnzA@HIDDEN>
In-Reply-To: <CAOQTW-P4+vs+JH8BTL8fL-d1QJXOdYq3i+3O7tALTDs=qHpnzA@HIDDEN>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: SJ0PR10MB5488:EE_|PH0PR10MB4792:EE_
x-ms-office365-filtering-correlation-id: 3ffecf77-6ece-440d-d2ab-08dbe6059f08
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: nqGAnALcg/1ZsmWEmIHYLSSaz/W8j90P04mwRqlPStL38PC1gLiDum6n7U20k1vwMi+x9PsMK6kEXE1Eu1FgSrM/MCjVWbENH42WMZ/0A+Kym87oc6lkRSxkvKywIAbPVw7XluNm2Np21O5mSK3/4/DzZwqhIAcy2vrV4uhETNGrsyM6xIiiEIR0yS3CrKTm3uOoVCOs6Z8440LRSboPY0Y5bannoOF6744+CH8F6cOOttrFIPxgR6zig/Nq3kmuOX38V5G/wWIzx4PlylWkArInM1I8cd4avFP2sTNhpbUZT9dXADC6u4i59OmiBuE9wK5kLX6vj5z07kQTYgfMIieQUI/sp4vvVjC6qGqKfHYmBFHmMcYsaR0RQjAAZCSqJ5zc/k0AIJdP7bGOM5trukXIWBcVzq98vJZJN2n4Fy4btGaAhU4CESoGAAcTrXDDZqA0F5eR9jb7EPQNhd+Tw8FQOnBY1OEPg9wF5Q5eqgZdZPGmDJidpB1RvmvQyhdE5ulbbGmOqbo7i5HYgURzFTnaSNBXKEyVZlL2CRnHERRoyKF5W/CLVsvnxqk2OPn4InmK+ucXiEaVNQ0eraHdjJ4fkTArGzovFc1Ff/LNUQrO08z2+2x/2JAu3EtenyXW2viyZKzMTxgy/WmVFCUIkw==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(13230031)(39860400002)(136003)(346002)(396003)(376002)(366004)(230922051799003)(186009)(64100799003)(1800799009)(451199024)(9686003)(4326008)(26005)(38070700009)(478600001)(52536014)(44832011)(33656002)(41300700001)(86362001)(2906002)(5660300002)(66476007)(8936002)(64756008)(66556008)(66946007)(66446008)(76116006)(8676002)(316002)(110136005)(71200400001)(7696005)(6506007)(55016003)(122000001)(83380400001)(38100700002)(81973001);
 DIR:OUT; SFP:1101; 
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RlBVbEQ0bnRvb1puVFZqd2Y3VG1HZXV1TFFnR0V4a3Nwckc1Vmp0cDhvYTJv?=
 =?utf-8?B?bXZkVGpIcG9IU0JHMndrU1NSd2pRSU9IMk0vTGxEQ3V4RWZ3cElFWGpTRXpF?=
 =?utf-8?B?Ri96dlJGWVY0Wm9rbjBsbmlaL3UvODhEbjgrVzJ0VDBkeXBzRW9tR3FuTXRF?=
 =?utf-8?B?ZGRsTEo4c1R6dlQ3ZXZwVlZVUmZ1d2Y5T3ZoaWFLZ2l2OVlGSHZ5MW5rZllZ?=
 =?utf-8?B?c0tEYXY4U0pHWFVrK1JrYndDMUR1VWQwYmtnL28rUS94bHcrbUY0b080SXF1?=
 =?utf-8?B?OVRRY205aU84MTdRejk1dm1SaGdJRzJkUXhXWEVudlVMZ3Z1OFBPWitvbDNj?=
 =?utf-8?B?U01BT2ZjTm9KNndOUXdSaENzOVB6ODZndStXRDNTblZhSUhIMHQzbG45bTJq?=
 =?utf-8?B?ODJ4Q2xtelVVeTQvZ2RPazhlUk1zbVk5MzVCc0NFczZlMXdiSDBHdnFsYWRj?=
 =?utf-8?B?NDY5N1RFaDdzMXBTang3Tng4NWRkdHkxeUdoczlnT3NqOUJPa3RidjM2MW1s?=
 =?utf-8?B?NUdobEt4ajRNUTlhWW54aWtVbVZrcWdhbzY4UEFKZEhFc2RwL1ZMbm8xTVNF?=
 =?utf-8?B?RWlMM20vQlh3cDhLRlBrTmN5bWZzNTlBYXN5d0lURUtvamp5dVdQUXQweVp6?=
 =?utf-8?B?amUyTUFZY3hTcVVucW90bUV6Z3pLQXBla1ladmFVZHJ1Y1lvWXQrcVB3R29o?=
 =?utf-8?B?SjNmNnpFaWVoN29zU1FrQnRzbE94SmdUVE5vRWVvMjd5S0xRVHRwVW1vc01y?=
 =?utf-8?B?TVZiMXNzUGRwTnZaOVQ2Q3BLK0x0YlQ0ZGNtMHlwOFN5YWxNZGtPbG00dGUr?=
 =?utf-8?B?aHZLSkF4WjM3MjQyUVlZN0FLc1VabHdaYUhUemk0RkVFblZPMmk1MHlsaytl?=
 =?utf-8?B?QkdVNis3VFpGZ0FRUk1JYnJ2RmhjZzhxWXk0ZzQzR1YvK3NFcHd0LzU1dFM4?=
 =?utf-8?B?WVZheldZMTVmbi9HRmxGWTNoWk1IOTlsM3YxaTVjcXhBWXMvYnJtcGFneDVu?=
 =?utf-8?B?NWtHV0xKTmREUC9sRGkxZnZYNEdXNnFoTzNPcE51RDE3L1c2SlorY2IwZWpj?=
 =?utf-8?B?cDNlNEpndDNhN3JZd2s3aXZObklNVndPcCsvUVZ0SUdRWmxtb2kyOHVaSTNz?=
 =?utf-8?B?SkFyQUJPYkY5SmhSK1NrQ09oZ0hjNmw5QkQ3c1VzdnRzdXcvaEE1TkROcnJp?=
 =?utf-8?B?ZklPMENTWXN4eHU5U3JSUU81TWUzZUV1ckRIZGhCRG96QkVwd2g1NlFYS013?=
 =?utf-8?B?UTRhZ0NLaUlSc1pDL3dOcFE5cmFrd3haeFNtMDg3Ti9lNVpCOWkrRVcxT2hm?=
 =?utf-8?B?YzMzbVZSOXF3STUzRlovV1NWNWxDRTJFeE1GSS84bzFHbEVSQmozQ2VmSHNL?=
 =?utf-8?B?RVFYOVZsYXRlYjZIaS96cE9WcE5wdEQxV1FROWozeUtYWXluZzRXZDc3bTNs?=
 =?utf-8?B?bFM2UmFsTWtCcmN3M3BFL3FKQ2FGTkh1aDR2d2NDR3FXaitWZ1ZBcXJQQlRo?=
 =?utf-8?B?c1ZsQy8rOGxqNlFJMEhsSDhyWnhabVdaQ2VHYVEzQTBpUUhBcHR2TXBXZHNY?=
 =?utf-8?B?RmtWYUxvN1NrWnJIUE9UaFZ5N0ViYVVob0RRSXN1ZVhXcTBFVnlVVW1iL3Fx?=
 =?utf-8?B?MjlUd0FuTU1pZlUzT2JFVk84anBKdkdQUU5MaGFIU01VQVZYak1XS1M5ZHZ3?=
 =?utf-8?B?Y0lVZ2MrRVVJRmpVUy9iWGxFTm1mR3B5dG5iV01ndE14QVZnZmtobmFONStJ?=
 =?utf-8?B?SVN3N2NMaWs5NW9jK1BYRVcyd09PdTNZUmdpMUgxSXJPZzloVm5hS2xtL1Fx?=
 =?utf-8?B?bzFNTmFmWkl1NDQvb20zejdnSG0zaEJaNlQ0eHZWcTZsRXlSU1FDNUEvRlk2?=
 =?utf-8?B?Wm0xVGFOZGVZRjdrWTFJYTlTcU5tZWZuNCtWeTg5clI5aVR1U1J0am01SDlE?=
 =?utf-8?B?K0lUbmIrYjN0WmtTd2lhQ1RRKy9SeExSQVJtdjVKU3lPQzN6OEtLeUxMdGFh?=
 =?utf-8?B?TnJiaWQxYWxYUGhQbVk5a3hQN1hEU0Zkdlh4dWZINUNhcHNCUnpUQkx2TCtO?=
 =?utf-8?B?THhBZ3pOWXV6dnlpbC9xbUhHWTlkb3RDSjQ2S25pSml6Z25CYkZpYXRTSTdr?=
 =?utf-8?Q?df6/s0K8G1bqeh29nUvKiOAJr?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: SN0wW7IiCaM7sv5URj5KJCciNi3IoGqiFmNYo9gvXE0+APujLhNLuNAxE34UTw7rIcfbAkq7yRqT7IJNkatNlK6uHiD+thrPcJIJKBdYKxtzs0bIwwlT/yu5dO5d9lQ7iVhvUJTbovLVizFqzxrEdh9+D8wX5t3qHe6uPtLTyRMwR11mwg5jj21iBCJTY97vRK/+qQD/IlJnitWqcoWZc/STu1QY8Wk2vwY3L7sjA2ICxDPdqY4t2icgIWhm6cuIolBiiGVu8TyyVt4Hm3uIVwiNeUSERNSzrjFcPR1JM+P3vvOsiLMUrbYT1SeSOASF8va3210dDsYMpA2K/KYyr6adNV4SZ022HpF79uVGxet4F9qP9tNbAD9xQ99AcGdUImLmt36DsPlePZUyWMkb/jg92BP0u0bALgU4ZuOyWHZ5k6+QzKtSbceBI7F5eI9ynYwIbiGccqWqduOSe1eeodfGlsCkNUqTGmcZP8DMEn01lNEKISxhZfi6ts4bExNL+rI3Zh+QJ7o836X12q9RdDJw2piGX2B6JECtWMaIuLiEMVhiYiHU2j3FAoM25+Mhpez6ivtHmVNwTLAmYgGshybUq+vd+rsfpahgEbhNP66O3LifJ4JUs8RNEdNWrKC1nDevmxQRLAmxw5ERqH7CX19YgKPMnGIaEV3uSItPu2tCLreTo8C0PvPwK0P8xBYQN2d6wNmn8y3ZjJGbDuKsg6yEPYt/UzniJgoAKCaEjxGlu89SlO55Fs/z2qKz0oSPC+GHvuMyVToPWt8q4iq3DF9y58zQqfKcw0izDA4RwfwbGWX6unVYV+XghkXFO31G
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3ffecf77-6ece-440d-d2ab-08dbe6059f08
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Nov 2023 18:06:42.0263 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: J5izQHjnx2Td4sIWRudHpKAtg/AaMZh5vgL4mQgvL9w37Vgd4oSDe1TLoV2HCi7BGs6fh5ZnzHpxuc5VcbnNaw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4792
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-11-15_17,2023-11-15_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0
 adultscore=0
 phishscore=0 mlxscore=0 bulkscore=0 spamscore=0 suspectscore=0
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311060000 definitions=main-2311150141
X-Proofpoint-GUID: wDNxxwSlp0uhCjOv7_dmDxQQnQaDqHUF
X-Proofpoint-ORIG-GUID: wDNxxwSlp0uhCjOv7_dmDxQQnQaDqHUF
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 67161
Cc: "67161 <at> debbugs.gnu.org" <67161 <at> debbugs.gnu.org>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

PiA+IFdlIHNob3VsZG4ndCB1c2Ugbm9uLUFTQ0lJIGNoYXJhY3RlcnMgYnkgZGVmYXVsdCwgd2l0
aG91dCBjaGVja2luZw0KPiA+IHRoZXkgY2FuIGJlIGRpc3BsYXllZC4NCj4gDQo+IFRoYW5rcyBm
b3IgcG9pbnRpbmcgdGhpcyBvdXQuIEkgdGhpbmsgaXQgY2FuIGJlIGNoYW5nZWQgdG8gIi4uLiIu
DQoNCisxLg0KDQpXb3VsZCBzb21lb25lIHBsZWFzZSBkbyBsaWtld2lzZSBmb3IgYGRpcmVkLXNv
cnQtc2V0LW1vZGUtbGluZSc/DQpNeSB2ZXJzaW9uIChpbiBEaXJlZCspIHVzZXMgIi4uLiIsIG5v
dCBhbiBlbGxpcHNpcyBjaGFyLg0KDQpGV0lXLCBJTU8gYW4gZWxsaXBzaXMgY2hhciBpcyBfYmFk
XyB3aGVuIHRoZSBmb250IHVzZWQgaXMgZml4ZWQNCndpZHRoLiAgSXQncyBub3QgdmVyeSBsZWdp
YmxlLCBpbiBwYXJ0aWN1bGFyLg0KX19fDQoNCg0KRldJVzI6IFRoZSBvdGhlciBkaWZmZXJlbmNl
IG15IHZlcnNpb24gaGFzIGlzDQp0aGF0IGl0IHJlc3BlY3RzIGEgdXNlciBvcHRpb246DQpfX18N
Cg0KZGlyZWRwLXN3aXRjaGVzLWluLW1vZGUtbGluZSBpcyBhIHZhcmlhYmxlIGRlZmluZWQgaW4g
YGRpcmVkKy5lbCcuDQoNCkl0cyB2YWx1ZSBpcyBuaWwNCg0KSG93IHRvIGluZGljYXRlIGBkaXJl
ZC1hY3R1YWwtc3dpdGNoZXMnIGluIG1vZGUtbGluZS4NClBvc3NpYmxlIHZhbHVlczoNCiAqIGBu
aWwnOiAgICBJbmRpY2F0ZSBuYW1lLW9yLWRhdGUgc29ydCBvcmRlciwgaWYgcG9zc2libGUuDQog
ICAgICAgICAgICAgRWxzZSBzaG93IGZ1bGwgc3dpdGNoZXMuDQogKiBgYXMtaXMnOiAgU2hvdyBm
dWxsIHN3aXRjaGVzLg0KICogSW50ZWdlcjogIFNob3cgb25seSB0aGUgZmlyc3QgTiBjaGFycyBv
ZiBmdWxsIHN3aXRjaGVzLg0KICogRnVuY3Rpb246IFBhc3MgYGRpcmVkLWFjdHVhbC1zd2l0Y2hl
cycgYXMgYXJnIGFuZCBzaG93IHJlc3VsdC4NCl9fXw0KDQpJZiB2YW5pbGxhIEVtYWNzIGRpZCBs
aWtld2lzZSBvciBzb21ldGhpbmcgc2ltaWxhciB0aGVuIEkNCndvdWxkbid0IG5lZWQgbXkgdmVy
c2lvbiBvZiBgZGlyZWQtc29ydC1zZXQtbW9kZS1saW5lJw0KKGZvciBuZXcgRW1hY3MgdmVyc2lv
bnMsIGF0IGxlYXN0KS4NCg==




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67161; Package emacs. Full text available.

Message received at 67161 <at> debbugs.gnu.org:


Received: (at 67161) by debbugs.gnu.org; 15 Nov 2023 16:28:07 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Nov 15 11:28:07 2023
Received: from localhost ([127.0.0.1]:53116 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r3IkJ-00027g-9P
	for submit <at> debbugs.gnu.org; Wed, 15 Nov 2023 11:28:07 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:58120)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1r3IQg-0001QS-L6
 for 67161 <at> debbugs.gnu.org; Wed, 15 Nov 2023 11:07:50 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1r3F4j-00033c-OL; Wed, 15 Nov 2023 07:32:58 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=8BJl6Zm920IYb4AlenSPdHc2qis3qyCPz4eLjb8ZgC8=; b=fo3HnaybQrdkLR9aRZY3
 R2ly0qKpbvidNaGGrXdUSbSFDv0bCJcOuPfWj0EbOmPLMEwXLHwsrdIMcYB4EakfQ5QW5F3wHbk/s
 OAJmw1m7JiIy6xpsfn3kJTp6FZsE2dlp9BeWagnIeAZLe8GW4rB5oMZ/o4MKC727QizwWSNn3pO7+
 +8OZSzzqw+yI+8CQUVIhngvbBoV9DvbhpTOauT2KWFNKn53drA8xEkJxfoIDzdIM7hRVJOOEW4u9L
 +x2j2THpbfpPNn6ICFL8/MasThERJAD424jkajNwbkRfmZOaIDA9uCLAQatpzL3YrFDiyskPgDp6F
 PWO7IrDzWCVzIw==;
Date: Wed, 15 Nov 2023 14:32:30 +0200
Message-Id: <83a5rfrych.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Liu Hui <liuhui1610@HIDDEN>, Stefan Kangas <stefankangas@HIDDEN>,
 Stefan Monnier <monnier@HIDDEN>
In-Reply-To: <CAOQTW-P4+vs+JH8BTL8fL-d1QJXOdYq3i+3O7tALTDs=qHpnzA@HIDDEN>
 (message from Liu Hui on Wed, 15 Nov 2023 18:04:13 +0800)
Subject: Re: bug#67161: 30.0.50;
 [PATCH] Add option `dired-filename-display-length'
References: <CAOQTW-MSpBK4ACpLk8U2m6HJx8HXw21O0kyYZ-i85ETNjyOUcA@HIDDEN>
 <8334x8tqi9.fsf@HIDDEN>
 <CAOQTW-P4+vs+JH8BTL8fL-d1QJXOdYq3i+3O7tALTDs=qHpnzA@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 67161
Cc: 67161 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Liu Hui <liuhui1610@HIDDEN>
> Date: Wed, 15 Nov 2023 18:04:13 +0800
> Cc: 67161 <at> debbugs.gnu.org
> 
> Eli Zaretskii <eliz@HIDDEN> 于2023年11月14日周二 21:26写道:
> 
> > > +(defcustom dired-filename-hiding-ellipsis "…"
> >
> > We shouldn't use non-ASCII characters by default, without checking
> > they can be displayed.
> 
> Thanks for pointing this out. I think it can be changed to "...".

I actually wonder why we need it as a defcustom.  If you use
truncate-string-ellipsis, you will get both a customizable setting and
the correct string for the terminal at hand.  Why do we need an extra
option?

> > > +    (let ((ell-len (string-width dired-filename-hiding-ellipsis))
> > > +          maxlen filename-col)
> > > +      (while (< (point) end)
> > > +        (ignore-errors
> > > +       (if (not (dired-move-to-filename))
> >
> > Did you consider using truncate-string-to-width here?
> 
> I'm not sure what you mean. Using truncate-string-to-width to shorten
> string or using truncate-string-ellipsis to obtain the ellipsis? The
> problem of truncate-string-to-width is that it produces a new string.
> I want to avoid modifying the buffer text since it would break other
> dired functionalities. Therefore this patch only changes the display
> instead of the underlying text.

So you consider using the 'invisible' property a good feature?  I
actually don't like using it for such purposes, as it gets in the way.
But maybe as an opt-in behavior that could be OK?

Stefan & Stefan, WDYT?

Btw, using string-width might not be the best possibility here.  I
would recommend string-pixel-width instead (with subsequent division
by what default-char-width returns), as that will produce a better
approximation, especially on GUI frames.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67161; Package emacs. Full text available.

Message received at 67161 <at> debbugs.gnu.org:


Received: (at 67161) by debbugs.gnu.org; 15 Nov 2023 15:57:14 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Nov 15 10:57:14 2023
Received: from localhost ([127.0.0.1]:52962 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r3IGQ-00018D-4L
	for submit <at> debbugs.gnu.org; Wed, 15 Nov 2023 10:57:14 -0500
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:48709)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <monnier@HIDDEN>) id 1r3IGN-00017z-E7
 for 67161 <at> debbugs.gnu.org; Wed, 15 Nov 2023 10:57:13 -0500
Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
 by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 76AFA80675;
 Wed, 15 Nov 2023 10:57:06 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1700063825;
 bh=zCLcf2BgiK+01ZH+vtgbFzmwGytEHT3aM5GpQ91HJoI=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=pvtCSt7MgUXD1pGsOhKc5wx2EUS7PUDDKQnWG6qsqC2PhCXu3vkzhi0LzBZmDg3HI
 bs4TOhLvRdC5rmm7OEjadBGz2B1M4SEudtCrgJMJoAd8ZVK3FCyZdB5KU0Z5kOue4Z
 MURjVtyp4b1RkE7lJ6AyDnCuA2LsKpf7h2KtetnfQDrm9uJtiDxfKTNps0YiNP76ps
 BlBD2ggrYiwYauKBeALOPdHHnHq3H05kdoj0Srw/sdhEPEGEeIDRFIiNHO+NGTRwFx
 N7JaAnPQTDi4ZziUoH9eb/KijRCCDugFdU8IZhav55JbCHISv3MdKuLCx0Y6KOrpDW
 pi4AwFsdNEZ/w==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id B39E5803B1;
 Wed, 15 Nov 2023 10:57:05 -0500 (EST)
Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A51BE120191;
 Wed, 15 Nov 2023 10:57:05 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
To: Liu Hui <liuhui1610@HIDDEN>
Subject: Re: bug#67161: 30.0.50; [PATCH] Add option
 `dired-filename-display-length'
In-Reply-To: <CAOQTW-MSpBK4ACpLk8U2m6HJx8HXw21O0kyYZ-i85ETNjyOUcA@HIDDEN>
 (Liu Hui's message of "Tue, 14 Nov 2023 17:52:58 +0800")
Message-ID: <jwv5y236n1p.fsf-monnier+emacs@HIDDEN>
References: <CAOQTW-MSpBK4ACpLk8U2m6HJx8HXw21O0kyYZ-i85ETNjyOUcA@HIDDEN>
Date: Wed, 15 Nov 2023 10:54:36 -0500
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL 0.091 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
 DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
 domain T_SCC_BODY_TEXT_LINE    -0.01 -
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 67161
Cc: 67161 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> +(defcustom dired-filename-hiding-ellipsis "=E2=80=A6"
[...]
> +(defun dired-filename-update-invisibility-spec ()
> +  (funcall (if (derived-mode-p 'dired-mode)
> +               'add-to-invisibility-spec
> +             'remove-from-invisibility-spec)
> +           `(dired-filename-hide . ,dired-filename-hiding-ellipsis)))

AFAIK this does not do what the code suggests: the ELLIPSIS part
of the element passed to `add-to-invisibility-spec` is treated as
a boolean.

How the ellipses are displayed is controlled by the `selective-display`
extra slot of the display table.

I think it's good that you use `invisible`, tho, specifically since it
then uses whichever ellipsis the user has chosen via the display-table.
The downside is that most users don't know how to change it and there's
no convenient facility to access it.  You probably need something like

    (defun length-of-standard-ellipsis ()
      (let ((glyphs
             (and standard-display-table
                  (display-table-slot standard-display-table
                                      'selective-display))))
        (if glyphs (length glyphs) (eval-when-compile (length "...")))))


-- Stefan





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67161; Package emacs. Full text available.

Message received at 67161 <at> debbugs.gnu.org:


Received: (at 67161) by debbugs.gnu.org; 15 Nov 2023 15:30:47 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Nov 15 10:30:47 2023
Received: from localhost ([127.0.0.1]:52870 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r3Hqo-0000I8-52
	for submit <at> debbugs.gnu.org; Wed, 15 Nov 2023 10:30:46 -0500
Received: from mail-ot1-x329.google.com ([2607:f8b0:4864:20::329]:53458)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <liuhui1610@HIDDEN>) id 1r3Hqc-0000Hj-Rn
 for 67161 <at> debbugs.gnu.org; Wed, 15 Nov 2023 10:30:39 -0500
Received: by mail-ot1-x329.google.com with SMTP id
 46e09a7af769-6ce291b5df9so4381502a34.2
 for <67161 <at> debbugs.gnu.org>; Wed, 15 Nov 2023 07:30:35 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1700062230; x=1700667030; darn=debbugs.gnu.org;
 h=content-transfer-encoding:cc:to:subject:message-id:date:from
 :in-reply-to:references:mime-version:from:to:cc:subject:date
 :message-id:reply-to;
 bh=oNW5inS2/Y1VrmdfaNUh+55ICQJPXh4kTsSjqcJuYGU=;
 b=RPGtOwLrlDZjX+/LrkqGhJdLJTU9WQdS6fN5TrXz5/ld31cb1OmmdgjUOI9YN9LABW
 VgBMYaPxpOPYpp4cb7nptKGxVRe/FYmCXJKqHQ4nsORVXOEPRLa0WWI/upZ2WHc0lTo4
 fHOcfD7CrWcL+Y/fEllKQXnHSeTwuqxDeeiIKLvRWvVAWCopY04THywcQVxtbcNcSaMe
 Btpo+0XqlRk7wEYJoxzDNjCxIRjTS3G8wHYneO+dgd2vhecTjCItxB9oIN4KHlds4ZPr
 va+khVxJErAvH13rgbJRJCi6T716+dlkCx4wRpZMF0P0p5W5wTdmI5a3LD+wkAO7IKXl
 Qtog==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1700062230; x=1700667030;
 h=content-transfer-encoding:cc:to:subject:message-id:date:from
 :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=oNW5inS2/Y1VrmdfaNUh+55ICQJPXh4kTsSjqcJuYGU=;
 b=PmjsDISFrT6+GE23+JTM0DIthMEJjr1k8aVIX3DCypPs8S4iPWWwn8kqOYlFhn43p6
 0ddvPoHZ44o3SPtaGxpyztM62uGXCLWgMtjYO2XeUiMZKBaupXUIRU146D3d/GQIBSes
 NLBmBpOXEnET1Jgrr/7zVYd3igRlXHioQd/JyXBq3K3jq1IGgicV638VOcQkCc5qm++S
 eUbyET/j7MEvD9kksNbw+1969vDG+Wgp3jLGn2CwiimEK2u6n/W3WJnlHEyiaKqOC3ET
 3WDZV1vFMMqCDr8ic6YsByF3pltTb5XcOZWYyY135GJV7gSh+knlfW03ptalD9vt78EK
 ecDw==
X-Gm-Message-State: AOJu0Yy1VD+OMG9o4Kp14jbVJxiup0vTe1NfKS88DwU1PPHUHYAoI3Et
 VgESUAu8yCWkWqQHkeTEjO/3DK2+/oZ6ITPCKWebSg1XyV4=
X-Google-Smtp-Source: AGHT+IHsDb9ZdtQVr7ajAXCUGNLx3Q24v4wUuMm0rBnvEoiXSTs9VDoWzKTIn9ou2n+bybZxn6sksmIsObvXS65CVLM=
X-Received: by 2002:a67:b201:0:b0:45f:735d:a98 with SMTP id
 b1-20020a67b201000000b0045f735d0a98mr11537030vsf.12.1700042664672; Wed, 15
 Nov 2023 02:04:24 -0800 (PST)
MIME-Version: 1.0
References: <CAOQTW-MSpBK4ACpLk8U2m6HJx8HXw21O0kyYZ-i85ETNjyOUcA@HIDDEN>
 <8334x8tqi9.fsf@HIDDEN>
In-Reply-To: <8334x8tqi9.fsf@HIDDEN>
From: Liu Hui <liuhui1610@HIDDEN>
Date: Wed, 15 Nov 2023 18:04:13 +0800
Message-ID: <CAOQTW-P4+vs+JH8BTL8fL-d1QJXOdYq3i+3O7tALTDs=qHpnzA@HIDDEN>
Subject: Re: bug#67161: 30.0.50;
 [PATCH] Add option `dired-filename-display-length'
To: Eli Zaretskii <eliz@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 1.3 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 
 Content preview:  Eli Zaretskii 于2023年11月14日周二 21:26写道: >
   > +(defcustom dired-filename-hiding-ellipsis "…" > > We shouldn't use non-ASCII
    characters by default, without checking > they can be displayed. 
 
 Content analysis details:   (1.3 points, 10.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
  0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
  1.1 DATE_IN_PAST_03_06     Date: is 3 to 6 hours before Received: date
  0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
                             provider (liuhui1610[at]gmail.com)
 -0.0 SPF_PASS               SPF: sender matches SPF record
  0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends
                             in digit (liuhui1610[at]gmail.com)
 -0.0 RCVD_IN_DNSWL_NONE     RBL: Sender listed at https://www.dnswl.org/,
                              no trust
                             [2607:f8b0:4864:20:0:0:0:329 listed in]
                             [list.dnswl.org]
 -0.0 T_SCC_BODY_TEXT_LINE   No description available.
X-Debbugs-Envelope-To: 67161
Cc: 67161 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.3 (/)

Eli Zaretskii <eliz@HIDDEN> =E4=BA=8E2023=E5=B9=B411=E6=9C=8814=E6=97=A5=
=E5=91=A8=E4=BA=8C 21:26=E5=86=99=E9=81=93=EF=BC=9A

> > +(defcustom dired-filename-hiding-ellipsis "=E2=80=A6"
>
> We shouldn't use non-ASCII characters by default, without checking
> they can be displayed.

Thanks for pointing this out. I think it can be changed to "...".

> > +    (let ((ell-len (string-width dired-filename-hiding-ellipsis))
> > +          maxlen filename-col)
> > +      (while (< (point) end)
> > +        (ignore-errors
> > +       (if (not (dired-move-to-filename))
>
> Did you consider using truncate-string-to-width here?

I'm not sure what you mean. Using truncate-string-to-width to shorten
string or using truncate-string-ellipsis to obtain the ellipsis? The
problem of truncate-string-to-width is that it produces a new string.
I want to avoid modifying the buffer text since it would break other
dired functionalities. Therefore this patch only changes the display
instead of the underlying text.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67161; Package emacs. Full text available.

Message received at 67161 <at> debbugs.gnu.org:


Received: (at 67161) by debbugs.gnu.org; 14 Nov 2023 13:27:39 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 14 08:27:39 2023
Received: from localhost ([127.0.0.1]:60488 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r2tS6-0004QD-VV
	for submit <at> debbugs.gnu.org; Tue, 14 Nov 2023 08:27:39 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:35566)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1r2tS5-0004Pz-PP
 for 67161 <at> debbugs.gnu.org; Tue, 14 Nov 2023 08:27:38 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1r2tRK-0001aG-89; Tue, 14 Nov 2023 08:26:50 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=wjFIX2liZrdxE7MIRBqq0OTFWFDpTrx0HYCNE5ODU+E=; b=j/Qgm7krT/yMCgAD3JlW
 23xWTthkDSGiZgrCifkRjxllbRbXH9Dr5kKQYW/7yr2C9Gh1xijBq/iKbrW8utEbHZIEziWuQZybe
 HT0mDLomZA0kHRvb+64gqCLedMollR05XV7kTIh2imsI6SRqivZ6TC8+4KtPISViGSHaiDRwCovLy
 Ftt2py0rr32otpYQiEyr1DgVi2CG97lxgh2G0jz6v+9lJMBO2szxEsUEhjDCs2wEyXs8FQhfL+zU0
 E+QMd+yBKefajt2ja8P8Y5iuDLPGN69S7VRxMduLxtyYRPYA4i+OXHWoBTf5jokm53hlFEM6jLzsX
 wq+uoDy79rG0Gg==;
Date: Tue, 14 Nov 2023 15:26:38 +0200
Message-Id: <8334x8tqi9.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Liu Hui <liuhui1610@HIDDEN>
In-Reply-To: <CAOQTW-MSpBK4ACpLk8U2m6HJx8HXw21O0kyYZ-i85ETNjyOUcA@HIDDEN>
 (message from Liu Hui on Tue, 14 Nov 2023 17:52:58 +0800)
Subject: Re: bug#67161: 30.0.50;
 [PATCH] Add option `dired-filename-display-length'
References: <CAOQTW-MSpBK4ACpLk8U2m6HJx8HXw21O0kyYZ-i85ETNjyOUcA@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 67161
Cc: 67161 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Liu Hui <liuhui1610@HIDDEN>
> Date: Tue, 14 Nov 2023 17:52:58 +0800
> 
> The attached patch implements the feature of controlling the display
> length of filename in dired buffers.
> 
> When setting this option to `window', the long filename is shortened
> by hiding the middle part to ensure that the whole line needs not to
> be wrapped. The option can also be set to an integer, meaning the
> maximum display length of filename. For users who turn on line
> truncation, this feature can display the end part including the file
> extension, which I think is convenient.

Thanks.

> +(defcustom dired-filename-hiding-ellipsis "…"

We shouldn't use non-ASCII characters by default, without checking
they can be displayed.

> +    (let ((ell-len (string-width dired-filename-hiding-ellipsis))
> +          maxlen filename-col)
> +      (while (< (point) end)
> +        (ignore-errors
> +	  (if (not (dired-move-to-filename))

Did you consider using truncate-string-to-width here?




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#67161; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 14 Nov 2023 09:54:04 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 14 04:54:03 2023
Received: from localhost ([127.0.0.1]:60051 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r2q7P-0001ky-AJ
	for submit <at> debbugs.gnu.org; Tue, 14 Nov 2023 04:54:03 -0500
Received: from lists.gnu.org ([2001:470:142::17]:41330)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <liuhui1610@HIDDEN>) id 1r2q7M-0001kR-Kc
 for submit <at> debbugs.gnu.org; Tue, 14 Nov 2023 04:54:01 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <liuhui1610@HIDDEN>)
 id 1r2q6a-0001JC-Ud
 for bug-gnu-emacs@HIDDEN; Tue, 14 Nov 2023 04:53:12 -0500
Received: from mail-vk1-xa2a.google.com ([2607:f8b0:4864:20::a2a])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <liuhui1610@HIDDEN>)
 id 1r2q6Y-00025e-WF
 for bug-gnu-emacs@HIDDEN; Tue, 14 Nov 2023 04:53:12 -0500
Received: by mail-vk1-xa2a.google.com with SMTP id
 71dfb90a1353d-49dc95be8c3so2039423e0c.0
 for <bug-gnu-emacs@HIDDEN>; Tue, 14 Nov 2023 01:53:10 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1699955590; x=1700560390; darn=gnu.org;
 h=to:subject:message-id:date:from:mime-version:from:to:cc:subject
 :date:message-id:reply-to;
 bh=/pnOQANlgcWuGr2ObX3ucBz+/PKUac3kcjdrQthe7ao=;
 b=EW5l18EzH+XQpAlR6aqg7McMMtisN3gHROhsTnmz0clSt2Cw13WMTW3FNY63L+agHy
 TfxNmnQaJnluQAHAJyptGbcmIqLpyq5BnJeLNJO8hoFrah2X3wpncRuuTF8L8i628rs2
 WwaBf8HISZ8jhOTt4LITW8DY7RurCtF6rbetJ2FoEWuW1FakKltbD4ZG3Zjz4dcL4i2I
 z9IUjZ+ALan9dMHlIqxbIpvdPyEh5hJXd+S0ze6r3h43TrI4F2S429b1ZXNgUqbgYtJd
 Eu6iWAILL/c4vKXew3JDn2Bypq1WiGgOq1OAPmU2Vj//VGYozBOGsBwxXEKzw2I4/Akf
 u3Fg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1699955590; x=1700560390;
 h=to:subject:message-id:date:from:mime-version:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=/pnOQANlgcWuGr2ObX3ucBz+/PKUac3kcjdrQthe7ao=;
 b=KHkTxcPUk15kOHd/Xu59sah5iboqAT+GQDmitwQeuxtSVASHxvYAKgIvQXro0Z8tge
 6z3AlAOsWFb96wBc4oG6bAmZqras5p5yG7MqKNKJCcsQ5/+Cd2JUkie7E+FrAPvo1rd+
 eXWcpMJqzTR4xayYD42qPcvbHtIFHrlxvlukecUBNcYtTfd1J/Ll5hlIsAQdivTLaz16
 dAgcs+buOYO9yUF+Vip/0unvdbcOM23RxXnVEG+aKGASIraQYKrcqAp5haewA68n3r+j
 3Szd8G/oJwnIKqA6Ly44mtXMsV7WKerH+hvr+iEXaJIepC6sv0tZVTBu/56RGRxjy1jn
 Vs9g==
X-Gm-Message-State: AOJu0YxX1fyQ5qzbrwGWvAhSh7ORaVsPWzLxqsvItYiAmnaFPymvqoHB
 QOpV5K2bPQs/Yse3ikpwO4/2dX/xpyDbBRpblrqyaAzxIH0Skg==
X-Google-Smtp-Source: AGHT+IGQqo7qxlxgiATOcbuH9wN+ivS8eIskhcW311wpP2BiUgWTmM+Nsdscbwnuywy/PJaR6sJ+N5R4yozucOF/bBI=
X-Received: by 2002:a67:e1d1:0:b0:45f:b8e3:f7d5 with SMTP id
 p17-20020a67e1d1000000b0045fb8e3f7d5mr4364931vsl.8.1699955589712; Tue, 14 Nov
 2023 01:53:09 -0800 (PST)
MIME-Version: 1.0
From: Liu Hui <liuhui1610@HIDDEN>
Date: Tue, 14 Nov 2023 17:52:58 +0800
Message-ID: <CAOQTW-MSpBK4ACpLk8U2m6HJx8HXw21O0kyYZ-i85ETNjyOUcA@HIDDEN>
Subject: 30.0.50; [PATCH] Add option `dired-filename-display-length'
To: bug-gnu-emacs@HIDDEN
Content-Type: multipart/mixed; boundary="0000000000000f330e060a19c1cb"
Received-SPF: pass client-ip=2607:f8b0:4864:20::a2a;
 envelope-from=liuhui1610@HIDDEN; helo=mail-vk1-xa2a.google.com
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.2 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview:  Hi, The attached patch implements the feature of controlling
 the display length of filename in dired buffers. When setting this option
 to `window', the long filename is shortened by hiding the middle part to
 ensure that the whole line needs not to be wrapped. The option can also be
 set to an integer, meaning [...] 
 Content analysis details:   (1.2 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
 provider (liuhui1610[at]gmail.com)
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
 1.0 SPF_SOFTFAIL           SPF: sender does not match SPF record (softfail)
 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends
 in digit (liuhui1610[at]gmail.com)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.2 (/)

--0000000000000f330e060a19c1cb
Content-Type: text/plain; charset="UTF-8"

Hi,

The attached patch implements the feature of controlling the display
length of filename in dired buffers.

When setting this option to `window', the long filename is shortened
by hiding the middle part to ensure that the whole line needs not to
be wrapped. The option can also be set to an integer, meaning the
maximum display length of filename. For users who turn on line
truncation, this feature can display the end part including the file
extension, which I think is convenient.


Best,

--
Liu Hui

--0000000000000f330e060a19c1cb
Content-Type: text/x-patch; charset="UTF-8"; 
	name="0001-Add-option-dired-filename-display-length.patch"
Content-Disposition: attachment; 
	filename="0001-Add-option-dired-filename-display-length.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_loy5mhtw0>
X-Attachment-Id: f_loy5mhtw0

RnJvbSA0M2E3MjU4NWZmMTFiMzQyY2I0OGY0NTRiNDQ2NmVmNWVkNGI2ZjliIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBMaXUgSHVpIDxsaXVodWkxNjEwQGdtYWlsLmNvbT4KRGF0ZTog
VHVlLCAxNCBOb3YgMjAyMyAxNjoxNDoxMiArMDgwMApTdWJqZWN0OiBbUEFUQ0hdIEFkZCBvcHRp
b24gYGRpcmVkLWZpbGVuYW1lLWRpc3BsYXktbGVuZ3RoJwoKKiBsaXNwL2RpcmVkLmVsIChkaXJl
ZC1maWxlbmFtZS1kaXNwbGF5LWxlbmd0aCk6CihkaXJlZC1maWxlbmFtZS1oaWRpbmctZWxsaXBz
aXMpOiBOZXcgb3B0aW9ucy4KKGRpcmVkLWluc2VydC1zZXQtcHJvcGVydGllcyk6IFNldCBpbnZp
c2liaWxpdHkgc3BlYyBmb3IgbG9uZwpmaWxlbmFtZXMuCihkaXJlZC0tZ2V0LWZpbGVuYW1lLWRp
c3BsYXktbGVuZ3RoKQooZGlyZWQtZmlsZW5hbWUtdXBkYXRlLWludmlzaWJpbGl0eS1zcGVjKTog
TmV3IGZ1bmN0aW9ucy4KKGRpcmVkLW1vZGUpOiBBZGQgZmlsZW5hbWUgaW52aXNpYmlsaXR5IHNw
ZWMuCiogbGlzcC93ZGlyZWQuZWwgKHdkaXJlZC1jaGFuZ2UtdG8td2RpcmVkLW1vZGUpCih3ZGly
ZWQtY2hhbmdlLXRvLWRpcmVkLW1vZGUpOiBVcGRhdGUgZmlsZW5hbWUgaW52aXNpYmlsaXR5IHNw
ZWMuCi0tLQogbGlzcC9kaXJlZC5lbCAgfCAxMjQgKysrKysrKysrKysrKysrKysrKysrKysrKysr
KysrKysrLS0tLS0tLS0tLS0tLS0tLQogbGlzcC93ZGlyZWQuZWwgfCAgIDIgKwogMiBmaWxlcyBj
aGFuZ2VkLCA4NSBpbnNlcnRpb25zKCspLCA0MSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9s
aXNwL2RpcmVkLmVsIGIvbGlzcC9kaXJlZC5lbAppbmRleCA4OTE5ZDJjMjIzZi4uYjY1MGYxNWUy
OGYgMTAwNjQ0Ci0tLSBhL2xpc3AvZGlyZWQuZWwKKysrIGIvbGlzcC9kaXJlZC5lbApAQCAtNTE3
LDYgKzUxNywyMSBAQCBkaXJlZC1oaWRlLWRldGFpbHMtcHJlc2VydmVkLWNvbHVtbnMKICAgOnR5
cGUgJyhyZXBlYXQgaW50ZWdlcikKICAgOnZlcnNpb24gIjMwLjEiKQogCisoZGVmY3VzdG9tIGRp
cmVkLWZpbGVuYW1lLWRpc3BsYXktbGVuZ3RoIG5pbAorICAiSWYgbm9uLW5pbCwgaGlkZSBtaWRk
bGUgcGFydCBvZiBsb25nIGZpbGVuYW1lcyBpbiBEaXJlZCBidWZmZXJzLgorSWYgdGhlIHZhbHVl
IGlzIHRoZSBzeW1ib2wgYHdpbmRvdycsIHRoZW4gZmlsZW5hbWVzIGFyZSBzaG9ydGVuZWQKK3Rv
IG5vdCBleGNlZWQgdGhlIHJpZ2h0IGVkZ2Ugb2YgY3VycmVudCB3aW5kb3cuICBPdGhlcndpc2Us
IGl0CitzaG91bGQgYmUgYW4gaW50ZWdlciByZXByZXNlbnRpbmcgdGhlIG1heGltdW0gZmlsZW5h
bWUgbGVuZ3RoLiIKKyAgOnR5cGUgJyhjaG9pY2UgKGludGVnZXIgOnRhZyAiRnVsbCIgbmlsKQor
ICAgICAgICAgICAgICAgICAoY29uc3QgICA6dGFnICJXaW5kb3ciIHdpbmRvdykKKyAgICAgICAg
ICAgICAgICAgKGludGVnZXIgOnRhZyAiSW50ZWdlciIpKQorICA6dmVyc2lvbiAiMzAuMSIpCisK
KyhkZWZjdXN0b20gZGlyZWQtZmlsZW5hbWUtaGlkaW5nLWVsbGlwc2lzICLigKYiCisgICJTdHJp
bmcgdG8gaW5kaWNhdGUgZmlsZW5hbWUgaGlkaW5nLiIKKyAgOnR5cGUgJ3N0cmluZworICA6dmVy
c2lvbiAiMzAuMSIpCisKIAwKIDs7OyBJbnRlcm5hbCB2YXJpYWJsZXMKIApAQCAtMTkwMyw0OCAr
MTkxOCw2MiBAQCBkaXJlZC1pbnNlcnQtc2V0LXByb3BlcnRpZXMKICAgIkFkZCB2YXJpb3VzIHRl
eHQgcHJvcGVydGllcyB0byB0aGUgbGluZXMgaW4gdGhlIHJlZ2lvbiwgZnJvbSBCRUcgdG8gRU5E
LiIKICAgKHNhdmUtZXhjdXJzaW9uCiAgICAgKGdvdG8tY2hhciBiZWcpCi0gICAgKHdoaWxlICg8
IChwb2ludCkgZW5kKQotICAgICAgKGlnbm9yZS1lcnJvcnMKLQkoaWYgKG5vdCAoZGlyZWQtbW92
ZS10by1maWxlbmFtZSkpCi0JICAgICh1bmxlc3MgKG9yIChsb29raW5nLWF0LXAgIl4kIikKLQkJ
CShsb29raW5nLWF0LXAgZGlyZWQtc3ViZGlyLXJlZ2V4cCkpCi0JICAgICAgKHB1dC10ZXh0LXBy
b3BlcnR5IChsaW5lLWJlZ2lubmluZy1wb3NpdGlvbikKLQkJCQkgKDErIChsaW5lLWVuZC1wb3Np
dGlvbikpCi0JCQkJICdpbnZpc2libGUgJ2RpcmVkLWhpZGUtZGV0YWlscy1pbmZvcm1hdGlvbikp
Ci0JICAoc2F2ZS1leGN1cnNpb24KLSAgICAgICAgICAgIChsZXQgKChlbmQgKDEtIChwb2ludCkp
KQotICAgICAgICAgICAgICAgICAgKG9wb2ludCAoZ290by1jaGFyICgxKyAocG9zLWJvbCkpKSkK
LSAgICAgICAgICAgICAgICAgIChpIDApKQotICAgICAgICAgICAgICAocHV0LXRleHQtcHJvcGVy
dHkgb3BvaW50IGVuZCAnaW52aXNpYmxlICdkaXJlZC1oaWRlLWRldGFpbHMtZGV0YWlsKQotICAg
ICAgICAgICAgICAod2hpbGUgKHJlLXNlYXJjaC1mb3J3YXJkICJbXiBdKyIgZW5kIHQpCi0gICAg
ICAgICAgICAgICAgKHdoZW4gKG1lbWJlciAoY2wtaW5jZiBpKSBkaXJlZC1oaWRlLWRldGFpbHMt
cHJlc2VydmVkLWNvbHVtbnMpCi0gICAgICAgICAgICAgICAgICAocHV0LXRleHQtcHJvcGVydHkg
b3BvaW50IChwb2ludCkgJ2ludmlzaWJsZSBuaWwpKQotICAgICAgICAgICAgICAgIChzZXRxIG9w
b2ludCAocG9pbnQpKSkpKQotICAgICAgICAgIChsZXQgKChiZWcgKHBvaW50KSkgKGVuZCAoc2F2
ZS1leGN1cnNpb24KLQkgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChkaXJlZC1tb3ZlLXRv
LWVuZC1vZi1maWxlbmFtZSkKLQkgICAgICAgICAgICAgICAgICAgICAgICAgICAgICgxLSAocG9p
bnQpKSkpKQotICAgICAgICAgICAgKGlmIGRpcmVkLWNsaWNrLXRvLXNlbGVjdC1tb2RlCi0gICAg
ICAgICAgICAgICAgKHB1dC10ZXh0LXByb3BlcnR5IGJlZyBlbmQgJ2tleW1hcAotICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICBkaXJlZC1jbGljay10by1zZWxlY3QtbWFwKQotICAg
ICAgICAgICAgICAod2hlbiAoYW5kIGRpcmVkLW1vdXNlLWRyYWctZmlsZXMgKGZib3VuZHAgJ3gt
YmVnaW4tZHJhZykpCi0gICAgICAgICAgICAgICAgKHB1dC10ZXh0LXByb3BlcnR5IGJlZyBlbmQg
J2tleW1hcAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkaXJlZC1tb3VzZS1k
cmFnLWZpbGVzLW1hcCkpKQotCSAgICAoYWRkLXRleHQtcHJvcGVydGllcwotCSAgICAgYmVnICgx
KyBlbmQpCi0JICAgICBgKG1vdXNlLWZhY2UKLQkgICAgICAgaGlnaGxpZ2h0Ci0JICAgICAgIGRp
cmVkLWZpbGVuYW1lIHQKLQkgICAgICAgaGVscC1lY2hvICwoaWYgZGlyZWQtY2xpY2stdG8tc2Vs
ZWN0LW1vZGUKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJtb3VzZS0yOiBtYXJrIG9y
IHVubWFyayB0aGlzIGZpbGUiCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgKGlmIChhbmQg
ZGlyZWQtbW91c2UtZHJhZy1maWxlcwotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIChmYm91bmRwICd4LWJlZ2luLWRyYWcpKQotICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAiZG93bi1tb3VzZS0xOiBkcmFnIHRoaXMgZmlsZSB0byBhbm90aGVyIHByb2dyYW0KKyAg
ICAobGV0ICgoZWxsLWxlbiAoc3RyaW5nLXdpZHRoIGRpcmVkLWZpbGVuYW1lLWhpZGluZy1lbGxp
cHNpcykpCisgICAgICAgICAgbWF4bGVuIGZpbGVuYW1lLWNvbCkKKyAgICAgICh3aGlsZSAoPCAo
cG9pbnQpIGVuZCkKKyAgICAgICAgKGlnbm9yZS1lcnJvcnMKKwkgIChpZiAobm90IChkaXJlZC1t
b3ZlLXRvLWZpbGVuYW1lKSkKKwkgICAgICAodW5sZXNzIChvciAobG9va2luZy1hdC1wICJeJCIp
CisJCQkgIChsb29raW5nLWF0LXAgZGlyZWQtc3ViZGlyLXJlZ2V4cCkpCisJICAgICAgICAocHV0
LXRleHQtcHJvcGVydHkgKGxpbmUtYmVnaW5uaW5nLXBvc2l0aW9uKQorCQkJCSAgICgxKyAobGlu
ZS1lbmQtcG9zaXRpb24pKQorCQkJCSAgICdpbnZpc2libGUgJ2RpcmVkLWhpZGUtZGV0YWlscy1p
bmZvcm1hdGlvbikpCisJICAgIChzYXZlLWV4Y3Vyc2lvbgorICAgICAgICAgICAgICAobGV0ICgo
ZW5kICgxLSAocG9pbnQpKSkKKyAgICAgICAgICAgICAgICAgICAgKG9wb2ludCAoZ290by1jaGFy
ICgxKyAocG9zLWJvbCkpKSkKKyAgICAgICAgICAgICAgICAgICAgKGkgMCkpCisgICAgICAgICAg
ICAgICAgKHB1dC10ZXh0LXByb3BlcnR5IG9wb2ludCBlbmQgJ2ludmlzaWJsZSAnZGlyZWQtaGlk
ZS1kZXRhaWxzLWRldGFpbCkKKyAgICAgICAgICAgICAgICAod2hpbGUgKHJlLXNlYXJjaC1mb3J3
YXJkICJbXiBdKyIgZW5kIHQpCisgICAgICAgICAgICAgICAgICAod2hlbiAobWVtYmVyIChjbC1p
bmNmIGkpIGRpcmVkLWhpZGUtZGV0YWlscy1wcmVzZXJ2ZWQtY29sdW1ucykKKyAgICAgICAgICAg
ICAgICAgICAgKHB1dC10ZXh0LXByb3BlcnR5IG9wb2ludCAocG9pbnQpICdpbnZpc2libGUgbmls
KSkKKyAgICAgICAgICAgICAgICAgIChzZXRxIG9wb2ludCAocG9pbnQpKSkpKQorICAgICAgICAg
ICAgKGxldCAoKGJlZyAocG9pbnQpKSAoZW5kIChzYXZlLWV4Y3Vyc2lvbgorCSAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAoZGlyZWQtbW92ZS10by1lbmQtb2YtZmlsZW5hbWUpCisJICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICgxLSAocG9pbnQpKSkpKQorICAgICAgICAgICAg
ICAoaWYgZGlyZWQtY2xpY2stdG8tc2VsZWN0LW1vZGUKKyAgICAgICAgICAgICAgICAgIChwdXQt
dGV4dC1wcm9wZXJ0eSBiZWcgZW5kICdrZXltYXAKKyAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICBkaXJlZC1jbGljay10by1zZWxlY3QtbWFwKQorICAgICAgICAgICAgICAgICh3
aGVuIChhbmQgZGlyZWQtbW91c2UtZHJhZy1maWxlcyAoZmJvdW5kcCAneC1iZWdpbi1kcmFnKSkK
KyAgICAgICAgICAgICAgICAgIChwdXQtdGV4dC1wcm9wZXJ0eSBiZWcgZW5kICdrZXltYXAKKyAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkaXJlZC1tb3VzZS1kcmFnLWZpbGVz
LW1hcCkpKQorICAgICAgICAgICAgICAod2hlbiBkaXJlZC1maWxlbmFtZS1kaXNwbGF5LWxlbmd0
aAorICAgICAgICAgICAgICAgIChsZXQgKChsZW4gKHN0cmluZy13aWR0aCAoYnVmZmVyLXN1YnN0
cmluZyBiZWcgKDErIGVuZCkpKSkKKyAgICAgICAgICAgICAgICAgICAgICBlbGwtYmVnKQorICAg
ICAgICAgICAgICAgICAgKG9yIG1heGxlbiAoc2V0cSBtYXhsZW4gKGRpcmVkLS1nZXQtZmlsZW5h
bWUtZGlzcGxheS1sZW5ndGgpKSkKKyAgICAgICAgICAgICAgICAgICh3aGVuIChhbmQgKGludGVn
ZXJwIG1heGxlbikgKD4gbGVuIG1heGxlbiAoKyBlbGwtbGVuIDIpKSkKKyAgICAgICAgICAgICAg
ICAgICAgKG9yIGZpbGVuYW1lLWNvbCAoc2V0cSBmaWxlbmFtZS1jb2wgKGN1cnJlbnQtY29sdW1u
KSkpCisgICAgICAgICAgICAgICAgICAgIChtb3ZlLXRvLWNvbHVtbiAoKyBmaWxlbmFtZS1jb2wg
KC8gbWF4bGVuIDIpKSkKKyAgICAgICAgICAgICAgICAgICAgKHNldHEgZWxsLWJlZyAocG9pbnQp
KQorICAgICAgICAgICAgICAgICAgICAobW92ZS10by1jb2x1bW4gKCsgZmlsZW5hbWUtY29sICgv
IG1heGxlbiAyKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKC0gbGVu
IG1heGxlbikgZWxsLWxlbikpCisgICAgICAgICAgICAgICAgICAgIChwdXQtdGV4dC1wcm9wZXJ0
eQorICAgICAgICAgICAgICAgICAgICAgZWxsLWJlZyAocG9pbnQpICdpbnZpc2libGUgJ2RpcmVk
LWZpbGVuYW1lLWhpZGUpKSkpCisJICAgICAgKGFkZC10ZXh0LXByb3BlcnRpZXMKKwkgICAgICAg
YmVnICgxKyBlbmQpCisJICAgICAgIGAobW91c2UtZmFjZQorCSAgICAgICAgIGhpZ2hsaWdodAor
CSAgICAgICAgIGRpcmVkLWZpbGVuYW1lIHQKKwkgICAgICAgICBoZWxwLWVjaG8gLChpZiBkaXJl
ZC1jbGljay10by1zZWxlY3QtbW9kZQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAi
bW91c2UtMjogbWFyayBvciB1bm1hcmsgdGhpcyBmaWxlIgorICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgKGlmIChhbmQgZGlyZWQtbW91c2UtZHJhZy1maWxlcworICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgKGZib3VuZHAgJ3gtYmVnaW4tZHJhZykpCisgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgImRvd24tbW91c2UtMTogZHJhZyB0aGlzIGZpbGUg
dG8gYW5vdGhlciBwcm9ncmFtCiBtb3VzZS0yOiB2aXNpdCB0aGlzIGZpbGUgaW4gb3RoZXIgd2lu
ZG93IgotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIm1vdXNlLTI6IHZpc2l0IHRoaXMg
ZmlsZSBpbiBvdGhlciB3aW5kb3ciKSkpKQotCSAgICAod2hlbiAoPCAoKyBlbmQgNSkgKGxpbmUt
ZW5kLXBvc2l0aW9uKSkKLQkgICAgICAocHV0LXRleHQtcHJvcGVydHkgKCsgZW5kIDUpIChsaW5l
LWVuZC1wb3NpdGlvbikKLQkJCSAgICAgICAgICdpbnZpc2libGUgJ2RpcmVkLWhpZGUtZGV0YWls
cy1saW5rKSkpKSkKLSAgICAgIChmb3J3YXJkLWxpbmUgMSkpKSkKKyAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIm1vdXNlLTI6IHZpc2l0IHRoaXMgZmlsZSBpbiBvdGhlciB3aW5kb3ci
KSkpKQorCSAgICAgICh3aGVuICg8ICgrIGVuZCA1KSAobGluZS1lbmQtcG9zaXRpb24pKQorCSAg
ICAgICAgKHB1dC10ZXh0LXByb3BlcnR5ICgrIGVuZCA1KSAobGluZS1lbmQtcG9zaXRpb24pCisJ
CQkgICAgICAgICAgICdpbnZpc2libGUgJ2RpcmVkLWhpZGUtZGV0YWlscy1saW5rKSkpKSkKKyAg
ICAgICAgKGZvcndhcmQtbGluZSAxKSkpKSkKIAogKGRlZnVuIGRpcmVkLS1tYWtlLWRpcmVjdG9y
eS1jbGlja2FibGUgKCkKICAgKHNhdmUtZXhjdXJzaW9uCkBAIC0xOTc2LDYgKzIwMDUsMTIgQEAg
ZGlyZWQtLW1ha2UtZGlyZWN0b3J5LWNsaWNrYWJsZQogICAgICAgICAgICAgICAgICAgICAgICAg
ICAiUkVUIiBjbGljaykpKSkKICAgICAgICAgICAoc2V0cSBzZWdtZW50LXN0YXJ0IChwb2ludCkp
KSkpKSkKIAorKGRlZnVuIGRpcmVkLS1nZXQtZmlsZW5hbWUtZGlzcGxheS1sZW5ndGggKCkKKyAg
IlJldHVybiBtYXhpbXVtIGRpc3BsYXkgbGVuZ3RoIG9mIGZpbGVuYW1lLiIKKyAgKGlmIChpbnRl
Z2VycCBkaXJlZC1maWxlbmFtZS1kaXNwbGF5LWxlbmd0aCkKKyAgICAgIGRpcmVkLWZpbGVuYW1l
LWRpc3BsYXktbGVuZ3RoCisgICAgKC0gKHdpbmRvdy1tYXgtY2hhcnMtcGVyLWxpbmUpIDIgKGN1
cnJlbnQtY29sdW1uKSkpKQorCiAMCiA7OzsgUmV2ZXJ0aW5nIGEgZGlyZWQgYnVmZmVyCiAKQEAg
LTI2MTcsNiArMjY1Miw3IEBAIGRpcmVkLW1vZGUKIAltb2RlLWxpbmUtYnVmZmVyLWlkZW50aWZp
Y2F0aW9uCiAJKHByb3BlcnRpemVkLWJ1ZmZlci1pZGVudGlmaWNhdGlvbiAiJTE3YiIpKQogICAo
YWRkLXRvLWludmlzaWJpbGl0eS1zcGVjICcoZGlyZWQgLiB0KSkKKyAgKGRpcmVkLWZpbGVuYW1l
LXVwZGF0ZS1pbnZpc2liaWxpdHktc3BlYykKICAgOzsgSWdub3JlIGRpcmVkLWhpZGUtZGV0YWls
cy0qIHZhbHVlIG9mIGludmlzaWJsZSB0ZXh0IHByb3BlcnR5IGJ5IGRlZmF1bHQuCiAgICh3aGVu
IChlcSBidWZmZXItaW52aXNpYmlsaXR5LXNwZWMgdCkKICAgICAoc2V0cSBidWZmZXItaW52aXNp
YmlsaXR5LXNwZWMgKGxpc3QgdCkpKQpAQCAtMzEwNiw2ICszMTQyLDEyIEBAIGRpcmVkLWhpZGUt
ZGV0YWlscy11cGRhdGUtaW52aXNpYmlsaXR5LXNwZWMKIAwKIDs7OyBGdW5jdGlvbnMgdG8gaGlk
ZS91bmhpZGUgdGV4dAogCisoZGVmdW4gZGlyZWQtZmlsZW5hbWUtdXBkYXRlLWludmlzaWJpbGl0
eS1zcGVjICgpCisgIChmdW5jYWxsIChpZiAoZGVyaXZlZC1tb2RlLXAgJ2RpcmVkLW1vZGUpCisg
ICAgICAgICAgICAgICAnYWRkLXRvLWludmlzaWJpbGl0eS1zcGVjCisgICAgICAgICAgICAgJ3Jl
bW92ZS1mcm9tLWludmlzaWJpbGl0eS1zcGVjKQorICAgICAgICAgICBgKGRpcmVkLWZpbGVuYW1l
LWhpZGUgLiAsZGlyZWQtZmlsZW5hbWUtaGlkaW5nLWVsbGlwc2lzKSkpCisKIChkZWZ1biBkaXJl
ZC0tZmluZC1oaWRkZW4tcG9zIChzdGFydCBlbmQpCiAgICh0ZXh0LXByb3BlcnR5LWFueSBzdGFy
dCBlbmQgJ2ludmlzaWJsZSAnZGlyZWQpKQogCmRpZmYgLS1naXQgYS9saXNwL3dkaXJlZC5lbCBi
L2xpc3Avd2RpcmVkLmVsCmluZGV4IDA3OWQ5M2Q2MDExLi41ZDUwYTU3NDI5MCAxMDA2NDQKLS0t
IGEvbGlzcC93ZGlyZWQuZWwKKysrIGIvbGlzcC93ZGlyZWQuZWwKQEAgLTI2MSw2ICsyNjEsNyBA
QCB3ZGlyZWQtY2hhbmdlLXRvLXdkaXJlZC1tb2RlCiAgIChhZGQtZnVuY3Rpb24gOm92ZXJyaWRl
IChsb2NhbCAncmV2ZXJ0LWJ1ZmZlci1mdW5jdGlvbikgIyd3ZGlyZWQtcmV2ZXJ0KQogICAoc2V0
LWJ1ZmZlci1tb2RpZmllZC1wIG5pbCkKICAgKHNldHEgYnVmZmVyLXVuZG8tbGlzdCBuaWwpCisg
IChkaXJlZC1maWxlbmFtZS11cGRhdGUtaW52aXNpYmlsaXR5LXNwZWMpCiAgIChydW4tbW9kZS1o
b29rcyAnd2RpcmVkLW1vZGUtaG9vaykKICAgKG1lc3NhZ2UgIiVzIiAoc3Vic3RpdHV0ZS1jb21t
YW5kLWtleXMKIAkJICJQcmVzcyBcXFt3ZGlyZWQtZmluaXNoLWVkaXRdIHdoZW4gZmluaXNoZWQg
XApAQCAtNDU2LDYgKzQ1Nyw3IEBAIHdkaXJlZC1jaGFuZ2UtdG8tZGlyZWQtbW9kZQogICAoZGly
ZWQtc29ydC1zZXQtbW9kZS1saW5lKQogICAoZGlyZWQtYWR2ZXJ0aXNlKQogICAoZGlyZWQtaGlk
ZS1kZXRhaWxzLXVwZGF0ZS1pbnZpc2liaWxpdHktc3BlYykKKyAgKGRpcmVkLWZpbGVuYW1lLXVw
ZGF0ZS1pbnZpc2liaWxpdHktc3BlYykKICAgKHJlbW92ZS1ob29rICdraWxsLWJ1ZmZlci1ob29r
ICMnd2RpcmVkLWNoZWNrLWtpbGwtYnVmZmVyIHQpCiAgIChyZW1vdmUtaG9vayAnYmVmb3JlLWNo
YW5nZS1mdW5jdGlvbnMgIyd3ZGlyZWQtLWJlZm9yZS1jaGFuZ2UtZm4gdCkKICAgKHJlbW92ZS1o
b29rICdhZnRlci1jaGFuZ2UtZnVuY3Rpb25zICMnd2RpcmVkLS1yZXN0b3JlLXByb3BlcnRpZXMg
dCkKLS0gCjIuMjUuMQoK
--0000000000000f330e060a19c1cb--




Acknowledgement sent to Liu Hui <liuhui1610@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#67161; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Sun, 26 Nov 2023 06:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.