GNU bug report logs - #67183
[PATCH] gnu: Add python-canmatrix.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 67183 in the body.
You can then email your comments to 67183 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Troy Figiel <troy <at> troyfigiel.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add python-canmatrix.
Date: Tue, 14 Nov 2023 22:24:52 +0100

* gnu/packages/python-xyz.scm (python-canmatrix): New variable.

Change-Id: I96192f7304388aefe1b5cc358d462d42120ca3a0
---
 gnu/packages/python-xyz.scm | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index e521c1580d..10182893cd 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -145,6 +145,7 @@
 ;;; Copyright © c4droid <c4droid <at> foxmail.com>
 ;;; Copyright © 2023 Janneke Nieuwenhuizen <janneke <at> gnu.org>
 ;;; Copyright © 2023 Attila Lendvai <attila <at> lendvai.name>
+;;; Copyright © 2023 Troy Figiel <troy <at> troyfigiel.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -2955,6 +2956,39 @@ (define-public python-can
 sending and receiving messages on a CAN bus.")
     (license license:lgpl3+)))

+(define-public python-canmatrix
+  (package
+    (name "python-canmatrix")
+    (version "1.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "canmatrix" version))
+       (sha256
+        (base32 "046dzmggfm6h0fvfvwrblvih0blhc70ma0pqxzry3cphc08jvsrg"))
+       ;; The test suite uder ./test is a legacy test suite. The new test
+       ;; suite is defined under src/canmatrix/tests.
+       (modules '((guix build utils)))
+       (snippet '(delete-file-recursively "test"))))
+    (build-system python-build-system)
+    (arguments
+     '(#:phases (modify-phases %standard-phases
+                  (replace 'check
+                    (lambda* (#:key tests? #:allow-other-keys)
+                      (when tests?
+                        (invoke "pytest")))))))
+    (propagated-inputs (list python-attrs python-click python-future
+                             python-six))
+    (native-inputs (list python-lxml python-pytest python-xlrd python-xlwt))
+    (home-page "https://github.com/ebroecker/canmatrix")
+    (synopsis "Implements a CAN matrix object in Python")
+    (description
+     "This package implements a CAN matrix object in Python which describes the
+CAN-communication and its needed objects such as board units, frames, signals
+and values.  It also includes two command line tools (canconvert and
+cancompare) for converting and comparing CAN databases.")
+    (license license:bsd-2)))
+
 (define-public python-canopen
   (package
     (name "python-canopen")
--
2.40.1

Message #10 received at 67183-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Troy Figiel <troy <at> troyfigiel.com>
Cc: 67183-done <at> debbugs.gnu.org
Subject: Re: [bug#67183] [PATCH] gnu: Add python-canmatrix.
Date: Sun, 26 Nov 2023 23:30:31 +0100

[Message part 1 (text/plain, inline)]

Hi,

Troy Figiel <troy <at> troyfigiel.com> skribis:

> * gnu/packages/python-xyz.scm (python-canmatrix): New variable.
>
> Change-Id: I96192f7304388aefe1b5cc358d462d42120ca3a0

Applied with the cosmetic changes below, following
<https://guix.gnu.org/manual/devel/en/html_node/Synopses-and-Descriptions.html>.

Thanks,
Ludo’.

[Message part 2 (text/x-patch, inline)]

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index ea1b56fa82..746ecccc5a 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -2981,12 +2981,13 @@ (define-public python-canmatrix
                              python-six))
     (native-inputs (list python-lxml python-pytest python-xlrd python-xlwt))
     (home-page "https://github.com/ebroecker/canmatrix")
-    (synopsis "Implements a CAN matrix object in Python")
+    (synopsis "@acronym{CAN, Controller Area Network} matrices in Python")
     (description
-     "This package implements a CAN matrix object in Python which describes the
-CAN-communication and its needed objects such as board units, frames, signals
-and values.  It also includes two command line tools (canconvert and
-cancompare) for converting and comparing CAN databases.")
+     "This package implements a @acronym{CAN, Controller Area Network} matrix
+object in Python which describes the CAN-communication and its needed objects
+such as board units, frames, signals, and values.  It also includes two
+command-line tools (@command{canconvert} and @command{cancompare}) for
+converting and comparing CAN databases.")
     (license license:bsd-2)))
 
 (define-public python-canopen

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.