GNU bug report logs - #67198
[PATCH] gnu: Add emacs-adwaita-dark-theme

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 67198 in the body.
You can then email your comments to 67198 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tristan Cottam <tristan <at> cott.am>
To: guix-patches <at> gnu.org
Cc: Tristan Cottam <tristan <at> cott.am>
Subject: [PATCH] gnu: Add emacs-adwaita-dark-theme
Date: Wed, 15 Nov 2023 13:38:16 +0100

* gnu/packages/emacs-xyz.scm (emacs-adwaita-dark-theme): New variable.

Change-Id: Id6e6d0d6aa27e7c1cc6ec0fc11c3a5f09231d751
---
 gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index be7ffd1f37..b0c5f10b96 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1995,6 +1995,29 @@ (define-public emacs-suneater-theme
 theme but now takes more inspiration from the Nano theme.")
     (license license:gpl3+)))
 
+(define-public emacs-adwaita-dark-theme
+  (let ((commit "a97d5d5f5657a52c3b4c4b146b4d307dfb1a7a74")
+        (revision "0"))
+    (package
+      (name "emacs-adwaita-dark-theme")
+      (version (git-version "1.1.0" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://gitlab.com/jessieh/adwaita-dark-theme")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "0g8fjqmz805fhqspbzmpvb90kpzwigl4z56bkykywgy2cwb9ljzh"))))
+      (build-system emacs-build-system)
+      (home-page "https://gitlab.com/jessieh/adwaita-dark-theme")
+      (synopsis "Adwaita-inspired dark color scheme for Emacs")
+      (description
+       "adwaita-dark-theme is an Adwaita-inspired dark color scheme for
+Emacs.")
+      (license license:gpl2+))))
+
 (define-public emacs-treepy
   (package
     (name "emacs-treepy")

base-commit: bd0f2173210416e86281c1de8789e7cdab66dd57
prerequisite-patch-id: 5e36e77f4fa1848dbd20c2e5d5cec31d2473c2a8
-- 
2.41.0

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Tristan Cottam via Guix-patches via <guix-patches <at> gnu.org>
Cc: Tristan Cottam <tristan <at> cott.am>,
 Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 67198 <at> debbugs.gnu.org,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: [bug#67198] [PATCH] gnu: Add emacs-adwaita-dark-theme
Date: Wed, 15 Nov 2023 18:11:19 +0100

Hello,

Tristan Cottam via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-adwaita-dark-theme): New variable.

Thank you.

> +(define-public emacs-adwaita-dark-theme
> +  (let ((commit "a97d5d5f5657a52c3b4c4b146b4d307dfb1a7a74")
> +        (revision "0"))
> +    (package
> +      (name "emacs-adwaita-dark-theme")
> +      (version (git-version "1.1.0" revision commit))

The last commit is actually a version bump to "1.1.1", so you can bind
`version' to "1.1.1", drop `revision' and use that commit instead.

> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url "https://gitlab.com/jessieh/adwaita-dark-theme")
> +                      (commit commit)))
> +                (file-name (git-file-name name version))
> +                (sha256
> +                 (base32
> +                  "0g8fjqmz805fhqspbzmpvb90kpzwigl4z56bkykywgy2cwb9ljzh"))))
> +      (build-system emacs-build-system)
> +      (home-page "https://gitlab.com/jessieh/adwaita-dark-theme")
> +      (synopsis "Adwaita-inspired dark color scheme for Emacs")
> +      (description
> +       "adwaita-dark-theme is an Adwaita-inspired dark color scheme for
> +Emacs.")

Nitpick: "Adwaita Dark is an Adwaita-inspired…"

Otherwise, LGTM.

Regards,
-- 
Nicolas Goaziou

Message #14 received at 67198 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Tristan Cottam <tristan <at> cott.am>, 67198 <at> debbugs.gnu.org
Cc: Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: [bug#67198] [PATCH] gnu: Add emacs-adwaita-dark-theme
Date: Wed, 15 Nov 2023 19:40:14 +0100

Am Mittwoch, dem 15.11.2023 um 13:38 +0100 schrieb Tristan Cottam:
> * gnu/packages/emacs-xyz.scm (emacs-adwaita-dark-theme): New
> variable.
> 
> Change-Id: Id6e6d0d6aa27e7c1cc6ec0fc11c3a5f09231d751
> ---
>  gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index be7ffd1f37..b0c5f10b96 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -1995,6 +1995,29 @@ (define-public emacs-suneater-theme
>  theme but now takes more inspiration from the Nano theme.")
>      (license license:gpl3+)))
>  
> +(define-public emacs-adwaita-dark-theme
> +  (let ((commit "a97d5d5f5657a52c3b4c4b146b4d307dfb1a7a74")
> +        (revision "0"))
> +    (package
> +      (name "emacs-adwaita-dark-theme")
> +      (version (git-version "1.1.0" revision commit))
> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url
> "https://gitlab.com/jessieh/adwaita-dark-theme")
> +                      (commit commit)))
> +                (file-name (git-file-name name version))
> +                (sha256
> +                 (base32
> +                 
> "0g8fjqmz805fhqspbzmpvb90kpzwigl4z56bkykywgy2cwb9ljzh"))))
> +      (build-system emacs-build-system)
> +      (home-page "https://gitlab.com/jessieh/adwaita-dark-theme")
> +      (synopsis "Adwaita-inspired dark color scheme for Emacs")
> +      (description
> +       "adwaita-dark-theme is an Adwaita-inspired dark color scheme
> for
> +Emacs.")
Don't start a description with lower case.  If you really need to, use
@code or similar (discouraged here imho), otherwise good ol' "This
package provides" has your back.
> +      (license license:gpl2+))))
> +
>  (define-public emacs-treepy
>    (package
>      (name "emacs-treepy")
> 
> base-commit: bd0f2173210416e86281c1de8789e7cdab66dd57
> prerequisite-patch-id: 5e36e77f4fa1848dbd20c2e5d5cec31d2473c2a8
Cheers

Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>, Tristan Cottam via
 Guix-patches via <guix-patches <at> gnu.org>
Cc: Tristan Cottam <tristan <at> cott.am>,
 Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>, 67198 <at> debbugs.gnu.org,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: [bug#67198] [PATCH] gnu: Add emacs-adwaita-dark-theme
Date: Wed, 15 Nov 2023 19:41:18 +0100

Am Mittwoch, dem 15.11.2023 um 18:11 +0100 schrieb Nicolas Goaziou:
> Hello,
> 
> Tristan Cottam via Guix-patches via <guix-patches <at> gnu.org> writes:
> 
> > * gnu/packages/emacs-xyz.scm (emacs-adwaita-dark-theme): New
> > variable.
> 
> Thank you.
> 
> > +(define-public emacs-adwaita-dark-theme
> > +  (let ((commit "a97d5d5f5657a52c3b4c4b146b4d307dfb1a7a74")
> > +        (revision "0"))
> > +    (package
> > +      (name "emacs-adwaita-dark-theme")
> > +      (version (git-version "1.1.0" revision commit))
> 
> The last commit is actually a version bump to "1.1.1", so you can
> bind `version' to "1.1.1", drop `revision' and use that commit
> instead.

If it's not a release commit, I'd still use git-version.

Cheers

Message #23 received at 67198 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: tristan <at> cott.am, cox.katherine.e+guix <at> gmail.com, 67198 <at> debbugs.gnu.org,
 andrew <at> trop.in
Subject: Re: [bug#67198] [PATCH] gnu: Add emacs-adwaita-dark-theme
Date: Wed, 15 Nov 2023 21:07:27 +0100

Hello,

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> Am Mittwoch, dem 15.11.2023 um 18:11 +0100 schrieb Nicolas Goaziou:

>> The last commit is actually a version bump to "1.1.1", so you can
>> bind `version' to "1.1.1", drop `revision' and use that commit
>> instead.
>
> If it's not a release commit, I'd still use git-version.

FWIW, changing the Version keyword in the header is a release. Also, it
has the benefit of making the version number more meaningful.

Regards,
-- 
Nicolas Goaziou

Message #26 received at 67198 <at> debbugs.gnu.org (full text, mbox):

From: Tristan Cottam <tristan <at> cott.am>
To: 67198 <at> debbugs.gnu.org
Cc: Tristan Cottam <tristan <at> cott.am>
Subject: [PATCH v2] gnu: Add emacs-adwaita-dark-theme
Date: Wed, 15 Nov 2023 22:59:33 +0100

* gnu/packages/emacs-xyz.scm (emacs-adwaita-dark-theme): New variable.

Change-Id: Id6e6d0d6aa27e7c1cc6ec0fc11c3a5f09231d751
---


> FWIW, changing the Version keyword in the header is a release. Also, it
> has the benefit of making the version number more meaningful.

I agree, I had missed that version bump commit. However, it isn't in fact the
last one, so I left the rest as it is.

 gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index be7ffd1f37..443f315f23 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1995,6 +1995,29 @@ (define-public emacs-suneater-theme
 theme but now takes more inspiration from the Nano theme.")
     (license license:gpl3+)))
 
+(define-public emacs-adwaita-dark-theme
+  (let ((commit "a97d5d5f5657a52c3b4c4b146b4d307dfb1a7a74")
+        (revision "0"))
+    (package
+      (name "emacs-adwaita-dark-theme")
+      (version (git-version "1.1.1" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://gitlab.com/jessieh/adwaita-dark-theme")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "0g8fjqmz805fhqspbzmpvb90kpzwigl4z56bkykywgy2cwb9ljzh"))))
+      (build-system emacs-build-system)
+      (home-page "https://gitlab.com/jessieh/adwaita-dark-theme")
+      (synopsis "Adwaita-inspired dark color scheme for Emacs")
+      (description
+       "adwaita-dark-theme is an Adwaita-inspired dark color scheme for
+Emacs.")
+      (license license:gpl2+))))
+
 (define-public emacs-treepy
   (package
     (name "emacs-treepy")

base-commit: bd0f2173210416e86281c1de8789e7cdab66dd57
prerequisite-patch-id: 5e36e77f4fa1848dbd20c2e5d5cec31d2473c2a8
-- 
2.41.0

Message #29 received at 67198 <at> debbugs.gnu.org (full text, mbox):

From: Tristan Cottam <tristan <at> cott.am>
To: 67198 <at> debbugs.gnu.org
Cc: Tristan Cottam <tristan <at> cott.am>
Subject: [PATCH v3] gnu: Add emacs-adwaita-dark-theme
Date: Sat, 18 Nov 2023 12:31:13 +0100

* gnu/packages/emacs-xyz.scm (emacs-adwaita-dark-theme): New variable.

Change-Id: Id6e6d0d6aa27e7c1cc6ec0fc11c3a5f09231d751
---
 gnu/packages/emacs-xyz.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index fd965600c8..47df135d83 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1995,6 +1995,27 @@ (define-public emacs-suneater-theme
 theme but now takes more inspiration from the Nano theme.")
     (license license:gpl3+)))
 
+(define-public emacs-adwaita-dark-theme
+  ;; Version 1.1.1 isn't tagged upstream.
+  (package
+    (name "emacs-adwaita-dark-theme")
+    (version "1.1.1")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://gitlab.com/jessieh/adwaita-dark-theme")
+                    (commit "057c39313341907b35c68d2179226886a0c276fd")))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1g7hyg2hfvn24gaw4lca4g8lw10q2wg9nfrgl7pfdggz202m027c"))))
+    (build-system emacs-build-system)
+    (home-page "https://gitlab.com/jessieh/adwaita-dark-theme")
+    (synopsis "Adwaita-inspired dark color scheme for Emacs")
+    (description
+     "This package provides an Adwaita-inspired dark color scheme for Emacs.")
+    (license license:gpl2+)))
+
 (define-public emacs-treepy
   (package
     (name "emacs-treepy")

base-commit: fc6bdaad57bf91609849623c5f485403c030cb49
prerequisite-patch-id: 5e36e77f4fa1848dbd20c2e5d5cec31d2473c2a8
-- 
2.41.0

Message #34 received at 67198-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Tristan Cottam <tristan <at> cott.am>
Cc: Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 67198-done <at> debbugs.gnu.org,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: [bug#67198] [PATCH v3] gnu: Add emacs-adwaita-dark-theme
Date: Sun, 07 Jan 2024 16:04:33 +0100

Hi,

Tristan Cottam <tristan <at> cott.am> skribis:

> * gnu/packages/emacs-xyz.scm (emacs-adwaita-dark-theme): New variable.
>
> Change-Id: Id6e6d0d6aa27e7c1cc6ec0fc11c3a5f09231d751

Finally applied, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.