GNU bug report logs - #67209
29.1; ERC 5.5.0.29.1: /squery doesn't work in server buffer.

Previous Next

Package: emacs;

Reported by: osmkarp <at> gmail.com

Date: Wed, 15 Nov 2023 19:22:02 UTC

Severity: normal

Merged with 67213

Found in version 29.1

Done: "J.P." <jp <at> neverwas.me>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 67209 in the body.
You can then email your comments to 67209 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to emacs-erc <at> gnu.org, bug-gnu-emacs <at> gnu.org:
bug#67209; Package emacs. (Wed, 15 Nov 2023 19:22:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to osmkarp <at> gmail.com:
New bug report received and forwarded. Copy sent to emacs-erc <at> gnu.org, bug-gnu-emacs <at> gnu.org. (Wed, 15 Nov 2023 19:22:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: osmkarp <at> gmail.com
To: bug-gnu-emacs <at> gnu.org
Subject: 29.1; ERC 5.5.0.29.1: /squery doesn't work in server buffer.
Date: Wed, 15 Nov 2023 21:20:54 +0200
In ERC server buffer when writing:
/squery Alis LIST #linux*

it gives:
---
Incorrect arguments. Usage:
/SQUERY arg1
Send a Service Query to the service given as the first word in LINE.

The rest of LINE is the message to send.
---

Next command works well and do what we wanted.
/quote SQUERY Alis :LIST #linux*



In GNU Emacs 29.1 (build 2, x86_64-pc-linux-gnu) of 2023-11-14 built on
 pm
System Description: Debian GNU/Linux trixie/sid

Configured using:
 'configure --prefix=/home/me/root/usr --without-xaw3d --without-xpm
 --without-tiff --without-lcms2 --without-x --with-native-compilation'

Configured features:
GMP GNUTLS LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER SECCOMP
SOUND THREADS TREE_SITTER ZLIB

Important settings:
  value of $LANG: fi_FI.UTF-8
  locale-coding-system: utf-8-unix

Major mode: ERC

Minor modes in effect:
  shell-dirtrack-mode: t
  erc-track-mode: t
  erc-track-minor-mode: t
  erc-ring-mode: t
  erc-netsplit-mode: t
  erc-menu-mode: t
  erc-match-mode: t
  erc-list-mode: t
  erc-fill-mode: t
  erc-stamp-mode: t
  erc-dcc-mode: t
  erc-pcomplete-mode: t
  erc-autojoin-mode: t
  erc-irccontrols-mode: t
  erc-noncommands-mode: t
  erc-move-to-prompt-mode: t
  erc-readonly-mode: t
  erc-networks-mode: t
  server-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: linux
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
/home/me/.emacs.d/elpa/jsonrpc-1.0.17/jsonrpc hides /home/me/root/usr/share/emacs/29.1/lisp/jsonrpc
/home/me/.emacs.d/elpa/eglot-1.14/eglot hides /home/me/root/usr/share/emacs/29.1/lisp/progmodes/eglot
/home/me/.emacs.d/elpa/eldoc-1.14.0/eldoc hides /home/me/root/usr/share/emacs/29.1/lisp/emacs-lisp/eldoc

Features:
(shadow sort mail-extr emacsbug message rfc822 mml mml-sec epa derived
epg rfc6068 epg-config mm-decode mm-bodies mm-encode mailabbrev
gmm-utils mailheader sendmail timezone parse-time shell dired-aux alis
cl-print debug backtrace disp-table misearch multi-isearch find-func
shortdoc erc-button erc-ibuffer ibuf-ext ibuffer ibuffer-loaddefs
erc-log erc-notify erc-page erc-services erc-sound erc-speedbar speedbar
ezimage dframe erc-xdcc help-fns radix-tree mule-util erc-track erc-ring
erc-netsplit erc-menu erc-match erc-list erc-fill erc-stamp erc-dcc
erc-pcomplete pcomplete comint ansi-osc ansi-color ring erc-join
erc-goodies erc pp erc-backend erc-networks erc-common erc-compat
erc-loaddefs yank-media mhtml-mode css-mode smie color js c-ts-common
treesit imenu cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles
cc-align cc-engine cc-vars cc-defs sgml-mode facemenu newst-treeview
tree-widget newst-reader newst-backend iso8601 jka-compr textsec
uni-scripts idna-mapping ucs-normalize uni-confusable textsec-check
gnutls network-stream url-http mail-parse rfc2231 rfc2047 rfc2045
ietf-drums url-gw nsm url-cache url-auth format-spec eww xdg url-queue
thingatpt shr pixel-fill kinsoku url-file image svg xml dom puny mm-url
gnus nnheader gnus-util text-property-search time-date mail-utils range
wid-edit mm-util mail-prsvr term/linux comp regexp-opt comp-cstr
warnings icons rx cl-extra help-mode server dired-x dired dnd
dired-loaddefs info tool-bar package browse-url url url-proxy
url-privacy url-expand url-methods url-history url-cookie
generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse
auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x
map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc
iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook
vc-hooks lisp-float-type elisp-mode tabulated-list replace newcomment
text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow
isearch easymenu timer select mouse jit-lock font-lock syntax font-core
term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
theme-loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads inotify multi-tty
make-network-process native-compile emacs)

Memory information:
((conses 16 605038 75080)
 (symbols 48 21049 0)
 (strings 32 117414 8570)
 (string-bytes 1 5719641)
 (vectors 16 71574)
 (vector-slots 8 1868959 48353)
 (floats 8 433 552)
 (intervals 56 10820 1348)
 (buffers 984 62))




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#67209; Package emacs. (Wed, 15 Nov 2023 20:25:02 GMT) Full text and rfc822 format available.

Message #8 received at 67209 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: osmkarp <at> gmail.com
Cc: 67209 <at> debbugs.gnu.org, emacs-erc <at> gnu.org
Subject: Re: bug#67209: 29.1; ERC 5.5.0.29.1: /squery doesn't work in server
 buffer.
Date: Wed, 15 Nov 2023 12:24:27 -0800
Hi,

osmkarp <at> gmail.com writes:

> In ERC server buffer when writing:
> /squery Alis LIST #linux*
>
> it gives:
> ---
> Incorrect arguments. Usage:
> /SQUERY arg1
> Send a Service Query to the service given as the first word in LINE.
>
> The rest of LINE is the message to send.
> ---
>
> Next command works well and do what we wanted.
> /quote SQUERY Alis :LIST #linux*

Thanks a lot for reporting this. Myself or someone else will look into
it shortly, hopefully in time for ERC 5.6, which is just around the
corner.

Cheers,
J.P.

P.S. Some additional context for the record [1].

[1] https://lists.gnu.org/archive/html/emacs-erc/2022-03/msg00004.html




Merged 67209 67213. Request was from "J.P." <jp <at> neverwas.me> to control <at> debbugs.gnu.org. (Wed, 15 Nov 2023 23:14:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#67209; Package emacs. (Wed, 15 Nov 2023 23:39:02 GMT) Full text and rfc822 format available.

Message #13 received at 67209 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: osmkarp <at> gmail.com
Cc: 67209 <at> debbugs.gnu.org, emacs-erc <at> gnu.org, 67213 <at> debbugs.gnu.org
Subject: Re: bug#67209: 29.1; ERC 5.5.0.29.1: /squery doesn't work in server
 buffer.
Date: Wed, 15 Nov 2023 15:37:38 -0800
osmkarp <at> gmail.com writes:

> Patch for bug#67209
>
> 3714a3715,3717
> > (defalias 'erc-cmd-S #'erc-cmd-SQUERY)
> > (put 'erc-cmd-SQUERY 'do-not-parse-args t)

Thanks. In the future, it'd be preferable if you could follow the
procedure described in CONTRIBUTE [1] for preparing patches so we can
try them out, review them, and install them with relative ease. Also, as
mentioned in #erc, I've merged this patch's bug with the original report
(bug#67209), since we don't really differentiate between patches and
issues on this tracker. So, if you're up for it, please try re-exporting
your patch in the recommended fashion and attaching it in a reply-all to
this email. Thanks again!


[1] https://git.savannah.gnu.org/cgit/emacs.git/tree/CONTRIBUTE




Information forwarded to emacs-erc <at> gnu.org, bug-gnu-emacs <at> gnu.org:
bug#67209; Package emacs. (Fri, 17 Nov 2023 11:34:01 GMT) Full text and rfc822 format available.

Message #16 received at 67209 <at> debbugs.gnu.org (full text, mbox):

From: Osmo Karppinen <osmkarp <at> gmail.com>
To: 67209 <at> debbugs.gnu.org
Subject: bug#67209 [PATCH] /squery doesn't work in server buffer
Date: Fri, 17 Nov 2023 13:33:28 +0200
[Message part 1 (text/plain, inline)]
Tags: patch

Hello,

Here is patch for /squery bug descriped earlier posts. Setting
erc-cmd-SQUERY function property do-not-parse-args to true will
fix that bug.

Repository revision: c710bf48408aece9865eb07081ca93d905e3983d
Repository branch: master
System Description: Debian

[0001-Fix-erc-cmd-SQUERY-bug-by-setting-property-do-not-pa.patch (text/x-diff, attachment)]

Reply sent to "J.P." <jp <at> neverwas.me>:
You have taken responsibility. (Sat, 18 Nov 2023 22:16:02 GMT) Full text and rfc822 format available.

Notification sent to osmkarp <at> gmail.com:
bug acknowledged by developer. (Sat, 18 Nov 2023 22:16:02 GMT) Full text and rfc822 format available.

Message #21 received at 67209-done <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: Osmo Karppinen <osmkarp <at> gmail.com>
Cc: emacs-erc <at> gnu.org, 67209-done <at> debbugs.gnu.org
Subject: Re: bug#67209: [PATCH] /squery doesn't work in server buffer
Date: Sat, 18 Nov 2023 14:15:24 -0800
Osmo Karppinen <osmkarp <at> gmail.com> writes:

> Tags: patch
>
> Hello,
>
> Here is patch for /squery bug descriped earlier posts. Setting
> erc-cmd-SQUERY function property do-not-parse-args to true will
> fix that bug.
>
> Repository revision: c710bf48408aece9865eb07081ca93d905e3983d
> Repository branch: master
> System Description: Debian

This has been installed on master as

  64174ae148d * Fix command-line parsing for erc-cmd-SQUERY
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=64174ae1

Thanks and closing.




Reply sent to "J.P." <jp <at> neverwas.me>:
You have taken responsibility. (Sat, 18 Nov 2023 22:16:02 GMT) Full text and rfc822 format available.

Notification sent to osmkarp <at> gmail.com:
bug acknowledged by developer. (Sat, 18 Nov 2023 22:16:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 17 Dec 2023 12:24:07 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 145 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.