GNU bug report logs - #67211
[PATCH] gnu: Add emacs-adwaita-dark-theme

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 67211 in the body.
You can then email your comments to 67211 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tristan Cottam <tristan <at> cott.am>
To: guix-patches <at> gnu.org
Cc: Tristan Cottam <tristan <at> cott.am>
Subject: [PATCH] gnu: Add emacs-adwaita-dark-theme
Date: Wed, 15 Nov 2023 22:43:54 +0100

* gnu/packages/emacs-xyz.scm (emacs-adwaita-dark-theme): New variable.

Change-Id: Id6e6d0d6aa27e7c1cc6ec0fc11c3a5f09231d751
---

> FWIW, changing the Version keyword in the header is a release. Also, it
> has the benefit of making the version number more meaningful.

I agree, I had missed that version bump commit. However, it isn't in fact the
last one, so I left the rest as it is.

 gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index be7ffd1f37..443f315f23 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1995,6 +1995,29 @@ (define-public emacs-suneater-theme
 theme but now takes more inspiration from the Nano theme.")
     (license license:gpl3+)))
 
+(define-public emacs-adwaita-dark-theme
+  (let ((commit "a97d5d5f5657a52c3b4c4b146b4d307dfb1a7a74")
+        (revision "0"))
+    (package
+      (name "emacs-adwaita-dark-theme")
+      (version (git-version "1.1.1" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://gitlab.com/jessieh/adwaita-dark-theme")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "0g8fjqmz805fhqspbzmpvb90kpzwigl4z56bkykywgy2cwb9ljzh"))))
+      (build-system emacs-build-system)
+      (home-page "https://gitlab.com/jessieh/adwaita-dark-theme")
+      (synopsis "Adwaita-inspired dark color scheme for Emacs")
+      (description
+       "adwaita-dark-theme is an Adwaita-inspired dark color scheme for
+Emacs.")
+      (license license:gpl2+))))
+
 (define-public emacs-treepy
   (package
     (name "emacs-treepy")

base-commit: bd0f2173210416e86281c1de8789e7cdab66dd57
prerequisite-patch-id: 5e36e77f4fa1848dbd20c2e5d5cec31d2473c2a8
-- 
2.41.0

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Tristan Cottam via Guix-patches via <guix-patches <at> gnu.org>
Cc: Tristan Cottam <tristan <at> cott.am>,
 Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>, 67211 <at> debbugs.gnu.org,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: [bug#67211] [PATCH] gnu: Add emacs-adwaita-dark-theme
Date: Thu, 16 Nov 2023 12:58:17 +0100

Hello,

Tristan Cottam via Guix-patches via <guix-patches <at> gnu.org> writes:

> I agree, I had missed that version bump commit. However, it isn't in fact the
> last one, so I left the rest as it is.

My point is that is it usually better to package version bumps rather
than arbitrary commits. IOW, I'd rather drop the revision and package
057c39313341907b35c68d2179226886a0c276fd instead.

> +      (description
> +       "adwaita-dark-theme is an Adwaita-inspired dark color scheme for
> +Emacs.")

You didn't change this. Is it intentional?

Regards,
-- 
Nicolas Goaziou

Message #14 received at 67211 <at> debbugs.gnu.org (full text, mbox):

From: Tristan Cottam <tristan <at> cott.am>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>,
 "67211 <at> debbugs.gnu.org" <67211 <at> debbugs.gnu.org>
Subject: Re: [bug#67211] [PATCH] gnu: Add emacs-adwaita-dark-theme
Date: Thu, 16 Nov 2023 15:38:32 +0000

I accidentally sent a reply to #67198 to guix-patches <at> gnu.org, resulting in
this new issue. How can I close this?

Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Tristan Cottam via Guix-patches via <guix-patches <at> gnu.org>
Cc: Tristan Cottam <tristan <at> cott.am>,
 "67211 <at> debbugs.gnu.org" <67211 <at> debbugs.gnu.org>
Subject: Re: [bug#67211] [PATCH] gnu: Add emacs-adwaita-dark-theme
Date: Thu, 16 Nov 2023 20:57:04 +0100

Hello,

Tristan Cottam via Guix-patches via <guix-patches <at> gnu.org> writes:

> I accidentally sent a reply to #67198 to guix-patches <at> gnu.org, resulting in
> this new issue. How can I close this?

You can send an empty mail to <NNN-done <at> debbugs.gnu.org> where NNN is
the number of the issue you created.

Regards,
-- 
Nicolas Goaziou

Message #25 received at 67211-done <at> debbugs.gnu.org (full text, mbox):

From: Tristan Cottam <tristan <at> cott.am>
To: "67211-done <at> debbugs.gnu.org" <67211-done <at> debbugs.gnu.org>
Subject: Re: [bug#67211] [PATCH] gnu: Add emacs-adwaita-dark-theme
Date: Thu, 16 Nov 2023 20:35:27 +0000

> You can send an empty mail to <NNN-done <at> debbugs.gnu.org> where NNN is
> the number of the issue you created.

Great, thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.