GNU bug report logs - #67214
[PATCH] services: xvnc: Do not specify display number when using inetd

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 67214 in the body.
You can then email your comments to 67214 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Thompson, David" <dthompson2 <at> worcester.edu>
To: Ryan Prior via Guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] services: xvnc: Do not specify display number when using inetd
Date: Wed, 15 Nov 2023 17:53:46 -0500

[Message part 1 (text/plain, inline)]

Hey everyone,

I've been struggling to get VNC working with multiple users. Upon
digging into it I realized that it's because the X display number is
fixed in the xvnc service, even when in inetd mode, so only the first
user who connects gets a desktop and everyone else gets an error. By
omitting the display number when using inetd, xvnc just picks an
unused display and I'm now able to log in with multiple user accounts.

The patch is a one-liner and hopefully not very controversial. :)

- Dave

[0001-services-xvnc-Do-not-specify-display-number-when-usi.patch (text/x-patch, attachment)]

Message #8 received at 67214 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: "Thompson, David" <dthompson2 <at> worcester.edu>
Cc: 67214 <at> debbugs.gnu.org
Subject: Re: [bug#67214] [PATCH] services: xvnc: Do not specify display
 number when using inetd
Date: Sat, 25 Nov 2023 19:11:25 +0100

Hello David,

> * gnu/services/vnc.scm (xvnc-configuration->command-line-arguments): Omit X
> display number when inetd? is #t.

Seems fair, I think you can go ahead.

Thanks,

Mathieu

Message #13 received at 67214-done <at> debbugs.gnu.org (full text, mbox):

From: "Thompson, David" <dthompson2 <at> worcester.edu>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 67214-done <at> debbugs.gnu.org
Subject: Re: [bug#67214] [PATCH] services: xvnc: Do not specify display number
 when using inetd
Date: Mon, 27 Nov 2023 11:03:03 -0500

Hey Mathieu,

On Sat, Nov 25, 2023 at 1:11 PM Mathieu Othacehe <othacehe <at> gnu.org> wrote:
>
>
> Hello David,
>
> > * gnu/services/vnc.scm (xvnc-configuration->command-line-arguments): Omit X
> > display number when inetd? is #t.
>
> Seems fair, I think you can go ahead.

Thanks for the review! Pushed as commit
dce3672f5a8eb440ae61a334384423d1e2ff5e65.

- Dave

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.