GNU bug report logs - #67235
[PATCH] Fix finding test name with erts-run-test with point-char

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 67235 in the body.
You can then email your comments to 67235 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Noah Peart <noah.v.peart <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix finding test name with erts-run-test with point-char
Date: Thu, 16 Nov 2023 18:12:52 -0800

[Message part 1 (text/plain, inline)]

Tags: patch


* lisp/progmodes/erts-mode.el(erts-run-test): Fix finding the test name
when Point-Char is defined

Bug: Interactively running a test with `erts-run-test` fails when the
test has a Point-Char definition. When there is a Point-Char definition,
`erts-run-test` calls `(erts-mode--preceding-spec "Point-Char")`,
overwriting the match data expected by `ert-test--erts-test`.

Recipe to reproduce:
Try `M-x erts-run-test` in the indent.erts test from
test/lisp/progmodes/typescript-ts-mode-resources/indent.erts:
[[The following is in `erts-mode`]]

Code:
  (lambda ()
    (setq indent-tabs-mode nil)
    (setq typescript-ts-mode-indent-offset 2)
    (typescript-ts-mode)
    (indent-region (point-min) (point-max)))

Point-Char: |

Name: Basic indentation

=-=
const foo = () => {
  console.log("bar");
  if (x) {
    return y;
  } else if (y) {
    return u;
  }
  return baz.x()
    ? true
    : false;
}
=-=-=

In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.33, cairo version 1.16.0) of 2023-11-15 built on noah-X580VD
Repository revision: 1a1f47e4a1fb70e6810f9eabd0f1826b71a2bcb0
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Ubuntu 22.04.3 LTS

Configured using:
 'configure --prefix=/usr/local --with-modules --with-tree-sitter
--with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls
--with-json --with-mailutils --with-jpeg --with-png --with-rsvg
--with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12
CXX=gcc-12'

[Message part 2 (text/html, inline)]

[erts-run-test.patch (text/x-patch, attachment)]

Message #10 received at 67235-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Noah Peart <noah.v.peart <at> gmail.com>
Cc: 67235-done <at> debbugs.gnu.org
Subject: Re: bug#67235: [PATCH] Fix finding test name with erts-run-test with
 point-char
Date: Sat, 25 Nov 2023 11:43:44 +0200

> From: Noah Peart <noah.v.peart <at> gmail.com>
> Date: Thu, 16 Nov 2023 18:12:52 -0800
> 
> Tags: patch
> 
> * lisp/progmodes/erts-mode.el(erts-run-test): Fix finding the test name
> when Point-Char is defined
> 
> Bug: Interactively running a test with `erts-run-test` fails when the
> test has a Point-Char definition. When there is a Point-Char definition,
> `erts-run-test` calls `(erts-mode--preceding-spec "Point-Char")`,
> overwriting the match data expected by `ert-test--erts-test`.
> 
> Recipe to reproduce:
> Try `M-x erts-run-test` in the indent.erts test from
> test/lisp/progmodes/typescript-ts-mode-resources/indent.erts:
> [[The following is in `erts-mode`]]

Thanks, installed on master and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.