Received: (at 67241) by debbugs.gnu.org; 6 Jan 2025 17:42:49 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 06 12:42:49 2025
Received: from localhost ([127.0.0.1]:39916 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tUr7o-0000qz-MK
for submit <at> debbugs.gnu.org; Mon, 06 Jan 2025 12:42:49 -0500
Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]:44280)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <zimon.toutoune@HIDDEN>)
id 1tUr7l-0000qU-9g
for 67241 <at> debbugs.gnu.org; Mon, 06 Jan 2025 12:42:45 -0500
Received: by mail-wm1-x333.google.com with SMTP id
5b1f17b1804b1-436345cc17bso106196425e9.0
for <67241 <at> debbugs.gnu.org>; Mon, 06 Jan 2025 09:42:45 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1736185364; x=1736790164; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:message-id:date:references
:in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id
:reply-to; bh=HEy2uT1+lXCpdGVmpo3VqfFKS4+ZSCThcC7NDBUXAmg=;
b=lbvlM72eEnlkInNZsho+NZU9YIZNUaAxLgLZbVvnV+NRwOHpyBNANMOk9Gq+yFQNY5
kcFxhEfJvDBtokU5fOm/hmquTx3IWO27vtWFd7QgO5ulQgatnJLISwmPi4vibqxE612v
EtmmgfqMEYwZcUW81cquG0nqJLwuvTveJiwpB/MivXTSmgH1FR4/Ny6M/hiWPE/wE5QV
+fiKmHSxwdg9f/UvuQd7oiJYXE9t30KVo2IXuoQKaL8sd96GC+Is0thUoG/4g35r5Tkj
x4T3G5Z7bm6W+bMYhgnWL222jfu9ejaL06bud92iuhQblym00/0OBJgxMRsW2HMARSaa
PZGQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1736185364; x=1736790164;
h=content-transfer-encoding:mime-version:message-id:date:references
:in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=HEy2uT1+lXCpdGVmpo3VqfFKS4+ZSCThcC7NDBUXAmg=;
b=FWnPOD8ruDio/tA8VZVckKWBNmY/HVqCepwVKWYq0bZNYrFlf9TYj8kVPWkkBaHeHG
Oz7fLdeNKk/Qz0zE+UpyHap4rwvUIZLrpRIPd/Bh6NVPvYhRhvMLbu2zoskUvrJydt45
p+uDVKm1/gjjtiu2NNC9/BFI/u/rB/5PaPxklKTrFz0me/yZ/1sY40dlM+eiuWseBNYS
8E7J8JV2h4qljB68Qhii1jk9N60yWHrMsv7K+pANVesex0iVe3cvSLagdHaC5x3RIA8A
4AUy4p2vQDxlGB9TFJ8NYx9ai8vEilgitS35KAk0FMgScj0P2/BH9PYKCvndIr0O55TK
rx5Q==
X-Gm-Message-State: AOJu0Yyz8ELB63dIgNHfqrtY5HvFQt5gf1LW/0ITPY/fK6K1beX8i7a5
Y1dKfiqnWr0JJS07xqRO3yuHD1+pMbH9y7m0qrXJRdBxvGduBa6VXHElPA==
X-Gm-Gg: ASbGncsbzdRRDIajQcxdKYGI3D+AElQQnXWusXssMmQJ6zqTRjvDTsyl1YjsOlPCy/v
6YjIXyVLZGZGdmzpDIT9KZ2ytf02GGLEm7keIGQCllgsTafPnHgtkCTA60+L0XTBzW3z4W/oxUI
tMA5FgiU0sEJaYFgR/+bKXQqOG4Ph9OinRVLqjnDPgcqrwj84UEbo8eMX177L9xKsgN/H+7XPKm
ZBa27isPg+xHSPLe4YOCMOJeYxNal7DkWfA9k4P8WL64YwBhDJOipZ5IG62g7jt8NrtMwwlouMQ
2D/UG886+HMc76nycfRLJ96yS8ErdCgBG+/WyYaxsw==
X-Google-Smtp-Source: AGHT+IF1Pm03pCIP6yI9CqLXFf80bdah9e8/810A5TzhIoOStlKUN4nhguIjrnslKMkekmesAnfAew==
X-Received: by 2002:a05:600c:3554:b0:434:9934:575 with SMTP id
5b1f17b1804b1-436686461d6mr516491175e9.16.1736185363906;
Mon, 06 Jan 2025 09:42:43 -0800 (PST)
Received: from lili (roam-nat-fw-prg-194-254-61-47.net.univ-paris-diderot.fr.
[194.254.61.47]) by smtp.gmail.com with ESMTPSA id
ffacd0b85a97d-38a1c8acabbsm48025625f8f.93.2025.01.06.09.42.43
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 06 Jan 2025 09:42:43 -0800 (PST)
From: Simon Tournier <zimon.toutoune@HIDDEN>
To: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Subject: Re: bug#67241: [PATCH] guix-install.sh: Add message about Info reader.
In-Reply-To: <87frmkkssn.fsf@HIDDEN>
References: <87h68d6k4e.fsf@HIDDEN>
<e8022e114a050910d879193b9ec317826f768278.1731743586.git.zimon.toutoune@HIDDEN>
<87r068uyn5.fsf@HIDDEN> <87ldwf7bml.fsf@HIDDEN>
<87frmkkssn.fsf@HIDDEN>
Date: Mon, 06 Jan 2025 18:37:23 +0100
Message-ID: <875xmryhbg.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 67241
Cc: 67241 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Hi Maxim,
On Thu, 19 Dec 2024 at 16:58, Maxim Cournoyer <maxim.cournoyer@HIDDEN> w=
rote:
> Hm. I agree duplication is not nice. Probably a naming issue ;-)
Arf, as we know: =C2=AB There are only two hard things in Computer Science:
cache invalidation and naming things. =C2=BB :-)
> According to git blame these lines were also authored by you 4 years
> ago, ha!
Ah, you got me! ;-) Bah I am consistent.
> It checks the exit status instead of the captured string output. While
> it's not that bad in that case, in general I find checking for the exit
> status a much more reliable and clean option.
Thanks for explaining. I will re-send that way. However, I still think
that=E2=80=99s the same from some Bash point of view=E2=80=A6
>> Both $() and "" used in tandem makes the test sound, from my
>> understanding.
>
> Hm. Is [ "something" ] true and [ "" ] false? Apparently it is, but
> I'd argue that's not very clear, especially when there are explicit test
> operations to check for an non-empty or empty string (test -n and test
> -z).
=E2=80=A6and welcome to weird Bash. ;-) Maybe I have misread, from my
understanding, this:
if [ "$(type -P foo)" ]
is equivalent to:
if test -n $(type -P foo)
and also equivalent to:
if type -P foo >/dev/null
And I know nothing about internals; maybe some type conversion are
avoided with the latter and some cycles are saved?
Well, it appears to me a matter of taste. :-) I find the former easier
to parse than the latter. But I also fine with the latter; let do that.
Cheers,
simon
bug-guix@HIDDEN:bug#67241; Package guix.
Full text available.
Received: (at 67241) by debbugs.gnu.org; 19 Dec 2024 08:00:07 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Dec 19 03:00:06 2024
Received: from localhost ([127.0.0.1]:37315 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tOBS2-0000P6-Ha
for submit <at> debbugs.gnu.org; Thu, 19 Dec 2024 03:00:06 -0500
Received: from mail-pf1-f173.google.com ([209.85.210.173]:61792)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <maxim.cournoyer@HIDDEN>) id 1tOBS0-0000Nw-6H
for 67241 <at> debbugs.gnu.org; Thu, 19 Dec 2024 03:00:04 -0500
Received: by mail-pf1-f173.google.com with SMTP id
d2e1a72fcca58-725abf74334so434414b3a.3
for <67241 <at> debbugs.gnu.org>; Thu, 19 Dec 2024 00:00:04 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1734595138; x=1735199938; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=aETYbzidIDrahpWFzP9k9cE3r79yfP8+LQ5YexdUNJM=;
b=HDesbOqDPGV5ml3N/9M27cZCepDkoxlJrFcrOPsYbNYC93W+c+lhLdDds7EYF3O2df
aSOHbyxSl+dWw+Viy3FWEJ07uZskTBnNTF3puGCD1MOmRWKR3CHAPMCooT4STV3J5OJa
fJTKeiTP4qMxS80PDW/9gThCjMDpMzx2DnW18oWmwJJtojquQ1bY0h/jpwc+NTwA/9P8
Jc/CgDHQYI8w1mG4HbIILxWp2/NNvcP0NwGmEDuqNiizJM+Ub+MOu0DnPdtzFjitkV4D
BV2gMEvZbbMvKnj32y5k37NfWKpgtcPR/iGCmYyDXnSXF1enEuL7tq3tRHuowSzqaKn9
AbxA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1734595138; x=1735199938;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:x-gm-message-state:from
:to:cc:subject:date:message-id:reply-to;
bh=aETYbzidIDrahpWFzP9k9cE3r79yfP8+LQ5YexdUNJM=;
b=tUS3lb3zRaYg8oRD6hzoLrsebPYAoU0ndy0pbeSitU6saC2eS4s381qTaDFao0CCNS
k7ldX8WMRm7nfllzj+rDWZstGLDpWUAl/HO5hyfqKCZWlQqewCy+gfIMV2Ce9EU0jMY0
6CTR9yqiUkJsBwv+83llljulPctKy/ynZ5EfK2JVVbYUsJdcDUPNrkJPtbyuRujj/v2h
HKJej3iadrHhwsKYWcFS36V/gAVuF2go3uoPcmjaCXkg0b61Sk+ic1+V49jmHtbwujLO
bEX9612iYyf7ZKpLCVaitfHMhmpNg/R5uObuJbXBwmhUQavyMq/lUkJxoAhypMeyUDkV
QfYA==
X-Gm-Message-State: AOJu0YxWvwkJX0qnA4gJDDs7tOmeqC5YK921dbkkQ+4djX65ACf242Jd
j9jdYz3+JiRqDNbKZQRzYy+rn5YtlwN9CIgXPzkJo1mB6nSlgNlfoGOzXqzHxmM=
X-Gm-Gg: ASbGncsmt3nm01b4Q4Eb8oSIzIDx+tM0Tj/JcCLJEQ/nyr+W1xERa3TcsdDAJXXeKi7
mSVuitoG8rQfvU6WcEiV/Fs4v5F04i1cMUVTCGP2yqjO9FDr6ZkB0Jyj9Npwol+ejyHC0FSM6wd
FwioWQaGNSSIyk9+O8UH1KbMM9qWIrgkJ6teNXNLDpuvPcC3Ia+RsxLz1dceVyrczzyExpxKJ1b
yZiXWvC9lLn5bGYSCO4okFhhOthGBice4x9/BtTC0vXpPn0y69sBA==
X-Google-Smtp-Source: AGHT+IFOjfXVfwcaukdnaiDoeCuGKqeBaxk1l/SLtncWWk4Ku9Jn8B2wit1w1ng0k1Cwt/ZluseT4A==
X-Received: by 2002:a05:6a20:43a9:b0:1e1:9fef:e958 with SMTP id
adf61e73a8af0-1e5b4600269mr9006810637.9.1734595137749;
Wed, 18 Dec 2024 23:58:57 -0800 (PST)
Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89])
by smtp.gmail.com with ESMTPSA id
d2e1a72fcca58-72aad8fabc9sm704724b3a.141.2024.12.18.23.58.56
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 18 Dec 2024 23:58:57 -0800 (PST)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: Simon Tournier <zimon.toutoune@HIDDEN>
Subject: Re: bug#67241: [PATCH] guix-install.sh: Add message about Info reader.
In-Reply-To: <87ldwf7bml.fsf@HIDDEN> (Simon Tournier's message of "Mon, 16
Dec 2024 18:58:58 +0100")
References: <87h68d6k4e.fsf@HIDDEN>
<e8022e114a050910d879193b9ec317826f768278.1731743586.git.zimon.toutoune@HIDDEN>
<87r068uyn5.fsf@HIDDEN> <87ldwf7bml.fsf@HIDDEN>
Date: Thu, 19 Dec 2024 16:58:48 +0900
Message-ID: <87frmkkssn.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 67241
Cc: 67241 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Hi Simon,
Simon Tournier <zimon.toutoune@HIDDEN> writes:
> Hi Maxim,
>
> On Mon, 16 Dec 2024 at 11:53, Maxim Cournoyer <maxim.cournoyer@HIDDEN>=
wrote:
>
>>> +_info()
>>> +{
>>> + if [ "$(type -P info)" ]; then
>>> + _msg "$1"
>>> + else
>>> + _msg "${WAR}Please install Info reader; see package 'info-read=
er'"
>>> + _msg "$1"
>>> + fi
>>> +}
>>
>> It seems odd to me to "overload" _msg into _info that deals with some si=
de
>> effect; I'd rather see this conditional explicit at the message printing
>> site.
>
> It was to avoid the duplication of the exact same conditional with the
> exact same message.
>
> I do not have an opinion=E2=80=A6
Hm. I agree duplication is not nice. Probably a naming issue ;-)
>> Also, your test is testing for the empty string when info is not found,
>> not the exist status, which is wrong.
>
> Please note that the script already uses:
>
> if [ "$(type -P pidof)" ]; then
> if [ ! "$(pidof nscd)" ]; then
>
> And I have only respected the same. :-)
According to git blame these lines were also authored by you 4 years
ago, ha!
>> not the exist status, which is wrong. I think you meant something like:
>>
>> --8<---------------cut here---------------start------------->8---
>> if type -P info >/dev/null then [...]; fi
>> --8<---------------cut here---------------end--------------->8---
>
> Well, I am not a Bash expert but I guess that=E2=80=99s the same result in
> practise, no?
It checks the exit status instead of the captured string output. While
it's not that bad in that case, in general I find checking for the exit
status a much more reliable and clean option.
> Both $() and "" used in tandem makes the test sound, from my
> understanding.
Hm. Is [ "something" ] true and [ "" ] false? Apparently it is, but
I'd argue that's not very clear, especially when there are explicit test
operations to check for an non-empty or empty string (test -n and test
-z).
>> But this got me curious again... could we instead automate the
>> installation of info post-installation?
>
> It appears to me unrelated to this change at hand. :-)
It's related in that if the user opted to install 'info-reader' (on by
default), we wouldn't have to warn anything about, but yes, we can do so
later if you prefer, as I expect it's not that trivial.
I don't have strong feelings about the change as-is anymore, but I may
refactor the type -P checks to use the alternative style outlined above,
if you don't mind.
--=20
Thanks,
Maxim
bug-guix@HIDDEN:bug#67241; Package guix.
Full text available.
Received: (at 67241) by debbugs.gnu.org; 17 Dec 2024 18:07:29 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Dec 17 13:07:29 2024
Received: from localhost ([127.0.0.1]:60208 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tNbyj-0005Y5-8Q
for submit <at> debbugs.gnu.org; Tue, 17 Dec 2024 13:07:29 -0500
Received: from mail-wr1-f52.google.com ([209.85.221.52]:55427)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <zimon.toutoune@HIDDEN>) id 1tNbyh-0005Xr-06
for 67241 <at> debbugs.gnu.org; Tue, 17 Dec 2024 13:07:27 -0500
Received: by mail-wr1-f52.google.com with SMTP id
ffacd0b85a97d-37ed3bd6114so2750564f8f.2
for <67241 <at> debbugs.gnu.org>; Tue, 17 Dec 2024 10:07:26 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1734458781; x=1735063581; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:message-id:date:references
:in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id
:reply-to; bh=vKSARIDwng3CgSgv0tRzjDN2EoR5Rcd1EEaqgBmAWxA=;
b=cmY7Jzwl44tIV2Z7NaxMrfYFTBjHoUYfiHwEc+uJ1XpUsNEjWaJEvKO2k/z4QLhb13
9KgJt1RMCH7R1kQ0Fhf+IcnXnvT+sorcOtpmcbOdHbccgNAn6E7NB7XfjpBhMT6HCOb5
zHeqeEdRmunsv6hvWHNDB8LBwKbPzbugVpXfhQHHPwdwiY52yrufo9ZkwJm+sQg6v5mK
vru9SHKihZpUrZk3v2pq9qCpSBs4r95lLO98/zwj41M+px8w8scs5NBsBv+tMh1CGLu3
ircf/pbvleWATj6fWda9y8zGfa2hRBVAqo0tbWg0tBBtvQ528ZwZ8rkzUsLGAMBdmJuH
Tj/Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1734458781; x=1735063581;
h=content-transfer-encoding:mime-version:message-id:date:references
:in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=vKSARIDwng3CgSgv0tRzjDN2EoR5Rcd1EEaqgBmAWxA=;
b=PpXh6jz7uw/LdbaBuurEAkqF8OIXsCae9ZFPmQSk4m/eyNdqqadlPSlxQgQG2rzVrT
TZZbIihrbVZYUWgTXAoyfR/qllLr7n0CMnHJWFoIJI95dmEI6oL6jUlJsXFvLPrEpHZl
9sVhtZ8pPaIODEHa84VeWeedRogimACwRzBbi0OARtcsQsrKIcUnrMBN4LrIlvo0QWBU
fRSUh9KfzRd62Ia9hv3on7bteXLOOdpauGDNfjFTDux5xRX64Q/riw1ha4vBBuYQqFRW
agN3LhxrNU2yhuEd6QBoNO6ccSoZGCRWixRKaLIjf++++KJv2WxbwdXt+HXjV1qbhKsW
786A==
X-Gm-Message-State: AOJu0YycE8b6aj4JMJizZKb3h4FDYiwpjgjjzAPUNTZFTOzRLgdZou8W
/3RwatVB9wDxaKzW9TxJIB8TrAEQZOfWjmRMVF40osV9SDyw319g+QDmew==
X-Gm-Gg: ASbGncu+Uie4rNbA6q0sq3yFVjKhSXsvEhK+cQ1wsZkgow+SKCWeDy0eT+jIEcnfaU1
Tw3OIWLj8dI5ZS3DK+LCb4kMaMKS8XbpLOGrwrGAOrnR/xSf2aaPR6ReV2bOLtxilPoKNsU69in
/h6MMgZBqAefNllxg6f+NsYIvspoWHwJMuHfqU5xXwrWnLYsNIumaopPIyxXFWQtSQDVdoZ75UQ
rFPx220MRyk8xg6nNJ2p2dpmccH6GsMPUSMZYAMUNw1NiPwMaBpoqne4y3LcToP/3tENkUNDBWH
6J5RFCRP
X-Google-Smtp-Source: AGHT+IEC8xkKf/Wl3rHrngoxjkldxjSbKUod43H+/M/N3SpxyJDZTYaGBPDDgVjj490dMaYtm0vwHw==
X-Received: by 2002:a5d:64a8:0:b0:385:f349:ffef with SMTP id
ffacd0b85a97d-3888e0b8723mr15751849f8f.41.1734458780877;
Tue, 17 Dec 2024 10:06:20 -0800 (PST)
Received: from lili (33.148.22.93.rev.sfr.net. [93.22.148.33])
by smtp.gmail.com with ESMTPSA id
ffacd0b85a97d-388c8046c05sm11979269f8f.73.2024.12.17.10.06.19
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 17 Dec 2024 10:06:20 -0800 (PST)
From: Simon Tournier <zimon.toutoune@HIDDEN>
To: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Subject: Re: bug#67241: [PATCH] guix-install.sh: Add message about Info reader.
In-Reply-To: <87r068uyn5.fsf@HIDDEN>
References: <87h68d6k4e.fsf@HIDDEN>
<e8022e114a050910d879193b9ec317826f768278.1731743586.git.zimon.toutoune@HIDDEN>
<87r068uyn5.fsf@HIDDEN>
Date: Mon, 16 Dec 2024 18:58:58 +0100
Message-ID: <87ldwf7bml.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.5 (/)
X-Debbugs-Envelope-To: 67241
Cc: 67241 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.5 (/)
Hi Maxim,
On Mon, 16 Dec 2024 at 11:53, Maxim Cournoyer <maxim.cournoyer@HIDDEN> w=
rote:
>> +_info()
>> +{
>> + if [ "$(type -P info)" ]; then
>> + _msg "$1"
>> + else
>> + _msg "${WAR}Please install Info reader; see package 'info-reade=
r'"
>> + _msg "$1"
>> + fi
>> +}
>
> It seems odd to me to "overload" _msg into _info that deals with some side
> effect; I'd rather see this conditional explicit at the message printing
> site.
It was to avoid the duplication of the exact same conditional with the
exact same message.
I do not have an opinion=E2=80=A6
> Also, your test is testing for the empty string when info is not found,
> not the exist status, which is wrong.
Please note that the script already uses:
if [ "$(type -P pidof)" ]; then
if [ ! "$(pidof nscd)" ]; then
And I have only respected the same. :-)
> not the exist status, which is wrong. I think you meant something like:
>
> --8<---------------cut here---------------start------------->8---
> if type -P info >/dev/null then [...]; fi
> --8<---------------cut here---------------end--------------->8---
Well, I am not a Bash expert but I guess that=E2=80=99s the same result in
practise, no?
Both $() and "" used in tandem makes the test sound, from my
understanding.
> But this got me curious again... could we instead automate the
> installation of info post-installation?
It appears to me unrelated to this change at hand. :-)
> If yes, we should also automate
> the installation of glibc-locales, using prompts that the user can
> accept or decline like for the other configuration choices.
Yeah why not, but let open another issue for tracking that, because
that=E2=80=99s not necessary straightforward since it=E2=80=99s on the top =
of different
distros.
Cheers,
simon
bug-guix@HIDDEN:bug#67241; Package guix.
Full text available.
Received: (at 67241) by debbugs.gnu.org; 16 Dec 2024 02:54:36 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Dec 15 21:54:36 2024
Received: from localhost ([127.0.0.1]:52890 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tN1Fj-0003AV-Ct
for submit <at> debbugs.gnu.org; Sun, 15 Dec 2024 21:54:35 -0500
Received: from mail-pl1-f169.google.com ([209.85.214.169]:49474)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <maxim.cournoyer@HIDDEN>) id 1tN1Ff-0003AL-8I
for 67241 <at> debbugs.gnu.org; Sun, 15 Dec 2024 21:54:32 -0500
Received: by mail-pl1-f169.google.com with SMTP id
d9443c01a7336-2166f1e589cso36977115ad.3
for <67241 <at> debbugs.gnu.org>; Sun, 15 Dec 2024 18:54:31 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1734317610; x=1734922410; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=3umyfD08AjsnAfpXt8m7rZ5rm6+obJwjH73SOP3O1po=;
b=WhZli1HGYv3DdoL2On0E4YFmupaDj3SJnoqrE50gP1UAEXyRzUacwgjyzK0gE6oXgv
nhT9KPqXh4XpYNypUEXeztiDgpObJkwVTEmtRE1Udypm5xdal8APL910ojzQrgKq0GM1
Wcwim4oDrmVhcB9g1hhatQHddFVwFTIDTYdcAHWHig135ZIvEHtzC2xLvdSfTDqyateZ
bM7xfqCoudaIVx9P14mc+SNxH6MxxLyn8yPOShHr5wZeqjrWpOuWFIyt762SJAJ1prUR
gvhXELalltbjPX/o4Ncs2Gm8qKccVk10Krqopa0HrpmQ2T1ipX6zjaxpWoBKIZdiR+Nn
e3cw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1734317610; x=1734922410;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:x-gm-message-state:from
:to:cc:subject:date:message-id:reply-to;
bh=3umyfD08AjsnAfpXt8m7rZ5rm6+obJwjH73SOP3O1po=;
b=kYzw9z47RdtsdrDFUgtr/2HWbLq1fuqdPClzAhtovCDY0+ZeUCc0m2VdZ+vGnJk9UC
cURGVBpyIJ9h/iU8IQf9Vg8irApMATj8CAPuwBi/pUc+gRvpEKcjJhOc91OJTffvOrn/
FDO9zxdpDYYBCZN6tqvhCwSV+5OzC36FvbvmLfw5zEJ6ScBXdGqIbln6z2fcZ5WOlvtY
FJCikR4m7FuJEGuyVL6KcaElW8iULRmak45TM0fcslJCSa0g+gU8xm4lhmTubAKeAVxp
+lzBuQpNJYJZub/eu1YKcQ4mUudx+az9LZXBZAUez5HkBBQ/7f+/Q6T9okDve5wB+dBl
xGGw==
X-Gm-Message-State: AOJu0YyDGjJTSwEOeJ5VLbaAOX97jzXiio2HaCz+YyuWba3MDasToAEw
rGxTSapc0EZrCJTH3yuqSCxzVBKu1FBJ9JSRqpX9b03w7ZxlvuA+6XcZRCzN
X-Gm-Gg: ASbGncug6FcuH/B1YmFFliG5a5uLWwOM2T95hn/m+IWiBPecG3hfOcoPoBhAMCsoMqV
9CGT2CE7x/2tIwNMzyiLdV31DyD10ooLiJYg9JoRzq62oJYi48pzk0uNSkwQPnltwT3p8bhE+fx
aUS7YHQLgBMYIzqtjDJe9u0nzfTRyQr/wXeer098nMA9xEcOy2NxM8h7zEXiU4tLHz2wgQiGjKC
yBDWwQvnbQRls/svnXT3JfdMoiBpEa/JemWuxlrg5QT1MLKhpvj7Q==
X-Google-Smtp-Source: AGHT+IFK7fStAPczwHlA6yCdTHGEWfNfhVKkNEHzP+7Oko2ly14DB1rtE62c8uxDLUdgFFObIQt2tg==
X-Received: by 2002:a17:903:944:b0:216:3dc0:c8ab with SMTP id
d9443c01a7336-218929f1d64mr159992485ad.9.1734317609607;
Sun, 15 Dec 2024 18:53:29 -0800 (PST)
Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89])
by smtp.gmail.com with ESMTPSA id
d9443c01a7336-218a1e5cf5asm32789185ad.178.2024.12.15.18.53.28
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sun, 15 Dec 2024 18:53:29 -0800 (PST)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: Simon Tournier <zimon.toutoune@HIDDEN>
Subject: Re: [PATCH] guix-install.sh: Add message about Info reader.
In-Reply-To: <e8022e114a050910d879193b9ec317826f768278.1731743586.git.zimon.toutoune@HIDDEN>
(Simon Tournier's message of "Sat, 16 Nov 2024 08:54:07 +0100")
References: <87h68d6k4e.fsf@HIDDEN>
<e8022e114a050910d879193b9ec317826f768278.1731743586.git.zimon.toutoune@HIDDEN>
Date: Mon, 16 Dec 2024 11:53:18 +0900
Message-ID: <87r068uyn5.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 67241
Cc: 67241 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Hi Simon,
Simon Tournier <zimon.toutoune@HIDDEN> writes:
> * etc/guix-install.sh (_info): New procedure.
> (_chk_sys_nscd, main_install): Use it.
>
> Change-Id: I2cad8bc2554cd4ea88f30c8a104b7c62f2aa2e0e
> ---
> etc/guix-install.sh | 18 ++++++++++++++----
> 1 file changed, 14 insertions(+), 4 deletions(-)
>
> diff --git a/etc/guix-install.sh b/etc/guix-install.sh
> index f07b2741bb..08e25de238 100755
> --- a/etc/guix-install.sh
> +++ b/etc/guix-install.sh
> @@ -5,7 +5,7 @@
> # Copyright =C2=A9 2018 Efraim Flashner <efraim@HIDDEN>
> # Copyright =C2=A9 2019=E2=80=932020, 2022 Tobias Geerinckx-Rice <me@tob=
ias.gr>
> # Copyright =C2=A9 2020 Morgan Smith <Morgan.J.Smith@HIDDEN>
> -# Copyright =C2=A9 2020 Simon Tournier <zimon.toutoune@HIDDEN>
> +# Copyright =C2=A9 2020, 2024 Simon Tournier <zimon.toutoune@HIDDEN>
> # Copyright =C2=A9 2020 Daniel Brooks <db48x@HIDDEN>
> # Copyright =C2=A9 2021 Jakub K=C4=85dzio=C5=82ka <kuba@HIDDEN>
> # Copyright =C2=A9 2021 Chris Marusich <cmmarusich@HIDDEN>
> @@ -129,6 +129,16 @@ die()
> exit 1
> }
>=20=20
> +_info()
> +{
> + if [ "$(type -P info)" ]; then
> + _msg "$1"
> + else
> + _msg "${WAR}Please install Info reader; see package 'info-reader=
'"
> + _msg "$1"
> + fi
> +}
It seems odd to me to "overload" _msg into _info that deals with some side
effect; I'd rather see this conditional explicit at the message printing
site.
Also, your test is testing for the empty string when info is not found,
not the exist status, which is wrong. I think you meant something like:
--8<---------------cut here---------------start------------->8---
if type -P info >/dev/null then [...]; fi
--8<---------------cut here---------------end--------------->8---
But this got me curious again... could we instead automate the
installation of info post-installation? If yes, we should also automate
the installation of glibc-locales, using prompts that the user can
accept or decline like for the other configuration choices.
That'd be more useful than asking the user to manually install things
itself.
--=20
Thanks,
Maxim
bug-guix@HIDDEN:bug#67241; Package guix.
Full text available.
Received: (at 67241) by debbugs.gnu.org; 16 Nov 2024 07:55:24 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 16 02:55:24 2024
Received: from localhost ([127.0.0.1]:51971 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tCDeN-00046a-Jp
for submit <at> debbugs.gnu.org; Sat, 16 Nov 2024 02:55:24 -0500
Received: from mail-wm1-f44.google.com ([209.85.128.44]:42274)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <zimon.toutoune@HIDDEN>) id 1tCDeK-00046L-RR
for 67241 <at> debbugs.gnu.org; Sat, 16 Nov 2024 02:55:22 -0500
Received: by mail-wm1-f44.google.com with SMTP id
5b1f17b1804b1-4315eac969aso14366715e9.1
for <67241 <at> debbugs.gnu.org>; Fri, 15 Nov 2024 23:55:20 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1731743655; x=1732348455; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=7vkazje4crajeWuv5WNO/WvJ0OBLHE0Z50k1sYFMY8c=;
b=j0bdo38ht3CO5Wg5ut1O+S4B1t4pGoZ48IkKcmi4mg84ZYFlJj9GfYsGhPh4h2GvoP
kJq0L48s38TqvRut7CUsfesfqbAK2vKrHSZpxKw5y+p7ekxwW24V3koioihquCE8Dmqe
u7qozIIhqGsXPDZs2g/3t4lkE/p0nooo9B02SNrtnviRb22RbzeYirdlcPi//ItapPH/
oftf4SUJfOIFBpuDyxjpC2MFaHHYLjZAIl2e7b/GPJwsykRZ6Lct3UE5W9mxnTGEVRh5
eWiY/wM9pzMlFi2605qfnPnFfBCd2IihSVu5UCCk+fjnzVtRSyxWqWuGFycyp1GuUsa1
9x4w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1731743655; x=1732348455;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=7vkazje4crajeWuv5WNO/WvJ0OBLHE0Z50k1sYFMY8c=;
b=vFfkPhsnbQuzvcEOuVT5TR+pYikq/qmnF1kBu7s7a7OO9NyBvHdGRUYHAbXZqQlL7B
sOiwEqrFvwTZkDeYuw56SjH8xQWhOcWKQrC21VQfLppblJFfTW+mmhE35YaLM3h/z56E
prendld6YWG73DZaAIL0oy4eg/slTah1eM/jz+2TZJJHiUJqeLE1BuLD77wgFb5Z1QUz
9giYYjUwNBsEvGEhTRBXMUGlY7I1+D02jrh+IHwy0egB+wat4z7Rup4J7ifzfp/4c5a+
dro5MkWUqc2ba7/LyEhwbk3o4Bsm2/9Kfq8jaGYNCvkeQGIyukPx0/FkarGo2b0F6Dhn
jhWg==
X-Gm-Message-State: AOJu0YzAM+gdDTd+7oyH7UwwIpMVzYFgnvRlm6HA5So3nERcJkesAx84
c1PXtDFv5nDVE2RfcIsemFujTTyiQ6qQgbEEsePZB422yFMxTMov
X-Google-Smtp-Source: AGHT+IG097M6geAfVYhTX5I/ohhD2rBaIcyBaMPwgwX/dom/Z4kKkpfM9rO1Yolz2qo5aGTVLuMflg==
X-Received: by 2002:a05:600c:35ce:b0:428:b4a:7001 with SMTP id
5b1f17b1804b1-432d9767769mr92475625e9.15.1731743654767;
Fri, 15 Nov 2024 23:54:14 -0800 (PST)
Received: from lili.. (d96ded6d.fsp.oleane.fr. [217.109.237.109])
by smtp.gmail.com with ESMTPSA id
5b1f17b1804b1-432dac21b24sm78553545e9.40.2024.11.15.23.54.13
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 15 Nov 2024 23:54:14 -0800 (PST)
From: Simon Tournier <zimon.toutoune@HIDDEN>
To: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Subject: [PATCH] guix-install.sh: Add message about Info reader.
Date: Sat, 16 Nov 2024 08:54:07 +0100
Message-ID: <e8022e114a050910d879193b9ec317826f768278.1731743586.git.zimon.toutoune@HIDDEN>
X-Mailer: git-send-email 2.46.0
In-Reply-To: <87h68d6k4e.fsf@HIDDEN>
References: <87h68d6k4e.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 67241
Cc: Simon Tournier <zimon.toutoune@HIDDEN>, 67241 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
* etc/guix-install.sh (_info): New procedure.
(_chk_sys_nscd, main_install): Use it.
Change-Id: I2cad8bc2554cd4ea88f30c8a104b7c62f2aa2e0e
---
etc/guix-install.sh | 18 ++++++++++++++----
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index f07b2741bb..08e25de238 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -5,7 +5,7 @@
# Copyright © 2018 Efraim Flashner <efraim@HIDDEN>
# Copyright © 2019–2020, 2022 Tobias Geerinckx-Rice <me@HIDDEN>
# Copyright © 2020 Morgan Smith <Morgan.J.Smith@HIDDEN>
-# Copyright © 2020 Simon Tournier <zimon.toutoune@HIDDEN>
+# Copyright © 2020, 2024 Simon Tournier <zimon.toutoune@HIDDEN>
# Copyright © 2020 Daniel Brooks <db48x@HIDDEN>
# Copyright © 2021 Jakub Kądziołka <kuba@HIDDEN>
# Copyright © 2021 Chris Marusich <cmmarusich@HIDDEN>
@@ -129,6 +129,16 @@ die()
exit 1
}
+_info()
+{
+ if [ "$(type -P info)" ]; then
+ _msg "$1"
+ else
+ _msg "${WAR}Please install Info reader; see package 'info-reader'"
+ _msg "$1"
+ fi
+}
+
# Return true if user answered yes, false otherwise. The prompt is
# yes-biased, that is, when the user simply enter newline, it is equivalent to
# answering "yes".
@@ -290,11 +300,11 @@ chk_sys_nscd()
if [ "$(type -P pidof)" ]; then
if [ ! "$(pidof nscd)" ]; then
_msg "${WAR}We recommend installing and/or starting your distribution 'nscd' service"
- _msg "${WAR}Please read 'info guix \"Application Setup\"' about \"Name Service Switch\""
+ _info "${WAR}Please read 'info guix \"Application Setup\"' about \"Name Service Switch\""
fi
else
_msg "${INF}We cannot determine if your distribution 'nscd' service is running"
- _msg "${INF}Please read 'info guix \"Application Setup\"' about \"Name Service Switch\""
+ _info "${INF}Please read 'info guix \"Application Setup\"' about \"Name Service Switch\""
fi
}
@@ -856,7 +866,7 @@ main_install()
rm -r "${tmp_path}"
_msg "${PAS}Guix has successfully been installed!"
- _msg "${INF}Run 'info guix' to read the manual."
+ _info "${INF}Run 'info guix' to read the manual."
# Required to source /etc/profile in desktop environments.
_msg "${INF}Please log out and back in to complete the installation."
base-commit: 3e8d3d80f41e016cdfe80e488a78c2351c94fef8
--
2.45.2
bug-guix@HIDDEN:bug#67241; Package guix.
Full text available.Received: (at 67241) by debbugs.gnu.org; 12 Nov 2024 06:30:06 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 12 01:30:06 2024 Received: from localhost ([127.0.0.1]:60241 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tAkPd-0005CX-VJ for submit <at> debbugs.gnu.org; Tue, 12 Nov 2024 01:30:06 -0500 Received: from mail-pg1-f171.google.com ([209.85.215.171]:52401) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>) id 1tAkPb-0005BK-3e for 67241 <at> debbugs.gnu.org; Tue, 12 Nov 2024 01:30:04 -0500 Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-7ee4c57b037so3854888a12.0 for <67241 <at> debbugs.gnu.org>; Mon, 11 Nov 2024 22:30:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731392936; x=1731997736; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GRr99dDjzByDlUekHt46be8CM2G3YaCkxDHwQFzCecw=; b=HcofKXGzcis/Pip6FHRxmiPZu+9mvtK9vibvrw/8CxpiGgbafnuLPnY38pjiprHy52 b2ZwTReuSxeWdtascg9iUEyh3Hw600MH/Hvgj7q7fdHM9w2MlSVXozdOLjc3kmJc/Gah BI6tnub9DW6O/VkVOOTC4GG9wn8FB602TSLSk0QZoYDUQTaSvpans5hXq9CMZ4yFijHN iXrnQju2CM75sJoWNMr/lGpu9etFaLei9qkcCjQXe2Eb0TO7wTyOL87LxoHhQ2a2iuMD siOMZ5Genwp8QaLfQsL11erjL5y9ukB5fr4T7cXfd0b5KOo74uinLzeTtG2NaM3a1kTp 693A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731392936; x=1731997736; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GRr99dDjzByDlUekHt46be8CM2G3YaCkxDHwQFzCecw=; b=D5FmJm7UOn6FFQ7QlWTLwsndseQhPpwQVe5MW7ZIwQoUlVIpoeX/b7kDA7xvpecgAE AwkNcYUYP2yO2LWjYUuKFwNSKOJaCyiGsg7EVpUDm3xp1KtZUvWwUwAcyODMyOyp8gfv 19SmnT/L/AOpg3vukRBtiNTNiMwWNo6hsUg/vCCe2RNKWFfOk4xQGdn9mh8F5r3JqtZR hjozEiypz3pSmLd6b+19O/Nt2udom8xWTxx5L3sQugLqmmTec4Yl/LySkDvoDXwOWMpq tw6JfSx7HFyk+Wp70aUrwiL1DJAOZ8O8Sd/eZ7AqXjyLXbu8QGiNI6fmd4glX7M/KC0C bHEg== X-Gm-Message-State: AOJu0Ywuic4/YCmrs34FIDVUFUc8uDUoqu5MwGNDynkrMNNNgWiF+ehJ Zb/9nkIx+DXEmaFqTAZT/gw38cFuqrNZxZbXl9wPAsznugsL8yAl06TY/Wwa X-Google-Smtp-Source: AGHT+IFSVleJCVKLoficdeYGjg2n2m10j+M9vOK21nl6JCZQGlbrwQGsSubcB3CcaXD8+UKTlYX7og== X-Received: by 2002:a05:6a21:788e:b0:1db:eb76:578d with SMTP id adf61e73a8af0-1dc22b1b587mr23351204637.36.1731392936212; Mon, 11 Nov 2024 22:28:56 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21177dc838esm86757385ad.32.2024.11.11.22.28.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Nov 2024 22:28:55 -0800 (PST) From: Maxim Cournoyer <maxim.cournoyer@HIDDEN> To: Simon Tournier <zimon.toutoune@HIDDEN> Subject: Re: bug#67241: guix-install.sh: Run =?utf-8?B?4oCZaW5mbyBndWl4?= =?utf-8?B?4oCZ?= needs =?utf-8?B?4oCZaW5mb+KAmQ==?= In-Reply-To: <87a5rcekbk.fsf@HIDDEN> (Simon Tournier's message of "Fri, 17 Nov 2023 11:38:23 +0100") References: <87a5rcekbk.fsf@HIDDEN> Date: Tue, 12 Nov 2024 15:28:49 +0900 Message-ID: <87h68d6k4e.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67241 Cc: 67241 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Hi Simon, Simon Tournier <zimon.toutoune@HIDDEN> writes: > Hi, > > The guix-install.sh script ends with the message: > > Run 'info guix' to read the manual. > > And this works only if the foreign distribution has already installed an > =E2=80=99info=E2=80=99 reader. That could not be the case. > > I suggest to test if =E2=80=9Ctype -P info=E2=80=9C returns something, th= en display the > message, else recommend to install an Info reader often named =E2=80=99in= fo=E2=80=99 or > =E2=80=99info-reader=E2=80=99 and display the message. Sounds like a good idea to me. --=20 Thanks, Maxim
bug-guix@HIDDEN:bug#67241; Package guix.
Full text available.
Received: (at submit) by debbugs.gnu.org; 17 Nov 2023 16:14:39 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 17 11:14:39 2023
Received: from localhost ([127.0.0.1]:47030 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1r41UI-00055I-8R
for submit <at> debbugs.gnu.org; Fri, 17 Nov 2023 11:14:39 -0500
Received: from lists.gnu.org ([2001:470:142::17]:46742)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <zimon.toutoune@HIDDEN>) id 1r41UC-00054x-HU
for submit <at> debbugs.gnu.org; Fri, 17 Nov 2023 11:14:33 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <zimon.toutoune@HIDDEN>)
id 1r41U2-0002u6-Nm
for bug-guix@HIDDEN; Fri, 17 Nov 2023 11:14:18 -0500
Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <zimon.toutoune@HIDDEN>)
id 1r41U1-0001GE-Af
for bug-guix@HIDDEN; Fri, 17 Nov 2023 11:14:18 -0500
Received: by mail-wm1-x330.google.com with SMTP id
5b1f17b1804b1-408434ce195so4848635e9.0
for <bug-guix@HIDDEN>; Fri, 17 Nov 2023 08:14:16 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1700237656; x=1700842456; darn=gnu.org;
h=content-transfer-encoding:mime-version:message-id:date:subject:to
:from:from:to:cc:subject:date:message-id:reply-to;
bh=rIkKZvgXguRcTZ2GJBk+pFEc8NsPSItzy/nbi6pejFw=;
b=RXMYvKpGJkx9NGG5wg0lA2dNbfgyMsWU2daR71u4BwOgKxt8aI+gKVzahxzWkghqva
53Ybe2vwutcxMp79tAU8K5czUzdwy4REzsO4vDgG64o4Cle67JleRuD8udqDm+i/sykj
N6ZQ0g+nG+aSQkGGRHu+Yk+NpPMMhc+fAJUby5k5N1u59Xr4N6BuGt6ODXntfsbT4R0U
zADAlSY5VGpaHiE2q5pKJ4N7gIwWMVDQT+uGlu6BP0XSHdHs/JujLGD6w81jlJXq4KrR
DbSPMgE8Bno3bTGD8/DL+TAf0B/srJ2Fz2yH74FShEtUmubItiukHDCoQpTjyo2yt9in
3CiQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1700237656; x=1700842456;
h=content-transfer-encoding:mime-version:message-id:date:subject:to
:from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=rIkKZvgXguRcTZ2GJBk+pFEc8NsPSItzy/nbi6pejFw=;
b=gtt6yRdHDUxmoRMrW0wBTnyWc16jx64FjwRf0zldbxozAfnOXCxlq4ZcCy73XUhL3q
5LRMMSQtA4WbiMM/CLTecn3x/MERsYI3iN1tvCqc7ZbPT0a+A/6/NBA6UAuJHkqosO+1
fJrHwPzcuh7oF+EgOFlINZ81VoWadkeROpAxJ3pwlf+qhF0nzVSEAGEGDZfN8dB7r/Lh
b94Pgo9xwu7PX0Es5s0KhgA71nODQIrgFBRxEetWhac0dSUTXOTUjYXFeGUey86fAaFx
QxNJxhn2tt5UnSiv9sVtesLxiPwKkU1TVMPPDOnq8ldpcxiGtUMTxh1ld6amF+eCXFPe
ZTmg==
X-Gm-Message-State: AOJu0YxVTHz688xToyspcFqbFY5QqJUlpcl2dnRKIA91B7WLs2xyW8Tk
MsCqr+lpYtd2ICyfq5xvALGUvfq/9NA=
X-Google-Smtp-Source: AGHT+IFdj1xPr5z48gHZhv5THPPCmxsHNQauaTIOLCXEMeDaMUNeN1qQ+hznj16SvsVJjKJRYYso+A==
X-Received: by 2002:a05:600c:1d13:b0:406:513d:738f with SMTP id
l19-20020a05600c1d1300b00406513d738fmr9353920wms.2.1700237655596;
Fri, 17 Nov 2023 08:14:15 -0800 (PST)
Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id
a20-20020a05600c069400b0040849ce7116sm7463497wmn.43.2023.11.17.08.14.15
for <bug-guix@HIDDEN>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 17 Nov 2023 08:14:15 -0800 (PST)
From: Simon Tournier <zimon.toutoune@HIDDEN>
To: bug-guix@HIDDEN
Subject: guix-install.sh: Run =?utf-8?B?4oCZaW5mbyBndWl44oCZ?= needs
=?utf-8?B?4oCZaW5mb+KAmQ==?=
Date: Fri, 17 Nov 2023 11:38:23 +0100
Message-ID: <87a5rcekbk.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass client-ip=2a00:1450:4864:20::330;
envelope-from=zimon.toutoune@HIDDEN; helo=mail-wm1-x330.google.com
X-Spam_score_int: -4
X-Spam_score: -0.5
X-Spam_bar: /
X-Spam_report: (-0.5 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_03_06=1.592,
DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 2.0 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hi, The guix-install.sh script ends with the message: Run
'info guix' to read the manual.
Content analysis details: (2.0 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (zimon.toutoune[at]gmail.com)
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
1.1 DATE_IN_PAST_03_06 Date: is 3 to 6 hours before Received: date
1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail)
-0.0 T_SCC_BODY_TEXT_LINE No description available.
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.0 (+)
Hi,
The guix-install.sh script ends with the message:
Run 'info guix' to read the manual.
And this works only if the foreign distribution has already installed an
=E2=80=99info=E2=80=99 reader. That could not be the case.
I suggest to test if =E2=80=9Ctype -P info=E2=80=9C returns something, then=
display the
message, else recommend to install an Info reader often named =E2=80=99info=
=E2=80=99 or
=E2=80=99info-reader=E2=80=99 and display the message.
WDYT?
Cheers,
simon
Simon Tournier <zimon.toutoune@HIDDEN>:bug-guix@HIDDEN.
Full text available.bug-guix@HIDDEN:bug#67241; Package guix.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.