GNU bug report logs - #67265
[PATCH 0/3] Add python-ripser and missing dependencies

Previous Next

Package: guix-patches;

Reported by: Troy Figiel <troy <at> troyfigiel.com>

Date: Sat, 18 Nov 2023 21:49:02 UTC

Severity: normal

Tags: patch

Done: Mathieu Othacehe <othacehe <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 67265 in the body.
You can then email your comments to 67265 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#67265; Package guix-patches. (Sat, 18 Nov 2023 21:49:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Troy Figiel <troy <at> troyfigiel.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sat, 18 Nov 2023 21:49:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Troy Figiel <troy <at> troyfigiel.com>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/3] Add python-ripser and missing dependencies
Date: Sat, 18 Nov 2023 22:48:17 +0100
This patch series adds python-ripser, its direct dependency
python-persim and its transitive dependency python-hopcroftkarp.

Troy Figiel (3):
  gnu: Add python-hopcroftkarp.
  gnu: Add python-persim.
  gnu: Add python-ripser.

 gnu/packages/machine-learning.scm | 89 +++++++++++++++++++++++++++++++
 1 file changed, 89 insertions(+)

-- 
2.40.1





Information forwarded to guix-patches <at> gnu.org:
bug#67265; Package guix-patches. (Sat, 18 Nov 2023 21:53:01 GMT) Full text and rfc822 format available.

Message #8 received at 67265 <at> debbugs.gnu.org (full text, mbox):

From: Troy Figiel <troy <at> troyfigiel.com>
To: 67265 <at> debbugs.gnu.org
Subject: [PATCH 1/3] gnu: Add python-hopcroftkarp.
Date: Sat, 18 Nov 2023 22:52:19 +0100
* gnu/packages/machine-learning.scm (python-hopcroftkarp): New variable.

Change-Id: I444f0371526d7a69d31363c228d5f7818bcf60dd
---
 gnu/packages/machine-learning.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/machine-learning.scm b/gnu/packages/machine-learning.scm
index a84377e1eb..6c29aefb58 100644
--- a/gnu/packages/machine-learning.scm
+++ b/gnu/packages/machine-learning.scm
@@ -21,6 +21,7 @@
 ;;; Copyright © 2023 zamfofex <zamfofex <at> twdb.moe>
 ;;; Copyright © 2023 Navid Afkhami <navid.afkhami <at> mdc-berlin.de>
 ;;; Copyright © 2023 Zheng Junjie <873216071 <at> qq.com>
+;;; Copyright © 2023 Troy Figiel <troy <at> troyfigiel.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -812,6 +813,30 @@ (define-public sentencepiece
 depend on language-specific pre- or post-processing.")
     (license license:asl2.0)))
 
+(define-public python-hopcroftkarp
+  ;; This commit fixes a broken import, but has not been released to PyPI.
+  (let ((commit "2846e1dd3265d95d2bddb0cf4190b830cbb4efe6")
+        (revision "1"))
+    (package
+      (name "python-hopcroftkarp")
+      (version (git-version "1.2.5" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/sofiatolaosebikan/hopcroftkarp")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "018ilrp41fcclmb5lsml3aijwbmhbq3m7wy65hr1fryj0avic8fr"))))
+      (build-system pyproject-build-system)
+      (home-page "https://github.com/sofiatolaosebikan/hopcroftkarp")
+      (synopsis "Implementation of the Hopcroft-Karp algorithm")
+      (description
+       "This package implements the Hopcroft-Karp algorithm, producing a maximum
+cardinality matching from a bipartite graph.")
+      (license license:gpl3))))
+
 (define-public python-sacrebleu
   (package
     (name "python-sacrebleu")
-- 
2.40.1





Information forwarded to guix-patches <at> gnu.org:
bug#67265; Package guix-patches. (Sat, 18 Nov 2023 21:54:02 GMT) Full text and rfc822 format available.

Message #11 received at 67265 <at> debbugs.gnu.org (full text, mbox):

From: Troy Figiel <troy <at> troyfigiel.com>
To: 67265 <at> debbugs.gnu.org
Subject: [PATCH 2/3] gnu: Add python-persim.
Date: Sat, 18 Nov 2023 22:53:45 +0100
* gnu/packages/machine-learning.scm (python-persim): New variable.

Change-Id: I914071a90b4555d7d1218ce83337d49298effb01
---
 gnu/packages/machine-learning.scm | 36 +++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/gnu/packages/machine-learning.scm b/gnu/packages/machine-learning.scm
index 6c29aefb58..e315be7f9f 100644
--- a/gnu/packages/machine-learning.scm
+++ b/gnu/packages/machine-learning.scm
@@ -837,6 +837,42 @@ (define-public python-hopcroftkarp
 cardinality matching from a bipartite graph.")
       (license license:gpl3))))
 
+(define-public python-persim
+  (package
+    (name "python-persim")
+    (version "0.3.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "persim" version))
+       (sha256
+        (base32 "0q8wfakx8q4h3ryvw8cba0v6z7xn9139qkrzs3mi1ggyzacnx9d7"))))
+    (build-system pyproject-build-system)
+    (propagated-inputs (list python-deprecated
+                             python-hopcroftkarp
+                             python-joblib
+                             python-matplotlib
+                             python-numpy
+                             python-scikit-learn
+                             python-scipy))
+    (native-inputs (list python-pytest python-pytest-cov))
+    (home-page "https://persim.scikit-tda.org")
+    (synopsis "Tools for analyzing persistence diagrams in Python")
+    (description
+     "This package includes a variety of tools used to analyze persistence diagrams.
+It currently houses implementations of
+@itemize
+@item Persistence images
+@item Persistence landscapes
+@item Bottleneck distance
+@item Modified Gromov–Hausdorff distance
+@item Sliced Wasserstein kernel
+@item Heat kernel
+@item Diagram plotting
+@end itemize
+")
+    (license license:expat))) ; MIT License
+
 (define-public python-sacrebleu
   (package
     (name "python-sacrebleu")
-- 
2.40.1





Information forwarded to guix-patches <at> gnu.org:
bug#67265; Package guix-patches. (Sat, 18 Nov 2023 21:55:01 GMT) Full text and rfc822 format available.

Message #14 received at 67265 <at> debbugs.gnu.org (full text, mbox):

From: Troy Figiel <troy <at> troyfigiel.com>
To: 67265 <at> debbugs.gnu.org
Subject: [PATCH 3/3] gnu: Add python-ripser.
Date: Sat, 18 Nov 2023 22:54:35 +0100
* gnu/packages/machine-learning.scm (python-ripser): New variable.

Change-Id: I21b42e555a5017e68cf43a6eaa19d991db36723d
---
 gnu/packages/machine-learning.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/machine-learning.scm b/gnu/packages/machine-learning.scm
index e315be7f9f..8987688ae8 100644
--- a/gnu/packages/machine-learning.scm
+++ b/gnu/packages/machine-learning.scm
@@ -873,6 +873,34 @@ (define-public python-persim
 ")
     (license license:expat))) ; MIT License
 
+(define-public python-ripser
+  (package
+    (name "python-ripser")
+    (version "0.6.4")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "ripser" version))
+       (sha256
+        (base32 "1575nwsn6b29z7w1mjk23ri83bxq2b4ld979hpgm174642a3x6vs"))))
+    (build-system pyproject-build-system)
+    (propagated-inputs (list python-numpy python-persim python-scikit-learn
+                             python-scipy))
+    (native-inputs (list python-cython python-pytest))
+    (home-page "https://ripser.scikit-tda.org")
+    (synopsis "Persistent homology library for Python")
+    (description
+     "This package implements a variety of persistent homology algorithms.  It
+provides an interface for
+@itemize
+@item computing persistence cohomology of sparse and dense data sets
+@item visualizing persistence diagrams
+@item computing lowerstar filtrations on images
+@item computing representative cochains
+@end itemize
+")
+    (license license:expat))) ; MIT License
+
 (define-public python-sacrebleu
   (package
     (name "python-sacrebleu")
-- 
2.40.1





Information forwarded to guix-patches <at> gnu.org:
bug#67265; Package guix-patches. (Sun, 07 Jan 2024 20:38:02 GMT) Full text and rfc822 format available.

Message #17 received at 67265 <at> debbugs.gnu.org (full text, mbox):

From: Troy Figiel <troy <at> troyfigiel.com>
To: 67265 <at> debbugs.gnu.org
Subject: [PATCH v2 0/3] Add python-ripser and its dependencies
Date: Sun, 7 Jan 2024 21:15:05 +0100
This patch series adds python-ripser, its direct dependency
python-persim and its transitive dependency python-hopcroftkarp.

I noticed that the first few patches I sent to Guix, were sent without a
base-commit. I have rebased the patch series that follows on master and given
it a base-commit.

Troy Figiel (3):
  gnu: Add python-hopcroftkarp.
  gnu: Add python-persim.
  gnu: Add python-ripser.

 gnu/packages/machine-learning.scm | 89 +++++++++++++++++++++++++++++++
 1 file changed, 89 insertions(+)


base-commit: 5f8a993aa85554ca09bd27139230d7664107e1b6
-- 
2.42.0





Information forwarded to guix-patches <at> gnu.org:
bug#67265; Package guix-patches. (Sun, 07 Jan 2024 20:38:02 GMT) Full text and rfc822 format available.

Message #20 received at 67265 <at> debbugs.gnu.org (full text, mbox):

From: Troy Figiel <troy <at> troyfigiel.com>
To: 67265 <at> debbugs.gnu.org
Subject: [PATCH v2 1/3] gnu: Add python-hopcroftkarp.
Date: Sat, 18 Nov 2023 22:06:13 +0100
* gnu/packages/machine-learning.scm (python-hopcroftkarp): New variable.

Change-Id: I444f0371526d7a69d31363c228d5f7818bcf60dd
---
 gnu/packages/machine-learning.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/machine-learning.scm b/gnu/packages/machine-learning.scm
index b4651c80e5..d852b0debe 100644
--- a/gnu/packages/machine-learning.scm
+++ b/gnu/packages/machine-learning.scm
@@ -21,6 +21,7 @@
 ;;; Copyright © 2023 zamfofex <zamfofex <at> twdb.moe>
 ;;; Copyright © 2023 Navid Afkhami <navid.afkhami <at> mdc-berlin.de>
 ;;; Copyright © 2023 Zheng Junjie <873216071 <at> qq.com>
+;;; Copyright © 2023 Troy Figiel <troy <at> troyfigiel.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -812,6 +813,30 @@ (define-public sentencepiece
 depend on language-specific pre- or post-processing.")
     (license license:asl2.0)))
 
+(define-public python-hopcroftkarp
+  ;; This commit fixes a broken import, but has not been released to PyPI.
+  (let ((commit "2846e1dd3265d95d2bddb0cf4190b830cbb4efe6")
+        (revision "1"))
+    (package
+      (name "python-hopcroftkarp")
+      (version (git-version "1.2.5" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/sofiatolaosebikan/hopcroftkarp")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "018ilrp41fcclmb5lsml3aijwbmhbq3m7wy65hr1fryj0avic8fr"))))
+      (build-system pyproject-build-system)
+      (home-page "https://github.com/sofiatolaosebikan/hopcroftkarp")
+      (synopsis "Implementation of the Hopcroft-Karp algorithm")
+      (description
+       "This package implements the Hopcroft-Karp algorithm, producing a maximum
+cardinality matching from a bipartite graph.")
+      (license license:gpl3))))
+
 (define-public python-sacrebleu
   (package
     (name "python-sacrebleu")
-- 
2.42.0





Information forwarded to guix-patches <at> gnu.org:
bug#67265; Package guix-patches. (Sun, 07 Jan 2024 20:39:01 GMT) Full text and rfc822 format available.

Message #23 received at 67265 <at> debbugs.gnu.org (full text, mbox):

From: Troy Figiel <troy <at> troyfigiel.com>
To: 67265 <at> debbugs.gnu.org
Subject: [PATCH v2 2/3] gnu: Add python-persim.
Date: Sat, 18 Nov 2023 22:39:11 +0100
* gnu/packages/machine-learning.scm (python-persim): New variable.

Change-Id: I914071a90b4555d7d1218ce83337d49298effb01
---
 gnu/packages/machine-learning.scm | 36 +++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/gnu/packages/machine-learning.scm b/gnu/packages/machine-learning.scm
index d852b0debe..67a8041f72 100644
--- a/gnu/packages/machine-learning.scm
+++ b/gnu/packages/machine-learning.scm
@@ -837,6 +837,42 @@ (define-public python-hopcroftkarp
 cardinality matching from a bipartite graph.")
       (license license:gpl3))))
 
+(define-public python-persim
+  (package
+    (name "python-persim")
+    (version "0.3.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "persim" version))
+       (sha256
+        (base32 "0q8wfakx8q4h3ryvw8cba0v6z7xn9139qkrzs3mi1ggyzacnx9d7"))))
+    (build-system pyproject-build-system)
+    (propagated-inputs (list python-deprecated
+                             python-hopcroftkarp
+                             python-joblib
+                             python-matplotlib
+                             python-numpy
+                             python-scikit-learn
+                             python-scipy))
+    (native-inputs (list python-pytest python-pytest-cov))
+    (home-page "https://persim.scikit-tda.org")
+    (synopsis "Tools for analyzing persistence diagrams in Python")
+    (description
+     "This package includes a variety of tools used to analyze persistence diagrams.
+It currently houses implementations of
+@itemize
+@item Persistence images
+@item Persistence landscapes
+@item Bottleneck distance
+@item Modified Gromov–Hausdorff distance
+@item Sliced Wasserstein kernel
+@item Heat kernel
+@item Diagram plotting
+@end itemize
+")
+    (license license:expat))) ; MIT License
+
 (define-public python-sacrebleu
   (package
     (name "python-sacrebleu")
-- 
2.42.0





Information forwarded to guix-patches <at> gnu.org:
bug#67265; Package guix-patches. (Sun, 07 Jan 2024 20:40:02 GMT) Full text and rfc822 format available.

Message #26 received at 67265 <at> debbugs.gnu.org (full text, mbox):

From: Troy Figiel <troy <at> troyfigiel.com>
To: 67265 <at> debbugs.gnu.org
Subject: [PATCH v2 3/3] gnu: Add python-ripser.
Date: Sat, 18 Nov 2023 22:41:16 +0100
* gnu/packages/machine-learning.scm (python-ripser): New variable.

Change-Id: I21b42e555a5017e68cf43a6eaa19d991db36723d
---
 gnu/packages/machine-learning.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/machine-learning.scm b/gnu/packages/machine-learning.scm
index 67a8041f72..1616738399 100644
--- a/gnu/packages/machine-learning.scm
+++ b/gnu/packages/machine-learning.scm
@@ -873,6 +873,34 @@ (define-public python-persim
 ")
     (license license:expat))) ; MIT License
 
+(define-public python-ripser
+  (package
+    (name "python-ripser")
+    (version "0.6.4")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "ripser" version))
+       (sha256
+        (base32 "1575nwsn6b29z7w1mjk23ri83bxq2b4ld979hpgm174642a3x6vs"))))
+    (build-system pyproject-build-system)
+    (propagated-inputs (list python-numpy python-persim python-scikit-learn
+                             python-scipy))
+    (native-inputs (list python-cython python-pytest))
+    (home-page "https://ripser.scikit-tda.org")
+    (synopsis "Persistent homology library for Python")
+    (description
+     "This package implements a variety of persistent homology algorithms.  It
+provides an interface for
+@itemize
+@item computing persistence cohomology of sparse and dense data sets
+@item visualizing persistence diagrams
+@item computing lowerstar filtrations on images
+@item computing representative cochains
+@end itemize
+")
+    (license license:expat))) ; MIT License
+
 (define-public python-sacrebleu
   (package
     (name "python-sacrebleu")
-- 
2.42.0





Reply sent to Mathieu Othacehe <othacehe <at> gnu.org>:
You have taken responsibility. (Tue, 09 Jan 2024 09:20:01 GMT) Full text and rfc822 format available.

Notification sent to Troy Figiel <troy <at> troyfigiel.com>:
bug acknowledged by developer. (Tue, 09 Jan 2024 09:20:01 GMT) Full text and rfc822 format available.

Message #31 received at 67265-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Troy Figiel <troy <at> troyfigiel.com>
Cc: 67265-done <at> debbugs.gnu.org
Subject: Re: [bug#67265] [PATCH v2 0/3] Add python-ripser and its dependencies
Date: Tue, 09 Jan 2024 10:18:55 +0100
> This patch series adds python-ripser, its direct dependency
> python-persim and its transitive dependency python-hopcroftkarp.

Applied, thanks,

Mathieu




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 06 Feb 2024 12:24:12 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 93 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.