GNU bug report logs - #67268
[PATCH] texinfo: add pointer about combining tests

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: automake-patches; Reported by: Karl Berry <karl@HIDDEN>; Keywords: patch; dated Sun, 19 Nov 2023 02:28:02 UTC; Maintainer for automake-patches is automake-patches@HIDDEN.

Message received at 67268 <at> debbugs.gnu.org:


Received: (at 67268) by debbugs.gnu.org; 2 Dec 2023 09:40:55 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Dec 02 04:40:55 2023
Received: from localhost ([127.0.0.1]:56644 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r9MUZ-00025V-D8
	for submit <at> debbugs.gnu.org; Sat, 02 Dec 2023 04:40:55 -0500
Received: from mail.gentoo.org ([2001:470:ea4a:1:5054:ff:fec7:86e4]:39227
 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vapier@HIDDEN>) id 1r9MUW-00025F-5G
 for 67268 <at> debbugs.gnu.org; Sat, 02 Dec 2023 04:40:53 -0500
Received: by smtp.gentoo.org (Postfix, from userid 559)
 id 0EA86335D64; Sat,  2 Dec 2023 09:40:36 +0000 (UTC)
Date: Sat, 2 Dec 2023 04:40:34 -0500
From: Mike Frysinger <vapier@HIDDEN>
To: Karl Berry <karl@HIDDEN>
Subject: Re: [bug#67268] [PATCH] texinfo: add pointer about combining tests
Message-ID: <ZWr7kjHoyRic7jit@vapier>
References: <CANnVG6nxeBwe3r0th0M6eM2bosjCmRuG-+4WnjxqR5rfqZX_MQ@HIDDEN>
 <202311190227.3AJ2RcMZ032145@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature"; boundary="rKicS1eabiue7ZrN"
Content-Disposition: inline
In-Reply-To: <202311190227.3AJ2RcMZ032145@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 67268
Cc: 67268 <at> debbugs.gnu.org, michael@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)


--rKicS1eabiue7ZrN
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 18 Nov 2023 19:27, Karl Berry wrote:
> Hi Michael,
>=20
>=20
>     Date: Sun, 16 Oct 2016 18:35:53 +0200
>     From: Michael Stapelberg <michael@HIDDEN>
>     To: automake-patches@HIDDEN
>     Subject: [PATCH] texinfo: add pointer about combining tests
>=20
>     https://lists.gnu.org/archive/html/automake-patches/2016-10/msg00002.=
html
>=20
> Seven years late(r), but I did finally merge (a version of) your
> suggestion of a portability note in the Automake manual about &&
> vs. test -a, as below.  Thanks! --karl
>=20
>=20
> doc: mention shell operators preferred over `test` options.

is the automake manual the best place for this ?  the autoconf manual has a
very extensive "Portable Shell Programming" chapter:
https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.71/ht=
ml_node/Portable-Shell.html

seems like it'd be better to extend that section and link it from here.
-mike

--rKicS1eabiue7ZrN
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmVq+5IACgkQQWM7n+g3
9YHCMhAApYS5CFj3jVWPHITCkgijwzTmWHg9UT9IrSQW0GB7tZOCnJp/+hI1EBYG
TZ7TEVbgaY/+brKjheBb+up4eHzAV8OGZ3VZGSMv73iZV4xpQCKeGd6nDfNV3gYz
/V2Q8HeiwgR5j0OFQXjOy8tivTWIRG1MDr/CGGg2x84UoKFR90I2UQV9BoiEbv++
L7vh1MAHaNsB6IlNj38lEupY8QWeTGwxlwpc0jsIYxZem0qNSxem2h8vUrwGMbf4
UpY0Q/o1+08tZZDhb070DYno0piQgjaJwIndbsDyZBjcm+0K7xpsu0ZP5harRHry
FWYhdSrgZAMULEONl/gthv1wtAivCt2c9R3BOgKRkOHRFyXMfefi2KnyMdS+R+xl
qUepnJ7iAk+8/yBwlB7r+lLi6RgKOcrnC5k6Eh2cYQNOJnJkesJALFTGUHGkKbEN
hD/mfgwvmerXfFbUXKsLd1+K4ikKr642u+iTdfnhtWQyX5us41l8CEeQz2b6mty5
/1or7ZxwqbTZ/izoQalazaO82GexO0tBZK6E/TmllWVBefDQy9b0HuqbmjnhNWaB
7dEPylnIRHVJqpMnhFnaXdN51LOomXjHDZFlBdTepUpQYsThHP7gokjUZTage5l5
54l8oHEErwSW+/a45PxxsX4Ff59J84eqbUEN5tTH22gsuDUUxmE=
=LYpc
-----END PGP SIGNATURE-----

--rKicS1eabiue7ZrN--




Information forwarded to automake-patches@HIDDEN:
bug#67268; Package automake-patches. Full text available.
Did not alter fixed versions and reopened. Request was from Debbugs Internal Request <help-debbugs@HIDDEN> to internal_control <at> debbugs.gnu.org. Full text available.

Message received at 67268-done <at> debbugs.gnu.org:


Received: (at 67268-done) by debbugs.gnu.org; 25 Nov 2023 21:36:57 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 25 16:36:57 2023
Received: from localhost ([127.0.0.1]:40389 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r70Ke-0004es-O0
	for submit <at> debbugs.gnu.org; Sat, 25 Nov 2023 16:36:56 -0500
Received: from frenzy.freefriends.org ([198.99.81.75]:38950
 helo=freefriends.org) by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <karl@HIDDEN>) id 1r70Kc-0004eb-IJ
 for 67268-done <at> debbugs.gnu.org; Sat, 25 Nov 2023 16:36:55 -0500
X-Envelope-From: karl@HIDDEN
X-Envelope-To: <67268-done <at> debbugs.gnu.org>
Received: from freefriends.org (localhost [127.0.0.1])
 by freefriends.org (8.14.7/8.14.7) with ESMTP id 3APLamCd008227
 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT)
 for <67268-done <at> debbugs.gnu.org>; Sat, 25 Nov 2023 14:36:48 -0700
Received: (from apache@localhost)
 by freefriends.org (8.14.7/8.14.7/Submit) id 3APLamTE008226;
 Sat, 25 Nov 2023 14:36:48 -0700
Date: Sat, 25 Nov 2023 14:36:48 -0700
Message-Id: <202311252136.3APLamTE008226@HIDDEN>
From: Karl Berry <karl@HIDDEN>
To: 67268-done <at> debbugs.gnu.org
Subject: 
X-Spam-Score: 4.3 (++++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details. Content preview:  
 Content analysis details:   (4.3 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
 -0.0 SPF_PASS               SPF: sender matches SPF record
 2.0 BLANK_SUBJECT          Subject is present but empty
 2.3 EMPTY_MESSAGE          Message appears to have no textual parts
X-Debbugs-Envelope-To: 67268-done
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 3.3 (+++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 
 Content preview:  
 
 Content analysis details:   (3.3 points, 10.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
 -0.0 SPF_PASS               SPF: sender matches SPF record
  2.0 BLANK_SUBJECT          Subject is present but empty
  2.3 EMPTY_MESSAGE          Message appears to have no textual parts
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager





Notification sent to Karl Berry <karl@HIDDEN>:
bug acknowledged by developer. Full text available.
Reply sent to Karl Berry <karl@HIDDEN>:
You have taken responsibility. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 19 Nov 2023 02:27:57 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 18 21:27:57 2023
Received: from localhost ([127.0.0.1]:49701 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r4XXP-0004N2-M1
	for submit <at> debbugs.gnu.org; Sat, 18 Nov 2023 21:27:57 -0500
Received: from lists.gnu.org ([2001:470:142::17]:35008)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <karl@HIDDEN>) id 1r4XXL-0004Mi-6p
 for submit <at> debbugs.gnu.org; Sat, 18 Nov 2023 21:27:54 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <karl@HIDDEN>)
 id 1r4XXE-00084g-7M
 for automake-patches@HIDDEN; Sat, 18 Nov 2023 21:27:44 -0500
Received: from frenzy.freefriends.org ([198.99.81.75] helo=freefriends.org)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <karl@HIDDEN>)
 id 1r4XXC-0004om-I2
 for automake-patches@HIDDEN; Sat, 18 Nov 2023 21:27:43 -0500
X-Envelope-From: karl@HIDDEN
Received: from freefriends.org (localhost [127.0.0.1])
 by freefriends.org (8.14.7/8.14.7) with ESMTP id 3AJ2Rc0i032146
 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); 
 Sat, 18 Nov 2023 19:27:38 -0700
Received: (from apache@localhost)
 by freefriends.org (8.14.7/8.14.7/Submit) id 3AJ2RcMZ032145;
 Sat, 18 Nov 2023 19:27:38 -0700
Date: Sat, 18 Nov 2023 19:27:38 -0700
Message-Id: <202311190227.3AJ2RcMZ032145@HIDDEN>
From: Karl Berry <karl@HIDDEN>
To: michael@HIDDEN
Subject: Re: [PATCH] texinfo: add pointer about combining tests
In-Reply-To: <CANnVG6nxeBwe3r0th0M6eM2bosjCmRuG-+4WnjxqR5rfqZX_MQ@HIDDEN>
Received-SPF: pass client-ip=198.99.81.75; envelope-from=karl@HIDDEN;
 helo=freefriends.org
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: submit
Cc: automake-patches@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi Michael,


    Date: Sun, 16 Oct 2016 18:35:53 +0200
    From: Michael Stapelberg <michael@HIDDEN>
    To: automake-patches@HIDDEN
    Subject: [PATCH] texinfo: add pointer about combining tests

    https://lists.gnu.org/archive/html/automake-patches/2016-10/msg00002.html

Seven years late(r), but I did finally merge (a version of) your
suggestion of a portability note in the Automake manual about &&
vs. test -a, as below.  Thanks! --karl


doc: mention shell operators preferred over `test` options.

* doc/automake.texi (Usage of Conditionals): mention that shell
operators (&&, ||, ()) are preferred over `test` options (-a, -o,
\(\)). Idea and POSIX url reference from Michael Stapelberg,
https://lists.gnu.org/archive/html/automake-patches/2016-10/msg00002.html
diff --git a/doc/automake.texi b/doc/automake.texi
index 51a3c3dbe..635bdd28c 100644
--- a/doc/automake.texi
+++ b/doc/automake.texi
@@ -11118,6 +11118,14 @@ must arrange for @emph{every} @code{AM_CONDITIONAL} to be invoked every
 time @command{configure} is run.  If @code{AM_CONDITIONAL} is run
 conditionally (e.g., in a shell @code{if} statement), then the result
 will confuse @command{automake}.
+
+For portability, it is best to use shell operators @code{&&} and
+@code{||} and parentheses, when constructing a compound
+@var{condition} using the @command{test} command, and not the
+@code{-a} and @code{-o} options and parentheses as options to
+@command{test}, all of which have been marked obsolescent by POSIX
+(@url{https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html#tag_20_128_161}).
+The name @code{test} is also more portable than @code{[}.
 @end defmac

 @cindex @option{--enable-debug}, example

compile finished at Sat Nov 18 18:25:16 2023




Acknowledgement sent to Karl Berry <karl@HIDDEN>:
New bug report received and forwarded. Copy sent to automake-patches@HIDDEN. Full text available.
Report forwarded to automake-patches@HIDDEN:
bug#67268; Package automake-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Sat, 2 Dec 2023 09:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.