GNU bug report logs - #67283
[PATCH] guix: guile: Add #:substitutable? argument to build system.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 67283 in the body.
You can then email your comments to 67283 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Skyler Ferris <skyvine <at> protonmail.com>
To: guix-patches <at> gnu.org
Cc: Skyler Ferris <skyvine <at> protonmail.com>
Subject: [PATCH] guix: guile: Add #:substitutable? argument to build system.
Date: Sun, 19 Nov 2023 09:10:36 -0800

This is implemented the same as in gnu-build-system.

* guix/build-system/guile.scm (guile-build, guile-cross-build): Add
  #:substitutable? argument

Change-Id: I04babb81ff1f322833f7ff22cd7580c048b26102
---
 guix/build-system/guile.scm | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/guix/build-system/guile.scm b/guix/build-system/guile.scm
index 1bd292e267..bd3bb1c870 100644
--- a/guix/build-system/guile.scm
+++ b/guix/build-system/guile.scm
@@ -88,7 +88,8 @@ (define* (guile-build name inputs
                       (compile-flags %compile-flags)
                       (imported-modules %guile-build-system-modules)
                       (modules '((guix build guile-build-system)
-                                 (guix build utils))))
+                                 (guix build utils)))
+                      (substitutable? #t))
   "Build SOURCE using Guile taken from the native inputs, and with INPUTS."
   (define builder
     (with-imported-modules imported-modules
@@ -114,6 +115,7 @@ (define* (guile-build name inputs
                       #:system system
                       #:target #f
                       #:graft? #f
+                      #:substitutable? substitutable?
                       #:guile-for-build guile)))
 
 (define* (guile-cross-build name
@@ -133,7 +135,8 @@ (define* (guile-cross-build name
                             (compile-flags %compile-flags)
                             (imported-modules %guile-build-system-modules)
                             (modules '((guix build guile-build-system)
-                                       (guix build utils))))
+                                       (guix build utils)))
+                            (substitutable? #t))
   (define builder
     (with-imported-modules imported-modules
       #~(begin
@@ -173,6 +176,7 @@ (define* (guile-cross-build name
                       #:system system
                       #:target target
                       #:graft? #f
+                      #:substitutable? substitutable?
                       #:guile-for-build guile)))
 
 (define guile-build-system

base-commit: cd82ddd15c28b4f4690255b11a1ce6dcac7c166d
prerequisite-patch-id: d25067ea4ec0e23744f2dca853c7e9f7b9ab4a9d
-- 
2.41.0

Message #10 received at 67283-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Skyler Ferris <skyvine <at> protonmail.com>
Cc: 67283-done <at> debbugs.gnu.org
Subject: Re: [bug#67283] [PATCH] guix: guile: Add #:substitutable? argument
 to build system.
Date: Sat, 25 Nov 2023 16:26:48 +0100

Skyler Ferris <skyvine <at> protonmail.com> skribis:

> This is implemented the same as in gnu-build-system.
>
> * guix/build-system/guile.scm (guile-build, guile-cross-build): Add
>   #:substitutable? argument
>
> Change-Id: I04babb81ff1f322833f7ff22cd7580c048b26102

Tweaked the commit log and applied it, thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.