GNU bug report logs - #67284
[PATCH] guix: meson: Add #:substitutable? argument to build system.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Package: guix-patches; Reported by: Skyler Ferris <skyvine@HIDDEN>; Keywords: patch; Done: Ludovic Courtès <ludo@HIDDEN>; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 67284-done <at> debbugs.gnu.org:


Received: (at 67284-done) by debbugs.gnu.org; 25 Nov 2023 16:31:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 25 11:31:48 2023
Received: from localhost ([127.0.0.1]:40082 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r6vZM-00055i-2m
	for submit <at> debbugs.gnu.org; Sat, 25 Nov 2023 11:31:48 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:46016)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1r6vZL-00055V-2y
 for 67284-done <at> debbugs.gnu.org; Sat, 25 Nov 2023 11:31:47 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1r6vZ7-0002jW-9d; Sat, 25 Nov 2023 11:31:33 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To:
 From; bh=qi4dA6LkSXlxMdlu9N7w0zO1oULWjjl6vjrYRAyTwDc=; b=UCj68BH35mAPSXe11BoO
 UXR6KrOHXLanRK9Amweu83PagN5G3UQPqtF5uMIuXezB8s8Na9QGhhNy2SifSfkR/csXkDEoCG2CX
 liBfnRFmvbwOXGREbVcbccG7dhBRLZLSekA9jxm5SmfE3G45PzQqfF/50U04A3RP3XiDOrUbrwnyW
 vT/PLEfG9KUl7+kIbLS6ZGX0hbTn6Bpaw4ZpJIjAD3nB5PCGcBRxRmdMOMBJPszugmeLcOef8mJNi
 0qnlChFYMFXqxXR0yIPgLKSKuVng5CY1EGJUuZ6O3wUcGX1UpV3rHx6H+Y2rTkNrZ3i9bj90VJxwT
 S1HFOyvdyyuNNA==;
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
To: Skyler Ferris <skyvine@HIDDEN>
Subject: Re: [bug#67284] [PATCH] guix: meson: Add #:substitutable? argument
 to build system.
In-Reply-To: <1650b790f2eca0a74736230b570d1299e5bcfc8b.1700414069.git.skyvine@HIDDEN>
 (Skyler Ferris's message of "Sun, 19 Nov 2023 09:14:39 -0800")
References: <1650b790f2eca0a74736230b570d1299e5bcfc8b.1700414069.git.skyvine@HIDDEN>
Date: Sat, 25 Nov 2023 17:31:29 +0100
Message-ID: <87bkbh4wwu.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 67284-done
Cc: 67284-done <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Skyler Ferris <skyvine@HIDDEN> skribis:

> This implemented the same as in gnu-build-system. The gexp->derivation
> calls did not need to be modified because they already
> passed #:substitutable?, which did not cause an error due to the
> procedure exported by the (guix store) module with the same name.

Heh, fun.  :-)

> * guix/build-system/meson.scm (meson-build, meson-cross-build): Add
>   #:substitutable? argument
>
> Change-Id: I2d56c8130f785a2d6af456ef9f9bfc1b10dc2a50

Applied, thanks!
Notification sent to Skyler Ferris <skyvine@HIDDEN>:
bug acknowledged by developer. Full text available.
Reply sent to Ludovic Courtès <ludo@HIDDEN>:
You have taken responsibility. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 19 Nov 2023 17:15:10 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 19 12:15:10 2023
Received: from localhost ([127.0.0.1]:52013 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r4lO1-000463-VM
	for submit <at> debbugs.gnu.org; Sun, 19 Nov 2023 12:15:10 -0500
Received: from lists.gnu.org ([2001:470:142::17]:44442)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <skyvine@HIDDEN>) id 1r4lNq-000452-Fv
 for submit <at> debbugs.gnu.org; Sun, 19 Nov 2023 12:15:08 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <skyvine@HIDDEN>)
 id 1r4lNj-0002hN-Hw
 for guix-patches@HIDDEN; Sun, 19 Nov 2023 12:14:51 -0500
Received: from c-24-143-119-132.customer.broadstripe.net ([24.143.119.132]
 helo=localhost)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <skyvine@HIDDEN>)
 id 1r4lNi-0003TV-5f
 for guix-patches@HIDDEN; Sun, 19 Nov 2023 12:14:51 -0500
Received: from [127.0.0.1] (helo=localhost.localdomain)
 by localhost with esmtp (Exim 4.96.1)
 (envelope-from <skyvine@HIDDEN>) id 1r4lNg-0005hI-1j;
 Sun, 19 Nov 2023 09:14:48 -0800
From: Skyler Ferris <skyvine@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] guix: meson: Add #:substitutable? argument to build system.
Date: Sun, 19 Nov 2023 09:14:39 -0800
Message-ID: <1650b790f2eca0a74736230b570d1299e5bcfc8b.1700414069.git.skyvine@HIDDEN>
X-Mailer: git-send-email 2.41.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: softfail client-ip=24.143.119.132;
 envelope-from=skyvine@HIDDEN; helo=localhost
X-Spam_score_int: 36
X-Spam_score: 3.6
X-Spam_bar: +++
X-Spam_report: (3.6 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FROM=0.001,
 FSL_HELO_NON_FQDN_1=0.001, HELO_LOCALHOST=3.828, KHOP_HELO_FCRDNS=0.001,
 RDNS_DYNAMIC=0.982, SPF_SOFTFAIL=0.665, SPOOFED_FREEMAIL=0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
Cc: Skyler Ferris <skyvine@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

This implemented the same as in gnu-build-system. The gexp->derivation
calls did not need to be modified because they already
passed #:substitutable?, which did not cause an error due to the
procedure exported by the (guix store) module with the same name.

* guix/build-system/meson.scm (meson-build, meson-cross-build): Add
  #:substitutable? argument

Change-Id: I2d56c8130f785a2d6af456ef9f9bfc1b10dc2a50
---
 guix/build-system/meson.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/guix/build-system/meson.scm b/guix/build-system/meson.scm
index 7c617bffb0..2d14016b94 100644
--- a/guix/build-system/meson.scm
+++ b/guix/build-system/meson.scm
@@ -182,6 +182,7 @@ (define* (meson-build name inputs
                       (imported-modules %meson-build-system-modules)
                       (modules '((guix build meson-build-system)
                                  (guix build utils)))
+                      (substitutable? #t)
                       allowed-references
                       disallowed-references)
   "Build SOURCE using MESON, and with INPUTS, assuming that SOURCE
@@ -266,6 +267,7 @@ (define* (meson-cross-build name
                             (imported-modules %meson-build-system-modules)
                             (modules '((guix build meson-build-system)
                                        (guix build utils)))
+                            (substitutable? #t)
                             allowed-references
                             disallowed-references)
   "Cross-build SOURCE for TARGET using MESON, and with INPUTS, assuming that

base-commit: cd82ddd15c28b4f4690255b11a1ce6dcac7c166d
-- 
2.41.0
Acknowledgement sent to Skyler Ferris <skyvine@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#67284; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Sat, 25 Nov 2023 16:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.