Eli Zaretskii <eliz@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 67287) by debbugs.gnu.org; 19 Nov 2023 20:19:05 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 19 15:19:05 2023 Received: from localhost ([127.0.0.1]:52160 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1r4oG0-0002wS-V0 for submit <at> debbugs.gnu.org; Sun, 19 Nov 2023 15:19:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1r4oFz-0002vu-4s; Sun, 19 Nov 2023 15:19:03 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1r4oFs-00009O-1K; Sun, 19 Nov 2023 15:18:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=mRAn91QT4z3z+Aa8U7KUbsMzS6pHa3mIU+ilOHbqtaM=; b=SKMMtLim//iPnpUvD+mz 2f9n/sXWlOImREV4tyIJa2RQCNLhKlJkcjPSmm/L2BamXfKHeOU0gRVZNB4zn8NSA2iUIb9vwDrYQ zi3wESL4gJLJbhXrtPo0ire76pMmw5GN9lJsbv/pxO2wIOpI92G0tbpm+qQsSNBwAvrjHBDyhWXne EzgdFZxHPWf9HRunGzqG+7kvqvqLT75Y6dVtoR7QpcPo1DXXVXSajKxBNFglkcn8kROsVv3GPtEv9 nyUjnCpSMChhRpwqmhlheBeuZw+TaKJcpt0mxWqrrvUxIIENhBJQ5oRc5o4HpPHVrJF51bLiQ+Q7a YJcXZb/jyQngjA==; Date: Sun, 19 Nov 2023 22:18:38 +0200 Message-Id: <83a5r9jy3l.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: =?utf-8?Q?Jo=C3=A3o?= Pedro <jpedrodeamorim@HIDDEN> In-Reply-To: <87zfz95yf0.fsf@ergo> (message from =?utf-8?Q?Jo=C3=A3o?= Pedro on Sun, 19 Nov 2023 16:35:31 -0300) Subject: Re: bug#67287: 29.1; hs-set-up-overlay messes up indent-sexp References: <87zfz95yf0.fsf@ergo> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67287 Cc: 67287 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) tags 67287 notabug wontfix thanks > From: João Pedro <jpedrodeamorim@HIDDEN> > Date: Sun, 19 Nov 2023 16:35:31 -0300 > > When setting `hs-set-up-overlay' to a custom value, such as the one in > the docstring for the variable, it messes up the behaviour of > `indent-sexp' when it is called "before" the s-expression. > > Steps to reproduce: > > 1. Go to any lisp buffer e.g. *scracth* > 2. Paste the following piece of code > > (setq hs-set-up-overlay > (lambda (ov) > (when (eq 'code (overlay-get ov 'hs)) > (overlay-put ov 'display > (propertize > (format " ... <%d>" > (count-lines (overlay-start ov) > (overlay-end ov))) > 'face 'font-lock-type-face))))) > > 3. Evaluate it > 4. Enable `hs-minor-mode' > 5. Hide the block with `hs-hide-block' (need to be on the beginning line > of the forms) > 6. Move point either to the first opening parenthesis or the the empty > line before the `setq' form > > (setq > ^---- > > 7. Call `indent-sexp' > 8. Open the block with `hs-show-block' > > You should see the following: > > (setq hs-set-up-overlay > (lambda (ov) > (when (eq 'code (overlay-get ov 'hs)) > (overlay-put ov 'display > (propertize > (format " ... <%d>" > (count-lines (overlay-start ov) > (overlay-end ov))) > ) > > I tried to investigate why it does that, but couldn't really get to the > root cause. It seems that its only affected when we're setting the > `display' prop of the overlay, but I couldn't confirm it either. Indentation commands align text by columns, and 'display' properties and invisible text affect those columns (starting from Emacs 29). So you shouldn't expect reasonable results from indenting a sexp which is partially hidden and has a 'display' property that replaces it. IOW, always unhide the block before indenting it. This is not a bug.
bug-gnu-emacs@HIDDEN:bug#67287; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 19 Nov 2023 19:35:54 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 19 14:35:54 2023 Received: from localhost ([127.0.0.1]:52114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1r4naE-0001oj-Ej for submit <at> debbugs.gnu.org; Sun, 19 Nov 2023 14:35:54 -0500 Received: from lists.gnu.org ([2001:470:142::17]:58536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <jpedrodeamorim@HIDDEN>) id 1r4naA-0001oV-Fb for submit <at> debbugs.gnu.org; Sun, 19 Nov 2023 14:35:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <jpedrodeamorim@HIDDEN>) id 1r4na3-0000zT-0I for bug-gnu-emacs@HIDDEN; Sun, 19 Nov 2023 14:35:43 -0500 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <jpedrodeamorim@HIDDEN>) id 1r4na0-0006eB-ID for bug-gnu-emacs@HIDDEN; Sun, 19 Nov 2023 14:35:41 -0500 Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-1ce5e65ba37so14997845ad.1 for <bug-gnu-emacs@HIDDEN>; Sun, 19 Nov 2023 11:35:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700422535; x=1701027335; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=6NJ0xIfVMvyMaDIGZ4NgdmWjKOLx2xz3k+5BQXgK9MY=; b=c/J2IEj7dTTqH1lms4vBhQaa7j0mZyt6eiY/3lJPUT7vxayLxzeAVCKIGCFjQDbzCT TRsKkTf5tN9WRkuF3keACrlwYnVeZUQbtOiz/azSzgSnYMAZnXaHgyFgsmKoAEIWkgkY BFfB+2lts7L8BqFANZrGJkuKAlC60M0DP8OfcRpnqEZoS+jlac8CFDRNWOESsXSxg9D5 3GZlwB/D+J8RuirmP4aKFFe6H6/hfLlCJ+c/GFd05qDjM/I3QyjNqjc8M2lqLZtBpY6Z P+UM8qNh9WTFlrOWrvg2l1Kr4mz01xileNH9WvIz4kkOXY5Vq0YCCLlhZ4iryLhEoZXE TMXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700422535; x=1701027335; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6NJ0xIfVMvyMaDIGZ4NgdmWjKOLx2xz3k+5BQXgK9MY=; b=LVlQmRthxkYNIwOB0ELb6GmYid8DPfBP7lfwgDHQ8GDi4Y+Jhu8DrS/LfOpfy1Vios wDo4EI2sGlmW06+KlpMzgo812QBumetMhWCEp65y4VSwJp/MmNi7NNCfoGKdnh9JJQWO LtadyZEP5cTh/NuQJZ9eBhE/V7NY1Tdo4ZyNoZQRs4w16l9xdq4FGVLbNLL1fT7SpXgi l0V3WzmrzUiz3SKtvj9cDx6dZXs9E/HgX9A6YBbJ0LM5/GO6gmdKgyhI1/X0qqIp3Z/R zW+6aliA4XzNLnANE2CYqecciML5F4/+SEQeAGQBY2+FGjcDvcOEk2ijX8iY6rja2vUu 76ng== X-Gm-Message-State: AOJu0YyQnrOh2mayYn3YoZvRX41zjYeXVrZ1o4E0zWqmPObme6LbfVBn +n3fL+UmTSikfcTaXq3SK7srO0S7u8M= X-Google-Smtp-Source: AGHT+IGr6kcGtLiZD7RUXc3V8Jb2UtC2t6HmqCYqDlE66za93cZQv9ES1fShhDGXDrcvIm6Q3Pnagg== X-Received: by 2002:a17:902:cec4:b0:1bd:e258:a256 with SMTP id d4-20020a170902cec400b001bde258a256mr8541450plg.32.1700422535245; Sun, 19 Nov 2023 11:35:35 -0800 (PST) Received: from ergo ([187.61.201.31]) by smtp.gmail.com with ESMTPSA id t18-20020a170902d21200b001cf59ad964asm1355483ply.140.2023.11.19.11.35.34 for <bug-gnu-emacs@HIDDEN> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 11:35:34 -0800 (PST) From: =?utf-8?Q?Jo=C3=A3o_Pedro?= <jpedrodeamorim@HIDDEN> To: bug-gnu-emacs@HIDDEN Subject: 29.1; hs-set-up-overlay messes up indent-sexp Date: Sun, 19 Nov 2023 16:35:31 -0300 Message-ID: <87zfz95yf0.fsf@ergo> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 Received-SPF: pass client-ip=2607:f8b0:4864:20::62d; envelope-from=jpedrodeamorim@HIDDEN; helo=mail-pl1-x62d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) R3JlZXRpbmdzIQ0KDQpXaGVuIHNldHRpbmcgYGhzLXNldC11cC1vdmVybGF5JyB0byBhIGN1c3Rv bSB2YWx1ZSwgc3VjaCBhcyB0aGUgb25lIGluDQp0aGUgZG9jc3RyaW5nIGZvciB0aGUgdmFyaWFi bGUsIGl0IG1lc3NlcyB1cCB0aGUgYmVoYXZpb3VyIG9mDQpgaW5kZW50LXNleHAnIHdoZW4gaXQg aXMgY2FsbGVkICJiZWZvcmUiIHRoZSBzLWV4cHJlc3Npb24uDQoNClN0ZXBzIHRvIHJlcHJvZHVj ZToNCg0KMS4gR28gdG8gYW55IGxpc3AgYnVmZmVyIGUuZy4gKnNjcmFjdGgqDQoyLiBQYXN0ZSB0 aGUgZm9sbG93aW5nIHBpZWNlIG9mIGNvZGUNCg0KICAgIChzZXRxIGhzLXNldC11cC1vdmVybGF5 DQogICAgICAgICAgKGxhbWJkYSAob3YpDQogICAgICAgICAgICAod2hlbiAoZXEgJ2NvZGUgKG92 ZXJsYXktZ2V0IG92ICdocykpDQogICAgICAgICAgICAgIChvdmVybGF5LXB1dCBvdiAnZGlzcGxh eQ0KICAgICAgICAgICAgICAgICAgICAgICAgICAgKHByb3BlcnRpemUNCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAoZm9ybWF0ICIgLi4uIDwlZD4iDQogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAoY291bnQtbGluZXMgKG92ZXJsYXktc3RhcnQgb3YpDQogICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKG92ZXJsYXktZW5kIG92KSkp DQogICAgICAgICAgICAgICAgICAgICAgICAgICAgJ2ZhY2UgJ2ZvbnQtbG9jay10eXBlLWZhY2Up KSkpKQ0KDQozLiBFdmFsdWF0ZSBpdA0KNC4gRW5hYmxlIGBocy1taW5vci1tb2RlJw0KNS4gSGlk ZSB0aGUgYmxvY2sgd2l0aCBgaHMtaGlkZS1ibG9jaycgKG5lZWQgdG8gYmUgb24gdGhlIGJlZ2lu bmluZyBsaW5lDQogICBvZiB0aGUgZm9ybXMpDQo2LiBNb3ZlIHBvaW50IGVpdGhlciB0byB0aGUg Zmlyc3Qgb3BlbmluZyBwYXJlbnRoZXNpcyBvciB0aGUgdGhlIGVtcHR5DQogICBsaW5lIGJlZm9y ZSB0aGUgYHNldHEnIGZvcm0NCg0KICAgKHNldHENCiAgIF4tLS0tDQoNCjcuIENhbGwgYGluZGVu dC1zZXhwJw0KOC4gT3BlbiB0aGUgYmxvY2sgd2l0aCBgaHMtc2hvdy1ibG9jaycNCg0KWW91IHNo b3VsZCBzZWUgdGhlIGZvbGxvd2luZzoNCg0KICAgIChzZXRxIGhzLXNldC11cC1vdmVybGF5DQog ICAgICAgICAgKGxhbWJkYSAob3YpDQogICAgICAgICAgICAod2hlbiAoZXEgJ2NvZGUgKG92ZXJs YXktZ2V0IG92ICdocykpDQogICAgICAgICAgICAgIChvdmVybGF5LXB1dCBvdiAnZGlzcGxheQ0K ICAgICAgICAgICAgICAgICAgICAgICAgICAgKHByb3BlcnRpemUNCiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAoZm9ybWF0ICIgLi4uIDwlZD4iDQogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAoY291bnQtbGluZXMgKG92ZXJsYXktc3RhcnQgb3YpDQogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKG92ZXJsYXktZW5kIG92KSkpDQog ICAgICAgICAgICAgICAgICAgICAgICAgICAgKQ0KDQpJIHRyaWVkIHRvIGludmVzdGlnYXRlIHdo eSBpdCBkb2VzIHRoYXQsIGJ1dCBjb3VsZG4ndCByZWFsbHkgZ2V0IHRvIHRoZQ0Kcm9vdCBjYXVz ZS4gSXQgc2VlbXMgdGhhdCBpdHMgb25seSBhZmZlY3RlZCB3aGVuIHdlJ3JlIHNldHRpbmcgdGhl DQpgZGlzcGxheScgcHJvcCBvZiB0aGUgb3ZlcmxheSwgYnV0IEkgY291bGRuJ3QgY29uZmlybSBp dCBlaXRoZXIuDQoNCkJlc3QgcmVnYXJkcywNCg0KLS0gDQpKb8OjbyBQZWRybyBkZSBBLiBQYXVs YQ0KSVQgYmFjaGVsb3JzIGF0IFVuaXZlcnNpZGFkZSBGZWRlcmFsIGRvIFJpbyBHcmFuZGUgZG8g Tm9ydGUgKFVGUk4pDQo=
João Pedro <jpedrodeamorim@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#67287; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.