GNU logs - #67290, boring messages

Message sent to bug-guix@HIDDEN:

Subject: bug#67290: (current-profile) only works when invoked as a process named "guix"
Resent-From: Ian Eure <ian@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Sun, 19 Nov 2023 21:25:02 +0000
Resent-Message-ID: <handler.67290.B.170042907828401 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 67290 <at> debbugs.gnu.org
Feedback-ID: id9014242:Fastmail
From: Ian Eure <ian@HIDDEN>
Date: Sun, 19 Nov 2023 13:24:13 -0800
Message-ID: <878r6tv3lu.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass client-ip=66.111.4.25; envelope-from=ian@HIDDEN;
 helo=out1-smtp.messagingengine.com
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
 SPF_HELO_PASS=-0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.6 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.4 (/)

When you invoke `guix repl', the current-profile and current-channels proce=
dures reflect my current profile and channel configuration:

    l0p!ieure~$ guix repl
    GNU Guile 3.0.9
    Copyright (C) 1995-2023 Free Software Foundation, Inc.

    Guile comes with ABSOLUTELY NO WARRANTY; for details type `,show w'.
    This program is free software, and you are welcome to redistribute it
    under certain conditions; type `,show c' for details.

    Enter `,help' for help.
    scheme@(guix-user)> ,m (guix describe)
    scheme@(guix describe)> (current-profile)
    $1 =3D "/home/ieure/.config/guix/current"
    scheme@(guix describe)> (length (current-channels))
    $2 =3D 3
    scheme@(guix describe)>=20

If you run `guile', they do not:

    l0p!ieure~$ guile
    GNU Guile 3.0.9
    Copyright (C) 1995-2023 Free Software Foundation, Inc.

    Guile comes with ABSOLUTELY NO WARRANTY; for details type `,show w'.
    This program is free software, and you are welcome to redistribute it
    under certain conditions; type `,show c' for details.

    Enter `,help' for help.
    scheme@(guile-user)> ,m (guix describe)
    scheme@(guix describe)> (current-profile)
    $1 =3D #f
    scheme@(guix describe)> (length (current-channels))
    $2 =3D 1
    scheme@(guix describe)>=20

The issue seems to be that current-profile checks the name of the program w=
hich was invoked, and always returns #f unless the name ends with "bin/guix=
".  Since "guile" doesn=E2=80=99t, they don=E2=80=99t work as expected.  Se=
e: https://git.savannah.gnu.org/cgit/guix.git/tree/guix/describe.scm#n64

I discovered this when I was using emacs-guix to debug one of my package de=
finitions, which inherits from a package in a non-default channel.  While I=
 can load the .scm file into Geiser no matter what channels are configured,=
 it can=E2=80=99t use the module containing the package definition it inher=
its from.  This also appears to be the root cause behind this three-year-ol=
d bug report for emacs-guix: https://gitlab.com/emacs-guix/emacs-guix/-/iss=
ues/17

I=E2=80=99m not sure what the rationale is for this behavior, so I don=E2=
=80=99t have a suggestion for a fix, but it=E2=80=99s definitely a bug.

Thanks,

  =E2=80=94 Ian

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Ian Eure <ian@HIDDEN>
Subject: bug#67290: Acknowledgement ((current-profile) only works when
 invoked as a process named "guix")
Message-ID: <handler.67290.B.170042907828401.ack <at> debbugs.gnu.org>
References: <878r6tv3lu.fsf@HIDDEN>
X-Gnu-PR-Message: ack 67290
X-Gnu-PR-Package: guix
Reply-To: 67290 <at> debbugs.gnu.org
Date: Sun, 19 Nov 2023 21:25:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-guix@HIDDEN

If you wish to submit further information on this problem, please
send it to 67290 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
67290: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D67290
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-guix@HIDDEN:

Subject: bug#67290: (current-profile) only works when invoked as a process named "guix"
Resent-From: Simon Tournier <zimon.toutoune@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Fri, 12 Jan 2024 12:52:05 +0000
Resent-Message-ID: <handler.67290.B67290.170506389116157 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Ian Eure <ian@HIDDEN>, 67290 <at> debbugs.gnu.org
From: Simon Tournier <zimon.toutoune@HIDDEN>
In-Reply-To: <878r6tv3lu.fsf@HIDDEN>
References: <878r6tv3lu.fsf@HIDDEN>
Date: Fri, 12 Jan 2024 12:17:13 +0100
Message-ID: <87r0imx0li.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hi,

On Sun, 19 Nov 2023 at 13:24, Ian Eure <ian@HIDDEN> wrote:

> The issue seems to be that current-profile checks the name of the
> program which was invoked, and always returns #f unless the name ends
> with "bin/guix".  Since "guile" doesn=E2=80=99t, they don=E2=80=99t work =
as expected.
> See:
> https://git.savannah.gnu.org/cgit/guix.git/tree/guix/describe.scm#n64

About current-profile, maybe this patch:


--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline; filename=p.patch
Content-Description: p.patch

diff --git a/guix/describe.scm b/guix/describe.scm
index 65cd79094b..4147d5db1f 100644
--- a/guix/describe.scm
+++ b/guix/describe.scm
@@ -61,14 +61,18 @@ (define current-profile
 or #f if this is not applicable."
     (match initial-program-arguments
       ((program . _)
-       (and (string-suffix? "/bin/guix" program)
-            ;; Note: We want to do _lexical dot-dot resolution_.  Using ".."
-            ;; for real would instead take us into the /gnu/store directory
-            ;; that ~/.config/guix/current/bin points to, whereas we want to
-            ;; obtain ~/.config/guix/current.
-            (let ((candidate (dirname (dirname program))))
-              (and (file-exists? (string-append candidate "/manifest"))
-                   candidate)))))))
+       (or (and (string-suffix? "/bin/guix" program)
+                ;; Note: We want to do _lexical dot-dot resolution_.  Using ".."
+                ;; for real would instead take us into the /gnu/store directory
+                ;; that ~/.config/guix/current/bin points to, whereas we want to
+                ;; obtain ~/.config/guix/current.
+                (let ((candidate (dirname (dirname program))))
+                  (and (file-exists? (string-append candidate "/manifest"))
+                       candidate)))
+           (let ((current (string-append
+                           (config-directory #:ensure? #f) "/current/manifest")))
+             (and (file-exists? current)
+                  current)))))))
 
 (define (current-profile-date)
   "Return the creation date of the current profile (produced by 'guix pull'),

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


?

Well, I do not know exactly if fixing your issue does not introduce
regression.

About emacs-guix, instead of launching Guile, why not start =E2=80=9Cguix
repl=E2=80=9D instead?  The command =E2=80=9Cguix repl=E2=80=9D had been im=
proved =E2=80=93 and maybe
even introduced after the release of emacs-guix.  Somehow, I am not very
happy with the current integration between Geiser and Guix. :-)

Cheers,
simon



--=-=-=--

Message sent to bug-guix@HIDDEN:

Subject: bug#67290: (current-profile) only works when invoked as a process named "guix"
Resent-From: Ian Eure <ian@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Sat, 13 Jan 2024 20:52:01 +0000
Resent-Message-ID: <handler.67290.B67290.170517911719798 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 67290 <at> debbugs.gnu.org
Feedback-ID: id9014242:Fastmail
References: <878r6tv3lu.fsf@HIDDEN> <87r0imx0li.fsf@HIDDEN>
User-agent: mu4e 1.10.8; emacs 29.1
From: Ian Eure <ian@HIDDEN>
Date: Sat, 13 Jan 2024 12:46:43 -0800
In-reply-to: <87r0imx0li.fsf@HIDDEN>
Message-ID: <87jzodq7ml.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>


Simon Tournier <zimon.toutoune@HIDDEN> writes:

> Hi,
>
> On Sun, 19 Nov 2023 at 13:24, Ian Eure <ian@HIDDEN> wrote:
>
>> The issue seems to be that current-profile checks the name of=20
>> the
>> program which was invoked, and always returns #f unless the=20
>> name ends
>> with "bin/guix".  Since "guile" doesn=E2=80=99t, they don=E2=80=99t work=
 as=20
>> expected.
>> See:
>> https://git.savannah.gnu.org/cgit/guix.git/tree/guix/describe.scm#n64
>
> About current-profile, maybe this patch:
>
> [2. p.patch --- text/x-diff; p.patch]
> diff --git a/guix/describe.scm b/guix/describe.scm
> index 65cd79094b..4147d5db1f 100644
> --- a/guix/describe.scm
> +++ b/guix/describe.scm
> @@ -61,14 +61,18 @@ (define current-profile
>  or #f if this is not applicable."
>      (match initial-program-arguments
>        ((program . _)
> -       (and (string-suffix? "/bin/guix" program)
> -            ;; Note: We want to do _lexical dot-dot=20
> resolution_.  Using ".."
> -            ;; for real would instead take us into the=20
> /gnu/store directory
> -            ;; that ~/.config/guix/current/bin points to,=20
> whereas we want to
> -            ;; obtain ~/.config/guix/current.
> -            (let ((candidate (dirname (dirname program))))
> -              (and (file-exists? (string-append candidate=20
> "/manifest"))
> -                   candidate)))))))
> +       (or (and (string-suffix? "/bin/guix" program)
> +                ;; Note: We want to do _lexical dot-dot=20
> resolution_.  Using ".."
> +                ;; for real would instead take us into the=20
> /gnu/store directory
> +                ;; that ~/.config/guix/current/bin points to,=20
> whereas we want to
> +                ;; obtain ~/.config/guix/current.
> +                (let ((candidate (dirname (dirname program))))
> +                  (and (file-exists? (string-append candidate=20
> "/manifest"))
> +                       candidate)))
> +           (let ((current (string-append
> +                           (config-directory #:ensure? #f)=20
> "/current/manifest")))
> +             (and (file-exists? current)
> +                  current)))))))
>=20=20
>  (define (current-profile-date)
>    "Return the creation date of the current profile (produced by=20
>    'guix pull'),
>
>
> ?
>
> Well, I do not know exactly if fixing your issue does not=20
> introduce
> regression.
>

The patch looks good to me, but this is all stuff I=E2=80=99m not very=20
familiar with.


> About emacs-guix, instead of launching Guile, why not start=20
> =E2=80=9Cguix
> repl=E2=80=9D instead?  The command =E2=80=9Cguix repl=E2=80=9D had been =
improved =E2=80=93 and=20
> maybe
> even introduced after the release of emacs-guix.  Somehow, I am=20
> not very
> happy with the current integration between Geiser and Guix. :-)
>

I=E2=80=99m not sure why it works the way it does, or whether it could be=20
changed to invoke `guix repl'.

I don=E2=80=99t think it=E2=80=99s expected for library code behavior to ch=
ange=20
depending on the runtime context, so I believe fixing Guix is the=20
right solution.  Perhaps the concerns around resolving relative=20
paths belongs somewhere more proximate to where that=E2=80=99s an issue?=20
I definitely don=E2=80=99t understand everything happening in this code,=20
but it strikes me as a concern relevant to some operations=20
executed from the CLI.  If that=E2=80=99s the case, putting it in the CLI=20
tooling where special handling is needed would make sense to me.

  =E2=80=94 Ian

Last modified: Sat, 20 Jan 2024 12:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.