GNU bug report logs - #67365
[PATCH core-updates] gnu: gitless: fix definition.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 67365 in the body.
You can then email your comments to 67365 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
To: guix-patches <at> gnu.org
Subject: [PATCH core-updates] gnu: gitless: fix definition.
Date: Wed, 22 Nov 2023 19:00:17 +0800

gnu/packages/version-control.scm(gitless)[arguments] move #~ to #:phases,
disable test.

Change-Id: Ibe3cdbd24fc0b27a15a880a2a45cb0cd8cfde84d
---
 gnu/packages/version-control.scm | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index c366a41342..b687d184c2 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -50,6 +50,7 @@
 ;;; Copyright © 2023 Nicolas Graves <ngraves <at> ngraves.fr>
 ;;; Copyright © 2023 Bruno Victal <mirai <at> makinata.eu>
 ;;; Copyright © 2023 Kjartan Oli Agustsson <kjartanoli <at> disroot.org>
+;;; Copyright © 2023 Zheng Junjie <873216071 <at> qq.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -776,9 +777,10 @@ (define-public gitless
        (file-name (git-file-name name version))))
     (build-system python-build-system)
     (arguments
-     #~(list
-        #:phases
-        (modify-phases %standard-phases
+     (list
+      #:tests? #f ;; FIXME: fix test
+      #:phases
+      #~(modify-phases %standard-phases
           (add-before 'build 'loosen-requirements
             (lambda _
               (substitute* "setup.py"

base-commit: 1bca46690c6240310befc6208fb24a044bd4b437
-- 
2.41.0

Message #10 received at 67365-done <at> debbugs.gnu.org (full text, mbox):

From: Hilton Chain <hako <at> ultrarare.space>
To: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
Cc: 67365-done <at> debbugs.gnu.org
Subject: Re: [bug#67365] [PATCH core-updates] gnu: gitless: fix definition.
Date: Wed, 22 Nov 2023 20:17:48 +0800

Hi,

On Wed, 22 Nov 2023 19:00:17 +0800,
Zheng Junjie wrote:
> 
> gnu/packages/version-control.scm(gitless)[arguments] move #~ to #:phases,
> disable test.
> 
> Change-Id: Ibe3cdbd24fc0b27a15a880a2a45cb0cd8cfde84d
> ---
>  gnu/packages/version-control.scm | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
> index c366a41342..b687d184c2 100644
> --- a/gnu/packages/version-control.scm
> +++ b/gnu/packages/version-control.scm
> @@ -50,6 +50,7 @@
>  ;;; Copyright © 2023 Nicolas Graves <ngraves <at> ngraves.fr>
>  ;;; Copyright © 2023 Bruno Victal <mirai <at> makinata.eu>
>  ;;; Copyright © 2023 Kjartan Oli Agustsson <kjartanoli <at> disroot.org>
> +;;; Copyright © 2023 Zheng Junjie <873216071 <at> qq.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -776,9 +777,10 @@ (define-public gitless
>         (file-name (git-file-name name version))))
>      (build-system python-build-system)
>      (arguments
> -     #~(list
> -        #:phases
> -        (modify-phases %standard-phases
> +     (list
> +      #:tests? #f ;; FIXME: fix test
> +      #:phases
> +      #~(modify-phases %standard-phases
>            (add-before 'build 'loosen-requirements
>              (lambda _
>                (substitute* "setup.py"
> 
> base-commit: 1bca46690c6240310befc6208fb24a044bd4b437
> -- 
> 2.41.0


Applied (without the #:tests? change, I'll address it later), thank you!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.