GNU bug report logs - #67433
[PATCH] Fix typescript-ts-mode add operator to treesit-font-lock-feature-list

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 67433 in the body.
You can then email your comments to 67433 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Noah Peart <noah.v.peart <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix typescript-ts-mode add operator to
 treesit-font-lock-feature-list
Date: Fri, 24 Nov 2023 07:25:17 -0800

[Message part 1 (text/plain, inline)]

Tags: patch


* lisp/progmodes/typescript-ts-mode.el(typescript-ts-mode): Add operator
to treesit-font-lock-feature-list in typescript-ts-mode.

Bug: `typescript-ts-mode` defines `operator` font-locking feature but
doesn't add
it to `treesit-font-lock-feature-list`.


In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.33, cairo version 1.16.0) of 2023-11-24 built on noah-X580VD
Repository revision: 0858d10aebed44f7d66548d061af03b3cb136d04
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Ubuntu 22.04.3 LTS

Configured using:
 'configure --prefix=/usr/local --with-modules --with-tree-sitter
--with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls
--with-json --with-mailutils --with-jpeg --with-png --with-rsvg
--with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12
CXX=gcc-12'

[Message part 2 (text/html, inline)]

[typescript-ts-mode-operator.patch (text/x-patch, attachment)]

Message #8 received at 67433 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Noah Peart <noah.v.peart <at> gmail.com>, Yuan Fu <casouri <at> gmail.com>
Cc: 67433 <at> debbugs.gnu.org
Subject: Re: bug#67433: [PATCH] Fix typescript-ts-mode add operator to
 treesit-font-lock-feature-list
Date: Fri, 24 Nov 2023 20:43:04 +0200

> From: Noah Peart <noah.v.peart <at> gmail.com>
> Date: Fri, 24 Nov 2023 07:25:17 -0800
> 
> * lisp/progmodes/typescript-ts-mode.el(typescript-ts-mode): Add operator
> to treesit-font-lock-feature-list in typescript-ts-mode.
> 
> Bug: `typescript-ts-mode` defines `operator` font-locking feature but doesn't add
> it to `treesit-font-lock-feature-list`.
> 
> In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version

Thanks, but please always try to test in Emacs 29 and tell if the
problem happens there as well.  It is important for us to know on
which branch to fix the problem.

Yuan, any comments?

Message #13 received at 67433-done <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Noah Peart <noah.v.peart <at> gmail.com>, 67433-done <at> debbugs.gnu.org
Subject: Re: bug#67433: [PATCH] Fix typescript-ts-mode add operator to
 treesit-font-lock-feature-list
Date: Fri, 24 Nov 2023 20:47:35 +0200

Version: 29.2

On 24/11/2023 17:25, Noah Peart wrote:
> Tags: patch
> 
> 
> * lisp/progmodes/typescript-ts-mode.el(typescript-ts-mode): Add operator
> to treesit-font-lock-feature-list in typescript-ts-mode.
> 
> Bug: `typescript-ts-mode` defines `operator` font-locking feature but 
> doesn't add
> it to `treesit-font-lock-feature-list`.

Thanks! Installed.

Suggestion for the future: it would be a bit more helpful when the 
commit message are inside the patch file already. So 'git am' puts it in 
the commit without additional copying required.

Message #16 received at 67433 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Eli Zaretskii <eliz <at> gnu.org>, Noah Peart <noah.v.peart <at> gmail.com>,
 Yuan Fu <casouri <at> gmail.com>
Cc: 67433 <at> debbugs.gnu.org
Subject: Re: bug#67433: [PATCH] Fix typescript-ts-mode add operator to
 treesit-font-lock-feature-list
Date: Fri, 24 Nov 2023 20:51:19 +0200

On 24/11/2023 20:43, Eli Zaretskii wrote:
>> From: Noah Peart<noah.v.peart <at> gmail.com>
>> Date: Fri, 24 Nov 2023 07:25:17 -0800
>>
>> * lisp/progmodes/typescript-ts-mode.el(typescript-ts-mode): Add operator
>> to treesit-font-lock-feature-list in typescript-ts-mode.
>>
>> Bug: `typescript-ts-mode` defines `operator` font-locking feature but doesn't add
>> it to `treesit-font-lock-feature-list`.
>>
>> In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
> Thanks, but please always try to test in Emacs 29 and tell if the
> problem happens there as well.  It is important for us to know on
> which branch to fix the problem.
> 
> Yuan, any comments?

Sorry, I've already installed the patch.

The setting was missing from the very beginning, so the problem was in 
emacs-29.

Message #19 received at 67433 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dmitry Gutov <dmitry <at> gutov.dev>
Cc: noah.v.peart <at> gmail.com, casouri <at> gmail.com, 67433 <at> debbugs.gnu.org
Subject: Re: bug#67433: [PATCH] Fix typescript-ts-mode add operator to
 treesit-font-lock-feature-list
Date: Sat, 25 Nov 2023 09:04:12 +0200

> Date: Fri, 24 Nov 2023 20:51:19 +0200
> Cc: 67433 <at> debbugs.gnu.org
> From: Dmitry Gutov <dmitry <at> gutov.dev>
> 
> On 24/11/2023 20:43, Eli Zaretskii wrote:
> >> From: Noah Peart<noah.v.peart <at> gmail.com>
> >> Date: Fri, 24 Nov 2023 07:25:17 -0800
> >>
> >> * lisp/progmodes/typescript-ts-mode.el(typescript-ts-mode): Add operator
> >> to treesit-font-lock-feature-list in typescript-ts-mode.
> >>
> >> Bug: `typescript-ts-mode` defines `operator` font-locking feature but doesn't add
> >> it to `treesit-font-lock-feature-list`.
> >>
> >> In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
> > Thanks, but please always try to test in Emacs 29 and tell if the
> > problem happens there as well.  It is important for us to know on
> > which branch to fix the problem.
> > 
> > Yuan, any comments?
> 
> Sorry, I've already installed the patch.

Thanks, but please in the future wait for a little longer, unless the
problem is obvious (like a typo or a syntax error).

Message #22 received at 67433 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: noah.v.peart <at> gmail.com, casouri <at> gmail.com, 67433 <at> debbugs.gnu.org
Subject: Re: bug#67433: [PATCH] Fix typescript-ts-mode add operator to
 treesit-font-lock-feature-list
Date: Sat, 25 Nov 2023 14:20:01 +0200

On 25/11/2023 09:04, Eli Zaretskii wrote:
>> Date: Fri, 24 Nov 2023 20:51:19 +0200
>> Cc:67433 <at> debbugs.gnu.org
>> From: Dmitry Gutov<dmitry <at> gutov.dev>
>>
>> On 24/11/2023 20:43, Eli Zaretskii wrote:
>>>> From: Noah Peart<noah.v.peart <at> gmail.com>
>>>> Date: Fri, 24 Nov 2023 07:25:17 -0800
>>>>
>>>> * lisp/progmodes/typescript-ts-mode.el(typescript-ts-mode): Add operator
>>>> to treesit-font-lock-feature-list in typescript-ts-mode.
>>>>
>>>> Bug: `typescript-ts-mode` defines `operator` font-locking feature but doesn't add
>>>> it to `treesit-font-lock-feature-list`.
>>>>
>>>> In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
>>> Thanks, but please always try to test in Emacs 29 and tell if the
>>> problem happens there as well.  It is important for us to know on
>>> which branch to fix the problem.
>>>
>>> Yuan, any comments?
>> Sorry, I've already installed the patch.
> Thanks, but please in the future wait for a little longer, unless the
> problem is obvious (like a typo or a syntax error).

Ok, I will. But it was pretty obvious to me (unused font-lock rules).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.