GNU bug report logs - #67445
Likely Gnus bracketing mistake

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 67445 in the body.
You can then email your comments to 67445 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mattias Engdegård <mattias.engdegard <at> gmail.com>
To: Emacs Bug Report <bug-gnu-emacs <at> gnu.org>
Subject: Likely Gnus bracketing mistake
Date: Sat, 25 Nov 2023 15:50:59 +0100

This looks like a bracketing mistake (gnus-group.el line 1758):

>     (if (and backward (progn (beginning-of-line)) (bobp))

especially considering `beginning-of-line` always returns nil.

(Is there a Gnus maintainer these days?)

Message #8 received at 67445 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Mattias Engdegård <mattias.engdegard <at> gmail.com>,
 Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 67445 <at> debbugs.gnu.org
Subject: Re: bug#67445: Likely Gnus bracketing mistake
Date: Sat, 25 Nov 2023 17:52:46 +0200

> From: Mattias Engdegård <mattias.engdegard <at> gmail.com>
> Date: Sat, 25 Nov 2023 15:50:59 +0100
> 
> This looks like a bracketing mistake (gnus-group.el line 1758):
> 
> >     (if (and backward (progn (beginning-of-line)) (bobp))
> 
> especially considering `beginning-of-line` always returns nil.
> 
> (Is there a Gnus maintainer these days?)

Yes, Eric (CC'ed).

Message #11 received at 67445 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Mattias Engdegård <mattias.engdegard <at> gmail.com>
Cc: 67445 <at> debbugs.gnu.org
Subject: Re: bug#67445: Likely Gnus bracketing mistake
Date: Sat, 25 Nov 2023 09:27:33 -0800

Mattias Engdegård <mattias.engdegard <at> gmail.com> writes:

> This looks like a bracketing mistake (gnus-group.el line 1758):
>
>>     (if (and backward (progn (beginning-of-line)) (bobp))
>
> especially considering `beginning-of-line` always returns nil.

Yes, it looks like you're right. Let me test a bit.

> (Is there a Gnus maintainer these days?)

It has a janitor :)

Message #14 received at 67445 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Mattias Engdegård <mattias.engdegard <at> gmail.com>,
 67445 <at> debbugs.gnu.org
Subject: Re: bug#67445: Likely Gnus bracketing mistake
Date: Sat, 25 Nov 2023 13:19:56 -0800

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Mattias Engdegård <mattias.engdegard <at> gmail.com>
>> Date: Sat, 25 Nov 2023 15:50:59 +0100
>> 
>> This looks like a bracketing mistake (gnus-group.el line 1758):
>> 
>> >     (if (and backward (progn (beginning-of-line)) (bobp))
>> 
>> especially considering `beginning-of-line` always returns nil.

That whole special-case test doesn't seem necessary, I think the
attached patch is sufficient. I've tested it lightly, does it look okay?

>> (Is there a Gnus maintainer these days?)
>
> Yes, Eric (CC'ed).

Hey, I've been promoted!

[gnus-search-articles.diff (text/x-patch, attachment)]

Message #17 received at 67445 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Schwab <schwab <at> linux-m68k.org>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: Eli Zaretskii <eliz <at> gnu.org>,
 Mattias Engdegård <mattias.engdegard <at> gmail.com>,
 67445 <at> debbugs.gnu.org
Subject: Re: bug#67445: Likely Gnus bracketing mistake
Date: Sat, 25 Nov 2023 22:43:37 +0100

On Nov 25 2023, Eric Abrahamsen wrote:

> +	    (not (if (> 0 way) (eobp) (bobp)))

            (not (if backward (bobp) (eobp))))

-- 
Andreas Schwab, schwab <at> linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

Message #20 received at 67445 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Andreas Schwab <schwab <at> linux-m68k.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>,
 Mattias Engdegård <mattias.engdegard <at> gmail.com>,
 67445 <at> debbugs.gnu.org
Subject: Re: bug#67445: Likely Gnus bracketing mistake
Date: Sat, 25 Nov 2023 13:58:15 -0800

On November 25, 2023 1:43:37 PM PST, Andreas Schwab <schwab <at> linux-m68k.org> wrote:
>On Nov 25 2023, Eric Abrahamsen wrote:
>
>> +	    (not (if (> 0 way) (eobp) (bobp)))
>
>            (not (if backward (bobp) (eobp))))

 Ah, good point! Thanks.

Message #23 received at 67445 <at> debbugs.gnu.org (full text, mbox):

From: Mattias Engdegård <mattias.engdegard <at> gmail.com>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 67445 <at> debbugs.gnu.org
Subject: Re: bug#67445: Likely Gnus bracketing mistake
Date: Sun, 26 Nov 2023 09:59:18 +0100

25 nov. 2023 kl. 18.27 skrev Eric Abrahamsen <eric <at> ericabrahamsen.net>:

> It has a janitor :)

The usual reward for diligence!

Message #28 received at 67445-done <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Mattias Engdegård <mattias.engdegard <at> gmail.com>
Cc: 67445-done <at> debbugs.gnu.org
Subject: Re: bug#67445: Likely Gnus bracketing mistake
Date: Sun, 26 Nov 2023 07:29:03 -0800

Mattias Engdegård <mattias.engdegard <at> gmail.com> writes:

> 25 nov. 2023 kl. 18.27 skrev Eric Abrahamsen <eric <at> ericabrahamsen.net>:
>
>> It has a janitor :)
>
> The usual reward for diligence!

I can always put "maintainer" on my business cards, tho :)

I'm closing this bug, thanks for the report!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.