GNU bug report logs - #67460
[PATCH] Add ert-font-lock

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 67460 in the body.
You can then email your comments to 67460 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vladimir Kazanov <vekazanov <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add ert-font-lock
Date: Sun, 26 Nov 2023 18:47:30 +0000

[Message part 1 (text/plain, inline)]

As suggested in emacs-devel@ [1], this patch adds ert-lont-lock.el to
Emacs. Ert-font-lock is an extension to ERT providing an easy way to
check font faces either in inline strings or resource files.

The assertion syntax is based on Tree-sitter's syntax highlighter unit
tests [2]. This makes it easy to port existing tree-sitter grammar
tests to support both new-style ts-based major modes and the
traditional ones.

[1] https://lists.gnu.org/archive/html/emacs-devel/2023-11/msg00867.html
[2] https://tree-sitter.github.io/tree-sitter/syntax-highlighting#unit-testing
-- 
Regards,

Vladimir Kazanov

[0001-Add-ert-font-lock.patch (text/x-patch, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org, Dmitry Gutov <dmitry <at> gutov.dev>,
 Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#67460: [PATCH] Add ert-font-lock
Date: Fri, 1 Dec 2023 19:51:08 -0800

On 11/26/23 10:47 AM, Vladimir Kazanov wrote:
> As suggested in emacs-devel@ [1], this patch adds ert-lont-lock.el to
> Emacs. Ert-font-lock is an extension to ERT providing an easy way to
> check font faces either in inline strings or resource files.
>
> The assertion syntax is based on Tree-sitter's syntax highlighter unit
> tests [2]. This makes it easy to port existing tree-sitter grammar
> tests to support both new-style ts-based major modes and the
> traditional ones.
>
> [1] https://lists.gnu.org/archive/html/emacs-devel/2023-11/msg00867.html
> [2] https://tree-sitter.github.io/tree-sitter/syntax-highlighting#unit-testing
Thanks for working on this, this is fantastic! I had a cursory look and 
it is very well written. It will be a great boon to the tree-sitter 
modes, which don't have tests for font-locking right now.

Yuan

Message #11 received at 67460 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Vladimir Kazanov <vekazanov <at> gmail.com>
Cc: 67460 <at> debbugs.gnu.org
Subject: Re: bug#67460: [PATCH] Add ert-font-lock
Date: Sat, 02 Dec 2023 14:50:17 +0200

> From: Vladimir Kazanov <vekazanov <at> gmail.com>
> Date: Sun, 26 Nov 2023 18:47:30 +0000
> 
> As suggested in emacs-devel@ [1], this patch adds ert-lont-lock.el to
> Emacs. Ert-font-lock is an extension to ERT providing an easy way to
> check font faces either in inline strings or resource files.
> 
> The assertion syntax is based on Tree-sitter's syntax highlighter unit
> tests [2]. This makes it easy to port existing tree-sitter grammar
> tests to support both new-style ts-based major modes and the
> traditional ones.

Thanks.

Byte-compiling this I get two warnings:

    ELC      emacs-lisp/ert-font-lock.elc

  In ert-font-lock--parse-macro-args:
  emacs-lisp/ert-font-lock.el:82:19: Warning: Unused lexical variable `keys'

  In ert-font-lock--comment-start-p:
  emacs-lisp/ert-font-lock.el:191:10: Warning: `derived-mode-p' called with 3 arguments, but accepts only 1

Could you please fix these and resubmit the patch?

Message #14 received at 67460 <at> debbugs.gnu.org (full text, mbox):

From: Vladimir Kazanov <vekazanov <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 67460 <at> debbugs.gnu.org
Subject: Re: bug#67460: [PATCH] Add ert-font-lock
Date: Sun, 3 Dec 2023 09:51:43 +0000

[Message part 1 (text/plain, inline)]

Hi Eli,

Thanks for looking into this!

Note to myself: I need to make byte-compiling into a habit. Anyway,
warnings fixed, here's the updated patch.

On Sat, 2 Dec 2023 at 12:50, Eli Zaretskii <eliz <at> gnu.org> wrote:
>
> > From: Vladimir Kazanov <vekazanov <at> gmail.com>
> > Date: Sun, 26 Nov 2023 18:47:30 +0000
> >
> > As suggested in emacs-devel@ [1], this patch adds ert-lont-lock.el to
> > Emacs. Ert-font-lock is an extension to ERT providing an easy way to
> > check font faces either in inline strings or resource files.
> >
> > The assertion syntax is based on Tree-sitter's syntax highlighter unit
> > tests [2]. This makes it easy to port existing tree-sitter grammar
> > tests to support both new-style ts-based major modes and the
> > traditional ones.
>
> Thanks.
>
> Byte-compiling this I get two warnings:
>
>     ELC      emacs-lisp/ert-font-lock.elc
>
>   In ert-font-lock--parse-macro-args:
>   emacs-lisp/ert-font-lock.el:82:19: Warning: Unused lexical variable `keys'
>
>   In ert-font-lock--comment-start-p:
>   emacs-lisp/ert-font-lock.el:191:10: Warning: `derived-mode-p' called with 3 arguments, but accepts only 1
>
> Could you please fix these and resubmit the patch?



-- 
Regards,

Vladimir Kazanov

[0001-Add-ert-font-lock.patch (text/x-patch, attachment)]

Message #19 received at 67460-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Vladimir Kazanov <vekazanov <at> gmail.com>
Cc: 67460-done <at> debbugs.gnu.org
Subject: Re: bug#67460: [PATCH] Add ert-font-lock
Date: Sun, 03 Dec 2023 15:19:17 +0200

> From: Vladimir Kazanov <vekazanov <at> gmail.com>
> Date: Sun, 3 Dec 2023 09:51:43 +0000
> Cc: 67460 <at> debbugs.gnu.org
> 
> Thanks for looking into this!
> 
> Note to myself: I need to make byte-compiling into a habit. Anyway,
> warnings fixed, here's the updated patch.

Thanks, installed on the master branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.