GNU bug report logs - #67466
[PATCH gnome-team] gnu: rygel: Update to 0.42.4.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 67466 in the body.
You can then email your comments to 67466 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vivien Kraus <vivien <at> planete-kraus.eu>
To: guix-patches <at> gnu.org
Cc: rg <at> raghavgururajan.name, liliana.prikler <at> gmail.com,
 maxim.cournoyer <at> gmail.com
Subject: [PATCH gnome-team] gnu: rygel: Update to 0.42.4.
Date: Sun, 26 Nov 2023 17:58:07 +0100

* gnu/packages/gnome.scm (rygel): Update to 0.42.4.
[arguments]: Convert to list of G-Expressions.
[propagated-inputs]: Add glib.

Change-Id: I17da7894a9626cd056c7c86ac6747acc0828e1ba
---
 gnu/packages/gnome.scm | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index d354327497..d6ee3493b5 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -1676,7 +1676,7 @@ (define-public sushi
 (define-public rygel
   (package
     (name "rygel")
-    (version "0.41.2")
+    (version "0.42.4")
     (source (origin
               (method url-fetch)
               (uri (string-append "mirror://gnome/sources/" name "/"
@@ -1684,12 +1684,12 @@ (define-public rygel
                                   name "-" version ".tar.xz"))
               (sha256
                (base32
-                "0wivd60hn115ar3hsrsa595kpxzp8gwq30ksh32qlq8j9dhlq65i"))))
+                "1xq36f0n42yall67ibqzqsdpvljbdanhy0lvkc8ncark5nmdy433"))))
     (build-system meson-build-system)
     (arguments
      ;; Disable the tracker plugin.
-     '(#:configure-flags
-       (list "-Dplugins=external,gst-launch,lms,media-export,
+     (list #:configure-flags
+           #~'("-Dplugins=external,gst-launch,lms,media-export,
 mpris,playbin,ruih,tracker3")))
     (native-inputs
      (list gettext-minimal
@@ -1719,6 +1719,9 @@ (define-public rygel
            libxslt
            libunistring
            tracker))
+    (propagated-inputs
+     ;; The .pc files require.private gmodule-2.0
+     (list glib))
     (synopsis "Share audio, video, and pictures with other devices")
     (description
      "Rygel is a home media solution (@dfn{UPnP AV MediaServer and

base-commit: e21f0cb7b7a87992004193cd56638ad961fe5928
-- 
2.41.0

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Vivien Kraus <vivien <at> planete-kraus.eu>
Cc: rg <at> raghavgururajan.name, liliana.prikler <at> gmail.com, guix-patches <at> gnu.org
Subject: Re: [PATCH gnome-team] gnu: rygel: Update to 0.42.4.
Date: Sun, 03 Dec 2023 18:56:29 -0500

Hello,

Vivien Kraus <vivien <at> planete-kraus.eu> writes:

> * gnu/packages/gnome.scm (rygel): Update to 0.42.4.
> [arguments]: Convert to list of G-Expressions.
> [propagated-inputs]: Add glib.
>
> Change-Id: I17da7894a9626cd056c7c86ac6747acc0828e1ba
> ---
>  gnu/packages/gnome.scm | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index d354327497..d6ee3493b5 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -1676,7 +1676,7 @@ (define-public sushi
>  (define-public rygel
>    (package
>      (name "rygel")
> -    (version "0.41.2")
> +    (version "0.42.4")
>      (source (origin
>                (method url-fetch)
>                (uri (string-append "mirror://gnome/sources/" name "/"
> @@ -1684,12 +1684,12 @@ (define-public rygel
>                                    name "-" version ".tar.xz"))
>                (sha256
>                 (base32
> -                "0wivd60hn115ar3hsrsa595kpxzp8gwq30ksh32qlq8j9dhlq65i"))))
> +                "1xq36f0n42yall67ibqzqsdpvljbdanhy0lvkc8ncark5nmdy433"))))
>      (build-system meson-build-system)
>      (arguments
>       ;; Disable the tracker plugin.
> -     '(#:configure-flags
> -       (list "-Dplugins=external,gst-launch,lms,media-export,
> +     (list #:configure-flags
> +           #~'("-Dplugins=external,gst-launch,lms,media-export,
>  mpris,playbin,ruih,tracker3")))

Nitpick: I prefer the #~(list "args" ...) style, which I find more readable.

Reviewed-by: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

-- 
Thanks,
Maxim

Message #11 received at 67466 <at> debbugs.gnu.org (full text, mbox):

From: Vivien Kraus <vivien <at> planete-kraus.eu>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: rg <at> raghavgururajan.name, 67466 <at> debbugs.gnu.org, liliana.prikler <at> gmail.com
Subject: [PATCH gnome-team v2] gnu: rygel: Improve style.
Date: Mon, 4 Dec 2023 18:27:05 +0100

* gnu/packages/gnome.scm (rygel) [#:configure-flags]: Use the 'list' syntax
istead of 'quote'.

Change-Id: I173b5872ebfa82855055145923cd2f1a1b4d68d1
---
Hi,

The patch was already applied, so I make a new commit.

I am sorry for the X-Debbugs-CC error on my side, I understand why it is
useful and I will systematically use it in the future for new submissions.

Best regards,

Vivien

 gnu/packages/gnome.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index c6437ce450..2bb0587d5f 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -1697,7 +1697,7 @@ (define-public rygel
     (arguments
      ;; Disable the tracker plugin.
      (list #:configure-flags
-           #~'("-Dplugins=external,gst-launch,lms,media-export,
+           #~(list "-Dplugins=external,gst-launch,lms,media-export,
 mpris,playbin,ruih,tracker3")))
     (native-inputs
      (list gettext-minimal

base-commit: 4c323c2f8308bba0e3295f3109d159c7b8f72838
-- 
2.41.0

Message #14 received at 67466 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Vivien Kraus <vivien <at> planete-kraus.eu>
Cc: rg <at> raghavgururajan.name, 67466 <at> debbugs.gnu.org, liliana.prikler <at> gmail.com
Subject: Re: [PATCH gnome-team v2] gnu: rygel: Improve style.
Date: Mon, 04 Dec 2023 18:05:47 -0500

Vivien Kraus <vivien <at> planete-kraus.eu> writes:

> * gnu/packages/gnome.scm (rygel) [#:configure-flags]: Use the 'list' syntax
> istead of 'quote'.
>
> Change-Id: I173b5872ebfa82855055145923cd2f1a1b4d68d1

Reviewed-by: Maxim Cournoyer <maxim.cournoyer <at> gmail>

-- 
Thanks,
Maxim

Message #19 received at 67466-done <at> debbugs.gnu.org (full text, mbox):

From: Vivien Kraus <vivien <at> planete-kraus.eu>
To: 67466-done <at> debbugs.gnu.org
Subject: Closing!
Date: Wed, 20 Dec 2023 00:16:52 +0100

It has been pushed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.