GNU bug report logs - #67520
29.1; Mention headers

Previous Next

Packages: emacs, gnus;

Reported by: Dan Jacobson <jidanni <at> jidanni.org>

Date: Wed, 29 Nov 2023 03:51:02 UTC

Severity: normal

Found in version 29.1

Fixed in version 30.1

Done: Eric Abrahamsen <eric <at> ericabrahamsen.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 67520 in the body.
You can then email your comments to 67520 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org, bugs <at> gnus.org:
bug#67520; Package emacs,gnus. (Wed, 29 Nov 2023 03:51:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Dan Jacobson <jidanni <at> jidanni.org>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org, bugs <at> gnus.org. (Wed, 29 Nov 2023 03:51:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dan Jacobson <jidanni <at> jidanni.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.1; Mention headers
Date: Wed, 29 Nov 2023 11:49:18 +0800
This docstring should mention the case where the user wants to forward
the entire message, including pristine headers.

He tries each in vain, finding that none include the headers.

C-c C-f runs the command gnus-summary-mail-forward (found in
gnus-summary-mode-map), which is an autoloaded interactive
native-compiled Lisp function in ‘gnus-msg.el’.

It is bound to C-c C-f and S o m.

(gnus-summary-mail-forward &optional ARG POST)

Forward the current message(s) to another user.
If process marks exist, forward all marked messages;
if ARG is nil, see ‘message-forward-as-mime’ and ‘message-forward-show-mml’;
if ARG is 1, decode the message and forward directly inline;
if ARG is 2, forward message as an rfc822 MIME section;
if ARG is 3, decode message and forward as an rfc822 MIME section;
if ARG is 4, forward message directly inline;
otherwise, use flipped ‘message-forward-as-mime’.
If POST, post instead of mail.
For the "inline" alternatives, also see the variable
‘message-forward-ignored-headers’.

[back]




Information forwarded to bug-gnu-emacs <at> gnu.org, bugs <at> gnus.org:
bug#67520; Package emacs,gnus. (Wed, 29 Nov 2023 12:57:01 GMT) Full text and rfc822 format available.

Message #8 received at 67520 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dan Jacobson <jidanni <at> jidanni.org>,
 Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 67520 <at> debbugs.gnu.org
Subject: Re: bug#67520: 29.1; Mention headers
Date: Wed, 29 Nov 2023 14:56:09 +0200
> From: Dan Jacobson <jidanni <at> jidanni.org>
> Date: Wed, 29 Nov 2023 11:49:18 +0800
> 
> This docstring should mention the case where the user wants to forward
> the entire message, including pristine headers.
> 
> He tries each in vain, finding that none include the headers.
> 
> C-c C-f runs the command gnus-summary-mail-forward (found in
> gnus-summary-mode-map), which is an autoloaded interactive
> native-compiled Lisp function in ‘gnus-msg.el’.
> 
> It is bound to C-c C-f and S o m.
> 
> (gnus-summary-mail-forward &optional ARG POST)
> 
> Forward the current message(s) to another user.
> If process marks exist, forward all marked messages;
> if ARG is nil, see ‘message-forward-as-mime’ and ‘message-forward-show-mml’;
> if ARG is 1, decode the message and forward directly inline;
> if ARG is 2, forward message as an rfc822 MIME section;
> if ARG is 3, decode message and forward as an rfc822 MIME section;
> if ARG is 4, forward message directly inline;
> otherwise, use flipped ‘message-forward-as-mime’.
> If POST, post instead of mail.
> For the "inline" alternatives, also see the variable
> ‘message-forward-ignored-headers’.

Eric, any comments?




Information forwarded to bug-gnu-emacs <at> gnu.org, bugs <at> gnus.org:
bug#67520; Package emacs,gnus. (Wed, 29 Nov 2023 15:32:01 GMT) Full text and rfc822 format available.

Message #11 received at 67520 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 67520 <at> debbugs.gnu.org, Dan Jacobson <jidanni <at> jidanni.org>
Subject: Re: bug#67520: 29.1; Mention headers
Date: Wed, 29 Nov 2023 07:31:14 -0800
Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Dan Jacobson <jidanni <at> jidanni.org>
>> Date: Wed, 29 Nov 2023 11:49:18 +0800
>> 
>> This docstring should mention the case where the user wants to forward
>> the entire message, including pristine headers.
>> 
>> He tries each in vain, finding that none include the headers.
>> 
>> C-c C-f runs the command gnus-summary-mail-forward (found in
>> gnus-summary-mode-map), which is an autoloaded interactive
>> native-compiled Lisp function in ‘gnus-msg.el’.
>> 
>> It is bound to C-c C-f and S o m.
>> 
>> (gnus-summary-mail-forward &optional ARG POST)
>> 
>> Forward the current message(s) to another user.
>> If process marks exist, forward all marked messages;
>> if ARG is nil, see ‘message-forward-as-mime’ and ‘message-forward-show-mml’;
>> if ARG is 1, decode the message and forward directly inline;
>> if ARG is 2, forward message as an rfc822 MIME section;
>> if ARG is 3, decode message and forward as an rfc822 MIME section;
>> if ARG is 4, forward message directly inline;
>> otherwise, use flipped ‘message-forward-as-mime’.
>> If POST, post instead of mail.
>> For the "inline" alternatives, also see the variable
>> ‘message-forward-ignored-headers’.
>
> Eric, any comments?

I didn't understand the request. The docstring should mention that none
of the calling options for `gnus-summary-mail-forward' include the all
the original headers?




Information forwarded to bug-gnu-emacs <at> gnu.org, bugs <at> gnus.org:
bug#67520; Package emacs,gnus. (Thu, 30 Nov 2023 06:03:01 GMT) Full text and rfc822 format available.

Message #14 received at 67520 <at> debbugs.gnu.org (full text, mbox):

From: Dan Jacobson <jidanni <at> jidanni.org>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 67520 <at> debbugs.gnu.org
Subject: Re: bug#67520: 29.1; Mention headers
Date: Thu, 30 Nov 2023 14:02:21 +0800
EA> I didn't understand the request. The docstring should mention that none
EA> of the calling options for `gnus-summary-mail-forward' include the all
EA> the original headers?

Yes. Please add to the docstring:

"This command does not forward headers along with the message.
To do so, use ........ instead."

(As half of users want to forward the headers along with the
message and the other half of the users don't.)





Information forwarded to bug-gnu-emacs <at> gnu.org, bugs <at> gnus.org:
bug#67520; Package emacs,gnus. (Mon, 04 Dec 2023 01:41:01 GMT) Full text and rfc822 format available.

Message #17 received at 67520 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Dan Jacobson <jidanni <at> jidanni.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 67520 <at> debbugs.gnu.org
Subject: Re: bug#67520: 29.1; Mention headers
Date: Sun, 03 Dec 2023 17:39:56 -0800
Dan Jacobson <jidanni <at> jidanni.org> writes:

> EA> I didn't understand the request. The docstring should mention that none
> EA> of the calling options for `gnus-summary-mail-forward' include the all
> EA> the original headers?
>
> Yes. Please add to the docstring:
>
> "This command does not forward headers along with the message.
> To do so, use ........ instead."
>
> (As half of users want to forward the headers along with the
> message and the other half of the users don't.)

Sorry, I'm still being slow here -- what are we suggesting the user use
instead? What goes in the ellipses?




Information forwarded to bug-gnu-emacs <at> gnu.org, bugs <at> gnus.org:
bug#67520; Package emacs,gnus. (Mon, 04 Dec 2023 03:31:02 GMT) Full text and rfc822 format available.

Message #20 received at 67520 <at> debbugs.gnu.org (full text, mbox):

From: Dan Jacobson <jidanni <at> jidanni.org>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 67520 <at> debbugs.gnu.org
Subject: Re: bug#67520: 29.1; Mention headers
Date: Mon, 04 Dec 2023 11:30:10 +0800
OK, then ths is a feature request. Users are often asked to forward 
complete pristine emails to various abuse investigation departments.
Gnus should offer such functionality.




Information forwarded to bug-gnu-emacs <at> gnu.org, bugs <at> gnus.org:
bug#67520; Package emacs,gnus. (Tue, 05 Dec 2023 04:27:02 GMT) Full text and rfc822 format available.

Message #23 received at 67520 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Dan Jacobson <jidanni <at> jidanni.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 67520 <at> debbugs.gnu.org
Subject: Re: bug#67520: 29.1; Mention headers
Date: Mon, 04 Dec 2023 20:26:33 -0800
On 12/04/23 11:30 AM, Dan Jacobson wrote:
> OK, then ths is a feature request. Users are often asked to forward
> complete pristine emails to various abuse investigation departments.
> Gnus should offer such functionality.

Okay, that's clearer! message.el is fairly convoluted, but it comes down
to `message-remove-ignored-headers'. That consults several options,
most importantly `message-forward-ignored-headers' and
`message-forward-included-headers'. The ignored headers are removed, as
you'd expect, but if anything at all is in the included headers, *only*
those included headers are... included. You lose everything else.

So what you really want is the option to (perhaps temporarily) set
`message-forward-included-headers' to nil. (Please try it out and
confirm.)

And the real question is how to offer this option to the user.
Everything is already thoroughly overloaded...




Information forwarded to bug-gnu-emacs <at> gnu.org, bugs <at> gnus.org:
bug#67520; Package emacs,gnus. (Tue, 05 Dec 2023 05:08:02 GMT) Full text and rfc822 format available.

Message #26 received at 67520 <at> debbugs.gnu.org (full text, mbox):

From: Dan Jacobson <jidanni <at> jidanni.org>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 67520 <at> debbugs.gnu.org
Subject: Re: bug#67520: 29.1; Mention headers
Date: Tue, 05 Dec 2023 13:06:48 +0800
>>>>> "EA" == Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

EA> And the real question is how to offer this option to the user.
EA> Everything is already thoroughly overloaded...

Yup, I just tested it and the only difference with the message before
gnus got its hands one it was

0a1
> From nobody Tue Dec  5 13:00:45 2023
65a67
> X-Gnus-Mail-Source: maildir:~/Maildir/new
67a70,71
> MIME-Version: 1.0
> Content-Type: text/plain
89a94
>

And it is good that the X-Gnus-Mail-Source doesn't show up in the
forwarded message too.

So you are on the right track.




Information forwarded to bug-gnu-emacs <at> gnu.org, bugs <at> gnus.org:
bug#67520; Package emacs,gnus. (Wed, 06 Dec 2023 15:10:01 GMT) Full text and rfc822 format available.

Message #29 received at 67520 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Dan Jacobson <jidanni <at> jidanni.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 67520 <at> debbugs.gnu.org
Subject: Re: bug#67520: 29.1; Mention headers
Date: Wed, 06 Dec 2023 07:09:00 -0800
On 12/05/23 13:06 PM, Dan Jacobson wrote:
>>>>>> "EA" == Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>
> EA> And the real question is how to offer this option to the user.
> EA> Everything is already thoroughly overloaded...
>
> Yup, I just tested it and the only difference with the message before
> gnus got its hands one it was
>
> 0a1
>> From nobody Tue Dec  5 13:00:45 2023
> 65a67
>> X-Gnus-Mail-Source: maildir:~/Maildir/new
> 67a70,71
>> MIME-Version: 1.0
>> Content-Type: text/plain
> 89a94
>>
>
> And it is good that the X-Gnus-Mail-Source doesn't show up in the
> forwarded message too.
>
> So you are on the right track.

What I can offer you is a "symbolic prefix" (see the Gnus manual section
of the same name). What that means is that, in addition to the usual
numerical prefixes, you could also type "M-i a" before the command ("a"
here standing for "all headers") and the forwarding code would let-bind
`message-forward-included-headers' to nil.

That's the best I can come up with.




Information forwarded to bug-gnu-emacs <at> gnu.org, bugs <at> gnus.org:
bug#67520; Package emacs,gnus. (Fri, 08 Dec 2023 05:18:02 GMT) Full text and rfc822 format available.

Message #32 received at 67520 <at> debbugs.gnu.org (full text, mbox):

From: Dan Jacobson <jidanni <at> jidanni.org>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 67520 <at> debbugs.gnu.org
Subject: Re: bug#67520: 29.1; Mention headers
Date: Fri, 08 Dec 2023 13:17:02 +0800
OK, great. Now all that needs to be done is when the user types C-h C-c C-f
they should see at the bottom:
-----
To include ALL headers in your forwarded message, use

M-i a C-c C-f
------
And of course C-c C-f runs the command gnus-summary-mail-forward needs
to be changed to accept the prefix. (info "(gnus) Symbolic Prefixes")




Information forwarded to bug-gnu-emacs <at> gnu.org, bugs <at> gnus.org:
bug#67520; Package emacs,gnus. (Fri, 08 Dec 2023 17:43:02 GMT) Full text and rfc822 format available.

Message #35 received at 67520 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Dan Jacobson <jidanni <at> jidanni.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 67520 <at> debbugs.gnu.org
Subject: Re: bug#67520: 29.1; Mention headers
Date: Fri, 08 Dec 2023 09:42:10 -0800
[Message part 1 (text/plain, inline)]
On 12/08/23 13:17 PM, Dan Jacobson wrote:
> OK, great. Now all that needs to be done is when the user types C-h C-c C-f
> they should see at the bottom:
> -----
> To include ALL headers in your forwarded message, use
>
> M-i a C-c C-f
> ------
> And of course C-c C-f runs the command gnus-summary-mail-forward needs
> to be changed to accept the prefix. (info "(gnus) Symbolic Prefixes")

Here's what I've got so far.

[0001-Provide-option-to-forward-Gnus-messages-with-all-mos.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org, bugs <at> gnus.org:
bug#67520; Package emacs,gnus. (Fri, 08 Dec 2023 22:25:02 GMT) Full text and rfc822 format available.

Message #38 received at 67520 <at> debbugs.gnu.org (full text, mbox):

From: jidanni <jidanni <at> jidanni.org>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 67520 <at> debbugs.gnu.org
Subject: Re: bug#67520: 29.1; Mention headers
Date: Sat, 9 Dec 2023 06:24:37 +0800
Cool! Thanks for working on it.




bug marked as fixed in version 30.1, send any further explanations to 67520 <at> debbugs.gnu.org and Dan Jacobson <jidanni <at> jidanni.org> Request was from Eric Abrahamsen <eric <at> ericabrahamsen.net> to control <at> debbugs.gnu.org. (Tue, 12 Dec 2023 18:03:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 10 Jan 2024 12:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 122 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.