GNU bug report logs - #67537
[PATCH 0/4] Update weirdware packages.

Previous Next

Package: guix-patches;

Reported by: Sergey Trofimov <sarg <at> sarg.org.ru>

Date: Wed, 29 Nov 2023 21:32:02 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 67537 in the body.
You can then email your comments to 67537 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to andrew <at> trop.in, cox.katherine.e+guix <at> gmail.com, liliana.prikler <at> gmail.com, guix-patches <at> gnu.org:
bug#67537; Package guix-patches. (Wed, 29 Nov 2023 21:32:03 GMT) Full text and rfc822 format available.
Acknowledgement sent to Sergey Trofimov <sarg <at> sarg.org.ru>:
New bug report received and forwarded. Copy sent to andrew <at> trop.in, cox.katherine.e+guix <at> gmail.com, liliana.prikler <at> gmail.com, guix-patches <at> gnu.org. (Wed, 29 Nov 2023 21:32:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sergey Trofimov <sarg <at> sarg.org.ru>
To: guix-patches <at> gnu.org
Cc: Sergey Trofimov <sarg <at> sarg.org.ru>
Subject: [PATCH 0/4] Update weirdware packages.
Date: Wed, 29 Nov 2023 22:31:09 +0100

Hello guix,

I've noticed that recently added weirdware emacs packages use `inputs` to
declare dependencies. I think `propagated-inputs` make more sense here as
these are required in runtime.

Sergey Trofimov (4):
  gnu: emacs-dnt: Propagate inputs.
  gnu: emacs-debase: Remove unused inputs.
  gnu: emacs-discomfort: Propagate inputs.
  gnu: emacs-hyperspace: Propagated inputs.

 gnu/packages/emacs-xyz.scm | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)


base-commit: bdbb9dc27a590b08651d058f06a42caa26e04abb
-- 
2.41.0
Information forwarded to andrew <at> trop.in, cox.katherine.e+guix <at> gmail.com, liliana.prikler <at> gmail.com, guix-patches <at> gnu.org:
bug#67537; Package guix-patches. (Wed, 29 Nov 2023 21:34:02 GMT) Full text and rfc822 format available.

Message #8 received at 67537 <at> debbugs.gnu.org (full text, mbox):

From: Sergey Trofimov <sarg <at> sarg.org.ru>
To: 67537 <at> debbugs.gnu.org
Cc: Sergey Trofimov <sarg <at> sarg.org.ru>
Subject: [PATCH 1/4] gnu: emacs-dnt: Propagate inputs.
Date: Wed, 29 Nov 2023 22:33:04 +0100

* gnu/packages/emacs-xyz.scm (emacs-dnt):
Use propagated-inputs for runtime dependencies.
---
 gnu/packages/emacs-xyz.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 996142dc3e..d50b76d099 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -3310,7 +3310,7 @@ (define-public emacs-dnt
          (file-name (git-file-name name version))
          (sha256
           (base32 "1bls9j1ibw0npjapslbrh6nmlbn3d4ajhjygsqlf6h9qg12sxm3r"))))
-      (inputs (list emacs-s))
+      (propagated-inputs (list emacs-s))
       (build-system emacs-build-system)
       (home-page "https://codeberg.org/emacs-weirdware/dnt")
       (synopsis "Strip trackers from URLs")
-- 
2.41.0
Information forwarded to andrew <at> trop.in, cox.katherine.e+guix <at> gmail.com, liliana.prikler <at> gmail.com, guix-patches <at> gnu.org:
bug#67537; Package guix-patches. (Wed, 29 Nov 2023 21:34:02 GMT) Full text and rfc822 format available.

Message #11 received at 67537 <at> debbugs.gnu.org (full text, mbox):

From: Sergey Trofimov <sarg <at> sarg.org.ru>
To: 67537 <at> debbugs.gnu.org
Cc: Sergey Trofimov <sarg <at> sarg.org.ru>
Subject: [PATCH 2/4] gnu: emacs-debase: Remove unused inputs.
Date: Wed, 29 Nov 2023 22:33:05 +0100

* gnu/packages/emacs-xyz.scm (emacs-debase):
Remove empty inputs list.
---
 gnu/packages/emacs-xyz.scm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index d50b76d099..a832501f55 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -34906,7 +34906,6 @@ (define-public emacs-debase
          (sha256
           (base32 "112vk1svnc6516vhs47sx5jw6bg8lwrc15l99dxj0sc313lxjy3k"))))
       (build-system emacs-build-system)
-      (inputs (list))
       (home-page "https://codeberg.org/emacs-weirdware/debase")
       (synopsis "D-Bus convenience layer for Emacs")
       (description
-- 
2.41.0
Information forwarded to andrew <at> trop.in, cox.katherine.e+guix <at> gmail.com, liliana.prikler <at> gmail.com, guix-patches <at> gnu.org:
bug#67537; Package guix-patches. (Wed, 29 Nov 2023 21:34:03 GMT) Full text and rfc822 format available.

Message #14 received at 67537 <at> debbugs.gnu.org (full text, mbox):

From: Sergey Trofimov <sarg <at> sarg.org.ru>
To: 67537 <at> debbugs.gnu.org
Cc: Sergey Trofimov <sarg <at> sarg.org.ru>
Subject: [PATCH 3/4] gnu: emacs-discomfort: Propagate inputs.
Date: Wed, 29 Nov 2023 22:33:06 +0100

* gnu/packages/emacs-xyz.scm (emacs-discomfort):
Use propagated-inputs for runtime dependencies.
---
 gnu/packages/emacs-xyz.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index a832501f55..f72fb180b8 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -34929,7 +34929,7 @@ (define-public emacs-discomfort
          (sha256
           (base32 "01p4bfiasqxfmp9x1bxdc7763bh712d3vlp2014y8pzrwb1jqdaq"))))
       (build-system emacs-build-system)
-      (inputs (list emacs-debase))
+      (propagated-inputs (list emacs-debase))
       (home-page "https://codeberg.org/emacs-weirdware/discomfort")
       (synopsis "User interface to mount & unmount disks in Emacs.")
       (description "Discomfort is an interface to mount and unmount disks in Emacs, using UDisks2.")
-- 
2.41.0
Information forwarded to andrew <at> trop.in, cox.katherine.e+guix <at> gmail.com, liliana.prikler <at> gmail.com, guix-patches <at> gnu.org:
bug#67537; Package guix-patches. (Wed, 29 Nov 2023 21:35:01 GMT) Full text and rfc822 format available.

Message #17 received at 67537 <at> debbugs.gnu.org (full text, mbox):

From: Sergey Trofimov <sarg <at> sarg.org.ru>
To: 67537 <at> debbugs.gnu.org
Cc: Sergey Trofimov <sarg <at> sarg.org.ru>
Subject: [PATCH 4/4] gnu: emacs-hyperspace: Propagated inputs.
Date: Wed, 29 Nov 2023 22:33:07 +0100

* gnu/packages/emacs-xyz.scm (emacs-hyperspace):
Use propagated inputs for runtime dependencies.
---
 gnu/packages/emacs-xyz.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index f72fb180b8..c079d740ec 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -36504,7 +36504,7 @@ (define-public emacs-hyperspace
          (sha256
           (base32 "19h3d12a99i7a92k3iw4zmjmw3dazsgnkc6j4965h033r1s40amx"))))
       (build-system emacs-build-system)
-      (inputs (list emacs-s))
+      (propagated-inputs (list emacs-s))
       (home-page "https://codeberg.org/emacs-weirdware/hyperspace")
       (synopsis "Get there from here")
       (description
-- 
2.41.0
Information forwarded to guix-patches <at> gnu.org:
bug#67537; Package guix-patches. (Wed, 29 Nov 2023 21:56:01 GMT) Full text and rfc822 format available.

Message #20 received at 67537 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Sergey Trofimov <sarg <at> sarg.org.ru>, 67537 <at> debbugs.gnu.org
Cc: Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: [bug#67537] [PATCH 0/4] Update weirdware packages.
Date: Wed, 29 Nov 2023 22:55:22 +0100

Am Mittwoch, dem 29.11.2023 um 22:31 +0100 schrieb Sergey Trofimov:
> Hello guix,
> 
> I've noticed that recently added weirdware emacs packages use
> `inputs` to
> declare dependencies. I think `propagated-inputs` make more sense
> here as
> these are required in runtime.
> 
> Sergey Trofimov (4):
>   gnu: emacs-dnt: Propagate inputs.
>   gnu: emacs-debase: Remove unused inputs.
>   gnu: emacs-discomfort: Propagate inputs.
>   gnu: emacs-hyperspace: Propagated inputs.
Nice catch.  LGTM.
Reply sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
You have taken responsibility. (Thu, 04 Jan 2024 11:40:02 GMT) Full text and rfc822 format available.
Notification sent to Sergey Trofimov <sarg <at> sarg.org.ru>:
bug acknowledged by developer. (Thu, 04 Jan 2024 11:40:02 GMT) Full text and rfc822 format available.

Message #25 received at 67537-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 67537-done <at> debbugs.gnu.org, Sergey Trofimov <sarg <at> sarg.org.ru>,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: [bug#67537] [PATCH 0/4] Update weirdware packages.
Date: Thu, 04 Jan 2024 12:38:43 +0100

Hello,

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> Am Mittwoch, dem 29.11.2023 um 22:31 +0100 schrieb Sergey Trofimov:
>> Hello guix,
>> 
>> I've noticed that recently added weirdware emacs packages use
>> `inputs` to
>> declare dependencies. I think `propagated-inputs` make more sense
>> here as
>> these are required in runtime.
>> 
>> Sergey Trofimov (4):
>>   gnu: emacs-dnt: Propagate inputs.
>>   gnu: emacs-debase: Remove unused inputs.
>>   gnu: emacs-discomfort: Propagate inputs.
>>   gnu: emacs-hyperspace: Propagated inputs.
> Nice catch.  LGTM.

Applied. Thanks.

Regards,
-- 
Nicolas Goaziou
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 01 Feb 2024 12:24:12 GMT) Full text and rfc822 format available.
This bug report was last modified 1 year and 98 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.