GNU bug report logs -
#67570
[PATCH] gnu: kubo: Fix build.
Previous Next
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 67570 in the body.
You can then email your comments to 67570 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
guix-patches <at> gnu.org:
bug#67570; Package
guix-patches.
(Fri, 01 Dec 2023 19:10:01 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
"Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>:
New bug report received and forwarded. Copy sent to
guix-patches <at> gnu.org.
(Fri, 01 Dec 2023 19:10:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Hello,
this patch series fixes Kubo build.
[0001-gnu-kubo-Fix-build.patch (text/x-diff, attachment)]
[0002-gnu-kubo-Fix-the-package-style.patch (text/x-diff, attachment)]
[Message part 4 (text/plain, inline)]
- avp
--
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE B57C E9C5 A2D9 0898 A02F
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#67570; Package
guix-patches.
(Sat, 02 Dec 2023 10:06:01 GMT)
Full text and
rfc822 format available.
Message #8 received at 67570 <at> debbugs.gnu.org (full text, mbox):
Hi,
I spoke too fast…
"Artyom V. Poptsov" <poptsov.artyom <at> gmail.com> skribis:
> + (let ((p (package-input-rewriting
> + `((,go-golang-org-x-sys . ,go-golang-org-x-sys-0.8))
> + #:deep? #true)))
> + (cons go-golang-org-x-sys-0.8
> + (map p
> + (list go-github-com-alecthomas-units
> + ;; TODO: needs to be updated first
> + ;; go-github-com-blang-semver
> + go-github-com-cespare-xxhash
It does fix the build, but it’s a bit heavy-handed: every time we
compute the kubo derivation, we go through that graph rewriting, which
is quite expensive.
Can you think of another way this could be fixed? What if we don’t
replace go-golang-org-x-sys everywhere? Or perhaps there’s a trick that
would allow us to build with go-golang-org-x-sys 0.4?
In parallel perhaps we should work on upgrading go-golang-org-x-sys
altogether?
WDYT?
Ludo’.
Removed tag(s) patch.
Request was from
Ludovic Courtès <ludo <at> gnu.org>
to
control <at> debbugs.gnu.org.
(Sat, 02 Dec 2023 10:06:02 GMT)
Full text and
rfc822 format available.
Information forwarded
to
guix-patches <at> gnu.org:
bug#67570; Package
guix-patches.
(Sat, 09 Dec 2023 08:23:01 GMT)
Full text and
rfc822 format available.
Message #13 received at 67570 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Hello Ludovic!
> It does fix the build, but it’s a bit heavy-handed: every time we
> compute the kubo derivation, we go through that graph rewriting, which
> is quite expensive.
Agreed, I just wanted to make a "quick fix" that works.
> Can you think of another way this could be fixed? What if we don’t
> replace go-golang-org-x-sys everywhere? Or perhaps there’s a trick that
> would allow us to build with go-golang-org-x-sys 0.4?
> In parallel perhaps we should work on upgrading go-golang-org-x-sys
> altogether?
Alright, I tried to update "go-golang-org-x-sys" to 0.8.0, here's the
patch:
[0001-gnu-go-golang-org-x-sys-Update-to-0.8.0.patch (text/x-diff, attachment)]
[Message part 3 (text/plain, inline)]
It seems that the dependent packages are fine with that. I haven't
checked everything but I did some cherry-picking across the dependent
packages and build some of them and found no build errors. Please find
my check-list attached.
[go-golang-org-x-sys-0.8.0-upgrade-check.org (application/vnd.lotus-organizer, attachment)]
[Message part 5 (text/plain, inline)]
Thanks,
- avp
--
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE B57C E9C5 A2D9 0898 A02F
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#67570; Package
guix-patches.
(Sun, 10 Dec 2023 21:24:02 GMT)
Full text and
rfc822 format available.
Message #16 received at 67570 <at> debbugs.gnu.org (full text, mbox):
Hi,
"Artyom V. Poptsov" <poptsov.artyom <at> gmail.com> skribis:
>> Can you think of another way this could be fixed? What if we don’t
>> replace go-golang-org-x-sys everywhere? Or perhaps there’s a trick that
>> would allow us to build with go-golang-org-x-sys 0.4?
>
>> In parallel perhaps we should work on upgrading go-golang-org-x-sys
>> altogether?
>
> Alright, I tried to update "go-golang-org-x-sys" to 0.8.0, here's the
> patch:
>
> From 6022d28be487d06e9987785db1240355c080f459 Mon Sep 17 00:00:00 2001
> Message-ID: <6022d28be487d06e9987785db1240355c080f459.1702109906.git.poptsov.artyom <at> gmail.com>
> From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
> Date: Sat, 9 Dec 2023 11:09:26 +0300
> Subject: [PATCH] gnu: go-golang-org-x-sys: Update to 0.8.0.
>
> * gnu/packages/golang.scm (go-golang-org-x-sys): Update to 0.8.0.
> (go-golang-org-x-sys-0.8): Remove.
> (go-github-com-quic-go-quic-go, go-github-com-quic-go-qtls-go1-20):
> Use the new version of "go-golang-org-x-sys".
> * gnu/packages/networking.scm (yggdrasil): Use the new version of
> "go-golang-org-x-sys".
> [propagated-inputs]: Don't rewrite inputs; add "go-golang-org-x-sys".
This is being built:
https://qa.guix.gnu.org/issue/67570
Let’s keep an eye on it and see how it goes.
Thanks,
Ludo’.
Information forwarded
to
guix-patches <at> gnu.org:
bug#67570; Package
guix-patches.
(Fri, 29 Dec 2023 09:56:01 GMT)
Full text and
rfc822 format available.
Message #19 received at 67570 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Hello!
> This is being built:
>
> https://qa.guix.gnu.org/issue/67570
So what is the status of this? Last time I checked the link the
information about the build was gone and it's not obvious for me how to
get this info again.
Before I saw that some new packages were failing, I'd like to check if I
can fix them.
Could you provide a new link or the info itself?
Thanks!
- avp
--
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE B57C E9C5 A2D9 0898 A02F
[signature.asc (application/pgp-signature, inline)]
Reply sent
to
Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility.
(Sun, 07 Jan 2024 14:49:02 GMT)
Full text and
rfc822 format available.
Notification sent
to
"Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>:
bug acknowledged by developer.
(Sun, 07 Jan 2024 14:49:02 GMT)
Full text and
rfc822 format available.
Message #24 received at 67570-done <at> debbugs.gnu.org (full text, mbox):
Hi!
"Artyom V. Poptsov" <poptsov.artyom <at> gmail.com> skribis:
>> This is being built:
>>
>> https://qa.guix.gnu.org/issue/67570
>
> So what is the status of this? Last time I checked the link the
> information about the build was gone and it's not obvious for me how to
> get this info again.
>
> Before I saw that some new packages were failing, I'd like to check if I
> can fix them.
>
> Could you provide a new link or the info itself?
Unfortunately I’m not sure why qa.guix is no longer providing any info,
and I don’t know how to get it back. Chris?
Anyhow, I built Kubo with this patch and got substitutes from
bordeaux.guix for all its dependencies; Kubo itself built fine. So I’m
proposing to apply the patch and see from there whether anything needs
fixing. It’s suboptimal, but that’s what we have.
Thanks,
Ludo’.
Information forwarded
to
guix-patches <at> gnu.org:
bug#67570; Package
guix-patches.
(Sun, 07 Jan 2024 15:38:01 GMT)
Full text and
rfc822 format available.
Message #27 received at 67570 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Ludovic Courtès <ludo <at> gnu.org> writes:
> Hi!
>
> "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com> skribis:
>
>>> This is being built:
>>>
>>> https://qa.guix.gnu.org/issue/67570
>>
>> So what is the status of this? Last time I checked the link the
>> information about the build was gone and it's not obvious for me how to
>> get this info again.
>>
>> Before I saw that some new packages were failing, I'd like to check if I
>> can fix them.
>>
>> Could you provide a new link or the info itself?
>
> Unfortunately I’m not sure why qa.guix is no longer providing any info,
> and I don’t know how to get it back. Chris?
Looks like these patches were sent long enough ago that they've dropped
out of the fixed number of recent patches that QA looks at [1].
1: https://git.cbaines.net/guix/qa-frontpage/tree/scripts/guix-qa-frontpage.in#n154
You can resend the series to get QA to pay attention again, but current
QA isn't really working anyway due to a number of issues.
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#67570; Package
guix-patches.
(Mon, 08 Jan 2024 17:04:01 GMT)
Full text and
rfc822 format available.
Message #30 received at 67570 <at> debbugs.gnu.org (full text, mbox):
Hi Chris!
Christopher Baines <mail <at> cbaines.net> skribis:
> Looks like these patches were sent long enough ago that they've dropped
> out of the fixed number of recent patches that QA looks at [1].
Would it be possible to keep previous build results beyond that number,
only marking them as “archived” or similar? (And then after a longer
period of time, they can be removed altogether.)
It would allow us to get useful info even for old patches.
Thanks,
Ludo’.
Information forwarded
to
guix-patches <at> gnu.org:
bug#67570; Package
guix-patches.
(Mon, 08 Jan 2024 17:15:02 GMT)
Full text and
rfc822 format available.
Message #33 received at 67570-done <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Hello,
as far as I remember, one of the packages that was failing is
"go-github-com-charmbracelet-glamour" -- this is not directly related to
"go-golang-org-x-sys" as the package build has started failing before my
patch, but anyways. Yesterday I sent a patch that should fix
"go-github-com-charmbracelet-glamour" build:
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68311
- avp
--
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE B57C E9C5 A2D9 0898 A02F
[signature.asc (application/pgp-signature, inline)]
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org.
(Tue, 06 Feb 2024 12:24:13 GMT)
Full text and
rfc822 format available.
This bug report was last modified 1 year and 93 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.