GNU bug report logs - #67574
oci-container-service: hotfix

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 67574 in the body.
You can then email your comments to 67574 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: paul <goodoldpaul <at> autistici.org>
To: guix-patches <at> gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>
Subject: oci-container-service: hotfix
Date: Fri, 1 Dec 2023 23:38:57 +0100

Hello Ludo’ ,

I just managed to read my Guix email after some  time. I just guix 
pulled and realized there's a bug at [0]. The fix is trivial and I'm 
sending it as a patch. I'm also working on a test suite to prevent this 
to happen in the future.


Thanks for all your work,

giacomo



[0]: 
https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/services/docker.scm#n377

Message #8 received at 67574 <at> debbugs.gnu.org (full text, mbox):

From: Giacomo Leidi <goodoldpaul <at> autistici.org>
To: 67574 <at> debbugs.gnu.org
Cc: Giacomo Leidi <goodoldpaul <at> autistici.org>
Subject: [PATCH] services: Fix oci-container-service-type container user.
Date: Fri,  1 Dec 2023 23:45:05 +0100

The oci-container-configuration supports two user fields: one is the
user, from the host system, under whose authority the OCI-backed
Shepherd service is run; the other is an optional user/UID that can be
passed to the docker run invokation to override the user defined in the
OCI image.

The user from the host system is incorrectly passed to docker run
command, this patches reverts the incorrect behavior and passes the
correct container-user field value.

* gnu/services/docker.scm (oci-container-configuration): Fix the user
passed to the docker run invokation.
---
 gnu/services/docker.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/services/docker.scm b/gnu/services/docker.scm
index ebea0a473a..72ef7d74db 100644
--- a/gnu/services/docker.scm
+++ b/gnu/services/docker.scm
@@ -374,7 +374,7 @@ (define oci-container-configuration->options
           (network
            (oci-container-configuration-network config))
           (user
-           (oci-container-configuration-user config))
+           (oci-container-configuration-container-user config))
           (workdir
            (oci-container-configuration-workdir config)))
       (apply append

base-commit: 842a11f1caa1bb929c427722ad9d7b7c1ff65727
-- 
2.41.0

Message #13 received at 67574-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Giacomo Leidi <goodoldpaul <at> autistici.org>
Cc: 67574-done <at> debbugs.gnu.org
Subject: Re: bug#67574: oci-container-service: hotfix
Date: Sun, 10 Dec 2023 22:23:53 +0100

Giacomo Leidi <goodoldpaul <at> autistici.org> skribis:

> The oci-container-configuration supports two user fields: one is the
> user, from the host system, under whose authority the OCI-backed
> Shepherd service is run; the other is an optional user/UID that can be
> passed to the docker run invokation to override the user defined in the
> OCI image.
>
> The user from the host system is incorrectly passed to docker run
> command, this patches reverts the incorrect behavior and passes the
> correct container-user field value.
>
> * gnu/services/docker.scm (oci-container-configuration): Fix the user
> passed to the docker run invokation.

Applied, thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.