GNU logs - #67593, boring messages

Message sent to bug-coreutils@HIDDEN:

Subject: bug#67593: `split --number=l/N` no longer splits evenly
Resent-From: Victor Engmark <victor@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-coreutils@HIDDEN
Resent-Date: Sun, 03 Dec 2023 00:26:01 +0000
Resent-Message-ID: <handler.67593.B.170156314219460 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 67593 <at> debbugs.gnu.org
Message-ID: <e965589eeb832a95c0d107345244e928f57f060d.camel@HIDDEN>
From: Victor Engmark <victor@HIDDEN>
Date: Sun, 03 Dec 2023 13:25:01 +1300
Autocrypt: addr=victor@HIDDEN; prefer-encrypt=mutual;
 keydata=mDMEZQ/G5hYJKwYBBAHaRw8BAQdAZNkbxswUuLGnj1OYtA8j4Zc8ECWXP65YMaJ8CXoPboy0JFZpY3RvciBFbmdtYXJrIDx2aWN0b3JAZW5nbWFyay5uYW1lPoiZBBMWCgBBFiEE8cX2MBPl3i+1dNQqzl6zg0TYXbYFAmUPxuYCGwMFCRLMAwAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQzl6zg0TYXbap5QEA6lzeeVuncmbEt+BQROEz7/8dbNz8gxgr9b7U61P7RdsA/23wIERJqzWj4beDPKC/PrujaRaJibYG5yvh41BWTzYFuDgEZQ/G5hIKKwYBBAGXVQEFAQEHQOTKFfUlk8M1kvjTORDMxJG0EK97yWsrqtnFZ7/FMgVnAwEIB4h+BBgWCgAmFiEE8cX2MBPl3i+1dNQqzl6zg0TYXbYFAmUPxuYCGwwFCRLMAwAACgkQzl6zg0TYXbarUwEAwXCvoKR374iCCAW0HV7d0jv/HAfZva/C1tZmRn+A1cIBAJ2a4M4vXEoop46NA1AlYDZNBW4NaIS+Uhdjks2qeWQK
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.1 
MIME-Version: 1.0
Received-SPF: pass client-ip=2a01:5b40:0:3006::1;
 envelope-from=victor@HIDDEN; helo=smtp.domeneshop.no
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

Hi all

Commit fb6fc7f3ce6b0b70a5df7f605e71c4f8541e256b (part of v9.2)
introduced a regression in how `split --number=3Dl/N` works.

Test script `tests/split/l-chunk2.sh`:

```
#!/bin/sh

. "${srcdir=3D.}/tests/init.sh"; path_prepend_ ./src
print_ver_ split

printf 'first\n' > exp1 || framework_failure_
printf 'second\n' > exp2 || framework_failure_
cat exp1 exp2 > in || framework_failure_
split -e -n l/2 in || framework_failure_
compare exp1 xaa || fail=3D1
compare exp2 xab || fail=3D1

Exit $fail
```

Relevant test output:

```
+ diff -u exp1 xaa
--- exp1	2023-12-03 12:42:50.511334991 +1300
+++ xaa	2023-12-03 12:42:50.513334908 +1300
@@ -1 +1,2 @@
 first
+second
```

and

```
+ diff -u exp2 xab
diff: xab: No such file or directory
```

In other words, it doesn't split the file at all, despite it containing
two lines of content.

The bug is still present in current master (commit
73d119f4f8052a9fb6cef13cd9e75d5a4e23311a).

Bisected on NixOS 23.11 using the following script:

```
#!/bin/sh

set -e

export CFLAGS=3D-w # Avoid build failure

git submodule update
git clean -fdx --exclude=3Dbisect.sh --exclude=3Dtests/split/l-chunk2.sh

./bootstrap
autoconf
./configure
make
make check TESTS=3Dtests/split/l-chunk2.sh SUBDIRS=3D.
```

and these commands:

```
git bisect start master v9.1
git bisect run ./bisect.sh
```

Cheers
Victor

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Victor Engmark <victor@HIDDEN>
Subject: bug#67593: Acknowledgement (`split --number=l/N` no longer splits
 evenly)
Message-ID: <handler.67593.B.170156314219460.ack <at> debbugs.gnu.org>
References: <e965589eeb832a95c0d107345244e928f57f060d.camel@HIDDEN>
X-Gnu-PR-Message: ack 67593
X-Gnu-PR-Package: coreutils
Reply-To: 67593 <at> debbugs.gnu.org
Date: Sun, 03 Dec 2023 00:26:01 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-coreutils@HIDDEN

If you wish to submit further information on this problem, please
send it to 67593 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
67593: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D67593
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-coreutils@HIDDEN:

Subject: bug#67593: `split --number=l/N` no longer splits evenly
Resent-From: Paul Eggert <eggert@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-coreutils@HIDDEN
Resent-Date: Sun, 03 Dec 2023 09:38:01 +0000
Resent-Message-ID: <handler.67593.B67593.170159628020095 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Victor Engmark <victor@HIDDEN>
Cc: 67593 <at> debbugs.gnu.org
Message-ID: <fd60967a-6dd1-4f38-98fb-e253c64a40a0@HIDDEN>
Date: Sun, 3 Dec 2023 01:37:37 -0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
References: <e965589eeb832a95c0d107345244e928f57f060d.camel@HIDDEN>
From: Paul Eggert <eggert@HIDDEN>
Organization: UCLA Computer Science Department
In-Reply-To: <e965589eeb832a95c0d107345244e928f57f060d.camel@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

That's not a bug, in that 'split' is behaving as documented. The first 
input line is one byte shorter than the second one. 'Split' divides the 
input into two regions, and because the first region happens to be one 
byte longer than the second region both input lines are sent to the 
first output file.

In older coreutils, 'split' used a different algorithm to compute region 
sizes, which worked better for your test case but considerably worse in 
others. For example, in older coreutils:

seq 50 >in
split -n l/71 in

created 43 files of size 0, 9 files of size 2, 18 files of size 3, and 
one file of size 69. Current coreutils splits much better: it creates 21 
files of size 0, 9 files of size 2, and 41 files of size 3.

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 3 Dec 2023 09:38:38 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Dec 03 04:38:38 2023
Received: from localhost ([127.0.0.1]:59146 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r9ivu-0005FN-6y
	for submit <at> debbugs.gnu.org; Sun, 03 Dec 2023 04:38:38 -0500
Received: from mail.cs.ucla.edu ([131.179.128.66]:51658)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eggert@HIDDEN>) id 1r9ivr-0005F8-Qr
 for control <at> debbugs.gnu.org; Sun, 03 Dec 2023 04:38:36 -0500
Received: from localhost (localhost [127.0.0.1])
 by mail.cs.ucla.edu (Postfix) with ESMTP id 9ABBB3C011BE9
 for <control <at> debbugs.gnu.org>; Sun,  3 Dec 2023 01:38:20 -0800 (PST)
Received: from mail.cs.ucla.edu ([127.0.0.1])
 by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032)
 with ESMTP id 82vIGM6vhjNU for <control <at> debbugs.gnu.org>;
 Sun,  3 Dec 2023 01:38:20 -0800 (PST)
Received: from localhost (localhost [127.0.0.1])
 by mail.cs.ucla.edu (Postfix) with ESMTP id 094483C011BEA
 for <control <at> debbugs.gnu.org>; Sun,  3 Dec 2023 01:38:20 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu 094483C011BEA
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu;
 s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1701596300;
 bh=ZXg1iTUrBJ8YEHduX53db6FvPfgmCAWwlPKne8bgeEk=;
 h=Message-ID:Date:MIME-Version:To:From;
 b=nxJQ9h9Tx+SMdMSeHA7uOo4YrlMQk06H1Co4A8EAD6Y+u5CAlVW99epgy2iEAiScg
 Uw2NT9YnyIOzwgCw65zMXIwlWwg1jTdX+1wdfZhq2iD+UbF4iV+HUd67rs2/5UeF1p
 gWApfUIAFWi6aCDS0rC00r3PJ9pLB8SLnPUFbWsAlwoNXNGs/eE6tpWTn61vCDzuww
 3QJUNAfKSutri8kUHtz9hvOJ589RC7Nt5K5nOEdImviYRVbEkhnGL9UlIZTCEwN0cV
 mC6hzhA+sbh4E/48E+Vzm8Kz8Fi5o5PxRYXom47KpG+w8mNI3P20oAXRAXMuDytX8h
 itCJiQo5b8sQA==
X-Virus-Scanned: amavisd-new at mail.cs.ucla.edu
Received: from mail.cs.ucla.edu ([127.0.0.1])
 by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026)
 with ESMTP id IW7p6PbJsEbS for <control <at> debbugs.gnu.org>;
 Sun,  3 Dec 2023 01:38:19 -0800 (PST)
Received: from [192.168.254.12] (unknown [47.148.192.211])
 by mail.cs.ucla.edu (Postfix) with ESMTPSA id E6CD43C011BE9
 for <control <at> debbugs.gnu.org>; Sun,  3 Dec 2023 01:38:19 -0800 (PST)
Message-ID: <6c4da619-9673-4030-a337-4cab7c72efa4@HIDDEN>
Date: Sun, 3 Dec 2023 01:38:19 -0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
To: control <at> debbugs.gnu.org
From: Paul Eggert <eggert@HIDDEN>
Subject: 67593 is not a bug
Organization: UCLA Computer Science Department
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

tags 67593 notabug

Last modified: Sun, 3 Dec 2023 09:45:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.