Received: (at 67594) by debbugs.gnu.org; 8 Dec 2023 17:51:42 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Dec 08 12:51:42 2023
Received: from localhost ([127.0.0.1]:46015 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rBf0n-00012R-N3
for submit <at> debbugs.gnu.org; Fri, 08 Dec 2023 12:51:42 -0500
Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]:41110)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <zimon.toutoune@HIDDEN>) id 1rBf0l-00011w-HJ
for 67594 <at> debbugs.gnu.org; Fri, 08 Dec 2023 12:51:40 -0500
Received: by mail-wr1-x42c.google.com with SMTP id
ffacd0b85a97d-3333073c93cso365109f8f.0
for <67594 <at> debbugs.gnu.org>; Fri, 08 Dec 2023 09:51:26 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1702057880; x=1702662680; darn=debbugs.gnu.org;
h=mime-version:message-id:date:references:in-reply-to:subject:to:from
:from:to:cc:subject:date:message-id:reply-to;
bh=JLXXmuIQIlyLiRWg+nuCsbadK85Y6OdIkYJYqQ4+1Gg=;
b=C/Z3WalIqEMwKHA3aTC8TJX9WRGRVVMNsbQlspwQpz29KDwCDzdB1Tue/yqDk1rT7B
BFpTTHhCU1NfgSsHWL0td46xal6JIuJZb2ijEetosHsvNkd+VzSeaBKuXp8UMyrpy3fz
1321ixr1HPYDS21CerMxerLRTJjHqiR9OKpSbM6AHa/lcvmLG5bBcphbk9n3MLOLhyD2
MudKLtLFqrUXJQ8yT8nBDQwlWibjjm0ptX9oI572gbMmakZCUIu23srSl65gDNTOeyPa
bZuYaNugF/Ra8Z4YgIWr+hRzEo6nM7MC1U3eANwmogJPq0qxyeAq+TppPs5rqvRQ/TZo
X8Mw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1702057880; x=1702662680;
h=mime-version:message-id:date:references:in-reply-to:subject:to:from
:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=JLXXmuIQIlyLiRWg+nuCsbadK85Y6OdIkYJYqQ4+1Gg=;
b=M47d2gSrX+pydS+e9N2rXktwcF0QFVPg6WszF4r9bFsEFIYNGMzqY4Wn5OoJfQorcQ
mCdWHXN9qk1xq0jTab4JmYJLt+IJUmoJybIo6Qzxs7bzlYFDobKkwr1owC1NVDdOPeMI
XWKzULv08T/1rVct6onVzMIep9SYVDkMsGQdj3lupvEcntIN8KiXZQYPtbdXfoN1z+oD
dWsNC6wxLMUr6rCtkYLUej7ZylX/4l4SWWPIeSuqmrMwLc2L4ZVd6XJRm0mlV6n1IT5R
LB5I7TAfvf5/Z8xAsL84tSjjFyWoI6CbndwsjMgGe2vsPAIalu42PJ9i6OYHf5LuP2qS
3ytA==
X-Gm-Message-State: AOJu0Yx0wvwX7PykJw+J8Jnr94u3dgu79trHkp0ZT5mWThvqG3Gi7Rr9
91JP7WOdkWq5Zm4jB1lNV0jQ8M6/7YI=
X-Google-Smtp-Source: AGHT+IE5dMmHUNksi6Ysmbv9eLY7KsnlhIiLicp2ceY+1ZY9aOZI04cw9+r5zv4FbDdJhw0M4QB6Ig==
X-Received: by 2002:a05:6000:1445:b0:333:51af:b269 with SMTP id
v5-20020a056000144500b0033351afb269mr525341wrx.6.1702057880222;
Fri, 08 Dec 2023 09:51:20 -0800 (PST)
Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id
n16-20020a5d4850000000b003334926fb81sm2470389wrs.90.2023.12.08.09.51.19
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 08 Dec 2023 09:51:19 -0800 (PST)
From: Simon Tournier <zimon.toutoune@HIDDEN>
To: Leo Famulari <leo@HIDDEN>, 67594 <at> debbugs.gnu.org
Subject: Re: bug#67594: Cannot reproduce hash calculation of erlang package
In-Reply-To: <ZWvf_aJQDVkqkPRc@HIDDEN>
References: <ZWvf_aJQDVkqkPRc@HIDDEN>
Date: Fri, 08 Dec 2023 18:19:35 +0100
Message-ID: <87lea47gt4.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 67594
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Hi,
On Sat, 02 Dec 2023 at 20:55, Leo Famulari <leo@HIDDEN> wrote:
> (source (origin
> (method git-fetch)
> ;; The tarball from http://erlang.org/download contains many
> ;; pre-compiled files, so we use this snapshot of the source
> ;; repository.
> (uri (git-reference
> (url "https://github.com/erlang/otp")
> (commit (string-append "OTP-" version))))
> (file-name (git-file-name name version))
> (sha256
> (base32
> "092lym5a181gz89nscw7kqhw1wa6qvgcpkj80q4i9p79mxmsr1nj"))
> $ git clone https://github.com/erlang/otp
> $ cd otp
> $ git checkout OTP-25.3.2
> HEAD is now at 0418c10ec3 Updated OTP version
> $ guix hash -x --serializer=nar .
> 05m2fixgfn2gcisz13zp002hy5i8580ayai3lqs77q8gwzdb22mz
> It's not the same hash as in the package definition.
Indeed, and I think the issue is coming from that:
./lib/dialyzer/test/options1_SUITE_data/my_include/CVS
It is another case of bug#65979 [1]. Because there is both .git and
CVS, the current implementation of vcs-file? is confused and so exclude
some folders when it should not.
This is fixed by <https://issues.guix.gnu.org/66961#7> that I will push
shortly the last revision v4. :-)
--8<---------------cut here---------------start------------->8---
$ ./pre-inst-env guix hash -x --serializer=nar /tmp/otp
092lym5a181gz89nscw7kqhw1wa6qvgcpkj80q4i9p79mxmsr1nj
--8<---------------cut here---------------end--------------->8---
1: https://issues.guix.gnu.org/issue/65979
Cheers,
simon
bug-guix@HIDDEN:bug#67594; Package guix.
Full text available.
Received: (at submit) by debbugs.gnu.org; 3 Dec 2023 01:55:39 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Dec 02 20:55:39 2023
Received: from localhost ([127.0.0.1]:58966 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1r9bhr-0007Pj-CP
for submit <at> debbugs.gnu.org; Sat, 02 Dec 2023 20:55:39 -0500
Received: from lists.gnu.org ([2001:470:142::17]:52972)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <leo@HIDDEN>) id 1r9bhp-0007PT-4H
for submit <at> debbugs.gnu.org; Sat, 02 Dec 2023 20:55:37 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <leo@HIDDEN>) id 1r9bhZ-0006v1-LB
for bug-guix@HIDDEN; Sat, 02 Dec 2023 20:55:21 -0500
Received: from out3-smtp.messagingengine.com ([66.111.4.27])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <leo@HIDDEN>) id 1r9bhU-0008S4-Gr
for bug-guix@HIDDEN; Sat, 02 Dec 2023 20:55:21 -0500
Received: from compute6.internal (compute6.nyi.internal [10.202.2.47])
by mailout.nyi.internal (Postfix) with ESMTP id 845205C00D0;
Sat, 2 Dec 2023 20:55:12 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
by compute6.internal (MEProxy); Sat, 02 Dec 2023 20:55:12 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name;
h=cc:content-type:content-type:date:date:from:from:in-reply-to
:message-id:mime-version:reply-to:sender:subject:subject:to:to;
s=mesmtp; t=1701568512; x=1701654912; bh=ucVNOGc4nnkH3zRqWve9JB
Aa0WalI2XjmCKSkm3C7B4=; b=eZCc/7MRXAyOxMaM8K1M+AznwI3wGLyBQ95eqw
3UnkQbpcnMWFE2XQmZ54DMJ8QriEnyrAXNAU6hb/56L3jf1BVN52R6+WdEbXPnHm
DykWY52/KksugnD/Zx/lPmk/dwDlbLlgSZJSFd96E0Mb9YuQLHPJZvWbM2UoSR2E
huoVA=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-type:content-type:date:date
:feedback-id:feedback-id:from:from:in-reply-to:message-id
:mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy
:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=
1701568512; x=1701654912; bh=ucVNOGc4nnkH3zRqWve9JBAa0WalI2XjmCK
Skm3C7B4=; b=UW5z1ucwNEr9wyqJWKeZbAuw5xiXv9jgaksbXlVBWK6bvs/I1wT
87Z9n4whRFIhCMvcpzThRUAO/DOOAvbI/R4aOkkE6F/Ce6nQ4wp63ceII/RFnVs5
T5rMwHYHgz9i5Rh5iu4KLYw8lU0XQqBjlaSRETgQahSkLT5eXGKgNC/OTfZa43Dz
dCQuIkJbLvgb+yzTVP3jY3uyujnAWb7VNjLyD5zHQm2xEIRqczPQ3HR65NEw+4Ds
vly0hZB5Sf0bBtpLR3An/kdQWcW3dISZfe0wji4q4NpmsA2Fy49dwSfZ3VBmcPc/
2FpYgOxFsbI/CoLp9Uwa+TagIf1FRzcEIUA==
X-ME-Sender: <xms:AOBrZeahQ9BRAeiVFPvPixUR9KqcVabRRawUX0TihjWzSljVxy_CLw>
<xme:AOBrZRavPmxJF8QsfJG4hPkIYIwxOv-lFCy8bizZYCeKOj9jLCSqSUNAUZhq5tFrr
vvhdnoN2Ag2S1w6-Q>
X-ME-Received: <xmr:AOBrZY-optvMIEDax6TjJswvCJpX8TO1ZR1KJZILXbTinpfSDEAg9D82gecCWI77tLTExknwGzA5Ew3uunwVbPr_>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudejvddggeduucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkgggtugesthdtredttd
dtvdenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhi
rdhnrghmvgeqnecuggftrfgrthhtvghrnhepueehudeuheffudelffehudejhfelkeekff
egueeigeekieevjedvhfetgfdvhfevnecuffhomhgrihhnpegvrhhlrghnghdrohhrghdp
ghhithhhuhgsrdgtohhmpdhgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenuc
frrghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg
X-ME-Proxy: <xmx:AOBrZQqrHezGIZUgqfYoztF-4XauE7w-gOtxV6GfObrl5RWIG6vgAg>
<xmx:AOBrZZqTyMWh0d-J4ZyAwolKryEqtwU_HUampGMNYq3d7Bl_tdtfnw>
<xmx:AOBrZeTQ4Yml1pS-I3sXTt_GDiG2jOUcVBp4keJ1E0ogGR2tleqmOg>
<xmx:AOBrZbFuxUoORgb0adiaLfrCN-NJXi0xuyARpsxsDXkTZrUePZh6Iw>
Feedback-ID: i819c4023:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA for
<bug-guix@HIDDEN>; Sat, 2 Dec 2023 20:55:12 -0500 (EST)
Date: Sat, 2 Dec 2023 20:55:09 -0500
From: Leo Famulari <leo@HIDDEN>
To: bug-guix@HIDDEN
Subject: Cannot reproduce hash calculation of erlang package
Message-ID: <ZWvf_aJQDVkqkPRc@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Received-SPF: pass client-ip=66.111.4.27; envelope-from=leo@HIDDEN;
helo=out3-smtp.messagingengine.com
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,
SPF_HELO_PASS=-0.001, SPF_PASS=-0.001,
T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.9 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)
As reported on #guix by jeremyc [0], the standard method for calculating
the hash of a Git checkout is not working as expected for the Erlang
package [1].
Currently, our Erlang package has this source block:
------
(version "25.3.2")
(source (origin
(method git-fetch)
;; The tarball from http://erlang.org/download contains many
;; pre-compiled files, so we use this snapshot of the source
;; repository.
(uri (git-reference
(url "https://github.com/erlang/otp")
(commit (string-append "OTP-" version))))
(file-name (git-file-name name version))
(sha256
(base32
"092lym5a181gz89nscw7kqhw1wa6qvgcpkj80q4i9p79mxmsr1nj"))
(patches (search-patches "erlang-man-path.patch"))))
------
So, I clone otp.git, check out the tag, and calculate the hash according
to the manual:
------
$ git clone https://github.com/erlang/otp
Cloning into 'otp'...
remote: Enumerating objects: 491375, done.
remote: Counting objects: 100% (102345/102345), done.
remote: Compressing objects: 100% (3576/3576), done.
remote: Total 491375 (delta 100266), reused 99037 (delta 98766), pack-reused 389030
Receiving objects: 100% (491375/491375), 485.70 MiB | 14.17 MiB/s, done.
Resolving deltas: 100% (396274/396274), done.
Updating files: 100% (12078/12078), done.
$ cd otp
$ git checkout OTP-25.3.2
Note: switching to 'OTP-25.3.2'.
You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.
If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:
git switch -c <new-branch-name>
Or undo this operation with:
git switch -
Turn off this advice by setting config variable advice.detachedHead to false
HEAD is now at 0418c10ec3 Updated OTP version
$ guix hash -x --serializer=nar .
05m2fixgfn2gcisz13zp002hy5i8580ayai3lqs77q8gwzdb22mz
------
It's not the same hash as in the package definition.
Additionally, I used '--check' to make sure I'm not crazy. I commented
out the patch that we apply to the otp.git, and then used this command,
which returned successfully:
------
$ ./pre-inst-env guix build --no-grafts erlang -S --no-substitutes --no-offload --check
------
What's up? Are me and jeremyc missing something here?
[0]
http://logs.guix.gnu.org/guix/2023-12-03.log#020056
[1]
https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/erlang.scm?id=06ebc45e15f2a1bd4526a5a716eed657c902a0c1#n48
Leo Famulari <leo@HIDDEN>:bug-guix@HIDDEN.
Full text available.bug-guix@HIDDEN:bug#67594; Package guix.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.