GNU bug report logs - #67601
[PATCH gnome-team] gnu: Add xdg-desktop-portal-gnome.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 67601 in the body.
You can then email your comments to 67601 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vivien Kraus <vivien <at> planete-kraus.eu>
To: guix-patches <at> gnu.org
Cc: rg <at> raghavgururajan.name, liliana.prikler <at> gmail.com,
 maxim.cournoyer <at> gmail.com
Subject: [PATCH gnome-team] gnu: Add xdg-desktop-portal-gnome.
Date: Sun, 3 Dec 2023 14:51:01 +0100

* gnu/packages/gnome.scm (xdg-desktop-portal-gnome): New variable.
(gnome) [propagated-inputs]: Add xdg-desktop-portal-gnome.

Change-Id: I2925cf950b731c71e4ad4a01f28bce22c0cb54fb
---
Dear Guix,

I’m not sure what I’m doing here. xdg-desktop-portal-gnome is a core app, so I
guess I should add it to the gnome propagated inputs?

Best regards,

Vivien

 gnu/packages/gnome.scm | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index d354327497..3a69aca3ba 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -10114,6 +10114,7 @@ (define-public gnome
           simple-scan
           totem
           tracker-miners
+          xdg-desktop-portal-gnome
           yelp
           ;; Others.
           gnome-online-accounts
@@ -12841,6 +12842,44 @@ (define-public piper
   (simple-service 'ratbagd dbus-root-service-type (list libratbag))")
     (license license:gpl2)))
 
+(define-public xdg-desktop-portal-gnome
+  (package
+    (name "xdg-desktop-portal-gnome")
+    (version "44.2")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "mirror://gnome/sources/" name "/"
+                                  (version-major version) "/"
+                                  name "-" version ".tar.xz"))
+              (sha256
+               (base32
+                "08gznmr718na5p2j8fm7nim5862r2v0sjh68ql5yl0q356n1mvah"))
+              (snippet
+               #~(begin
+                   (use-modules (guix build utils))
+                   (delete-file-recursively "subprojects")))))
+    (build-system meson-build-system)
+    (arguments
+     (list
+      #:glib-or-gtk? #t
+      #:configure-flags #~'("-Dsystemduserunitdir=no")))
+    (inputs
+     (list gnome-desktop
+           gsettings-desktop-schemas
+           libadwaita
+           libxml2
+           xdg-desktop-portal
+           xdg-desktop-portal-gtk))
+    (native-inputs
+     (list gettext-minimal
+           `(,glib "bin")
+           pkg-config))
+    (home-page "https://gitlab.gnome.org/GNOME/xdg-desktop-portal-gnome")
+    (synopsis "GNOME backend for xdg-desktop-portal")
+    (description "xdg-desktop-portal-gnome implements a back-end for
+@command{xdg-desktop-portal} that uses gtk and some more GNOME APIs.")
+    (license license:lgpl2.1+)))
+
 (define-public parlatype
   (package
     (name "parlatype")

base-commit: e21f0cb7b7a87992004193cd56638ad961fe5928
-- 
2.41.0

Message #8 received at 67601 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Vivien Kraus <vivien <at> planete-kraus.eu>, 67601 <at> debbugs.gnu.org
Cc: rg <at> raghavgururajan.name, liliana.prikler <at> gmail.com
Subject: Re: [PATCH gnome-team] gnu: Add xdg-desktop-portal-gnome.
Date: Sun, 03 Dec 2023 19:30:30 -0500

Hi Vivien,

Vivien Kraus <vivien <at> planete-kraus.eu> writes:

> * gnu/packages/gnome.scm (xdg-desktop-portal-gnome): New variable.
> (gnome) [propagated-inputs]: Add xdg-desktop-portal-gnome.

These should be in two seperate commits (1. adding the new package and
2. adding it as an propagated-input to the gnome package)

> Dear Guix,
>
> I’m not sure what I’m doing here. xdg-desktop-portal-gnome is a core app, so I
> guess I should add it to the gnome propagated inputs?

https://ftp2.nluug.nl/windowing/gnome/teams/releng/45.0/versions indeed
suggests it is a core application, so adding it to 'gnome' sounds
reasonable to me.

If you split the commits, LGTM.

-- 
Thanks,
Maxim

Message #11 received at 67601 <at> debbugs.gnu.org (full text, mbox):

From: Vivien Kraus <vivien <at> planete-kraus.eu>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: rg <at> raghavgururajan.name, liliana.prikler <at> gmail.com, 67601 <at> debbugs.gnu.org
Subject: [PATCH gnome-team v2 1/2] gnu: Add xdg-desktop-portal-gnome.
Date: Sun, 3 Dec 2023 14:51:01 +0100

* gnu/packages/gnome.scm (xdg-desktop-portal-gnome): New variable.

Change-Id: I2925cf950b731c71e4ad4a01f28bce22c0cb54fb
---
 gnu/packages/gnome.scm | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index c6437ce450..1a515af4e7 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -12866,6 +12866,44 @@ (define-public piper
   (simple-service 'ratbagd dbus-root-service-type (list libratbag))")
     (license license:gpl2)))
 
+(define-public xdg-desktop-portal-gnome
+  (package
+    (name "xdg-desktop-portal-gnome")
+    (version "44.2")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "mirror://gnome/sources/" name "/"
+                                  (version-major version) "/"
+                                  name "-" version ".tar.xz"))
+              (sha256
+               (base32
+                "08gznmr718na5p2j8fm7nim5862r2v0sjh68ql5yl0q356n1mvah"))
+              (snippet
+               #~(begin
+                   (use-modules (guix build utils))
+                   (delete-file-recursively "subprojects")))))
+    (build-system meson-build-system)
+    (arguments
+     (list
+      #:glib-or-gtk? #t
+      #:configure-flags #~'("-Dsystemduserunitdir=no")))
+    (inputs
+     (list gnome-desktop
+           gsettings-desktop-schemas
+           libadwaita
+           libxml2
+           xdg-desktop-portal
+           xdg-desktop-portal-gtk))
+    (native-inputs
+     (list gettext-minimal
+           `(,glib "bin")
+           pkg-config))
+    (home-page "https://gitlab.gnome.org/GNOME/xdg-desktop-portal-gnome")
+    (synopsis "GNOME backend for xdg-desktop-portal")
+    (description "xdg-desktop-portal-gnome implements a back-end for
+@command{xdg-desktop-portal} that uses gtk and some more GNOME APIs.")
+    (license license:lgpl2.1+)))
+
 (define-public parlatype
   (package
     (name "parlatype")

base-commit: 4c323c2f8308bba0e3295f3109d159c7b8f72838
-- 
2.41.0

Message #14 received at 67601 <at> debbugs.gnu.org (full text, mbox):

From: Vivien Kraus <vivien <at> planete-kraus.eu>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: rg <at> raghavgururajan.name, liliana.prikler <at> gmail.com, 67601 <at> debbugs.gnu.org
Subject: [PATCH gnome-team v2 2/2] gnu: gnome: Propagate
 xdg-desktop-portal-gnome.
Date: Mon, 4 Dec 2023 19:16:16 +0100

* gnu/packages/gnome.scm (gnome) [propagated-inputs]: Add
xdg-desktop-portal-gnome.

Change-Id: I2a911ec58a1c9992213e60d92a3dd955dd1a545e
---
 gnu/packages/gnome.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 1a515af4e7..71a8a4b7ec 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -10137,6 +10137,7 @@ (define-public gnome
           simple-scan
           totem
           tracker-miners
+          xdg-desktop-portal-gnome
           yelp
           ;; Others.
           gnome-online-accounts
-- 
2.41.0

Message #17 received at 67601 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Vivien Kraus <vivien <at> planete-kraus.eu>
Cc: rg <at> raghavgururajan.name, liliana.prikler <at> gmail.com, 67601 <at> debbugs.gnu.org
Subject: Re: [PATCH gnome-team v2 1/2] gnu: Add xdg-desktop-portal-gnome.
Date: Mon, 04 Dec 2023 19:30:16 -0500

Vivien Kraus <vivien <at> planete-kraus.eu> writes:

> * gnu/packages/gnome.scm (xdg-desktop-portal-gnome): New variable.
>
> Change-Id: I2925cf950b731c71e4ad4a01f28bce22c0cb54fb

Reviewed-by: Maxim Cournoyer <maxim.cournoyer <at> gmail>

-- 
Thanks,
Maxim

Message #20 received at 67601 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Vivien Kraus <vivien <at> planete-kraus.eu>
Cc: rg <at> raghavgururajan.name, liliana.prikler <at> gmail.com, 67601 <at> debbugs.gnu.org
Subject: Re: [PATCH gnome-team v2 2/2] gnu: gnome: Propagate
 xdg-desktop-portal-gnome.
Date: Mon, 04 Dec 2023 19:30:23 -0500

Vivien Kraus <vivien <at> planete-kraus.eu> writes:

> * gnu/packages/gnome.scm (gnome) [propagated-inputs]: Add
> xdg-desktop-portal-gnome.
>
> Change-Id: I2a911ec58a1c9992213e60d92a3dd955dd1a545e

Reviewed-by: Maxim Cournoyer <maxim.cournoyer <at> gmail>

-- 
Thanks,
Maxim

Message #25 received at 67601-done <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>, Vivien Kraus
 <vivien <at> planete-kraus.eu>
Cc: rg <at> raghavgururajan.name, 67601-done <at> debbugs.gnu.org
Subject: Re: [PATCH gnome-team v2 1/2] gnu: Add xdg-desktop-portal-gnome.
Date: Wed, 20 Dec 2023 00:02:09 +0100

Am Montag, dem 04.12.2023 um 19:30 -0500 schrieb Maxim Cournoyer:
> Vivien Kraus <vivien <at> planete-kraus.eu> writes:
> 
> > * gnu/packages/gnome.scm (xdg-desktop-portal-gnome): New variable.
> > 
> > Change-Id: I2925cf950b731c71e4ad4a01f28bce22c0cb54fb
> 
> Reviewed-by: Maxim Cournoyer <maxim.cournoyer <at> gmail>
Pushed at last.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.