GNU bug report logs - #67602
29.1; [PATCH] Add function eww-copy-point-link-url to eww.

Previous Next

Package: emacs;

Reported by: Osmo Karppinen <osmkarp <at> gmail.com>

Date: Sun, 3 Dec 2023 15:14:01 UTC

Severity: normal

Tags: patch

Found in version 29.1

Fixed in version 30.0.50

Done: Juri Linkov <juri <at> linkov.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 67602 in the body.
You can then email your comments to 67602 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#67602; Package emacs. (Sun, 03 Dec 2023 15:14:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Osmo Karppinen <osmkarp <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sun, 03 Dec 2023 15:14:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Osmo Karppinen <osmkarp <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.1; [PATCH] Add function eww-copy-point-link-url to eww.
Date: Sun, 03 Dec 2023 17:13:23 +0200
[Message part 1 (text/plain, inline)]
Tags: patch

New function eww-copy-point-link-url will copy URL of link pointed by
the pointer to the killring in eww. Patch adds also new key binding for
the function and also menuitem. I think that key "c" is good for this
operation.

Why? Sometimes it is needed to get url from link at the point to your
killring. Data behind the url could be in form what eww or emacs can't
handle well. So it is not quite handy to load page and then copy it's
url to the killring with eww-copy-page-url.

GNU Emacs 30.0.50 Development version fb4b0b30a24e on master branch;
build date 2023-12-03.


[0001-Add-function-eww-copy-point-link-url-to-eww.patch (text/x-diff, attachment)]
[Message part 3 (text/plain, inline)]

With thanks,
Osmo Karppinen

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#67602; Package emacs. (Sun, 03 Dec 2023 17:07:02 GMT) Full text and rfc822 format available.

Message #8 received at 67602 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Osmo Karppinen <osmkarp <at> gmail.com>
Cc: 67602 <at> debbugs.gnu.org
Subject: Re: bug#67602: 29.1; [PATCH] Add function eww-copy-point-link-url
 to eww.
Date: Sun, 03 Dec 2023 19:02:47 +0200
> New function eww-copy-point-link-url will copy URL of link pointed by
> the pointer to the killring in eww. Patch adds also new key binding for
> the function and also menuitem. I think that key "c" is good for this
> operation.

Another variant would be to reuse 'eww-copy-page-url' bound to "w",
and to copy a link with a prefix argument.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#67602; Package emacs. (Sun, 03 Dec 2023 17:50:02 GMT) Full text and rfc822 format available.

Message #11 received at 67602 <at> debbugs.gnu.org (full text, mbox):

From: Eshel Yaron <me <at> eshelyaron.com>
To: Juri Linkov <juri <at> linkov.net>
Cc: Osmo Karppinen <osmkarp <at> gmail.com>, 67602 <at> debbugs.gnu.org
Subject: Re: bug#67602: 29.1; [PATCH] Add function eww-copy-point-link-url
 to eww.
Date: Sun, 03 Dec 2023 18:48:41 +0100
Juri Linkov <juri <at> linkov.net> writes:

>> New function eww-copy-point-link-url will copy URL of link pointed by
>> the pointer to the killring in eww. Patch adds also new key binding for
>> the function and also menuitem. I think that key "c" is good for this
>> operation.
>
> Another variant would be to reuse 'eww-copy-page-url' bound to "w",
> and to copy a link with a prefix argument.

I'm think "w" already does that in EWW when point is on a link, no?
That's thanks to the fact that SHR renders links with a `keymap`
property that binds "w" to `shr-maybe-probe-and-copy-url`.


Best,

Eshel




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#67602; Package emacs. (Sun, 03 Dec 2023 18:03:02 GMT) Full text and rfc822 format available.

Message #14 received at 67602 <at> debbugs.gnu.org (full text, mbox):

From: Osmo Karppinen <osmkarp <at> gmail.com>
To: Eshel Yaron <me <at> eshelyaron.com>
Cc: 67602 <at> debbugs.gnu.org, Juri Linkov <juri <at> linkov.net>
Subject: Re: bug#67602: 29.1;
 [PATCH] Add function eww-copy-point-link-url to eww.
Date: Sun, 03 Dec 2023 20:02:36 +0200
You were right. This case is closed. Documentation is bit misleading.
When you Type C-h k and your point is not on link it shows you
eww-copy-page-url. And same when you look at your local eww keymap.
It is somehow hard to find that there is eww-link-keymap.

With thanks,
Osmo Karppinen




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#67602; Package emacs. (Sun, 03 Dec 2023 18:17:01 GMT) Full text and rfc822 format available.

Message #17 received at 67602 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Osmo Karppinen <osmkarp <at> gmail.com>
Cc: 67602 <at> debbugs.gnu.org, me <at> eshelyaron.com, juri <at> linkov.net
Subject: Re: bug#67602: 29.1;
 [PATCH] Add function eww-copy-point-link-url to eww.
Date: Sun, 03 Dec 2023 20:16:33 +0200
> Cc: 67602 <at> debbugs.gnu.org, Juri Linkov <juri <at> linkov.net>
> Date: Sun, 03 Dec 2023 20:02:36 +0200
> From: Osmo Karppinen <osmkarp <at> gmail.com>
> 
> 
> You were right. This case is closed. Documentation is bit misleading.
> When you Type C-h k and your point is not on link it shows you
> eww-copy-page-url. And same when you look at your local eww keymap.
> It is somehow hard to find that there is eww-link-keymap.

EWW has its own manual, and this feature is described there, see the
node "Basics".




bug marked as fixed in version 30.0.50, send any further explanations to 67602 <at> debbugs.gnu.org and Osmo Karppinen <osmkarp <at> gmail.com> Request was from Juri Linkov <juri <at> linkov.net> to control <at> debbugs.gnu.org. (Wed, 06 Dec 2023 17:29:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 04 Jan 2024 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 128 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.