GNU logs - #67609, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#67609: 29.1; (eglot-inlay-hints-mode -1) behaves surprisingly, does not work in cc-mode hooks
Resent-From: Morgon Kanter <morgon.kanter@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 03 Dec 2023 18:35:02 +0000
Resent-Message-ID: <handler.67609.B.170162846312394 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 67609 <at> debbugs.gnu.org
MIME-Version: 1.0
From: Morgon Kanter <morgon.kanter@HIDDEN>
Date: Sun, 3 Dec 2023 13:28:36 -0500
Message-ID: <CAMGeJwnTPzxLZrxzsB8L66=TnjydoSuGj2wHL7YGgvvh5rr=jQ@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Received-SPF: pass client-ip=2607:f8b0:4864:20::f2d;
 envelope-from=morgon.kanter@HIDDEN; helo=mail-qv1-xf2d.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Mailman-Approved-At: Sun, 03 Dec 2023 13:34:21 -0500
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

eglot-inlay-hints-mode seems to always turn on, at least in cc-mode, even
when explicitly disabled by a hook, leaving me to disable it once the
buffer is loaded. For example, this is my config:

(defun config:cc-defaults ()
  (c-toggle-comment-style 1)
  (subword-mode 1)
  (diminish 'subword-mode)
  (local-set-key (kbd "C-M-S-<backspace>") #'kill-outer-sexp-and-parens)
  ;; Run eglot if we're under a project.
  (when (project-current)
    (eglot-ensure)
    (eglot-inlay-hints-mode -1)))
(add-hook 'c-mode-common-hook #'config:cc-defaults)

This will, when visiting a C++ file for the first time, turn on eglot.
Then it should also turn *off* the inlay-hints mode, but it does not.
The inlay hints appear until I manually run eglot-inlay-hints-mode.

This behavior appears even if I change the above configuration to remove
the eglot-ensure portion, and simply run (eglot-inlay-hints-mode -1)
unconditionally in the hook. They will still appear, and I still have to
run it manually to turn it off.

This behavior is, I think, different from most other mode configurations
throughout Emacs which can be set up and torn down in hooks.


In GNU Emacs 29.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38,
cairo version 1.17.8)
Windowing system distributor 'Microsoft Corporation', version 11.0.12010000
System Description: Arch Linux

Configured using:
 'configure --with-x-toolkit=gtk3 --with-native-compilation=aot
 --sysconfdir=/etc --prefix=/usr --libexecdir=/usr/lib
 --with-tree-sitter --localstatedir=/var --with-cairo
 --disable-build-details --with-harfbuzz --with-libsystemd
 --with-modules 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fno-plt
 -fexceptions -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security
 -fstack-clash-protection -fcf-protection -g
 -ffile-prefix-map=/build/emacs/src=/usr/src/debug/emacs -flto=auto'
 'LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now -flto=auto'
 'CXXFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions
 -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security
 -fstack-clash-protection -fcf-protection -Wp,-D_GLIBCXX_ASSERTIONS -g
 -ffile-prefix-map=/build/emacs/src=/usr/src/debug/emacs -flto=auto''

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: ELisp/d

Minor modes in effect:
  global-git-commit-mode: t
  magit-auto-revert-mode: t
  shell-dirtrack-mode: t
  marginalia-mode: t
  override-global-mode: t
  vertico-mode: t
  which-key-mode: t
  server-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
/home/surgo/.emacs.d/elpa/transient-20231103.2312/transient hides
/usr/share/emacs/29.1/lisp/transient
/home/surgo/.emacs.d/elpa/seq-2.24/seq hides
/usr/share/emacs/29.1/lisp/emacs-lisp/seq

Features:
(shadow sort mail-extr emacsbug misearch multi-isearch eglot
external-completion array jsonrpc ert pp ewoc debug backtrace find-func
xref flymake-proc flymake thingatpt compile project mule-util vc-git
vc-dispatcher cap-words superword subword cc-mode cc-fonts cc-guess
cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs
magit-submodule magit-blame magit-stash magit-reflog magit-bisect
magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit
magit-sequence magit-notes magit-worktree magit-tag magit-merge
magit-branch magit-reset magit-files magit-refs magit-status magit
magit-repos magit-apply magit-wip magit-log which-func imenu magit-diff
smerge-mode diff diff-mode git-commit log-edit message sendmail
yank-media puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg
rfc6068 epg-config gnus-util text-property-search time-date mm-decode
mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util
ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader
pcvs-util add-log magit-core magit-autorevert autorevert filenotify
magit-margin magit-transient magit-process with-editor comp comp-cstr
warnings icons rx shell pcomplete comint ansi-osc ring ansi-color
magit-mode transient magit-git magit-base magit-section format-spec
cursor-sensor crm dash marginalia edmacro kmacro use-package-bind-key
bind-key easy-mmode vertico compat diminish which-key cl-extra help-mode
use-package-diminish use-package-core tango-dark-theme server
magit-autoloads pcase git-commit-autoloads magit-section-autoloads
dash-autoloads marginalia-autoloads projectile-autoloads
transient-autoloads vertico-autoloads with-editor-autoloads info
compat-autoloads seq-autoloads package browse-url url url-proxy
url-privacy url-expand url-methods url-history url-cookie
generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse
auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x
map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc
iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook
vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode lisp-mode prog-mode register
page tab-bar menu-bar rfn-eshadow isearch easymenu timer select
scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors
frame minibuffer nadvice seq simple cl-generic indonesian philippine
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite emoji-zwj charscript
charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure
cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp
files window text-properties overlay sha1 md5 base64 format env
code-pages mule custom widget keymap hashtable-print-readable backquote
threads dbusbind inotify lcms2 dynamic-setting system-font-setting
font-render-setting cairo move-toolbar gtk x-toolkit xinput2 x multi-tty
make-network-process native-compile emacs)

Memory information:
((conses 16 262393 20795)
 (symbols 48 19979 3)
 (strings 32 68186 1843)
 (string-bytes 1 2926233)
 (vectors 16 46984)
 (vector-slots 8 840297 27324)
 (floats 8 117 317)
 (intervals 56 941 111)
 (buffers 984 17))

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Morgon Kanter <morgon.kanter@HIDDEN>
Subject: bug#67609: Acknowledgement (29.1; (eglot-inlay-hints-mode -1)
 behaves surprisingly, does not work in cc-mode hooks)
Message-ID: <handler.67609.B.170162846312394.ack <at> debbugs.gnu.org>
References: <CAMGeJwnTPzxLZrxzsB8L66=TnjydoSuGj2wHL7YGgvvh5rr=jQ@HIDDEN>
X-Gnu-PR-Message: ack 67609
X-Gnu-PR-Package: emacs
Reply-To: 67609 <at> debbugs.gnu.org
Date: Sun, 03 Dec 2023 18:35:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 67609 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
67609: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D67609
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#67609: 29.1; (eglot-inlay-hints-mode -1) behaves surprisingly, does not work in cc-mode hooks
Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 03 Dec 2023 18:54:01 +0000
Resent-Message-ID: <handler.67609.B67609.170162958815056 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Morgon Kanter <morgon.kanter@HIDDEN>
Cc: 67609 <at> debbugs.gnu.org
MIME-Version: 1.0
References: <CAMGeJwnTPzxLZrxzsB8L66=TnjydoSuGj2wHL7YGgvvh5rr=jQ@HIDDEN>
In-Reply-To: <CAMGeJwnTPzxLZrxzsB8L66=TnjydoSuGj2wHL7YGgvvh5rr=jQ@HIDDEN>
From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN>
Date: Sun, 3 Dec 2023 18:52:37 +0000
Message-ID: <CALDnm51asPT+L+TbAF75uzhGPbMZJ67b_VfM9pANg723LVrNwA@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

On Sun, Dec 3, 2023 at 6:35=E2=80=AFPM Morgon Kanter <morgon.kanter@HIDDEN=
om> wrote:
>
> eglot-inlay-hints-mode seems to always turn on, at least in cc-mode, even
> when explicitly disabled by a hook, leaving me to disable it once the
> buffer is loaded. For example, this is my config:
>
> (defun config:cc-defaults ()
>   (c-toggle-comment-style 1)
>   (subword-mode 1)
>   (diminish 'subword-mode)
>   (local-set-key (kbd "C-M-S-<backspace>") #'kill-outer-sexp-and-parens)
>   ;; Run eglot if we're under a project.
>   (when (project-current)
>     (eglot-ensure)
>     (eglot-inlay-hints-mode -1)))
> (add-hook 'c-mode-common-hook #'config:cc-defaults)

Hi.  Because you're using 'eglot-ensure' (hint, maybe you
shoudn't, read the manual in the latest master for why)
it means that after the eglot-ensure form executes,
Eglot will not be setup yet, so the following form
has no effect.  You need to replace it with

  (add-hook 'eglot-managed-mode-hook (lambda ()
(eglot-inlay-hints-mode -1)) nil t)

So that when Eglot does start up, it knows to disable
inlay hints.

You may add the above line globally (with the trailing 'nil t') if
you never want inlay hints to be enabled automatically in any
mode or language server.

And see also eglot-ignored-server-capabilities and add consider
:inlayHintProvider to it if you don't even ever want to enable
it manually.

Jo=C3=A3o

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#67609: 29.1; (eglot-inlay-hints-mode -1) behaves surprisingly, does not work in cc-mode hooks
Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 03 Dec 2023 19:24:02 +0000
Resent-Message-ID: <handler.67609.B67609.170163143418448 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Morgon Kanter <morgon.kanter@HIDDEN>
Cc: 67609 <at> debbugs.gnu.org
MIME-Version: 1.0
References: <CAMGeJwnTPzxLZrxzsB8L66=TnjydoSuGj2wHL7YGgvvh5rr=jQ@HIDDEN>
 <CALDnm51asPT+L+TbAF75uzhGPbMZJ67b_VfM9pANg723LVrNwA@HIDDEN>
 <CAMGeJwn2nVdv4cS9sHHru+FFaJJLqhUD1qrFD1nULLHqVxe4TA@HIDDEN>
In-Reply-To: <CAMGeJwn2nVdv4cS9sHHru+FFaJJLqhUD1qrFD1nULLHqVxe4TA@HIDDEN>
From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN>
Date: Sun, 3 Dec 2023 19:23:19 +0000
Message-ID: <CALDnm50UvqT1M=mfu5HL4qbNwN4iNsqL2vT6KBy7XWy9+pkhOQ@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

On Sun, Dec 3, 2023 at 7:02=E2=80=AFPM Morgon Kanter <morgon.kanter@HIDDEN=
om> wrote:

> (defun config:cc-defaults ()
>   ;(setq c-require-final-newline t)  ;; lol causes errors in cc-mode
>   (c-toggle-comment-style 1)
>   (subword-mode 1)
>   (diminish 'subword-mode)
>   (local-set-key (kbd "C-M-S-<backspace>") #'kill-outer-sexp-and-parens)
>   (eglot-inlay-hints-mode -1))
>
> ...and I will receive the same behavior. The eglot-ensure here is a red h=
erring.

I never said this would work either.  It's not a red herring
in the sense that you shouldn't expect eglot-ensure to have
loaded eglot in the buffer after the form has finished.

And you shouldn't expect (eglot-inlay-hints-mode -1) to have
any effect before Eglot is loaded, which obviously does not
happen in the absence of any Eglot-related command as you show here.

So, this doesn't add anything to the story.

> To reproduce, visit a C++ buffer in a project, run M-x eglot. Inlay
> hints will appear. Kill and reopen the buffer. Inlay hints will
> appear.

To achieve your desired behaviour, read my advice in the last email,
thanks.

Jo=C3=A3o

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#67609: 29.1; (eglot-inlay-hints-mode -1) behaves surprisingly, does not work in cc-mode hooks
Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 03 Dec 2023 20:39:01 +0000
Resent-Message-ID: <handler.67609.B67609.170163593925883 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 67609
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Morgon Kanter <morgon.kanter@HIDDEN>
Cc: 67609 <at> debbugs.gnu.org
Received: via spool by 67609-submit <at> debbugs.gnu.org id=B67609.170163593925883
          (code B ref 67609); Sun, 03 Dec 2023 20:39:01 +0000
Received: (at 67609) by debbugs.gnu.org; 3 Dec 2023 20:38:59 +0000
Received: from localhost ([127.0.0.1]:32837 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r9tEx-0006jO-1a
	for submit <at> debbugs.gnu.org; Sun, 03 Dec 2023 15:38:59 -0500
Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131]:49494)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <joaotavora@HIDDEN>) id 1r9tEu-0006jA-OB
 for 67609 <at> debbugs.gnu.org; Sun, 03 Dec 2023 15:38:57 -0500
Received: by mail-lf1-x131.google.com with SMTP id
 2adb3069b0e04-50bf2dfda6fso575078e87.3
 for <67609 <at> debbugs.gnu.org>; Sun, 03 Dec 2023 12:38:46 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1701635920; x=1702240720; darn=debbugs.gnu.org;
 h=content-transfer-encoding:cc:to:subject:message-id:date:from
 :in-reply-to:references:mime-version:from:to:cc:subject:date
 :message-id:reply-to;
 bh=jBO/oT1eF+InQdxsO8eKi4br/wZ9iMET7pmRJbvVju4=;
 b=e1Kb6fXHdY+re92AqAQvTLoVR5+NKqUezFz/FeE6LUW9cBxC4OB9mi0P2IpcZ2JVkC
 Yf0zRTM3ZhOsVs5F8D+7Yr7ZYUWRTpbUSo/2UVGoV3ylm1L4X1zVt/WEZo4v7nKdnJpE
 GwZwfHHq8xHIWh3OH/d7FuZdl4dHqZII/8fiON+5OSm0CeUCfua9QaC7cFSyXw0fWSoo
 l/cAShFASb7RBlzhB3BvIXsjPB7O15xhvUzp9/abSsQnr81PlU/wkxDeIWtE4tdxUeV2
 h8JbHh0CLDP8ZXsg6xvIvHgaReJ2QXWY7lK+WUtWxXFISGjmcNFHRg7XOSZiBijdAxJb
 z4qg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1701635920; x=1702240720;
 h=content-transfer-encoding:cc:to:subject:message-id:date:from
 :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=jBO/oT1eF+InQdxsO8eKi4br/wZ9iMET7pmRJbvVju4=;
 b=noWkcAntQUNuE1hUul41+gJOqaeX7wMNNAJzRKPiDyIrRbVjJcLRlb2OCqR5BxuhA1
 7cwqXswicSdya4zpyZg+ykpXhxFO8nH6beYbUYgq58mj9p45QI1lcHe2ua5RMka1/Et6
 cUPIVBJsyCULMpqlz9ah1yhd2dO2A/PVJs6nxg7QH1nRQP2qNfTQiGtIkE8qPOq4VqPM
 FfFsddMVWgcmSDCybV3kPrAAM3Q50a3RfeG4F+UFEVp7xEz3t2eid+2RGK6h2q9KYf0I
 7AV+PjpG9oE1FCoETM8S7LDEr+UgZMXOrWA+00O07ywzS/Rw5aEucWB81r9oRXkPkQD0
 jUlw==
X-Gm-Message-State: AOJu0YyoqBN8z2wd67nGaGJw1ShpgajTvNNeDeJ2S0+8X9hOsli/YI/Y
 ryh7JwQGEnLMHiZZB6Oazyv8BRyLg/vuNWA5cSQ=
X-Google-Smtp-Source: AGHT+IF/xnIlZwhyzSgDa8d1/kprv3JzU+sy6zQn70eQd1O9ZAbmijPn4dfxxrrxXmW5YAYZz61jUHdbCeE/qR4Zpag=
X-Received: by 2002:ac2:4c18:0:b0:50b:f031:eb84 with SMTP id
 t24-20020ac24c18000000b0050bf031eb84mr613902lfq.35.1701635919858; Sun, 03 Dec
 2023 12:38:39 -0800 (PST)
MIME-Version: 1.0
References: <CAMGeJwnTPzxLZrxzsB8L66=TnjydoSuGj2wHL7YGgvvh5rr=jQ@HIDDEN>
 <CALDnm51asPT+L+TbAF75uzhGPbMZJ67b_VfM9pANg723LVrNwA@HIDDEN>
 <CAMGeJwn2nVdv4cS9sHHru+FFaJJLqhUD1qrFD1nULLHqVxe4TA@HIDDEN>
 <CALDnm50UvqT1M=mfu5HL4qbNwN4iNsqL2vT6KBy7XWy9+pkhOQ@HIDDEN>
 <CAMGeJwknf33W0sdO7xUQuKKxsvt+VH0KO5=A43nV3YowaCkUzw@HIDDEN>
In-Reply-To: <CAMGeJwknf33W0sdO7xUQuKKxsvt+VH0KO5=A43nV3YowaCkUzw@HIDDEN>
From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN>
Date: Sun, 3 Dec 2023 20:38:28 +0000
Message-ID: <CALDnm535w5q5HMohBvKBZHLxH+_s9HCpWWFd_7Ma6z0h0U0tiw@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On Sun, Dec 3, 2023 at 7:37=E2=80=AFPM Morgon Kanter <morgon.kanter@HIDDEN=
om> wrote:

> This should hopefully stop bug reports like mine in the future.

Yours is the first such bug here I can remember, maybe because
googling for "turn off eglot-inlay-hints-mode" lands you on a
Reddit page with the eglot-managed-mode-hook information.

Maybe I can update the manual, but it already says Eglot turns all
supported LSP features by default .  And it should come at no suprise
that eglot-inlay-hints-mode, listed under "Eglot commands", only works
if Eglot is active.  Eglot is presented as minor mode and
eglot-managed-mode-hook is described in sufficient detail.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#67609: 29.1; (eglot-inlay-hints-mode -1) behaves surprisingly, does not work in cc-mode hooks
Resent-From: Morgon Kanter <morgon.kanter@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 04 Dec 2023 05:47:02 +0000
Resent-Message-ID: <handler.67609.B67609.170166877329839 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 67609
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN>
Cc: 67609 <at> debbugs.gnu.org
Received: via spool by 67609-submit <at> debbugs.gnu.org id=B67609.170166877329839
          (code B ref 67609); Mon, 04 Dec 2023 05:47:02 +0000
Received: (at 67609) by debbugs.gnu.org; 4 Dec 2023 05:46:13 +0000
Received: from localhost ([127.0.0.1]:33336 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rA1mW-0007l3-1J
	for submit <at> debbugs.gnu.org; Mon, 04 Dec 2023 00:46:13 -0500
Received: from mail-qv1-xf36.google.com ([2607:f8b0:4864:20::f36]:49162)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <morgon.kanter@HIDDEN>) id 1r9rjs-0004Dd-7p
 for 67609 <at> debbugs.gnu.org; Sun, 03 Dec 2023 14:02:48 -0500
Received: by mail-qv1-xf36.google.com with SMTP id
 6a1803df08f44-67abaab0bc7so4950556d6.2
 for <67609 <at> debbugs.gnu.org>; Sun, 03 Dec 2023 11:02:38 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1701630152; x=1702234952; darn=debbugs.gnu.org;
 h=content-transfer-encoding:cc:to:subject:message-id:date:from
 :in-reply-to:references:mime-version:from:to:cc:subject:date
 :message-id:reply-to;
 bh=o3mXBCwFQDYAurNP/Fh57fi1mS+flCxUnHmMn8j8eh0=;
 b=aGSHTiy2TZidclG01MKOTrS6ig1Uads6WCenzq4ZdYXFj4ATGZvIo/J7Yksst36pl0
 gRoei08riRouPjYQ9BBjfg0w33W8c8Pau4HmlGBnUbb9J8QzqWB4Q1UCkQ+qwEifkuIG
 CDIq1MvLhkwbASJ0lpLHb6n31yewdPaKdphkCbt+DZGGfVqwrmPD8Cz/VAK77xyaauaK
 lplRK0psMuMlbAJDQaooLq+NubzJN9uymC2hA1zxJfMIC2QVm7gjvQfPAfP3mnIGSegh
 Rnpv+hSLcANvKXC8eGp+jyv7PQR/vcMqOfpxRomG+RsndidjJzAWUCNwHIM+dpbqUNkl
 DbkA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1701630152; x=1702234952;
 h=content-transfer-encoding:cc:to:subject:message-id:date:from
 :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=o3mXBCwFQDYAurNP/Fh57fi1mS+flCxUnHmMn8j8eh0=;
 b=U6rSh8pc7KR+kcf9Op++1puTNA6aQs19y+KAFRUlKPhqAHbAGqxHlQMBG9JHh3wrRO
 KTF0Em59BA5b8+YTTo2sCje2Jc+bKJ4fiaGyz0cK5/xliDim+BI+9xVaLbyHxiZuW2MZ
 l73Q/z+Ats3yFgtkf3KXgK7A2DTZpfopC1w51SgGs+/mLrP6L9s2sC2F5Yy3C5k6If5r
 cy1+2Yw/rn0eRj+5igGUoV1QWM26ytR9dFRE3e53jypMYFrxzgsPlwONpe6UgOQcaK9c
 v9oS18yzJOP5AlUKHqHVKAPiXjfFgIr2bOYKq9mNNVaslWO+jyXE5yMoTsY0aMTsVyi9
 0VvQ==
X-Gm-Message-State: AOJu0YzRZRYdiz7K8pUKLasvZHkgyDfEXReUTUFIOryFWOe2PdggrLv0
 7GQOKPB5urKuRFTijIcpBNM+Ah8dswkACDUTDGWZtHZ5
X-Google-Smtp-Source: AGHT+IE//KHlz9VxCdy2G7yHUxb4G45zUk7kyeMCIOodmRkp0UrZDs9bue+NE2/2czbOHfzcU25KpBMDz+8JtMzeUD0=
X-Received: by 2002:a05:6214:c5:b0:67a:88e7:20ff with SMTP id
 f5-20020a05621400c500b0067a88e720ffmr3509561qvs.14.1701630152396; Sun, 03 Dec
 2023 11:02:32 -0800 (PST)
MIME-Version: 1.0
References: <CAMGeJwnTPzxLZrxzsB8L66=TnjydoSuGj2wHL7YGgvvh5rr=jQ@HIDDEN>
 <CALDnm51asPT+L+TbAF75uzhGPbMZJ67b_VfM9pANg723LVrNwA@HIDDEN>
In-Reply-To: <CALDnm51asPT+L+TbAF75uzhGPbMZJ67b_VfM9pANg723LVrNwA@HIDDEN>
From: Morgon Kanter <morgon.kanter@HIDDEN>
Date: Sun, 3 Dec 2023 14:02:24 -0500
Message-ID: <CAMGeJwn2nVdv4cS9sHHru+FFaJJLqhUD1qrFD1nULLHqVxe4TA@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-Mailman-Approved-At: Mon, 04 Dec 2023 00:46:10 -0500
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi Jo=C3=A3o,

> Hi.  Because you're using 'eglot-ensure' (hint, maybe you
> shoudn't, read the manual in the latest master for why)
> it means that after the eglot-ensure form executes,
> Eglot will not be setup yet, so the following form
> has no effect.  You need to replace it with [snip]

I believe there is more to the story than this. I can remove the
eglot-ensure, load eglot so eglot-inlay-hints-mode is a valid symbol,
and replace my config with this:

(defun config:cc-defaults ()
  ;(setq c-require-final-newline t)  ;; lol causes errors in cc-mode
  (c-toggle-comment-style 1)
  (subword-mode 1)
  (diminish 'subword-mode)
  (local-set-key (kbd "C-M-S-<backspace>") #'kill-outer-sexp-and-parens)
  (eglot-inlay-hints-mode -1))

...and I will receive the same behavior. The eglot-ensure here is a red her=
ring.

To reproduce, visit a C++ buffer in a project, run M-x eglot. Inlay
hints will appear. Kill and reopen the buffer. Inlay hints will
appear.

-- Morgon

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#67609: 29.1; (eglot-inlay-hints-mode -1) behaves surprisingly, does not work in cc-mode hooks
Resent-From: Morgon Kanter <morgon.kanter@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 04 Dec 2023 05:47:03 +0000
Resent-Message-ID: <handler.67609.B67609.170166877729857 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 67609
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN>
Cc: 67609 <at> debbugs.gnu.org
Received: via spool by 67609-submit <at> debbugs.gnu.org id=B67609.170166877729857
          (code B ref 67609); Mon, 04 Dec 2023 05:47:03 +0000
Received: (at 67609) by debbugs.gnu.org; 4 Dec 2023 05:46:17 +0000
Received: from localhost ([127.0.0.1]:33338 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rA1mX-0007lJ-Bh
	for submit <at> debbugs.gnu.org; Mon, 04 Dec 2023 00:46:17 -0500
Received: from mail-qv1-xf30.google.com ([2607:f8b0:4864:20::f30]:42469)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <morgon.kanter@HIDDEN>) id 1r9sI2-00059m-FD
 for 67609 <at> debbugs.gnu.org; Sun, 03 Dec 2023 14:38:06 -0500
Received: by mail-qv1-xf30.google.com with SMTP id
 6a1803df08f44-677fba00a49so32896196d6.1
 for <67609 <at> debbugs.gnu.org>; Sun, 03 Dec 2023 11:37:56 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1701632270; x=1702237070; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:from:to:cc:subject:date:message-id:reply-to;
 bh=1J2ESE6cLhFWNTz3XVCvryGGCpOsEF+KHpIqLL+1i80=;
 b=X6Xf6xwsqF41cUQd4ogFcEFMOus7SKT/OIa8WNw2OF8jptLnhdbS65w5Sn8soDZwVU
 fjNcm7uqbn6Fun7hGwGdppp0SyfmLUweQJmHuzXMYTNNrZc+wMK6XOIR32CBwJNO55sU
 zszNTZ/jeieoS6JVOAdc++3eenv995BegjcMHS80dKjMR6yE5pI4Wtw+L/3IjZhOhDZw
 kDLxsHUyDYKbIsyrSgyFtvEJD4+H3QcJShxZtlNFOXwd4+6Gh8vNgtD2UBPcDANva8C/
 j0I32sm1pLHEMDBgFWMOz8qj4NIP3T7+AAz4muI9ppdOe9Yzp4PAOEgPj2OJdDS+ZtjK
 3+Lg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1701632270; x=1702237070;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=1J2ESE6cLhFWNTz3XVCvryGGCpOsEF+KHpIqLL+1i80=;
 b=rMAi16UnZgrfyP7xaHNqmfw7/CDJNvljfZjz1iwCYjphp9I7utXGWwakHQ7ASIuaRk
 Uo6m4eOD52j91CSlyFEMvYpE9dY4JOe2Q4DFqR5rBVIofbMzAoTsec905UkvsKQ7uOUN
 4EPxrfdTHq1S2krzrQWb6Kp8j4hncclncolyEuAZcH4a3YIFF7vKi2YxkbE5IIgWh+mZ
 tkpMtxynrbxAGeD34Civcc/HALTuVwFI+nQl6QG1x9/icuKkHFGNNiq3mecd332EULt8
 n4DjNwyQzKsCHAQoK7Z1Hl9zkhSeBdB3NEpEO+8MYt/acOJJ9bh6gyEc9gFaVjw+0Ww7
 1Lkg==
X-Gm-Message-State: AOJu0Yz7lDasYBY0Cu62aR8nPkAmNhWbOlWqHGPOHM1Rg0b83okLz2+J
 Fg7dHVnGjG3i54vNEa/FeQTBPOoVZHit61BH
X-Google-Smtp-Source: AGHT+IG7pFQPYm5p9n078w3ZKK6QTk+e5FHvr+UiJzMQDSIAl/SiKR0VZnqePj5Y6qdoTFmrgzmG7U6BKi5YFNWskKI=
X-Received: by 2002:ad4:5ae9:0:b0:67a:52eb:7a00 with SMTP id
 c9-20020ad45ae9000000b0067a52eb7a00mr4737805qvh.7.1701632270430; Sun, 03 Dec
 2023 11:37:50 -0800 (PST)
MIME-Version: 1.0
References: <CAMGeJwnTPzxLZrxzsB8L66=TnjydoSuGj2wHL7YGgvvh5rr=jQ@HIDDEN>
 <CALDnm51asPT+L+TbAF75uzhGPbMZJ67b_VfM9pANg723LVrNwA@HIDDEN>
 <CAMGeJwn2nVdv4cS9sHHru+FFaJJLqhUD1qrFD1nULLHqVxe4TA@HIDDEN>
 <CALDnm50UvqT1M=mfu5HL4qbNwN4iNsqL2vT6KBy7XWy9+pkhOQ@HIDDEN>
In-Reply-To: <CALDnm50UvqT1M=mfu5HL4qbNwN4iNsqL2vT6KBy7XWy9+pkhOQ@HIDDEN>
From: Morgon Kanter <morgon.kanter@HIDDEN>
Date: Sun, 3 Dec 2023 14:37:42 -0500
Message-ID: <CAMGeJwknf33W0sdO7xUQuKKxsvt+VH0KO5=A43nV3YowaCkUzw@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: -0.0 (/)
X-Mailman-Approved-At: Mon, 04 Dec 2023 00:46:10 -0500
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

> > To reproduce, visit a C++ buffer in a project, run M-x eglot. Inlay
> > hints will appear. Kill and reopen the buffer. Inlay hints will
> > appear.
>
> To achieve your desired behaviour, read my advice in the last email,
> thanks.

Fair enough. I understand now that the correct and expected way to
disable this is the way you have described. Since the behavior appears
surprising though, and it looks like the only such eglot-related mode
command is eglot-inlay-hints-mode, could something like this quote be
added to the manual for eglot-inlay-hints-mode?

"Eglot will turn on eglot-inlay-hints-mode after setting up, which
happens after most mode hooks are run. To disable it, you should run
(eglot-inlay-hints-mode -1) in eglot-managed-mode-hook, rather than
your buffer's major mode hooks."

This should hopefully stop bug reports like mine in the future.

Thanks,
-- Morgon

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#67609: 29.1; (eglot-inlay-hints-mode -1) behaves surprisingly, does not work in cc-mode hooks
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 16 Dec 2023 09:33:02 +0000
Resent-Message-ID: <handler.67609.B67609.17027191314554 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 67609
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Morgon Kanter <morgon.kanter@HIDDEN>
Cc: joaotavora@HIDDEN, 67609 <at> debbugs.gnu.org
Received: via spool by 67609-submit <at> debbugs.gnu.org id=B67609.17027191314554
          (code B ref 67609); Sat, 16 Dec 2023 09:33:02 +0000
Received: (at 67609) by debbugs.gnu.org; 16 Dec 2023 09:32:11 +0000
Received: from localhost ([127.0.0.1]:53960 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rER1m-0001BO-Iy
	for submit <at> debbugs.gnu.org; Sat, 16 Dec 2023 04:32:10 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:36324)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1rER1k-0001BA-LT
 for 67609 <at> debbugs.gnu.org; Sat, 16 Dec 2023 04:32:09 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1rER1e-0007Tp-Rl; Sat, 16 Dec 2023 04:32:02 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=JJRa5vYHKpdFc8UAcwnD8HwAVUOQYdOWQWEh/lKk4Kc=; b=UEdzqrr2Sb5/sXoqj6Si
 AZhCvA9wsnd1nbnEFfhZwmH8Z9JCn26+sJZktBruOzDSAlrF0/L+y3pyks3SK3IIE9capC8h1csIc
 xynmJF8X6xrs+Y1yNsXr8wQf6ATZE/M2/qM39S9DWCy03/2vU3ci1p7LWHhtfkp73wfjQ8K3lW8fs
 fsqLLD88+12fa/XxgxvC5DGOg0sDoze5Xm01C1AP6SO8GmdPmDJme8AXMPA41YiGiT+5Ulhw2Xkx7
 9J8OJWFi+KTvyZXEtFRnKShSB20lyFbRXKPN1Jzw6SlqENok7x4XZTbJnakmIHNx4wQV0XC/Vdy9h
 v93/qph+S/WW1Q==;
Date: Sat, 16 Dec 2023 11:31:43 +0200
Message-Id: <8334w2o5mo.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <CAMGeJwknf33W0sdO7xUQuKKxsvt+VH0KO5=A43nV3YowaCkUzw@HIDDEN>
 (message from Morgon Kanter on Sun, 3 Dec 2023 14:37:42 -0500)
References: <CAMGeJwnTPzxLZrxzsB8L66=TnjydoSuGj2wHL7YGgvvh5rr=jQ@HIDDEN>
 <CALDnm51asPT+L+TbAF75uzhGPbMZJ67b_VfM9pANg723LVrNwA@HIDDEN>
 <CAMGeJwn2nVdv4cS9sHHru+FFaJJLqhUD1qrFD1nULLHqVxe4TA@HIDDEN>
 <CALDnm50UvqT1M=mfu5HL4qbNwN4iNsqL2vT6KBy7XWy9+pkhOQ@HIDDEN>
 <CAMGeJwknf33W0sdO7xUQuKKxsvt+VH0KO5=A43nV3YowaCkUzw@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Cc: 67609 <at> debbugs.gnu.org
> From: Morgon Kanter <morgon.kanter@HIDDEN>
> Date: Sun, 3 Dec 2023 14:37:42 -0500
> 
> > > To reproduce, visit a C++ buffer in a project, run M-x eglot. Inlay
> > > hints will appear. Kill and reopen the buffer. Inlay hints will
> > > appear.
> >
> > To achieve your desired behaviour, read my advice in the last email,
> > thanks.
> 
> Fair enough. I understand now that the correct and expected way to
> disable this is the way you have described. Since the behavior appears
> surprising though, and it looks like the only such eglot-related mode
> command is eglot-inlay-hints-mode, could something like this quote be
> added to the manual for eglot-inlay-hints-mode?
> 
> "Eglot will turn on eglot-inlay-hints-mode after setting up, which
> happens after most mode hooks are run. To disable it, you should run
> (eglot-inlay-hints-mode -1) in eglot-managed-mode-hook, rather than
> your buffer's major mode hooks."
> 
> This should hopefully stop bug reports like mine in the future.

João, do we need to do anything here, or can this be closed now?

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#67609: 29.1; (eglot-inlay-hints-mode -1) behaves surprisingly, does not work in cc-mode hooks
Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 16 Dec 2023 11:56:01 +0000
Resent-Message-ID: <handler.67609.B67609.170272775313950 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 67609
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 67609 <at> debbugs.gnu.org, Morgon Kanter <morgon.kanter@HIDDEN>
Received: via spool by 67609-submit <at> debbugs.gnu.org id=B67609.170272775313950
          (code B ref 67609); Sat, 16 Dec 2023 11:56:01 +0000
Received: (at 67609) by debbugs.gnu.org; 16 Dec 2023 11:55:53 +0000
Received: from localhost ([127.0.0.1]:54079 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rETGr-0003cw-9H
	for submit <at> debbugs.gnu.org; Sat, 16 Dec 2023 06:55:53 -0500
Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]:58618)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <joaotavora@HIDDEN>) id 1rETGp-0003cf-H3
 for 67609 <at> debbugs.gnu.org; Sat, 16 Dec 2023 06:55:52 -0500
Received: by mail-lf1-x136.google.com with SMTP id
 2adb3069b0e04-50bce78f145so1754350e87.0
 for <67609 <at> debbugs.gnu.org>; Sat, 16 Dec 2023 03:55:50 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1702727745; x=1703332545; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:from:to:cc:subject:date:message-id:reply-to;
 bh=9t5sulWpWfeLOZJ6wTkVXwqc4InZyaS0qPFB1y5Ce74=;
 b=jIQCr8BRwcAGTcoUifXDHn8W6s+53I/BtV++5BaRYiuayI04g00Bbua2D6d3jrUN/o
 rrJw2okfngCeKbpv7o5hxAAgqeLav7I2hGN4G5v43e7XIwZfhbjukzAqVRu3vGGDUToL
 mHe7TdwCf8fgNVf1UmAAt56j7pe+Qug4ClmlA+I2X78Dw7SzVDPia9P0esqhm95p5LBa
 qI7XQBNL0MpiI5laBnSxmyje5SwXHUz3JA6A3+Q9/ck8Fk7NH6PwW5lRvTi0XKF86Mgc
 SteyvWhSh/GzCxvaHr48XFj1mbTsWekzAdNNYbJNYlO34q0i3xeaSsLplJpOpio80ljx
 8XiQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1702727745; x=1703332545;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=9t5sulWpWfeLOZJ6wTkVXwqc4InZyaS0qPFB1y5Ce74=;
 b=fWBsEepZl17lekS24jvJXdW1c5aCAGSm3YriRe4Rx97Hq/Vnsa7bJBaICNrSxZnh4M
 thFWR+14q685XopHuKmkdigVLX7CH5bUWjYoT5wgmcxyRJ9D3Ye72WRXTbn242pCvBBl
 3SdQVIDIFQ/wOLccwGOybk/ciMGBNS375HWyc1KWtF4yuqgX4bLi8bsDo31BV8+Hndu+
 5dnzYMeG/I7lSEw1LRXMqvRM4/88WbR5cNjkfJOBVoddbKJHD85Lm63osfXZlUn5dZgW
 kvtxomhEdlKhs1Xvlp1R/04dAEBxeCyGiB0Aj7KOcoV36Vpz1yFvo+LD916JkHyqNZ8q
 ETWw==
X-Gm-Message-State: AOJu0YwKv3VYCIP+yhzioSGOaqXWSpc3O5aqcpWm9YoztDfpQGYY819N
 vCqx8SQxdLgU07PiwPAFkqtsDpdUEKmKEMpM79E=
X-Google-Smtp-Source: AGHT+IFTdj3vE5WVfdaovSQf2YqldULDvUd7/+vSHKsaWXTkulkhutzjz7XdcBG+JpKmFiEKnb0Ue9G/nwUiEimw/oY=
X-Received: by 2002:a05:6512:b02:b0:50d:563d:f083 with SMTP id
 w2-20020a0565120b0200b0050d563df083mr3625894lfu.63.1702727744770; Sat, 16 Dec
 2023 03:55:44 -0800 (PST)
MIME-Version: 1.0
References: <CAMGeJwnTPzxLZrxzsB8L66=TnjydoSuGj2wHL7YGgvvh5rr=jQ@HIDDEN>
 <CALDnm51asPT+L+TbAF75uzhGPbMZJ67b_VfM9pANg723LVrNwA@HIDDEN>
 <CAMGeJwn2nVdv4cS9sHHru+FFaJJLqhUD1qrFD1nULLHqVxe4TA@HIDDEN>
 <CALDnm50UvqT1M=mfu5HL4qbNwN4iNsqL2vT6KBy7XWy9+pkhOQ@HIDDEN>
 <CAMGeJwknf33W0sdO7xUQuKKxsvt+VH0KO5=A43nV3YowaCkUzw@HIDDEN>
 <8334w2o5mo.fsf@HIDDEN>
In-Reply-To: <8334w2o5mo.fsf@HIDDEN>
From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN>
Date: Sat, 16 Dec 2023 11:55:32 +0000
Message-ID: <CALDnm512DGYLVsD6eRzEZ7GgVvMtnKLPhOuik_TwW=R_cCX56Q@HIDDEN>
Content-Type: multipart/alternative; boundary="0000000000006056d1060c9f326d"
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--0000000000006056d1060c9f326d
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, Dec 16, 2023, 09:32 Eli Zaretskii <eliz@HIDDEN> wrote:

> > Cc: 67609 <at> debbugs.gnu.org
> > From: Morgon Kanter <morgon.kanter@HIDDEN>
> > Date: Sun, 3 Dec 2023 14:37:42 -0500
> >
> > > > To reproduce, visit a C++ buffer in a project, run M-x eglot. Inlay
> > > > hints will appear. Kill and reopen the buffer. Inlay hints will
> > > > appear.
> > >
> > > To achieve your desired behaviour, read my advice in the last email,
> > > thanks.
> >
> > Fair enough. I understand now that the correct and expected way to
> > disable this is the way you have described. Since the behavior appears
> > surprising though, and it looks like the only such eglot-related mode
> > command is eglot-inlay-hints-mode, could something like this quote be
> > added to the manual for eglot-inlay-hints-mode?
> >
> > "Eglot will turn on eglot-inlay-hints-mode after setting up, which
> > happens after most mode hooks are run. To disable it, you should run
> > (eglot-inlay-hints-mode -1) in eglot-managed-mode-hook, rather than
> > your buffer's major mode hooks."
> >
> > This should hopefully stop bug reports like mine in the future.
>
> Jo=C3=A3o, do we need to do anything here, or can this be closed now?
>

I mean to add something to the manual  (though not specifically for inlay
hints) that will help users connect the pieces of this puzzle more easily,
the there pieces being.

Eglot generally turns all supported things on by default
Eglot has a minor mode with a hook
Eglot functions called from lisp have no effect outside the minor mode.

Jo=C3=A3o

>

--0000000000006056d1060c9f326d
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto"><div><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D=
"gmail_attr">On Sat, Dec 16, 2023, 09:32 Eli Zaretskii &lt;<a href=3D"mailt=
o:eliz@HIDDEN" target=3D"_blank" rel=3D"noreferrer">eliz@HIDDEN</a>&gt; w=
rote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex=
;border-left:1px #ccc solid;padding-left:1ex">&gt; Cc: <a href=3D"mailto:67=
609 <at> debbugs.gnu.org" rel=3D"noreferrer noreferrer" target=3D"_blank">67609@=
debbugs.gnu.org</a><br>
&gt; From: Morgon Kanter &lt;<a href=3D"mailto:morgon.kanter@HIDDEN" rel=
=3D"noreferrer noreferrer" target=3D"_blank">morgon.kanter@HIDDEN</a>&gt=
;<br>
&gt; Date: Sun, 3 Dec 2023 14:37:42 -0500<br>
&gt; <br>
&gt; &gt; &gt; To reproduce, visit a C++ buffer in a project, run M-x eglot=
. Inlay<br>
&gt; &gt; &gt; hints will appear. Kill and reopen the buffer. Inlay hints w=
ill<br>
&gt; &gt; &gt; appear.<br>
&gt; &gt;<br>
&gt; &gt; To achieve your desired behaviour, read my advice in the last ema=
il,<br>
&gt; &gt; thanks.<br>
&gt; <br>
&gt; Fair enough. I understand now that the correct and expected way to<br>
&gt; disable this is the way you have described. Since the behavior appears=
<br>
&gt; surprising though, and it looks like the only such eglot-related mode<=
br>
&gt; command is eglot-inlay-hints-mode, could something like this quote be<=
br>
&gt; added to the manual for eglot-inlay-hints-mode?<br>
&gt; <br>
&gt; &quot;Eglot will turn on eglot-inlay-hints-mode after setting up, whic=
h<br>
&gt; happens after most mode hooks are run. To disable it, you should run<b=
r>
&gt; (eglot-inlay-hints-mode -1) in eglot-managed-mode-hook, rather than<br=
>
&gt; your buffer&#39;s major mode hooks.&quot;<br>
&gt; <br>
&gt; This should hopefully stop bug reports like mine in the future.<br>
<br>
Jo=C3=A3o, do we need to do anything here, or can this be closed now?<br></=
blockquote></div></div><div dir=3D"auto"><br></div><div dir=3D"auto">I mean=
 to add something to the manual=C2=A0 (though not specifically for inlay hi=
nts) that will help users connect the pieces of this puzzle more easily, th=
e there pieces being.</div><div dir=3D"auto"><br></div><div dir=3D"auto">Eg=
lot generally turns all supported things on by default</div><div dir=3D"aut=
o">Eglot has a minor mode with a hook</div><div dir=3D"auto">Eglot function=
s called from lisp have no effect outside the minor mode.</div><div dir=3D"=
auto"><br></div><div dir=3D"auto">Jo=C3=A3o</div><div dir=3D"auto"><div cla=
ss=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 =
.8ex;border-left:1px #ccc solid;padding-left:1ex">
</blockquote></div></div></div>

--0000000000006056d1060c9f326d--

Last modified: Sat, 20 Jan 2024 12:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.