GNU bug report logs - #67616
[PATCH] Fix: add comint hook locally in lua-ts-inferior-lua

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 67616 in the body.
You can then email your comments to 67616 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Noah Peart <noah.v.peart <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix: add comint hook locally in lua-ts-inferior-lua
Date: Sun, 3 Dec 2023 19:26:54 -0800

[Message part 1 (text/plain, inline)]

Tags: patch


Bug: In `lua-ts-inferior-lua`, `comint-preoutput-filter-functions` hook
isn't added locally.


In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.33, cairo version 1.16.0) of 2023-12-03 built on noah-X580VD
Repository revision: 9c1f24d7a497ee8b9c1ec3f1161a3ed7d6e34bd0
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Ubuntu 22.04.3 LTS

Configured using:
 'configure --prefix=/usr/local --with-modules --with-tree-sitter
--with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls
--with-json --with-mailutils --with-jpeg --with-png --with-rsvg
--with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12
CXX=gcc-12'

[Message part 2 (text/html, inline)]

[lua-ts-inferior-hook.patch (text/x-patch, attachment)]

Message #8 received at 67616 <at> debbugs.gnu.org (full text, mbox):

From: john muhl <jm <at> pub.pink>
To: Noah Peart <noah.v.peart <at> gmail.com>
Cc: 67616 <at> debbugs.gnu.org
Subject: Re: bug#67616: [PATCH] Fix: add comint hook locally in
 lua-ts-inferior-lua
Date: Sun, 03 Dec 2023 22:18:22 -0600

[Message part 1 (text/plain, inline)]

Noah Peart <noah.v.peart <at> gmail.com> writes:

> Tags: patch
>
> Bug: In `lua-ts-inferior-lua`, `comint-preoutput-filter-functions` hook
> isn't added locally.

Thanks. I think that obsoletes the buffer-name check at the
beginning. A quick test looks that way to me. Could you give a try?

[0001-Fix-add-comint-hook-locally-in-lua-ts-inferior-lua.patch (text/x-patch, attachment)]

Message #11 received at 67616 <at> debbugs.gnu.org (full text, mbox):

From: Noah Peart <noah.v.peart <at> gmail.com>
To: john muhl <jm <at> pub.pink>
Cc: 67616 <at> debbugs.gnu.org
Subject: Re: bug#67616: [PATCH] Fix: add comint hook locally in
 lua-ts-inferior-lua
Date: Sun, 3 Dec 2023 23:58:46 -0800

[Message part 1 (text/plain, inline)]

Yea, that looks good to me.  Is it necessary to set
`comint-use-prompt-regexp` to `t`?
The behaviour of `comint-previous/next-prompt` seems better when that is
nil.
Thanks!

On Sun, Dec 3, 2023 at 8:30 PM john muhl <jm <at> pub.pink> wrote:

> Noah Peart <noah.v.peart <at> gmail.com> writes:
>
> > Tags: patch
> >
> > Bug: In `lua-ts-inferior-lua`, `comint-preoutput-filter-functions` hook
> > isn't added locally.
>
> Thanks. I think that obsoletes the buffer-name check at the
> beginning. A quick test looks that way to me. Could you give a try?
>
>

[Message part 2 (text/html, inline)]

Message #14 received at 67616 <at> debbugs.gnu.org (full text, mbox):

From: john muhl <jm <at> pub.pink>
To: Noah Peart <noah.v.peart <at> gmail.com>
Cc: 67616 <at> debbugs.gnu.org
Subject: Re: bug#67616: [PATCH] Fix: add comint hook locally in
 lua-ts-inferior-lua
Date: Mon, 04 Dec 2023 12:17:27 -0600

[Message part 1 (text/plain, inline)]

Noah Peart <noah.v.peart <at> gmail.com> writes:

> Yea, that looks good to me.  Is it necessary to set
> `comint-use-prompt-regexp` to `t`?
> The behaviour of `comint-previous/next-prompt` seems better when
> that is nil.
> Thanks!

You’re right. I wasn’t able to get creative enough to merge them
into a single commit so it’s separate.

[0001-Fix-add-comint-hook-locally-in-lua-ts-inferior-lua.patch (text/x-patch, attachment)]

[0001-Fix-comint-next-previous-prompt-in-lua-ts-mode.patch (text/x-patch, attachment)]

Message #19 received at 67616-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: john muhl <jm <at> pub.pink>
Cc: noah.v.peart <at> gmail.com, 67616-done <at> debbugs.gnu.org
Subject: Re: bug#67616: [PATCH] Fix: add comint hook locally in
 lua-ts-inferior-lua
Date: Sat, 16 Dec 2023 11:39:04 +0200

> Cc: 67616 <at> debbugs.gnu.org
> Date: Mon, 04 Dec 2023 12:17:27 -0600
> From:  john muhl via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> Noah Peart <noah.v.peart <at> gmail.com> writes:
> 
> > Yea, that looks good to me.  Is it necessary to set
> > `comint-use-prompt-regexp` to `t`?
> > The behaviour of `comint-previous/next-prompt` seems better when
> > that is nil.
> > Thanks!
> 
> You’re right. I wasn’t able to get creative enough to merge them
> into a single commit so it’s separate.

Thanks, installed on the master branch, and closing the bug.

P.S. Please both of you see how I edited the commit log messages in
minor ways, and try to follow this in the future.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.