GNU bug report logs - #67658
filesets can’t open files from menu-bar when using ‘:tree’

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 67658 in the body.
You can then email your comments to 67658 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: ". shynur" <one.last.kiss <at> outlook.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: filesets can’t open files from menu-bar when using ‘:tree’
Date: Wed, 6 Dec 2023 11:17:41 +0000

Reproduce:

  PS D:/Tmp> dir 
  test.txt test.org
  PS D:/Tmp> runemacs.exe -Q
  
  (require 'filesets)
  (push `("Teest"
          . ((:tree ,default-directory ""))) filesets-data)
  (filesets-init)
  
  M-x eval-buffer 
  
  Click: Menu-Bar -> File -> Filesets -> 0 Teest -> Tree: d:/Tmp/
  
Then emacs just gave me an error:
  “filesets-files-under: Wrong type argument: stringp, nil”
  
I expected it to open all the files under that directory.
Am I missing something?

___

v29.1.90 for MS-Windows

Message #8 received at 67658 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: ". shynur" <one.last.kiss <at> outlook.com>
Cc: 67658 <at> debbugs.gnu.org
Subject: Re: bug#67658: filesets can’t open files from
 menu-bar when using ‘:tree’
Date: Sat, 16 Dec 2023 13:33:17 +0200

> From: ". shynur" <one.last.kiss <at> outlook.com>
> Date: Wed, 6 Dec 2023 11:17:41 +0000
> 
> Reproduce:
> 
>   PS D:/Tmp> dir 
>   test.txt test.org
>   PS D:/Tmp> runemacs.exe -Q
>   
>   (require 'filesets)
>   (push `("Teest"
>           . ((:tree ,default-directory ""))) filesets-data)
>   (filesets-init)
>   
>   M-x eval-buffer 
>   
>   Click: Menu-Bar -> File -> Filesets -> 0 Teest -> Tree: d:/Tmp/
>   
> Then emacs just gave me an error:
>   “filesets-files-under: Wrong type argument: stringp, nil”
>   
> I expected it to open all the files under that directory.
> Am I missing something?

You are not missing anything, this has been broken since Emacs 28.1,
where we installed a change which fixed "normal" invocation of
filesets-open, but broke its invocations from the menu-bar menus.  The
breakage was due to omitting from the fix to bug#976 the cautious 'if'
clause in the original author's code.

This should be fixed now on the emacs-29 branch.

Message #13 received at 67658-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: one.last.kiss <at> outlook.com
Cc: 67658-done <at> debbugs.gnu.org
Subject: Re: bug#67658: filesets can’t open files from
 menu-bar when using ‘:tree’
Date: Sat, 23 Dec 2023 11:01:57 +0200

> Cc: 67658 <at> debbugs.gnu.org
> Date: Sat, 16 Dec 2023 13:33:17 +0200
> From: Eli Zaretskii <eliz <at> gnu.org>
> 
> > From: ". shynur" <one.last.kiss <at> outlook.com>
> > Date: Wed, 6 Dec 2023 11:17:41 +0000
> > 
> > Reproduce:
> > 
> >   PS D:/Tmp> dir 
> >   test.txt test.org
> >   PS D:/Tmp> runemacs.exe -Q
> >   
> >   (require 'filesets)
> >   (push `("Teest"
> >           . ((:tree ,default-directory ""))) filesets-data)
> >   (filesets-init)
> >   
> >   M-x eval-buffer 
> >   
> >   Click: Menu-Bar -> File -> Filesets -> 0 Teest -> Tree: d:/Tmp/
> >   
> > Then emacs just gave me an error:
> >   “filesets-files-under: Wrong type argument: stringp, nil”
> >   
> > I expected it to open all the files under that directory.
> > Am I missing something?
> 
> You are not missing anything, this has been broken since Emacs 28.1,
> where we installed a change which fixed "normal" invocation of
> filesets-open, but broke its invocations from the menu-bar menus.  The
> breakage was due to omitting from the fix to bug#976 the cautious 'if'
> clause in the original author's code.
> 
> This should be fixed now on the emacs-29 branch.

No further comments, so I presume the bug was fixed, and I'm closing
it.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.