GNU bug report logs - #67674
30.0.50; shr-heading's update broke racket-mode's documention read

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 67674 in the body.
You can then email your comments to 67674 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mou Tong <mou.tong <at> outlook.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: 30.0.50; shr-heading's update broke racket-mode's documention read
Date: Thu, 7 Dec 2023 02:49:20 +0000

[Message part 1 (text/plain, inline)]

Hi there, I noticed that after this commit

https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d41a5e4b1bafbb974d2c886d3198d9bda7821591

There are some changes in the function `shr-heading`.

```diff
 (defun shr-heading (dom &rest types)
   (shr-ensure-paragraph)
-  (apply #'shr-fontize-dom dom types)
+  (let ((start (point))
+     (level (string-to-number
+         (string-remove-prefix "shr-h" (symbol-name (car types))))))
+   (apply #'shr-fontize-dom dom types)
+   (put-text-property start (pos-eol) 'outline-level level))
   (shr-ensure-paragraph))
```

In racket-mode, when looking for local docs, racket-mode will use the
following function to `shr-heading`:

    (shr-heading dom face)

Here `dom` is unrelated to this, problem occurs in `face`:

`racket-mode` passed `face` (as an example, which value is
`(variable-pitch (:height 1.6))`) to `shr-heading`, when `shr-heading`
parses it:

    (symbol-name (car '((variable-patch (:height 1.6)))))

error occurs:

    (wrong-type-argument symbolp (variable-patch (:height 1.6)))

Does this counts as an Emacs's bug, or racket-mode's problem? thx

[Message part 2 (text/html, inline)]

Message #8 received at 67674 <at> debbugs.gnu.org (full text, mbox):

From: Mou Tong <mou.tong <at> outlook.com>
To: Mou Tong <mou.tong <at> outlook.com>
Cc: "67674 <at> debbugs.gnu.org" <67674 <at> debbugs.gnu.org>
Subject: 30.0.50; shr-heading's update broke racket-mode's documention
Date: Fri, 8 Dec 2023 01:09:49 +0000

[Message part 1 (text/plain, inline)]

Ah, never mind, please close this.

I have reported this to racket-mode, and it got fixed in racket-mode.

Sorry for the noise.

[Message part 2 (text/html, inline)]

Message #13 received at 67674-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Mou Tong <mou.tong <at> outlook.com>
Cc: 67674-done <at> debbugs.gnu.org
Subject: Re: bug#67674: 30.0.50;
 shr-heading's update broke racket-mode's documention
Date: Fri, 08 Dec 2023 08:45:11 +0200

> Cc: "67674 <at> debbugs.gnu.org" <67674 <at> debbugs.gnu.org>
> From: Mou Tong <mou.tong <at> outlook.com>
> Date: Fri, 8 Dec 2023 01:09:49 +0000
> 
> Ah, never mind, please close this. 
> 
> I have reported this to racket-mode, and it got fixed in racket-mode.

Closed, thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.