X-Loop: help-debbugs@HIDDEN
Subject: [bug#67681] [PATCH] gnu: Add node-commander.
Resent-From: Rikard Nordgren <hrn@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 07 Dec 2023 08:30:02 +0000
Resent-Message-ID: <handler.67681.B.170193779931991 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: report 67681
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 67681 <at> debbugs.gnu.org
Cc: hrn@HIDDEN
X-Debbugs-Original-To: guix-patches@HIDDEN
Received: via spool by submit <at> debbugs.gnu.org id=B.170193779931991
(code B ref -1); Thu, 07 Dec 2023 08:30:02 +0000
Received: (at submit) by debbugs.gnu.org; 7 Dec 2023 08:29:59 +0000
Received: from localhost ([127.0.0.1]:40976 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rB9le-0008Ju-RP
for submit <at> debbugs.gnu.org; Thu, 07 Dec 2023 03:29:59 -0500
Received: from lists.gnu.org ([2001:470:142::17]:54516)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <hrn@HIDDEN>) id 1rB9lZ-0008Jb-Jc
for submit <at> debbugs.gnu.org; Thu, 07 Dec 2023 03:29:57 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <hrn@HIDDEN>) id 1rB9lH-0002R5-9b
for guix-patches@HIDDEN; Thu, 07 Dec 2023 03:29:35 -0500
Received: from mout02.posteo.de ([185.67.36.66])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <hrn@HIDDEN>) id 1rB9lE-00046z-JH
for guix-patches@HIDDEN; Thu, 07 Dec 2023 03:29:34 -0500
Received: from submission (posteo.de [185.67.36.169])
by mout02.posteo.de (Postfix) with ESMTPS id 303E5240105
for <guix-patches@HIDDEN>; Thu, 7 Dec 2023 09:29:30 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
t=1701937770; bh=R+iD9InYL89BRw+fBwRndRubAI3S3ll4zmmeg4eNnko=;
h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:
Content-Transfer-Encoding:From;
b=WCO2a1mHxsOVhTVpN8gd6zFULPzUi8WsGaepTA+lkb2RgUxkcRDdo7dtD7r0IHdmj
OJ4vCrvSLaNqAy65gRg3Eza5ByAQiNFg6ouKP+9u3ximWao8l1NBRPdtMKvwu1LW00
sIv2SNcqLrLvBzlVAma41OhhpR3xeifGfu4BHHMQbEGWMlHPizTGSBxl0WI9C0K6Ow
0A+T4FYFPSEBitMlw/7Gx8F8NIO1KqDTjQo+wA8u3ENeHbzhREMjwEZ9jh3cY/1/jn
VWorvQ5P39fVIiOFHv/HBzLBV9LlAYwzIUviEVVvp99AnD4pee69/VG5MTo3CveSf9
Zjj7D90ets7nw==
Received: from customer (localhost [127.0.0.1])
by submission (posteo.de) with ESMTPSA id 4Sm6rT5Rkmz6tsg;
Thu, 7 Dec 2023 09:29:29 +0100 (CET)
From: Rikard Nordgren <hrn@HIDDEN>
Date: Thu, 7 Dec 2023 08:29:16 +0000
Message-Id: <5309647d34306d09dba21177002f96a7d7f39e74.1701937716.git.hrn@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=185.67.36.66; envelope-from=hrn@HIDDEN;
helo=mout02.posteo.de
X-Spam_score_int: -43
X-Spam_score: -4.4
X-Spam_bar: ----
X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,
SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
* gnu/packages/node-xyz.scm (node-commander): New variable.
Change-Id: I5b00861705d64e0e89da81acee833e145287bd66
---
gnu/packages/node-xyz.scm | 38 ++++++++++++++++++++++++++++++++++++++
1 file changed, 38 insertions(+)
diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm
index 6c16417309..8486d121dd 100644
--- a/gnu/packages/node-xyz.scm
+++ b/gnu/packages/node-xyz.scm
@@ -155,6 +155,44 @@ (define-public node-color-name
"This package provides a JSON list with color names and their values.")
(license license:expat)))
+(define-public node-commander
+ (package
+ (name "node-commander")
+ (version "11.1.0")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/tj/commander.js")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "1xwh85kbxj76ni41r2h0apl8mjbfcnmxzzp3vlspq30w8kwfckni"))))
+ (build-system node-build-system)
+ (arguments
+ '(#:tests? #f
+ #:phases (modify-phases %standard-phases
+ (add-after 'patch-dependencies 'delete-dependencies
+ (lambda _
+ (delete-dependencies '("@types/jest" "@types/node"
+ "@typescript-eslint/eslint-plugin"
+ "@typescript-eslint/parser"
+ "eslint"
+ "eslint-config-standard"
+ "eslint-config-standard-with-typescript"
+ "eslint-plugin-import"
+ "eslint-plugin-jest"
+ "eslint-plugin-n"
+ "eslint-plugin-promise"
+ "jest"
+ "ts-jest"
+ "tsd"
+ "typescript")))))))
+ (home-page "https://github.com/tj/commander.js")
+ (synopsis "Command line interface for node.js")
+ (description "The complete solution for node.js command-line interfaces.")
+ (license license:expat)))
+
(define-public node-crx3
(package
(name "node-crx3")
base-commit: 23627b1706af25a0a30b96b9169a3495279aff1b
--
2.34.1
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Rikard Nordgren <hrn@HIDDEN> Subject: bug#67681: Acknowledgement ([PATCH] gnu: Add node-commander.) Message-ID: <handler.67681.B.170193779931991.ack <at> debbugs.gnu.org> References: <5309647d34306d09dba21177002f96a7d7f39e74.1701937716.git.hrn@HIDDEN> X-Gnu-PR-Message: ack 67681 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 67681 <at> debbugs.gnu.org Date: Thu, 07 Dec 2023 08:30:02 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): guix-patches@HIDDEN If you wish to submit further information on this problem, please send it to 67681 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 67681: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D67681 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
X-Loop: help-debbugs@HIDDEN
Subject: [bug#67681] [PATCH] gnu: Add node-commander.
Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 04 Jan 2024 03:33:02 +0000
Resent-Message-ID: <handler.67681.B67681.170433912823282 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 67681
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Rikard Nordgren <hrn@HIDDEN>
Cc: 67681 <at> debbugs.gnu.org
Received: via spool by 67681-submit <at> debbugs.gnu.org id=B67681.170433912823282
(code B ref 67681); Thu, 04 Jan 2024 03:33:02 +0000
Received: (at 67681) by debbugs.gnu.org; 4 Jan 2024 03:32:08 +0000
Received: from localhost ([127.0.0.1]:53411 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rLESl-00063R-VI
for submit <at> debbugs.gnu.org; Wed, 03 Jan 2024 22:32:08 -0500
Received: from mail-qk1-x730.google.com ([2607:f8b0:4864:20::730]:59430)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <maxim.cournoyer@HIDDEN>) id 1rLESi-00062t-Aj
for 67681 <at> debbugs.gnu.org; Wed, 03 Jan 2024 22:32:05 -0500
Received: by mail-qk1-x730.google.com with SMTP id
af79cd13be357-781df3bc08fso8255885a.2
for <67681 <at> debbugs.gnu.org>; Wed, 03 Jan 2024 19:32:00 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1704339115; x=1704943915; darn=debbugs.gnu.org;
h=mime-version:user-agent:message-id:date:references:in-reply-to
:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=7lv5B9Y4Ogqof1R6s5SZwXApk5fVHuGKdwuFbUTq8A8=;
b=dLJLDOuemIRFxEEO8a4sFbctVKaRI3RW8J8kjziQC7h8oVDUbYfnn2m7+kj9+9k2ZW
dak0qmvGAq4O1/QfXoTujdKiB8EaVmif7pJxzJrSDr2rwYtGYtInu1VBYYfx+FIsFw8e
Jne/xPPKT1L+oBrw70SCI5YnB3VvejGoa68rG0KhPH9aqhZtQavBw1lWGtq2KFWP2NCn
E1JsOwWPrnKfNSqdkWEcxuSrk8f6jS7WYwmlMeWyNLfNsypwsfN+5yWhTx34pCxwoeiv
XOdFYHwNjAcuHUCcIdD6LEUuqol7OZTbWADbm1BYdM2v9QrueSWnxeiJehSGANpLLTN6
hTBw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1704339115; x=1704943915;
h=mime-version:user-agent:message-id:date:references:in-reply-to
:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
:message-id:reply-to;
bh=7lv5B9Y4Ogqof1R6s5SZwXApk5fVHuGKdwuFbUTq8A8=;
b=MeRL6gZ/cNYRQtPoLUAR9Dr9clGgBdsrAuS2VFCcaJ9zxORpQdRd6vHNWRpMV81ABm
J+c45XILtG+aghnbuNOMTTWWJYPhTaqwCCIDsjVXLwab6ftpfipDstnZBjSfrLaHWR34
agZF9hVgJ+U1x17xYXSG4ViQvCpTT6HWgljRutJ2oH0LCy4Z5j6LE/Wzt+4lO0vAtIq/
1Sg73O5UpF1uK7tRDp0VJuoQofds2tvKdJpclMTNrruWh0eR+JhD6rpB+q/pDQIpp6tk
D8FveHrWwcLU0ce4nfyZfAgu1Q8YcAISuPe9+TFlH45UM6Xx6op3F+fdy/oOZcKXqEcw
P7zA==
X-Gm-Message-State: AOJu0Yw7FF2OsGSRrj/l8jkVmiiu+45fTHth3KMFBxky0lBcrL385d3f
4n8llVH63wLaAec3aK4MdORo0xYiqrsR4w==
X-Google-Smtp-Source: AGHT+IELYmzv6R3jv6jpNjDWkGsIsia5SblmGAowwN7pN6zQ6JTxSvF1rcvFd4BMrC3gmyyz/ABzDg==
X-Received: by 2002:a05:6214:29c2:b0:67f:113c:3679 with SMTP id
gh2-20020a05621429c200b0067f113c3679mr75766qvb.38.1704339114845;
Wed, 03 Jan 2024 19:31:54 -0800 (PST)
Received: from hurd (dsl-10-132-1.b2b2c.ca. [72.10.132.1])
by smtp.gmail.com with ESMTPSA id
bd18-20020ad45692000000b0067eff6713a8sm11436365qvb.87.2024.01.03.19.31.54
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 03 Jan 2024 19:31:54 -0800 (PST)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
In-Reply-To: <5309647d34306d09dba21177002f96a7d7f39e74.1701937716.git.hrn@HIDDEN>
(Rikard Nordgren's message of "Thu, 7 Dec 2023 08:29:16 +0000")
References: <5309647d34306d09dba21177002f96a7d7f39e74.1701937716.git.hrn@HIDDEN>
Date: Wed, 03 Jan 2024 22:31:53 -0500
Message-ID: <87bka14vva.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Hi,
Rikard Nordgren <hrn@HIDDEN> writes:
> * gnu/packages/node-xyz.scm (node-commander): New variable.
>
> Change-Id: I5b00861705d64e0e89da81acee833e145287bd66
> ---
> gnu/packages/node-xyz.scm | 38 ++++++++++++++++++++++++++++++++++++++
> 1 file changed, 38 insertions(+)
>
> diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm
> index 6c16417309..8486d121dd 100644
> --- a/gnu/packages/node-xyz.scm
> +++ b/gnu/packages/node-xyz.scm
> @@ -155,6 +155,44 @@ (define-public node-color-name
> "This package provides a JSON list with color names and their values.")
> (license license:expat)))
>
> +(define-public node-commander
> + (package
> + (name "node-commander")
> + (version "11.1.0")
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/tj/commander.js")
> + (commit (string-append "v" version))))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32 "1xwh85kbxj76ni41r2h0apl8mjbfcnmxzzp3vlspq30w8kwfckni"))))
> + (build-system node-build-system)
> + (arguments
> + '(#:tests? #f
Why is the test suite disabled? A comment (explaining a good reason) is
needed :-).
> + #:phases (modify-phases %standard-phases
> + (add-after 'patch-dependencies 'delete-dependencies
A comment explaining why these are removed would help.
> + (lambda _
> + (delete-dependencies '("@types/jest" "@types/node"
> + "@typescript-eslint/eslint-plugin"
> + "@typescript-eslint/parser"
> + "eslint"
> + "eslint-config-standard"
> + "eslint-config-standard-with-typescript"
> + "eslint-plugin-import"
> + "eslint-plugin-jest"
> + "eslint-plugin-n"
> + "eslint-plugin-promise"
> + "jest"
> + "ts-jest"
> + "tsd"
> + "typescript")))))))
> + (home-page "https://github.com/tj/commander.js")
> + (synopsis "Command line interface for node.js")
> + (description "The complete solution for node.js command-line interfaces.")
Could you please expand a bit on the description? What features does it
have? Keep it factual; "The complete solution ..." sounds like
marketing language.
--
Thanks,
Maxim
Received: (at control) by debbugs.gnu.org; 4 Jan 2024 03:32:09 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 03 22:32:09 2024 Received: from localhost ([127.0.0.1]:53414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rLESn-00063g-Cm for submit <at> debbugs.gnu.org; Wed, 03 Jan 2024 22:32:09 -0500 Received: from mail-qv1-xf2c.google.com ([2607:f8b0:4864:20::f2c]:53674) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>) id 1rLESm-00063H-EC for control <at> debbugs.gnu.org; Wed, 03 Jan 2024 22:32:08 -0500 Received: by mail-qv1-xf2c.google.com with SMTP id 6a1803df08f44-680b1956ca4so529756d6.3 for <control <at> debbugs.gnu.org>; Wed, 03 Jan 2024 19:32:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704339119; x=1704943919; darn=debbugs.gnu.org; h=subject:from:to:message-id:date:from:to:cc:subject:date:message-id :reply-to; bh=Gax3C6qIhSNjoeb7sEZSMjue+Cq8/qsKlzxWBGicoLM=; b=emyw4fssNbg37I2FSOlmYH/C5XbuMEteEzfJn2DI+B9GLjRYC+hBCjs9eiufwFNN8a UH1hKUGE/vQRo9dUZ017YA9v8FJ9t8Kys+jz1dp4ZjwIE4uyhiXaIGvlI8hrT50mQwxZ JTfUyzpYmZM7O+O31mpMFDKT48h5lhlwOFnaT6lwQNOqwJFs5MFZ3VTRPIO7XoktREWt +C2CtS/zjmnVIaajLAvc/LT7WM/wzw4skG8Qk8o/nTuOP4AS35Tgf/UsuicE4Uqkp/nu q2a/MyaxIH1Gl1JjGUenbIfzohaw4weqNZbBhJ0V2ru56q5cm84W0M9C3eijEbmF1XQX bR7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704339119; x=1704943919; h=subject:from:to:message-id:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Gax3C6qIhSNjoeb7sEZSMjue+Cq8/qsKlzxWBGicoLM=; b=h2zjpB/HmWnemkzI+5/vomuO6E2bGM6rQJ8G6p5LnQz/fmkj5Ufdyh5LFFZz+vxk/v qXu+QnZm10h2kbkpWVs9c7gRfh+oJ845YH8PR6iYxtC94KZZ5WuI7snyBWK1GNoAmyNa 9olbpsH3z2mPqQvCeuBoItFsw/5u8/c4lI6xoiNaOGWRdPkCktbDoz7Vs5F1ZFssGciW CuJV2DIm1LB0xw4OYNWsF8Ga90wLGWwc+cC+nVEnH0dUQzPnQ5slELczC7KakHSh9DGp ntpJdIlFie3evPwsRKCac5/DC6LKA91asj/IWqZqo6rfS7WmJyYnHpGPkeEF4AcV6Tio loPg== X-Gm-Message-State: AOJu0YxvG8aLHrABxy2TGSWxPu7brj52zar0RI/264T7a1eeRB64i6SZ l7NCrU3+IJ1FaqB59zrc+k2EZZjDonK8dQ== X-Google-Smtp-Source: AGHT+IGfPs9BdIv4/9Uj5ubwXWBAeOW50R8gJRwp62jyZsrF6Wp4nrGwMyyJkrHT0k+qfJyQd71jog== X-Received: by 2002:a05:6214:1c42:b0:680:3f01:1f1d with SMTP id if2-20020a0562141c4200b006803f011f1dmr67800qvb.126.1704339119116; Wed, 03 Jan 2024 19:31:59 -0800 (PST) Received: from hurd (dsl-10-132-1.b2b2c.ca. [72.10.132.1]) by smtp.gmail.com with ESMTPSA id y14-20020ad445ae000000b0067f986ff8c3sm10441776qvu.35.2024.01.03.19.31.58 for <control <at> debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jan 2024 19:31:58 -0800 (PST) Date: Wed, 03 Jan 2024 22:31:57 -0500 Message-Id: <87a5pl4vv6.fsf@HIDDEN> To: control <at> debbugs.gnu.org From: Maxim Cournoyer <maxim.cournoyer@HIDDEN> Subject: control message for bug #67681 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) tags 67681 + moreinfo quit
X-Loop: help-debbugs@HIDDEN
Subject: [bug#67681] [PATCH] gnu: Add node-commander.
Resent-From: hrn <hrn@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 04 Jan 2024 17:21:02 +0000
Resent-Message-ID: <handler.67681.B67681.170438884111514 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 67681
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch moreinfo
To: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Cc: 67681 <at> debbugs.gnu.org
Received: via spool by 67681-submit <at> debbugs.gnu.org id=B67681.170438884111514
(code B ref 67681); Thu, 04 Jan 2024 17:21:02 +0000
Received: (at 67681) by debbugs.gnu.org; 4 Jan 2024 17:20:41 +0000
Received: from localhost ([127.0.0.1]:55593 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rLROb-0002ze-CI
for submit <at> debbugs.gnu.org; Thu, 04 Jan 2024 12:20:41 -0500
Received: from mout01.posteo.de ([185.67.36.65]:47537)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <hrn@HIDDEN>) id 1rLROY-0002zO-Nw
for 67681 <at> debbugs.gnu.org; Thu, 04 Jan 2024 12:20:39 -0500
Received: from submission (posteo.de [185.67.36.169])
by mout01.posteo.de (Postfix) with ESMTPS id 41B20240028
for <67681 <at> debbugs.gnu.org>; Thu, 4 Jan 2024 18:20:28 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
t=1704388828; bh=kXz6NbeD2UU9AH8RUMIqXxon9U2VPSF1PjtSdUa91s8=;
h=MIME-Version:Content-Transfer-Encoding:Date:From:To:Cc:Subject:
Message-ID:From;
b=Es7UZqPwMaAXDqzAC0YoZqeFvEZhCzmnvgHP+C+PC9pJXhVWi/Lib90sfllheKewT
JgiVmfe9vxXEPOCVlsgqh5gZKNU+sFieK8JP0HuKYUjK9K9NEKI6WKuP5JCsMkm4PP
j9+xsmvvg2rRTsyeaDU3/YqC167L30bgMYW1FHg+Drf4i2F4zS8tQ8weRVT/bBXICn
zQAOYAAv1kOiPCpr4dXQvLFGIO38/aQ2JHSW4iXeHBqTfr8h6vKC+Wn8l2Jadiy56q
7NeXua4grJfRELdl0lDBHcNL+r/3vJQd2E2VA3JZMfqUDNXAUu3t5xlIEH3mQPbNAo
P2z+2ZR0qfxiQ==
Received: from customer (localhost [127.0.0.1])
by submission (posteo.de) with ESMTPSA id 4T5YJC5TQNz6tvk;
Thu, 4 Jan 2024 18:20:27 +0100 (CET)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
format=flowed
Content-Transfer-Encoding: 7bit
Date: Thu, 04 Jan 2024 17:20:27 +0000
From: hrn <hrn@HIDDEN>
In-Reply-To: <87bka14vva.fsf@HIDDEN>
References: <5309647d34306d09dba21177002f96a7d7f39e74.1701937716.git.hrn@HIDDEN>
<87bka14vva.fsf@HIDDEN>
Message-ID: <f7227df7a74dc9fa2d4a1b2cfda896cc@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Hi,
Thanks for reviewing!
> Why is the test suite disabled? A comment (explaining a good reason)
> is
> needed :-).
This is what many node packages in node-xyz.scm does. I think this is
because the tests are difficult to bootstrap. The dependency chains for
the tests
are typically large and circular.
> A comment explaining why these are removed would help.
This is also the norm in node-xyz.scm. The excluded dependencies are for
development and can in many cases be very difficult to bootstrap.
To be able to make progress with packaging node packages it seems to me
that the general strategy has been to disable tests and dependencies
needed for tests. My assumption might be wrong though. Do you still
think I should add comments?
> Could you please expand a bit on the description? What features does
> it
> have? Keep it factual; "The complete solution ..." sounds like
> marketing language.
I agree that this needs to be changed. I blindly copied what the package
said about itself.
Best regards,
Rikard
X-Loop: help-debbugs@HIDDEN
Subject: [bug#67681] [PATCH] gnu: Add node-commander.
Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 06 Jan 2024 19:06:02 +0000
Resent-Message-ID: <handler.67681.B67681.17045679274376 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 67681
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch moreinfo
To: hrn <hrn@HIDDEN>
Cc: 67681 <at> debbugs.gnu.org
Received: via spool by 67681-submit <at> debbugs.gnu.org id=B67681.17045679274376
(code B ref 67681); Sat, 06 Jan 2024 19:06:02 +0000
Received: (at 67681) by debbugs.gnu.org; 6 Jan 2024 19:05:27 +0000
Received: from localhost ([127.0.0.1]:60306 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rMBz5-00018W-B7
for submit <at> debbugs.gnu.org; Sat, 06 Jan 2024 14:05:27 -0500
Received: from mail-qv1-xf2f.google.com ([2607:f8b0:4864:20::f2f]:60798)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <maxim.cournoyer@HIDDEN>) id 1rMBz3-00018H-RD
for 67681 <at> debbugs.gnu.org; Sat, 06 Jan 2024 14:05:26 -0500
Received: by mail-qv1-xf2f.google.com with SMTP id
6a1803df08f44-680adbf077dso6500956d6.1
for <67681 <at> debbugs.gnu.org>; Sat, 06 Jan 2024 11:05:20 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1704567914; x=1705172714; darn=debbugs.gnu.org;
h=mime-version:user-agent:message-id:date:references:in-reply-to
:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=qkscEca5stmcECj4IzeO7WNjvZNZqIth3XUeuAei2sg=;
b=JF0wp15A369qPtggfsaAIXmxmpt/LxLMlAVrA3TKN1QQyqhjJkzrzFWX6wraecPNIA
0smI6Frene3xHTCY08/K9KcR+vtqZ1k13IWCw+vFvu6uZh5qnAxoJ/V/Ghed+bFOl05N
EDN/UzMcWoka6X6HbHYuG3J0E7TnfTOL9JM+ij9sKmdZ7bcOCYk0naQE973zAY9z8MKR
2jxnH+rSBe5auTfnuoQsFOulASTiXFc75+38x4KD5q/Aelwc/LGOvmJqZ3N4weAa8bvk
a3Ej+Ac8ShHcUr9QL0Jp/4XLbLM7dd0C9pH/F9ynS4S5YJAN5ZQiy0rTdvQeI/PdMdMF
LQEg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1704567914; x=1705172714;
h=mime-version:user-agent:message-id:date:references:in-reply-to
:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
:message-id:reply-to;
bh=qkscEca5stmcECj4IzeO7WNjvZNZqIth3XUeuAei2sg=;
b=SMnFHYCsY8xfhGuTQJdHP/koSEd/Li8YzsFtyYEvu4mfiAm40l3CxjSsJdrY4xBXVx
UctPr0Qzngvn+CCbUVZLo5JvLb8WfrsrpR22u6y2Lo61H+HlKG8Fxnzdig36umUqFU5U
uhonhux2BzJFAPwl+47+oPg86eWyL4TLL3o1zSRfdnH87pkM7t4az3pQJRIKqkHde/0I
J7QvSRoXCWIr5pOJkFsMAZ+XTe6S+Rx4d4u6uwbwkPM/gk59hTIIq8r1cStVs8x7neNU
DFi9sdv8yrUJFdEyZDTepx7I5PkjUroh40ajej6QIHbIQHSVrnLnTog/iVCsjraIHHYM
b7ng==
X-Gm-Message-State: AOJu0Yxi8cSzerOp8/kzrEORXDfhfOt+T5fNlLQBsmk5+Qssv5ISFCmb
etDZVISjBKsvI+b4kfxnnz3ILYXPs8w=
X-Google-Smtp-Source: AGHT+IFL4mD5e3EddBd9bcAfz0ihoxGQ0MzOgeCgBJkao1luuNxRg8Ck4Y5TEzJFCR3CL72c5qzZjA==
X-Received: by 2002:a05:6214:400a:b0:680:a4c:275d with SMTP id
kd10-20020a056214400a00b006800a4c275dmr2028946qvb.87.1704567914701;
Sat, 06 Jan 2024 11:05:14 -0800 (PST)
Received: from hurd (dsl-156-75.b2b2c.ca. [66.158.156.75])
by smtp.gmail.com with ESMTPSA id
a14-20020a0562140c2e00b0067f839f073csm1561699qvd.40.2024.01.06.11.05.13
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sat, 06 Jan 2024 11:05:14 -0800 (PST)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
In-Reply-To: <f7227df7a74dc9fa2d4a1b2cfda896cc@HIDDEN> (hrn@HIDDEN's
message of "Thu, 04 Jan 2024 17:20:27 +0000")
References: <5309647d34306d09dba21177002f96a7d7f39e74.1701937716.git.hrn@HIDDEN>
<87bka14vva.fsf@HIDDEN>
<f7227df7a74dc9fa2d4a1b2cfda896cc@HIDDEN>
Date: Sat, 06 Jan 2024 14:05:11 -0500
Message-ID: <871qauz3iw.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Hi,
hrn <hrn@HIDDEN> writes:
> Hi,
>
> Thanks for reviewing!
>
>> Why is the test suite disabled? A comment (explaining a good
>> reason) is
>> needed :-).
>
> This is what many node packages in node-xyz.scm does. I think this is
> because the tests are difficult to bootstrap. The dependency chains
> for the tests
> are typically large and circular.
>
>> A comment explaining why these are removed would help.
>
> This is also the norm in node-xyz.scm. The excluded dependencies are
> for development and can in many cases be very difficult to bootstrap.
>
> To be able to make progress with packaging node packages it seems to
> me that the general strategy has been to disable tests and
> dependencies needed for tests. My assumption might be wrong though. Do
> you still think I should add comments?
OK, this makes sense, but hard to grasp for a newcomer like me to (gnu
packages node-xyz). Perhaps it could be explained in a commentary
comment at the top of the module.
>> Could you please expand a bit on the description? What features
>> does it
>> have? Keep it factual; "The complete solution ..." sounds like
>> marketing language.
>
> I agree that this needs to be changed. I blindly copied what the
> package said about itself.
OK. I look forward to a v2.
--
Thanks,
Maxim
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.