GNU logs - #67710, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#67710: [PATCH] 29.1.50 missing indent rule for parameter list in csharp-ts-mode
Resent-From: Jacob Leeming <jacobtophatleeming@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 08 Dec 2023 14:19:03 +0000
Resent-Message-ID: <handler.67710.B.170204509317671 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 67710 <at> debbugs.gnu.org
MIME-Version: 1.0
From: Jacob Leeming <jacobtophatleeming@HIDDEN>
Date: Fri, 8 Dec 2023 14:12:28 +0000
Message-ID: <CAAVkrVYacSnLpHj-PYJS0sb4-cJWW4Xsxh92V0eHiFGjZE9mFA@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Received-SPF: pass client-ip=2607:f8b0:4864:20::102b;
 envelope-from=jacobtophatleeming@HIDDEN; helo=mail-pj1-x102b.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Mailman-Approved-At: Fri, 08 Dec 2023 09:18:11 -0500
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

From emacs -Q:

evaluate this elisp to set up treesitter for csharp:

(setq treesit-language-source-alist '((c-sharp
"https://github.com/tree-sitter/tree-sitter-c-sharp" "master" "src"))
      treesit-load-name-override-list '((c-sharp
"libtree-sitter-csharp" "tree_sitter_c_sharp"))
      major-mode-remap-alist '((csharp-mode . csharp-ts-mode)))

insert the following text into a csharp-ts-mode buffer:

void ExampleFunction(
    int arg1,
  int arg2,
 int arg3,
int arg4,
    int arg5
)
{
    Console.WriteLine(arg1);
}

Try to indent the parameters of the function with
indent-for-tab-command. Nothing will happen.

This issue can be fixed with the following patch:



diff --git a/lisp/progmodes/csharp-mode.el b/lisp/progmodes/csharp-mode.el
index 53c52e6..8cc4e95 100644
--- a/lisp/progmodes/csharp-mode.el
+++ b/lisp/progmodes/csharp-mode.el
@@ -704,7 +704,8 @@ csharp-ts-mode--indent-rules
      ((parent-is "object_type") parent-bol csharp-ts-mode-indent-offset)
      ((parent-is "enum_body") parent-bol csharp-ts-mode-indent-offset)
      ((parent-is "arrow_function") parent-bol csharp-ts-mode-indent-offset)
-     ((parent-is "parenthesized_expression") parent-bol
csharp-ts-mode-indent-offset))))
+     ((parent-is "parenthesized_expression") parent-bol
csharp-ts-mode-indent-offset)
+     ((parent-is "parameter_list") parent-bol csharp-ts-mode-indent-offset))))

 (defvar csharp-ts-mode--keywords
   '("using" "namespace" "class" "if" "else" "throw" "new" "for"

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Jacob Leeming <jacobtophatleeming@HIDDEN>
Subject: bug#67710: Acknowledgement ([PATCH] 29.1.50 missing indent rule
 for parameter list in csharp-ts-mode)
Message-ID: <handler.67710.B.170204509317671.ack <at> debbugs.gnu.org>
References: <CAAVkrVYacSnLpHj-PYJS0sb4-cJWW4Xsxh92V0eHiFGjZE9mFA@HIDDEN>
X-Gnu-PR-Message: ack 67710
X-Gnu-PR-Package: emacs
X-Gnu-PR-Keywords: patch
Reply-To: 67710 <at> debbugs.gnu.org
Date: Fri, 08 Dec 2023 14:19:03 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 67710 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
67710: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D67710
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#67710: [PATCH] 29.1.50 missing indent rule for parameter list in csharp-ts-mode
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 08 Dec 2023 14:38:03 +0000
Resent-Message-ID: <handler.67710.B67710.170204624820730 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Jacob Leeming <jacobtophatleeming@HIDDEN>
Cc: 67710 <at> debbugs.gnu.org
Date: Fri, 08 Dec 2023 16:37:11 +0200
Message-Id: <83plzgzroo.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <CAAVkrVYacSnLpHj-PYJS0sb4-cJWW4Xsxh92V0eHiFGjZE9mFA@HIDDEN>
 (message from Jacob Leeming on Fri, 8 Dec 2023 14:12:28 +0000)
References: <CAAVkrVYacSnLpHj-PYJS0sb4-cJWW4Xsxh92V0eHiFGjZE9mFA@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

merge 67710 67709
thanks

> From: Jacob Leeming <jacobtophatleeming@HIDDEN>
> Date: Fri, 8 Dec 2023 14:12:28 +0000
> 
> >From emacs -Q:
> 
> evaluate this elisp to set up treesitter for csharp:
> 
> (setq treesit-language-source-alist '((c-sharp
> "https://github.com/tree-sitter/tree-sitter-c-sharp" "master" "src"))
>       treesit-load-name-override-list '((c-sharp
> "libtree-sitter-csharp" "tree_sitter_c_sharp"))
>       major-mode-remap-alist '((csharp-mode . csharp-ts-mode)))
> 
> insert the following text into a csharp-ts-mode buffer:
> 
> void ExampleFunction(
>     int arg1,
>   int arg2,
>  int arg3,
> int arg4,
>     int arg5
> )
> {
>     Console.WriteLine(arg1);
> }
> 
> Try to indent the parameters of the function with
> indent-for-tab-command. Nothing will happen.
> 
> This issue can be fixed with the following patch:
> 
> 
> 
> diff --git a/lisp/progmodes/csharp-mode.el b/lisp/progmodes/csharp-mode.el
> index 53c52e6..8cc4e95 100644
> --- a/lisp/progmodes/csharp-mode.el
> +++ b/lisp/progmodes/csharp-mode.el
> @@ -704,7 +704,8 @@ csharp-ts-mode--indent-rules
>       ((parent-is "object_type") parent-bol csharp-ts-mode-indent-offset)
>       ((parent-is "enum_body") parent-bol csharp-ts-mode-indent-offset)
>       ((parent-is "arrow_function") parent-bol csharp-ts-mode-indent-offset)
> -     ((parent-is "parenthesized_expression") parent-bol
> csharp-ts-mode-indent-offset))))
> +     ((parent-is "parenthesized_expression") parent-bol
> csharp-ts-mode-indent-offset)
> +     ((parent-is "parameter_list") parent-bol csharp-ts-mode-indent-offset))))
> 
>  (defvar csharp-ts-mode--keywords
>    '("using" "namespace" "class" "if" "else" "throw" "new" "for"

This is an exact duplicate of bug#67709.  Merging.

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 8 Dec 2023 14:39:49 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Dec 08 09:39:49 2023
Received: from localhost ([127.0.0.1]:44289 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rBc17-0005VJ-Ht
	for submit <at> debbugs.gnu.org; Fri, 08 Dec 2023 09:39:49 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:39934)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>)
 id 1rBc14-0005Uh-6B; Fri, 08 Dec 2023 09:39:46 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1rBc0l-00089X-7e; Fri, 08 Dec 2023 09:39:27 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=kigmEVyyeecCnwZhHGfejPcgFn2uLEj/dkyq2Bb9zhs=; b=WJP2OV/YbEQ2
 t6p8Z8O4RA0jpEIpuWsI234AjM3MqwrtDVhjGWBHACMY3hRevTF7d5tb++7xEulOI1rTBSzmV5GXc
 hBSaj6K9qg2N7EvYJ8GK7DKHZl1fqxh+1+RsSUfQfzbGHT0SWD2Fbo+L+OQVMGHVzqanwx/r7qyrA
 a+UEMO1rqcXdcVTm60NHGMmiBZJm6C7Y4dcJQvIeudTWUjMoxWie3qSueQWrn1FQCx8KQewFpQBcl
 DncQUgnrw4/iu21fxhjPKOIJ7wMNOz5LYAZTfrgW7v4RBRODcQ3g2jfxzU30udR9yQzTZecHmbtqL
 5SpTIGSV53me63NMr6mHXA==;
Date: Fri, 08 Dec 2023 16:39:42 +0200
Message-Id: <83o7f0zrkh.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Jacob Leeming <jacobtophatleeming@HIDDEN>
In-Reply-To: <CAAVkrVaC7YV__im5amD_DRzZSV-xyCQNzJ3U2NYqYc6ci4HqtA@HIDDEN>
 (message from Jacob Leeming on Fri, 8 Dec 2023 14:30:20 +0000)
Subject: Re: bug#67709:
References: <CAAVkrVZ1rNqFPbJ5w-RxYHLZLj3CTwvYhn1TN=W-i3s565MZEw@HIDDEN>
 <CAAVkrVaC7YV__im5amD_DRzZSV-xyCQNzJ3U2NYqYc6ci4HqtA@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: control
Cc: jacobtophatleeming@HIDDEN, 67709 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

reopen 67709
merge 67710 67709
thanks

> From: Jacob Leeming <jacobtophatleeming@HIDDEN>
> Date: Fri, 8 Dec 2023 14:30:20 +0000
> 
> duplicate of 67710

We don't close duplicates, we merge them.

Last modified: Fri, 8 Dec 2023 14:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.