GNU logs - #67727, boring messages

Message sent to guix-patches@HIDDEN:

Subject: [bug#67727] My first package: libsurvive
Resent-From: Tobias Alexandra Platen <alex@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 09 Dec 2023 14:57:02 +0000
Resent-Message-ID: <handler.67727.B.17021337949615 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 67727 <at> debbugs.gnu.org
Message-ID: <33287c7e32d41871bc7071748a0cc9ecb5592812.camel@HIDDEN>
From: Tobias Alexandra Platen <alex@HIDDEN>
Date: Sat, 09 Dec 2023 13:14:02 +0100
Content-Type: multipart/mixed; boundary="=-Ac8ToVFfWpVUIrUA+X4O"
User-Agent: Evolution 3.46.4-2 
MIME-Version: 1.0
Received-SPF: none client-ip=83.223.95.204;
 envelope-from=alex@HIDDEN; helo=mailout1.hostsharing.net
X-Spam_score_int: -25
X-Spam_score: -2.6
X-Spam_bar: --
X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7,
 RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001,
 SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -0.0 (/)
X-Mailman-Approved-At: Sat, 09 Dec 2023 09:56:27 -0500
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-Ac8ToVFfWpVUIrUA+X4O
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

I've tried to follow the rules documented in[1] and run guix lint and
currenty dont know how to fix the warnings. I made the release and
pushed it to codeberg.

gnu/packages/hardware.scm:1051:6: warning: no valid tags found for
libsurvive
gnu/packages/hardware.scm:1051:6: libsurvive@HIDDEN: updater 'generic-
git' failed to find upstream releases
gnu/packages/hardware.scm:1051:6: libsurvive@HIDDEN: scheduled
Software Heritage archival

[1] https://guix.gnu.org/manual/devel/en/html_node/Contributing.html

--=-Ac8ToVFfWpVUIrUA+X4O
Content-Disposition: attachment; filename="0001-gnu-Add-libsurvive.patch"
Content-Type: text/x-patch; name="0001-gnu-Add-libsurvive.patch"; charset="UTF-8"
Content-Transfer-Encoding: base64

RnJvbSAwZTZjZGE4OTU3ZTRiNGYzNzE4N2RjZGE1Y2FjZTY2NjAyZWI4NDAxIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBUb2JpYXMgUGxhdGVuIDx0cGxhdGVuQHBvc3Rlby5kZT4KRGF0
ZTogU2F0LCA5IERlYyAyMDIzIDEyOjUzOjAwICswMTAwClN1YmplY3Q6IFtQQVRDSCAxLzFdIGdu
dTogQWRkIGxpYnN1cnZpdmUKCi0tLQogZ251L3BhY2thZ2VzL2hhcmR3YXJlLnNjbSB8IDI4ICsr
KysrKysrKysrKysrKysrKysrKysrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCAyOCBpbnNlcnRpb25z
KCspCgpkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL2hhcmR3YXJlLnNjbSBiL2dudS9wYWNrYWdl
cy9oYXJkd2FyZS5zY20KaW5kZXggNTliOTVhYjdjOC4uZmRiZDIxYTAxOCAxMDA2NDQKLS0tIGEv
Z251L3BhY2thZ2VzL2hhcmR3YXJlLnNjbQorKysgYi9nbnUvcGFja2FnZXMvaGFyZHdhcmUuc2Nt
CkBAIC0zOCw2ICszOCw3IEBAIChkZWZpbmUtbW9kdWxlIChnbnUgcGFja2FnZXMgaGFyZHdhcmUp
CiAgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIGFkbWluKQogICAjOnVzZS1tb2R1bGUgKGdu
dSBwYWNrYWdlcyBhdXRvdG9vbHMpCiAgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIGF2YWhp
KQorICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBhbGdlYnJhKQogICAjOnVzZS1tb2R1bGUg
KGdudSBwYWNrYWdlcyBiYXNlKQogICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBiYXNoKQog
ICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBiaXNvbikKQEAgLTEwNDksNiArMTA1MCwzMyBA
QCAoZGVmaW5lLXB1YmxpYyBvcGVuaG1kCiB0ZWNobm9sb2d5LCBzdWNoIGFzIGhlYWQgbW91bnRl
ZCBkaXNwbGF5cyB3aXRoIGJ1aWx0IGluIGhlYWQgdHJhY2tpbmcuIikKICAgICAobGljZW5zZSBs
aWNlbnNlOmJvb3N0MS4wKSkpCiAKKyhkZWZpbmUtcHVibGljIGxpYnN1cnZpdmUKKyAgKHBhY2th
Z2UKKyAgICAobmFtZSAibGlic3Vydml2ZSIpCisgICAgKHZlcnNpb24gIjIwMjMuMTIiKQorICAg
IChzb3VyY2UKKyAgICAgIChvcmlnaW4gOztUT0RPOiBtYWtlIHJlbGVhc2UKKyAgICAgICAgKG1l
dGhvZCBnaXQtZmV0Y2gpCisgICAgICAgICh1cmkgKGdpdC1yZWZlcmVuY2UKKyAgICAgICAgICAg
ICAgKHVybCAiaHR0cHM6Ly9jb2RlYmVyZy5vcmcvTGlicmVWUi9saWJzdXJ2aXZlIikKKyAgICAg
ICAgICAgICAgKHJlY3Vyc2l2ZT8gI3QpCisgICAgICAgICAgICAgIChjb21taXQgInYyMDIzLjEy
LnJjMCIpKSkgOzsgbWFrZSBhIGZpbmFsIHJlbGVhc2UgdGhpcyB5ZWFyCisgICAgICAgIChmaWxl
LW5hbWUgKGdpdC1maWxlLW5hbWUgbmFtZSB2ZXJzaW9uKSkKKyAgICAgICAgKHNoYTI1NiAoYmFz
ZTMyICIwZmtkZ3ZwbTk4N3lsNXE2eXEwOTc5Y2ZqOTlmZmk2azBkcG1kZGxweGZtMnJuZ244NXI1
IikpKSkKKyAgICAoYnVpbGQtc3lzdGVtIGNtYWtlLWJ1aWxkLXN5c3RlbSkKKyAgICAoYXJndW1l
bnRzIChsaXN0ICM6dGVzdHM/ICNmKSkgOzsgbm8gdGVzdHMgaW4gdGhpcyB2ZXJzaW9uCisgICAg
KG5hdGl2ZS1pbnB1dHMKKyAgICAgKGxpc3QgcGtnLWNvbmZpZykpCisgICAgKGlucHV0cworICAg
ICAobGlzdCBoaWRhcGkgZWlnZW4gZXVkZXYpKQorICAgIChob21lLXBhZ2UgImh0dHBzOi8vY29k
ZWJlcmcub3JnL0xpYnJlVlIvbGlic3Vydml2ZSIpCisgICAgKHN5bm9wc2lzICJMaWdodGhvdXNl
IFRyYWNraW5nIGZvciBMaWJyZVZSIikKKyAgICAoZGVzY3JpcHRpb24gIkxpYnN1cnZpdmUgaXMg
YSBzZXQgb2YgdG9vbHMgYW5kIGxpYnJhcmllcyB0aGF0IGVuYWJsZSBMaWdodGhvdXNlCitUcmFj
a2luZyBvbiB2YXJpb3VzIGRldmljZXMsIGluY2x1ZGluZyBIVEMgVml2ZSBhbmQgdGhlIHdlbGwg
a25vd24gVmFsdmUgSW5kZXguCitJdCBjdXJyZW50bHkgc3VwcG9ydHMgYm90aCBTdGVhbVZSIDEu
MCBhbmQgU3RlYW1WUiAyLjAgZ2VuZXJhdGlvbiBvZiBkZXZpY2VzLAorZnV0dXJlIHZlcnNpb25z
IHdpbGwgc3VwcG9ydCBtb3JlIGhhcmR3YXJlIGFuZCB0aGUgc3Vydml2ZV9saW5rIHByb3RvY29s
LiIpCisgICAgKGxpY2Vuc2UgbGljZW5zZTpleHBhdCkpKQorCiAoZGVmaW5lLXB1YmxpYyBvcGVu
cmdiCiAgIChwYWNrYWdlCiAgICAgKG5hbWUgIm9wZW5yZ2IiKQotLSAKMi4zOS4yCgo=


--=-Ac8ToVFfWpVUIrUA+X4O
Content-Disposition: attachment; filename="0000-cover-letter.patch"
Content-Type: text/x-patch; name="0000-cover-letter.patch"; charset="UTF-8"
Content-Transfer-Encoding: base64

RnJvbSAwZTZjZGE4OTU3ZTRiNGYzNzE4N2RjZGE1Y2FjZTY2NjAyZWI4NDAxIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBUb2JpYXMgUGxhdGVuIDx0cGxhdGVuQHBvc3Rlby5kZT4KRGF0
ZTogU2F0LCA5IERlYyAyMDIzIDEzOjAxOjA0ICswMTAwClN1YmplY3Q6IFtQQVRDSCAwLzFdICoq
KiBTVUJKRUNUIEhFUkUgKioqCgoqKiogQkxVUkIgSEVSRSAqKioKClRvYmlhcyBQbGF0ZW4gKDEp
OgogIGdudTogQWRkIGxpYnN1cnZpdmUKCiBnbnUvcGFja2FnZXMvaGFyZHdhcmUuc2NtIHwgMjgg
KysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMSBmaWxlIGNoYW5nZWQsIDI4IGluc2VydGlv
bnMoKykKCgpiYXNlLWNvbW1pdDogNjFmMmQ4NGU3NWMzNDBjMmJhNTI4ZDM5MmY1MjJjNTFiODg0
M2YzNAotLSAKMi4zOS4yCgo=


--=-Ac8ToVFfWpVUIrUA+X4O--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Tobias Alexandra Platen <alex@HIDDEN>
Subject: bug#67727: Acknowledgement (My first package: libsurvive)
Message-ID: <handler.67727.B.17021337949615.ack <at> debbugs.gnu.org>
References: <33287c7e32d41871bc7071748a0cc9ecb5592812.camel@HIDDEN>
X-Gnu-PR-Message: ack 67727
X-Gnu-PR-Package: guix-patches
Reply-To: 67727 <at> debbugs.gnu.org
Date: Sat, 09 Dec 2023 14:57:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 67727 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
67727: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D67727
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to guix-patches@HIDDEN:

Subject: [bug#67727] My first package: libsurvive
References: <33287c7e32d41871bc7071748a0cc9ecb5592812.camel@HIDDEN>
Resent-From: Nicolas Goaziou <mail@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 09 Mar 2025 13:50:02 +0000
Resent-Message-ID: <handler.67727.B67727.174152816813828 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 67727 <at> debbugs.gnu.org
Cc: Tobias Alexandra Platen <alex@HIDDEN>
From: Nicolas Goaziou <mail@HIDDEN>
In-Reply-To: <33287c7e32d41871bc7071748a0cc9ecb5592812.camel@HIDDEN>
Date: Sun, 09 Mar 2025 14:48:56 +0100
Message-ID: <87h6429uwn.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hello,

> +(define-public libsurvive

Thank you!

> +  (package
> +    (name "libsurvive")
> +    (version "2023.12")
> +    (source
> +      (origin ;;TODO: make release
> +        (method git-fetch)
> +        (uri (git-reference
> +              (url "https://codeberg.org/LibreVR/libsurvive")
> +              (recursive? #t)

Can you unbundle whatever is pulled in submodules and avoid using
#:recursive?

> +              (commit "v2023.12.rc0"))) ;; make a final release this year

Nitpick: end of line comments use a single semicolon.

It is also not a good idea to introduce a mismatch between version and
commit. It this situation, you can either use "2023.12.rc0" for version
and (string-append "v" version) for commit, or use a raw commit hash,
bound to `commit' and bind "1" to `revision'. Then, version becomes
(git-version "2023.12" revision commit) and commit is set to=E2=80=A6 commi=
t.

> +        (file-name (git-file-name name version))
> +        (sha256 (base32 "0fkdgvpm987yl5q6yq0979cfj99ffi6k0dpmddlpxfm2rng=
n85r5"))))
> +    (build-system cmake-build-system)
> +    (arguments (list #:tests? #f)) ;; no tests in this version

Same remark as above about semicolon.

> +    (native-inputs
> +     (list pkg-config))
> +    (inputs
> +     (list hidapi eigen eudev))

Please order inputs alphabetically.

> +    (home-page "https://codeberg.org/LibreVR/libsurvive")
> +    (synopsis "Lighthouse Tracking for LibreVR")
> +    (description "Libsurvive is a set of tools and libraries that enable=
 Lighthouse
> +Tracking on various devices, including HTC Vive and the well known Valve=
 Index.
> +It currently supports both SteamVR 1.0 and SteamVR 2.0 generation of dev=
ices,
> +future versions will support more hardware and the survive_link
> protocol.")

Nitpick: @code{survive_link} protocol.

Would you want to send an updated patch?

Regards,
--=20
Nicolas Goaziou

Message sent to guix-patches@HIDDEN:

Subject: [bug#67727] My first package: libsurvive
Resent-From: Tobias Alexandra Platen <alex@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Mon, 10 Mar 2025 00:44:02 +0000
Resent-Message-ID: <handler.67727.B67727.17415674418082 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Nicolas Goaziou <mail@HIDDEN>, 67727 <at> debbugs.gnu.org
Message-ID: <2739466711c968953c9faa8558ed1ee9ecd69bdf.camel@HIDDEN>
From: Tobias Alexandra Platen <alex@HIDDEN>
Date: Sun, 09 Mar 2025 17:05:36 +0100
In-Reply-To: <87h6429uwn.fsf@HIDDEN>
References: <87h6429uwn.fsf@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4-2 
MIME-Version: 1.0
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

On Sun, 2025-03-09 at 14:48 +0100, Nicolas Goaziou wrote:
> Hello,
>=20
> > +(define-public libsurvive
>=20
> Thank you!
>=20
> > +=C2=A0 (package
> > +=C2=A0=C2=A0=C2=A0 (name "libsurvive")
> > +=C2=A0=C2=A0=C2=A0 (version "2023.12")
> > +=C2=A0=C2=A0=C2=A0 (source
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (origin ;;TODO: make release
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (method git-fetch)
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (uri (git-reference
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0 (url "https://codeberg.org/LibreVR/libsurvive")
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0 (recursive? #t)
>=20
> Can you unbundle whatever is pulled in submodules and avoid using
> #:recursive?
>=20
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0 (commit "v2023.12.rc0"))) ;; make a final release
> > this year
>=20
> Nitpick: end of line comments use a single semicolon.
>=20
> It is also not a good idea to introduce a mismatch between version
> and
> commit. It this situation, you can either use "2023.12.rc0" for
> version
> and (string-append "v" version) for commit, or use a raw commit hash,
> bound to `commit' and bind "1" to `revision'. Then, version becomes
> (git-version "2023.12" revision commit) and commit is set to=E2=80=A6 com=
mit.
>=20
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (file-name (git-file-name n=
ame version))
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (sha256 (base32
> > "0fkdgvpm987yl5q6yq0979cfj99ffi6k0dpmddlpxfm2rngn85r5"))))
> > +=C2=A0=C2=A0=C2=A0 (build-system cmake-build-system)
> > +=C2=A0=C2=A0=C2=A0 (arguments (list #:tests? #f)) ;; no tests in this =
version
>=20
> Same remark as above about semicolon.
>=20
> > +=C2=A0=C2=A0=C2=A0 (native-inputs
> > +=C2=A0=C2=A0=C2=A0=C2=A0 (list pkg-config))
> > +=C2=A0=C2=A0=C2=A0 (inputs
> > +=C2=A0=C2=A0=C2=A0=C2=A0 (list hidapi eigen eudev))
>=20
> Please order inputs alphabetically.
>=20
> > +=C2=A0=C2=A0=C2=A0 (home-page "https://codeberg.org/LibreVR/libsurvive=
")
> > +=C2=A0=C2=A0=C2=A0 (synopsis "Lighthouse Tracking for LibreVR")
> > +=C2=A0=C2=A0=C2=A0 (description "Libsurvive is a set of tools and libr=
aries that
> > enable Lighthouse
> > +Tracking on various devices, including HTC Vive and the well known
> > Valve Index.
> > +It currently supports both SteamVR 1.0 and SteamVR 2.0 generation
> > of devices,
> > +future versions will support more hardware and the survive_link
> > protocol.")
>=20
> Nitpick: @code{survive_link} protocol.
>=20
> Would you want to send an updated patch?
yes, but not today. Maybe in one month.
>=20
> Regards,

Last modified: Mon, 10 Mar 2025 00:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.