GNU bug report logs - #67895
[PATCH] build-system/composer: Do not try to delete-duplicates.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 67895 in the body.
You can then email your comments to 67895 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: guix-patches <at> gnu.org
Cc: ludo <at> gnu.org, ngraves <at> ngraves.fr
Subject: [PATCH] build-system/composer: Do not try to delete-duplicates.
Date: Tue, 19 Dec 2023 10:08:47 +0100

* guix/build-system/composer.scm (create-autoload):
Do not use the delete-duplicates function, stale code that should have
been removed in an earlier cleanup.

Change-Id: I778c1cfba7ef8de16a1ba297b583595b391b7e00
---
 guix/build/composer-build-system.scm | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/guix/build/composer-build-system.scm b/guix/build/composer-build-system.scm
index 8896384e0a..8d7d43236e 100644
--- a/guix/build/composer-build-system.scm
+++ b/guix/build/composer-build-system.scm
@@ -191,13 +191,11 @@ (define* (create-autoload vendor composer-file inputs #:key dev-dependencies?)
                (cons* (string-join (string-split key #\\) "\\\\")
                       (append-map (lambda (v) (list vendor v)) vals)))))
            (_ (format #t "")))
-         (delete-duplicates
-          (append
-           (composer-autoload-psr-4 autoload)
-           (if (and dev-dependencies? (not (null? autoload-dev)))
-               (composer-autoload-psr-4 autoload-dev)
-               '()))
-          '()))
+         (append
+          (composer-autoload-psr-4 autoload)
+          (if (and dev-dependencies? (not (null? autoload-dev)))
+              (composer-autoload-psr-4 autoload-dev)
+              '())))
         (for-each
          (lambda (psr0)
            (match psr0
-- 
2.41.0

Message #10 received at 67895-done <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 67895-done <at> debbugs.gnu.org
Cc: Nicolas Graves <ngraves <at> ngraves.fr>
Subject: Re: [PATCH] build-system/composer: Do not try to delete-duplicates.
Date: Fri, 12 Jul 2024 11:10:35 -0500

Applied and tested here:

https://issues.guix.gnu.org/72067

Thanks!
-- 
all the best,
jgart

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.